Re: [PATCH] IBM Z: Fix testcase vcond-shift.c

2021-03-01 Thread Stefan Schulze Frielinghaus via Gcc-patches
On Tue, Mar 02, 2021 at 08:08:14AM +0100, Andreas Krebbel wrote: > On 3/1/21 5:00 PM, Stefan Schulze Frielinghaus wrote: > > As of commit 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1 expressions > > x CMP y ? -1 : 0 are fold into x CMP y. Due to this we do not see > > shifts anymore after expand in

Re: PR analyzer/94362 Partial Fix

2021-03-01 Thread brian.sobulefsky via Gcc-patches
Hi, It may not be worth altering at this point, but it seems like it would leave less bugs open if all the constraints go in as "closed" ranges and all evals are translated to closed intervals. So, if (idx > 0) and if (idx >= 1) are the same constraint. I know this won't be an option for

Re: [PATCH] IBM Z: Fix testcase vcond-shift.c

2021-03-01 Thread Andreas Krebbel via Gcc-patches
On 3/1/21 5:00 PM, Stefan Schulze Frielinghaus wrote: > As of commit 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1 expressions > x CMP y ? -1 : 0 are fold into x CMP y. Due to this we do not see > shifts anymore after expand in our testcases but comparisons. Thus > replace instructions vesraX by

Re: [PATCH] avoid -Wnonull for dynamic_cast (PR 99251)

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 7:44 PM, Martin Sebor wrote: On 3/1/21 1:33 PM, Jason Merrill wrote: On 3/1/21 12:10 PM, Martin Sebor wrote: On 2/24/21 8:13 PM, Jason Merrill wrote: On 2/24/21 5:25 PM, Martin Sebor wrote: In r11-6900 (PR 98646 - static_cast confuses -Wnonnull) we decided that issuing -Wnonnull

Re: PR analyzer/94362 Partial Fix

2021-03-01 Thread David Malcolm via Gcc-patches
On Sat, 2021-02-27 at 10:04 +, brian.sobulefsky wrote: > Hi, > > Please find a patch to fix part of the bug PR analyzer/94362. Thanks. Various comments inline below. > This bug is a > false positive for a null dereference found when compiling openssl. > The cause > is the

Re: [PATCH] c++: ICE with deduction guide in checking type-dep [PR99009, PR97034]

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 7:59 PM, Marek Polacek wrote: On Mon, Mar 01, 2021 at 03:08:58PM -0500, Jason Merrill wrote: On 3/1/21 2:54 PM, Marek Polacek wrote: On Thu, Feb 25, 2021 at 10:45:29PM -0500, Jason Merrill via Gcc-patches wrote: On 2/25/21 5:41 PM, Marek Polacek wrote: On Thu, Feb 25, 2021 at

Re: [PATCH 3/4] c++: Delay normalizing nested requirements until satisfaction

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 6:09 PM, Patrick Palka wrote: On Mon, 1 Mar 2021, Jason Merrill wrote: On 2/28/21 12:40 PM, Patrick Palka wrote: On Fri, 12 Feb 2021, Jason Merrill wrote: On 2/10/21 9:41 AM, Patrick Palka wrote: On Tue, 9 Feb 2021, Jason Merrill wrote: On 2/8/21 2:03 PM, Patrick Palka wrote:

Re: [PATCH 6/6] c++: Consolidate REQUIRES_EXPR evaluation/diagnostic routines

2021-03-01 Thread Jason Merrill via Gcc-patches
On 2/28/21 12:59 PM, Patrick Palka wrote: This folds the diagnose_requires_expr routines into the corresponding tsubst_requires_expr ones. This is achieved by making the latter routines take a sat_info instead of a subst_info, and assigning the appropriate meanings to the flags sat_info::noisy

PING 5 [PATCH] correct fix to avoid false positives for vectorized stores (PR 96963, 94655)

2021-03-01 Thread Martin Sebor via Gcc-patches
Ping 5: https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564059.html On 2/22/21 5:20 PM, Martin Sebor wrote: Ping 4: https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564059.html On 2/14/21 5:43 PM, Martin Sebor wrote: Ping 3:

Re: [PATCH] c++: ICE with deduction guide in checking type-dep [PR99009, PR97034]

2021-03-01 Thread Marek Polacek via Gcc-patches
On Mon, Mar 01, 2021 at 03:08:58PM -0500, Jason Merrill wrote: > On 3/1/21 2:54 PM, Marek Polacek wrote: > > On Thu, Feb 25, 2021 at 10:45:29PM -0500, Jason Merrill via Gcc-patches > > wrote: > > > On 2/25/21 5:41 PM, Marek Polacek wrote: > > > > On Thu, Feb 25, 2021 at 10:59:49AM -0500, Jason

Re: [PATCH] avoid -Wnonull for dynamic_cast (PR 99251)

2021-03-01 Thread Martin Sebor via Gcc-patches
On 3/1/21 1:33 PM, Jason Merrill wrote: On 3/1/21 12:10 PM, Martin Sebor wrote: On 2/24/21 8:13 PM, Jason Merrill wrote: On 2/24/21 5:25 PM, Martin Sebor wrote: In r11-6900 (PR 98646 - static_cast confuses -Wnonnull) we decided that issuing -Wnonnull for dereferencing the result of

Re: [PATCH 2/3 V2] Do not include stdio.h in libgcc's Decimal/Float128 conversions.

2021-03-01 Thread Segher Boessenkool
On Mon, Mar 01, 2021 at 12:18:52PM -0500, Michael Meissner wrote: > The _sprintfkf.c file was including stdio.h to get the definition of sprintf. (declaration of) > This patch modifies this so that stdio.h is not included in order to support > freestanding cross compilers that might not provide

Re: [PATCH] avoid -Warray-bounds checks for vtable assignments (PR 98266)

2021-03-01 Thread Martin Sebor via Gcc-patches
On 2/25/21 4:40 PM, Jeff Law wrote: On 2/8/21 3:44 PM, Martin Sebor wrote: I think the underlying problem is the same.  We're getting a size that doesn't correspond to what's actually being accessed, and it happens because of the virtual inheritance.  In pr97595 Jason suggested to use the

Re: PING [PATCH] avoid -Warray-bounds checks for vtable assignments (PR 98266)

2021-03-01 Thread Martin Sebor via Gcc-patches
On 2/24/21 5:35 PM, Jason Merrill wrote: On 2/23/21 6:07 PM, Martin Sebor wrote: On 2/23/21 2:52 PM, Jason Merrill wrote: On 2/23/21 11:02 AM, Martin Sebor wrote: [CC Jason for any further comments/clarification] On 2/9/21 10:49 AM, Martin Sebor wrote: On 2/8/21 4:11 PM, Jeff Law wrote:

Re: [PATCH 3/4] c++: Delay normalizing nested requirements until satisfaction

2021-03-01 Thread Patrick Palka via Gcc-patches
On Mon, 1 Mar 2021, Jason Merrill wrote: > On 2/28/21 12:40 PM, Patrick Palka wrote: > > On Fri, 12 Feb 2021, Jason Merrill wrote: > > > > > On 2/10/21 9:41 AM, Patrick Palka wrote: > > > > On Tue, 9 Feb 2021, Jason Merrill wrote: > > > > > > > > > On 2/8/21 2:03 PM, Patrick Palka wrote: > > >

Re: [PATCH 5/6] c++: Clean up normalization / satisfaction routines

2021-03-01 Thread Jason Merrill via Gcc-patches
On 2/28/21 12:58 PM, Patrick Palka wrote: This patch mostly performs some straightforward refactoring: - Renamed satisfy_constraint to satisfy_normalized_constraints - Renamed the three-parameter version of satisfy_constraint_expression to satisfy_nondeclaration_constraints -

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thiago Macieira via Gcc-patches
On Monday, 1 March 2021 14:31:09 PST Ville Voutilainen wrote: > On Tue, 2 Mar 2021 at 00:21, Thiago Macieira wrote: > > But the code I posted, if people are careful to use write like I did, > > would > > allow us to have the experimental "we're not sure this is right" > > implementation of

Re: [PATCH 1/3 V2] Fix __sprintfkf prototype in libgcc.

2021-03-01 Thread Segher Boessenkool
On Mon, Mar 01, 2021 at 12:17:34PM -0500, Michael Meissner wrote: > The prototype of __sprintfkf in _sprintfkf.h did not match the function in > _sprintfkf.c. This patch fixes the prototype. I also included the > _sprintfkf.h file in _sprintfkf.c to make sure the prototype is correct and to >

Re: [PATCH 4/4] c++: dependent constraint on placeholder 'auto' [PR96443]

2021-03-01 Thread Jason Merrill via Gcc-patches
On 2/28/21 12:55 PM, Patrick Palka wrote: On Fri, 12 Feb 2021, Jason Merrill wrote: On 2/11/21 5:14 PM, Patrick Palka wrote: On Thu, 11 Feb 2021, Jason Merrill wrote: On 2/8/21 2:03 PM, Patrick Palka wrote: This fixes the way we check satisfaction of constraints on placeholder types in

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Ville Voutilainen via Gcc-patches
On Tue, 2 Mar 2021 at 00:21, Thiago Macieira wrote: > But the code I posted, if people are careful to use write like I did, would > allow us to have the experimental "we're not sure this is right" > implementation of atomic waits, latches, barriers and semaphores right now. The code assumes

[PATCH] [og10] openmp: Scale precision of collapsed iteration variable

2021-03-01 Thread Kwok Cheung Yeung
Hello When two or more nested loops are collapsed using the OpenMP collapse clause, a single iteration variable is used to represent the combined iteration space. In the usual case (i.e. statically scheduled, no ordered clause), the type of this variable is picked by taking the unsigned

Re: [PATCH 3/4] c++: Delay normalizing nested requirements until satisfaction

2021-03-01 Thread Jason Merrill via Gcc-patches
On 2/28/21 12:40 PM, Patrick Palka wrote: On Fri, 12 Feb 2021, Jason Merrill wrote: On 2/10/21 9:41 AM, Patrick Palka wrote: On Tue, 9 Feb 2021, Jason Merrill wrote: On 2/8/21 2:03 PM, Patrick Palka wrote: This sets up the functionality for controlling the initial set of template

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thiago Macieira via Gcc-patches
On Monday, 1 March 2021 14:04:34 PST Ville Voutilainen wrote: > Well, this would be different. What I'm suggesting is not quite that; > for any *new* facility, we'd make sure > that its draft macro and the final IS macro are different, but the > minimum value is the first draft version, > not

*PING* [PATCH] PR libfortran/99218 - [8/9/10/11 Regression] matmul on temporary array accesses invalid memory

2021-03-01 Thread Harald Anlauf via Gcc-patches
Early ping. Harald > Gesendet: Dienstag, 23. Februar 2021 um 22:46 Uhr > Von: "Harald Anlauf" > An: "fortran" , "gcc-patches" > Betreff: [PATCH] PR libfortran/99218 - [8/9/10/11 Regression] matmul on > temporary array accesses invalid memory > > Dear all, > > under certain circumstances a

[Patch, part1] PR fortran/49278 - ICE when combining DATA with default initialization

2021-03-01 Thread Harald Anlauf via Gcc-patches
Dear all, the present PR has two issues. The first one, addressed by this patch, was about accepting invalid code where a variable appeared both in a declaration with PARAMETER as well as in a DATA statement, which could lead to an ICE. We now reject this. (There is a separate issue about

Re: [PATCH] c++: Private parent access check for using decls [PR19377]

2021-03-01 Thread Anthony Sharp via Gcc-patches
Hi all, Here is the patch as promised. Regression tested on the c++ side and everything seems okay. Compiles fine. Sounds good, though strip_using_decl (parent_field) may be overloaded if > the using-decl brings in multiple functions with that name. Could you give my new regression test a

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Ville Voutilainen via Gcc-patches
On Mon, 1 Mar 2021 at 23:54, Thiago Macieira wrote: > But your suggestion does work. We don't need to apply them to all macros, only > those that are new in a given version, like __cpp_lib_atomic_wait or > __cpp_lib_latch in this case. Alternatively, implementations can set the macro > to a given

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thiago Macieira via Gcc-patches
On Monday, 1 March 2021 12:35:05 PST Ville Voutilainen wrote: > I can't make the above code work, in any reasonable manner, because > it's doing feature detection incorrectly. :) > What I can imagine doing, however, is this: > > 1) a published IS always bumps feature-macro values (this won't help

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Ville Voutilainen via Gcc-patches
On Mon, 1 Mar 2021 at 21:44, Thiago Macieira wrote: > But you can see someone doing: > > #if __cplusplus >= 202002L && __has_include() > # include > #else > # error "Please upgrade your compiler & standard library" > #endif > > and using in their inline code. And as you say, if they then mix

Re: [PATCH] avoid -Wnonull for dynamic_cast (PR 99251)

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 12:10 PM, Martin Sebor wrote: On 2/24/21 8:13 PM, Jason Merrill wrote: On 2/24/21 5:25 PM, Martin Sebor wrote: In r11-6900 (PR 98646 - static_cast confuses -Wnonnull) we decided that issuing -Wnonnull for dereferencing the result of dynamic_cast was helpful despite the false

Re: [PATCH] c++: ICE with deduction guide in checking type-dep [PR99009, PR97034]

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 2:54 PM, Marek Polacek wrote: On Thu, Feb 25, 2021 at 10:45:29PM -0500, Jason Merrill via Gcc-patches wrote: On 2/25/21 5:41 PM, Marek Polacek wrote: On Thu, Feb 25, 2021 at 10:59:49AM -0500, Jason Merrill wrote: On 2/12/21 6:12 PM, Marek Polacek wrote: We represent deduction

Re: [PATCH] C++: target attribute - local decl

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 11:59 AM, Martin Liška wrote: On 3/1/21 5:36 PM, Jason Merrill wrote: On 3/1/21 7:43 AM, Martin Liška wrote: On 2/22/21 11:53 PM, Jason Merrill wrote: The problem seems to be with the handling of local decls.  If DECL_LOCAL_DECL_P, you need to look at DECL_LOCAL_DECL_ALIAS to find

Re: [PATCH] c++: ICE with deduction guide in checking type-dep [PR99009, PR97034]

2021-03-01 Thread Marek Polacek via Gcc-patches
On Thu, Feb 25, 2021 at 10:45:29PM -0500, Jason Merrill via Gcc-patches wrote: > On 2/25/21 5:41 PM, Marek Polacek wrote: > > On Thu, Feb 25, 2021 at 10:59:49AM -0500, Jason Merrill wrote: > > > On 2/12/21 6:12 PM, Marek Polacek wrote: > > > > We represent deduction guides with FUNCTION_DECLs, but

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thiago Macieira via Gcc-patches
On Monday, 1 March 2021 10:12:35 PST Ville Voutilainen wrote: > I do have a question about the intent/concern here, regardless of what > your patch technically > does. The ABI break _is_ your concern, and the "heisenbugs" you were > worried about would > in fact be caused by the ABI break? So if

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thomas Rodgers
On 2021-03-01 10:06, Thiago Macieira wrote: On Monday, 1 March 2021 09:38:58 PST Thomas Rodgers wrote: And _M_phase, despite being non-atomic, is never accessed without the atomic_ref, aside from the constructor. Both arrive() and wait() start off by creating the atomic_ref. If it's

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Ville Voutilainen via Gcc-patches
On Mon, 1 Mar 2021 at 20:09, Thiago Macieira via Libstdc++ wrote: > > On Sunday, 28 February 2021 07:05:47 PST Hans-Peter Nilsson wrote: > > On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: > > > ints can be used in futexes. chars can't. > > > > Shouldn't that be an atomic type instead

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thiago Macieira via Gcc-patches
On Monday, 1 March 2021 09:38:58 PST Thomas Rodgers wrote: > > And _M_phase, despite being non-atomic, is never accessed without the > > atomic_ref, aside from the constructor. Both arrive() and wait() start > > off by > > creating the atomic_ref. > > If it's non-atomic, then how is wait()

[PATCH] clarify nonaliasing property of attribute malloc (PR 99295)

2021-03-01 Thread Martin Sebor via Gcc-patches
The documentation change made for pr83023 - branch probabilities pessimize malloc, introduced an ambiguity into the description of attribute malloc pointed out in pr99295. The change suggests that GCC assumes that most calls only to malloc and calloc but not to realloc return non-null.

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thomas Rodgers
Botched replying to the list, sending again On 2021-03-01 09:38, Thomas Rodgers wrote: On 2021-03-01 09:24, Thiago Macieira via Libstdc++ wrote: On Sunday, 28 February 2021 07:05:47 PST Hans-Peter Nilsson wrote: On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: ints can be used in

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thomas Rodgers
On 2021-03-01 09:24, Thiago Macieira via Libstdc++ wrote: On Sunday, 28 February 2021 07:05:47 PST Hans-Peter Nilsson wrote: On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: ints can be used in futexes. chars can't. Shouldn't that be an atomic type instead of a bare int then?

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thiago Macieira via Gcc-patches
On Sunday, 28 February 2021 07:05:47 PST Hans-Peter Nilsson wrote: > On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: > > ints can be used in futexes. chars can't. > > Shouldn't that be an atomic type instead of a bare int then? There are a couple of atomic_refs: using

[PATCH 3/3 V2] Do not build Decimal/Float128 conversions if decimal is disabled.

2021-03-01 Thread Michael Meissner via Gcc-patches
[PATCH 3/3 V2] Do not build Decimal/Float128 conversions if decimal is disabled. This patch suppresses building the Decimal <-> Float128 conversions if the user used --disable-decimal-float when configuring GCC. I have done bootstraps on a little endian power9 system with each of the long double

[PATCH 2/3 V2] Do not include stdio.h in libgcc's Decimal/Float128 conversions.

2021-03-01 Thread Michael Meissner via Gcc-patches
[PATCH 2/3 V2] Do not include stdio.h in libgcc's Decimal/Float128 conversions. The _sprintfkf.c file was including stdio.h to get the definition of sprintf. This patch modifies this so that stdio.h is not included in order to support freestanding cross compilers that might not provide stdio.h.

[PATCH 1/3 V2] Fix __sprintfkf prototype in libgcc.

2021-03-01 Thread Michael Meissner via Gcc-patches
[PATCH 1/3 V2] Fix __sprintfkf prototype in libgcc. The prototype of __sprintfkf in _sprintfkf.h did not match the function in _sprintfkf.c. This patch fixes the prototype. I also included the _sprintfkf.h file in _sprintfkf.c to make sure the prototype is correct and to eliminate a warning

[PATCH 0/3 V2] Honor --disable-decimal-float in PowerPC libgcc _Float128

2021-03-01 Thread Michael Meissner via Gcc-patches
I have broken the patches I submitted on Friday February 26th into 3 patches. These patches allow us to build the libgcc library on PowerPC for VSX systems and optionally enable/disable the Decimal support. If Decimal support is disabled, then the Float128 <-> Decimal conversions are not built.

Re: [PATCH] avoid -Wnonull for dynamic_cast (PR 99251)

2021-03-01 Thread Martin Sebor via Gcc-patches
On 2/24/21 8:13 PM, Jason Merrill wrote: On 2/24/21 5:25 PM, Martin Sebor wrote: In r11-6900 (PR 98646 - static_cast confuses -Wnonnull) we decided that issuing -Wnonnull for dereferencing the result of dynamic_cast was helpful despite the false positives it causes when the pointer is

Re: [PATCH] C++: target attribute - local decl

2021-03-01 Thread Martin Liška
On 3/1/21 5:36 PM, Jason Merrill wrote: On 3/1/21 7:43 AM, Martin Liška wrote: On 2/22/21 11:53 PM, Jason Merrill wrote: The problem seems to be with the handling of local decls.  If DECL_LOCAL_DECL_P, you need to look at DECL_LOCAL_DECL_ALIAS to find the namespace-scope decl.  But then if

Re: [PATCH] C++: target attribute - local decl

2021-03-01 Thread Jason Merrill via Gcc-patches
On 3/1/21 7:43 AM, Martin Liška wrote: On 2/22/21 11:53 PM, Jason Merrill wrote: The problem seems to be with the handling of local decls.  If DECL_LOCAL_DECL_P, you need to look at DECL_LOCAL_DECL_ALIAS to find the namespace-scope decl.  But then if there is no preceding namespace-scope

Re: [PATCH 1/5] std::latch: reduce internal implementation from ptrdiff_t to int

2021-03-01 Thread Thomas Rodgers
On 2021-02-28 13:31, Hans-Peter Nilsson wrote: On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: On Friday, 26 February 2021 11:31:00 PST Andreas Schwab wrote: On Feb 26 2021, Thiago Macieira wrote: On Friday, 26 February 2021 10:14:42 PST Andreas Schwab wrote: On Feb 26 2021,

Re: [PATCH 4/5] barrier: use int instead of unsigned char for the phase state

2021-03-01 Thread Thomas Rodgers
On 2021-02-28 07:05, Hans-Peter Nilsson wrote: On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: ints can be used in futexes. chars can't. Shouldn't that be an atomic type instead of a bare int then? It's an atomic_ref. --- libstdc++-v3/include/std/barrier | 21

Re: add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-03-01 Thread Segher Boessenkool
On Mon, Mar 01, 2021 at 09:46:29AM +0100, Richard Biener wrote: > On Sat, Feb 27, 2021 at 2:43 AM Segher Boessenkool > wrote: > > > > On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote: > > > On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva > > > wrote: > > > > > > > > This patch

[PATCH] IBM Z: Fix testcase vcond-shift.c

2021-03-01 Thread Stefan Schulze Frielinghaus via Gcc-patches
As of commit 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1 expressions x CMP y ? -1 : 0 are fold into x CMP y. Due to this we do not see shifts anymore after expand in our testcases but comparisons. Thus replace instructions vesraX by corresponding vchX. Keep testcases vchX_{lt,gt} where only a

Re: [arm/testsuite]: Skip pr97969.c if -mthumb is not compatible [PR target/97969]

2021-03-01 Thread Christophe Lyon via Gcc-patches
Ping? On Wed, 3 Feb 2021 at 10:01, Christophe Lyon wrote: > > Ping? > I guess that's obvious enough? > > On Wed, 27 Jan 2021 at 10:03, Christophe Lyon > wrote: > > > > Depending on how the toolchain is configured or how the testsuite is > > executed, -mthumb may not be compatible. Like for

[PATCH][pushed] s390: add exceptions for param modified by target pragma

2021-03-01 Thread Martin Liška
There are 4 more exceptions for params that are modified in target pragma. Martin gcc/ChangeLog: PR target/99313 * optc-save-gen.awk: Add 4 more exceptions. gcc/testsuite/ChangeLog: PR target/99313 * gcc.target/s390/target-attribute/pr99313.c: New test. ---

c++: Completeness of typedef structs [PR 99294]

2021-03-01 Thread Nathan Sidwell
When we read in a class definition, we use fixup_type_variants to propagate the now-completed fields of the class's TYPE to other variants. Unfortunately that doesn't propagate all of them, and in this case we had a typedef to an (incomplete) instantiation. That typedef ended up with a

Re: [PATCH] PING implement pre-c++20 contracts

2021-03-01 Thread Jeff Chapman via Gcc-patches
On 1/18/21, Jason Merrill wrote: > On 1/4/21 9:58 AM, Jeff Chapman wrote: >> Ping. re: >> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561135.html >> >> >> https://github.com/lock3/gcc/tree/contracts-jac-alt >>

Patch ping^2

2021-03-01 Thread Jakub Jelinek via Gcc-patches
On Tue, Feb 23, 2021 at 09:49:08AM +0100, Jakub Jelinek via Gcc-patches wrote: > I'd like to ping the > https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565350.html > patch, P2 PR99085 ice-on-valid-code fix in fixup_partitions. Ping Thanks Jakub

Re: [PATCH] C++: target attribute - local decl

2021-03-01 Thread Martin Liška
On 2/22/21 11:53 PM, Jason Merrill wrote: The problem seems to be with the handling of local decls.  If DECL_LOCAL_DECL_P, you need to look at DECL_LOCAL_DECL_ALIAS to find the namespace-scope decl.  But then if there is no preceding namespace-scope declaration, the new decl created by

Re: [PATCH V3 0/5] Support for the CTF and BTF debug formats

2021-03-01 Thread Jose E. Marchesi via Gcc-patches
> - More testing: we are building Gentoo with -gctf activated by > default and fixing problems as we find them. More than 160 packages > built so far.] This count is now 860 packages built ;)

Re: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2021-03-01 Thread Martin Liška
PING On 2/18/21 10:18 AM, Martin Liška wrote: On 2/16/21 10:17 PM, Qing Zhao wrote: Hello, What’s the status of this patch now? Is there any major technical issue with the patch? Our company has been waiting for this patch for almost one year, we need it for our important application.

[Patch] libgfortran: Fix negation for largest integer [PR81986]

2021-03-01 Thread Tobias Burnus
Found by Vittorio Zecca when using the sanitizer on libgomp (bootstrap-ubsan) on pr66311.f90, which uses '(-huge(0_16))-1'. The error then occurs in libgfortran/runtime/string.c's gfc_itoa (GFC_INTEGER_LARGEST n, char *buffer, size_t len) where (as shown 'n') is signed and 't' is:

Re: [PATCH][comitted] Testsuite: Disable PR99149 test on big-endian

2021-03-01 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi All, > > This patch disables the test for PR99149 on Big-endian > where for standard AArch64 the patterns are disabled. > > Regtested on aarch64-none-linux-gnu and no issues. > > Committed under the obvious rule. > > Thanks, > Tamar > > gcc/testsuite/ChangeLog: > >

[PATCH V3 3/5] CTF/BTF testsuites

2021-03-01 Thread Jose E. Marchesi via Gcc-patches
This commit adds a new testsuite for the CTF debug format. 2021-02-18 Indu Bhagat David Faust gcc/testsuite/ * gcc.dg/debug/btf/btf-1.c: New test. * gcc.dg/debug/btf/btf-2.c: Likewise. * gcc.dg/debug/btf/btf-anonymous-struct-1.c: Likewise. *

[PATCH V3 5/5] Enable BTF generation in the BPF backend

2021-03-01 Thread Jose E. Marchesi via Gcc-patches
This patch changes the BPF GCC backend in order to use the DWARF debug hooks and therefore enables the user to generate BTF debugging information with -gbtf. Generating BTF is crucial when compiling BPF programs, since the CO-RE (compile-once, run-everwhere) mechanism used by the kernel BPF

[PATCH V3 4/5] CTF/BTF documentation

2021-03-01 Thread Jose E. Marchesi via Gcc-patches
This commit documents the new command line options introduced by the CTF and BTF debug formats. 2021-02-18 Indu Bhagat * doc/invoke.texi: Document the CTF and BTF debug info options. --- gcc/doc/invoke.texi | 20 1 file changed, 20 insertions(+) diff --git

[PATCH V3 0/5] Support for the CTF and BTF debug formats

2021-03-01 Thread Jose E. Marchesi via Gcc-patches
[Changes from V2: - Rebased to latest master. - Several bug fixes in the CTF support. - Several bug fixes in the BTF support. - New tests for BTF. - Fix a couple of tests in the CTF testsuite. - More testing: we are building Gentoo with -gctf activated by default and fixing problems as we find

[PATCH V3 1/5] Add new function lang_GNU_GIMPLE

2021-03-01 Thread Jose E. Marchesi via Gcc-patches
2021-02-18 Indu Bhagat * langhooks.c (lang_GNU_GIMPLE): New Function. * langhooks.h: New Prototype. --- gcc/langhooks.c | 9 + gcc/langhooks.h | 1 + 2 files changed, 10 insertions(+) diff --git a/gcc/langhooks.c b/gcc/langhooks.c index 2354386f7b4..0082ee9f350 100644

Re: [PATCH 1/5] std::latch: reduce internal implementation from ptrdiff_t to int

2021-03-01 Thread Richard Biener via Gcc-patches
On Sun, Feb 28, 2021 at 10:53 PM Hans-Peter Nilsson wrote: > > > > On Fri, 26 Feb 2021, Thiago Macieira via Gcc-patches wrote: > > > On Friday, 26 February 2021 11:31:00 PST Andreas Schwab wrote: > > > On Feb 26 2021, Thiago Macieira wrote: > > > > On Friday, 26 February 2021 10:14:42 PST Andreas

Re: add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-03-01 Thread Richard Biener via Gcc-patches
On Sat, Feb 27, 2021 at 2:43 AM Segher Boessenkool wrote: > > On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote: > > On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote: > > > > > > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2 > > > tests. Tested on

[PATCH] middle-end/97855 - fix diagnostic with default pretty printer

2021-03-01 Thread Richard Biener
The default diagnostic tree printer relies on dump_generic_node which for some reason manages to clobber the diagnostic pretty-printer state so we see garbled diagnostics like /home/rguenther/src/trunk/gcc/calls.c: In function 'expand_call':

Re: [PATCH] dwarf2unwind : Force the CFA after remember/restore pairs [44107/48097].

2021-03-01 Thread Richard Biener via Gcc-patches
On Fri, Feb 26, 2021 at 11:04 PM Iain Sandoe wrote: > > Hi > > This address one of the more long-standing and serious regressions > for Darwin. GCC emits unwind code by default on the assumption that > the unwinder will be (or have the same capability) as the one in the > current libgcc_s. For

Re: [PATCH] RISC-V: Implment __builtin_thread_pointer

2021-03-01 Thread Matthias Klose
On 7/8/20 9:59 PM, Jim Wilson wrote: > On Tue, Jul 7, 2020 at 2:52 AM Kito Cheng wrote: >> gcc/ChangeLog: >> * gcc/config/riscv/riscv.md (): New. >> (TP_REGNUM): Ditto. >> * doc/extend.texi (Target Builtins): Add RISC-V built-in section. >> Document