[PATCH] tree-optimization/106293 - fix testcase

The following removes a problematic initializer which causes excess diagnostics with -m32 and isn't actually required. Tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/106293 * gcc.dg/tree-ssa/ssa-dse-46.c: Remove long initializer. ---

Re: [committed] libstdc++: Fix deadlock in debug iterator increment [PR108288]

Thanks for fixing this. Here is the extension of the fix to all post-increment/decrement operators we have on _GLIBCXX_DEBUG iterator. I prefer to restore somehow previous implementation to continue to have _GLIBCXX_DEBUG post operators implemented in terms of normal post operators. I also

Re: [PATCH] xtensa: Make instruction cost estimation for size more accurate

On Mon, Jan 9, 2023 at 7:34 PM Takayuki 'January June' Suwa wrote: > > Until now, we applied COSTS_N_INSNS() (multiplying by 4) after dividing > the instruction length by 3, so we couldn't express the difference less > than modulo 3 in insn cost for size (e.g. 11 Bytes and 12 bytes cost the >

[PATCH] ifcvt.cc: Prevent excessive if-conversion for conditional moves

Currently, cond_move_process_if_block() does the conversion without balancing the cost of the converted sequence with the original one, but this should be checked by calling targetm.noce_conversion_profitable_p(). Doing so allows us to provide a way based on the target-specific cost estimate, to

Re: [PATCH] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd

Hi Segher, Thanks for your help to review! Segher Boessenkool writes: > Hi! > > On Tue, Jan 10, 2023 at 09:45:27PM +0800, Jiufu Guo wrote: >> As mentioned in PR108338, on p9, we could use mtvsrws to implement >> the conversion from SI#0 to SF (or lowpart DI to SF). And we find >> we can also

[r13-5092 Regression] FAIL: gcc.dg/tree-ssa/ssa-dse-46.c (test for excess errors) on Linux/x86_64

Hi all, This is the bisect result for the latest regression which fail to send to mailing list. It seems that the mail command in s-nail went down after my machine got upgraded, still investigating why. On Linux/x86_64, 4e0b504f26f78ff02e80ad98ebbf8ded3aa6ffa1 is the first bad commit

Re: [PATCH] libsanitizer/mips: always build with largefile support

On Fri, 6 Jan 2023, YunQiang Su wrote: > -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 is always used for mips > when build libsanitizer in LLVM. Thus >FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 176 : 160, 216); > instead of >FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216); > in

Re: [PATCH v2] bpf: correct bpf_print_operand for floats [PR108293]

> Hi Jose, > > As we discussed on IRC, since we don't currently define > TARGET_SUPPORTS_WIDE_INT it is safer to keep the handling for VOIDmode > CONST_DOUBLEs. My current understanding is that it may be needed if the > host is a 32-bit platform. > > I also added a gcc_unreachable () as you

Re: [PATCH v3 17/19] modula2 front end: dejagnu expect library scripts

Jason Merrill writes: > On 12/6/22 09:47, Gaius Mulley via Gcc-patches wrote: >> Here are the dejagnu expect library scripts for the gm2 >> testsuite. > > A couple of weeks ago I noticed on a testrun that the modula tests > didn't seem to be timing out properly, so I made this change. It >

[PATCH] Fortran: frontend passes do_subscript leaks gmp memory [PR97345]

Dear all, the attached obvious patch fixes a memory leak with gmp variables that are set but apparently (=valgrind) never cleared. No new testcase as the current testsuite gives enough coverage (confirmed by trying a faulty version...) and as per discussion with Steve (see PR). Committed after

Re: [PATCH] longlong.h: Do no use asm input cast for clang

On Tue, 10 Jan 2023, Adhemerval Zanella Netto via Gcc-patches wrote: > That's my original intention [1], but Joseph stated that GCC is the upstream > source of this file. Joseph, would you be ok for a similar patch to glibc > since gcc is reluctant to accept it? I don't think it's a good idea

[PATCH v2] bpf: correct bpf_print_operand for floats [PR108293]

Hi Jose, As we discussed on IRC, since we don't currently define TARGET_SUPPORTS_WIDE_INT it is safer to keep the handling for VOIDmode CONST_DOUBLEs. My current understanding is that it may be needed if the host is a 32-bit platform. I also added a gcc_unreachable () as you pointed out. V2

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

On Mon, Jan 09, 2023 at 10:21:52PM -0500, Michael Meissner wrote: > I had the patches to change the precision to 128, and I just ran them. C and > C++ do not seem to be bothered by changing the precision to 128 (once I got it > to build, etc.). But Fortran on the other hand does actually use the

Re: [PATCH] longlong.h: Do no use asm input cast for clang

On Tue, Jan 10, 2023 at 03:35:37PM +0100, Andreas Schwab wrote: > On Jan 10 2023, Segher Boessenkool wrote: > > > The file starts with > > > > /* longlong.h -- definitions for mixed size 32/64 bit arithmetic. > >Copyright (C) 1991-2022 Free Software Foundation, Inc. > > > >This file is

Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678]

On Tue, Jan 10, 2023 at 04:33:59PM +, Wilco Dijkstra via Gcc-patches wrote: > @@ -1204,10 +1203,15 @@ execute_cfa_program (const unsigned char *insn_ptr, > case DW_CFA_GNU_window_save: > #if defined (__aarch64__) && !defined (__ILP32__) > /* This CFA is multiplexed with Sparc.

Re: Missed lowering to ld1rq from svld1rq for memory operand

On Fri, 5 Aug 2022 at 17:49, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > Following from off-list discussion, in the attached patch, I wrote pattern > > similar to vec_duplicate_reg, which seems to work for the svld1rq > > tests. > > Does it look OK ? > > > >

Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678]

Hi Szabolcs, > i would keep the assert: how[reg] must be either UNSAVED or UNDEFINED > here, other how[reg] means the toggle cfi instruction is mixed with > incompatible instructions for the pseudo reg. > > and i would add a comment about this e.g. saying that UNSAVED/UNDEFINED > how[reg] is used

Re: [PATCH 1/2] libstdc++: Enable string_view in freestanding

Hi Jonathan, Jonathan Wakely writes: > Sorry for the top post. > > -#define __cpp_lib_string_contains 202011L > +#if _GLIBCXX_HOSTED > + // This FTM is not hosted as it also implies matching > support, > + // and is omitted from the freestanding subset. > +# define

Ping^3: [PATCH] d: Update __FreeBSD_version values [PR107469]

Hello, Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html I would like to remind that Gerald Pfeifer already volunteered to commit this patch when it is approved. However the patch has not been approved yet. Thanks, Lorenzo Salvadore > --- Original Message --- >

Re: [PATCH, Modula2] PR-108142 Many empty directories created in the build directory

Jakub Jelinek writes: > On Tue, Jan 10, 2023 at 11:16:28AM +0100, Richard Biener via Gcc-patches > wrote: >> > @@ -424,7 +388,7 @@ override PLUGINCFLAGS := $(filter-out >> > -mdynamic-no-pic,$(PLUGINCFLAGS)) >> > >> > plugin/m2rte$(soext): $(srcdir)/m2/plugin/m2rte.cc >> >

[PATCH] tree-optimization/106293 - missed DSE with virtual LC PHI

Degenerate virtual PHIs can break DSEs fragile heuristic as to what defs it can handle for further processing. The following enhances it to look through degenerate PHIs by means of a worklist, processing the degenerate PHI defs uses to the defs array. The rewrite of virtuals into loop-closed SSA

Re: [PATCH] libatomic: Provide gthr.h default implementation

On 19/12/2022 17:02, Sebastian Huber wrote: Build libatomic for all targets. Use gthr.h to provide a default implementation. If the thread model is "single", then this implementation will not work if for example atomic operations are used for thread/interrupt synchronization. Is this and the

[PATCH] gcc: emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536]

Per http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name: 17$: DW_TAG_formal_parameter_pack DW_AT_name("args") 18$: DW_TAG_formal_parameter ! no DW_AT_name attribute

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

On 1/6/23 14:21, David Malcolm wrote: > On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote: >> Patch can bootstrap on x86_64-linux-gnu and survives regression >> tests. > > Thanks for the patch. > > I noticed that you marked PR 108307 as a dup of this, which covers >

RE: [x86 PATCH] PR rtl-optimization/107991: peephole2 to tweak register allocation.

Hi Richard and Uros, I believe I've managed to reduce a minimal test case that exhibits the underlying problem with reload. The following snippet when compiled on x86-64 with -O2: void ext(int x); void foo(int x, int y) { ext(y - x); } produces the following 5 instructions prior to reload:

Re: [PATCH] longlong.h: Do no use asm input cast for clang

On Jan 10 2023, Segher Boessenkool wrote: > The file starts with > > /* longlong.h -- definitions for mixed size 32/64 bit arithmetic. >Copyright (C) 1991-2022 Free Software Foundation, Inc. > >This file is part of the GNU C Library. > > Please change that first then? GCC is the source

Re: [PATCH 1/2] libstdc++: Enable string_view in freestanding

Sorry for the top post. -#define __cpp_lib_string_contains 202011L +#if _GLIBCXX_HOSTED + // This FTM is not hosted as it also implies matching support, + // and is omitted from the freestanding subset. +# define __cpp_lib_string_contains 202011L +#endif // HOSTED That should say

Re: [PATCH] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd

Hi! On Tue, Jan 10, 2023 at 09:45:27PM +0800, Jiufu Guo wrote: > As mentioned in PR108338, on p9, we could use mtvsrws to implement > the conversion from SI#0 to SF (or lowpart DI to SF). And we find > we can also enhance the conversion from highpart DI to SF (as the > case in this patch). > >

[PING][PATCH] arm: Split up MVE _Generic associations to prevent type clashes [PR107515]

Hi all, With these previous patches: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606586.html https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606587.html we enabled the MVE overloaded _Generic associations to handle more scalar types, however at PR 107515 we found a new

Re: [PATCH] Fix memory constraint on MVE v[ld/st][2/4] instructions [PR107714]

On 12/12/2022 13:42, Kyrylo Tkachov wrote: Hi Stam, -Original Message- From: Stam Markianos-Wright Sent: Friday, December 9, 2022 1:32 PM To: gcc-patches@gcc.gnu.org Cc: Kyrylo Tkachov ; Richard Earnshaw ; Ramana Radhakrishnan ; ni...@redhat.com Subject: [PATCH] Fix memory

Re: [PATCH v2] libstdc++: Fix Unicode codecvt and add tests [PR86419]

On Tue, 10 Jan 2023, 13:43 Dimitrij Mijoski, wrote: > On Tue, 2023-01-10 at 13:28 +, Jonathan Wakely wrote: > > Thanks for the patch. Do you have a copyright assignment for gcc filed > with the FSF? > > > Yes, I have already signed the copyright assignment. > Great, thanks for confirming.

[PATCH] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd

Hi, As mentioned in PR108338, on p9, we could use mtvsrws to implement the conversion from SI#0 to SF (or lowpart DI to SF). And we find we can also enhance the conversion from highpart DI to SF (as the case in this patch). This patch enhances these conversions accordingly. Bootstrap and

Re: [PATCH v2] libstdc++: Fix Unicode codecvt and add tests [PR86419]

On Tue, 2023-01-10 at 13:28 +, Jonathan Wakely wrote: > Thanks for the patch. Do you have a copyright assignment for gcc > filed with the FSF?  Yes, I have already signed the copyright assignment.

Re: [PATCH v2] libstdc++: Fix Unicode codecvt and add tests [PR86419]

On Tue, 10 Jan 2023, 13:00 Dimitrij Mijoski wrote: > Fixes the conversion from UTF-8 to UTF-16 to properly return partial > instead ok. > Fixes the conversion from UTF-16 to UTF-8 to properly return partial > instead ok. > Fixes the conversion from UTF-8 to UCS-2 to properly return partial >

Re: gcc-13/changes.html: Mention -fstrict-flex-arrays and its impact

> On Jan 10, 2023, at 3:06 AM, Richard Biener wrote: > > On Mon, 9 Jan 2023, Qing Zhao wrote: > >> >> >>> On Jan 9, 2023, at 2:11 AM, Richard Biener wrote: >>> >>> On Thu, 22 Dec 2022, Qing Zhao wrote: >>> > On Dec 22, 2022, at 2:09 AM, Richard Biener wrote: >

Re: [PATCH] longlong.h: Do no use asm input cast for clang

Hi! On Tue, Jan 10, 2023 at 09:26:13AM -0300, Adhemerval Zanella Netto wrote: > On 12/12/22 20:52, Segher Boessenkool wrote: > > On Mon, Dec 12, 2022 at 02:10:16PM -0300, Adhemerval Zanella Netto wrote: > > How do you intend to modify all the existing copies of the header that > > haven't been

Re: [committed 1/3] libstdc++: Fix std::span constraint for sizeof(size_t) < sizeof(int) [PR108221]

On Tue, 10 Jan 2023, 12:26 Jakub Jelinek via Libstdc++, < libstd...@gcc.gnu.org> wrote: > On Tue, Jan 10, 2023 at 11:46:55AM +, Jonathan Wakely via Gcc-patches > wrote: > > Tested x86_64-linux. Pushed to trunk. > > > > -- >8 -- > > > > The default constructor has a constraint that is always

[PATCH v2] libstdc++: Fix Unicode codecvt and add tests [PR86419]

Fixes the conversion from UTF-8 to UTF-16 to properly return partial instead ok. Fixes the conversion from UTF-16 to UTF-8 to properly return partial instead ok. Fixes the conversion from UTF-8 to UCS-2 to properly return partial instead error. Fixes the conversion from UTF-8 to UCS-2 to treat

Re: [PATCH] longlong.h: Do no use asm input cast for clang

On 12/12/22 20:52, Segher Boessenkool wrote: > On Mon, Dec 12, 2022 at 02:10:16PM -0300, Adhemerval Zanella Netto wrote: >> On 30/11/22 20:24, Segher Boessenkool wrote: >>> I understand that the casts should be no-ops on the asm side (maybe they >>> change the sign) and they are present as

Re: [committed 1/3] libstdc++: Fix std::span constraint for sizeof(size_t) < sizeof(int) [PR108221]

On Tue, Jan 10, 2023 at 11:46:55AM +, Jonathan Wakely via Gcc-patches wrote: > Tested x86_64-linux. Pushed to trunk. > > -- >8 -- > > The default constructor has a constraint that is always false if > arithmetic on size_t values promotes to int. Rewrite the constraint > exactly as written in

[committed 1/3] libstdc++: Fix std::span constraint for sizeof(size_t) < sizeof(int) [PR108221]

Tested x86_64-linux. Pushed to trunk. -- >8 -- The default constructor has a constraint that is always false if arithmetic on size_t values promotes to int. Rewrite the constraint exactly as written in the standard, which works correctly. libstdc++-v3/ChangeLog: PR libstdc++/108221

[committed 2/3] libstdc++: Fix some algos for 16-bit size_t [PR108221]

Tested x86_64-linux. Pushed to trunk. -- >8 -- Some standard algorithms fail to compile when size_t or ptrdiff_t is narrower than int. The __lg helper function is ambiguous if ptrdiff_t is short or __int20, so replace it with a function template that works for those types as well as

[committed 3/3] libstdc++: Fix tzdb.cc to compile with -fno-exceptions

Tested x86_64-linux. Pushed to trunk. -- >8 -- libstdc++-v3/ChangeLog: * src/c++20/tzdb.cc (tzdb_list::_S_init_tzdb): Use __try and __catch macros for exception handling. --- libstdc++-v3/src/c++20/tzdb.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

OpenMP Patch Ping

Hi all, hello Jakub, Below is the updated list to last ping, https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607178.html NOTE to the list below: I have stopped checking older patches. I know some more are pending review, others need to be revised. I will re-check, once the below listed

[Patch][1/2] OpenMP: Add lang hooks + run-time filled map arrays for Fortran deep mapping of DT

This patches is the ME part to support OpenMP 5.0's deep-mapping feature, i.e. mapping allocatable components of Fortran's derived types automatically. [Not the lang hooks but allocatate-array part will probably also be useful when later adding 'iterator'-modifier support to the 'map'/'to'/'from'

Re: [PATCH] tree-optimization/108314 - avoid BIT_NOT optimization for extract-last

Richard Biener writes: > On Tue, 10 Jan 2023, Richard Sandiford wrote: > >> Richard Biener writes: >> > The extract-last reduction internal function expects the then and >> > else clause as vector and scalar and thus we cannot perform optimization >> > of the inversion of the condition by

Re: [PATCH] tree-optimization/108314 - avoid BIT_NOT optimization for extract-last

On Tue, 10 Jan 2023, Richard Sandiford wrote: > Richard Biener writes: > > The extract-last reduction internal function expects the then and > > else clause as vector and scalar and thus we cannot perform optimization > > of the inversion of the condition by swapping the then/else clauses. > > >

Re: [x86 PATCH] PR rtl-optimization/107991: peephole2 to tweak register allocation.

Uros Bizjak writes: > On Mon, Jan 9, 2023 at 4:01 PM Roger Sayle wrote: >> >> >> This patch addresses PR rtl-optimization/107991, which is a P2 regression >> where GCC currently requires more "mov" instructions than GCC 7. >> >> The x86's two address ISA creates some interesting challenges for

Re: [PATCH, Modula2] PR-108142 Many empty directories created in the build directory

On Tue, Jan 10, 2023 at 11:16:28AM +0100, Richard Biener via Gcc-patches wrote: > > @@ -424,7 +388,7 @@ override PLUGINCFLAGS := $(filter-out > > -mdynamic-no-pic,$(PLUGINCFLAGS)) > > > > plugin/m2rte$(soext): $(srcdir)/m2/plugin/m2rte.cc > > $(GCC_HEADER_DEPENDENCIES_FOR_M2) \ > >

Re: [PATCH] tree-optimization/108314 - avoid BIT_NOT optimization for extract-last

Richard Biener writes: > The extract-last reduction internal function expects the then and > else clause as vector and scalar and thus we cannot perform optimization > of the inversion of the condition by swapping the then/else clauses. > > Bootstrap and regtest running on

Re: [PATCH] c++: Define built-in for std::tuple_element [PR100157]

On Mon, 9 Jan 2023 at 19:25, Patrick Palka wrote: > > On Mon, 9 Jan 2023, Patrick Palka wrote: > > > On Wed, 5 Oct 2022, Patrick Palka wrote: > > > > > On Thu, 7 Jul 2022, Jonathan Wakely via Gcc-patches wrote: > > > > > > > This adds a new built-in to replace the recursive class template > > > >

Re: [PATCH, Modula2] PR-108142 Many empty directories created in the build directory

On Tue, Jan 10, 2023 at 2:49 AM Gaius Mulley via Gcc-patches wrote: > > > PR-108142 Modula-2 configure generates many subdirectories in the top > build directory. This patch dynamically creates subdirectories under > gcc/m2 if and when required. > > Bootstrapped on x86_64 gnu/linux, ok for

Re: [PATCH] PR rtl-optimization/106421: ICE in bypass_block from non-local goto.

On Mon, Jan 9, 2023 at 8:50 PM Roger Sayle wrote: > > > This patch fixes PR rtl-optimization/106421, an ICE-on-valid (but > undefined) regression. The fix, as proposed by Richard Biener, is to > defend against BLOCK_FOR_INSN returning NULL in cprop's bypass_block. > > This patch has been tested

[PATCH 1/2] libstdc++: Enable string_view in freestanding

This enables the default contract handler in freestanding environments, and, of course, provides freestanding users with string_view. libstdc++-v3/ChangeLog: * include/Makefile.am: Install bits/char_traits.h, std/string_view * include/Makefile.in: Regenerate. *

[PATCH 2/2] libstdc++: Fix a few !HOSTED test regressions

libstdc++-v3/ChangeLog: * testsuite/20_util/to_chars/version.cc: Mark hosted-only. * testsuite/20_util/uses_allocator/lwg3677.cc: Ditto. * testsuite/20_util/weak_ptr/cons/self_move.cc: Ditto. * testsuite/std/ranges/adaptors/as_rvalue/1.cc: Replace usage of

Re: [PATCH] bpf: correct bpf_print_operand for floats [PR108293]

Hi David. Thanks for the patch. > diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc > index 2aeaeaf309b..9dde3944e9c 100644 > --- a/gcc/config/bpf/bpf.cc > +++ b/gcc/config/bpf/bpf.cc > @@ -880,13 +880,20 @@ bpf_print_operand (FILE *file, rtx op, int code > ATTRIBUTE_UNUSED) >

[PATCH] tree-optimization/108314 - avoid BIT_NOT optimization for extract-last

The extract-last reduction internal function expects the then and else clause as vector and scalar and thus we cannot perform optimization of the inversion of the condition by swapping the then/else clauses. Bootstrap and regtest running on x86_64-unknown-linux-gnu, OK? Thanks, Richard.

[Committed] IBM zSystems: Make -fcall-saved-... work.

Committed to mainline. Bootstrap and regression tests are clean. gcc/ChangeLog: * config/s390/s390.cc (s390_register_info): Check call_used_regs instead of hard-coding the register numbers for call saved registers. (s390_optimize_register_info): Likewise.

Re: [PATCH] Remove legacy pre-C++ 11 definitions

On 1/9/23 16:19, Jonathan Wakely wrote: > On Mon, 9 Jan 2023 at 15:17, Martin Liška wrote: >> >> On 1/6/23 19:23, Jonathan Wakely wrote: >>> Seems to me that GCC code should just use nullptr directly not redefine >>> NULL. >> >> Sure, but that would lead to a huge patch which would rename NULL

Re: gcc-13/changes.html: Mention -fstrict-flex-arrays and its impact

On Mon, 9 Jan 2023, Qing Zhao wrote: > > > > On Jan 9, 2023, at 2:11 AM, Richard Biener wrote: > > > > On Thu, 22 Dec 2022, Qing Zhao wrote: > > > >> > >> > >>> On Dec 22, 2022, at 2:09 AM, Richard Biener wrote: > >>> > >>> On Wed, 21 Dec 2022, Qing Zhao wrote: > >>> > Hi, Richard,