Re: [nios2, committed] Disable --eh-frame-hdr with -pie or -shared on nios2-linux-gnu

2019-12-08 Thread Sandra Loosemore
On 12/5/19 2:47 PM, Sandra Loosemore wrote: I've checked in this patch to fix a long-standing bug on nios2-linux-gnu that resulted in linker errors like ../nios2-linux-gnu/bin/ld: FDE encoding in /tmp/cccfpQ2l.o(.eh_frame) prevents .eh_frame_hdr table being created when linking with -p

[nios2, committed] Disable --eh-frame-hdr with -pie or -shared on nios2-linux-gnu

2019-12-05 Thread Sandra Loosemore
/ml/binutils/2019-12/msg00013.html -Sandra 2019-12-05 Sandra Loosemore Disable --eh-frame-hdr with -pie or -shared on nios2-linux-gnu. The nios2 ABI doesn't have appropriate relocations to support --eh-frame-hdr with -pie or -shared, so we need to override the default specs

Re: [PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

2019-12-01 Thread Sandra Loosemore
Ping! On 11/13/19 9:27 AM, Sandra Loosemore wrote: This patch series lays some groundwork for the project to redo the OpenACC "kernels" region support in GCC, described in Thomas Schwinge's recent talk at the GNU Cauldron: https://gcc.gnu.org/wiki/cauldron2019talks?action=Att

[PATCH v2, committed] Fix bugs relating to flexibly-sized objects in nios2 backend.

2019-12-01 Thread Sandra Loosemore
is hardly any code that would be affected if we did change the ABI down the road. I plan to backport this patch to the GCC 9 branch but probably not any older branches. -Sandra 2019-12-01 Sandra Loosemore Fix bugs relating to flexibly-sized objects in nios2 backend. PR tar

Re: [PATCH] Don't put objects with flexible array members in small data

2019-11-21 Thread Sandra Loosemore
On 11/21/19 3:59 AM, Richard Sandiford wrote: Sandra Loosemore writes: This patch is for PR target/92499, a bug reported by GLIBC maintainers against nios2 target. The initial failure symptom was a linker error resulting from use of GP-relative addressing on an object that wasn't allocat

[PATCH] Don't put objects with flexible array members in small data

2019-11-20 Thread Sandra Loosemore
n nios2-elf and nios2-linux-gnu. I'm not set up to test any of the other affected back ends, but the code change is trivial and identical to what I did for nios2. OK to commit? I'd like to backport this patch to all active branches as well, once it is in on trunk. -Sandra 2019-11-20 S

[PATCH 1/2] Move loop and switch tree data structures from cp/ to c-family/.

2019-11-13 Thread Sandra Loosemore
similar OMP constructs is also moved. 2019-11-12 Sandra Loosemore gcc/c-family/ * c-common.c (c_block_may_fallthrough): New, split from cxx_block_may_fallthrough in the cp front end. (c_common_init_ts): Move handling of loop and switch-related statements

[PATCH 2/2] Change C front end to emit structured loop and switch tree nodes.

2019-11-13 Thread Sandra Loosemore
2019-11-12 Sandra Loosemore gcc/c * c-decl.c (c_break_label, c_cont_label): Delete, and replace with... (in_statement): New. (start_function): Adjust for above change. (c_push_function_context, c_pop_function_context): Likewise. * c

[PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

2019-11-13 Thread Sandra Loosemore
the same goto form that the C front end formerly emitted instead of the C++-style output, but that might just be papering over bugs elsewhere. Any advice on how to proceed here is welcome. If the patches are OK otherwise, maybe just file bugzilla issues for these regressions? -Sandra Sandra Loos

Re: [PATCH][DOC] Document -fallocation-dce.

2019-11-13 Thread Sandra Loosemore
On 11/13/19 6:45 AM, Martin Liška wrote: Hi. The patch is about a documentation entry for a newly added option in GCC 10. Ready for trunk? I thought this would be OK, until I saw: +Enabled by default. At the beginning of invoke.texi where it is talking about options having both -foo and

Re: [PATCH] Fix description of -fcommon

2019-10-20 Thread Sandra Loosemore
On 10/20/19 11:14 AM, Bernd Edlinger wrote: Hi, I've noticed that the description of -fcommon that gets printed with "gcc -v --help" is exactly the opposite of what this option actually does. With -fcommon, different global variables w/o initial value are plced in common blocks, similar to fort

Re: [PATCH] Fix PR c++/92024

2019-10-12 Thread Sandra Loosemore
On 10/12/19 12:10 PM, Bernd Edlinger wrote: [snip snip] So instead I'd like to adjust the doc of -Wshadow to reflect the implementation and remove the if(warn_shadow_local) to have C and C++ behave identical and hopefully now in sync with the doc. Bootstrapped and reg-tested on x86_64-pc-linu

Re: [PATCH] Come up with ipa passes introduction in gccint documentation

2019-10-10 Thread Sandra Loosemore
On 10/9/19 1:20 AM, Jan Hubicka wrote: On Tue, Oct 8, 2019 at 10:06 PM Sandra Loosemore wrote: On 10/8/19 2:52 AM, luoxhu wrote: Hi, This is the formal documentation patch for IPA passes. Thanks. None of the IPA passes are documented in passes.texi. This patch adds a section IPA passes

Re: [PATCH] Come up with ipa passes introduction in gccint documentation

2019-10-08 Thread Sandra Loosemore
On 10/8/19 2:52 AM, luoxhu wrote: Hi, This is the formal documentation patch for IPA passes. Thanks. None of the IPA passes are documented in passes.texi. This patch adds a section IPA passes just before GIMPLE passes and RTL passes in Chapter 9 "Passes and Files of the Compiler". Also, a s

Re: [PATCH] Update documentation of -Wshadow

2019-10-06 Thread Sandra Loosemore
On 10/3/19 9:16 AM, Bernd Edlinger wrote: Hi, I've noticed that the documentation of -Wshadow=x has some missing bits, and I want to add an negative example to -Wshadow=compatble-local. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. Is it OK for trunk? Index: gcc/doc/invoke.texi =

Re: [obvious, PATCH 4/3][doc] -Wuninitialized doesn't do -Wclobbered's job

2019-10-06 Thread Sandra Loosemore
On 10/3/19 9:12 AM, Vladislav Ivanishin wrote: Oh, and this old documentation bug. (AFAICT this is a historical artifact from the pre-tree-ssa times when both -Wclobbered and -Wuninitialized were implemented on RTL.) This one is actually independent of the others and, I believe, is obvious enou

Re: [patch, testsuite, arm] Fix ICE in gcc.dg/gimplefe-28.c

2019-09-22 Thread Sandra Loosemore
On 9/20/19 2:18 AM, Kyrill Tkachov wrote: Yeah, an add_options_for_arm_vfp is what we ideally need here. How about this version of the patch? The two test cases I also tweaked to use it are the only ones that use the corresponding arm_vfp_ok effective target. -Sandra 2019-09-22 Sandra

Re: [patch, testsuite, arm] Fix ICE in gcc.dg/gimplefe-28.c

2019-09-19 Thread Sandra Loosemore
On 9/19/19 2:40 AM, Kyrill Tkachov wrote: Index: gcc/testsuite/lib/target-supports.exp === --- gcc/testsuite/lib/target-supports.exp    (revision 275699) +++ gcc/testsuite/lib/target-supports.exp    (working copy) @@ -6670,6 +6670,9

[testsuite, obvious] Remove explicit "dg-do run" from g++.dg/vect/pr87914.cc

2019-09-14 Thread Sandra Loosemore
I found another instance of PR testsuite/83889 in the g++ testsuite. I've committed the attached patch to fix it in the same way as all the others. -Sandra 2019-09-14 Sandra Loosemore PR testsuite/83889 gcc/testsuite/ * g++.dg/vect/pr87914.cc: Remove explicit dg-do run. Index

[patch, testsuite, arm] Fix ICE in gcc.dg/gimplefe-28.c

2019-09-13 Thread Sandra Loosemore
e options when building this testcase. :-S The hook to do this is already there; it just needs a case for arm. OK to commit? -Sandra 2019-09-13 Sandra Loosemore gcc/testsuite/ * lib/target-supports.exp (add_options_for_sqrt_insn): Add arm options consistent with check_effective_target_

[PATCH testsuite, arm] cache fp16 hw effective-target tests

2019-09-13 Thread Sandra Loosemore
e test run anyway. ;-) Anyway, test results are the same with this patch, they just run faster. OK to commit? -Sandra 2019-09-13 Sandra Loosemore gcc/testsuite/ * lib/target-supports.exp (check_effective_target_arm_neon_fp16_hw) (check_effective_target_arm_fp16_hw): Use check_runtime

[testsuite, obvious] Remove explicit "dg-do run" from more gcc.dg/vect tests

2019-09-11 Thread Sandra Loosemore
hat doesn't support those instructions). I've applied the same trivial fix as in the original patch. I thought this was obvious enough that I went ahead and committed it. -Sandra 2019-09-11 Sandra Loosemore PR testsuite/83889 gcc/testsuite/ * gcc.dg/vect/pr81740-2.c: Remove explici

Re: [doc PATCH] document variable attribute alias

2019-08-05 Thread Sandra Loosemore
On 8/5/19 4:43 PM, Martin Sebor wrote: On 8/4/19 9:45 PM, Sandra Loosemore wrote: [snip] OK with that fixed. Done in r274127. Since people tend to refer to the manual for older versions of the compiler I'd like to make this change on supported release branches as well.  If you se

Re: [doc PATCH] document variable attribute alias

2019-08-04 Thread Sandra Loosemore
On 7/31/19 5:05 PM, Martin Sebor wrote: It was pointed out recently in another forum that GCC doesn't document attribute alias for variables.  It was also noted in the same discussion that the semantics of accessing aliases and their targets can have "surprising" effects because GCC (as do other

Re: [PATCH] Add -fprofile-note option.

2019-07-08 Thread Sandra Loosemore
On 7/8/19 11:43 AM, Martin Liška wrote: @@ -12407,7 +12407,9 @@ To optimize the program based on the collected profile information, use @item -fprofile-note=@var{path} @opindex fprofile-note -If @var{path} is specified, GCC saves gcno filename into @var{path} location. +If @var{path} is sp

Re: [PATCH] Add -fprofile-note option.

2019-07-03 Thread Sandra Loosemore
On 7/2/19 6:37 AM, Martin Liška wrote: @@ -12403,6 +12403,11 @@ the profile feedback data files. See @option{-fprofile-dir}. To optimize the program based on the collected profile information, use @option{-fprofile-use}. @xref{Optimize Options}, for more information. +@item -fprofile-note=

Re: [PATCH][ARM] Add support for "noinit" attribute

2019-07-01 Thread Sandra Loosemore
On 6/13/19 9:13 AM, Christophe Lyon wrote: @@ -7131,6 +7132,18 @@ given via attribute argument. @end table +@node ARM Variable Attributes +@subsection ARM Variable Attributes + +@table @code +@item noinit +@cindex @code{noinit} variable attribute, ARM +Any data with the @code{noinit} attrib

Re: Incremental LTO linking part 7: documentation

2019-07-01 Thread Sandra Loosemore
only documented in the internals manual, etc. I've finally decided I should just commit this piece as-is to get it out of my tree; it's an incremental improvement, anyway. -Sandra 2019-07-01 Sandra Loosemore gcc/ * doc/invoke.texi (Link Options): Further editorial changes to

[patch, testsuite] make g++.dg/ipa/pr89009.C require fpic effective target

2019-04-20 Thread Sandra Loosemore
I've checked in the attached patch as obvious, to clean up some test failures on nios2-elf. (The nios2 PSABI only defines PIC relocations for GNU/Linux targets so gcc rejects -fpic when compiling for bare-metal target.) -Sandra 2019-04-20 Sandra Loosemore gcc/testsuite/ * g++.d

Re: [PATCH, doc] Note variable shadowing at max macro using statement expression

2019-04-11 Thread Sandra Loosemore
On 4/11/19 2:31 AM, Tom de Vries wrote: Hi Sandra, thanks for the review. I've attached the updated patch, as well as the resulting relevant gcc.info portion. OK for trunk? This version looks OK. Thanks for helping to improve the docs! -Sandra

Re: [PATCH] Clearly document behaviour of multiple -g options

2019-04-10 Thread Sandra Loosemore
On 4/10/19 5:18 AM, Jonathan Wakely wrote: This copies the wording from the -O options to clearly state what happens if more than one -g option is used. * doc/invoke.texi (Debugging Options): Explicitly state the semantics of using multiple -g options. OK for trunk? Looks fine to me

Re: [RFC, doc] Note variable shadowing at max macro using statement expression

2019-04-09 Thread Sandra Loosemore
On 4/8/19 5:38 AM, Tom de Vries wrote: Hi, When suggesting to rewrite the unsafe (with respect to multiple evaluation of arguments) macro definition: ... #define max(a,b) ((a) > (b) ? (a) : (b)) ... into the safe macro definition: ... #define maxint(a,b) \ ({int _a = (a), _b = (b); _a

Re: [PATCH, GCC, DOCS, AArch64] Add missing documenation for mbranch-protection

2019-04-02 Thread Sandra Loosemore
On 4/2/19 6:45 AM, Sudakshina Das wrote: Hi This patch add the missing documentation bits for -mbranch-protection in both extend.texi and invoke.texi. Is this ok for trunk? diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index ef7adb6a9c0fe1abd769e237fd8d0ce4c614aef8..7e1c28182138aeba1

Re: [PATCH] document vector_size type attribute

2019-03-25 Thread Sandra Loosemore
On 3/25/19 9:13 AM, Martin Sebor wrote: On 3/24/19 8:00 PM, Sandra Loosemore wrote: On 3/22/19 10:58 AM, Martin Sebor wrote: Attribute vector_size applies to types as much as it does to variables but is only documented for the latter.  Attached is an update to the manual to document the

Re: [PATCH] document vector_size type attribute

2019-03-24 Thread Sandra Loosemore
On 3/22/19 10:58 AM, Martin Sebor wrote: Attribute vector_size applies to types as much as it does to variables but is only documented for the latter.  Attached is an update to the manual to document the attribute's effects in type definitions. This is OK to check in. Separately, I wish we cou

Re: [wwwdocs] My changes to gcc-9/changes.html

2019-03-18 Thread Sandra Loosemore
On 3/18/19 9:48 AM, Gerald Pfeifer wrote: On Mon, 18 Mar 2019, David Malcolm wrote: Here's a patch for the website to add my changes for GCC 9 (bearing a strong resemblance to my recent blog post) Wow, that. is. a. lot! :-) -Porting to GCC 8 page and the +Porting to GCC 9 page and the Good

Re: [wwwdocs] add gcc 9 changes

2019-03-17 Thread Sandra Loosemore
On 3/4/19 5:28 PM, Martin Sebor wrote: Attached is a patch with (mostly) my changes for GCC 9.  To make things easier to find I grouped related changes together within the sections I changed.  I put warnings under the same bullet, built-ins, and attributes. I have a few nit-picky comments... s

[doc, committed] fix PR c/80409

2019-02-25 Thread Sandra Loosemore
I've checked in this patch to document the GNU extension to va_arg for pointer types, which is really a POSIX extension per discussion in the issue. -Sandra 2019-02-25 Sandra Loosemore PR c/80409 gcc/ * doc/extend.texi (Variadic Pointer Args): New section. Index: gcc/doc/extend

Re: [ping] [PATCH doc] correct/improve -Wmissing-attributes and -Wattribute-alias

2019-02-24 Thread Sandra Loosemore
On 2/15/19 6:57 PM, Sandra Loosemore wrote: On 2/6/19 9:16 AM, Martin Sebor wrote: The manual documents the -Wno-missing-attributes form of the option as if it was enabled by default, even though it's enabled by -Wall (I can't get this -Wno- convention straight in my head).  I also g

Re: [PATCH] document __builtin_is_constant_evaluated

2019-02-19 Thread Sandra Loosemore
On 2/18/19 11:52 AM, Martin Sebor wrote: Index: gcc/doc/extend.texi === --- gcc/doc/extend.texi (revision 268992) +++ gcc/doc/extend.texi (working copy) @@ -12890,6 +12890,23 @@ built-in in this case, because it has no opportuni opt

Re: [PATCH] document __builtin_is_constant_evaluated

2019-02-15 Thread Sandra Loosemore
On 2/13/19 4:33 PM, Martin Sebor wrote: Index: gcc/doc/extend.texi === --- gcc/doc/extend.texi (revision 268856) +++ gcc/doc/extend.texi (working copy) @@ -12890,6 +12890,22 @@ built-in in this case, because it has no opportuni opt

Re: [PATCH] document __has_attribute and __has_include

2019-02-15 Thread Sandra Loosemore
On 2/13/19 2:46 PM, Martin Sebor wrote: The attached patch adds documentation for the __has_attribute (and __has_cpp_attribute) and __has_include operators added in r215752. Thanks! I was a little unsure where to add this, whether the preprocessor manual or the GCC manual, or both.  It seems

Re: [PATCH doc] correct/expand -Wreturn-type

2019-02-15 Thread Sandra Loosemore
On 2/6/19 11:15 AM, Martin Sebor wrote: [snip] But whatever.  Attached is a change with the subsentences reversed. This version of the patch is OK. -Sandra

Re: [PATCH doc] correct/improve -Wmissing-attributes and -Wattribute-alias

2019-02-15 Thread Sandra Loosemore
there are typos, awkward wording and confusing paragraph organization, etc. So I consulted the sources and came up with the attached alternative patch. Can you review this for correctness and generally making sense? -Sandra 2019-02-15 Sandra Loosemore Martin Sebor gcc/ * c-fa

undefined references to mkdir, etc in libstdc++ testing

2019-01-24 Thread Sandra Loosemore
On 1/24/19 1:20 PM, Jonathan Wakely wrote: On 24/01/19 11:53 -0700, Sandra Loosemore wrote: BTW, I'm more worried about the link errors introduced by the patch for PR 86756.  Those are regressions and apparently a problem that could affect user code, not just broken test cases for half-

Re: [testsuite, rfa] Add gthreads dependency to some failing libstdc++ tests

2019-01-24 Thread Sandra Loosemore
On 1/24/19 3:46 AM, Jonathan Wakely wrote: On 23/01/19 12:50 -0700, Sandra Loosemore wrote: I ran libstdc++ tests on nios2-elf target.  I observed several new tests failing with error: 'mutex' in namespace 'std' does not name a type The definition of class mutex in incl

[testsuite, rfa] Add gthreads dependency to some failing libstdc++ tests

2019-01-23 Thread Sandra Loosemore
ese tests are not supposed to work on this target. This patch adds the equivalent dependency to the failing tests. OK to commit? (I guess it is possible that this is actually a bug in the code instead, and the tests are supposed to pass) -Sandra 2019-01-23 Sandra Loosemore libstdc++

[testsuite, committed] require fpic effective target for tests with -fpic

2019-01-22 Thread Sandra Loosemore
ch is how I've handled this problem in the past. -Sandra 2019-01-22 Sandra Loosemore gcc/testsuite/ * g++.dg/lto/pr87906_0.C: Add dg-require-effective-target fpic. * g++.dg/vec-init-1.C: Likewise. * gcc.dg/pr87793.c: Likewise. Index: gcc/testsuite/g+

[testsuite, committed] fix tests requiring -fdelete-null-pointer-checks

2019-01-22 Thread Sandra Loosemore
g for this target by making the option explicit on those tests. FWIW, for these tests I was seeing a compilation error like "e != 0 is not a constant expression". -Sandra 2019-01-22 Sandra Loosemore gcc/testsuite/ * g++.dg/cpp0x/pr86397-1.C: Add -fdelete-null-pointer-checks.

Re: [patch, rfa] Fix PR other/16615, change "can not" to "cannot" throughout docs and code

2019-01-08 Thread Sandra Loosemore
On 12/31/18 4:23 PM, Joseph Myers wrote: On Fri, 28 Dec 2018, Sandra Loosemore wrote: Taken individually, all these changes probably qualify as obvious, but given how extensive they are and how many files are touched, I thought it would be good to get a sanity check on methodology before

Re: Add forgotten options to -fprofile-use

2019-01-07 Thread Sandra Loosemore
On 1/6/19 9:47 AM, Jan Hubicka wrote: Index: doc/invoke.texi === --- doc/invoke.texi (revision 267603) +++ doc/invoke.texi (working copy) @@ -9499,6 +9499,8 @@ DO I = 1, N D(I) = E(I) * F ENDDO @end smallexample +Th

[patch, rfa] Fix PR other/16615, change "can not" to "cannot" throughout docs and code

2018-12-28 Thread Sandra Loosemore
a sanity check on methodology before checking in the whole pile. E.g. are there other files that should be excluded from the recipe for part 1? I did some light testing on x86_64-linux-gnu (I'm not set up to build all the language front ends, but C and C++ bootstrap and regression-test

Re: V8 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-12-18 Thread Sandra Loosemore
On 12/18/18 2:12 PM, H.J. Lu wrote: diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index ac2ee59d92c..47f2fc3f518 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -358,6 +358,7 @@ Objective-C and Objective-C++ Dialects}. -Wuseless-cast -Wvariadic-macros -Wvector-operation

Re: [doc,committed] clarify docs for function attribute "const"

2018-12-13 Thread Sandra Loosemore
On 12/13/18 3:52 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00426.html (I have now committed the @code{const} cleanup mentioned below.) This patch is OK except for one nit. @cindex pointer arguments Note that a function that has pointer arguments and examin

Re: [doc PATCH] update attribute docs for C++

2018-12-11 Thread Sandra Loosemore
On 12/5/18 10:14 AM, Martin Sebor wrote: On 12/4/18 8:49 PM, Sandra Loosemore wrote: What is the "it" referenced in the user's questions you quoted?  The const/pure attributes?  Those are function attributes.  The text you are adding is in the type attribute section, so it see

Re: [PATCH 1/9]: C++ P0482R5 char8_t: Documentation updates

2018-12-11 Thread Sandra Loosemore
On 11/5/18 12:39 PM, Tom Honermann wrote: This patch adds documentation for new -fchar8_t and -fno-char8_t options. gcc/ChangeLog: 2018-11-04  Tom Honermann  * doc/invoke.texi (-fchar8_t): Document new option. My comments are all about nitpicky formatting things. diff --git a/gcc/do

Re: [doc PATCH] update attribute docs for C++

2018-12-04 Thread Sandra Loosemore
On 12/4/18 8:13 PM, Martin Sebor wrote: On 12/4/18 2:04 PM, Sandra Loosemore wrote: On 12/4/18 9:26 AM, Martin Sebor wrote: [snip] +The keyword @code{__attribute__} allows you to specify various special +properties of types.  Some type attributes apply only to structure and +union types, and

Re: [doc PATCH] update attribute docs for C++

2018-12-04 Thread Sandra Loosemore
On 12/4/18 9:26 AM, Martin Sebor wrote: Thanks for the comments.  Attached is an updated patch with the typos fixed.  I've left the rest as is. Well, I still think a number of points I commented on before need to be clarified in the text. If I'm confused, I think other readers will be, too,

Re: [doc PATCH] document when GCC ignores attribute aligned

2018-12-03 Thread Sandra Loosemore
On 12/3/18 8:23 PM, Martin Sebor wrote: Last week we agreed to clarify that attribute aligned on a function can decrease its alignment if it hasn't been previously declared with one.  Attached is this change. Besides the above, I also mention that the attribute specifies the alignment of the fir

Re: [doc PATCH] update attribute docs for C++

2018-12-03 Thread Sandra Loosemore
On 12/3/18 4:23 PM, Martin Sebor wrote: gcc/ChangeLog: * doc/extend.texi (attribute const, pure): Clarify. Index: gcc/doc/extend.texi === --- gcc/doc/extend.texi (revision 266766) +++ gcc/doc/extend.texi (working copy) @@

Re: [doc,committed] clarify docs for function attribute "const"

2018-12-03 Thread Sandra Loosemore
On 12/3/18 2:47 PM, Martin Sebor wrote: [snip] Attached is my proposed update.  The user's email suggested going into a lot of detail that I'm not sure would be helpful.  I think it's safer to keep it simple than to try to carefully outline tricky conditions under which some const or pure functi

Re: [doc, rfc] document __builtin_setjmp and __builtin_longjmp

2018-12-01 Thread Sandra Loosemore
On 12/1/18 2:27 AM, Andreas Schwab wrote: On Nov 30 2018, Sandra Loosemore wrote: +@code{__builtin_setjmp} and @code{__builtin_longjmp} use GCC's normal Please avoid starting the sentence with a non-capital. OK, I can fix that easily enough. I was really looking more for commen

[doc, rfc] document __builtin_setjmp and __builtin_longjmp

2018-11-30 Thread Sandra Loosemore
I have written a new patch for PR 59039 to address more of the comments there, as well as my own complaints about the draft patch attached to the issue. I'd like to get some feedback on this one before I commit it. -Sandra 2018-11-30 Sandra Loosemore PR c/59039 gcc/ * doc/extend

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Sandra Loosemore
On 11/26/18 10:59 AM, Martin Sebor wrote: Martin suggested we update the Coding Conventions to describe the expected style for function declarations with a pointer return types, and for overloaded operators.  Below is the patch. As an aside, regarding the space convention in casts: a crude grep

Re: [doc,committed] clarify docs for function attribute "const"

2018-11-26 Thread Sandra Loosemore
On 11/26/18 8:32 PM, Martin Sebor wrote: On 11/26/18 11:13 AM, Sandra Loosemore wrote: On 11/26/18 10:17 AM, Martin Sebor wrote: On 11/25/18 6:40 PM, Sandra Loosemore wrote: I've checked in the attached patch for PR79738. I think we have lost something important with the clarificati

[doc, committed] document that -freorder-functions also uses hot/cold attributes

2018-11-26 Thread Sandra Loosemore
I've checked in this patch for PR 57182. -Sandra 2018-11-26 Sandra Loosemore PR c/57182 gcc/ * doc/invoke.texi (Optimize Options): Document that -freorder-functions also uses "hot" and "cold" attributes. I

Re: [doc,committed] clarify docs for function attribute "const"

2018-11-26 Thread Sandra Loosemore
On 11/26/18 10:17 AM, Martin Sebor wrote: On 11/25/18 6:40 PM, Sandra Loosemore wrote: I've checked in the attached patch for PR79738. I think we have lost something important with the clarification of attribute const:   The @code{const} attribute imposes greater restrictions on

[doc, committed] Document -Wmissing-noreturn

2018-11-25 Thread Sandra Loosemore
I've checked in this patch to fix PR 57166. -Sandra 2018-11-25 Sandra Loosemore PR c/57166 gcc/ * doc/invoke.texi (Option Summary): Add -Wmissing-noreturn. (Warning Options): Likewise. Index: gcc/doc/invoke.texi === --

[doc,committed] clarify docs for function attribute "const"

2018-11-25 Thread Sandra Loosemore
I've checked in the attached patch for PR79738. -Sandra 2018-11-25 Sandra Loosemore PR web/79738 gcc/ * doc/extend.texi (Common Function Attributes): Clarify that functions with "const" attribute can read const global variables. Index: gcc/

[doc, committed] use preferred placement of type attributes in examples

2018-11-25 Thread Sandra Loosemore
I've checked in this patch for PR 54265, after getting clarification that there really is a reason why it's preferred to place type attributes after the struct/union/enum keyword instead of after the closing brace. -Sandra 2018-11-25 Sandra Loosemore PR other/54265 g

Re: [PATCH][GCC][DOC] Remove obsolete arm and aarch64 CPU names from invoke.texi

2018-11-23 Thread Sandra Loosemore
On 11/23/18 9:55 AM, Sam Tebbs wrote: Hi all, The mtune= documentation in doc/invoke.texi contains some obsolete CPU names that have been removed from the Arm and AArch64 backends. This patch removes them. All removed CPU names: * arm2 * arm250 * arm3 * arm60

[doc, committed] Clarify docs for designated initializers of unions

2018-11-22 Thread Sandra Loosemore
I've checked in this patch for PR 53608. It's derived from the text suggested in the issue. -Sandra 2018-11-22 Sandra Loosemore Alan Coopersmith PR c/53608 gcc/ * doc/extend.texi (Designated Inits): Clarify handling of multiple initializers for unions. Inde

[doc, committed] mention shared libraries in docs for -l option

2018-11-19 Thread Sandra Loosemore
I've checked in this patch for PR 50250, following the suggestion in the issue to point to the linker documentation for definitive info on -l instead of trying to explain everything in great detail. -Sandra 2018-11-19 Sandra Loosemore PR driver/50250 gcc/ * doc/invoke.texi

Re: [doc, committed] clarify that "packed" attribute can apply to C++ classes

2018-11-19 Thread Sandra Loosemore
On 11/19/18 2:52 AM, Jonathan Wakely wrote: On 15/11/18 17:52 -0700, Sandra Loosemore wrote: I've checked in this patch for PR 25759, another minor documentation improvement. I'll commit this patch as obvious as soon as svn stops being slow. Thank you. My eyes were kind of gl

[doc, committed] document interaction between -p/-pg and no_instrument_function attribute

2018-11-18 Thread Sandra Loosemore
Like the subject line says. I've checked in this patch for PR 40498. -Sandra 2018-11-18 Sandra Loosemore PR other/40498 gcc/ * doc/extend.texi (Common Function Attributes): Document that no_instrument_function applies to -p and -pg, too. * doc/invoke.texi (Instrumentation Op

[doc, committed] document that --help and --help= options cannot be combined

2018-11-17 Thread Sandra Loosemore
This patch is for PR 31357. I've applied the patch in the issue with a minor copy-edit. -Sandra 2018-11-17 Nick Clifton Sandra Loosemore PR driver/31357 gcc/ * doc/invoke.texi (Overall Options): Document that --help and --help= options cannot be combined. Index

[doc, committed] document implicit extern "C" block in system headers

2018-11-17 Thread Sandra Loosemore
s special treatment to system headers; see https://gcc.gnu.org/ml/gcc-patches/2018-07/msg00116.html -Sandra 2018-11-17 Sandra Loosemore PR c++/4225 gcc/ * doc/cpp.texi (System Headers): Add note about implicit extern "C" block on targets that define SYSTEM_IMPLICIT_EXTERN_C. Ind

[doc, committed] clarify -fno-implicit-templates usage

2018-11-17 Thread Sandra Loosemore
-Sandra 2018-11-17 Sandra Loosemore PR c++/4025 gcc/ * doc/invoke.texi (C++ Dialect Options): Clarify usage of -fno-implicit-templates. Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi (revision 266233) +++ gcc/

[doc, committed] fix formatting in @gccoptlist environments

2018-11-16 Thread Sandra Loosemore
-11-16 Sandra Loosemore gcc/ * doc/invoke.texi (Option Summary): Fix whitespace and line breaks in @gccoptlist environments. (Warning Options): Likewise. (Optimize Options): Likewise. (PowerPC SPE Options): Likewise. (RS/6000 and PowerPC Options): Likewise. Index: gcc/doc/invoke.texi

[doc, committed] update options enabled by -fprofile-generate, -fprofile-use, -fauto-profile

2018-11-16 Thread Sandra Loosemore
-profile, which shares much of the same logic. -Sandra 2018-11-16 Sandra Loosemore PR middle-end/23197 gcc/ * doc/invoke.texi (Optimize Options): Update options enabled by fprofile-generate, -fprofile-use, and -fauto-profile. Index: gcc/doc/invoke.texi

[doc, committed] clarify that "packed" attribute can apply to C++ classes

2018-11-15 Thread Sandra Loosemore
I've checked in this patch for PR 25759, another minor documentation improvement. -Sandra 2018-11-15 Sandra Loosemore PR c++/25759 gcc/ * doc/extend.texi (Common Type Attributes): Make it explicit that attribute "packed" can apply to C++ classes. Index: gcc/

[doc, committed] __attribute__((aligned)) linker restrictions

2018-11-14 Thread Sandra Loosemore
I've checked in this patch for PR 56334, following the recommendation in comment 1 in that issue to * distinguish between stack-allocated and statically-allocated variables * mention object file format restrictions and not just blame it on the linker. -Sandra 2018-11-15 Sandra Loos

[doc, committed] fix documentation about interaction between -flto and -O

2018-11-14 Thread Sandra Loosemore
laced that with some language explaining why you need to compile with optimization to get the full effect of LTO. I also did a bit of copy-editing and rearrangement of material in the -flto discussion so that it flows a little better and isn't quite as wordy. -Sandra 2018-11-14 Sandra

[doc, committed] improve documentation for -Og

2018-11-14 Thread Sandra Loosemore
ous" so I have gone ahead and committed this patch. -Sandra 2018-11-14 Sandra Loosemore PR middle-end/59658 gcc/ * doc/invoke.texi (Optimize Options): Clarify that -O0 and -Og also suppress many optimizations. Alphabetize option lists for -O1, -O2, and -Os. Add list of optio

[doc, committed] clarify documentation of cache parameters

2018-11-12 Thread Sandra Loosemore
Continuing to whack at trivial doc issues in bugzilla This patch is for PR 59634, which is to clarify that some cache-related parameters control attributes of the data cache and not the instruction cache. -Sandra 2018-11-13 Sandra Loosemore PR middle-end/59634 gcc/ * doc

[doc, committed] make #pragma once documentation easier to find

2018-11-12 Thread Sandra Loosemore
the GCC manual explaining that preprocessor pragmas are documented in the CPP manual. -Sandra 2018-11-12 Sandra Loosemore PR preprocessor/47823 gcc/ * doc/cpp.texi (Alternatives to Wrapper #ifndef): Move #pragma once documentation to... (Pragmas): ...here. * doc/extend.texi (Pragmas):

[doc, committed] clarify rtl docs about mode of high and lo_sum

2018-11-12 Thread Sandra Loosemore
I've checked in this patch for PR 21110. As noted in the issue, RTL high and lo_sum expressions don't have to be Pmode and are not restricted to address operands. -Sandra 2018-11-12 Sandra Loosemore PR middle-end/21110 gcc/ * doc/rtl.texi (Constants): Clarify that mod

Re: [PATCH][DOCS] Fix documentation of __builtin_cpu_is and __builtin_cpu_supports for x86.

2018-11-12 Thread Sandra Loosemore
On 11/12/18 4:46 AM, Martin Liška wrote: Hi. The patch is adding missing values for aforementioned built-ins. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-11-12 Martin Liska * doc/extend.texi: Add missing values for __builtin_cpu_is and __builtin_cpu_supports for x8

Re: [GCC][AArch64] [middle-end][docs] Document the xorsign optab

2018-11-12 Thread Sandra Loosemore
On 11/12/18 5:10 AM, Tamar Christina wrote: Hi Sandra, Ok for trunk? +@cindex @code{xorsign@var{m}3} instruction pattern +@item @samp{xorsign@var{m}3} +Target suppports an efficient expansion of x * copysign (1.0, y) +as xorsign (x, y). Store a value with the magnitude of operand 1 +and the s

[doc, committed] fix documentation of align type attribute

2018-11-11 Thread Sandra Loosemore
rrect one. -Sandra 2018-11-11 Sandra Loosemore PR c/69502 gcc/ * doc/extend.texi (Common Type Attributes): For the align type attribute, copy language about decreasing alignment from the corresponding variable attribute. Index: gcc/doc/extend

Re: [GCC][AArch64] [middle-end][docs] Document the xorsign optab

2018-11-11 Thread Sandra Loosemore
On 11/11/18 3:14 AM, Tamar Christina wrote: Hi All, This patch just adds documentation for the xorsign optab that was added a while ago. Ok for trunk? +@cindex @code{xorsign@var{m}3} instruction pattern +@item @samp{xorsign@var{m}3} +Target suppports an efficient expansion of x * copysign (1.

[doc, committed] document restrictions on mixing -fno-rtti and -frtti

2018-11-11 Thread Sandra Loosemore
I've checked in this patch to fix another old but easy doc issue from bugzilla, PR43105. -Sandra 2018-11-11 Sandra Loosemore PR c++/43105 gcc/ * doc/invoke.texi (C++ Dialect Options): Add warning about mixing -frtti and -fno-rtti code. Index: gcc/doc/invoke

[doc, committed] document probability associated with __builtin_expect

2018-11-11 Thread Sandra Loosemore
I've checked in this patch to fix PR26366, another small but ancient documentation bug. -Sandra 2018-11-11 Sandra Loosemore PR c/26366 gcc/ * doc/extend.texi (Other Builtins): Document probability associated with __builtin_expect. Index: gcc/doc/extend

[doc, committed] add index entries for positive forms of -fno-xxx and -mno-xxx options

2018-11-10 Thread Sandra Loosemore
improvements to the documentation are better than nothing -Sandra 2018-11-10 Sandra Loosemore PR middle-end/65703 gcc/ * doc/invoke.texi (Optimize Options): Add @opindex entries for the positive forms of -fno-xxx and -mno-xxx options that were lacking them. Index: gcc/

[doc, committed] Clarify defaults for some -fno-xxx options

2018-11-09 Thread Sandra Loosemore
65703. My next patch will address the other part of that issue, relating to not being able to find the documentation for the positive form of options like -fno-defer-pop. -Sandra 2018-11-09 Sandra Loosemore PR driver/41179 PR middle-end/65703 gcc/ * doc/invoke.texi (Optimize Options): Cl

[doc, committed] clarify default for some options starting with "no-"

2018-11-08 Thread Sandra Loosemore
This patch knocks off another old but trivial documentation bug, PR 36572. There are a couple more like this I'm going to squash too. -Sandra 2018-11-08 Sandra Loosemore PR other/36572 gcc/ * doc/invoke.texi (Optimize Options): Clarify default behavior for -fno-sched-interbloc

[doc, committed] clarify -fno-common behavior

2018-11-07 Thread Sandra Loosemore
I've checked in this patch to fix a minor but long-standing bug in the description of -fno-common, PR 42726. -Sandra 2018-11-07 Sandra Loosemore PR middle-end/42726 gcc/ * doc/invoke.texi (Code Gen Options): Clarify -fno-common behavior. Index: gcc/doc/invoke

[doc, committed] remove leading dash from @opindex entries

2018-11-07 Thread Sandra Loosemore
cluded the leading dash. Fixed thusly. -Sandra 2018-11-07 Sandra Loosemore gcc/ * doc/invoke.texi: Remove leading dash from @opindex entries throughout the file. Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi (revis

[doc, committed] document -e and --entry

2018-11-07 Thread Sandra Loosemore
Trying to knock off some easy documentation bugs from bugzilla... I've checked in this patch to fix PR driver/80828, about missing documentation for these options that are passed through to the linker. -Sandra 2018-11-07 Sandra Loosemore PR driver/80828 gcc/ * doc/invoke.texi (O

Re: [PATCH, OpenACC] Update documentation to mention OpenACC 2.5

2018-11-04 Thread Sandra Loosemore
On 11/02/2018 04:38 AM, Chung-Lin Tang wrote: Hi Thomas, this patch (mostly by yourself:) ) are the changes to the documentation to now state OpenACC 2.5 support. I believe this is within your maintainership scope. I took a look at it with my doc maintainer hat on too, and the patch is fine

<    1   2   3   4   5   6   7   8   9   10   >