Re: RFC: add some static probes to libstdc++

2013-02-28 Thread Tom Tromey
> "Dave" == Dave Korn writes: Dave> How did it build in the without sys/sdt.h case? Dave> Without HAVE_SYS_SDT_H, there's no definition of PROBE2 at all, Dave> but you use it unconditionally in eh_{catch,throw}.cc. Am I Dave> missing something? Ugh. I must have made some mistake in my t

RFC: add some static probes to libstdc++

2013-02-27 Thread Tom Tromey
get reactions to the probe before cleaning up the corresponding gdb patches for submission. I've built it both with and without sys/sdt.h, but I haven't yet run the test suite. Tom 2013-02-27 Tom Tromey * libsupc++/unwind-cxx.h: Include ../config.h, sys/sdt.h. (PROB

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Tom Tromey
> "Dave" == John David Anglin writes: Dave> I had looked at this a bit in the past. I don't think it's that Dave> difficult to add DWARF2 support Dave> to GCC on hppa. Although we don't support named sections, we can Dave> create named subspaces Dave> for the dwarf info. More of an issue i

Re: RFA: Update copyright for libcpp

2013-01-14 Thread Tom Tromey
> "Richard" == Richard Sandiford writes: Richard> Here's the result of running the copyright script on libcpp/. Richard> It's nice and short, but for consistency with the other patches, Richard> I've not listed out every file in the changelog. Richard> Tested on x86_64-linux-gnu. OK to inst

Re: extern "C" fixes for sunCC

2013-01-03 Thread Tom Tromey
> "Marc" == Marc Glisse writes: Marc> Do you prefer an other approach? No, this is fine, just yucky. Marc> Like this? (I'll test if approved, but I am not sure what was wrong Marc> with the indentation and parentheses so it may be wrong again) >From the node 'Formatting' in the GCS:

Re: extern "C" fixes for sunCC

2013-01-03 Thread Tom Tromey
> "Marc" == Marc Glisse writes: Marc> libcpp/ Marc> * line-map.c (get_combined_adhoc_loc): Cast to extern "C" type. Yucky. Marc> line_map_realloc reallocator Marc> - = set->reallocator ? set->reallocator : xrealloc; Marc> + = set->reallocator ? set->reallocator Marc> +

Re: [PATCH] Allocate extra 16 bytes for -fsanitize=address

2012-12-03 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> 2012-11-23 Jakub Jelinek Jakub> PR bootstrap/55380 Jakub> * files.c (read_file_guts): Allocate extra 16 bytes instead of Jakub> 1 byte at the end of buf. Pass size + 16 instead of size Jakub> to _cpp_convert_input. Jakub> * charset.c (_cpp_co

Re: [PATCH] Instance information in DWARF discriminators

2012-11-29 Thread Tom Tromey
> "Thomas" == Thomas Quinot writes: Thomas> As for the size impact on line_map_ordinary, indeed that's an additional Thomas> int here, but I'm not sure we allocate so many objects of that kind that Thomas> the increase is significant. Could you please measure it? My guess is that it is worse

Re: add typedef printers to libstdc++

2012-11-16 Thread Tom Tromey
>>>>> "Tom" == Tom Tromey writes: Jonathan> Please go ahead and commit, thanks, Tom! Tom> Thanks. The needed gdb patches are still pending, so I plan to wait Tom> until those go in before committing to libstdc++. I hope it will be Tom> next week sometim

Re: VEC re-write [patch 09/25]

2012-11-16 Thread Tom Tromey
> "Diego" == Diego Novillo writes: Diego> 2012-11-15 Diego Novillo Diego> Adjust for new vec API (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec) Diego> * boehm.c: Use new vec API in vec.h. Diego> * class.c: Likewise. Diego> * constants.c: Likewise. Diego> * decl.c: Likewise. Diego>

Patch: add AM_MAINTAINER_MODE in libsanitizer

2012-11-16 Thread Tom Tromey
missing call. Ok? Tom 2012-11-16 Tom Tromey * configure.ac: Invoke AM_MAINTAINER_MODE. * aclocal.m4, configure, Makefile.in, asan/Makefile.in, interception/Makefile.in, sanitizer_common/Makefile.in: Rebuild. diff --git a/libsanitizer/configure.ac b/libsanitizer/configure.ac

Patch: add @direntry for gcov

2012-10-30 Thread Tom Tromey
This patch adds a @direntry for gcov. I noticed that it was missing today, when I tried to find the gcov manual from the info "dir" node. Then I found out that I had filed PR 50899 for this ages ago. Ok? Tom 2012-10-30 Tom Tromey PR other/50899 * doc/gcc

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-25 Thread Tom Tromey
> "Dehao" == Dehao Chen writes: Dehao> This patch fixes debug info for expr and jump stmt. Dehao> Bootstrapped and passed gcc regression tests. Dehao> Is it okay for trunk? I wonder whether this affects the gdb test suite results. I'm not trying to pick on you specifically, but there's been

Re: Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-23 Thread Tom Tromey
Steven> Probably you mean the revised patch here: Steven> http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html Steven> The patch look OK to me but I can't approve it. I'm sorry about the delay on this. The libcpp bits are ok. I can't approve the other parts. I think new configure options sho

Re: [PATCH] [7/10] AArch64 Port

2012-10-23 Thread Tom Tromey
> "Marcus" == Marcus Shawcroft writes: Marcus> This patch adjusts the libcpp configury for AArch64. Marcus> Proposed ChangeLog: Marcus> * configure.ac: Enable AArch64. Marcus> * configure: Regenerate. This is ok. Thanks. Tom

Re: [Java] Tidy bultins and add __bultin_unreachable

2012-10-16 Thread Tom Tromey
> "Jan" == Jan Hubicka writes: Jan> this patch udpates Java frontend to declare __bulitin_unreachable Jan> and also fixes flags of synchronize bulitins to match ones from C Jan> FE. Jan> Regtested x86_64-linux, OK? The java bits are ok. Jan> + /* Looping const or pure is imlpies by noretu

Re: [libcpp] Free some variables

2012-10-15 Thread Tom Tromey
> "Tobias" == Tobias Burnus writes: Tobias> Build on x86-64-linux with C/C++/Fortran. I will now do an Tobias> all-language build/regtest. Tobias> OK when it passes? Tobias> 2012-10-03 Tobias Burnus Tobias> * files.c (read_file_guts, _cpp_save_file_entries): Free memory Tobias>

Re: add typedef printers to libstdc++

2012-09-27 Thread Tom Tromey
Jonathan> Please go ahead and commit, thanks, Tom! Thanks. The needed gdb patches are still pending, so I plan to wait until those go in before committing to libstdc++. I hope it will be next week sometime. Tom

Re: [CPP] Add pragmas for emitting diagnostics

2012-09-26 Thread Tom Tromey
> "Florian" == Florian Weimer writes: Florian> This patch adds support for #pragma GCC warning and #pragma GCC Florian> error. These pragmas can be used from preprocessor macros, Florian> unlike the existing #warning and #error directives. Library Florian> authors can use these pragmas to ad

Re: add typedef printers to libstdc++

2012-09-25 Thread Tom Tromey
:basic_string, but I thought a test Magnus> case here couldn't hurt? Here's an updated patch with the new tests. Tom 2012-09-25 Tom Tromey * testsuite/libstdc++-prettyprinters/whatis.cc: New file. * testsuite/lib/gdb-test.exp (whatis-test): New proc. (gdb

add typedef printers to libstdc++

2012-09-21 Thread Tom Tromey
ype's name. This lets a library pretend that some typedefs are canonical. This includes a fairly comprehensive test case for the new type printers. Tom b/libstdc++-v3/ChangeLog: 2012-09-21 Tom Tromey * testsuite/libstdc++-prettyprinters/whatis.cc: New file. * testsuite/l

Re: [PATCH] Combine location with block using block_locations

2012-09-13 Thread Tom Tromey
> "Dehao" == Dehao Chen writes: Dehao> + static htab_t location_adhoc_data_htab; Dehao> + static source_location curr_adhoc_loc; Dehao> + static struct location_adhoc_data *location_adhoc_data; Dehao> + static unsigned int allocated_location_adhoc_data; libcpp was written to allow multiple p

Re: [PATCH] Combine location with block using block_locations

2012-09-13 Thread Tom Tromey
> "Robert" == Robert Dewar writes: Robert> Sometimes I wonder whether the insistence on -g not changing code Robert> generation is warranted. In practice, gdb for me is so weak in handling Robert> -O1 or -O2, that if I want to debug something I have to recompile Robert> with -O0 -g, which cau

Re: failed attempt: retain identifier length from frontend to backend

2012-08-24 Thread Tom Tromey
> "Dimitris" == Dimitrios Apostolou writes: Dimitris> [...] since I broke things like the static assert in Dimitris> libcpp/identifiers.c, that I don't even understand: Dimitris> /* We don't need a proxy since the hash table's identifier comes first Dimitris> in cpp_hashnode. However,

Re: Speedups/Cleanups: End of GSOC patch collection

2012-08-24 Thread Tom Tromey
> "Dodji" == Dodji Seketeli writes: Dodji> With these changes, the libcpp parts look OK to me if they still Dodji> boostrap post c++ conversion. I am not a maintainer so I a deferring to Dodji> Tom and the other maintainers. I agree. Dodji, thanks for looking at this. Dmitris, thanks for w

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-15 Thread Tom Tromey
> "Jonathan" == Jonathan Wakely writes: Jonathan> I like it, please go ahead and check that in it you're happy Jonathan> with it. I did. Thanks. Tom

Re: Merge C++ conversion into trunk (0/6 - Overview)

2012-08-15 Thread Tom Tromey
> "Gaby" == Gabriel Dos Reis writes: Tom> I asked Keith to resurrect his patch for this. Gaby> Since people are concerned about typing rules, would it Gaby> be an option for GDB to allow people to input pointer Gaby> literals with the "p" suffix (or "0p" prefix instead of "0x")? I think on

Re: Merge C++ conversion into trunk (0/6 - Overview)

2012-08-15 Thread Tom Tromey
> "Diego" == Diego Novillo writes: Diego> GDB folks, would it be hard to figure out that there is a single Diego> variant of the called function and trust the user that they are Diego> passing the right pointer value? I asked Keith to resurrect his patch for this. Tom

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-14 Thread Tom Tromey
ted patch. Let me know what you think. Tom 2012-08-14 Tom Tromey * testsuite/libstdc++-prettyprinters/cxx11.cc (struct datum): New. (global): New global. (main): Add test for unique_ptr. * python/libstdcxx/v6/printers.py (UniquePointerPrin

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-13 Thread Tom Tromey
> "Jonathan" == Jonathan Wakely writes: >> $11 = std::unique_ptr containing (datum *) 0x6067d0 Jonathan> It's inconsistent with the other printers in that it prints Jonathan> the stored type, unlike e.g. std::vector which just says Jonathan> "std::vector of length ..." but I think that's an

RFC: fix std::unique_ptr pretty-printer

2012-08-10 Thread Tom Tromey
The new output looks like this: $11 = std::unique_ptr containing (datum *) 0x6067d0 Let me know what you think. Tom b/libstdc++-v3/ChangeLog: 2012-08-10 Tom Tromey * testsuite/libstdc++-prettyprinters/cxx11.cc (struct datum): New. (global): New global. (m

Re: RFA: implement C11 _Generic

2012-07-30 Thread Tom Tromey
>>>>> "Joseph" == Joseph S Myers writes: Joseph> On Mon, 30 Jul 2012, Tom Tromey wrote: >> 6.3 is about conversions, and the first paragraph starts "several >> operators convert ...". Based on this, and other such phrases in the >> text,

Re: RFA: implement C11 _Generic

2012-07-30 Thread Tom Tromey
> "Joseph" == Joseph S Myers writes: Tom> I wasn't really aware of 6.3.2.1, but after reading it and re-reading Tom> 6.5.1.1, I think I agree with his "model 0" interpretation: no promotion Tom> or conversion. Tom> I don't have a standards-based reason for this, though; just my belief Tom> t

Re: RFA: implement C11 _Generic

2012-07-27 Thread Tom Tromey
> "Joseph" == Joseph S Myers writes: Joseph> Could you explain the choices you have made for the issues Joseph> raised on comp.std.c last month (regarding the handling of Joseph> qualifiers on controlling expressions) and the rationale for Joseph> those choices (and make sure there are approp

RFA: implement C11 _Generic

2012-07-27 Thread Tom Tromey
really been all that good at language lawyering. Comments? 2012-07-27 Tom Tromey * c-common.h (enum rid) : New constant. * c-common.c (c_common_reswords): Add _Generic. 2012-07-27 Tom Tromey * c-parser.c (struct c_generic_association): New. (c_generic_associa

Re: [patch] Stop gengtype from emitting empty loops

2012-07-24 Thread Tom Tromey
> "Laurynas" == Laurynas Biveinis writes: Laurynas> 2012-06-24 Laurynas Bivienis Laurynas> * include/line-map.h (line_map_macro): Use the "atomic" GTY option Laurynas> for the macro_locations field. Laurynas> gcc/java: Laurynas> 2012-07-24 Laurynas Biveinis Laurynas>

Re: [PATCH 1/2] if-to-switch conversion pass

2012-07-19 Thread Tom Tromey
> "Steven" == Steven Bosscher writes: Steven> Makefile.in is a mess. One of these days, someone (hi, Tromey) will Steven> hopefully get annoyed enough with this again to finish some tool to Steven> auto-generate the dependences list. Until that time, let's try to Steven> avoid proliferating t

Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb.

2012-07-14 Thread Tom Tromey
> "Eli" == Eli Zaretskii writes: Eli> I understand all that, but why would the eq_f function need to be an Eli> external function on its own? It is just to avoid other users having to write their own. Eli> E.g., if we were to write a qsort replacement, would we have a Eli> suitable string c

Re: [PATCH] boehm-gc configuration support for GNU/Hurd

2012-06-18 Thread Tom Tromey
> "Thomas" == Thomas Schwinge writes: Thomas> This is a backport of upstream boehm-gc configuration support for Thomas> GNU/Hurd. The equivalent thing has been used in Debian's GCC packages Thomas> since GCC 4.2 already, and I decided that *NOW* ought to be the time to Thomas> put it into th

Re: long long availability in host compiler (Re: constant that doesn't fit in 32bits in alpha.c)

2012-06-15 Thread Tom Tromey
> "Eric" == Eric Botcazou writes: Tom> I don't understand what the code being external, or the review, has to Tom> do with anything. This code is compiled with the same host compiler as Tom> everything else. Eric> But, precisely, this line of reasoning is barely defensible in my Eric> opini

Re: long long availability in host compiler (Re: constant that doesn't fit in 32bits in alpha.c)

2012-06-15 Thread Tom Tromey
> "Eric" == Eric Botcazou writes: >> It's true that this is a pedantic violation; but the point here is that >> there is no practical barrier to using 'long long'. This code has been >> in the tree since 2007; so if there is some issue with it, it ought to >> have surfaced by now. Eric> The

Re: long long availability in host compiler (Re: constant that doesn't fit in 32bits in alpha.c)

2012-06-15 Thread Tom Tromey
> "Eric" == Eric Botcazou writes: Pedro> It's not about example, but the fact that host compilers have been Pedro> compiling that code as part of building gcc for years, without anyone Pedro> complaining, afaik. It doesn't matter whether the code pointed at Pedro> is the ugliest or most beau

Re: Changed table name. (issue6244048)

2012-06-04 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Lawrence> Because libcpp was using a typedef hash_table, that typedef has been Lawrence> renamed cpp_hash_table and uses of it have changed. The libcpp changes are ok. Tom

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-30 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Lawrence> On 5/24/12, Gabriel Dos Reis wrote: >> On May 24, 2012 Lawrence Crowl wrote: >> > Add a type-safe hash table, typed_htab. Uses of this table >> > replace uses of libiberty's htab_t. The benefits include less >> > boiler-plate code, full typ

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Tom Tromey
> "Diego" == Diego Novillo writes: Diego> +struct GTY(()) vec_prefix Diego> +{ Diego> + unsigned num; Diego> + unsigned alloc; Diego> +}; Diego> + Diego> +/* Vector type, user visible. */ Diego> +template Diego> +struct GTY(()) vec_t Diego> +{ Diego> + vec_prefix prefix; Diego> + T GTY((

Re: Turn check macros into functions. (issue6188088)

2012-05-25 Thread Tom Tromey
> "Mike" == Mike Stump writes: Mike> Yeah, I kinda think the gdb people are wimping out by not just Mike> implementing __extension__ and ({}), which, I think get us most of the Mike> way there. Shh, don't tell them I said that. We eagerly await your patch. Tom

Re: Turn check macros into functions. (issue6188088)

2012-05-25 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Lawrence> Should I add that to my patch to gdbinit.in? I think it would be helpful. Tom

Re: Turn check macros into functions. (issue6188088)

2012-05-21 Thread Tom Tromey
> "Alexander" == Alexander Monakov writes: Alexander> Hm, isn't GDB's 'set unwindonsignal on' enough to fix it? Alexander> It's useful to have that in your .gdbinit anyway, because the Alexander> same issue arises when calling debug_* functions in cc1 from Alexander> the debugger. Yeah, why

fix demangler crash - gdb PR 14065

2012-05-21 Thread Tom Tromey
ct, and it does avoid the crash. Ok? Tom 2012-05-21 Tom Tromey http://sourceware.org/bugzilla/show_bug.cgi?id=14065 * testsuite/demangle-expected: Add regression test. * cp-demangle.c (d_find_pack): Return NULL for DEMANGLE_COMPONENT_UNNAMED_TYPE. diff --git a

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Tom> Doesn't this mean that if you have checking enabled, and you use the Tom> wrong macro on some tree, cc1 will crash? That seems like a distinct Tom> minus to me. Lawrence> Yes, it does mean that, but it is a net overall improvement. It is a net de

Re: PING PATCH: break lines in announce_function

2012-05-16 Thread Tom Tromey
> "Manuel" == Manuel López-Ibáñez writes: Manuel> It seems it will never work for statement expressions: Manuel> http://article.gmane.org/gmane.comp.gcc.devel/107339 It could be done, but it is non-trivial for sure. Manuel> I see how these small functions can quickly become annoying. Is it

Re: PING PATCH: break lines in announce_function

2012-05-16 Thread Tom Tromey
> "Manuel" == Manuel López-Ibáñez writes: Manuel> Actually, I wonder how you (Richard) and other GCC hackers work with Manuel> and debug GCC, because it is a real pain in the ass. Manuel> * All the TREE_ macros don't work. Manuel> * __extension__ prevents GDB from evaluating many things. S

Re: Turn check macros into functions. (issue6188088)

2012-05-16 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Lawrence> The effect is that it now possible to get useful responses to gdb Lawrence> command like Lawrence> (gdb) print DECL_FUNCTION_CODE (decl) Doesn't this mean that if you have checking enabled, and you use the wrong macro on some tree, cc1 wil

Re: [PATCH preprocessor, diagnostics] PR preprocessor/53229 - Fix diagnostics location when pasting tokens

2012-05-15 Thread Tom Tromey
> "Dodji" == Dodji Seketeli writes: Dodji> To properly fix this, I think libcpp should keep the token of the Dodji> pasting operator '##', instead of representing it with flag on the LHS Dodji> operand's token. That way, it could use its location. Originally I had thought that a pasted toke

Re: [PATCH libcpp]: Avoid crash in interpret_float_suffix

2012-05-08 Thread Tom Tromey
> "Tristan" == Tristan Gingold writes: Tristan> 2012-05-04 Tristan Gingold Tristan>* expr.c (interpret_float_suffix): Add a guard. Ok. Tom

Re: RFA: consolidate DWARF strings into libiberty

2012-04-27 Thread Tom Tromey
>>>>> "Tom" == Tom Tromey writes: HJ> You should add extern "C" for C++ on those functions moved to HJ> libiberty. Tom> Yeah, sorry about that. Tom> I'm testing the fix. Here is what I am checking in. Tom ChangeLog: 2012-04-27 Tom Tromey

Re: RFA: consolidate DWARF strings into libiberty

2012-04-27 Thread Tom Tromey
HJ> You should add extern "C" for C++ on those functions moved to HJ> libiberty. Yeah, sorry about that. I'm testing the fix. Tom

Re: RFA: consolidate DWARF strings into libiberty

2012-04-27 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> On Thu, Apr 26, 2012 at 01:52:31PM -0400, DJ Delorie wrote: >> >> I will not oppose adding more unrelated stuff to libiberty, but >> neither will I approve it. I will let one of the other maintainers or >> a global maintainer approve it. Jakub> The

Re: PR c++/52538 Extend C++11 UDLs to be compatible with inttypes.h macros (issue6109043)

2012-04-26 Thread Tom Tromey
> "Ollie" == Ollie Wild writes: Ollie> 2012-04-22 Ollie Wild Ollie> * gcc/c-family/c-common.c: Ollie> * gcc/c-family/c-opts.c (c_common_handle_option): Ollie> * gcc/c-family/c.opt: Ollie> * gcc/doc/invoke.texi (struct A): Ollie> * gcc/testsuite/g++.dg/cpp0x/Wreserved-user-defined-lit

Re: [PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

2012-04-25 Thread Tom Tromey
> "Gaby" == Gabriel Dos Reis writes: Gaby> On Wed, Apr 25, 2012 at 9:33 AM, Dodji Seketeli wrote: >> Hopefully closing the series, this patch switches the compiler to >> -ftrack-macro-expansion=2 by default. >> >> Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. Gaby> Mak

Re: RFA: consolidate DWARF strings into libiberty

2012-04-23 Thread Tom Tromey
Tom> Here is a new patch for gcc. Tom> I still haven't updated the src side, but there's little to do there Tom> that isn't already done in this patch. Tom> Ok? Tom> Ping. Tom> Ping. This is the third ping. Please review the patch. There are two choices: 1. Approve the original patch, adding

Re: [patch] Fix CASE_LABEL_EXPR documentation in tree.def and tree-cfg.c

2012-04-18 Thread Tom Tromey
> "Steven" == Steven Bosscher writes: Steven> Subject says all. Will commit as obvious. Steven> * tree.def (CASE_LABEL_EXPR): Fix documentation, mention all operands. Thank you. Tom

Re: RFA: consolidate DWARF strings into libiberty

2012-04-13 Thread Tom Tromey
Tom> Here is a new patch for gcc. Tom> I still haven't updated the src side, but there's little to do there Tom> that isn't already done in this patch. Tom> Ok? Tom> Ping. Ping. Tom

Re: [PATCH] Caret diagnostics

2012-04-12 Thread Tom Tromey
> "Gaby" == Gabriel Dos Reis writes: Manuel> So, in fact, libcpp is buggy for not implementing this (as can be seen Manuel> in emacs). If/When libcpp is fixed, the column info will be correct Manuel> for tabs. And then, one may care about printing tabs as anything Manuel> different from a sin

Re: Mirror gcc/contrib -> src/contrib? [was Re: [patch, gcc RFA] dg-extract-results.sh: Handle KFAILs.]

2012-04-09 Thread Tom Tromey
> "Doug" == Doug Evans writes: Doug> On Thu, Mar 15, 2012 at 11:54 AM, Mike Stump wroteDoug> btw, is there any interest in mirroring gcc/contrib -> src/contrib? Doug> [instead of gdb having its own copy in gdb/testsuite, it *could* use Doug> the one in, e.g., src/contrib. I don't have a str

Re: RFA: consolidate DWARF strings into libiberty

2012-04-05 Thread Tom Tromey
>>>>> "Tom" == Tom Tromey writes: Tom> Here is a new patch for gcc. Tom> I still haven't updated the src side, but there's little to do there Tom> that isn't already done in this patch. Tom> Ok? Ping. Tom

Re: [libjava] Restore HAVE_INET6 tests (PR libgcj/52645)

2012-04-05 Thread Tom Tromey
> "Rainer" == Rainer Orth writes: Rainer> 2012-03-21 Rainer Orth Rainer> PR libgcj/52645 Rainer> * gnu/java/net/natPlainDatagramSocketImplPosix.cc (setOption): Rainer> Restore HAVE_INET6 check. Rainer> * gnu/java/net/natPlainDatagramSocketImplWin32.cc (setOp

Re: RFA: consolidate DWARF strings into libiberty

2012-03-19 Thread Tom Tromey
> "DJ" == DJ Delorie writes: DJ> The only drawback to adding toplevel libraries is coordinating changes DJ> among the toplevel configury. And adding crud to Makefiles all over. Pick a name for the new library and I will implement this. Tom

Re: Remove obsolete IRIX 6.5 support

2012-03-16 Thread Tom Tromey
> "Rainer" == Rainer Orth writes: Rainer> Continuing with the patches to remove obsolete ports, here's the Rainer> IRIX 6.5 removal patch. Rainer> * libjava/gnu/classpath/natSystemProperties.cc (getpwuid_adaptor) claims Rainer> to be for IRIX, too, but I cannot tell for certain. It doesn'

Re: RFA: consolidate DWARF strings into libiberty

2012-03-15 Thread Tom Tromey
>>>>> "Jakub" == Jakub Jelinek writes: Jakub> On Thu, Mar 15, 2012 at 12:41:54PM -0600, Tom Tromey wrote: >> I guess I can just put the whole DW_TAG_ prefix in there. >> That isn't a big deal. Or if you have some other suggestion, I can >>

Re: RFA: consolidate DWARF strings into libiberty

2012-03-15 Thread Tom Tromey
> "DJ" == DJ Delorie writes: Tom> Finally, there is already stuff in libiberty not related to Tom> portability. E.g., hashtab or the demangler. DJ> Yeah, I know, hence my "Should I give up that premise?" Yeah. I am not sure there will ever be enough shared code to warrant a new library, p

Re: RFA: consolidate DWARF strings into libiberty

2012-03-15 Thread Tom Tromey
> "DJ" == DJ Delorie writes: DJ> Sigh, libiberty is supposed to be a portability library, not a DJ> kitchen-sink for common stuff. Should I give up that premise? Or DJ> should we consider a common dwarf2 helper library, and move even more DJ> of the dwarf2 code into it? My reasoning was:

Re: Remove obsolete Solaris 8 support

2012-03-12 Thread Tom Tromey
> "Rainer" == Rainer Orth writes: Rainer> libcpp: Rainer> * lex.c: Remove Solaris 8 reference. Also ok. Tom

Re: Remove obsolete Solaris 8 support

2012-03-12 Thread Tom Tromey
> "Rainer" == Rainer Orth writes: Rainer> libjava: Rainer> * configure.ac (THREADLIBS): Remove *-*-solaris2.8 handling. Rainer> * configure: Regenerate. This part is ok. Thanks. Tom

Patch: fix std::unordered_map (et al) pretty printer

2012-02-14 Thread Tom Tromey
table are linked together via their _M_nxt fields, so I have simplified the iterator to just do this. I've included some new test cases. Tested on x86-64 Fedora 16. Ok? Tom 2012-02-14 Tom Tromey * testsuite/libstdc++-prettyprinters/cxx11.cc (main): Add new

Re: [patch boehm-gc]: Fix PR/48514

2012-02-10 Thread Tom Tromey
> "Kai" == Kai Tietz writes: Kai> * include/gc_config_macros.h (GC_DLL): Define it for Kai> mingw-targets only, if Kai> we are actual in boehm-gc's build and DLL_EXPORT macro is defined. This is ok. Thanks. Tom

Re: RFA: fix PR 51649

2012-01-30 Thread Tom Tromey
>>>>> "Tom" == Tom Tromey writes: Tom> Unless you have other tests to suggest, I am going to say that it has Tom> been sufficiently tested and check it in on Friday. Jakub said on irc that he thought I had done sufficient testing. So, I am checking this patch in now. thanks, Tom

Re: RFA: fix PR 51649

2012-01-25 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> Well, even bad debugging experience problems would be very undesirable Jakub> if we generated wrong debug info and everybody compiled it into their Jakub> sources. But pretty-printers stay on the side, it is just a matter of Jakub> updating the pytho

RFA: fix PR 51649

2012-01-23 Thread Tom Tromey
d with the default on x86-64 Fedora 15. I'm sufficiently out of the loop gcc-wise that I will need some advice as to whether this can go in immediately or whether it must wait for some other stage. Ok? Tom 2012-01-23 Tom Tromey PR libstdc++/51649: * testsuite/libstdc++

Re: [PATCH, go] Add -mieee to various go.test tests

2012-01-20 Thread Tom Tromey
> "Ian" == Ian Lance Taylor writes: Ian> And I just have to repeat that this patch is an ugly ugly hack, since Ian> -mieee should be the default. Perhaps we should investigate having Ian> gcc/go/gospec.c or gcc/go/lang-specs.h somehow add -mieee for those Ian> targets which require it. For

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-06 Thread Tom Tromey
> "Gary" == Gary Funck writes: Gary> I have a specific question re: this new code. Gary> + name = _cpp_get_file_name (pfile->main_file); Gary> + if (!name) Gary> + name = ""; Gary> I wasn't sure whether 'name' can have a NULL value, and handled Gary> that case

Re: [Google/main Patch] Cleanup pubnames/pubtypes and test-suite (issue5514045)

2012-01-06 Thread Tom Tromey
> "Sterling" == Sterling Augustine writes: Sterling> The enclosed patch to google/main contains certain small fixes Sterling> for pubnames and pubtypes, which are now emitted completely Sterling> and canonically. I am curious to know how you ensure that they are canonical. My recollection i

Re: [PATCH] Don't ICE on >= 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> Honza said that GDB doesn't support DW_TAG_dwarf_procedure though. Jakub> We'd need to represent it as nameless artificial DW_TAG_variable Jakub> or something similar. I think gdb will issue a complaint if it sees one. I'm not sure, I don't think I'

Re: [PATCH] Don't ICE on >= 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> another alternative would be to create DW_TAG_dwarf_procedure for Jakub> them or for portions thereof (for subexpressions it would be even Jakub> a potential nice debug info shrinking method, but would mean a Jakub> lot of work and gdb support isn't t

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-20 Thread Tom Tromey
> "Ramana" == Ramana Radhakrishnan writes: Ramana> Otherwise looks ok to me . Sergio was asked me to ping this for him, but instead I re-read the entire thread and I think that this was an approval conditional on him making the request changes (just to ChangeLog), which he did. So, I am che

Re: [PATCH] Fix libjava build on current git glibc (PR bootstrap/50888)

2011-11-23 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> As discussed in the PR, libjava fails to build against latest Jakub> glibc, because prims.cc is compiled with -fnon-call-exceptions, Jakub> uses ctype.h and libgcj isn't linked against -lsupc++ or -lstdc++. Jakub> isspace in latest glibc is a throw()

Re: [PATCH] Fix libjava build on current git glibc (PR bootstrap/50888)

2011-11-23 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> 2011-11-23 Jakub Jelinek Jakub> PR bootstrap/50888 Jakub> * prims.cc: Don't include ctype.h. Jakub> (c_isspace): Define. Jakub> (next_property_key, next_property_value): Use it instead Jakub> of isspace. This is ok. Tom

Re: [PATCH, debug] Emit basic block markers in .debug_line section

2011-11-18 Thread Tom Tromey
> "Roberto" == Roberto Agostino Vitillo writes: Roberto> I ended up not using it and it's clear to me that its practical Roberto> uses may be questionable ("fast" single stepping in a Roberto> debugger?) but I thought it might be worth to share it. Thanks. I think that if there is no use fo

Re: [PATCH, debug] Emit basic block markers in .debug_line section

2011-11-15 Thread Tom Tromey
> "Roberto" == Roberto Agostino Vitillo writes: Roberto> With this patch DW_LNS_set_basic_block opcodes are emitted in Roberto> the .debug_line section marking the instructions that indicate Roberto> the beginning of a basic block as specified by the dwarf Roberto> standards 2,3 and 4. I'm c

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Tom Tromey
> "Jeff" == Jeff Law writes: Jeff> So, presumably there's no way to know we're throwing to Jeff> NullPointerException from the exception information attached to the Jeff> statement or BB? If not I could disable if the statement with the Jeff> memory op throws anywhere. It's not ideal, but c

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Tom Tromey
> "Jeff" == Jeff Law writes: Jeff> First, it's perfectly fine to have a NULL pointer dereference in a Jeff> program as long as that code is never executed. Once the code is Jeff> executed, we've entered the realm of undefined behavior. Jeff> Thus in a conforming program we can safely assume

Re: [C++ Patch] PR 50956

2011-11-03 Thread Tom Tromey
> "Paolo" == Paolo Carlini writes: Paolo> By the way, I have no idea why I didn't see it, only Fortran includes Paolo> that header in the *libcpp* directory? Anyway, I'm proceeding to Paolo> bootstrap the attached. It really isn't ok to do this. That header is supposedly private to libcpp.

Re: [C++-11] User defined literals

2011-10-21 Thread Tom Tromey
> "Ed" == Ed Smith-Rowland <3dw...@verizon.net> writes: Ed> + /* Nonzero for the 2011 C++ Standard. */ Ed> + unsigned char cxx11; I think it would be better if the new field name reflected its purpose, so something like "user_literals". Ed> + if (ISIDST(*cur)) Ed> + { Ed> + typ

FYI: minor fix in gcc/configure

2011-10-17 Thread Tom Tromey
I'm checking this in as obvious. Sergio pointed out, via this patch, that gcc/configure didn't properly emit whether sys/std.h was discovered. Tested by re-running configure and examining the output. Tom 2011-10-17 Sergio Durigan Junior * configure.ac: Display `yes' if the SystemTap

Re: [patch] dwarf2out: Drop the size + performance overhead of DW_AT_sibling

2011-10-17 Thread Tom Tromey
> "Tristan" == Tristan Gingold writes: Tom> Another way to look at it is that there have been many changes to GCC's Tom> DWARF output in the last few years. Surely these have broken these Tom> DWARF consumers more than this change possibly could. Tristan> Yes, but there is -gstrict-dwarf to

Re: [patch] dwarf2out: Drop the size + performance overhead of DW_AT_sibling

2011-10-14 Thread Tom Tromey
> "Tristan" == Tristan Gingold writes: Tristan> I am not against this patch, my only concern is that there are many Tristan> many dwarf consumers and I have no idea how they will react to this Tristan> change. I tend to think that this is the wrong standard to apply. In this case we would b

Re: [gimplefe][patch] The symbol table for declarations

2011-10-11 Thread Tom Tromey
> "Sandeep" == Sandeep Soni writes: Sandeep> The following patch is a basic attempt to build a symbol table that Sandeep> stores the names of all the declarations made in the input file. I don't know anything about gimplefe, but unless you have complicated needs, it is more usual to just put

Re: Modify gcc for use with gdb (issue5132047)

2011-10-07 Thread Tom Tromey
> "Jeff" == Jeff Law writes: Jeff> Presumably it hasn't been included because not all gdb's understand Jeff> those bits and we typically don't build with -g3. GCC is pretty much the perfect candidate for a -g3 build. All those macros... The needed gdb changes have been in since right aroun

Re: Modify gcc for use with gdb (issue5132047)

2011-10-05 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> I don't mind if it goes into gdb, but IMHO the blacklisting should Jakub> definitely default to blacklisting DW_AT_artificial inline functions Jakub> (and allowing to unblacklist them), because the artificial attribute Jakub> has been designed for tha

Re: Modify gcc for use with gdb (issue5132047)

2011-10-05 Thread Tom Tromey
> "Diego" == Diego Novillo writes: Tom>    http://sourceware.org/bugzilla/show_bug.cgi?id=8287 Diego> I think this could work. I'm not sure I like the idea of having to Diego> specify all these blacklist commands, but I appreciate how it can make Diego> debugging more flexible. Yeah, that'

<    1   2   3   4   5   6   >