Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

Andrea Corallo writes: > David Malcolm writes: > >>> Hi David, >>> I can work on to get the SVN commit access. >>> As a maintainer has to sponsor it would you mind being the one? >> >> https://www.gnu.org/software/gcc/svnwrite.html says: >> "a well-established GCC maintainer (including

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

David Malcolm writes: >> Hi David, >> I can work on to get the SVN commit access. >> As a maintainer has to sponsor it would you mind being the one? > > https://www.gnu.org/software/gcc/svnwrite.html says: > "a well-established GCC maintainer (including reviewers) can approve > for write access

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

Hi David, Andrea, On 7/2/19 3:46 PM, David Malcolm wrote: On Wed, 2019-06-26 at 15:05 +, Andrea Corallo wrote: > David Malcolm writes: > > > On Tue, 2019-06-25 at 08:11 +, Andrea Corallo wrote: > > > Hi, > > > third version for this patch with the simplified test. > > > > > > make

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

On Wed, 2019-06-26 at 15:05 +, Andrea Corallo wrote: > David Malcolm writes: > > > On Tue, 2019-06-25 at 08:11 +, Andrea Corallo wrote: > > > Hi, > > > third version for this patch with the simplified test. > > > > > > make check-jit pass clean > > > > > > Bests > > > Andrea > > > >

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

Andrea Corallo writes: > David Malcolm writes: > >> On Tue, 2019-06-25 at 08:11 +, Andrea Corallo wrote: >>> Hi, >>> third version for this patch with the simplified test. >>> >>> make check-jit pass clean >>> >>> Bests >>> Andrea >>> >>> 2019-06-09 Andrea Corallo andrea.cora...@arm.com

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

David Malcolm writes: > On Tue, 2019-06-25 at 08:11 +, Andrea Corallo wrote: >> Hi, >> third version for this patch with the simplified test. >> >> make check-jit pass clean >> >> Bests >> Andrea >> >> 2019-06-09 Andrea Corallo andrea.cora...@arm.com >> >> * libgccjit.c

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

On Tue, 2019-06-25 at 08:11 +, Andrea Corallo wrote: > Hi, > third version for this patch with the simplified test. > > make check-jit pass clean > > Bests > Andrea > > 2019-06-09 Andrea Corallo andrea.cora...@arm.com > > * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

Hi, third version for this patch with the simplified test. make check-jit pass clean Bests Andrea 2019-06-09 Andrea Corallo andrea.cora...@arm.com * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to be a numeric type. 2019-06-20 Andrea Corallo andrea.cora...@arm.com *

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

David Malcolm writes: > On Mon, 2019-06-24 at 16:37 +, Andrea Corallo wrote: >> David Malcolm writes: >> >> > On Mon, 2019-06-24 at 15:30 +, Andrea Corallo wrote: >> > > Hi all, >> > > second version for this patch. >> > > Given the suggestion for the bit-field one I've tried to improve

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

On Mon, 2019-06-24 at 16:37 +, Andrea Corallo wrote: > David Malcolm writes: > > > On Mon, 2019-06-24 at 15:30 +, Andrea Corallo wrote: > > > Hi all, > > > second version for this patch. > > > Given the suggestion for the bit-field one I've tried to improve > > > also > > > here the error

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

David Malcolm writes: > On Mon, 2019-06-24 at 15:30 +, Andrea Corallo wrote: >> Hi all, >> second version for this patch. >> Given the suggestion for the bit-field one I've tried to improve also >> here the error message. > > Thanks. > >> I've added a simple testcase as requested, here I'm

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

On Mon, 2019-06-24 at 15:30 +, Andrea Corallo wrote: > Hi all, > second version for this patch. > Given the suggestion for the bit-field one I've tried to improve also > here the error message. Thanks. > I've added a simple testcase as requested, here I'm trying to do > *void=int+int. > This

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

Hi all, second version for this patch. Given the suggestion for the bit-field one I've tried to improve also here the error message. I've added a simple testcase as requested, here I'm trying to do *void=int+int. This without checking would normally crash verifying gimple. More complex cases can

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

On Mon, 2019-06-10 at 09:15 +, Andrea Corallo wrote: > Hi all, > I would like to propose this patch to check for the return type of > binary operators to be a numeric type. > Not doing so can lead the compiler into funny crashes. > > Does not introduce regressions running make check-jit. > >

[PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

Hi all, I would like to propose this patch to check for the return type of binary operators to be a numeric type. Not doing so can lead the compiler into funny crashes. Does not introduce regressions running make check-jit. OK for trunk? Bests Andrea 2019-06-09 Andrea Corallo