Re: [PATCH] BRIG frontend: request for a global review

Hi, I added some content to gccbrig.texi in r254820 as below. If you have something that I could describe further there, please just let me know. Index: gcc/brig/gccbrig.texi === --- gcc/brig/gccbrig.texi (revision 254819) +++

Re: [PATCH] BRIG frontend: request for a global review

Hi, On Sun, Sep 17, 2017 at 02:13:34PM +0200, Thomas Schwinge wrote: > Hi! > > On Tue, 24 Jan 2017 15:30:34 -0500, David Malcolm wrote: > > On Tue, 2017-01-24 at 13:52 +0100, Martin Jambor wrote: > > > [...] I have just > > > committed the BRIG FE as revision 244867. > >

Re: [PATCH] BRIG frontend: request for a global review

Hi! On Tue, 24 Jan 2017 15:30:34 -0500, David Malcolm wrote: > On Tue, 2017-01-24 at 13:52 +0100, Martin Jambor wrote: > > [...] I have just > > committed the BRIG FE as revision 244867. In a build with that enabled, I just happened to "make html" in "gcc/", and ran into:

Re: [PATCH] BRIG frontend: request for a global review

Hi, I have just committed the patch, as it is, except that a couple of two-spaces-after Pekka's name in Changelogs had already been corrected (sorry for that mistake) and I have also On Fri, Jan 27, 2017 at 10:31:34AM +0200, Pekka Jääskeläinen wrote: > --- a/gcc/brig/ChangeLog > +++

Re: [PATCH] BRIG frontend: request for a global review

Hi Jakub and Matthias, New overall patch attached. My commit access is pending so I'm relying on Martin or someone else to get this committed for now. Added replies inline: On Thu, Jan 26, 2017 at 2:04 PM, Jakub Jelinek wrote: > Hi! > > On Thu, Jan 26, 2017 at 01:30:21PM

Re: [PATCH] BRIG frontend: request for a global review

Hi! On Thu, Jan 26, 2017 at 01:30:21PM +0200, Pekka Jääskeläinen wrote: > diff --git a/ChangeLog b/ChangeLog > index 9695f9d..6f4f256 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,9 @@ > +2017-01-26 Pekka Jskel??inen > + > + * configure.ac:

Re: [PATCH] BRIG frontend: request for a global review

Hi, Here's a patch which I believe should address all the pointed out BRIG FE related issues that have not been committed yet. I didn't introduce new fixed width int type nodes to tree.h as that felt too intrusive at this point. Also, changes.html is still to add. OK for trunk? BR, Pekka On

Re: [PATCH] BRIG frontend: request for a global review

On Thu, Jan 26, 2017 at 09:38:23AM +0200, Pekka Jääskeläinen wrote: > > I suppose that also contrib/update-copyright.py need to be updated? (I > > never looked into that, so don't know.) > > Does it? The files are (c) FSF now. What should I do here exactly? I took care of this and committed

Re: [PATCH] BRIG frontend: request for a global review

On Wed, Jan 25, 2017 at 6:07 PM, Thomas Schwinge wrote: > Hi! > > On Wed, 25 Jan 2017 13:21:13 +0100, Jakub Jelinek wrote: >> On Wed, Jan 25, 2017 at 11:00:50AM +0100, Thomas Schwinge wrote: >> > On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor

Re: [PATCH] BRIG frontend: request for a global review

Hi! On Wed, 25 Jan 2017 13:21:13 +0100, Jakub Jelinek wrote: > On Wed, Jan 25, 2017 at 11:00:50AM +0100, Thomas Schwinge wrote: > > On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor wrote: > > > [BRIG front end] $ git grep --cached libbrig

Re: [PATCH] BRIG frontend: request for a global review

On Wed, Jan 25, 2017 at 11:00:50AM +0100, Thomas Schwinge wrote: > Hi! > > On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor wrote: > > [BRIG front end] > > "contrib/gcc_update" needs to be updated for "libhsail-rt". > > > Here is a patch to fix some Autotools issues in

Re: [PATCH] BRIG frontend: request for a global review

Hi! On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor wrote: > [BRIG front end] "contrib/gcc_update" needs to be updated for "libhsail-rt". Here is a patch to fix some Autotools issues in libhsail-rt (currently testing); OK for trunk? commit

Re: [PATCH] BRIG frontend: request for a global review

On Tue, 2017-01-24 at 15:30 -0500, David Malcolm wrote: > On Tue, 2017-01-24 at 13:52 +0100, Martin Jambor wrote: > > Hi, > > > > On Mon, Jan 23, 2017 at 02:11:37PM +0100, Richard Biener wrote: > > > On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor > > > wrote: > > > > Hi, > > > >

Re: [PATCH] BRIG frontend: request for a global review

On Tue, 2017-01-24 at 13:52 +0100, Martin Jambor wrote: > Hi, > > On Mon, Jan 23, 2017 at 02:11:37PM +0100, Richard Biener wrote: > > On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor > > wrote: > > > Hi, > > > > > > > > > On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener

Re: [PATCH] BRIG frontend: request for a global review

Hi, On Mon, Jan 23, 2017 at 02:11:37PM +0100, Richard Biener wrote: > On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor wrote: > > Hi, > > > > > > On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote: > >> On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen

Re: [PATCH] BRIG frontend: request for a global review

On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor wrote: > Hi, > > > On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote: >> On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen >> wrote: >> > Hi Richard, >> > >> > On Fri, Jan 20, 2017 at 10:26 AM,

Re: [PATCH] BRIG frontend: request for a global review

Hi, On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote: > On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen > wrote: > > Hi Richard, > > > > On Fri, Jan 20, 2017 at 10:26 AM, Richard Biener > > wrote: > >> So the #ifdef

Re: [PATCH] BRIG frontend: request for a global review

On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen wrote: > Hi Richard, > > On Fri, Jan 20, 2017 at 10:26 AM, Richard Biener > wrote: >> So the #ifdef ENABLE_BRIG_FE shouldn't be needed anymore (nor the >> configury for it). >> >> Otherwise this

Re: [PATCH] BRIG frontend: request for a global review

On Thu, Jan 19, 2017 at 6:46 PM, Pekka Jääskeläinen wrote: > Hi Jakub and Richard, > > Attached is an updated BRIG FE patch which adds the HSAIL related > builtins only internally in the BRIG FE. I didn't add LTO support as I > believe it's not > useful for BRIG FE due to it

Re: [PATCH] BRIG frontend: request for a global review

Hi Jakub and Richard, Attached is an updated BRIG FE patch which adds the HSAIL related builtins only internally in the BRIG FE. I didn't add LTO support as I believe it's not useful for BRIG FE due to it always inputting fully linked BRIGs and not mixing with other frontends. BR, Pekka On

Re: [PATCH] BRIG frontend: request for a global review

OK, I'll see into adapting the Jakub's idea and also check if some of the simplest builtins are better expanded directly to tree nodes instead. I'm not sure if lto support is needed though as the assumption now is to have fully linked input to this FE (all necessary BRIG modules fed in at build

Re: [PATCH] BRIG frontend: request for a global review

On Mon, Jan 16, 2017 at 09:46:43AM +0100, Richard Biener wrote: > There are 187 of them (well, simple grep of DEF_HSAIL, so probably a bit > less). > They aren't really documented but I guess that __hsail_bitmask_u64 for example > is really equivalent to sth like -1U >> n << m? So I'm not sure

Re: [PATCH] BRIG frontend: request for a global review

On Fri, Jan 13, 2017 at 4:54 PM, Pekka Jääskeläinen wrote: > On Fri, Jan 13, 2017 at 2:34 PM, Richard Biener > wrote: >> On Thu, Jan 12, 2017 at 3:55 PM, Pekka Jääskeläinen >> wrote: >>> Hi, >>> >>> A gentle ping... >> >>

Re: [PATCH] BRIG frontend: request for a global review

On Fri, Jan 13, 2017 at 11:36 PM, Richard Biener wrote: > Ah, with fibers fixed there's only the fp16.c part left. Presumably LGPL > overall is OK as well (but I'm not a lawyer either). Seems fp16.c has the GPL3 runtime exception in place, so I believe we are good

Re: [PATCH] BRIG frontend: request for a global review

On January 13, 2017 4:43:30 PM GMT+01:00, "Pekka Jääskeläinen" wrote: >Hi Richard, > >Thanks for the review! Replies/questions inline. > >On Fri, Jan 13, 2017 at 2:28 PM, Richard Biener > wrote: >> On Thu, Jan 12, 2017 at 3:55 PM, Pekka

Re: [PATCH] BRIG frontend: request for a global review

On Fri, Jan 13, 2017 at 2:34 PM, Richard Biener wrote: > On Thu, Jan 12, 2017 at 3:55 PM, Pekka Jääskeläinen > wrote: >> Hi, >> >> A gentle ping... > > Looking at 002/ > > What's the reason of having brig-builtins.def? I do not see any >

Re: [PATCH] BRIG frontend: request for a global review

Hi Richard, Thanks for the review! Replies/questions inline. On Fri, Jan 13, 2017 at 2:28 PM, Richard Biener wrote: > On Thu, Jan 12, 2017 at 3:55 PM, Pekka Jääskeläinen > wrote: >> Hi, >> >> A gentle ping... > > diff --git a/gcc/configure.ac

Re: [PATCH] BRIG frontend: request for a global review

Hi, A gentle ping... On Wed, Dec 14, 2016 at 7:15 PM, Pekka Jääskeläinen wrote: > Hi, > > I'm calling for a global review for the BRIG frontend for inclusion in > upstream. > The copyright transfer has been taken care of. > > The patch set has been approved by Martin