Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-27 Thread Jeff Law
On 09/27/2016 11:29 AM, Martin Sebor wrote: On 09/26/2016 02:30 AM, Gerald Pfeifer wrote: Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-27 Thread Martin Sebor
On 09/27/2016 11:29 AM, Martin Sebor wrote: On 09/26/2016 02:30 AM, Gerald Pfeifer wrote: Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-27 Thread Martin Sebor
On 09/26/2016 02:30 AM, Gerald Pfeifer wrote: Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at gimple-ssa-sprintf.c:1165 four or so days ago.

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-26 Thread Gerald Pfeifer
Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at gimple-ssa-sprintf.c:1165 four or so days ago. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77740 has

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-23 Thread Martin Sebor
On 09/22/2016 01:46 AM, Marek Polacek wrote: On Thu, Sep 22, 2016 at 09:24:11AM +0200, Jakub Jelinek wrote: On Wed, Sep 21, 2016 at 06:38:54PM -0600, Martin Sebor wrote: On 09/21/2016 09:09 AM, Jakub Jelinek wrote: When looking at PR77676, I've noticed various small formatting etc. issues,

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-22 Thread Martin Sebor
What I would be even more grateful for is a review of the error prone parts like those that caused the bootstrap failure. I.e., any lingering assumptions about integer sizes between the host I must say I'm surprised you do all your computations in HOST_WIDE_INT, rather than say in wide_int,

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-22 Thread Marek Polacek
On Thu, Sep 22, 2016 at 09:24:11AM +0200, Jakub Jelinek wrote: > On Wed, Sep 21, 2016 at 06:38:54PM -0600, Martin Sebor wrote: > > On 09/21/2016 09:09 AM, Jakub Jelinek wrote: > > >When looking at PR77676, I've noticed various small formatting etc. > > >issues, like not using is_gimple_* APIs

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-22 Thread Jakub Jelinek
On Wed, Sep 21, 2016 at 06:38:54PM -0600, Martin Sebor wrote: > On 09/21/2016 09:09 AM, Jakub Jelinek wrote: > >When looking at PR77676, I've noticed various small formatting etc. > >issues, like not using is_gimple_* APIs where we have them, not using > >gimple_call_builtin_p/gimple_call_fndecl

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-21 Thread Martin Sebor
On 09/21/2016 09:09 AM, Jakub Jelinek wrote: Hi! When looking at PR77676, I've noticed various small formatting etc. issues, like not using is_gimple_* APIs where we have them, not using gimple_call_builtin_p/gimple_call_fndecl (this one actually can show up, if e.g. uses the builtin with

[PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-21 Thread Jakub Jelinek
Hi! When looking at PR77676, I've noticed various small formatting etc. issues, like not using is_gimple_* APIs where we have them, not using gimple_call_builtin_p/gimple_call_fndecl (this one actually can show up, if e.g. uses the builtin with incorrect arguments (fewer, different types etc.)),