Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2017-01-11 Thread Andre Vieira (lists)
On 06/01/17 15:47, Jeff Law wrote: > On 01/06/2017 03:53 AM, Andre Vieira (lists) wrote: >> On 09/12/16 16:31, Bernd Schmidt wrote: >>> On 12/09/2016 05:16 PM, Andre Vieira (lists) wrote: >>> Regardless, 'reload_cse_simplify' would never perform the opposite transformation. It checks

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2017-01-06 Thread Jeff Law
On 01/06/2017 03:53 AM, Andre Vieira (lists) wrote: On 09/12/16 16:31, Bernd Schmidt wrote: On 12/09/2016 05:16 PM, Andre Vieira (lists) wrote: Regardless, 'reload_cse_simplify' would never perform the opposite transformation. It checks whether it can replace anything within the first

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2017-01-06 Thread Andre Vieira (lists)
On 09/12/16 16:31, Bernd Schmidt wrote: > On 12/09/2016 05:16 PM, Andre Vieira (lists) wrote: > >> Regardless, 'reload_cse_simplify' would never perform the opposite >> transformation. It checks whether it can replace anything within the >> first argument INSN, with the second argument TESTREG.

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-12 Thread Christophe Lyon
Hi Andre, On 9 December 2016 at 17:16, Andre Vieira (lists) wrote: > On 09/12/16 16:02, Ramana Radhakrishnan wrote: >> On Fri, Dec 9, 2016 at 3:58 PM, Bernd Schmidt wrote: >>> On 12/09/2016 04:34 PM, Andre Vieira (lists) wrote: >>>

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Bernd Schmidt
On 12/09/2016 05:16 PM, Andre Vieira (lists) wrote: Regardless, 'reload_cse_simplify' would never perform the opposite transformation. It checks whether it can replace anything within the first argument INSN, with the second argument TESTREG. As the name implies this will always be a register.

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Andre Vieira (lists)
On 09/12/16 16:02, Ramana Radhakrishnan wrote: > On Fri, Dec 9, 2016 at 3:58 PM, Bernd Schmidt wrote: >> On 12/09/2016 04:34 PM, Andre Vieira (lists) wrote: >> >>> Regardless, the other testcases I add in this patch show a sub-optimal >>> transformation done by postreload,

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Ramana Radhakrishnan
On Fri, Dec 9, 2016 at 3:58 PM, Bernd Schmidt wrote: > On 12/09/2016 04:34 PM, Andre Vieira (lists) wrote: > >> Regardless, the other testcases I add in this patch show a sub-optimal >> transformation done by postreload, turning direct calls into indirect >> calls, for

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Jeff Law
On 12/09/2016 08:02 AM, Bernd Schmidt wrote: On 12/09/2016 03:03 PM, Andre Vieira (lists) wrote: This patch fixes the issue reported in PR78255 by making postreload aware it should not be performing CSE on functions if NO_FUNCTION_CSE is defined to true. Bootstrap and full regression on

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Bernd Schmidt
On 12/09/2016 04:34 PM, Andre Vieira (lists) wrote: Regardless, the other testcases I add in this patch show a sub-optimal transformation done by postreload, turning direct calls into indirect calls, for targets which have specifically pointed out that no CSE should be done on functions through

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Wilco Dijkstra
Bernd wrote: > Hmm, it probably doesn't hurt, but looking at the PR I think the originally > reported problem > suggests you need a different fix: a separate register class to be used for > indirect sibling calls. > I remember seeing similar issues on other targets. The only safe way to

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Andre Vieira (lists)
On 09/12/16 15:02, Bernd Schmidt wrote: > On 12/09/2016 03:03 PM, Andre Vieira (lists) wrote: >> This patch fixes the issue reported in PR78255 by making postreload >> aware it should not be performing CSE on functions if NO_FUNCTION_CSE is >> defined to true. >> >> Bootstrap and full regression

Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Bernd Schmidt
On 12/09/2016 03:03 PM, Andre Vieira (lists) wrote: This patch fixes the issue reported in PR78255 by making postreload aware it should not be performing CSE on functions if NO_FUNCTION_CSE is defined to true. Bootstrap and full regression on arm-none-linux-gnueabihf and

[PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE

2016-12-09 Thread Andre Vieira (lists)
Hi, This patch fixes the issue reported in PR78255 by making postreload aware it should not be performing CSE on functions if NO_FUNCTION_CSE is defined to true. Bootstrap and full regression on arm-none-linux-gnueabihf and aarch64-unknown-linux-gnu. Also checked this fixed the reported issue