.
Sounds good, like so?
Let's leave a comment about why there's no 'default'. OK with that change.
-- >8 --
Subject: [PATCH] c++: ICE with failed __is_constructible constraint [PR100474]
Here we're crashing when diagnosing a failed __is_constructible constraint
because diagnose_trait_e
andled in switch [-Wswitch\
> > constraint.cc:3585:10: warning: enumeration value
> > ‘CPTK_IS_NOTHROW_CONSTRUCTIBLE’ not handled in switch [-Wswi\
>
> These we should.
>
> I think we should leave off the default so that when we add more traits we get
> a warning that
On 3/29/22 15:22, Patrick Palka wrote:
Here we're crashing when diagnosing a failed __is_constructible constraint
because diagnose_atomic_constraint don't know how to diagnose a trait
that diagnose_trait_expr doesn't specifically handle. This patch fixes
this by falling through to the default
Here we're crashing when diagnosing a failed __is_constructible constraint
because diagnose_atomic_constraint don't know how to diagnose a trait
that diagnose_trait_expr doesn't specifically handle. This patch fixes
this by falling through to the default case in this situation.
Bootstrapped and
