Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

Hi! On 2020-11-03T09:17:49+0100, I wrote: > I've just pushed "[OpenACC] More precise diagnostics for 'gang', > 'worker', 'vector' clauses with arguments on 'loop' only allowed in > 'kernels' regions" to master branch in commit > beddd1762ad2bbe84dd776c54489153f83f21e56, and backported to >

Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

Hi! On 2019-12-10T15:23:01+0100, Frederik Harwath wrote: > On 09.12.19 16:58, Harwath, Frederik wrote: >> [use] the location of clauses in warnings instead of the location of the >> loop to which the clause belongs. > Frederik Harwath (2): > Use clause locations in OpenACC nested reduction

Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

Hi Thomas, On 10.12.19 15:44, Thomas Schwinge wrote: > Thanks, yes, with my following remarks considered, and acted on per your > preference. To record the review effort, please include "Reviewed-by: > Thomas Schwinge " in the commit log, see > . Committed

Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

Hi Thomas, On 10.12.19 15:44, Thomas Schwinge wrote: >> Frederik Harwath (2): >> Use clause locations in OpenACC nested reduction warnings >> Add tests to verify OpenACC clause locations > > I won't insist, but suggest (common practice) to merge that into one > patch: bug fix plus test

Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

Hi Frederik! On 2019-12-10T15:23:01+0100, Frederik Harwath wrote: > On 09.12.19 16:58, Harwath, Frederik wrote: >> Tobias has recently fixed a problem with the column information in gfortran >> locations >> [...] >> I have tested the patch manually by adapting the validity check for nested >>

[PATCH 0/2] Add tests to verify OpenACC clause locations

Hi, On 09.12.19 16:58, Harwath, Frederik wrote: > Tobias has recently fixed a problem with the column information in gfortran > locations > [...] > I have tested the patch manually by adapting the validity check for nested > OpenACC reductions (see omp-low.c) > to include the location of