Re: [PATCH 2/3] Matching tokens: C parts (v2)

2017-08-09 Thread Marek Polacek
On Tue, Aug 08, 2017 at 04:37:28PM -0400, David Malcolm wrote: > Jason said (for the C++ part of the patch): > > About passing parser in or not, I'm happy with the current approach; > > adding things to the stack isn't free in a highly recursive program > > like GCC. > (in

Re: [PATCH 2/3] Matching tokens: C parts (v2)

2017-08-08 Thread David Malcolm
On Fri, 2017-08-04 at 12:09 -0600, Jeff Law wrote: > On 08/04/2017 08:32 AM, David Malcolm wrote: > > On Thu, 2017-08-03 at 11:34 -0600, Jeff Law wrote: > > > On 08/01/2017 02:21 PM, David Malcolm wrote: > > > > Changed in v2: > > > > > > > > * Renamed template argument to traits_t; eliminated

Re: [PATCH 2/3] Matching tokens: C parts (v2)

2017-08-04 Thread Jeff Law
On 08/04/2017 08:32 AM, David Malcolm wrote: > On Thu, 2017-08-03 at 11:34 -0600, Jeff Law wrote: >> On 08/01/2017 02:21 PM, David Malcolm wrote: >>> Changed in v2: >>> >>> * Renamed template argument to traits_t; eliminated subclasses, >>> just >>> using traits struct. >>> * Moved enum

Re: [PATCH 2/3] Matching tokens: C parts (v2)

2017-08-04 Thread David Malcolm
On Thu, 2017-08-03 at 11:34 -0600, Jeff Law wrote: > On 08/01/2017 02:21 PM, David Malcolm wrote: > > Changed in v2: > > > > * Renamed template argument to traits_t; eliminated subclasses, > > just > > using traits struct. > > * Moved enum constants into struct bodies (string constants can't >

Re: [PATCH 2/3] Matching tokens: C parts (v2)

2017-08-03 Thread Jeff Law
On 08/01/2017 02:21 PM, David Malcolm wrote: > Changed in v2: > > * Renamed template argument to traits_t; eliminated subclasses, just > using traits struct. > * Moved enum constants into struct bodies (string constants can't be > without constexpr, which isn't available in C++98). > * Fixed

[PATCH 2/3] Matching tokens: C parts (v2)

2017-08-01 Thread David Malcolm
Changed in v2: * Renamed template argument to traits_t; eliminated subclasses, just using traits struct. * Moved enum constants into struct bodies (string constants can't be without constexpr, which isn't available in C++98). * Fixed typo. OK for trunk? gcc/c/ChangeLog: * c-parser.c