Re: [PATCH 3/4]AArch64: correct dot-product RTL patterns for aarch64.

2021-07-26 Thread Richard Sandiford via Gcc-patches
> Sent: Thursday, July 22, 2021 7:11 PM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw >> ; Marcus Shawcroft >> ; Kyrylo Tkachov >> Subject: Re: [PATCH 3/4]AArch64: correct dot-product RTL patterns for >> aarch64. >>

RE: [PATCH 3/4]AArch64: correct dot-product RTL patterns for aarch64.

2021-07-23 Thread Tamar Christina via Gcc-patches
shaw > ; Marcus Shawcroft > ; Kyrylo Tkachov > Subject: Re: [PATCH 3/4]AArch64: correct dot-product RTL patterns for > aarch64. > > Tamar Christina writes: > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > > > Ok for master? > > > >

Re: [PATCH 3/4]AArch64: correct dot-product RTL patterns for aarch64.

2021-07-22 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for master? > > Thanks, > Tamar > > gcc/ChangeLog: > > * config/aarch64/aarch64-simd-builtins.def (sdot, udot): Rename to.. > (sdot_prod, udot_prod): ... This. > *

RE: [PATCH 3/4]AArch64: correct dot-product RTL patterns for aarch64.

2021-07-22 Thread Tamar Christina via Gcc-patches
n __inline int32x2_t __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) vdot_s32 (int32x2_t __r, int8x8_t __a, int8x8_t __b) { - return __builtin_aarch64_sdotv8qi (__r, __a, __b); + return __builtin_aarch64_sdot_prodv8qi (__a, __b, __r); } __extension__ extern __inline int3

Re: [PATCH 3/4]AArch64: correct dot-product RTL patterns for aarch64.

2021-07-15 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi All, > > The previous fix for this problem was wrong due to a subtle difference between > where NEON expects the RMW values and where intrinsics expects them. > > The insn pattern is modeled after the intrinsics and so needs an expand for > the vectorizer optab to

[PATCH 3/4]AArch64: correct dot-product RTL patterns for aarch64.

2021-07-15 Thread Tamar Christina via Gcc-patches
Hi All, The previous fix for this problem was wrong due to a subtle difference between where NEON expects the RMW values and where intrinsics expects them. The insn pattern is modeled after the intrinsics and so needs an expand for the vectorizer optab to switch the RTL. However operand[3] is