Re: [PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-18 Thread H.J. Lu
On Mon, Jun 16, 2025 at 4:28 PM Hongtao Liu wrote: > > On Mon, Jun 16, 2025 at 4:30 PM Hongtao Liu wrote: > > > > >+enum redundant_load_kind > > >+{ > > >+ LOAD_CONST0_VECTOR, > > >+ LOAD_CONSTM1_VECTOR, > > >+ LOAD_VECTOR > > >+}; > > Perhaps rename to x86_cse_kind, X86_CSE_CONST0_VECTOR, > >

Re: [PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-18 Thread H.J. Lu
On Wed, Jun 18, 2025 at 2:55 PM Hongtao Liu wrote: > > On Wed, Jun 18, 2025 at 2:39 PM H.J. Lu wrote: > > > > On Mon, Jun 16, 2025 at 4:14 PM Hongtao Liu wrote: > > > > > > >+enum redundant_load_kind > > > >+{ > > > >+ LOAD_CONST0_VECTOR, > > > >+ LOAD_CONSTM1_VECTOR, > > > >+ LOAD_VECTOR > >

Re: [PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-17 Thread Hongtao Liu
On Wed, Jun 18, 2025 at 2:39 PM H.J. Lu wrote: > > On Mon, Jun 16, 2025 at 4:14 PM Hongtao Liu wrote: > > > > >+enum redundant_load_kind > > >+{ > > >+ LOAD_CONST0_VECTOR, > > >+ LOAD_CONSTM1_VECTOR, > > >+ LOAD_VECTOR > > >+}; > > Perhaps rename to x86_cse_kind, X86_CSE_CONST0_VECTOR, > > X86

Re: [PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-17 Thread H.J. Lu
On Mon, Jun 16, 2025 at 4:14 PM Hongtao Liu wrote: > > >+enum redundant_load_kind > >+{ > >+ LOAD_CONST0_VECTOR, > >+ LOAD_CONSTM1_VECTOR, > >+ LOAD_VECTOR > >+}; > Perhaps rename to x86_cse_kind, X86_CSE_CONST0_VECTOR, > X86_CSE_CONSTM1_VECTOR, X86_CSE_VEC_DUP? Fixed. > LOAD sounds a bit amb

Re: [PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-16 Thread Hongtao Liu
On Mon, Jun 16, 2025 at 4:30 PM Hongtao Liu wrote: > > >+enum redundant_load_kind > >+{ > >+ LOAD_CONST0_VECTOR, > >+ LOAD_CONSTM1_VECTOR, > >+ LOAD_VECTOR > >+}; > Perhaps rename to x86_cse_kind, X86_CSE_CONST0_VECTOR, > X86_CSE_CONSTM1_VECTOR, X86_CSE_VEC_DUP? > LOAD sounds a bit ambiguous. >

Re: [PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-16 Thread Hongtao Liu
>+enum redundant_load_kind >+{ >+ LOAD_CONST0_VECTOR, >+ LOAD_CONSTM1_VECTOR, >+ LOAD_VECTOR >+}; Perhaps rename to x86_cse_kind, X86_CSE_CONST0_VECTOR, X86_CSE_CONSTM1_VECTOR, X86_CSE_VEC_DUP? LOAD sounds a bit ambiguous. Similar to ix86_get_vector_load_mode -> ix86_get_vector_cse_mode? >+

[PATCH v2 x86: Extend the remove_redundant_vector pass

2025-06-12 Thread H.J. Lu
x}; + s1 = __extension__(v4si){0x22222222,0x2222,0x2222,0x}; + l1 = __extension__(v2di){0xULL,0xULL}; + b2 = __extension__(v32qi){0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, + 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, + 0x22