Re: [Patch] OpenMP: Add ME support for 'omp allocate' stack variables

2023-10-18 Thread Thomas Schwinge
Hi Tobias! On 2023-10-18T11:53:30+0200, Tobias Burnus wrote: > On 18.10.23 11:44, Thomas Schwinge wrote: >> No need to change anything now, but in case that's useful later: >> [...] >> ..., just noting that '{ target c }', '{ target c++ }' are trivial to >> implement; see libgomp OpenACC

Re: [Patch] OpenMP: Add ME support for 'omp allocate' stack variables

2023-10-18 Thread Tobias Burnus
Hi Thomas, On 18.10.23 11:44, Thomas Schwinge wrote: No need to change anything now, but in case that's useful later: [...] ..., just noting that '{ target c }', '{ target c++ }' are trivial to implement; see libgomp OpenACC testing: libgomp/testsuite/libgomp.oacc-c/c.exp:proc

Re: [Patch] OpenMP: Add ME support for 'omp allocate' stack variables

2023-10-18 Thread Thomas Schwinge
Hi Tobias! No need to change anything now, but in case that's useful later: On 2023-09-18T14:22:50+0200, Tobias Burnus wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c/allocate-4.c > @@ -0,0 +1,84 @@ > +/* TODO: move to ../libgomp.c-c++-common once C++ is implemented. */ > +/* NOTE: {

[committed] libgomp.fortran/allocate-6.f90: Run with -fdump-tree-gimple (was: [Patch] OpenMP: Add ME support for 'omp allocate' stack variables)

2023-10-14 Thread Tobias Burnus
I wonder why I missed the following – but it now works :-/ Tobias - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München;

Re: [Patch] OpenMP: Add ME support for 'omp allocate' stack variables

2023-09-20 Thread Jakub Jelinek
On Mon, Sep 18, 2023 at 02:22:50PM +0200, Tobias Burnus wrote: > The attached patch now actually adds GOMP_alloc/free calls for 'omp allocate'. > > Besides the addition of the calls and the value expression, it also had to > deal with > (implicit) mapping/privatization - such that

[Patch] OpenMP: Add ME support for 'omp allocate' stack variables

2023-09-18 Thread Tobias Burnus
The attached patch now actually adds GOMP_alloc/free calls for 'omp allocate'. Besides the addition of the calls and the value expression, it also had to deal with (implicit) mapping/privatization - such that 'default(none)' did not wrongly trigger for the value expression (and categorizes the