Re: [RS6000] power8 internal compiler errors

2014-02-14 Thread David Edelsohn
On Fri, Feb 14, 2014 at 2:18 AM, Alan Modra wrote: > On Wed, Feb 12, 2014 at 06:47:37PM +0100, Ulrich Weigand wrote: >> Note that find_replacement itself already recurses into both sides >> of a PLUS. > > Thanks, I missed seeing that. I'd analysed the bug and knew what > needed doing from past fo

Re: [RS6000] power8 internal compiler errors

2014-02-13 Thread Alan Modra
On Wed, Feb 12, 2014 at 06:47:37PM +0100, Ulrich Weigand wrote: > Note that find_replacement itself already recurses into both sides > of a PLUS. Thanks, I missed seeing that. I'd analysed the bug and knew what needed doing from past forays into reload, so went looking for ways to get at the relo

Re: [RS6000] power8 internal compiler errors

2014-02-12 Thread Ulrich Weigand
David Edelsohn wrote: > On Mon, Feb 10, 2014 at 8:33 PM, Alan Modra wrote: > > On Mon, Feb 10, 2014 at 07:01:03PM -0500, David Edelsohn wrote: > >> On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: > >> > >> Shouldn't addr_op2 also be set from find_replacement? > > > > Sorry, I thought after I s

Re: [RS6000] power8 internal compiler errors

2014-02-12 Thread David Edelsohn
On Mon, Feb 10, 2014 at 8:33 PM, Alan Modra wrote: > On Mon, Feb 10, 2014 at 07:01:03PM -0500, David Edelsohn wrote: >> On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: >> >> Shouldn't addr_op2 also be set from find_replacement? > > Sorry, I thought after I sent the email that I should have add

Re: [RS6000] power8 internal compiler errors

2014-02-10 Thread David Edelsohn
On Mon, Feb 10, 2014 at 8:33 PM, Alan Modra wrote: > On Mon, Feb 10, 2014 at 07:01:03PM -0500, David Edelsohn wrote: >> On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: >> >> Shouldn't addr_op2 also be set from find_replacement? > > Sorry, I thought after I sent the email that I should have add

Re: [RS6000] power8 internal compiler errors

2014-02-10 Thread Alan Modra
On Mon, Feb 10, 2014 at 07:01:03PM -0500, David Edelsohn wrote: > On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: > > Shouldn't addr_op2 also be set from find_replacement? Sorry, I thought after I sent the email that I should have added some explanation of why certain parts need find_replacem

Re: [RS6000] power8 internal compiler errors

2014-02-10 Thread David Edelsohn
On Mon, Feb 10, 2014 at 5:18 PM, Alan Modra wrote: Shouldn't addr_op2 also be set from find_replacement? - David > @@ -16201,7 +16200,7 @@ > || !rs6000_legitimate_offset_address_p (PTImode, addr, > false, true))) > { >

[RS6000] power8 internal compiler errors

2014-02-10 Thread Alan Modra
Since reload may make multiple passes through insns, rtl seen during reload can look a little messy. On the second and subsequent passes you get to see any transformations made on previous passes. The rtl sanity checks in rs6000_secondary_reload_inner didn't take this fact into account, leading t