Re: [patch] Performance patch for MIPS conditional move in expr.c

2013-03-07 Thread Jakub Jelinek
On Wed, Nov 14, 2012 at 02:22:33PM -0800, Andrew Pinski wrote: commit 8ca1e58de404bbe82b93bc240ef28c68c681243d Author: Andrew Pinski apin...@cavium.com Date: Thu Jul 26 18:09:34 2012 -0700 2012-07-26 Andrew Pinski apin...@cavium.com Bug #3261 * config/mips/mips.md

Re: [patch] Performance patch for MIPS conditional move in expr.c

2013-03-07 Thread Andrew Pinski
On Thu, Mar 7, 2013 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 14, 2012 at 02:22:33PM -0800, Andrew Pinski wrote: commit 8ca1e58de404bbe82b93bc240ef28c68c681243d Author: Andrew Pinski apin...@cavium.com Date: Thu Jul 26 18:09:34 2012 -0700 2012-07-26 Andrew Pinski

Re: [patch] Performance patch for MIPS conditional move in expr.c

2013-01-07 Thread Steve Ellcey
On Thu, 2012-11-15 at 13:39 -0800, Andrew Pinski wrote: I was posting it for Steve's benefit really. I was in the process of updating the patch to the trunk and trying it out there before doing a formal submission :). As I found out the testcase needs to be changed to work with the new

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-15 Thread Richard Sandiford
Andrew Pinski andrew.pin...@caviumnetworks.com writes: 2012-07-26 Andrew Pinski apin...@cavium.com Bug #3261 * config/mips/mips.md (*movGPR:mode_on_MOVECC:mode): Remove mode check from comparisons. (*movSCALARF:mode_on_MOVECC:mode): Likewise.

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-15 Thread Andrew Pinski
On Thu, Nov 15, 2012 at 12:58 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Andrew Pinski andrew.pin...@caviumnetworks.com writes: 2012-07-26 Andrew Pinski apin...@cavium.com Bug #3261 * config/mips/mips.md (*movGPR:mode_on_MOVECC:mode): Remove mode check

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-15 Thread Andrew Pinski
On Thu, Nov 15, 2012 at 1:24 PM, Andrew Pinski andrew.pin...@caviumnetworks.com wrote: On Thu, Nov 15, 2012 at 12:58 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Andrew Pinski andrew.pin...@caviumnetworks.com writes: 2012-07-26 Andrew Pinski apin...@cavium.com Bug

[patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
Back in August of 2011, Richard Biener made a change affecting COND_EXPRs (r178408). As a result of that change the GCC MIPS compiler that used to promote HImode variables to SImode and then put out SImode variables and assignments for the conditional move (MIPS doesn't support HImode

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 11:02 AM, Steve Ellcey sell...@mips.com wrote: Back in August of 2011, Richard Biener made a change affecting COND_EXPRs (r178408). As a result of that change the GCC MIPS compiler that used to promote HImode variables to SImode and then put out SImode variables and

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
On Wed, 2012-11-14 at 11:15 -0800, Andrew Pinski wrote: Do you have a testcase? As I added expand_cond_expr_using_cmove, I think this is the correct fix. Thanks, Andrew Pinski Here is a cutdown test case that I have been compiling with -O3, if you compare with and without my patch you

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 11:27 AM, Steve Ellcey sell...@mips.com wrote: On Wed, 2012-11-14 at 11:15 -0800, Andrew Pinski wrote: Do you have a testcase? As I added expand_cond_expr_using_cmove, I think this is the correct fix. Thanks, Andrew Pinski Here is a cutdown test case that I have

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote: I know exactly where this code comes from; I have looked at the benchmark as one of the reason why I add expand_cond_expr_using_cmove in the first place. Anyways you should look into removing TARGET_PROMOTE_PROTOTYPES because I found

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 1:45 PM, Steve Ellcey sell...@mips.com wrote: On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote: I know exactly where this code comes from; I have looked at the benchmark as one of the reason why I add expand_cond_expr_using_cmove in the first place. Anyways you

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 1:51 PM, Andrew Pinski andrew.pin...@caviumnetworks.com wrote: On Wed, Nov 14, 2012 at 1:45 PM, Steve Ellcey sell...@mips.com wrote: On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote: I know exactly where this code comes from; I have looked at the benchmark as one

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Richard Henderson
On 2012-11-14 11:02, Steve Ellcey wrote: 2012-11-14 Steve Ellcey sell...@mips.com * expr.c (expand_cond_expr_using_cmove): Use promoted mode for temp. Ok. r~