Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-17 Thread Jeff Law
On 11/14/14 10:29, Zamyatin, Igor wrote: On Fri, Nov 14, 2014 at 05:05:57PM +, Zamyatin, Igor wrote: It is not that easy, -fsanitize=address is not supported everywhere. Better if you stick it into testsuite/gcc.dg/asan/ No point adding effective- target ia32/fpic, there is nothing i?86

RE: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread Zamyatin, Igor
ChangeLog: 2014-10-30 Igor Zamyatin igor.zamya...@intel.com * function.c (assign_parms): Move init of pic_offset_table_rtx from here to... * cfgexpand.c (expand_used_vars): ...here. The patch is probably fine. However, it would be good to have the

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 8:59 AM, Zamyatin, Igor igor.zamya...@intel.com wrote: ChangeLog: 2014-10-30 Igor Zamyatin igor.zamya...@intel.com * function.c (assign_parms): Move init of pic_offset_table_rtx from here to... * cfgexpand.c (expand_used_vars): ...here.

RE: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread Zamyatin, Igor
On Fri, Nov 14, 2014 at 8:59 AM, Zamyatin, Igor igor.zamya...@intel.com wrote: ChangeLog: 2014-10-30 Igor Zamyatin igor.zamya...@intel.com * function.c (assign_parms): Move init of pic_offset_table_rtx from here to... * cfgexpand.c

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 05:05:57PM +, Zamyatin, Igor wrote: --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr63845.c @@ -0,0 +1,20 @@ +/* PR sanitizer/63845 */ +/* { dg-do compile } */ +/* { dg-require-effective-target ia32 } */ +/* { dg-require-effective-target fpic }

RE: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread Zamyatin, Igor
On Fri, Nov 14, 2014 at 05:05:57PM +, Zamyatin, Igor wrote: It is not that easy, -fsanitize=address is not supported everywhere. Better if you stick it into testsuite/gcc.dg/asan/ No point adding effective- target ia32/fpic, there is nothing i?86 specific, not even ix86/x86_64

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-13 Thread H.J. Lu
On Wed, Nov 5, 2014 at 7:17 AM, Zamyatin, Igor igor.zamya...@intel.com wrote: Hi! Following patch (moving initialization of pic_offset_table_rtx earlier) fixes failures for asan tests on 32 bits in PIC mode mentioned here - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63534#c48

RE: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-05 Thread Zamyatin, Igor
Hi! Following patch (moving initialization of pic_offset_table_rtx earlier) fixes failures for asan tests on 32 bits in PIC mode mentioned here - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63534#c48 Bootstrapped/regtested on x86_64, i686 Is it ok for trunk? ChangeLog:

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-10-31 Thread Jeff Law
On 10/31/14 09:34, Zamyatin, Igor wrote: Hi! Following patch (moving initialization of pic_offset_table_rtx earlier) fixes failures for asan tests on 32 bits in PIC mode mentioned here - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63534#c48 Bootstrapped/regtested on x86_64, i686 Is it ok