Re: [PATCH 2/4][AArch64] Add support for FCCMP

2015-11-13 Thread Evandro Menezes
Hi, Wilco. It looks good to me, but FCMP is quite different from FCCMP on Exynos M1, so it'd be helpful to have distinct types for them. Say, "fcmp{s,d}" and "fccmp{s,d}". Would it be acceptable to add this with this patch or later? Thank you. -- Evandro Menezes On 11/13/2015 10:02 AM,

RE: [PATCH 2/4][AArch64] Add support for FCCMP

2015-11-13 Thread Wilco Dijkstra
> Evandro Menezes wrote: > Hi, Wilco. > > It looks good to me, but FCMP is quite different from FCCMP on Exynos M1, > so it'd be helpful to have distinct types for them. Say, "fcmp{s,d}" > and "fccmp{s,d}". Would it be acceptable to add this with this patch or > later? It would be easy to add

Re: [PATCH 2/4][AArch64] Add support for FCCMP

2015-11-13 Thread Evandro Menezes
On 11/13/2015 11:36 AM, Wilco Dijkstra wrote: Evandro Menezes wrote: Hi, Wilco. It looks good to me, but FCMP is quite different from FCCMP on Exynos M1, so it'd be helpful to have distinct types for them. Say, "fcmp{s,d}" and "fccmp{s,d}". Would it be acceptable to add this with this patch or

Re: [PATCH 2/4][AArch64] Add support for FCCMP

2015-11-13 Thread Andrew Pinski
On Sat, Nov 14, 2015 at 1:36 AM, Wilco Dijkstra wrote: >> Evandro Menezes wrote: >> Hi, Wilco. >> >> It looks good to me, but FCMP is quite different from FCCMP on Exynos M1, >> so it'd be helpful to have distinct types for them. Say, "fcmp{s,d}" >> and "fccmp{s,d}".