On Mar 9, 2021, Segher Boessenkool wrote:
> Hi!
> On Wed, Mar 03, 2021 at 06:07:29PM -0300, Alexandre Oliva wrote:
>> On Mar 3, 2021, Segher Boessenkool wrote:
>> It's skipping the test, as the change you propose, that reduces testing
>> surface, when testing only a configuration that ends up
Hi!
On Wed, Mar 03, 2021 at 06:07:29PM -0300, Alexandre Oliva wrote:
> On Mar 3, 2021, Segher Boessenkool wrote:
> It's skipping the test, as the change you propose, that reduces testing
> surface, when testing only a configuration that ends up skipping it.
Not at all. There are very many
On Mar 3, 2021, Segher Boessenkool wrote:
> On Wed, Mar 03, 2021 at 04:45:23PM -0300, Alexandre Oliva wrote:
>> On Mar 2, 2021, Segher Boessenkool wrote:
>>
>> > This is PR99352 now.
>>
>> Thanks. I've filed PR99371 for the add_options_for_sqrt_insn
>> incompleteness,
> As I said before,
On Wed, Mar 03, 2021 at 04:45:23PM -0300, Alexandre Oliva wrote:
> On Mar 2, 2021, Segher Boessenkool wrote:
>
> > This is PR99352 now.
>
> Thanks. I've filed PR99371 for the add_options_for_sqrt_insn
> incompleteness,
As I said before, I don't agree with that. We do no longer support
hi!
On Wed, Mar 03, 2021 at 04:22:29PM -0300, Alexandre Oliva wrote:
> While we could hide the bug/missing feature in add_options_for_sqrt_insn
> by constraining check_effective_target_sqrt_insn, the result would be
> just reduced test coverage for powerpc builds that defaulted to
>
On Mar 2, 2021, Segher Boessenkool wrote:
> This is PR99352 now.
Thanks. I've filed PR99371 for the add_options_for_sqrt_insn
incompleteness, and PR99372 for the gimplefe-28.c ICE.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain
On Mar 2, 2021, David Edelsohn wrote:
> The procs are used in more than that one test.
Err, are you looking at the trunk? In my tree, there are only two tests
that mention sqrt_insn, and it's two rather than one just because I
added the flag to another test myself, in a patch yet to be
On Tue, Mar 02, 2021 at 08:13:51AM -0300, Alexandre Oliva wrote:
> On Feb 26, 2021, Segher Boessenkool wrote:
> > You should essentially never use -mpowerpc-gpopt, but instead use a
> > -mcpu= that has it. You also of course whould not do that in run tests
> > if the cpu does not support those
On Tue, Mar 2, 2021 at 8:48 AM Richard Sandiford
wrote:
>
> Alexandre Oliva writes:
> > On Feb 26, 2021, Segher Boessenkool wrote:
> >
> >> On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote:
> >>> On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva
> >>> wrote:
> >>> >
> >>> > This
Alexandre Oliva writes:
> On Feb 26, 2021, Segher Boessenkool wrote:
>
>> On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote:
>>> On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote:
>>> >
>>> > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
>>> > tests.
Alex,
dejagnu should not report that sqrt_insn is available on PowerPC in
confirmations when it is not. The correct fix and the one suggested
by Richard and Segher is to test for the availability of sqrt, not to
assume that it exists in PowerPC.
The test should not explicitly add
On Feb 26, 2021, Segher Boessenkool wrote:
> On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote:
>> On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote:
>> >
>> > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
>> > tests. Tested on x86_64-linux-gnu, and on
On Mon, Mar 01, 2021 at 09:46:29AM +0100, Richard Biener wrote:
> On Sat, Feb 27, 2021 at 2:43 AM Segher Boessenkool
> wrote:
> >
> > On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote:
> > > On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva
> > > wrote:
> > > >
> > > > This patch
On Sat, Feb 27, 2021 at 2:43 AM Segher Boessenkool
wrote:
>
> On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote:
> > On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote:
> > >
> > > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
> > > tests. Tested on
On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote:
> On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote:
> >
> > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
> > tests. Tested on x86_64-linux-gnu, and on the affected platform. Ok to
> > install?
>
> I'm
On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote:
>
> This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
> tests. Tested on x86_64-linux-gnu, and on the affected platform. Ok to
> install?
I'm sort of surprised that sqrt instruction would be available for the
target but
This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
tests. Tested on x86_64-linux-gnu, and on the affected platform. Ok to
install?
From: Eric Botcazou
for gcc/testsuite/ChangeLog
* lib/target-supports.exp (add_options_for_sqrt_insn): For
PowerPC targets, add
17 matches
Mail list logo
