Re: [PATCH] Fix up get_reload_reg (PR rtl-optimization/56195)

2013-02-08 Thread Jakub Jelinek
On Thu, Feb 07, 2013 at 09:01:15PM -0500, David Miller wrote: From: Jakub Jelinek ja...@redhat.com Date: Fri, 8 Feb 2013 01:27:02 +0100 +void +fn (void) +{ + if (b) +{ + int *p, *q; + char g; + + if (f++) + for (;; e++); +lbl: + for (b =

Re: [Patch] Ad PR 56064: Extend fixed_from_double_int input

2013-02-08 Thread Richard Biener
On Thu, Feb 7, 2013 at 5:07 PM, Georg-Johann Lay a...@gjlay.de wrote: This patch solves a problem with VIEW_CONVERT_EXPR folding for fixed_cst and that use fixed-value.c:fixed_from_double_int. The patch sign/zero extends the double_int input according to the requested fixed-point mode. The

Re: [PATCH] Check headers in verify_loop_structure

2013-02-08 Thread Richard Biener
On Thu, 7 Feb 2013, Marek Polacek wrote: On Thu, Feb 07, 2013 at 02:56:48PM +0100, Richard Biener wrote: + /* Check the headers. */ + FOR_EACH_BB (bb) +{ + /* Skip BBs in the root tree. */ + if (bb-loop_father == current_loops-tree_root) + continue; You

Re: [PATCH][RFC] Fix PR56113 more

2013-02-08 Thread Richard Biener
On Fri, 1 Feb 2013, Richard Biener wrote: On Fri, 1 Feb 2013, Jakub Jelinek wrote: On Fri, Feb 01, 2013 at 10:00:00AM +0100, Richard Biener wrote: This reduces compile-time of the testcase in PR56113 (with n = 4) from 575s to 353s. It does so by reducing the quadratic

Re: [PATCH] Check headers in verify_loop_structure

2013-02-08 Thread Toon Moene
On 02/08/2013 12:20 PM, Richard Biener wrote: On Thu, 7 Feb 2013, Marek Polacek wrote: On Thu, Feb 07, 2013 at 02:56:48PM +0100, Richard Biener wrote: + /* Check the headers. */ + FOR_EACH_BB (bb) +{ + /* Skip BBs in the root tree. */ + if (bb-loop_father ==

Re: [PATCH] Check headers in verify_loop_structure

2013-02-08 Thread Marek Polacek
On Fri, Feb 08, 2013 at 12:38:48PM +0100, Toon Moene wrote: Maybe here: http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg00835.html Well this one is definitely not caused by the new verifier bits above. Marek

Re: [PATCH] Check headers in verify_loop_structure

2013-02-08 Thread Richard Biener
On Fri, 8 Feb 2013, Marek Polacek wrote: On Fri, Feb 08, 2013 at 12:38:48PM +0100, Toon Moene wrote: Maybe here: http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg00835.html Well this one is definitely not caused by the new verifier bits above. I've seen this locally when testing a LTO

[PATCH] Fix LTO bootstrap

2013-02-08 Thread Richard Biener
This fixes LTO bootstrap which, after the IRA changes to properly use loop_optimizer_init () and friends, now detects that we may in fact have invalidated dominator information (and formerly used this invalid dominator information to build up loops via flow_loops_find - oops). LTO bootstrap in

[PATCH, i386]: Use INTEGER_CLASS_P macro in ix86_spill_class

2013-02-08 Thread Uros Bizjak
Hello! The patch replaces open-coded INTEGER_CLASS_P macro with its definition from i386.h 2013-02-08 Uros Bizjak ubiz...@gmail.com * config/i386/i386.c (ix86_spill_class): Use INTEGER_CLASS_P macro. Bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32}, with additional

Re: [PATCH] Check headers in verify_loop_structure

2013-02-08 Thread Marek Polacek
On Fri, Feb 08, 2013 at 12:20:18PM +0100, Richard Biener wrote: Ok. Let's watch for fallout... Yeah, we'll see. Commited. Marek

[PATCH] Fix PR56231

2013-02-08 Thread Richard Biener
This fixes broken include information printed on diagnostics from the LTO frontend. We fail to properly leave the file we're still in after processing one data_in. Instead of figuring out where exactly we miss a clear_line_info call the following simply caches the current file/line/column at

[Patch,avr] Implement PR56254

2013-02-08 Thread Georg-Johann Lay
This adds variable delays to __builtin_avr_delay_cycles. Is this okay? Johann gcc/ PR target/56254 * config/avr/avr.c (avr_expand_builtin) AVR_BUILTIN_DELAY_CYCLES: Expand to delay_cycles for non-const delays. * config/avr/avr.md (delay_cycles): New expander.

Re: [Patch, fortran] PR54107 ICE on recursive interface

2013-02-08 Thread Paul Richard Thomas
Mikael, The patch itself is good for trunk - it's rather clever, in fact :-) What's happened to the testcase? There are still lots of commented out lines that I presume are fixed. Cheers Paul On 7 February 2013 23:28, Mikael Morin mikael.mo...@sfr.fr wrote: Hello, this is the last

RE: [Patch,avr] Implement PR56254

2013-02-08 Thread Weddington, Eric
-Original Message- From: Georg-Johann Lay Sent: Friday, February 08, 2013 5:53 AM To: gcc-patches@gcc.gnu.org Cc: Denis Chertykov; Weddington, Eric Subject: [Patch,avr] Implement PR56254 This adds variable delays to __builtin_avr_delay_cycles. Is this okay? What does this

Re: [PATCH, PR] Crash of Bessel functions at x==0!

2013-02-08 Thread Ed Smith-Rowland
On 02/08/2013 08:18 AM, Paolo Carlini wrote: On 02/08/2013 05:09 AM, Ed Smith-Rowland wrote: Here is a reworked patch... The asyptotic stuff is removed for now. Builds and tests cleanon x86_64-unknown-linux. Please add a: bool test __attribute__((unused)) = true; at the beginning of

[PATCH] Fix up extract_muldiv for NEGATE_EXPR (PR tree-optimization/56250)

2013-02-08 Thread Jakub Jelinek
Hi! As the testcase shows, treating (-something_unsigned) / c as -(something_unsigned / c) is wrong for unsigned types, seems to be fine for signed types even for -fwrapv and for multiplication instead of / or % looks fine to me too. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for

[PATCH, i386]: Define TARGET_CAN_SPLIT_STACK only when HAVE_GAS_CFI_PERSONALITY_DIRECTIVE is set

2013-02-08 Thread Uros Bizjak
Hello! Attached patch fixes several go testcase failures on CentOS 5.9 with ancient (GNU ld version 2.17.50.0.6-20.el5_8.3 20061020) binutils. These do not have CFI personality directive, so -fsplit-stack should not be used there. The compiler detects this situation through

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Uros Bizjak
On Fri, Feb 8, 2013 at 3:07 AM, Ian Lance Taylor i...@google.com wrote: On Thu, Feb 7, 2013 at 2:43 PM, Uros Bizjak ubiz...@gmail.com wrote: I did hit one new error that seems related: --- FAIL: TestChtimes (0.00 seconds) os_test.go:681: AccessTime didn't go backwards;

Re: [PATCH] Fix up extract_muldiv for NEGATE_EXPR (PR tree-optimization/56250)

2013-02-08 Thread Richard Biener
On Fri, 8 Feb 2013, Jakub Jelinek wrote: Hi! As the testcase shows, treating (-something_unsigned) / c as -(something_unsigned / c) is wrong for unsigned types, seems to be fine for signed types even for -fwrapv and for multiplication instead of / or % looks fine to me too.

[4.7 PATCH, committed] Clear MASK_ALTIVEC if no OS support

2013-02-08 Thread David Edelsohn
The -mcpu=XXX options enable processor features, including Altivec and VSX. Some OS releases do not have support for that feature. GCC included code to clear those features for Altivec, but it had not been updated when VSX was added. This was fixed on mainline as part of the general masks

Re: [PATCH, i386]: Define TARGET_CAN_SPLIT_STACK only when HAVE_GAS_CFI_PERSONALITY_DIRECTIVE is set

2013-02-08 Thread Ian Lance Taylor
On Fri, Feb 8, 2013 at 6:28 AM, Uros Bizjak ubiz...@gmail.com wrote: Attached patch fixes several go testcase failures on CentOS 5.9 with ancient (GNU ld version 2.17.50.0.6-20.el5_8.3 20061020) binutils. These do not have CFI personality directive, so -fsplit-stack should not be used there.

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Ian Lance Taylor
On Fri, Feb 8, 2013 at 6:42 AM, Uros Bizjak ubiz...@gmail.com wrote: On Fri, Feb 8, 2013 at 3:07 AM, Ian Lance Taylor i...@google.com wrote: On Thu, Feb 7, 2013 at 2:43 PM, Uros Bizjak ubiz...@gmail.com wrote: I did hit one new error that seems related: --- FAIL: TestChtimes (0.00 seconds)

Re: [PATCH] Fix up get_reload_reg (PR rtl-optimization/56195)

2013-02-08 Thread Vladimir Makarov
On 13-02-07 7:27 PM, Jakub Jelinek wrote: Hi! As the following testcase shows, get_reload_reg could sometimes return a reused reg in a wrong mode. If curr_insn_input_reloads[i].input and original have VOIDmode, they could compare equal (same integer constant), yet mode might be different from

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Uros Bizjak
On Fri, Feb 8, 2013 at 4:02 PM, Ian Lance Taylor i...@google.com wrote: I did hit one new error that seems related: --- FAIL: TestChtimes (0.00 seconds) os_test.go:681: AccessTime didn't go backwards; was={63495872497 0 47130825733376}, after={63495872497 0 47130825733376}

Re: [Patch, fortran] PR54107 ICE on recursive interface

2013-02-08 Thread Mikael Morin
Le 08/02/2013 14:06, Paul Richard Thomas a écrit : What's happened to the testcase? There are still lots of commented out lines that I presume are fixed. Well, I was playing with the testcase just before I sent the patch for review . Attached is what I have committed - testcase fixed, as

Re: [Patch,avr] Implement PR56254

2013-02-08 Thread Georg-Johann Lay
Weddington, Eric wrote: From: Georg-Johann Lay This adds variable delays to __builtin_avr_delay_cycles. Is this okay? What does this do? How does it work? Could you explain the statement in the documentation if ticks is not a compile-time constant, the delay might be overestimated by

Re: [Patch, microblaze]: Add MicroBlaze Little Endian Support

2013-02-08 Thread Michael Eager
On 01/24/2013 04:39 PM, David Holsgrove wrote: Hi Michael, Please find attached updated patch for MicroBlaze Little Endian support to reflect removal of microblaze*-*-* target. Changelog updated as follows. thanks, David gcc/Changelog 2013-01-25 Edgar E. Iglesias edgar.igles...@gmail.com

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Ian Lance Taylor
On Fri, Feb 8, 2013 at 7:23 AM, Uros Bizjak ubiz...@gmail.com wrote: On Fri, Feb 8, 2013 at 4:02 PM, Ian Lance Taylor i...@google.com wrote: I did hit one new error that seems related: --- FAIL: TestChtimes (0.00 seconds) os_test.go:681: AccessTime didn't go backwards;

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Uros Bizjak
On Fri, Feb 8, 2013 at 5:21 PM, Ian Lance Taylor i...@google.com wrote: On Fri, Feb 8, 2013 at 7:23 AM, Uros Bizjak ubiz...@gmail.com wrote: On Fri, Feb 8, 2013 at 4:02 PM, Ian Lance Taylor i...@google.com wrote: I did hit one new error that seems related: --- FAIL: TestChtimes (0.00

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Ian Lance Taylor
On Fri, Feb 8, 2013 at 8:48 AM, Uros Bizjak ubiz...@gmail.com wrote: utimensat returns zero on CentOS. Following is gdb session: Thanks--can you do the same session but with step instead of next? Ian

[PATCH] Improve debugging info (PR debug/53948 P1 regression)

2013-02-08 Thread Jeff Law
The basic problem here is parameters are marked with REG_USERVAR_P and IRA creates conflicts for the parameters with the callee clobbered registers. This results in the copy from the parameter registers into callee clobbered registers being removed. The move instructions happen to be

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Uros Bizjak
On Fri, Feb 8, 2013 at 5:53 PM, Ian Lance Taylor i...@google.com wrote: On Fri, Feb 8, 2013 at 8:48 AM, Uros Bizjak ubiz...@gmail.com wrote: utimensat returns zero on CentOS. Following is gdb session: Thanks--can you do the same session but with step instead of next? I think I got the

RE: [Patch,avr] Implement PR56254

2013-02-08 Thread Weddington, Eric
-Original Message- From: Georg-Johann Lay Sent: Friday, February 08, 2013 9:00 AM To: Weddington, Eric Cc: gcc-patches@gcc.gnu.org; Denis Chertykov; Joerg Wunsch Subject: Re: [Patch,avr] Implement PR56254 Weddington, Eric wrote: What does this do? How does it work?

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Uros Bizjak
On Fri, Feb 8, 2013 at 6:10 PM, Uros Bizjak ubiz...@gmail.com wrote: On Fri, Feb 8, 2013 at 5:53 PM, Ian Lance Taylor i...@google.com wrote: On Fri, Feb 8, 2013 at 8:48 AM, Uros Bizjak ubiz...@gmail.com wrote: utimensat returns zero on CentOS. Following is gdb session: Thanks--can you do the

Re: [Patch,avr] Implement PR56254

2013-02-08 Thread Georg-Johann Lay
Weddington, Eric wrote: -Original Message- From: Georg-Johann Lay Sent: Friday, February 08, 2013 9:00 AM To: Weddington, Eric Cc: gcc-patches@gcc.gnu.org; Denis Chertykov; Joerg Wunsch Subject: Re: [Patch,avr] Implement PR56254 Weddington, Eric wrote: What does this do? How does

Re: [PATCH] Improve debugging info (PR debug/53948 P1 regression)

2013-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2013 at 09:54:19AM -0700, Jeff Law wrote: PR debug/53948 * emit-rtl.c (reg_is_parm_p): New function. * regs.h (reg_is_parm_p): New prototype. * ira-conflicts.c (ira_build_conflicts): Allow parameters in callee-clobbered registers. This looks good

Re: [PATCH] Improve debugging info (PR debug/53948 P1 regression)

2013-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2013 at 06:55:08PM +0100, Jakub Jelinek wrote: But the testcase is problematic. --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/pr53948.c @@ -0,0 +1,10 @@ +/* Test that we emit a .line directive for the line + with local variable initializations. */ +/* {

Re: [PATCH] Improve debugging info (PR debug/53948 P1 regression)

2013-02-08 Thread Jeff Law
On 02/08/2013 10:55 AM, Jakub Jelinek wrote: On Fri, Feb 08, 2013 at 09:54:19AM -0700, Jeff Law wrote: PR debug/53948 * emit-rtl.c (reg_is_parm_p): New function. * regs.h (reg_is_parm_p): New prototype. * ira-conflicts.c (ira_build_conflicts): Allow parameters in

[PATCH, i386]: Enable standard vector-mode FMA patterns also for !TARGET_SSE_MATH

2013-02-08 Thread Uros Bizjak
Hello! As pointed out by Richi in PR56253 [1], we should enable standard vector-mode FMA patterns also for !TARGET_SSE_MATH, otherwise various transformations (convert_mult_to_fma) can't convert to a vectorized FMA. 2013-02-08 Uros Bizjak ubiz...@gmail.com * config/i386/sse.md

Re: [PATCH] Improve debugging info (PR debug/53948 P1 regression)

2013-02-08 Thread Jeff Law
On 02/08/2013 10:55 AM, Jakub Jelinek wrote: On Fri, Feb 08, 2013 at 09:54:19AM -0700, Jeff Law wrote: PR debug/53948 * emit-rtl.c (reg_is_parm_p): New function. * regs.h (reg_is_parm_p): New prototype. * ira-conflicts.c (ira_build_conflicts): Allow parameters in

[PATCH][Revisedx2] Fix PR libitm/55693

2013-02-08 Thread Jack Howarth
The attached patch eliminates, PR55693, the failure of the libitm.c++/eh-1.C execution test on darwin10 and later. With the introduction of c++ weak-symbol coalescing in Mac OS X 10.6, dyld no longer looks up weak symbols that reside in object files rather than shared libraries. This

Re: libgo patch committed: Update to current version of Go library

2013-02-08 Thread Ian Lance Taylor
On Fri, Feb 8, 2013 at 9:42 AM, Uros Bizjak ubiz...@gmail.com wrote: Please note, that looking at generated libcalls.go, there are many other possible signed/unsigned issues of the same type. Since this all happens on x86_64 (where go int is apparently 64bit), it looks that it is very

Re: [PATCH][RFC] Fix PR56113 more

2013-02-08 Thread Steven Bosscher
On Fri, Feb 8, 2013 at 12:25 PM, Richard Biener rguent...@suse.de wrote: Steven - can you reproduce your failures (and on which target?) Ping. I had ASAN failures on ppc64 but I cannot reproduce them anymore. Ciao! Steven

Re: [PATCH][RFC] Fix PR56113 more

2013-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2013 at 08:56:42PM +0100, Steven Bosscher wrote: On Fri, Feb 8, 2013 at 12:25 PM, Richard Biener rguent...@suse.de wrote: Steven - can you reproduce your failures (and on which target?) Ping. I had ASAN failures on ppc64 but I cannot reproduce them anymore. ASAN on ppc64

[PATCH] Improve debugging info (PR debug/53948 P1 regression)

2013-02-08 Thread Jeff Law
Based on feedback from Jakub, I updated the testcase for this PR. Updated patch attached. Installed onto the trunk. Jeff commit 48b3095f4ef7da1a06ad2fa96db3967762ce4f0b Author: Jeff Law l...@redhat.com Date: Fri Feb 8 09:57:43 2013 -0700 PR debug/53948 * emit-rtl.c

[patch, Fortran] Fix PR 56224

2013-02-08 Thread Thomas Koenig
Hello world, the attached patch fixes the PR by (re-)adding a search path for the path used by intrinsic modules. Regression-tested. OK for trunk? Thomas 2013-02-08 Thomas Koenig tkoe...@gcc.gnu.org PR fortran/56224 * options.c (gfc_handle_option): Also call

patch to fix PR56246

2013-02-08 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56246 LRA was not able to find enough regs for insn reloads. One reason of that was it did not try to reuse the same reload reg for the same value. Another reason was it tried to assign hard reg to a pseudo in any case, as

Re: [PATCH 1/2] PowerPC testsuite clean up

2013-02-08 Thread Peter Bergner
On Wed, 2013-02-06 at 17:19 -0500, David Edelsohn wrote: Because Peter Bergner most recently worked on embedded PPC targets, I had asked him to double-check the patch before approving it. Hopefully he will give me some feedback soon. I've had a look at the patch and it looks good to me. I also

Re: [PATCH 1/2] PowerPC testsuite clean up

2013-02-08 Thread David Edelsohn
On Fri, Feb 8, 2013 at 5:05 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Wed, 2013-02-06 at 17:19 -0500, David Edelsohn wrote: Because Peter Bergner most recently worked on embedded PPC targets, I had asked him to double-check the patch before approving it. Hopefully he will give me some

Go testsuite patch committed: Load timeout.exp

2013-02-08 Thread Ian Lance Taylor
Since testsuite/lib/go.exp now uses [timeout_value], it needs to load timeout.exp. This shows up when testing libgo using DejaGNU. Bootstrapped and ran Go tests on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2013-02-08 Ian Lance Taylor i...@google.com * lib/go.exp: Load

[google] Port revisions for -mpatch-functions-for-instrumentation option back to google-main. (issue7301068)

2013-02-08 Thread Harshit Chopra
2013-02-08 Harshit Chopra hars...@google.com Porting revisions r183548, r183888, r186118, r192231, r193381. diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index ab416ff..04b973f 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -396,6 +396,13 @@

Re: [google] Port revisions for -mpatch-functions-for-instrumentation option back to google-main. (issue7301068)

2013-02-08 Thread Xinliang David Li
ok. thanks, David On Fri, Feb 8, 2013 at 6:57 PM, Harshit Chopra hars...@google.com wrote: 2013-02-08 Harshit Chopra hars...@google.com Porting revisions r183548, r183888, r186118, r192231, r193381. diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index