Re: [Fortran-caf, patch, committed] Fix array support for CAF send, handle rank 1 arrays

2014-04-07 Thread Tobias Burnus
Tobias Burnus wrote: Testing showed that the test case doesn't work with num_images() 1. Fixed by the commit Rev. 209170. I forgot two functions - now it looks as if it really works with multiple images :-) Tobias Index: gcc/testsuite/ChangeLog.fortran-caf

Re: [BUILD] PING for Jakub's --with-build-config=bootstrap-asan / bootstrap-ubsan patches

2014-04-07 Thread Tobias Burnus
* PING * Tobias Burnus wrote: I would like to ping the following two patches of Jakub. As he wrote in PR60667: The http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01370.html fix is still waiting for review, you need that for both --with-build-config=bootstrap-ubsan and

RE: Skip gcc.dg/tree-ssa/isolate-*.c for AVR Target

2014-04-07 Thread K_s, Vishnu
Added comment to avr.c on why disabling -fdelete-null-pointer-checks. Patch Attached in the mail. Previously approved patch can be found here - http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01697.html. I don't have commit access to the source, please commit both the patches If they are OK.

[ping] [ARM] Fix PR target/60504

2014-04-07 Thread Eric Botcazou
This fixes the broken EH tables generated for the ARM: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01333.html Thanks in advance. -- Eric Botcazou

Re: [C++] Weffc++/Wnon-virtual-dtor confusion

2014-04-07 Thread Nathan Sidwell
On 04/06/14 10:50, Markus Trippelsdorf wrote: On 2014.04.06 at 09:13 +0100, Nathan Sidwell wrote: On 04/04/14 18:33, Nathan Sidwell wrote: I'm testing a patch that makes the test in the loop: if (TREE_PUBLIC (base_binfo) Hm, binfo's aren't noted that way, it's encoded in

Re: [PATCH] Fix PR59626, _FORTIFY_SOURCE wrappers and LTO

2014-04-07 Thread Richard Biener
On Fri, 4 Apr 2014, Jan Hubicka wrote: On Fri, 4 Apr 2014, Jan Hubicka wrote: Hi, here is an updated version of my earlier ipa.c change. It turns out that the problem was that I did not drop always_inline. In this version I just drop always_inline attribute on all functions

Re: [PATCH] Fix my name in contrib.texi

2014-04-07 Thread Richard Biener
On Mon, 7 Apr 2014, Gerald Pfeifer wrote: On Tue, 18 Mar 2014, Richard Biener wrote: Committed as obvious. htdocs/svn.html has four occurrences, and a few other pages also have some. Though I don't think it's appropriate to adjust the like of news.html, should I update svn.html? Sure,

Re: [C++] Weffc++/Wnon-virtual-dtor confusion

2014-04-07 Thread Markus Trippelsdorf
On 2014.04.07 at 08:39 +0100, Nathan Sidwell wrote: On 04/06/14 10:50, Markus Trippelsdorf wrote: On 2014.04.06 at 09:13 +0100, Nathan Sidwell wrote: On 04/04/14 18:33, Nathan Sidwell wrote: I'm testing a patch that makes the test in the loop: if (TREE_PUBLIC (base_binfo)

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Richard Biener
On Sat, Apr 5, 2014 at 3:52 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, we have front-end warnings about returning the address of a local variable. However, quite often in C++, people don't directly return the address of a temporary, it goes through a few functions which hide that

Re: RFA: Testsuite PATCH to add support for dlopen tests

2014-04-07 Thread Richard Biener
On Sun, Apr 6, 2014 at 6:21 PM, Mike Stump mikest...@comcast.net wrote: On Apr 4, 2014, at 9:53 AM, Jason Merrill ja...@redhat.com wrote: richi asked for a testcase for 60731, and since we didn't already have support for tests using dlopen, I had to add it. Does this approach make sense?

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Marc Glisse
On Mon, 7 Apr 2014, Richard Biener wrote: One hard part is avoiding duplicate warnings. Replacing the address with 0 is a convenient way to do that, so I did it both for my new warning and for the existing C/C++ ones. The patch breaks gfortran.dg/warn_target_lifetime_2.f90 because it ends up

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Eric Botcazou
One hard part is avoiding duplicate warnings. Replacing the address with 0 is a convenient way to do that, so I did it both for my new warning and for the existing C/C++ ones. The patch breaks gfortran.dg/warn_target_lifetime_2.f90 because it ends up warning twice. I didn't touch that

[libitm] Check if GCC uses assembler cfi support

2014-04-07 Thread Rainer Orth
The Solaris 11.2 x86 assembler is going to gain support for the cfi directives. To do things right this time, it will create read-only .eh_frame sections, unlike what gas and gcc currently do. The goal is to let /bin/ld handle the required merging of read-only and read-write .eh_frame sections,

Re: conditional notes after 'pedwarn'

2014-04-07 Thread Jason Merrill
OK. Jason

[PATCH][committed] Fix couple of typos and outdated function reference in comment

2014-04-07 Thread Kyrill Tkachov
Hi all, I've committed the attached patch to the introductory comment in haifa-sched.c as obvious with r209184. The function compute_block_backward_dependences was renamed to compute_block_dependences in 2007but the comment was not updated. Kyrill 2014-04-07 Kyrylo Tkachov

Re: [C++] Weffc++/Wnon-virtual-dtor confusion

2014-04-07 Thread Jason Merrill
On 04/07/2014 03:39 AM, Nathan Sidwell wrote: Jason, I shall leave it to your discretion as to whether we should continue with this patch, or revert the original one (for 4.9). This is OK. Post 4.9 we might try removing the warn_ecpp check and see how that is received. Jason

[Patch testsuite] Fix missing curly brace in gcc.target/arm/pr60657.c

2014-04-07 Thread Ramana Radhakrishnan
As subject says. Applied as obvious. Ramana 2014-04-07 Ramana Radhakrishnan ramana.radhakrish...@arm.com * gcc.target/arm/pr60657.c: Fix missing curly brace. -- Ramana Radhakrishnan Principal Engineer ARM Ltd.Index: gcc/testsuite/ChangeLog

[PATCH][AArch64] Wire up TARGET_SIMD and TARGET_FLOAT properly

2014-04-07 Thread Kyrill Tkachov
Hi all, Currently if we specify something like -march=armv8-a+nosimd or -mcpu=cpu-name+nosimd the backend will not use it properly to setup the TARGET_SIMD internal boolean that the backend checks for SIMD availability. In the end, the only effective way of disabling SIMD instructions was to

[PATCH] Fix PR60766

2014-04-07 Thread Richard Biener
This fixes PR60766, a case where IVOPTs generating signed expressions from originally unsigned ones breaks because that introduces undefined overflow and VRP manages to exploit that fact. The solution is to use unsigned arithmetic when doing simplification using tree-affine. In general that's

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-07 Thread Richard Biener
On Fri, Apr 4, 2014 at 7:51 PM, Jeff Law l...@redhat.com wrote: On 04/04/14 10:18, Andreas Krebbel wrote: Hi, the attached patch modifies the builtin-bswap-6/7 testcases in order to prevent GCC from using math instead of a compare. Only with a compare the folding in combine actually takes

Re: [ARM] Fix PR target/60504

2014-04-07 Thread Ramana Radhakrishnan
Sorry about the delayed review. I seem to have missed this earlier. On Tue, Mar 25, 2014 at 12:21 PM, Eric Botcazou ebotca...@adacore.com wrote: Hi, because of popular demand we switched the Ada compiler to ZCX, i.e. table- driven EH scheme, on ARM/Linux, only to discover that GCC doesn't

Re: [libitm] Check if GCC uses assembler cfi support

2014-04-07 Thread Richard Henderson
On 04/07/2014 04:33 AM, Rainer Orth wrote: The patch allowed i386-pc-solaris2.11 bootstraps to finish without regressions on trunk and 4.8 branch, still need to test 4.7 branch. Ok for trunk, 4.8 and 4.7 branches once testing completes? Rainer 2014-04-07 Rainer Orth

Re: [PATCH, ARM] Fix PR60609 (Error: value of 256 too large for field of 1 bytes)

2014-04-07 Thread Charles Baylis
On 4 April 2014 15:50, Ramana Radhakrishnan ramana@googlemail.com wrote: Additionally the testing has only considered Thumb2 - since we also do jumptable shortening for Thumb1 and given this late change it's worth also testing this on Thumb1 and making sure there are no regressions. Maybe

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-07 Thread Andreas Krebbel
On Mon, Apr 07, 2014 at 04:19:06PM +0200, Richard Biener wrote: The adjusted testcases now fail on x86_64/i?86 at least. See PR60776. They seem to require at least -O2 on x86 with that change. Ok to apply? diff --git a/gcc/testsuite/gcc.dg/builtin-bswap-6.c

[Ping] [Patch C++] RFC Fix PR57958

2014-04-07 Thread Dinar Temirbulatov
Hi, I revised the patch from http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00083.html. This change fixes PR57958 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57958) For this code: auto fn = [] (const FooData x) { return (x); }; { FooData a; fn(a); } Current version of trunk

Re: [PATCH] Initialize sanitizer builtins (PR sanitizer/60745)

2014-04-07 Thread Marek Polacek
On Sun, Apr 06, 2014 at 09:46:12AM -0700, Mike Stump wrote: On Apr 5, 2014, at 10:36 AM, Marek Polacek pola...@redhat.com wrote: I'll wait a day or two for possible comments. So, my only comment would be it would be nice to document the flags that can vary between pch creation and use

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Jeff Law
On 04/05/14 07:52, Marc Glisse wrote: Hello, we have front-end warnings about returning the address of a local variable. However, quite often in C++, people don't directly return the address of a temporary, it goes through a few functions which hide that fact. After some inlining, the fact that

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Marc Glisse
On Mon, 7 Apr 2014, Jeff Law wrote: On 04/05/14 07:52, Marc Glisse wrote: Hello, we have front-end warnings about returning the address of a local variable. However, quite often in C++, people don't directly return the address of a temporary, it goes through a few functions which hide that

Fixing PR60773

2014-04-07 Thread Cong Hou
In the patch of PR60656(http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01668.html), the test case requires GCC to vectorize the widen-mult pattern from si to di types. This may result in test failures on some platforms that don't support this pattern. This patch adds a new target

[patch] fix some libstdc++ testsuite bugs

2014-04-07 Thread Jonathan Wakely
This fixes some errors in the testsuite which aren't caught by G++ (for known reasons). Tested x86_64-linux, committed to trunk. commit 9c8945c0d7adf909f8b46c0331d66a00af4187b9 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Apr 7 18:17:03 2014 +0100 Fix testsuite bugs.

Re: [Ping] [Patch C++] RFC Fix PR57958

2014-04-07 Thread Jason Merrill
On 04/07/2014 12:56 PM, Dinar Temirbulatov wrote: /* We can't initialize a register from a AGGR_INIT_EXPR. */ else if (! cfun-returns_struct TREE_CODE (retval) == TARGET_EXPR TREE_CODE (TREE_OPERAND (retval, 1)) == AGGR_INIT_EXPR) retval =

Re: [Ping] [Patch C++] RFC Fix PR57958

2014-04-07 Thread Jason Merrill
On 04/07/2014 03:46 PM, Jason Merrill wrote: I guess we need to call complete_type before aggregate_value_p. complete_type_or_else, actually. Jason

[GOOGLE] AutoFDO+LIPO should invoke add_fake_edge too

2014-04-07 Thread Dehao Chen
This patch calls add_fake_edge for the AutoFDO+LIPO path. Bootstrapped and passed regression test and performance test. OK for google-4_8? Thanks, Dehao Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 209123) +++

Re: [GOOGLE] AutoFDO+LIPO should invoke add_fake_edge too

2014-04-07 Thread Xinliang David Li
ok (after fixing the format -- a function name starts a new line in function def). David On Mon, Apr 7, 2014 at 12:49 PM, Dehao Chen de...@google.com wrote: This patch calls add_fake_edge for the AutoFDO+LIPO path. Bootstrapped and passed regression test and performance test. OK for

Test failure: gcc.dg/tree-ssa/ssa-ifcombine-13.c

2014-04-07 Thread Steve Ellcey
Jakub, This test that you added on March 12th has always been failing for me on MIPS. It looks like you expect MIPS to optimize the if statement but mips.h has: #define LOGICAL_OP_NON_SHORT_CIRCUIT 0 So the if always shows up in ssa-ifcombine-13.c.169t.optimized. Should MIPS be removed from

[PATCH] Fix PR c++/60764

2014-04-07 Thread Patrick Palka
Hello, This patch fixes fixes an erroneous -Wnonnull warning when calling a constructor declared with __attribute__ ((nonnull (1))). The issue is that a NULL pointer is used as the placeholder object for the this parameter of the constructor method call until a target object is determined and

[PATCH] Fix PR c++/60765

2014-04-07 Thread Patrick Palka
Hi, This patch teaches the C++ frontend how to handle function attributes attached to pointer-to-member-function declarations. I bootstrapped and regtested this patch on x86_64-unknown-linux-gnu. 2014-04-05 Patrick Palka patr...@parcs.ath.cx PR c++/60765 * decl2.c

Re: [PATCH] Initialize sanitizer builtins (PR sanitizer/60745)

2014-04-07 Thread Mike Stump
On Apr 7, 2014, at 10:57 AM, Marek Polacek pola...@redhat.com wrote: On Sun, Apr 06, 2014 at 09:46:12AM -0700, Mike Stump wrote: On Apr 5, 2014, at 10:36 AM, Marek Polacek pola...@redhat.com wrote: I'll wait a day or two for possible comments. So, my only comment would be it would be nice

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Jeff Law
On 04/07/14 12:51, Marc Glisse wrote: I would tend to start from the return statements (assuming the return type is a pointer), look at the defining statement, do things if it is an assignment of an addr_expr, and recurse if it is a PHI. But maybe my brain is cabled backwards ;-) It works

Re: [4.8, PATCH, rs6000] (Re: [PATCH, rs6000] More efficient vector permute for little endian)

2014-04-07 Thread Bill Schmidt
Hi, I'm withdrawing this request as I just discovered it will sometimes be advantageous to use vnand rather than vnor; will rework this and get back to you. Thanks, Bill On Fri, 2014-04-04 at 15:45 -0500, Bill Schmidt wrote: On Thu, 2014-03-20 at 20:38 -0500, Bill Schmidt wrote: The original

Fix wrong code issue in ipa-devirt

2014-04-07 Thread Jan Hubicka
Hi, while looking into devirtualization dumps, I noticed that I got one false typed out as true. Not sure what I was thinking of. Martin, this may fix the wrong code issue you see in Firefox, hopefully. Will commit it after x86_64-linux testing finishes tomorrow. Honza * ipa-devirt.c

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Marc Glisse
On Mon, 7 Apr 2014, Jeff Law wrote: I am also afraid we may get more false positives, but maybe not. The only false positives should come from paths which are unexecutable. One could argue that if we find any that we should warn, then isolate the path so that we get an immediate runtime trap