Re: Backports to 9.3

2020-02-14 Thread H.J. Lu
On Thu, Feb 13, 2020 at 2:46 PM Jakub Jelinek wrote: > > Hi! > > I've backported following 15 commits from trunk to 9.3 branch, > bootstrapped/regtested on x86_64-linux and i686-linux, committed. > Hi Jakub, Are you preparing for GCC 9.3? I'd like to include this in GCC 9.3:

Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]

2020-02-14 Thread Hongtao Liu
Done. On Fri, Feb 14, 2020 at 7:16 PM Uros Bizjak wrote: > > On Fri, Feb 14, 2020 at 8:06 AM Uros Bizjak wrote: > > > > On Fri, Feb 14, 2020 at 7:03 AM Hongtao Liu wrote: > > > > > > On Thu, Feb 13, 2020 at 5:31 PM Hongtao Liu wrote: > > > > > > > > On Thu, Feb 13, 2020 at 5:12 PM Uros Bizjak

[PATCH] c/86134 avoid errors for unrecognized -Wno- options

2020-02-14 Thread Richard Biener
This makes sure to not promote diagnostics about unrecognized -Wno- options to errors and make the intent of the diagnostic clearer. Bootstrapped and tested on x86_64-unknown-linux-gnu, OK for trunk? Thanks, Richard. 2020-02-14 Richard Biener PR c/86134 * opts-global.c

Re: Backports to 9.3

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 07:45:43AM -0800, H.J. Lu wrote: > Are you preparing for GCC 9.3? I'd like to include this in GCC 9.3: > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1d69147af203d4dcd2270429f90c93f1a37ddfff > > It is very safe. Uros asked me to wait for a week before backporting to >

Re: [PATCH] aarch64: Allow -mcpu=generic -march=armv8.5-a

2020-02-14 Thread Richard Earnshaw (lists)
On 14/02/2020 10:41, Andrew Pinski wrote: On Fri, Feb 14, 2020 at 2:12 AM Richard Earnshaw (lists) wrote: On 14/02/2020 03:18, apin...@marvell.com wrote: From: Andrew Pinski Right if someone supplies a -mcpu= option and then overrides that option with -march=*, we get a warning when they

[8/9/10 Regression, patch][PR93714] ICE in gfc_check_same_strlen, at fortran/check.c:1253

2020-02-14 Thread Mark Eggleston
Please find attached a patch fixing the ICE in PR93714. Tested on: master at https://gcc.gnu.org/g:e235031d490e8ed2aa0bc229694975493fd58977 gcc 9 branch at https://gcc.gnu.org/g:d7ab361df604fb66e1ba1e3fb45b4453cba803c4 gcc 8 branch at

[PATCH 2/3] libstdc++: Convert the ranges algorithm entities into function objects

2020-02-14 Thread Patrick Palka
This is the standard way to inhibit ADL for these entities, which is required as per [algorithms.requirements] p2 and [specialized.algorithms] p4. The conversion was done mostly mechanically with a custom Vim macro. [ To make it easier to review, the diffstat below was generated with the -w

[PATCH 1/3] libstdc++: Fold some ranges algo subroutines into their only caller

2020-02-14 Thread Patrick Palka
These subroutines have only a single call site, so it might be best and simplest to eliminate them before we convert the algos into function objects. libstdc++-v3/ChangeLog: * include/bits/ranges_algo.h (ranges::__find_end): Fold into ... (ranges::find_end): ... here.

[PATCH 3/3] libstdc++: Post-conversion whitespace and formatting adjustments

2020-02-14 Thread Patrick Palka
libstdc++-v3/ChangeLog: * include/bits/ranges_algo.h: Adjust whitespace and formatting. * include/bits/ranges_algobase.h: Likewise. * include/bits/ranges_uninitialized.h: Likewise. --- libstdc++-v3/include/bits/ranges_algo.h | 631 ++

[SPARC] Fix PR target/93704

2020-02-14 Thread Eric Botcazou
This is an old thinko pertaining to the interaction between TLS sequences and delay slot filling: the compiler knows that it cannot put instructions with TLS relocations into delay slots with the original Sun TLS model, but it tests TARGET_SUN_TLS in this context, which depends only on the

Re: Backports to 9.3

2020-02-14 Thread H.J. Lu
On Fri, Feb 14, 2020 at 7:51 AM Jakub Jelinek wrote: > > On Fri, Feb 14, 2020 at 07:45:43AM -0800, H.J. Lu wrote: > > Are you preparing for GCC 9.3? I'd like to include this in GCC 9.3: > > > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1d69147af203d4dcd2270429f90c93f1a37ddfff > > > > It is

Re: [PATCH 00/14] rs6000: Begin replacing built-in support

2020-02-14 Thread Mike Stump
On Feb 4, 2020, at 9:40 AM, Segher Boessenkool wrote: >> My intent is to make adding new built-in functions as simple as adding >> a few lines to a couple of files, and automatically generating as much >> of the initialization, overload resolution, and expansion logic as >> possible. This patch

Re: [PATCH] document that alias and target must have the same type

2020-02-14 Thread Martin Sebor
On 2/13/20 3:55 PM, Sandra Loosemore wrote: On 2/5/20 1:13 PM, Martin Sebor wrote: diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index ec99c38a607..3634ce1c423 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -2557,8 +2557,11 @@ __attribute__ ((access (write_only, 1, 2),

Re: [PATCH v2 0/4] Fix library testsuite compilation for build sysroot

2020-02-14 Thread Mike Stump
On Feb 13, 2020, at 3:36 PM, Maciej W. Rozycki wrote: > > This is v2 of patch series, originally posted here: > > > >

[PATCH v2][ARM][GCC][2/x]: MVE ACLE intrinsics framework patch.

2020-02-14 Thread Srinath Parvathaneni
Hello Kyrill, In this patch (v2) all the review comments mentioned in previous patch (v1) are addressed. (v1) https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01395.html # Hello, This patch is part of MVE ACLE intrinsics framework. This patches add support to update

[PATCH v2][ARM][GCC][3/x]: MVE ACLE intrinsics framework patch.

2020-02-14 Thread Srinath Parvathaneni
Hello Kyrill, In this patch (v2) all the review comments mentioned in previous patch (v1) are addressed. (v1) https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01401.html # Hello, This patch is part of MVE ACLE intrinsics framework. The patch supports the use of emulation for

Re: [PATCH, rs6000]: mark clobber for registers changed by untpyed_call

2020-02-14 Thread Segher Boessenkool
On Fri, Feb 14, 2020 at 02:58:49PM +0800, Jiufu Guo wrote: > Segher Boessenkool writes: > > > On Sat, Feb 08, 2020 at 10:17:42AM -0600, Segher Boessenkool wrote: > >> And we do not know which of the register will be used for the return, in > >> untyped_call (only untyped-return knows). But we

Re: [RFC c-common PATCH] PR c++/40752 - useless -Wconversion with short +=.

2020-02-14 Thread Mike Stump
On Jan 24, 2020, at 9:45 AM, David Edelsohn wrote: > > On Fri, Jan 24, 2020 at 12:00 PM Jason Merrill wrote: >> >> On 1/24/20 8:45 AM, David Edelsohn wrote: >>> There is no ChangeLog entry for the testsuite changes. >> >> I don't believe in ChangeLog entries for testcases, but I'll add one

[committed] c++: Fix thinko in enum_min_precision [PR61414]

2020-02-14 Thread Jakub Jelinek
Hi! When backporting the PR61414 fix to 8.4, I've noticed that the caching of prec is actually broken, as it would fail to actually store the computed precision into the hash_map's value and so next time we'd think the enum needs 0 bits. Fixed thusly, bootstrapped/regtested on x86_64-linux and

Re: [PATCH] testsuite/strlenopt-81.c: Add target limitation.

2020-02-14 Thread Martin Sebor
On 2/13/20 8:34 PM, Kito Cheng wrote: - strlenopt-81.c has same limitation as strlenopt-80.c, this optimization only work when memcpy expand into load/store. Unlike strlenopt-80.c which is a compile-time test that verifies that the optimization successfully folds the strlen expressions,

[PATCH v2][ARM][GCC][1/x]: MVE ACLE intrinsics framework patch.

2020-02-14 Thread Srinath Parvathaneni
Hi Kyrill, > This patch series depends on upstream patches "Armv8.1-M Mainline Security > Extension" [4], > "CLI and multilib support for Armv8.1-M Mainline MVE extensions" [5] and > "support for Armv8.1-M > Mainline scalar shifts" [6]. Patch (version v1) was approved before. The above patches

Re: [PATCH v2 0/4] Fix library testsuite compilation for build sysroot

2020-02-14 Thread Maciej W. Rozycki
Mike, Chung-Lin -- > > In the end I have decided to use the documented `--tool_exec' option to > > `runtest' to contain the change within the testsuite's Makefile and its > > `check' goal, which is inherent to the build tree and as such not supposed > > to be used in standalone testing, like

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-02-14 Thread Martin Sebor
On 2/13/20 3:59 PM, Jason Merrill wrote: On 2/12/20 9:21 PM, Martin Sebor wrote: On 2/11/20 5:28 PM, Jason Merrill wrote: On 2/11/20 9:00 PM, Martin Sebor wrote: r270155, committed in GCC 9, introduced a transformation that strips redundant trailing zero initializers from array initializer

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 10:02:39PM +, GT wrote: > > > Function rs6000_simd_clone_adjust, even though it's body is empty, > > > cannot simply be removed. I tried it. It resulted in ICE. In my > > > view, leaving it empty is preferable to modifying other files > > > unrelated to rs6000.c in

Re: [PATCH v2 0/4] Fix library testsuite compilation for build sysroot

2020-02-14 Thread Mike Stump
On Feb 14, 2020, at 11:57 AM, Maciej W. Rozycki wrote: > > Mike, Chung-Lin -- > >>> In the end I have decided to use the documented `--tool_exec' option to >>> `runtest' to contain the change within the testsuite's Makefile and its >>> `check' goal, which is inherent to the build tree and as

[PATCH] drop weakref attribute on function definitions (PR 92799)

2020-02-14 Thread Martin Sebor
Because attribute weakref introduces a kind of a definition, it can only be applied to declarations of symbols that are not defined. GCC normally issues a warning when the attribute is applied to a defined symbol, but PR 92799 shows that it misses some cases on which it then leads to an ICE.

[RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread GT
Function rs6000_simd_clone_adjust, even though it's body is empty, cannot simply be removed. I tried it. It resulted in ICE. In my view, leaving it empty is preferable to modifying other files unrelated to rs6000.c in order to avoid having a function whose body is empty. Bert.

Re: [PATCH] c/86134 avoid errors for unrecognized -Wno- options

2020-02-14 Thread Joseph Myers
On Fri, 14 Feb 2020, Richard Biener wrote: > diff --git a/gcc/opts-global.c b/gcc/opts-global.c > index d5e308bf800..52ea083a6d5 100644 > --- a/gcc/opts-global.c > +++ b/gcc/opts-global.c > @@ -139,8 +139,10 @@ print_ignored_options (void) >const char *opt; > >opt =

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 08:24:30PM +, GT wrote: > Function rs6000_simd_clone_adjust, even though it's body is empty, > cannot simply be removed. I tried it. It resulted in ICE. In my > view, leaving it empty is preferable to modifying other files > unrelated to rs6000.c in order to avoid

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-14 Thread David Malcolm
On Mon, 2020-02-03 at 22:29 +, Bernd Edlinger wrote: > On 2/3/20 10:05 PM, Segher Boessenkool wrote: > > On Mon, Feb 03, 2020 at 08:16:52PM +, Bernd Edlinger wrote: > > > So gnome terminal is a problem, since it depend heavily on the > > > software > > > version, VTE library, and

Re: [PATCH 00/14] rs6000: Begin replacing built-in support

2020-02-14 Thread Segher Boessenkool
Hi! On Fri, Feb 14, 2020 at 10:34:40AM -0800, Mike Stump wrote: > On Feb 4, 2020, at 9:40 AM, Segher Boessenkool > wrote: > >> My intent is to make adding new built-in functions as simple as adding > >> a few lines to a couple of files, and automatically generating as much > >> of the

[c-family] Fix duplicates for anonymous structures with -fdump-ada-spec

2020-02-14 Thread Eric Botcazou
This fixes a weakness in the way -fdump-ada-spec builds names for anonymous structures in C/C++ code, resulting in duplicate identifiers under specific circumstances. Probably worth fixing in GCC 10 instead of waiting longer. Bootstrapped/regtested on x86_64-suse-linux, applied on the

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread GT
‐‐‐ Original Message ‐‐‐ On Friday, February 14, 2020 3:38 PM, Jakub Jelinek wrote: > On Fri, Feb 14, 2020 at 08:24:30PM +, GT wrote: > > > Function rs6000_simd_clone_adjust, even though it's body is empty, > > cannot simply be removed. I tried it. It resulted in ICE. In my > > view,

Re: [PATCH 1/3] libstdc++: Fold some ranges algo subroutines into their only caller

2020-02-14 Thread Jonathan Wakely
On 14/02/20 10:35 -0500, Patrick Palka wrote: These subroutines have only a single call site, so it might be best and simplest to eliminate them before we convert the algos into function objects. libstdc++-v3/ChangeLog: * include/bits/ranges_algo.h (ranges::__find_end): Fold into ...

Re: [PATCH] document that alias and target must have the same type

2020-02-14 Thread Sandra Loosemore
On 2/14/20 11:30 AM, Martin Sebor wrote: [snip] Attached is the updated revision that I plan to commit unless you (or anyone else) have further suggestions. This version is OK to commit. -Sandra

Re: [PATCH 00/14] rs6000: Begin replacing built-in support

2020-02-14 Thread Mike Stump
On Feb 14, 2020, at 1:26 PM, Segher Boessenkool wrote: > It remains to be seen how much of it can be used by other targets. > Pretending something is generic while it in fact is just a mass of > special cases isn't useful, it's just costly. Oh, yeah, of course. Ours was designed in two pieces,

[PATCH] debug/93751 Generate DIEs for external variables with -g1

2020-02-14 Thread Alexey Neyman
Hi all, As reported here, https://gcc.gnu.org/ml/gcc-help/2020-02/msg00062.html, GCC does not behave according to manual when `-gdwarf -g1` options are used; it does not generate the debugging information for external variables even though it is supposed to (and it does so for other

Re: [PATCH 3/3] libstdc++: Post-conversion whitespace and formatting adjustments

2020-02-14 Thread Jonathan Wakely
On 14/02/20 10:35 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: * include/bits/ranges_algo.h: Adjust whitespace and formatting. * include/bits/ranges_algobase.h: Likewise. * include/bits/ranges_uninitialized.h: Likewise. OK for master, thanks!

Re: [PATCH v2 0/4] Fix library testsuite compilation for build sysroot

2020-02-14 Thread Maciej W. Rozycki
On Fri, 14 Feb 2020, Mike Stump wrote: > > Thank you, Mike, for your input. That is what v1 did, but it seems to > > clash with some people's expectations, as discussed here: > > > > > > I didn't see any clash with expectations. They

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread Segher Boessenkool
On Fri, Feb 14, 2020 at 08:24:30PM +, GT wrote: > Function rs6000_simd_clone_adjust, even though it's body is empty, > cannot simply be removed. I tried it. It resulted in ICE. In my > view, leaving it empty is preferable to modifying other files > unrelated to rs6000.c in order to avoid

Re: [PATCH 2/3] libstdc++: Convert the ranges algorithm entities into function objects

2020-02-14 Thread Jonathan Wakely
On 14/02/20 10:35 -0500, Patrick Palka wrote: This is the standard way to inhibit ADL for these entities, which is required as per [algorithms.requirements] p2 and [specialized.algorithms] p4. The conversion was done mostly mechanically with a custom Vim macro. [ To make it easier to review,

Re: [PATCH] debug/93751 Generate DIEs for external variables with -g1

2020-02-14 Thread Alexey Neyman
On 2/14/20 4:36 PM, Alexey Neyman wrote: Hi all, As reported here, https://gcc.gnu.org/ml/gcc-help/2020-02/msg00062.html, GCC does not behave according to manual when `-gdwarf -g1` options are used; it does not generate the debugging information for external variables even though it is

[PATCH] match.pd: Disallow side-effects in GENERIC for non-COND_EXPR to COND_EXPR simplifications [PR93744]

2020-02-14 Thread Jakub Jelinek
Hi! As the following testcases show (the first one reported, last two found by code inspection), we need to disallow side-effects in simplifications that turn some unconditional expression into conditional one. From my little understanding of genmatch.c, it is able to automatically disallow side

[PATCH] wwwdocs: P1042R1: mention only partial support [PR92319]

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 08:41:45AM +0100, Jason Merrill wrote: > > I'm afraid I'm completely lost about the padding preservation/removal > > changes that are also in the paper, so haven't touched that part. For this, shall we mention the support is only partial like this? The standard has some

Re: [PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

2020-02-14 Thread Jason Merrill
On 2/13/20 8:56 PM, Marek Polacek wrote: My P0388R4 patch changed build_array_conv to create an identity conversion at the start of the conversion chain. Hmm, an identity conversion of {} suggests that it has a type, which it doesn't in the language. I'm not strongly against it, but what was

Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]

2020-02-14 Thread Uros Bizjak
On Fri, Feb 14, 2020 at 8:06 AM Uros Bizjak wrote: > > On Fri, Feb 14, 2020 at 7:03 AM Hongtao Liu wrote: > > > > On Thu, Feb 13, 2020 at 5:31 PM Hongtao Liu wrote: > > > > > > On Thu, Feb 13, 2020 at 5:12 PM Uros Bizjak wrote: > > > > > > > > On Thu, Feb 13, 2020 at 9:53 AM Jakub Jelinek

[PATCH] sra: Avoid verification failure (PR 93516)

2020-02-14 Thread Martin Jambor
Hi, get_ref_base_and_extent can return different sizes for COMPONENT_REFs and DECLs of the same type, with the latter including (more?) padding. When in the IL there is an assignment between such a COMPONENT_REF and a DECL, SRA will try to propagate the access from the former as a child of the

Re: [PATCH] sra: Avoid verification failure (PR 93516)

2020-02-14 Thread Richard Biener
On Fri, 14 Feb 2020, Martin Jambor wrote: > Hi, > > get_ref_base_and_extent can return different sizes for COMPONENT_REFs > and DECLs of the same type, with the latter including (more?) padding. > When in the IL there is an assignment between such a COMPONENT_REF and a > DECL, SRA will try to

Re: [PATCH] aarch64: Allow -mcpu=generic -march=armv8.5-a

2020-02-14 Thread Richard Earnshaw (lists)
On 14/02/2020 03:18, apin...@marvell.com wrote: From: Andrew Pinski Right if someone supplies a -mcpu= option and then overrides that option with -march=*, we get a warning when they conflict. What we need is a generic cpu for each arch level but that is not that useful because the only

Re: [PATCH] wwwdocs: P1042R1: mention only partial support [PR92319]

2020-02-14 Thread Jason Merrill
On 2/14/20 9:18 AM, Jakub Jelinek wrote: On Fri, Feb 14, 2020 at 08:41:45AM +0100, Jason Merrill wrote: I'm afraid I'm completely lost about the padding preservation/removal changes that are also in the paper, so haven't touched that part. For this, shall we mention the support is only

Re: [PATCH] aarch64: Allow -mcpu=generic -march=armv8.5-a

2020-02-14 Thread Andrew Pinski
On Fri, Feb 14, 2020 at 2:12 AM Richard Earnshaw (lists) wrote: > > On 14/02/2020 03:18, apin...@marvell.com wrote: > > From: Andrew Pinski > > > > Right if someone supplies a -mcpu= option and then overrides > > that option with -march=*, we get a warning when they conflict. > > What we need is