Re: [PATCH] testsuite: Run vec_insert case on P8 and P9 with option specified

2021-01-28 Thread Segher Boessenkool
Hi! On Thu, Jan 28, 2021 at 02:40:25AM -0600, Xionghu Luo wrote: > Move common functions to header file for cleanup. > > gcc/testsuite/ChangeLog: > > 2021-01-27 Xionghu Luo > > * gcc.target/powerpc/pr79251.p8.c: Move definition to ... > * gcc.target/powerpc/pr79251.h: ...this. >

Re: [PATCH v3] clear VLA bounds in attribute access (PR 97172)

2021-01-28 Thread Martin Sebor via Gcc-patches
On 1/28/21 1:31 AM, Richard Biener wrote: On Thu, Jan 28, 2021 at 12:08 AM Martin Sebor via Gcc-patches wrote: Attached is another attempt to fix the problem caused by allowing front-end trees representing nontrivial VLA bound expressions to stay in attribute access attached to functions.

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Segher Boessenkool
On Thu, Jan 28, 2021 at 02:30:56PM -0500, Michael Meissner wrote: > On Thu, Jan 28, 2021 at 12:59:18PM -0600, Segher Boessenkool wrote: > > On Thu, Jan 28, 2021 at 01:10:39PM -0500, Michael Meissner wrote: > > > > The whole thread is at > > > >

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 10:34 AM, Marek Polacek wrote: A year ago I submitted this patch: ~~ Here we trip on the TYPE_USER_ALIGN (t) assert in strip_typedefs: it gets "const d[0]" with TYPE_USER_ALIGN=0 but the result built by build_cplus_array_type is "const char[0]" with TYPE_USER_ALIGN=1. When we

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Segher Boessenkool
On Thu, Jan 28, 2021 at 01:58:26PM -0600, Peter Bergner wrote: > On 1/28/21 1:47 PM, Segher Boessenkool wrote: > > On Thu, Jan 28, 2021 at 02:30:56PM -0500, Michael Meissner wrote: > >> The second patch I want you to review is: > > > > "This patch replaces the following three patches:" > > > >

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Eric Botcazou
> Aware. I don't have access to, e.g., a sparc box. But the test I've added > uses -mstrict-align where possible to check that the issue is resolved. There are relatively fast SPARC64/Linux (gcc202) and SPARC/Solaris machines (gcc210 and gcc211) in the Compile Farm:

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Marek Polacek via Gcc-patches
On Thu, Jan 28, 2021 at 11:38:34PM +0100, Eric Botcazou wrote: > > Aware. I don't have access to, e.g., a sparc box. But the test I've added > > uses -mstrict-align where possible to check that the issue is resolved. > > There are relatively fast SPARC64/Linux (gcc202) and SPARC/Solaris

[PATCH] adjust "partly out of bounds" warning (PR 98503)

2021-01-28 Thread Martin Sebor via Gcc-patches
The GCC 11 -Warray-bounds enhancement to diagnose accesses whose leading offset is in bounds but whose trailing offset is not has been causing some confusion. When the warning is issued for an access to an in-bounds member via a pointer to a struct that's larger than the pointed-to object,

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Marek Polacek via Gcc-patches
On Thu, Jan 28, 2021 at 11:02:36PM +0100, Eric Botcazou wrote: > > Bootstrapped/regtested on > > * x86_64-pc-linux-gnu > > * powerpc64le-unknown-linux-gnu > > * aarch64-linux-gnu > > ok for trunk? > > None of them is strict alignment though, isn't it? Aware. I don't have access to, e.g., a

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Peter Bergner via Gcc-patches
On 1/28/21 1:47 PM, Segher Boessenkool wrote: > On Thu, Jan 28, 2021 at 02:30:56PM -0500, Michael Meissner wrote: >> The second patch I want you to review is: > > "This patch replaces the following three patches:" > > Please send a patch that modifies *current* code, and that is *tested* > with

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Marek Polacek via Gcc-patches
On Thu, Jan 28, 2021 at 03:18:55PM -0500, Jason Merrill via Gcc-patches wrote: > On 1/28/21 10:34 AM, Marek Polacek wrote: > > A year ago I submitted this patch: > > > > ~~ > > Here we trip on the TYPE_USER_ALIGN (t) assert in strip_typedefs: it > > gets "const d[0]" with TYPE_USER_ALIGN=0 but

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 3:36 PM, Marek Polacek wrote: On Thu, Jan 28, 2021 at 03:18:55PM -0500, Jason Merrill via Gcc-patches wrote: On 1/28/21 10:34 AM, Marek Polacek wrote: A year ago I submitted this patch: ~~ Here we trip on the TYPE_USER_ALIGN (t) assert in strip_typedefs: it gets "const d[0]" with

Re: [PATCH v3] clear VLA bounds in attribute access (PR 97172)

2021-01-28 Thread Martin Sebor via Gcc-patches
On 1/28/21 2:22 AM, Jakub Jelinek wrote: On Thu, Jan 28, 2021 at 09:31:46AM +0100, Richard Biener via Gcc-patches wrote: + if (TREE_CODE (bound) == PLUS_EXPR + && integer_all_onesp (TREE_OPERAND (bound, 1))) +{ + bound = TREE_OPERAND (bound, 0); + if (TREE_CODE (bound) ==

Re: [PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Eric Botcazou
> Bootstrapped/regtested on > * x86_64-pc-linux-gnu > * powerpc64le-unknown-linux-gnu > * aarch64-linux-gnu > ok for trunk? None of them is strict alignment though, isn't it? -- Eric Botcazou

Re: [PATCH v3] clear VLA bounds in attribute access (PR 97172)

2021-01-28 Thread Richard Biener via Gcc-patches
On Thu, Jan 28, 2021 at 12:08 AM Martin Sebor via Gcc-patches wrote: > > Attached is another attempt to fix the problem caused by allowing > front-end trees representing nontrivial VLA bound expressions to > stay in attribute access attached to functions. Since removing > these trees seems to be

[PATCH] testsuite: Run vec_insert case on P8 and P9 with option specified

2021-01-28 Thread Xionghu Luo via Gcc-patches
Move common functions to header file for cleanup. gcc/testsuite/ChangeLog: 2021-01-27 Xionghu Luo * gcc.target/powerpc/pr79251.p8.c: Move definition to ... * gcc.target/powerpc/pr79251.h: ...this. * gcc.target/powerpc/pr79251.p9.c: Likewise. *

Re: [RFC] test builtin ratio for loop distribution

2021-01-28 Thread Richard Biener via Gcc-patches
On Thu, Jan 28, 2021 at 6:28 AM Alexandre Oliva wrote: > > On Jan 27, 2021, Richard Biener wrote: > > > That said, rather than not transforming the loop as you do I'd > > say we want to re-inline small copies more forcefully during > > loop distribution code-gen so we turn a loop that sets > > 3

Fix LTO bootstrap on Windows (PR lto/85574)

2021-01-28 Thread Eric Botcazou
The last fix made for PR lto/85574 introduced a comparison of executables and this cannot directly work on Windows because they are timestamped. Moreover nobody sets $(exeext) at top level, at least on MinGW, so you get a weird behavior because some tools add the implicit .exe suffix and

Re: [PATCH] rtl-optimization/80960 - avoid creating garbage RTL in DSE

2021-01-28 Thread Richard Biener
On Wed, 27 Jan 2021, Jakub Jelinek wrote: > On Wed, Jan 27, 2021 at 03:40:38PM +0100, Richard Biener wrote: > > The following avoids repeatedly turning VALUE RTXen into > > sth useful and re-applying a constant offset through get_addr > > via DSE check_mem_read_rtx. Instead perform this once for

Re: [PATCH PR97627]Avoid computing niters info for fake edges

2021-01-28 Thread Richard Biener via Gcc-patches
On Thu, Jan 28, 2021 at 3:49 AM bin.cheng via Gcc-patches wrote: > > Hi, > As described in commit message, we need to avoid computing niters info for > fake > edges. This simple patch does this by two changes. > > Bootstrap and test on X86_64, is it ok? Hmm, so I think the patch is a bit

[PATCH] c++: Fix up handling of register ... asm ("...") vars in templates [PR33661, PR98847]

2021-01-28 Thread Jakub Jelinek via Gcc-patches
Hi! As the testcase shows, for vars appearing in templates, we don't attach the asm spec string to the pattern decls, nor pass it back to cp_finish_decl during instantiation. The following patch does that. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2021-01-27 Jakub

[PATCH] c++: Fix -Weffc++ in templates [PR98841]

2021-01-28 Thread Jakub Jelinek via Gcc-patches
Hi! We emit a bogus warning on the following testcase, suggesting that the operator should return *this even when it does that already. The problem is that normally cp_build_indirect_ref_1 ensures that *this is folded as current_class_ref, but in templates (if return type is non-dependent,

Re: [PATCH][X86] Enable X86_TUNE_AVX256_UNALIGNED_{LOAD, STORE}_OPTIMAL for generic tune [PR target/98172]

2021-01-28 Thread Richard Biener via Gcc-patches
On Thu, Jan 28, 2021 at 7:32 AM Hongtao Liu via Gcc-patches wrote: > > Hi: >GCC11 will be the system GCC 2 years from now, and for the > processors then, they shouldn't even need to split a 256-bit vector > into 2 128-bits vectors. >.i.e. Test SPEC2017 with the below 2 options on Zen3/ICL

Re: Fix LTO bootstrap on Windows (PR lto/85574)

2021-01-28 Thread Richard Biener via Gcc-patches
On Thu, Jan 28, 2021 at 9:35 AM Eric Botcazou wrote: > > The last fix made for PR lto/85574 introduced a comparison of executables and > this cannot directly work on Windows because they are timestamped. Moreover > nobody sets $(exeext) at top level, at least on MinGW, so you get a weird >

Re: [PATCH] [8/9/10/11 Regression] [OOP] PR fortran/86470 - ICE with OpenMP

2021-01-28 Thread Harald Anlauf via Gcc-patches
Hi Thomas, > > Should the testcase be moved to the gomp/ subdirectory? > Yes. It's a compile-time test, and it will then only be run > if the the compiler can do OpenMP. > > You will not need the > > +! { dg-options "-fopenmp" } > > line, then. Adjusted and committed as

[committed] c++: Some C++20 and C++23 option help fixes

2021-01-28 Thread Jakub Jelinek via Gcc-patches
Hi! I've noticed we still refer to C++20 as draft standard, and there is a pasto in C++23 description. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2021-01-28 Jakub Jelinek * c.opt (-std=c++2a, -std=c++20, -std=gnu++2a,

[PATCH] aarch64: Reimplement vshrn_n* intrinsics using builtins

2021-01-28 Thread Kyrylo Tkachov via Gcc-patches
Hi all, This patch reimplements the vshrn_n* intrinsics to use RTL builtins. These perform a narrowing right shift. Although the intrinsic generates the half-width mode (e.g. V8HI -> V8QI), the new pattern generates a full 128-bit mode (V8HI -> V16QI) by representing the fill-with-zeroes

[PATCH] aarch64: Reimplement vshrn_high_n* intrinsics using builtins

2021-01-28 Thread Kyrylo Tkachov via Gcc-patches
Hi all, This patch reimplements the vshrn_high_n* intrinsics that generate the SHRN2 instruction. It is a vec_concat of the narrowing shift with the bottom part of the destination register, so we need a little-endian and a big-endian version and an expander to pick between them. Bootstrapped

Re: [PATCH v3] clear VLA bounds in attribute access (PR 97172)

2021-01-28 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 28, 2021 at 09:31:46AM +0100, Richard Biener via Gcc-patches wrote: > + if (TREE_CODE (bound) == PLUS_EXPR > + && integer_all_onesp (TREE_OPERAND (bound, 1))) > +{ > + bound = TREE_OPERAND (bound, 0); > + if (TREE_CODE (bound) == NOP_EXPR) > + bound =

Re: [PATCH] libstdc++: implement locale support for AIX

2021-01-28 Thread CHIGOT, CLEMENT via Gcc-patches
>> * While you now define _GLIBCXX_C_LOCALE_XPG7 in >>  config/locale/xpg7/c_locale.h, config/os/aix/ctype_configure_char.cc >>   still tests the previous _GLIBCXX_C_LOCALE_IEEE_2008. > > Arf, I've missed that. it might not be the last patch then. > (I've made so much versions of it as I've tried

Re: [PATCH PR97627]Avoid computing niters info for fake edges

2021-01-28 Thread Bin.Cheng via Gcc-patches
On Thu, Jan 28, 2021 at 5:08 PM Richard Biener via Gcc-patches wrote: > > On Thu, Jan 28, 2021 at 3:49 AM bin.cheng via Gcc-patches > wrote: > > > > Hi, > > As described in commit message, we need to avoid computing niters info for > > fake > > edges. This simple patch does this by two

[PATCH] PING lra: clear lra_insn_recog_data after simplifying a mem subreg

2021-01-28 Thread Ilya Leoshkevich via Gcc-patches
Hello, I would like to ping the following patch: lra: clear lra_insn_recog_data after simplifying a mem subreg https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563428.html Best regards, Ilya

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Michael Meissner via Gcc-patches
I rebusmitted the patch after verifying it still builds and works with the current branch as: https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564486.html | Subject: [PATCH] Add conversions between _Float128 and Decimal. | Message-ID: <20210129024208.ga25...@ibm-toto.the-meissners.org> --

[PATCH, rs6000] Optimization for PowerPC 64bit constant generation [PR94395]

2021-01-28 Thread HAO CHEN GUI via Gcc-patches
Hi,    This patch tries to optimize PowerPC 64 bit constant generation when the constant can be transformed from a 32 bit or 16 bit constant by rotating, shifting and mask AND.    The attachments are the patch diff file and change log file.    Bootstrapped and tested on powerpc64le with no

[PATCH] c++: Fix infinite looping with invalid operator [PR96137]

2021-01-28 Thread Marek Polacek via Gcc-patches
My r11-86 adjusted cp_parser_class_name to do - scope = parser->scope; + scope = parser->scope ? parser->scope : parser->context->object_type; if (scope == error_mark_node) return error_mark_node; but that caused endless looping in cp_parser_type_specifier_seq (the while (true) loop)

Re: Default to DWARF5

2021-01-28 Thread Paul A. Clarke via Gcc-patches
The subject commit, 3804e937b0e252a7e42632fe6d9f898f1851a49c, causes a failure in the test suite for the IBM Advance Toolchain. The test in question uses "perf probe" to set a tracepoint at "main" in a newly built (with GCC 11) binary of "/bin/ld". With the patch applied, the command enters an

Re: [PATCH] c++: Fix infinite looping with invalid operator [PR96137]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 10:57 PM, Marek Polacek wrote: My r11-86 adjusted cp_parser_class_name to do - scope = parser->scope; + scope = parser->scope ? parser->scope : parser->context->object_type; if (scope == error_mark_node) return error_mark_node; but that caused endless looping in

Go driver patch committed: Always act as though -g was passed

2021-01-28 Thread Ian Lance Taylor via Gcc-patches
The go1 compiler always turns on debugging, to support Go stack traces and functions like runtime.Callers. With the recent switch to turn on DWARF 5 by default, this caused failures with some versions of gas, such as 2.35.1, because the assembly code would assume DWARF 5 but the driver would not

[PATCH] Add conversions between _Float128 and Decimal.

2021-01-28 Thread Michael Meissner via Gcc-patches
[PATCH] Add conversions between _Float128 and Decimal. This patch implements conversions between _Float128 and the 3 Decimal floating types. It does by extendending the dfp-bit conversions to add a new binary floating point type (KF), and doing the conversions in the same mannor as the other

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Michael Meissner via Gcc-patches
On Thu, Jan 28, 2021 at 12:59:18PM -0600, Segher Boessenkool wrote: > On Thu, Jan 28, 2021 at 01:10:39PM -0500, Michael Meissner wrote: > > > The whole thread is at > > > https://patchwork.ozlabs.org/project/gcc/patch/2020112524.ga...@ibm-toto.the-meissners.org/ > > > . > > > > > > I

[committed] libstdc++: Fix copyright dates for simd headers and tests

2021-01-28 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/experimental/bits/numeric_traits.h: Update copyright dates. * include/experimental/bits/simd.h: Likewise. * include/experimental/bits/simd_builtin.h: Likewise. * include/experimental/bits/simd_converter.h: Likewise.

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Segher Boessenkool
On Thu, Jan 28, 2021 at 01:10:39PM -0500, Michael Meissner wrote: > > The whole thread is at > > https://patchwork.ozlabs.org/project/gcc/patch/2020112524.ga...@ibm-toto.the-meissners.org/ > > . > > > > I approved *that* version of the patch. > > Yes you approved the built-in renaming

[PATCH] tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]

2021-01-28 Thread Marek Polacek via Gcc-patches
A year ago I submitted this patch: ~~ Here we trip on the TYPE_USER_ALIGN (t) assert in strip_typedefs: it gets "const d[0]" with TYPE_USER_ALIGN=0 but the result built by build_cplus_array_type is "const char[0]" with TYPE_USER_ALIGN=1. When we strip_typedefs the element of the array "const d",

[COMMITTED] PowerPC: Map IEEE 128-bit long double built-ins.

2021-01-28 Thread Michael Meissner via Gcc-patches
After testing the patch I submitted on November 17th that was approved to make sure it still works, I commited the patch to the master branch. Sorry about the intermediate rewrites. [PATCH] Map long double built-ins correctly with IEEE 128-bit long double. The PowerPC has two different 128-bit

Re: arm: Adjust cost of vector of constant zero

2021-01-28 Thread Christophe Lyon via Gcc-patches
On Wed, 27 Jan 2021 at 15:03, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: 27 January 2021 13:56 > > To: Kyrylo Tkachov > > Cc: Kyrylo Tkachov via Gcc-patches > > Subject: Re: arm: Adjust cost of vector of constant zero > > > > On Wed, 27 Jan

[PATCH] use memcpy instead of strncpy for dyn_string insertion

2021-01-28 Thread Martin Sebor via Gcc-patches
Calling strncpy in libiberty's dyn_string_insert() with the last argument equal to the length of the second triggers the warning: /src/gcc/master/libiberty/dyn-string.c:280:3: warning: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length

Re: [Ping] PowerPC: Add float128/Decimal conversions.

2021-01-28 Thread Michael Meissner via Gcc-patches
On Wed, Jan 27, 2021 at 09:11:49PM -0600, Segher Boessenkool wrote: > On Tue, Jan 26, 2021 at 06:43:06PM -0500, Michael Meissner wrote: > > I posted this patch on January 14th, 2021: > > https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563498.html > > > > | Date: Thu, 14 Jan 2021 12:09:36

Re: [PATCH] c++, v2: Fix -Weffc++ in templates [PR98841]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 10:24 AM, Jakub Jelinek wrote: On Thu, Jan 28, 2021 at 10:04:12AM -0500, Jason Merrill wrote: We emit a bogus warning on the following testcase, suggesting that the operator should return *this even when it does that already. The problem is that normally cp_build_indirect_ref_1

Re: [PATCH PR97627]Avoid computing niters info for fake edges

2021-01-28 Thread Richard Biener via Gcc-patches
On Thu, Jan 28, 2021 at 11:31 AM Bin.Cheng wrote: > > On Thu, Jan 28, 2021 at 5:08 PM Richard Biener via Gcc-patches > wrote: > > > > On Thu, Jan 28, 2021 at 3:49 AM bin.cheng via Gcc-patches > > wrote: > > > > > > Hi, > > > As described in commit message, we need to avoid computing niters info

c++: header unit template alias merging [PR 98770]

2021-01-28 Thread Nathan Sidwell
Typedefs are streamed by streaming the underlying type, and then recreating the typedef. But this breaks checking a duplicate is the same as the original when it is a template alias -- we end up checking a template alias (eg __void_t) against the underlying type (void). And those are not the

RE: aarch64: Use RTL builtins for [su]mlal_n intrinsics

2021-01-28 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Jonathan Wright > Sent: 28 January 2021 12:04 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov > Subject: aarch64: Use RTL builtins for [su]mlal_n intrinsics > > Hi, > > As subject, this patch rewrites [su]mlal_n Neon intrinsics to use RTL builtins >

Re: [PATCH] c++: Fix up handling of register ... asm ("...") vars in templates [PR33661, PR98847]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 3:52 AM, Jakub Jelinek wrote: Hi! As the testcase shows, for vars appearing in templates, we don't attach the asm spec string to the pattern decls, nor pass it back to cp_finish_decl during instantiation. The following patch does that. Bootstrapped/regtested on x86_64-linux and

aarch64: Use RTL builtins for [su]mlal_n intrinsics

2021-01-28 Thread Jonathan Wright via Gcc-patches
Hi, As subject, this patch rewrites [su]mlal_n Neon intrinsics to use RTL builtins rather than inline assembly code, allowing for better scheduling and optimization. Regression tested and bootstrapped on aarch64-none-linux-gnu - no issues. Ok for master? Thanks, Jonathan --- gcc/ChangeLog:

Re: c++: header unit template alias merging [PR 98770]

2021-01-28 Thread Nathan Sidwell
On 1/28/21 7:54 AM, Nathan Sidwell wrote: Typedefs are streamed by streaming the underlying type, and then recreating the typedef.  But this breaks checking a duplicate is the same as the original when it is a template alias -- we end up checking a template alias (eg __void_t) against the

Re: [PATCH][X86] Enable X86_TUNE_AVX256_UNALIGNED_{LOAD, STORE}_OPTIMAL for generic tune [PR target/98172]

2021-01-28 Thread H.J. Lu via Gcc-patches
On Thu, Jan 28, 2021 at 1:21 AM Richard Biener via Gcc-patches wrote: > > On Thu, Jan 28, 2021 at 7:32 AM Hongtao Liu via Gcc-patches > wrote: > > > > Hi: > >GCC11 will be the system GCC 2 years from now, and for the > > processors then, they shouldn't even need to split a 256-bit vector > >

[PATCH] aarch64: Use RTL builtins for [su]mlsl_n intrinsics

2021-01-28 Thread Jonathan Wright via Gcc-patches
Hi, As subject, this patch rewrites [su]mlsl_n Neon intrinsics to use RTL builtins rather than inline assembly code, allowing for better scheduling and optimization. Regression tested and bootstrapped on aarch64-none-linux-gnu - no issues. Ok for master? Thanks, Jonathan --- gcc/ChangeLog:

Re: [PATCH] c++: Fix -Weffc++ in templates [PR98841]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 3:58 AM, Jakub Jelinek wrote: Hi! We emit a bogus warning on the following testcase, suggesting that the operator should return *this even when it does that already. The problem is that normally cp_build_indirect_ref_1 ensures that *this is folded as current_class_ref, but in

Re: [PATCH] c++: fix string literal member initializer bug [PR90926]

2021-01-28 Thread Jason Merrill via Gcc-patches
On 1/28/21 9:54 AM, Tom Greenslade (thomgree) wrote: While trying to fix the suggested overload resolution issue I run into another bug: struct A { char str[4]; }; void f(A) {}; int main () { f({"foo"}); } Does not compile on GCC: "error: could not convert ‘{"foo"}’ from ‘’ to ‘A’",

[PATCH] c++, v2: Fix -Weffc++ in templates [PR98841]

2021-01-28 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 28, 2021 at 10:04:12AM -0500, Jason Merrill wrote: > > We emit a bogus warning on the following testcase, suggesting that the > > operator should return *this even when it does that already. > > The problem is that normally cp_build_indirect_ref_1 ensures that *this > > is folded as

[PATCH] aarch64: Fix gcc.target/aarch64/narrow_high-intrinsics.c testism

2021-01-28 Thread Kyrylo Tkachov via Gcc-patches
Pushing to fix recently-updated assembly generation. gcc/testsuite/ * gcc.target/aarch64/narrow_high-intrinsics.c: Fix shrn2 scan. shrn2.patch Description: shrn2.patch

RE: [PATCH] aarch64: Use RTL builtins for [su]mlsl_n intrinsics

2021-01-28 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Jonathan Wright > Sent: 28 January 2021 13:23 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov > Subject: [PATCH] aarch64: Use RTL builtins for [su]mlsl_n intrinsics > > Hi, > > As subject, this patch rewrites [su]mlsl_n Neon intrinsics to use RTL

RE: [PATCH] c++: fix string literal member initializer bug [PR90926]

2021-01-28 Thread Tom Greenslade (thomgree) via Gcc-patches
While trying to fix the suggested overload resolution issue I run into another bug: struct A { char str[4]; }; void f(A) {}; int main () { f({"foo"}); } Does not compile on GCC: "error: could not convert ‘{"foo"}’ from ‘’ to ‘A’", but works fine on Clang. Is this a known bug or a new