[committed] Increase timeout factor for hppa*-*-* in gcc.dg/long_branch.c

Committed to trunk. Dave --- Increase timeout factor for hppa*-*-* in gcc.dg/long_branch.c 2023-10-02 John David Anglin gcc/testsuite/ChangeLog: * gcc.dg/long_branch.c: Increase timeout factor for hppa*-*-*. diff --git a/gcc/testsuite/gcc.dg/long_branch.c

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On 10/2/23 11:20, David Edelsohn wrote: Wang, The AWK portions of this patch broke bootstrap on AIX. Also, the AWK portions are common code, not RISC-V specific.  I don't see anywhere that the common portions of the patch were reviewed or approved by anyone with authority to approve the

Re: [PATCH] Fix coroutine tests for libstdc++ gnu-version-namespace mode

Hi Gentle reminder for this minor patch. Thanks On 23/09/2023 22:10, François Dumont wrote: I'm eventually fixing those tests the same way we manage this problem in libstdc++ testsuite.    testsuite: Add optional libstdc++ version namespace in expected diagnostic     When libstdc++ is

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Wang, The AWK portions of this patch broke bootstrap on AIX. Also, the AWK portions are common code, not RISC-V specific. I don't see anywhere that the common portions of the patch were reviewed or approved by anyone with authority to approve the changes to the AWK files. This patch should not

[PATCH] c++: merge tsubst_copy into tsubst_copy_and_build

Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- The relationship between tsubst_copy_and_build and tsubst_copy (two of the main template argument substitution routines for expression trees) is rather hazy. The former is mostly a superset of the latter,

Re: [PATCH v2] ARM: Block predication on atomics [PR111235]

Hi Ramana, >> I used --target=arm-none-linux-gnueabihf --host=arm-none-linux-gnueabihf >> --build=arm-none-linux-gnueabihf --with-float=hard. However it seems that the >> default armhf settings are incorrect. I shouldn't need the --with-float=hard >> since >> that is obviously implied by armhf,

[pushed] contrib: Update Darwin entries in config-list.mk

Although the script itself is very unlikely to be useful (it would assume availability of both 'binutils' and a sysroot for each target) the list is used by at least one vendor for some testing. So I'd encourage other port maintainers to make sure their entries are up to date! I tested this on

Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050]

Now backport to gcc-11/12/13 branches. On 29/09/2023 11:53, Jonathan Wakely wrote: On Thu, 28 Sept 2023 at 18:25, François Dumont wrote: On 28/09/2023 18:18, Jonathan Wakely wrote: On Wed, 27 Sept 2023 at 05:44, François Dumont wrote: Still no chance to get feedback from TC ? Maybe I can

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On Mon, Oct 2, 2023 at 1:59 PM Jeff Law wrote: > > > On 10/2/23 11:20, David Edelsohn wrote: > > Wang, > > > > The AWK portions of this patch broke bootstrap on AIX. > > > > Also, the AWK portions are common code, not RISC-V specific. I don't > > see anywhere that the common portions of the

[committed] Add hppa*-*-* to dg-error targets at line 5 in gfortran.dg/pr95690.f90

Committed to trunk. Dave --- Add hppa*-*-* to dg-error targets at line 5 2023-10-02 John David Anglin gcc/testsuite/ChangeLog: * gfortran.dg/pr95690.f90: Add hppa*-*-* to dg-error targets at line 5. diff --git a/gcc/testsuite/gfortran.dg/pr95690.f90

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

On 10/2/23 12:03, David Edelsohn wrote: On Mon, Oct 2, 2023 at 1:59 PM Jeff Law > wrote: On 10/2/23 11:20, David Edelsohn wrote: > Wang, > > The AWK portions of this patch broke bootstrap on AIX. > > Also, the AWK portions are

[committed] Require target lra in gcc.dg/pr108095.c

Committed to trunk. Dave --- Require target lra in gcc.dg/pr108095.c 2023-10-02 John David Anglin gcc/testsuite/ChangeLog: * gcc.dg/pr108095.c: Require target lra. diff --git a/gcc/testsuite/gcc.dg/pr108095.c b/gcc/testsuite/gcc.dg/pr108095.c index fb76caae72e..0a487cf614a 100644

mvconst_internal splitter gated with !@ira_in_progess (was Re: Yet Another IRA question)

On 9/28/23 12:52, Vineet Gupta wrote: On 9/28/23 05:53, Jeff Law wrote: Vineet -- assuming Vlad's patch goes in, the other obvious candidate for this would be the mvconst_internal define_insn_and_split where we'd probably want to reject the insn as a whole once IRA has started. Good

Re: [committed] Require target lra in gcc.dg/pr108095.c

On 10/2/23 14:42, John David Anglin wrote: Committed to trunk. Dave --- Require target lra in gcc.dg/pr108095.c 2023-10-02 John David Anglin gcc/testsuite/ChangeLog: * gcc.dg/pr108095.c: Require target lra. Thanks. I already had this in my local tree. jeff

RFC: attributes documentation

When I was working on something else recently, I realized that the GCC manual had nothing in its attributes section saying that you could use the various documented GCC extension attributes with C/C++ standard attribute syntax too, or how (you have to use the "gnu::" prefix); I ended up finding

[PATCH] RISC-V: Fix the riscv_legitimize_poly_move issue on targets where the minimal VLEN exceeds 512.

riscv_legitimize_poly_move was expected to ensure the poly value is at most 32 times smaller than the minimal VLEN (32 being derived from '4096 / 128'). This assumption held when our mode modeling was not so precisely defined. However, now that we have modeled the mode size according to the

[PATCH] libcpp: testsuite: Add test for fixed _Pragma bug [PR82335]

Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82335 is another _Pragma-related bug that got fixed in GCC 12 but is still open. Before closing it out, I thought it would be good to add the testcase from that PR, which we don't have exactly in the testsuite already. Is it OK please? Thanks!

Re: [RFC] expr: don't clear SUBREG_PROMOTED_VAR_P flag for a promoted subreg [target/111466]

On 9/29/23 05:14, Jeff Law wrote: On 9/28/23 21:49, Vineet Gupta wrote: On 9/28/23 20:17, Jeff Law wrote: I can bootstrap & regression test alpha using QEMU user mode emulation. So we might be able to trigger something that way. It'll take some time, but might prove fruitful. That

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

Proposed fix, and verified with "mawk" and "gawk -P" (gawk with posix mode) on my linux also some other report it work on freebsd, just wait review :) https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631785.html On Tue, Oct 3, 2023 at 2:07 AM Jeff Law wrote: > > > > On 10/2/23 12:03,

Re: [PATCH] libiberty: Use posix_spawn in pex-unix when available.

On Fri, Sep 29, 2023 at 12:18 PM Brendan Shanks wrote: > > + #define ERR_ON_FAILURE(ret, func) \ > +do { if (ret) { *err = ret; *errmsg = func; goto exit; } else {} } while > (0) Thanks, but please don't use a macro that changes control flow. Ian

Re: [PATCH] Remove poly_int_pod

Jan-Benedict Glaw writes: > Hi Richard, > > On Thu, 2023-09-28 10:55:46 +0100, Richard Sandiford > wrote: >> poly_int was written before the switch to C++11 and so couldn't >> use explicit default constructors. This led to an awkward split >> between poly_int_pod and poly_int. poly_int simply

Re: [PATCH] RISC-V: Use safe_grow_cleared for vector info [PR111469]

On Sun, Oct 01, 2023 at 07:03:51AM +0800, 钟居哲 wrote: > LGTM. > > juzhe.zh...@rivai.ai > > diff --git a/gcc/config/riscv/riscv-vsetvl.cc > b/gcc/config/riscv/riscv-vsetvl.cc > index af8c31d873c..4b06d93e7f9 100644 > --- a/gcc/config/riscv/riscv-vsetvl.cc > +++ b/gcc/config/riscv/riscv-vsetvl.cc

[PATCH 1/3]middle-end: Refactor vectorizer loop conditionals and separate out IV to new variables

Hi All, This is extracted out of the patch series to support early break vectorization in order to simplify the review of that patch series. The goal of this one is to separate out the refactoring from the new functionality. This first patch separates out the vectorizer's definition of an exit

Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c

ping? maybe this counts as obvious? On Thu, 14 Sept 2023 at 11:13, Christophe Lyon wrote: > ping? > > On Fri, 8 Sept 2023 at 10:43, Christophe Lyon > wrote: > >> The test was declaring 'int *carry;' and wrote to '*carry' without >> initializing 'carry' first, leading to an attempt to write at

Re: [PATCH] Remove poly_int_pod

Hi Richard, On Thu, 2023-09-28 10:55:46 +0100, Richard Sandiford wrote: > poly_int was written before the switch to C++11 and so couldn't > use explicit default constructors. This led to an awkward split > between poly_int_pod and poly_int. poly_int simply inherited from > poly_int_pod and

[pushed] Fix profiledbootstrap poly_int fallout [PR111642]

rtl-tests.cc and simplify-rtx.cc used partial specialisation to try to restrict the NUM_POLY_INT_COEFFS>1 tests without resorting to preprocessor tests. That now triggers an error in some configurations, since the NUM_POLY_INT_COEFFS>1 tests used the global poly_int64, whose definition does not

[pushed] testsuite, Darwin: Skip g++.dg/debug/dwarf2/pr85550.C

Tested on x86_64-darwin21 pushed to trunk, thanks, Iain --- 8< --- There are two problems here; first that the emitted asm for -fdebug-types-section is ELF-specfic leading to assembler errors for Mach-O. If we fix this, we get a secondary fail since the debug linker does not recognise

[PATCH 3/3]middle-end: maintain LCSSA throughout loop peeling

Hi All, This final patch updates peeling to maintain LCSSA all the way through. It's significantly easier to maintain it during peeling while we still know where all new edges connect rather than touching it up later as is currently being done. This allows us to remove many of the helper

[PATCH 2/3]middle-end: updated niters analysis to handle multiple exits.

Hi All, This second part updates niters analysis to be able to analyze any number of exits. If we have multiple exits we determine the main exit by finding the first counting IV. The change allows the vectorizer to pass analysis for multiple loops, but we later gracefully reject them. It does

[PATCH] options: Prevent multidimensional arrays

Multidimensional arrary is gawk extension, and we accidentally introduced that in recent commit[1]. [1] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=e4a4b8e983bac865eb435b11798e38d633b98942 gcc/ChangeLog: * opt-read.awk: Drop multidimensional arrays. * opth-gen.awk: Ditto. ---

Re: [PATCH 1/2] testsuite: Add and use thread_fence effective-target

ping? On Sun, 10 Sept 2023 at 21:31, Christophe Lyon wrote: > Some targets like arm-eabi with newlib and default settings rely on > __sync_synchronize() to ensure synchronization. Newlib does not > implement it by default, to make users aware they have to take special > care. > > This makes a

Re: [PATCH v1] Mode-Switching: Add optional EMIT_AFTER hook

> Conceptually the rounding mode is just a property. The call, in > effect, should demand a "normal" rounding mode and set the rounding > mode to unknown if I understand how this is supposed to work. If my > understanding is wrong, then maybe that's where we should start -- > with a good

Re: [PATCH v6] RISC-V:Optimize the MASK opt generation

On Mon, 2 Oct 2023, Kito Cheng wrote: > Thanks for reporting this issue, I just realized multidimensional > arrays are gawk extensions, could you try the attached patch to see if > it can resolve the issue? Yes, with that patch applied the build proceeds far beyond that point (still running).

[PATCH] LoongArch: Replace UNSPEC_FCOPYSIGN with copysign RTL

When I added copysign support for LoongArch (r13-3702), we did not have a copysign RTL insn, so I had to use UNSPEC to represent the copysign instruction. Now the copysign RTX code has been added in r14-1586, so this patch removes those UNSPECs, and it uses the native RTL copysign insn. Inspired

Re: [PATCH v2] RISC-V: Implement TLS Descriptors.

Just one nit and one more comment for doc: Could you add some doc something like that? mostly I grab from other target, so you can just included in the patch. diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 31f2234640f..39396668da2 100644 --- a/gcc/doc/install.texi +++

Re: [PATCH] RISC-V: Use stdint-gcc.h in rvv testsuite

> > On Tue, Sep 26, 2023 at 10:59 AM Patrick O'Neill > > wrote: > >> stdint.h can be replaced with stdint-gcc.h to resolve some missing > >> system headers in non-multilib installations. > >> > >> Tested using glibc rv32gcv and rv64gcv on r14-4258-gc9837443075. > >> > >> gcc/ChangeLog: > >> > >>

[PATCH] Makefile.tpl: disable -Werror for feedback stage [PR111663]

From: Sergei Trofimovich Without the change profiled bootstrap fails for various warnings on master branch as: $ ../gcc/configure $ make profiledbootstrap ... gcc/genmodes.cc: In function ‘int main(int, char**)’: gcc/genmodes.cc:2152:1: error: ‘gcc/build/genmodes.gcda’

[PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

Hi All, I recently committed a patch that uses a nested std::pair in the second argument. It temporarily adds a second ranking variable for sorting and then later drops it. This hits the newly added assert in vec.h. This assert made some relaxation for std::pair but doesn't allow this case

Re: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

On Mon, Oct 02, 2023 at 01:38:53PM +0100, Tamar Christina wrote: > Hi All, > > I recently committed a patch that uses a nested std::pair in the second > argument. > It temporarily adds a second ranking variable for sorting and then later > drops it. > > This hits the newly added assert in

RE: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

> -Original Message- > From: Jakub Jelinek > Sent: Monday, October 2, 2023 2:21 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; jwak...@redhat.com > Subject: Re: [PATCH]middle-end: Recursively check > is_trivially_copyable_or_pair in vec.h > > On Mon, Oct 02, 2023 at

Re: [PATCH 1/5] OpenMP, NVPTX: memcpy[23]D bias correction

On Wed, 27 Sep 2023 00:57:58 +0200 Thomas Schwinge wrote: > On 2023-09-06T02:34:30-0700, Julian Brown > wrote: > > This patch works around behaviour of the 2D and 3D memcpy > > operations in the CUDA driver runtime. Particularly in Fortran, > > the "base pointer" of an array (used for either

Re: [PATCH] RFC: Add late-combine pass [PR106594]

Hi Richard, cool, thanks. I just gave it a try with my test cases and it does what it is supposed to do, at least if I disable the register pressure check :) A cursory look over the test suite showed no major regressions and just some overly specific tests. My test case only works before split,

[pushed] diagnostics: add diagnostic_output_format class

Eliminate various global variables in the json/sarif output code by bundling together callbacks and state into a new diagnostic_output_format class, with per-output-format subclasses. No functional change intended. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as

[pushed] diagnostics: group together source printing fields of diagnostic_context

struct diagnostic_context has > 60 fields. Try to tame some of the complexity by grouping together the 8 source-printing fields into a struct, the "m_source_printing" field. No functional change intended. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as

[pushed] diagnostics: fix missing init of set_locations_cb

Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r14-4366-gc64693fb885f21. gcc/ChangeLog: * diagnostic.cc (diagnostic_initialize): Initialize set_locations_cb to nullptr. --- gcc/diagnostic.cc | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [ARC PATCH] Use rlc r0, 0 to implement scc_ltu (i.e. carry_flag ? 1 : 0)

Hi Roger, Everything is good. Ok for mainline. Thank you for your contribution, Claudiu -Original Message- From: Claudiu Zissulescu Sent: Sunday, October 1, 2023 5:33 PM To: Jeff Law ; Roger Sayle Cc: gcc-patches@gcc.gnu.org Subject: RE: [ARC PATCH] Use rlc r0, 0 to implement scc_ltu