Re: [patch] Deal with #ident without

2012-06-07 Thread Andreas Schwab
Steven Bosscher stevenb@gmail.com writes: Index: doc/tm.texi === --- doc/tm.texi (revision 188182) +++ doc/tm.texi (working copy) @@ -5847,6 +5847,10 @@ value is 0. @end deftypevr @deftypefn {Target Hook}

Re: Go patch committed: Fix unsafe.Sizeof for named structs

2012-06-07 Thread Jakub Jelinek
On Wed, Jun 06, 2012 at 10:49:56PM -0700, Ian Lance Taylor wrote: This patch to the Go frontend fixes an embarrassing and serious bug in which unsafe.Sizeof returns the wrong value for a named struct that has fields that are themselves named structs. Bootstrapped and ran Go testsuite on

[google/gcc-4_6] Fix to use correct form for DW_AT_low_pc in compile_unit DIE. (issue6298055)

2012-06-07 Thread Cary Coutant
This patch is for the google/gcc-4_6 branch. In porting the earlier patch to use constant forms for DW_AT_high_pc, the code in dwarf2out_finish was inadvertently changed to use an indirect form for DW_AT_low_pc in the main compile_unit DIE. This patch adds the force_direct parameter used in

Re: Go patch committed: Fix unsafe.Sizeof for named structs

2012-06-07 Thread Ian Lance Taylor
Jakub Jelinek ja...@redhat.com writes: On Wed, Jun 06, 2012 at 10:49:56PM -0700, Ian Lance Taylor wrote: This patch to the Go frontend fixes an embarrassing and serious bug in which unsafe.Sizeof returns the wrong value for a named struct that has fields that are themselves named structs.

libgo patch RFA: Fix printing of names in stack dumps

2012-06-07 Thread Ian Lance Taylor
Go strings are not necessarily NUL terminated. The stack dump code was erroneously using %s to print the contents of a Go string. The runtime_printf function that it uses supports %S to print a Go string. This patch fixes the code to use %S. Without this a stack dump sometimes prints random

[google/main] New fdo summary-based icache sensitive unrolling (issue6282045)

2012-06-07 Thread Teresa Johnson
Updated patch based on feedback. Original description: This patch adds new program summary information to the gcov profile files that indicate how many profiled counts compose the majority of the program's execution time. This is used to provide an indication of the overall code size of the

[google/4_6] New fdo summary-based icache sensitive unrolling (issue6298056)

2012-06-07 Thread Teresa Johnson
This is the google/4_6 version of the patch to add new program summary information to the gcov profile files to use as a estimate of code size for guiding unrolling. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google/4_6? Thanks, Teresa Index: doc/invoke.texi

[committed] Fix OpenMP ICE with invalidly nested worksharing constructs (PR middle-end/53580)

2012-06-07 Thread Jakub Jelinek
Hi! omp-low.c isn't prepared to see invalidly nested worksharing etc., but diagnosed them just with a warning and let them go further. Fixed by making it an error (and nopping out the problematic constructs), bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. Backport

[PATCH] Fix ICE with asm goto and shrink wrapping (PR rtl-optimization/53589)

2012-06-07 Thread Jakub Jelinek
Hi! On the following testcase we ICE, because shrink-wrapping ends up calling force_nonfallthru_and_redirect on a BB that ends with asm goto that has some labels point to the fallthru block as well (i.e. asm goto (... : : : : lab); lab:;). The problem was that in that case the labels weren't

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-07 Thread davidxl
other than the update issue, good for google branch. David http://codereview.appspot.com/6282045/diff/4003/libgcc/libgcov.c File libgcc/libgcov.c (right): http://codereview.appspot.com/6282045/diff/4003/libgcc/libgcov.c#newcode1127 libgcc/libgcov.c:1127: cs_prg-num_hot_counters =

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-06-07 Thread Xinliang David Li
On Wed, Jun 6, 2012 at 10:58 PM, Sharad Singhai sing...@google.com wrote: Sorry about the delay. I have finally incorporated all the suggestions and reorganized the dump infrastructure a bit. The attached patch updates vectorizer passes so that instead of accessing global dump_file directly,

Go patch RFA: Fix taking the address of a field of a local variable

2012-06-07 Thread Ian Lance Taylor
This patch to the Go compiler fixes the case of taking the address of a field of a local variable. Previously taking the address of the field was not treated as taking the address of the variable. But, of course, it is. This patch fixes the problem. Bootstrapped and ran Go testsuite on

[Patch][ARM] Add arm-linux-gnueabihf triplet support.

2012-06-07 Thread Zhenqiang Chen
Hi, The patch adds arm-linux-gnueabihf triplet support. No regression for arm-linux-gnueabi tests. There are some differences between testsuite results on softfp Natty builders and the new hard float Precise builders. But none are due to the change in triplet. Thanks! -Zhenqiang

Re: [patch, fortran] Optimize assignment of empty strings

2012-06-07 Thread Tobias Burnus
Thomas Koenig wrote: his rather simple patch makes sure that only memset is used for assigning empty strings when front-end optimization is used. Regression-tested. OK for trunk? OK, thanks for the quick patch. Tobias 2012-06-06 Thomas König tkoe...@gcc.gnu.org PR fortran/52861

Re: [patch] Deal with #ident without

2012-06-07 Thread Richard Guenther
On Thu, Jun 7, 2012 at 8:16 AM, Andreas Schwab sch...@linux-m68k.org wrote: Steven Bosscher stevenb@gmail.com writes: Index: doc/tm.texi === --- doc/tm.texi       (revision 188182) +++ doc/tm.texi       (working copy) @@

Re: libgo patch RFA: Fix printing of names in stack dumps

2012-06-07 Thread Richard Guenther
On Thu, Jun 7, 2012 at 8:35 AM, Ian Lance Taylor i...@google.com wrote: Go strings are not necessarily NUL terminated.  The stack dump code was erroneously using %s to print the contents of a Go string.  The runtime_printf function that it uses supports %S to print a Go string. This patch

Re: [patch] Deal with #ident without

2012-06-07 Thread nick clifton
Hi Steven, This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT and IDENT_ASM_OP target macros, and replaces them with a single target hook. The RX parts of this patch are approved. Cheers Nick

Re: [patch] Deal with #ident without

2012-06-07 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 8:16 AM, Andreas Schwab sch...@linux-m68k.org wrote: Steven Bosscher stevenb@gmail.com writes: Index: doc/tm.texi === --- doc/tm.texi       (revision 188182) +++ doc/tm.texi       (working copy) @@

Re: divide 64-bit by constant for 32-bit target machines

2012-06-07 Thread Dinar Temirbulatov
Hi, Here is new version of patch based up on Paolo review, again tested on arm-7l, mips-32r2 (74k), i686 without new regressions. thanks, Dinar. On Sat, May 26, 2012 at 4:45 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 26/05/2012 14:35, Paolo Bonzini ha scritto:        

Re: [patch] Deal with #ident without

2012-06-07 Thread Andreas Schwab
Steven Bosscher stevenb@gmail.com writes: I am not sure what you mean with misplaced. A nested @deftypefn doesn't look right. Try make info. You need to add a @hook in tm.texi.in at the right place (output_ident has nothing to do with anchors). Andreas. -- Andreas Schwab,

[PATCH, i386]: Back port Fix PR 52908 - xop-mul-1:f9 miscompiled on bulldozer (-mxop) to 4.7

2012-06-07 Thread venkataramanan.kumar
Hi Maintainers, Please find the patch below that backports PR target/52908 to GCC 4.7. The patch passed bootstrap and regression test. Ok to commit? regards, Venkat. Index: ChangeLog === --- ChangeLog (revision 187449) +++

Re: [patch] Deal with #ident without

2012-06-07 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 12:42 PM, Andreas Schwab sch...@linux-m68k.org wrote: Steven Bosscher stevenb@gmail.com writes: I am not sure what you mean with misplaced. A nested @deftypefn doesn't look right.  Try make info.  You need to add a @hook in tm.texi.in at the right place

Re: [PATCH, i386]: Back port Fix PR 52908 - xop-mul-1:f9 miscompiled on bulldozer (-mxop) to 4.7

2012-06-07 Thread Jakub Jelinek
On Thu, Jun 07, 2012 at 06:07:18AM -0500, venkataramanan.ku...@amd.com wrote: Please find the patch below that backports PR target/52908 to GCC 4.7. The patch passed bootstrap and regression test. Ok to commit? Please wait with it until 4.7.1 is released. +2012-06-07 Venkataramanan

[PATCH] genhooks: always bail out if tm.texi lacks place for hook

2012-06-07 Thread Andreas Schwab
So that it doesn't happen again. Committed as obvious. Andreas. * genhooks.c (main): Set progname. (emit_documentation): Remove variable found_start, always bail out when a place is missing. * doc/tm.texi.in (C++ ABI): Add @hook

Re: [patch][gcc47] Deprecate -fconserve-space

2012-06-07 Thread Gerald Pfeifer
On Mon, 4 Jun 2012, Steven Bosscher wrote: How about this: Looks good to me. Do I understand correctly that this is a change in GCC 4.7.1 and later (but not GCC 4.7.0)? If that's the case, can you note this, for example by prepending [GCC 4.7.1 and later] to your snippet? Gerald

Re: divide 64-bit by constant for 32-bit target machines

2012-06-07 Thread Paolo Bonzini
Il 07/06/2012 12:21, Dinar Temirbulatov ha scritto: oh, I found typo in comment in the end of patch. fixed. Great improvement, thanks! Unfortunately we're not there yet, but much closer! I could understand the new code much better so I suggest some more improvements below, both to the comments

[patch, fortran,committed] Fix regression introduced by PR 52861 patch

2012-06-07 Thread Thomas Koenig
Hello world, my recent patch introduced a regression with deferred-length characters. I have committed the attached patch as obvious to fix this. Regards Thomas 2012-06-07 Thomas König tkoe...@gcc.gnu.org PR fortran/52861 * frontend-passes.c (optimize_assignment):

Re: [google/gcc-4_6] Fix to use correct form for DW_AT_low_pc in compile_unit DIE. (issue6298055)

2012-06-07 Thread Sterling Augustine
On Wed, Jun 6, 2012 at 11:23 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_6 branch. In porting the earlier patch to use constant forms for DW_AT_high_pc, the code in dwarf2out_finish was inadvertently changed to use an indirect form for DW_AT_low_pc in the

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-07 Thread Teresa Johnson
On Thu, Jun 7, 2012 at 12:05 AM, davi...@google.com wrote: other than the update issue, good for google branch. David http://codereview.appspot.com/6282045/diff/4003/libgcc/libgcov.c File libgcc/libgcov.c (right):

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-07 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 7:52 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Steven Bosscher stevenb@gmail.com writes: On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 06/06/2012 09:15, Steven Bosscher ha scritto: +    add_asm_printf (%s\n\t.ascii \%s\\n, +  

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-07 Thread Richard Sandiford
Steven Bosscher stevenb@gmail.com writes: On Thu, Jun 7, 2012 at 7:52 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Steven Bosscher stevenb@gmail.com writes: On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 06/06/2012 09:15, Steven Bosscher ha scritto:

Re: [wwwdocs] Buildstat update for 4.6

2012-06-07 Thread Gerald Pfeifer
On Sun, 3 Jun 2012, Tom G. Christensen wrote: Latest results for 4.6.x -tgc Testresults for 4.6.3: i386-pc-solaris2.8 i386-pc-solaris2.10 x86_64-unknown-linux-gnu Thanks, Tom! Online now. Gerald

[lra] patch fixing spec2000 mesa code generation failure

2012-06-07 Thread Vladimir Makarov
The following patch mostly fixes spec2000 mesa code generation failure on x86 triggered by committing hard reg splitting patch. The patch was successfully bootstrapped on x86-64. Committed as rev. 188316. 2012-06-07 Vladimir Makarov vmaka...@redhat.com * lra-constraints.c

[PATCH, libgcc]: Put soft-FP exception handler out-of-line for x86

2012-06-07 Thread Uros Bizjak
Hello! Attached patch rewrites x86 soft-FP as an out-of-line function that gets conditionally called when exception occurs. This rewrite removes 17 instances of the same code from libgcc. In addition, the patch unifies a lot of code between 32bit and 64bit x86 target, and also introduces SSE

Re: [PATCH][1/n][C] Do not sign-extend sizetypes

2012-06-07 Thread H.J. Lu
On Mon, Apr 11, 2011 at 7:25 AM, Richard Guenther rguent...@suse.de wrote: This is another try at making sizetype behavior more consistent with other integral types.  In particular this series will eventually succeed in making TYPE_UNSIGNED tell the truth for sizetypes ... This first patch

C++ PATCH for c++/53599 (ICE with local class in template)

2012-06-07 Thread Jason Merrill
The problem here was that when we instantiate G::bar, we want to instantiate F, and end up improperly pushing the declaration inside G, which leads to the ICE. Adjusting the call to pushclass is enough to fix this, which is what I propose doing for the 4.7 branch. For 4.8 I'm going to do

[google-4_6] indirect_call promotion for streaming LIPO (issue6306054)

2012-06-07 Thread Rong Xu
Hi, This patch is for google-4_6 branch only. It implements the multi-target indirect-call promotion as a regular IPA passes. I took a shortcut by opening and modifying the IR in IPA execute stage. The early version pushes the candidates to obstack and makes cgraph_node clones , and performs

Committed: xfail gcc.dg/pr46647.c for cris-* and crisv32-*

2012-06-07 Thread Hans-Peter Nilsson
See the PR. Note well, there is no effect on the emitted assembly code; the failure is in this pass but fixed in another. Thus it does not pass the work/benefit threshold for adding a separate test-case from the code in the PR, just for xfailing this one; and for every xfail there should be a PR.

Re: [Dwarf Patch] Improve pubnames and pubtypes generation. (issue 6197069)

2012-06-07 Thread saugustine
On 2012/06/01 17:58:41, saugustine wrote: The enclosed patch updates the earlier patch to address all of the feedback I have gotten regarding generating pubnames. It fixes the offset problem in the pubtypes table; switches DW_AT_pubtypes to a flag and so on. It also adds and documents a

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread davidxl
http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: Why not putting this into value-prof.h? http://codereview.appspot.com/6306054/diff/1/ipa-split.c File ipa-split.c (right):

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread xur
will send the new patch set in a few minutes. http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: They are referenced in lto-cgraph.c etc. On 2012/06/07 21:46:53, davidxl wrote: Why not

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread Rong Xu
On Thu, Jun 7, 2012 at 3:22 PM, x...@google.com wrote: will send the new patch set in a few minutes. http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: They are referenced in

[google-4_6] indirect_call promotion for streaming LIPO (patchset 2) (issue6306054)

2012-06-07 Thread Rong Xu
Hi, This patch is for google-4_6 branch only. Patch Set 2. Tested is undergoing. 2012-06-07 Rong Xu x...@google.com * lto-symtab.c (lto_cgraph_replace_node): indirect-call promotion support in streaming LIPO. (Entry_BB_profile_count): Ditto.

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread davidxl
ok for google branches -- LTO specific bugs should be isolated and submitted upstream. David http://codereview.appspot.com/6306054/diff/5001/value-prof.c File value-prof.c (right): http://codereview.appspot.com/6306054/diff/5001/value-prof.c#newcode1720 value-prof.c:1720: direct_call2 = 0; Ok

[RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-07 Thread Hans-Peter Nilsson
(CC to ARM maintainer approving the original patch.) I'm listing this under caveats rather than improvements and before the current top ARM-related caveat (as this one is more important :) because I don't see performance figures in the context of the original patch (r178852) backing up this as an

Ping: [RFA:] fix bug in configure header-probing for stack protector support in target C library

2012-06-07 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Fri, 1 Jun 2012 01:38:22 +0200 gcc: Fix configure test for stack protector support in target C library. * configure.ac (test_prefix, test_exec_prefix): Move setting from inside sysroot handling to before and outside it. *

Ping*2: [RFA:] doc: TARGET_LEGITIMIZE_ADDRESS needs to be defined for native TLS

2012-06-07 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Wed, 16 May 2012 02:24:02 +0200 gcc: * doc/tm.texi.in (Addressing Modes) TARGET_LEGITIMIZE_ADDRESS: Mention that this hook needs to be defined for native TLS. * doc/tm.texi: Regenerate.

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-07 Thread Michael Hope
On 8 June 2012 12:15, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: (CC to ARM maintainer approving the original patch.) I'm listing this under caveats rather than improvements and before the current top ARM-related caveat (as this one is more important :) because I don't see

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-07 Thread Hans-Peter Nilsson
From: Michael Hope michael.h...@linaro.org Date: Fri, 8 Jun 2012 04:42:30 +0200 On 8 June 2012 12:15, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: The some source codes was in the analyzed case a strcpy of a five-byte string (busybox/libbb/procps.c:365 'strcpy(filename_tail,

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-07 Thread Michael Hope
On 8 June 2012 15:20, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: From: Michael Hope michael.h...@linaro.org Date: Fri, 8 Jun 2012 04:42:30 +0200 On 8 June 2012 12:15, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: The some source codes was in the analyzed case a strcpy of

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-07 Thread Hans-Peter Nilsson
From: Michael Hope michael.h...@linaro.org Date: Fri, 8 Jun 2012 05:50:52 +0200 On 8 June 2012 15:20, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: So the default for ALIGNMENT_TRAP changed in 3.1? ALIGNMENT_TRAP is on by default but the early boot time trap is now conditional on

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-07 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Fri, 8 Jun 2012 06:29:04 +0200 From: Michael Hope michael.h...@linaro.org Date: Fri, 8 Jun 2012 05:50:52 +0200 The combination of older Linux ARM kernels and GCC 4.7 gives a faulty kernel. We're in agreement! Oh wait sorry, my bad, I