Re: Move statements upwards after reassociation

2012-10-11 Thread Xinliang David Li
On Wed, Oct 10, 2012 at 6:52 PM, Easwaran Raman era...@google.com wrote: Hi, In the expression reassociation pass, statements might get moved downwards to ensure that dependences are not violated after reassociation. This can increase the live range and, in a tight loop, result in spills.

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-11 Thread Bin Cheng
Hi Jeff, Steven, This is the updated patch according to your comments. The main changes includes: 1. Enable the option for all target at Os level by default. 2. Add a target independent test case. 3. Add comments on how the algorithm works. 4. Simplify the calculation of register pressure info by

[PATCH, testsuite]: Tweak obj-c++ TLS errors

2012-10-11 Thread Uros Bizjak
Hello! Recent commit changed various c++ TLS errors. Following patch tweaks obj-c++ testcase accordingly. 2012-10-11 Uros Bizjak ubiz...@gmail.com * obj-c++.dg/tls/init-2.mm: Tweak errors. Tested on alphaev68-pc-linux-gnu, committed to mainline SVN. Uros. Index:

Re: [C++] Omit overflow check for new char[n]

2012-10-11 Thread Dodji Seketeli
Florian Weimer fwei...@redhat.com a écrit: On 10/10/2012 06:02 PM, Dodji Seketeli wrote: I just have one question for own education. Regarding: @@ -2450,7 +2450,13 @@ if (array_p TYPE_VEC_NEW_USES_COOKIE (elt_type)) size = size_binop (PLUS_EXPR, size, cookie_size);

Re: [v3] Fix Solaris symbol versioning (PR libstdc++/54872)

2012-10-11 Thread Rainer Orth
Jonathan Wakely jwakely@gmail.com writes: 2012-10-10  Rainer Orth  r...@cebitec.uni-bielefeld.de         PR libstdc++/54872         * config/abi/pre/gnu.ver (GLIBCXX_3.4.11) [!__sun__ !__svr4__]:         Don't export _ZNSt12system_errorC*. OK, thanks, and sorry for causing the

Re: libbacktrace patch committed: Trace through shared libraries

2012-10-11 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: On Wed, Oct 10, 2012 at 7:13 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Solaris 10 Update 10 or sufficiently recent linker patches introduced dl_iterate_phdr on S10 as a backport from Solaris 11, but unlike S11, it lives in libdl.so only.

[doc] Vector operations

2012-10-11 Thread Marc Glisse
Hello, this documents both my latest C++ FE patch, something I noticed while doing the FE work (shifts can mix vectors and scalars) and the result of the conversation with Richard B on how the middle-end should model vector truth values. The patch is a little early compared to the code

Fix PR testsuite/54867

2012-10-11 Thread Eric Botcazou
The new scan-rtl-dump-not I recently added needs to be tweaked so as to cater to x86-64 platforms like Solaris where the prologue isn't elided. Tested on x86_64-suse-linux, applied on the mainline as obvious. 2012-10-11 Eric Botcazou ebotca...@adacore.com PR testsuite/54867

[C++ testcase] PR 43765

2012-10-11 Thread Paolo Carlini
Hi, I'm committing the testcase and closing the PR as fixed in mainline. Thanks, Paolo. /// 2012-10-11 Paolo Carlini paolo.carl...@oracle.com PR c++/43765 * g++.dg/parse/pr43765.C: New. Index: g++.dg/parse/pr43765.C

Re: [c-family] Small tweak to -fdump-ada-spec

2012-10-11 Thread Eric Botcazou
2012-10-09 Eric Botcazou ebotca...@adacore.com * c-ada-spec.c (dump_ada_template): Bail out for template declarations declaring something coming from another file. That's a small patch affecting only -fdump-ada-spec so I went ahead and installed it on the mainline. -- Eric

Committed, PR54897 (was: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2))

2012-10-11 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Thu, 11 Oct 2012 02:13:32 +0200 There's now an excess error: x/libstdc++-v3/testsuite/23_containers/bitset/45713.cc:24:55: error: size of array 'test' is not an integral constant-expression int test[sizeof(std::bitset0x) != 1 ? 1 :

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-11 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: On Fri, Oct 5, 2012 at 4:21 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: I think this should work. The only complication might be that users of DEFAULT_PROCESS_FILENAME need to include stdlib.h on Solaris to get the declaration of

[PATCH, i386]: Use SSE insns to generate soft-fp exceptions for 64bit targets only

2012-10-11 Thread Uros Bizjak
Hello! For 32bit targets, there is no guarantee that mxcsr register will be set up correctly w.r.t. unmasked FP exceptions, so don't use SSE instructions to generate INVALID and DIVZERO FP exceptions. 2012-10-10 Uros Bizjak ubiz...@gmail.com * config/i386/sfp-exceptions.c

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-11 Thread Gerald Pfeifer
On Thu, 11 Oct 2012, Rainer Orth wrote: Ok, here's the merged patch, tested on i386-pc-solaris2.10. Ok for mainline? Cool, thank you! Just a small note, in the following +#ifdef __FreeBSD__ +# define DEFAULT_PROCESS_FILENAME /proc/curproc/file +#elif defined(HAVE_GETEXECNAME) +#

[testsuite] PR 54868

2012-10-11 Thread Marc Glisse
Hello, understanding the testsuite is hard, but this patch seems to work. The idea is that vect_double and others don't tell that vectors are supported with these options, just that there exist options that enable vectors. They are thus useless outside of a directory like vect/ that adds

[v3] std::common_type testsuite tweaks

2012-10-11 Thread Paolo Carlini
Hi contributed by Daniel. Tested again and committed. Paolo. /// 2012-10-11 Daniel Krugler daniel.krueg...@googlemail.com * testsuite/20_util/common_type/requirements/sfinae_friendly_1.cc: Update / extend. *

Re: vec_cond_expr adjustments

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 1:20 AM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 8 Oct 2012, Richard Guenther wrote: On Mon, Oct 8, 2012 at 11:34 AM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 8 Oct 2012, Richard Guenther wrote: VEC_COND_EXPR is more complicated. We could for instance

Re: [patch] Fix PR bootstrap/54820

2012-10-11 Thread Eric Botcazou
2012-10-09 Eric Botcazou ebotca...@adacore.com PR bootstrap/54820 * Makefile.tpl (STAGE1_FLAGS_TO_PASS): New variable. (host_modules): Add STAGE1_FLAGS_TO_PASS to args. * Makefile.in: Regenerate. * configure.ac (have_static_libs): New variable and

Re: [Patch, ARM, testsuite]

2012-10-11 Thread Christophe Lyon
Hi Richard, On 21 September 2012 10:49, Richard Earnshaw rearn...@arm.com wrote: On 21/09/12 09:47, Matthew Gretton-Dann wrote: On 20 September 2012 23:06, Christophe Lyon christophe.l...@linaro.org wrote: Hi, GCC for ARM does not support compiling in Thumb1 mode and float-abi=hard. But

Re: Use conditional casting with symtab_node

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 7:31 AM, Xinliang David Li davi...@google.com wrote: On Fri, Oct 5, 2012 at 1:49 AM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Oct 4, 2012 at 8:16 PM, Diego Novillo dnovi...@google.com wrote: On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Olivier Hainque
Hello, The change apparently broke targets that have their gthr- header not in libgcc/ directly, quite a few. We are seeing failure on ppc-aix for example, which has ./libgcc/config/rs6000/gthr-aix.h We are also seeing failures while building a win32 canadian from linux, where we have

Re: Move statements upwards after reassociation

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 3:52 AM, Easwaran Raman era...@google.com wrote: Hi, In the expression reassociation pass, statements might get moved downwards to ensure that dependences are not violated after reassociation. This can increase the live range and, in a tight loop, result in spills.

Re: [testsuite] PR 54868

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 2:19 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, understanding the testsuite is hard, but this patch seems to work. The idea is that vect_double and others don't tell that vectors are supported with these options, just that there exist options that enable

Re: [testsuite] PR 54868

2012-10-11 Thread Marc Glisse
On Thu, 11 Oct 2012, Richard Biener wrote: On Thu, Oct 11, 2012 at 2:19 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, understanding the testsuite is hard, but this patch seems to work. The idea is that vect_double and others don't tell that vectors are supported with these options, just

Re: [PATCH] Fold REDUC_*_EXPR

2012-10-11 Thread Richard Biener
On Wed, Oct 10, 2012 at 7:49 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! This patch folds REDUC_*_EXPR (e.g. on pr54877.c -Ofast -mavx testcase we end up with unfolded REDUC_PLUS_EXPR till *.optimized). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Eh, I didn't

[asan] Rename tree-asan.[ch] to asan.[ch]

2012-10-11 Thread Diego Novillo
As discussed earlier, this patch renames tree-asan.[ch] to asan.[ch]. Tested on x86_64. Committed to branch. Diego. * asan.c: Rename from tree-asan.c. Update all users. * asan.h: Rename from tree-asan.h Update all users.

Re: Silecne array bounds warnings in duplicated code

2012-10-11 Thread Richard Biener
On Thu, 11 Oct 2012, Jan Hubicka wrote: Hi, this patch address problem I run into with strenghtened cunroll pass. I made cunroll to use loop_max_iterations bounds into an account that makes us to occasionally produce out of bounds loop accesses in loop like: for (i=0;in;i++) {

Re: [PATCH] Fold REDUC_*_EXPR

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 3:47 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 11, 2012 at 03:42:44PM +0200, Richard Biener wrote: On Wed, Oct 10, 2012 at 7:49 PM, Jakub Jelinek ja...@redhat.com wrote: This patch folds REDUC_*_EXPR (e.g. on pr54877.c -Ofast -mavx testcase we end up with

[asan] Target hook for shadow memory offset

2012-10-11 Thread Jakub Jelinek
Hi! As the shadow memory offset ored into shifted addresses is clearly target specific (1 29 on i?86, 1LL 44 on x86_64, 0 on ARM?, no support on other target so far), it should be IMHO a target hook. Ok for asan? 2012-10-11 Jakub Jelinek ja...@redhat.com * toplev.c

Re: [PATCH] Fold REDUC_*_EXPR

2012-10-11 Thread Jakub Jelinek
On Thu, Oct 11, 2012 at 04:30:42PM +0200, Richard Biener wrote: The comment wants to say that, but doesn't do it correctly: Operand 0 is a vector; the first element in the vector has the result. Operand 1 is a vector. */ because obviously it doesn't have two operands, just one. So

Re: [doc] Vector operations

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 11:25 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, this documents both my latest C++ FE patch, something I noticed while doing the FE work (shifts can mix vectors and scalars) and the result of the conversation with Richard B on how the middle-end should model

Re: [PATCH] Fold REDUC_*_EXPR

2012-10-11 Thread Richard Biener
On Thu, Oct 11, 2012 at 4:33 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 11, 2012 at 04:30:42PM +0200, Richard Biener wrote: The comment wants to say that, but doesn't do it correctly: Operand 0 is a vector; the first element in the vector has the result. Operand 1 is a

[C++ testcase] PR 36107

2012-10-11 Thread Paolo Carlini
Hi, testcase added to testsuite, PR closed as fixed. Thanks, Paolo. / 2012-10-11 Paolo Carlini paolo.carl...@oracle.com PR c++/36107 * g++.dg/ext/weak5.C: New. Index: g++.dg/ext/weak5.C ===

Re: [asan] Target hook for shadow memory offset

2012-10-11 Thread H.J. Lu
On Thu, Oct 11, 2012 at 7:32 AM, Jakub Jelinek ja...@redhat.com wrote: Hi! As the shadow memory offset ored into shifted addresses is clearly target specific (1 29 on i?86, 1LL 44 on x86_64, 0 on ARM?, no support on other target so far), it should be IMHO a target hook. Ok for asan?

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread David Edelsohn
AIX bootstrap is broken after this change. This patch also should not have been approved for GCC 4.7 branch without wider testing on trunk. Would you please revert this patch while you figure out how to provide the previous libstdc++ build behavior? Thanks, David

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Pavel Chupin
Could you try this fix? -- Pavel Chupin Intel Corporation Fix-missing-gthr-aix.h.patch Description: Binary data

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Rainer Orth
Pavel Chupin pavel.v.chu...@gmail.com writes: Could you try this fix? Duplicating this much info from libgcc is certainly the wrong (read: unmaintainable) approach. Rainer -- - Rainer Orth, Center for

Re: [PATCH 0/6] Thread pointer built-in functions

2012-10-11 Thread Chung-Lin Tang
This patch set has been committed, thanks to all maintainers who reviewed the respective parts. Thanks, Chung-Lin Full ChangeLog: 2012-10-11 Chung-Lin Tang clt...@codesourcery.com * builtins.c (expand_builtin_thread_pointer): New. (expand_builtin_set_thread_pointer): New.

Small configure.ac PATCH for aix configury

2012-10-11 Thread Jason Merrill
The check for .ref support on AIX used the wrong syntax, leading to broken output from autoconf. Tested by configuring a cross-compiler, applying to trunk as obvious. commit 885339b51d3221bcceabeaf9b2e5f39664ad947d Author: Jason Merrill ja...@redhat.com Date: Thu Oct 11 09:01:49 2012 -0400

Re: Move statements upwards after reassociation

2012-10-11 Thread Xinliang David Li
On Thu, Oct 11, 2012 at 6:16 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, Oct 11, 2012 at 3:52 AM, Easwaran Raman era...@google.com wrote: Hi, In the expression reassociation pass, statements might get moved downwards to ensure that dependences are not violated after

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-11 Thread Jason Merrill
On 10/09/2012 11:27 AM, Jason Merrill wrote: FAIL: g++.dg/tls/thread_local7.C scan-assembler-not \\.data I've changed this test to require native TLS. FAIL: g++.dg/tls/static-1.C * And I've fixed the compiler to not mess with thread_local wrappers on this test, since it uses __thread.

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-11 Thread Jason Merrill
OK, I've checked this in: commit 2425dc8daa33d8b5d15c803c9bf2f51f5e1915a0 Author: Jason Merrill ja...@redhat.com Date: Tue Oct 9 21:16:52 2012 -0400 * g++.dg/ext/visibility/pragma-override1.C: Fix target markup. * g++.dg/ext/visibility/pragma-override2.C: Fix target markup. diff

Re: PING Re: [PATCH, MIPS] add new peephole for 74k dspr2

2012-10-11 Thread Maciej W. Rozycki
On Wed, 10 Oct 2012, Richard Sandiford wrote: I've thought of -miterative-mdu or suchlike a knob that would override the default cost of multiplication/division as appropriate (i.e. to 32/64 plus any extra operation-specific constant as required), perhaps by forcing the 4Kp insn

C++ PATCH to limit DECL_THUNKS to virtual functions

2012-10-11 Thread Jason Merrill
The two current users of this field are DECL_FRIEND_CONTEXT for friend functions and DECL_THUNKS for virtual member functions; I would like to use it for another purpose for constructors, so I'm changing DECL_THUNKS to return null for non-virtual functions. Tested x86_64-pc-linux-gnu,

Re: [Patch, Fortran, OOP] PR 54784: [4.7/4.8 Regression] wrong code in polymorphic allocation with SOURCE

2012-10-11 Thread Janus Weil
Hi Mikael, here is a small patch for a wrong-code regression with polymorphic allocation. The problem is that we falsely detect the allocation variable to be a polymorphic array (although it is a scalar). For further details see the PR, in particular comment 4. Regtested on

[lra] patch to fix GCC crash on a SPEC2006 test

2012-10-11 Thread Vladimir Makarov
The following patch fixes scheduler crash on a SPEC2006 test because LRA did not process CALL_INSN_FUNCTION_USAGE. The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 192362. 2012-10-11 Vladimir Makarov vmaka...@redhat.com * lra-spills.c

Re: [asan] Target hook for shadow memory offset

2012-10-11 Thread Diego Novillo
On 2012-10-11 10:32 , Jakub Jelinek wrote: 2012-10-11 Jakub Jelinek ja...@redhat.com * toplev.c (process_options): Warn and turn off -fasan if not supported by target. * asan.c: Include target.h. (asan_scale, asan_offset_log_32, asan_offset_log_64,

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jack Howarth
On Thu, Oct 11, 2012 at 12:18:59AM +0100, Jonathan Wakely wrote: On 11 October 2012 00:09, Jonathan Wakely wrote: On 9 October 2012 18:49, Benjamin De Kosnik wrote: I don't like the sched_yield macro being set there because it's detected correctly by configure anyway, but I'm not going to

Make try_unroll_loop_completely to use loop bounds recorded

2012-10-11 Thread Jan Hubicka
Hi, while looking into RTL loop peeling micopmilation I found that we now do a lot of RTL loop peeling for loops of the form int a[2]; test(int c) { int i; for (i=0;ic;i++) a[i]=5; } this is because tree-ssa-loop-niter is able to prove that the loop iterates at most twice. This is

[asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Jakub Jelinek
Hi! Building trees, then gimplifying it, is unnecessarily expensive. This patch changes build_check_stmt to emit GIMPLE directly, and a couple of small cleanups here and there. Also, I'm using a different alias set for the shadow memory accesses, those obviously can't alias any other accesses.

Re: libbacktrace patch committed: Trace through shared libraries

2012-10-11 Thread Ian Lance Taylor
On Thu, Oct 11, 2012 at 1:44 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Ian Lance Taylor i...@google.com writes: On Wed, Oct 10, 2012 at 7:13 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Solaris 10 Update 10 or sufficiently recent linker patches introduced dl_iterate_phdr

Re: [PATCH, i386]: AMD bdver3 enablement

2012-10-11 Thread Uros Bizjak
On Thu, Oct 11, 2012 at 9:19 AM, Gopalasubramanian, Ganesh ganesh.gopalasubraman...@amd.com wrote: The attached patch (Patch.txt) enables the next version of AMD's bulldozer core. Please handle new sseshuf type attribute in various attribute calculations. You should at least add it to unit

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Diego Novillo
On 2012-10-11 12:38 , Jakub Jelinek wrote: - gimple_seq seq, stmts; - tree shadow_type = size_in_bytes == 16 ? - short_integer_type_node : char_type_node; - tree shadow_ptr_type = build_pointer_type (shadow_type); - tree uintptr_type = lang_hooks.types.type_for_mode (ptr_mode, -

Re: [PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-11 Thread Alexandre Oliva
On Oct 4, 2012, Jakub Jelinek ja...@redhat.com wrote: Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? This is ok, except for one nit. 2012-10-04 Jakub Jelinek ja...@redhat.com PR debug/54796 * rtl.h: Document jump flag on VALUE. * cselib.h

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Jakub Jelinek
On Thu, Oct 11, 2012 at 01:14:31PM -0400, Diego Novillo wrote: On 2012-10-11 12:38 , Jakub Jelinek wrote: - gimple_seq seq, stmts; - tree shadow_type = size_in_bytes == 16 ? - short_integer_type_node : char_type_node; - tree shadow_ptr_type = build_pointer_type (shadow_type); -

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Xinliang David Li
On Thu, Oct 11, 2012 at 9:38 AM, Jakub Jelinek ja...@redhat.com wrote: Hi! Building trees, then gimplifying it, is unnecessarily expensive. This patch changes build_check_stmt to emit GIMPLE directly, and a couple of small cleanups here and there. Also, I'm using a different alias set for

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jonathan Wakely
On 11 October 2012 17:05, Jack Howarth wrote: Jonathan, The committed patch results in the expected this_thread::yield() and this_thread::sleep_for() support. I did run into a regression at -m32/-m64 on darwin10 (but not darwin11/12). WARNING: program timed out. FAIL:

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Wei Mi
Hi Diego, /* Build - (base_addr ASAN_SHADOW_SHIFT) | targetm.asan_shadow_offset (). */ + (base_addr ASAN_SHADOW_SHIFT) + targetm.asan_shadow_offset (). */ Hm, I wonder if this is a documentation problem or we're generating bad runtime code. Wei, you tested the runtime and

Re: [RFA] Support common C++ declarations inside GTY'd structures

2012-10-11 Thread Laurynas Biveinis
Tested on x86_64. OK for trunk? Looks OK, with some very minor comments and questions below. static void -consume_until_semi (bool immediate) +consume_until_eos (void) { - if (immediate token () != ';') -require (';'); for (;;) switch (token ()) { case

Re: [Patch, Fortran, OOP] PR 54784: [4.7/4.8 Regression] wrong code in polymorphic allocation with SOURCE

2012-10-11 Thread Janus Weil
here is a small patch for a wrong-code regression with polymorphic allocation. The problem is that we falsely detect the allocation variable to be a polymorphic array (although it is a scalar). For further details see the PR, in particular comment 4. Regtested on x86_64-unknown-linux-gnu. Ok

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jack Howarth
On Thu, Oct 11, 2012 at 06:46:47PM +0100, Jonathan Wakely wrote: On 11 October 2012 17:05, Jack Howarth wrote: Jonathan, The committed patch results in the expected this_thread::yield() and this_thread::sleep_for() support. I did run into a regression at -m32/-m64 on darwin10 (but

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Dominique Dhumieres
Jack, That's PR 54407, so not a regression. ... The pthreads support is definitely improved in darwin11 and later. Do you confirm that 30_threads/condition_variable/54185.cc is passing on darwin11 and 12? If yes, I'll test a patch to skip it on darwin10 and older. Dominique

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Jakub Jelinek
On Thu, Oct 11, 2012 at 10:31:58AM -0700, Xinliang David Li wrote: +#define PROB_VERY_UNLIKELY (REG_BR_PROB_BASE / 2000 - 1) +#define PROB_ALWAYS(REG_BR_PROB_BASE) + Does it belong here ? -- looks like they can be generally useful for others. Perhaps, but then it would

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Pavel Chupin
How about this patch? 2012/10/11 Rainer Orth r...@cebitec.uni-bielefeld.de: Pavel Chupin pavel.v.chu...@gmail.com writes: Could you try this fix? Duplicating this much info from libgcc is certainly the wrong (read: unmaintainable) approach. Rainer --

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Xinliang David Li
On Thu, Oct 11, 2012 at 11:12 AM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 11, 2012 at 10:31:58AM -0700, Xinliang David Li wrote: +#define PROB_VERY_UNLIKELY (REG_BR_PROB_BASE / 2000 - 1) +#define PROB_ALWAYS(REG_BR_PROB_BASE) + Does it belong here ? -- looks

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jack Howarth
On Thu, Oct 11, 2012 at 08:11:48PM +0200, Dominique Dhumieres wrote: Jack, That's PR 54407, so not a regression. ... The pthreads support is definitely improved in darwin11 and later. Do you confirm that 30_threads/condition_variable/54185.cc is passing on darwin11 and 12? If yes,

[patch][IRA] Really record loop exits

2012-10-11 Thread Steven Bosscher
Hello, IRA uses record_loop_exits() to cache the loop exit edges, but due to a code ordering bug the edges are not actually recorded. record_loop_exits() starts with: if (!current_loops) return; So ira.c should set current_loops before calling record_loop_exits. With the current order,

[google] Move delete with size to its own file (issue6655052)

2012-10-11 Thread Easwaran Raman
This patch moves the two argument delete operator into its own file. When a program provides its own definition of operator delete (void *), but not operator delete (void *, size_t), we could end up linking two files that define _ZdlPv resulting in a linker error. Bootstraps with no test

Re: Use conditional casting with symtab_node

2012-10-11 Thread Lawrence Crowl
On 10/10/12, Xinliang David Li davi...@google.com wrote: In a different thread, I proposed the following alternative to 'try_xxx': templatetypename T T* symbol::cast_to(symbol* p) { if (p-isT()) return static_castT*(p); return 0; } cast: templatetypename T T

Re: Move statements upwards after reassociation

2012-10-11 Thread Steven Bosscher
On Thu, Oct 11, 2012 at 3:16 PM, Richard Biener richard.guent...@gmail.com wrote: NB, the whole reassoc code needs a re-write to avoid the excessive stmt modifications when it does nothing. So I'd very much rather avoid adding anything to reassoc until that rewrite happened. IMHO it's fair to

Re: Use conditional casting with symtab_node

2012-10-11 Thread Xinliang David Li
On Thu, Oct 11, 2012 at 1:23 PM, Lawrence Crowl cr...@googlers.com wrote: On 10/10/12, Xinliang David Li davi...@google.com wrote: In a different thread, I proposed the following alternative to 'try_xxx': templatetypename T T* symbol::cast_to(symbol* p) { if (p-isT()) return

Re: [google] Move delete with size to its own file (issue6655052)

2012-10-11 Thread Xinliang David Li
ok. thanks, David On Thu, Oct 11, 2012 at 1:21 PM, Easwaran Raman era...@google.com wrote: This patch moves the two argument delete operator into its own file. When a program provides its own definition of operator delete (void *), but not operator delete (void *, size_t), we could end up

[PATCH, alpha]: Trivial alpha.md macroizations, part 2

2012-10-11 Thread Uros Bizjak
Hello! 2012-10-11 Uros Bizjak ubiz...@gmail.com * config/alpha/alpha.md (IMODE): New mode iterator. (I124MODE): Ditto. (I248MODE): Ditto. (modesuffix): Handle QI and HI modes. (zero_extendqimode2): Macroize insn from zero_extendqi{hi,si,di}2

PR/54893: allow volatiles inside relaxed transactions

2012-10-11 Thread Aldy Hernandez
Apparently we were a bit too aggressive on disallowing volatiles inside transactions. Torvald seems to agree that volatiles should be allowed inside relaxed transactions, since they will go into serial irrevocable mode anyhow. The following patch fixes the PR. I did not include a test that

Re: [Patch, Fortran] Fix OPTIONAL, esp. with polymorphism

2012-10-11 Thread Janus Weil
Hi Tobias, gfortran supports OPTIONAL since quite some time - also some more complicated cases involving ELEMENTAL or the new F2008 addition, but as testing showed, the support is still incomplete; especially with polymorphic arguments there were several bugs. Besides a simple absent

Re: PR/54893: allow volatiles inside relaxed transactions

2012-10-11 Thread Richard Henderson
On 10/11/2012 01:56 PM, Aldy Hernandez wrote: PR middle-end/54893 * trans-mem.c (diagnose_tm_1_op): Allow volatiles inside relaxed transactions. Ok. r~

Re: [Patch, Fortran] PR 40453: Enhanced (recursive) argument checking

2012-10-11 Thread Janus Weil
ping! 2012/10/7 Janus Weil ja...@gcc.gnu.org: Hi all, here is a rather straightforward patch, which does 'recursive' checking of dummy procedures. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? Cheers, Janus 2012-10-06 Janus Weil ja...@gcc.gnu.org PR fortran/40453

[PATCH] Reduce conservativeness in REE using machine model (issue6631066)

2012-10-11 Thread Teresa Johnson
Revised patch to address conservative behavior in redundant extend elimination that was resulting in redundant extends not being removed. Now uses a new target hook machine_mode_from_attr_mode which is currently enabled only for i386. Bootstrapped and tested on x86_64-unknown-linux-gnu. Is this

[Patch, Fortran, OOP] PR 54881: [4.8 Regression] [OOP] ICE in fold_convert_loc, at fold-const.c:2016

2012-10-11 Thread Janus Weil
Hi all, here is an OOP patch for the above PR, which has two disconnected parts: 1) It fixes a problem with ASSOCIATED, when it is fed a CLASS-valued function as argument (i.e. the ICE in the bug title). This is the trans-intrinsic part of the patch. Instead of adding the _data component to the

Re: [PATCH] Reduce conservativeness in REE using machine model (issue6631066)

2012-10-11 Thread Steven Bosscher
On Thu, Oct 11, 2012 at 11:44 PM, Teresa Johnson wrote: + mode = targetm.machine_mode_from_attr_mode(insn); Nit: space between ..._mode and (. A test case would also be Nice To Have. Looks OK to me otherwise, but I can't approve it. Ciao! Steven

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-11 Thread Peter Bergner
On Tue, 2012-10-02 at 10:57 -0400, Vladimir Makarov wrote: Chaitin-Briggs literature does not discuss the termination, just saying that live-ranges shortening will result to assigning hard regs to all necessary pseudos which is not clearly guaranteed. There is the same problem in LRA. So

[SH] PR 51244 - Improve T bit store and cbranch

2012-10-11 Thread Oleg Endo
Hello, This one further improves T bit stores and conditional branches on SH for cases like described in comment #53 in the PR. Tested on rev 192200 with make -k check RUNTESTFLAGS=--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} and no new failures. Cheers,

Re: Move statements upwards after reassociation

2012-10-11 Thread Ian Lance Taylor
On Thu, Oct 11, 2012 at 1:25 PM, Steven Bosscher stevenb@gmail.com wrote: On Thu, Oct 11, 2012 at 3:16 PM, Richard Biener richard.guent...@gmail.com wrote: NB, the whole reassoc code needs a re-write to avoid the excessive stmt modifications when it does nothing. So I'd very much rather

Re: Move statements upwards after reassociation

2012-10-11 Thread Steven Bosscher
On Fri, Oct 12, 2012 at 12:00 AM, Ian Lance Taylor wrote: On Thu, Oct 11, 2012 at 1:25 PM, Steven Bosscher wrote: On Thu, Oct 11, 2012 at 3:16 PM, Richard Biener wrote: NB, the whole reassoc code needs a re-write to avoid the excessive stmt modifications when it does nothing. So I'd very much

[C++] PR53055

2012-10-11 Thread Marc Glisse
Hello, this is an old patch that Paolo dug out of bugzilla and where I only changed the error message. It fixes an ICE on invalid code. Note that the code uses error() like the nearby code so the caret appears on the RHS while the message is about the LHS. Paolo offered to look into it as a

[v3] Remove hack for 53067 in mainline

2012-10-11 Thread Paolo Carlini
Hi, not necessary anymore thanks to the resolution of c++/51213. Tested x86_64-linux multilib, committed. Thanks, Paolo. /// 2012-10-12 Paolo Carlini paolo.carl...@oracle.com * include/bits/hashtable_policy.h: Revert libstdc++/53067 quick hacks thanks

VEC_COND_EXPR

2012-10-11 Thread Marc Glisse
Hello, this patch brings VEC_COND_EXPR closer to what the doc now says. The non-comparison case and gimplification are dead paths currently, but it seems convenient to introduce them now. Note that by using the generic ternary gimplification code, it will produce VEC_COND_EXPR with an

Re: [PATCH 0/6] Thread pointer built-in functions / [SH] PR 54760

2012-10-11 Thread Oleg Endo
On Thu, 2012-10-11 at 23:11 +0800, Chung-Lin Tang wrote: This patch set has been committed, thanks to all maintainers who reviewed the respective parts. Thanks, Chung-Lin This broke the recently added thread pointer built-ins on SH, but I was prepared for that, so no problem here. The

Re: [lra] patch to fix GCC crash on a SPEC2006 test

2012-10-11 Thread Peter Bergner
On Thu, 2012-10-11 at 11:35 -0400, Vladimir Makarov wrote: + /* Call insn might have not references for pseudos besides +in CALL_INSN_FUNCTION_USAGE but we don't count them in +insn_bitmap of corresponding lra_reg_info as they don't +need reloads.

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-11 Thread Steven Bosscher
On Thu, Oct 11, 2012 at 8:50 AM, Bin Cheng wrote: + /* x+y won't be hoisted without defaultly enabled -fira-hoist-pressure, defaulty comment. + kinds of code motion(including code hoisting) in a unified way. needs space between motion and (. + flow graph, given if it can reach BB

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Wei Mi
Hi, Here is the initial test results of gcc asan patch, and it shows us some missing features in gcc but existing in llvm. [1]. gcc regression test for gcc-asan passes. [2]. llvm regression tests for gcc-asan: 18 failures in 123 for tests written in google test and 24 failures in 28 for tests

Re: [Patch, Fortran] PR 40453: Enhanced (recursive) argument checking

2012-10-11 Thread Thomas Koenig
Hi Janus, ping! 2012/10/7 Janus Weil ja...@gcc.gnu.org: Hi all, here is a rather straightforward patch, which does 'recursive' checking of dummy procedures. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? This is OK. Thanks for the patch! Thomas

[RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-11 Thread Hans-Peter Nilsson
The md.texi entry for nonlocal_goto_receiver says A typical reason why you might need this pattern is if some value, such as a pointer to a global table, must be restored when the frame pointer is restored. Note that a nonlocal goto only occurs within a unit-of-translation, so a global table

[C++ testcase] PR 51878

2012-10-11 Thread Paolo Carlini
Hi, testcase committed, closed as fixed in 4.8.0. Thanks, Paolo. // 2012-10-11 Paolo Carlini paolo.carl...@oracle.com PR c++/51878 * g++.dg/cpp0x/decltype45.C: New. Index: g++.dg/cpp0x/decltype45.C

Re: [SH] PR 51244 - Improve T bit store and cbranch

2012-10-11 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: This one further improves T bit stores and conditional branches on SH for cases like described in comment #53 in the PR. Tested on rev 192200 with make -k check RUNTESTFLAGS=--target_board=sh-sim

Re: [PATCH 0/6] Thread pointer built-in functions / [SH] PR 54760

2012-10-11 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: Anyway, regardless of this failure, the attached patch for SH should be applicable. OK? OK. Regards, kaz

Re: Move statements upwards after reassociation

2012-10-11 Thread Easwaran Raman
Thanks for the comments. As David wrote, the intent of the patch is not to do a general purpose scheduling, but to compensate for the possible live range lengthening introduced by reassociation. On Thu, Oct 11, 2012 at 6:16 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, Oct 11,

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-11 Thread Bin Cheng
-Original Message- From: Steven Bosscher [mailto:stevenb@gmail.com] Sent: Friday, October 12, 2012 7:04 AM To: Bin Cheng Cc: Jeff Law; gcc-patches@gcc.gnu.org Subject: Re: [PATCH RFA] Implement register pressure directed hoist pass On Thu, Oct 11, 2012 at 8:50 AM, Bin Cheng

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-11 Thread Vladimir Makarov
On 12-10-11 5:53 PM, Peter Bergner wrote: On Tue, 2012-10-02 at 10:57 -0400, Vladimir Makarov wrote: Chaitin-Briggs literature does not discuss the termination, just saying that live-ranges shortening will result to assigning hard regs to all necessary pseudos which is not clearly guaranteed.

[lra] patch from Richard Sandiford's review of lra-assigns.c

2012-10-11 Thread Vladimir Makarov
The following patch implements most Richard's proposals for LRA lra-spills.c and lra-coalesce.c files. The patch was successfully bootstrapped on x86/x86-64. Committed as rev. 192389. 2012-10-11 Vladimir Makarov vmaka...@redhat.com * target.def (register_priority): Change value

  1   2   >