Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-26 Thread Florian Weimer
On 08/25/2013 09:33 PM, Gerald Pfeifer wrote: On Tue, 20 Aug 2013, Florian Weimer wrote: As the libvtv reviewer, you don't need permission to commit your changes. :-) Actually, reviewers do need someone else's approval for their own changes (unlike maintainers and of course not for trivial

Re: Fix OBJ_TYPE_REF handling in ipa-cp

2013-08-26 Thread Martin Jambor
Hi, On Thu, Aug 22, 2013 at 05:33:50PM +0200, Jan Hubicka wrote: Hi, this problem was noticed by my verifier that binfo walks are not across type hiearchy. ipa_intraprocedural_devirtualization is one remaining place where we take class of object from OBJ_TYPE_REF_OBJECT instead of

Re: [PATCH 0/2] Port symtab/cgraph/varpool nodes to use C++ inheritance

2013-08-26 Thread David Malcolm
On Tue, 2013-08-20 at 23:01 +0200, Jan Hubicka wrote: [...] In summary, struct GTY(()) symtab_node_base becomes: class GTY((user)) symtab_node_base and the subclasses: struct GTY(()) cgraph_node and: struct GTY(()) varpool_node become (respectively): struct

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-26 Thread Caroline Tice
Thank you for pointing out my error. I will commit the following patch. -- Caroline Tice cmt...@google.com 2013-08-26 Caroline Tice cmt...@google.com * MAINTAINERS: Correct earliers update: Move myself from libvtv Various Reviewers to libvtv Various Maintainers. Index: MAINTAINERS

Re: ELF interposition and One Definition Rule

2013-08-26 Thread Mike Stump
On Aug 26, 2013, at 8:21 AM, Jan Hubicka hubi...@ucw.cz wrote: My understanding of C++ One Definition Rule, in a strict sense, does not a allow in to define two functions of the same name and different semantics in a valid program . I also think that all DSOs eventually linked together or

Re: [GOOGLE] Update AutoFDO annotation

2013-08-26 Thread Xinliang David Li
Can you add missing documentation on functions like ...:get_count_info -- documenting return value etc. Also it might be better to avoid using 'set' as the local variable name. Change it to something more specific. thanks, David On Thu, Aug 22, 2013 at 3:56 PM, Dehao Chen de...@google.com

Re: ELF interposition and One Definition Rule

2013-08-26 Thread Jason Merrill
On 08/26/2013 11:21 AM, Jan Hubicka wrote: Our default behaviour special case inline functions that are always AVAIL_AVAILABLE and, via decl_replaceable_p, also any COMDAT (that may be for functions since all COMDATs are also inlines, but makes difference for variables I think). Not all COMDAT

Re: [C++ Patch] Remove old bison hack?!

2013-08-26 Thread Jason Merrill
OK. Jason

Re: Make some comdats implicitly hidden

2013-08-26 Thread Jason Merrill
On 08/26/2013 03:57 PM, Jan Hubicka wrote: While analyzing the relocations of libreoffice I noticed that I can play the same game w/o LTO at linker level. Making those symbols hidden truns external relocations to internal and should improve runtime, too: comdat sharing by dynamic linker is

Re: ELF interposition and One Definition Rule

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 7:58 PM, Jason Merrill ja...@redhat.com wrote: On 08/26/2013 11:21 AM, Jan Hubicka wrote: Our default behaviour special case inline functions that are always AVAIL_AVAILABLE and, via decl_replaceable_p, also any COMDAT (that may be for functions since all COMDATs are

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Jason Merrill
On 08/26/2013 10:45 AM, Gabriel Dos Reis wrote: Hmm, let's not make it a default. Replacing global operator new (e.g. for tracing purposes) is a valid C++ programming idiom. Absolutely. What strikes me as vanishingly unlikely is the idea that the replacement operator new would expose

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 8:17 PM, Jason Merrill ja...@redhat.com wrote: On 08/26/2013 10:45 AM, Gabriel Dos Reis wrote: Hmm, let's not make it a default. Replacing global operator new (e.g. for tracing purposes) is a valid C++ programming idiom. Absolutely. What strikes me as vanishingly

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Jason Merrill
On 08/22/2013 09:19 AM, Jan Hubicka wrote: - I tried to track functions that lead to terminate() and not mark them as ECF_LEAF. This is because user can set handler. If the handler can resonably expect the static vars defined in its unit to be in the final form, we can not

[patch/djgpp]: Add ASM_DECLARE_FUNCTION_NAME

2013-08-26 Thread DJ Delorie
Needed to build i586-pc-msdosdjgpp target, committed. * config/i386/djgpp.h (ASM_DECLARE_FUNCTION_NAME): New. Index: config/i386/djgpp.h === --- config/i386/djgpp.h (revision 202015) +++ config/i386/djgpp.h (working copy)

Re: [PATCH, libgcc] Fix licenses on several files

2013-08-26 Thread Maxim Kuvyrkov
On 29/07/2013, at 10:03 AM, Maxim Kuvyrkov wrote: While verifying license compliance for GCC and its libraries I noticed that several libgcc files that end up in the final library are licensed under GPL-3.0+ instead of GPL-3.0-with-GCC-exception. This is, obviously, was not the intention

RE: [ping**4] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-08-26 Thread Bernd Edlinger
PING! This issue is really important. It does not only affect bitfields but all kinds of packed structures. Starting from gcc 4.6.0 there is not a single released version that handles the packed structures correctly. So could some one please approve Sandra's patch now? Thanks Bernd.

Re: powerpc64le multilibs and multiarch dir

2013-08-26 Thread Alan Modra
On Sun, Aug 25, 2013 at 10:40:30PM -0700, Mike Stump wrote: On Aug 25, 2013, at 8:32 PM, Alan Modra amo...@gmail.com wrote: We (IBM) don't intend to support running both big and little-endian processes on the same system in the near future. Perhaps I'm jumping the gun in defining the

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Mike Stump
On Aug 23, 2013, at 9:36 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: You made a statement. It was not clear whether it was what you want or whether it is what the standards mandate. Both. (2) what you believe the standards mandate, with appropriate quote; and The life of

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 2:44 AM, Mike Stump mikest...@comcast.net wrote: but I fear you won't understand this and how it applies. You must be right. I cannot match the entertaining value of your message, so you win. -- Gaby

Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
Same topic as patch 17/n. For more expressing printers. Tested on an x86_64-suse-linux. Applied to mainline. -- Gaby 2013-08-26 Gabriel Dos Reis g...@integrable-solutions.net c-family/ * c-pretty-print.h (c_pretty_printer::unary_expression): Now a virtual member function.

[PATCH, i386]: Remove unneeded ATTRIBUTE_UNUSED decorations

2013-08-26 Thread Uros Bizjak
Hello! 2013-08-26 Uros Bizjak ubiz...@gmail.com * config/i386/i386.c (ix86_debug_options): Remove prototype. (x86_64_elf_select_section): Ditto. (ix86_handle_tm_regparm_attribute): Remove ATTRIBUTE_UNUSED on used arguments. (ix86_pass_by_reference): Ditto.

Re: [PATCH, i386]: Remove unneeded ATTRIBUTE_UNUSED decorations

2013-08-26 Thread Jakub Jelinek
On Mon, Aug 26, 2013 at 11:04:42AM +0200, Uros Bizjak wrote: static bool -ix86_return_in_memory (const_tree type, const_tree fntype ATTRIBUTE_UNUSED) +ix86_return_in_memory (const_tree type, const_tree fntype) { #ifdef SUBTARGET_RETURN_IN_MEMORY return SUBTARGET_RETURN_IN_MEMORY (type,

Re: [PATCH, i386]: Remove unneeded ATTRIBUTE_UNUSED decorations

2013-08-26 Thread Uros Bizjak
On Mon, Aug 26, 2013 at 11:13 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Aug 26, 2013 at 11:04:42AM +0200, Uros Bizjak wrote: static bool -ix86_return_in_memory (const_tree type, const_tree fntype ATTRIBUTE_UNUSED) +ix86_return_in_memory (const_tree type, const_tree fntype) {

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
Paolo Carlini paolo.carl...@oracle.com writes: | Hi Gaby. | | On 08/26/2013 10:42 AM, Gabriel Dos Reis wrote: | Same topic as patch 17/n. For more expressing printers. | Tested on an x86_64-suse-linux. Applied to mainline. | Just got this: | |

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
Paolo Carlini paolo.carl...@oracle.com writes: | Hi Gaby, | | bootstrap is currently broken: | | /scratch/Gcc/svn-dirs/trunk/gcc/c/c-objc-common.c: In function ‘bool | c_tree_printer(pretty_printer*, text_info*, const char*, int, bool, | bool, bool)’: |

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Paolo Carlini
On 08/26/2013 11:20 AM, Gabriel Dos Reis wrote: You need more than that. The rest of patch is in trunk now. Sorry for the breakage -- as you probably guessed, I specified only c-family directory on the commit command line. Thanks! Paolo.

[c++-concepts] MErge from trunk

2013-08-26 Thread Gabriel Dos Reis
at revision 201992. There were conflicts with the recent pretty printing patches. Fixed. (Mostly due to the new concept-specific nodes printing.) Modulo the asan stuff. -- Gaby

Re: [PATCH] Create pass through and ancestor jump functions even there is dynamic type change

2013-08-26 Thread Jan Hubicka
2013-08-23 Martin Jambor mjam...@suse.cz * ipa-prop.h (ipa_pass_through_data): New field type_preserved. (ipa_ancestor_jf_data): Likewise. (ipa_get_jf_pass_through_agg_preserved): Fix comment typo. (ipa_get_jf_pass_through_type_preserved): New function.

[ubsan] Introduce pointer_sized_int_node

2013-08-26 Thread Marek Polacek
I noticed I forgot to apply this old patch, already acked by Jason. It introduces new pointer_sized_int_node, thus we can get rid of uptr_type function in ubsan, and it allows us to do some clean-up in asan.c, too. Tested x86_64-linux, applying to ubsan branch. 2013-08-26 Marek Polacek

Committed: fix i686 bootstrap: x86_64_elf_select_section is unused

2013-08-26 Thread Joern Rennecke
bootstrap for i686-pc-linux-gnu was failing with: /ssd/fsf/boot-201992/./prev-gcc/xg++ -B/ssd/fsf/boot-201992/./prev-gcc/ -B/usr/local/i686-pc-linux-gnu/bin/ -nostdinc++ -B/ssd/fsf/boot-201992/prev-i686-pc-linux-gnu/libstdc++-v3/src/.libs

Re: [Patch, Fortran, OOP] PR 57305: ICE when calling SIZEOF on an unlimited polymorphic variable

2013-08-26 Thread Janus Weil
Hi Mikael, the SIZEOF intrinsic currently returns the size according to the *declared* type for polymorphic variables. I think this doesn't really make much sense and it also causes ICEs when SIZEOF is called on CLASS(*) variables (which don't really have a declared type). Therefore I'm

Fix some issues with speculative devirtualization machinery

2013-08-26 Thread Jan Hubicka
Hi, by making speculative indirect call machinery to be used by ipa-devirt I put it on wild on firefox converting about 30% of all polymorphic calls in the progrma (3). This has provoked some issues I missed previously this patch fixes: 1) dumping - we no longer do only indirect calls from

RFA: fix avr gcc.dg/fixed-point/convert-accum-neg.c execution failure

2013-08-26 Thread Joern Rennecke
The gcc.dg/fixed-point/convert-accum-neg.c execution test fails for avr because for fractional integer to accumulator / integer conversions, the avr target rounds towards -infinity, whereas we are supposed to round towards 0. The attached patch implements rounding towards 0, and adds an option

Re: [PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

2013-08-26 Thread Alexander Ivchenko
Hi, I've added references to fxsr, xsave and xsaveopt options and builtins to doc/[invoke,extend].texi. Is it OK? diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 29a30ee..3aad294 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2013-08-23 Alexander Ivchenko

wide-int branch updated

2013-08-26 Thread Kenneth Zadeck
fixed fits_uhwi_p. tested on x86-64. kenny Index: gcc/wide-int.h === --- gcc/wide-int.h (revision 201985) +++ gcc/wide-int.h (working copy) @@ -1650,7 +1650,7 @@ wide_int_ro::fits_shwi_p () const inline bool

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Jan Hubicka
Hi, it seems to be couple weeks I am not able to compile big ltrans unit with -fdump-tree-all because the compiler eventually runs out of memory. I think it is one of your patches introducing serious memory leak. Can you, please, take a look on this? It makes my life harder - it is not fun to

Re: [Patch, Fortran, OOP] PR 57305: ICE when calling SIZEOF on an unlimited polymorphic variable

2013-08-26 Thread Mikael Morin
Le 26/08/2013 13:22, Janus Weil a écrit : Hi Mikael, the SIZEOF intrinsic currently returns the size according to the *declared* type for polymorphic variables. I think this doesn't really make much sense and it also causes ICEs when SIZEOF is called on CLASS(*) variables (which don't

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 7:24 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, it seems to be couple weeks I am not able to compile big ltrans unit with -fdump-tree-all because the compiler eventually runs out of memory. I think it is one of your patches introducing serious memory leak. Can you,

Re: [ping**4] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-08-26 Thread Sandra Loosemore
On 08/26/2013 01:16 AM, Bernd Edlinger wrote: PING! This issue is really important. It does not only affect bitfields but all kinds of packed structures. Starting from gcc 4.6.0 there is not a single released version that handles the packed structures correctly. So could some one please

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Jan Hubicka
On Mon, Aug 26, 2013 at 7:24 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, it seems to be couple weeks I am not able to compile big ltrans unit with -fdump-tree-all because the compiler eventually runs out of memory. I think it is one of your patches introducing serious memory leak.

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Jason Merrill
On 08/22/2013 12:45 PM, Gabriel Dos Reis wrote: If the user-supplied operator new returns a, then it must also ensure that 'a' is not used anywhere else -- e.g. I you can't do lvalue-to-value conversion on 'a' to see what is written there. Because its storage has been reused. That is, aliasing

Re: [PATCH, i386, MPX 1/X] Support of Intel MPX ISA

2013-08-26 Thread Ilya Enkovich
Ping 2013/8/19 Ilya Enkovich enkovich@gmail.com: Ping 2013/8/12 Ilya Enkovich enkovich@gmail.com: 2013/8/10 Joseph S. Myers jos...@codesourcery.com: On Mon, 29 Jul 2013, Ilya Enkovich wrote: Hi, Here is updated version of the patch. I removed redundant mode_for_bound, added

Re: [Patch, Fortran, OOP] PR 57305: ICE when calling SIZEOF on an unlimited polymorphic variable

2013-08-26 Thread Janus Weil
I'm slightly inclined to kindly invite the user to switch to STORAGE_SIZE+SIZE instead. Any other opinion? Since the SIZEOF intrinsic has been around for some time in gfortran (before STORAGE_SIZE was available), I would say we should at least continue to support it for backward

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 9:00 AM, Jan Hubicka hubi...@ucw.cz wrote: On Mon, Aug 26, 2013 at 7:24 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, it seems to be couple weeks I am not able to compile big ltrans unit with -fdump-tree-all because the compiler eventually runs out of memory. I think

Re: Add overload for register_pass

2013-08-26 Thread Richard Henderson
On 08/24/2013 02:33 PM, Oleg Endo wrote: gcc/ChangeLog: * passes.c (register_pass): Add overload. * tree-pass.h (register_pass): Forward declare it. Add comment. Ok. r~

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Jan Hubicka
On Mon, Aug 26, 2013 at 9:00 AM, Jan Hubicka hubi...@ucw.cz wrote: On Mon, Aug 26, 2013 at 7:24 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, it seems to be couple weeks I am not able to compile big ltrans unit with -fdump-tree-all because the compiler eventually runs out of memory. I

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Jan Hubicka
On 08/22/2013 12:45 PM, Gabriel Dos Reis wrote: If the user-supplied operator new returns a, then it must also ensure that 'a' is not used anywhere else -- e.g. I you can't do lvalue-to-value conversion on 'a' to see what is written there. Because its storage has been reused. That is,

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 9:38 AM, Jan Hubicka hubi...@ucw.cz wrote: On 08/22/2013 12:45 PM, Gabriel Dos Reis wrote: If the user-supplied operator new returns a, then it must also ensure that 'a' is not used anywhere else -- e.g. I you can't do lvalue-to-value conversion on 'a' to see what is

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 9:32 AM, Jan Hubicka hubi...@ucw.cz wrote: On Mon, Aug 26, 2013 at 9:00 AM, Jan Hubicka hubi...@ucw.cz wrote: On Mon, Aug 26, 2013 at 7:24 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, it seems to be couple weeks I am not able to compile big ltrans unit with

Re: [C++ patch] Set attributes for C++ runtime library calls

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 9:07 AM, Jason Merrill ja...@redhat.com wrote: On 08/22/2013 12:45 PM, Gabriel Dos Reis wrote: If the user-supplied operator new returns a, then it must also ensure that 'a' is not used anywhere else -- e.g. I you can't do lvalue-to-value conversion on 'a' to see what

RFA: fix some avr stdint issues

2013-08-26 Thread Joern Rennecke
This patch fixes the gcc.dg/c99-stdint-5.c and gcc.dg/c99-stdint-6.c excess error failures. Tested for atmega128-sim. OK to apply? 2013-05-26 Joern Rennecke joern.renne...@embecosm.com * config/avr/avr-stdint.h (INT16_TYPE): Change default to int. (UINT16_TYPE): Change

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Gabriel Dos Reis
On Mon, Aug 26, 2013 at 9:32 AM, Jan Hubicka hubi...@ucw.cz wrote: modify ALL_LINKERFLAGS or BUILD_LINKERFLAGS? configure --with-build-config=bootstrap-lto . You need plugin enabled buinutils for that. I think there however should be a lot easier way to reproduce it by just dropping some

Re: RFA: fix find_valid_class to accept classes w/out last hard reg

2013-08-26 Thread Ulrich Weigand
Joern Rennecke wrote: 2013-05-02 Joern Rennecke joern.renne...@embecosm.com * reload.c (find_valid_class): Allow classes that do not include FIRST_PSEUDO_REGISTER - 1. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain

ELF interposition and One Definition Rule

2013-08-26 Thread Jan Hubicka
Hi, cgraph_function_body_availability determine if body of a given function is available in current compilation unit and if so, if it may be overwritten by completely different semantic by (dynamic)linker. Function that is AVAIL_AVAILABLE can still be repleaced by a function fron different unit,

Re: Clean up pretty printers [18/n]

2013-08-26 Thread Jan Hubicka
On Mon, Aug 26, 2013 at 9:32 AM, Jan Hubicka hubi...@ucw.cz wrote: modify ALL_LINKERFLAGS or BUILD_LINKERFLAGS? configure --with-build-config=bootstrap-lto . You need plugin enabled buinutils for that. I think there however should be a lot easier way to reproduce it by just

Fix edge redirection in ipa-inline-transform

2013-08-26 Thread Jan Hubicka
Hi, this patch fixes bug that triggers an ICE when building firefox; cgraph_redirect_edge_call_stmt_to_callee can now remove an edge it is given and thus inline_transform must keep track of next pointer. Bootstrapped/regtested ppc64-linux, commited. Index: ChangeLog

Fix ICE with -fdump-ipa-cp

2013-08-26 Thread Jan Hubicka
Hi, this patch fixes fallout of my patch to remove DECL_ARGUMENT from WPA stage. Fixed thus. Regtested/bootstrapped x86_64-linux, comitted. Honza Index: ChangeLog === --- ChangeLog (revision 201997) +++ ChangeLog (working

Fix cgraph_redirect_edge_call_stmt_to_callee

2013-08-26 Thread Jan Hubicka
Hi, this patch fixes interesting problem in cgraph_redirect_edge_call_stmt_to_callee. Before expanding the speculative call we do type checking ensuring that type of callee is compatible with a call. This fails when ipa-cp decides to redirect the call and change function signature, because the

Minor gimple_get_virt_method_for_binfo tweek

2013-08-26 Thread Jan Hubicka
Hi, any time we look for constructor of a given readonly static var, we should use ctor_for_folding that knows about interposition rules and knows how to walk aliases. gimple_get_virt_method_for_binfo is hopefully last place I forgot to update. Bootstrapped/regtested ppc64-linux, committed.

C++ constructors/destructors can not have address taken.

2013-08-26 Thread Jan Hubicka
Hi, this patch tesch comdat_can_be_unshared_p_1 about the fact that C++ constructors and destructors can not have address taken that can be used for equivalence comparsion. This mean that we can privatize them into the DSO. Bootstrapped/regtested x86_64-linux, comitted. * ipa.c

Do not turn virtual methods cold based on absence of direct calls

2013-08-26 Thread Jan Hubicka
Hi, on firefox we turn some virtual methods cold just because we think that if they are not called directly and not having address taken, we won't need them. Unless we track call targets of polymorphic calls better, we should not try to touch them until after inlining (when those will just

RFA: prefer double over same-size float as conversion result

2013-08-26 Thread Joern Rennecke
This fixes the following avr failures: FAIL: gcc.dg/Wdouble-promotion.c (test for warnings, line 45) FAIL: gcc.dg/Wdouble-promotion.c (test for warnings, line 52) FAIL: gcc.dg/Wdouble-promotion.c (test for warnings, line 53) FAIL: gcc.dg/Wdouble-promotion.c (test for warnings, line 56) FAIL:

Re: [PATCH v3 12/18] convert the Go front end to automatic dependencies

2013-08-26 Thread Tom Tromey
Ian == Ian Lance Taylor i...@google.com writes: Ian I assume that dropping $(OUTPUT_OPTION) is correct--I haven't looked Ian at the new definition of $(COMPILE). I believe the depcomp script takes care of this. Tom

Re: [Ping^4] [Patch, AArch64, ILP32] 3/5 Minor change in function.c:assign_parm_find_data_types()

2013-08-26 Thread Richard Henderson
On 08/15/2013 11:21 AM, Yufeng Zhang wrote: Ping^4~ I am aware that it is currently holiday season, but it would be really nice if this tiny patch can get some further comments even if it is not an approval. The original RFA email is here:

Re: RFA: prefer double over same-size float as conversion result

2013-08-26 Thread Richard Henderson
On 08/26/2013 09:07 AM, Joern Rennecke wrote: 2013-05-14 Joern Rennecke joern.renne...@embecosm.com * c-typeck.c (c_common_type): Prefer double_type_node over other REAL_TYPE types with the same precision. (convert_arguments): Likewise. Ok. r~

Re: [PATCH i386 2/8] [AVX512] Add mask registers.

2013-08-26 Thread Kirill Yukhin
On 22 Aug 08:49, Richard Henderson wrote: Hello, You can always split away the clobber after reload, as we do for when add gets implemented with lea. I've refactored the patch, making mask logic insn patterns non-unspec. Unfortunately I was unable to use '*' in mask alternative, since it is

RFA: Consider int and same-size short as equivalent vector components

2013-08-26 Thread Joern Rennecke
avr currently shows the following failure: FAIL: c-c++-common/vector-scalar.c -Wc++-compat (test for excess errors) Excess errors: /home/amylaar/atmel/4.8/unisrc-mainline/gcc/testsuite/c-c++-common/vector-scalar .c:9:34: error: invalid operands to binary | (have '__vector(8) int' and 'veci')

Re: RFA: fix some avr stdint issues

2013-08-26 Thread Denis Chertykov
2013/8/26 Joern Rennecke joern.renne...@embecosm.com: This patch fixes the gcc.dg/c99-stdint-5.c and gcc.dg/c99-stdint-6.c excess error failures. Tested for atmega128-sim. OK to apply? 2013-05-26 Joern Rennecke joern.renne...@embecosm.com * config/avr/avr-stdint.h

Re: RFA: prefer double over same-size float as conversion result

2013-08-26 Thread Joseph S. Myers
In convert_arguments I think you should be comparing TYPE_MAIN_VARIANT (valtype) against double_type_node and long_double_type_node, rather than just valtype. This is PR c/35649 (so include that number in your ChangeLog entry and close that bug as fixed). -- Joseph S. Myers

Re: [PATCH i386 2/8] [AVX512] Add mask registers.

2013-08-26 Thread Richard Henderson
On 08/26/2013 09:13 AM, Kirill Yukhin wrote: +(define_split + [(set (match_operand:SWI12 0 mask_reg_operand) + (any_logic:SWI12 (match_operand:SWI12 1 mask_reg_operand) + (match_operand:SWI12 2 mask_reg_operand))) + (clobber (reg:CC FLAGS_REG))] + TARGET_AVX512F

Re: RFA: fix avr gcc.dg/fixed-point/convert-accum-neg.c execution failure

2013-08-26 Thread Denis Chertykov
2013/8/26 Joern Rennecke joern.renne...@embecosm.com: The gcc.dg/fixed-point/convert-accum-neg.c execution test fails for avr because for fractional integer to accumulator / integer conversions, the avr target rounds towards -infinity, whereas we are supposed to round towards 0. The attached

Re: [PATCH] libitm: Add custom HTM fast path for RTM on x86_64.

2013-08-26 Thread Richard Henderson
On 08/22/2013 02:57 PM, Torvald Riegel wrote: On Thu, 2013-08-22 at 12:05 -0700, Richard Henderson wrote: On 08/22/2013 11:39 AM, Torvald Riegel wrote: + /* Store edi for future HTM fast path retries. We use a stack slot + lower than the jmpbuf so that the jmpbuf's rip field will

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-08-26 Thread Richard Henderson
+static tree +c_check_cilk_loop_incr (location_t loc, tree decl, tree incr) +{ + if (EXPR_HAS_LOCATION (incr)) +loc = EXPR_LOCATION (incr); + + if (!incr) +{ + error_at (loc, missing increment); + return error_mark_node; +} Either these tests are swapped, or the

[wide-int] Add missing ()

2013-08-26 Thread Mike Stump
[wide-int] Add missing () diff --git a/gcc/genmodes.c b/gcc/genmodes.c index a27993a..946dcc9 100644 --- a/gcc/genmodes.c +++ b/gcc/genmodes.c @@ -874,14 +874,14 @@ emit_max_int (void) max = i-bytesize; if (max mmax) mmax = max; - printf (#define MAX_BITSIZE_MODE_ANY_INT

Re: [RFA] Type inheritance graph analysis speculative devirtualization, part 4/7, ODR at LTO time

2013-08-26 Thread Martin Jambor
Hi, On Mon, Aug 19, 2013 at 04:01:16PM +0200, Jan Hubicka wrote: [...] * Makefile.in (ipa-devirt.o): Add dependency on diagnostic.h * ipa-devirt.c: Include diganostic.h (odr_type_d): Add types and types_set. (hash_type_name): Work for types with vtables during LTO.

Re: [RFA] Type inheritance graph analysis speculative devirtualization, part 4/7, ODR at LTO time

2013-08-26 Thread Jan Hubicka
Hi, On Mon, Aug 19, 2013 at 04:01:16PM +0200, Jan Hubicka wrote: [...] * Makefile.in (ipa-devirt.o): Add dependency on diagnostic.h * ipa-devirt.c: Include diganostic.h (odr_type_d): Add types and types_set. (hash_type_name): Work for types with vtables during

Re: v2 of GDB hooks for debugging GCC

2013-08-26 Thread David Malcolm
On Wed, 2013-08-21 at 15:01 -0600, Tom Tromey wrote: David == David Malcolm dmalc...@redhat.com writes: [...] David How would one go about toggling the enabledness of a prettyprinter? Is David this something that can only be done from python? You can use enable pretty-printer and disable

v3 of GDB hooks for debugging GCC

2013-08-26 Thread David Malcolm
On Wed, 2013-08-21 at 15:01 -0600, Tom Tromey wrote: David == David Malcolm dmalc...@redhat.com writes: Tom Naughty. David We chatted about this at Cauldron; I haven't yet had a chance to David implement the magic bullet approach we discussed there. In the David meantime, is there a API

Re: GDB hooks for debugging GCC

2013-08-26 Thread David Malcolm
On Mon, 2013-08-19 at 13:56 -0600, Jeff Law wrote: On 08/02/2013 07:48 PM, David Malcolm wrote: GDB 7.0 onwards supports hooks written in Python to improve the quality-of-life within the debugger. The best known are the pretty-printing hooks [1], which we already use within libstdc++ for

Re: RFA: Consider int and same-size short as equivalent vector components

2013-08-26 Thread Marc Glisse
On Mon, 26 Aug 2013, Joern Rennecke wrote: avr currently shows the following failure: FAIL: c-c++-common/vector-scalar.c -Wc++-compat (test for excess errors) Excess errors: /home/amylaar/atmel/4.8/unisrc-mainline/gcc/testsuite/c-c++-common/vector-scalar .c:9:34: error: invalid operands to

Re: RFA: Consider int and same-size short as equivalent vector components

2013-08-26 Thread Joern Rennecke
Quoting Marc Glisse marc.gli...@inria.fr: The issue seems larger than just short/int. On x86, (ll)l fails to compile for a vector of long, with ll that has opaque type vector of int, that seems wrong. I don't understand what you mean here. Could you post the actual code sample?

Re: RFA: Consider int and same-size short as equivalent vector components

2013-08-26 Thread Marc Glisse
On Mon, 26 Aug 2013, Joern Rennecke wrote: Quoting Marc Glisse marc.gli...@inria.fr: The issue seems larger than just short/int. On x86, (ll)l fails to compile for a vector of long, with ll that has opaque type vector of int, that seems wrong. I don't understand what you mean here. Could

Make some comdats implicitly hidden

2013-08-26 Thread Jan Hubicka
Hi, for -flto (and for -fhwhole-program as well) I for a while privatize comdat symbols based on fact that I know their address can not be compared for equivality (virtuals/ctors/dtors and functions with no address taken). While analyzing the relocations of libreoffice I noticed that I can play

[C++ Patch] Remove old bison hack?!

2013-08-26 Thread Paolo Carlini
Hi, a few days ago I noticed this comment and code. Removing it passes testing on x86_64-linux (I would in any case also boot and test multilib before committing). Admittedly, a bit risky, but Stage 1 seems the right time to try. Thanks! Paolo. 2013-08-26 Paolo