[Patch ARM/testsuite] Mark pr48329.f90 as unsupported on AArch32

2014-05-13 Thread Ramana Radhakrishnan
The AArch32 SIMD unit doesn't have vector floating point divide. Handled thusly. I've chosen to inherit vector floating point divide support from target_vect_float. If this doesn't work for all targets, they can choose to override it here otherwise. Tested cross with the testcase on

Re: [PATCH, MIPS] Fix a couple of target tests for microMIPS

2014-05-13 Thread Richard Sandiford
Moore, Catherine catherine_mo...@mentor.com writes: 2014-05-12 Catherine Moore c...@codesourcery.com gcc/testsuite/ * gcc.target/mips/near-far-1.c: Adjust expected output to allow the JALS instruction. * gcc.target/mips/near-far-2.c: Likewise. *

[PATCH 1/5] rm a bunch of _stat allocation functions

2014-05-13 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, basically this patch is unchanged from the last time I sent this series, except I reordered the includes in rtl.c to have ggc.h come before vec.h because vec.h declares some functions from ggc.h if building a binary to run on the build machine.

[PATCH 4/5] add finalizers to ggc

2014-05-13 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com This implements finalizers by keeping a list of registered finalizers and after every mark but before sweeping check to see if any of them are for unmarked blocks. This uses the two vector and forward iteration approach I think richi agreed to.

[PATCH 5/5] move many members of target_globals out of gc memory

2014-05-13 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Same as patch 6 in the original series. I forget if this is ok, so please tell me, and yes it was bootstrapped + regtested on x86_64-unknown-linux-gnu Trev gcc/ChangeLog: * target-globals.c (target_globals::~target_globals): new destructor.

Re: [patch, mips] fix JALR test in configure.ac

2014-05-13 Thread Richard Sandiford
Sandra Loosemore san...@codesourcery.com writes: When configuring GCC for mips-linux-gnu, this happens: configure:26145: checking assembler and linker for explicit JALR relocation conftest.s: Assembler messages: conftest.s:2: Internal error! Assertion failure in macro_build at

Re: [patch, mips] small -mmicromips testsuite cleanup

2014-05-13 Thread Richard Sandiford
Sandra Loosemore san...@codesourcery.com writes: 2014-05-12 Nathan Sidwell nat...@codesourcery.com Sandra Loosemore san...@codesourcery.com gcc/testsuite/ * gcc.target/mips/loongson-simd.c: Disable micromips too. OK, thanks. Richard

Re: [PATCH] Fix up ix86_expand_set_or_movmem (PR target/61060)

2014-05-13 Thread Jan Hubicka
Hi! As discussed in the PR, ix86_expand_set_or_movmem assumes that count == 0 means !CONST_INT_P (count_exp), but that is not necessarily true with -O0 -ftree-ter, when the middle-end doesn't immediately see the length argument be integer_zerop, yet TER results in it being expanded as

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-13 Thread Mark Wielaard
On Mon, May 12, 2014 at 11:22:11PM -0400, Jason Merrill wrote: On 04/28/2014 08:37 AM, Mark Wielaard wrote: The debugger cares about the actual underlying type used if the language can use multiple. Either explicitly assigned by the user or implicitly as derived by the language/compile flags

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-13 Thread Marek Polacek
On Mon, May 12, 2014 at 03:44:42PM +, Joseph S. Myers wrote: On Sun, 11 May 2014, Marek Polacek wrote: FAIL: c-c++-common/pr50459.c -std=gnu++1y (test for excess errors) FAIL: c-c++-common/pr50459.c -Wc++-compat (test for excess errors) The errors are

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Marek Polacek
On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: Thanks. Committed the patch @r210351 with changes: (1) Create shrink-wrap.h. (2) Move all shrink-wrapping related interfaces from function.h to shrink-wrap.h. (3) shrink-wrap.h is included in function.c, shrink-wrap.c and

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Konstantin Serebryany
I've committed this upstream and will include it into my next updated patch: +#if defined(__x86_64__) !defined(_LP64) + typedef long long __sanitizer_time_t; +#else + typedef long __sanitizer_time_t; +#endif + struct __sanitizer_timeb { -long time; +__sanitizer_time_t time;

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread pinskia
On May 13, 2014, at 12:59 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: I've committed this upstream and will include it into my next updated patch: +#if defined(__x86_64__) !defined(_LP64) + typedef long long __sanitizer_time_t; +#else + typedef long

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Zhenqiang Chen
On 13 May 2014 15:55, Marek Polacek pola...@redhat.com wrote: On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: Thanks. Committed the patch @r210351 with changes: (1) Create shrink-wrap.h. (2) Move all shrink-wrapping related interfaces from function.h to shrink-wrap.h. (3)

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-13 Thread Joern Rennecke
On 12 May 2014 23:39, Oleg Endo oleg.e...@t-online.de wrote: This is the same as changing/setting the FP modes (PR, SZ) on SH while preserving the other FPSCR bits, or did I miss something? It's more like if you have to control multiple bits at once to get a specific mode. Say you have to turn

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Marek Polacek
On Tue, May 13, 2014 at 04:08:21PM +0800, Zhenqiang Chen wrote: On 13 May 2014 15:55, Marek Polacek pola...@redhat.com wrote: On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: Thanks. Committed the patch @r210351 with changes: (1) Create shrink-wrap.h. (2) Move all

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Jakub Jelinek
On Mon, May 12, 2014 at 03:20:37PM +0400, Konstantin Serebryany wrote: This is the first libsanitizer merge in 4.10 (the last merge was in December 2013). Worked on x86_64-linux and i686-linux (Fedora 20 and 17), bootstrap/regtest showed no regressions. Jakub

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Konstantin Serebryany
On Tue, May 13, 2014 at 12:05 PM, pins...@gmail.com wrote: On May 13, 2014, at 12:59 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: I've committed this upstream and will include it into my next updated patch: +#if defined(__x86_64__) !defined(_LP64) + typedef long

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Rainer Orth
pins...@gmail.com writes: If this is not enough, please contribute patches directly upstream -- I can not accept them from here. I am still against the way Libsanitizer is being maintained. I really think the maintainers of the source in gcc should submit the patches upstream and not

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-05-13 Thread Richard Biener
On Mon, 12 May 2014, Evgeny Stupachenko wrote: The test is on general changes. However I was able to test it on x86 only. I see 2 possible solutions: 1. Set the test for x86 only. 2. Modify it so that it will pass on sparc-sun-solaris2. If 2. is not acceptable I'll create patch for 1.

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Zhenqiang Chen
On 13 May 2014 16:13, Marek Polacek pola...@redhat.com wrote: On Tue, May 13, 2014 at 04:08:21PM +0800, Zhenqiang Chen wrote: On 13 May 2014 15:55, Marek Polacek pola...@redhat.com wrote: On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: Thanks. Committed the patch @r210351

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Rainer Orth
Konstantin Serebryany konstantin.s.serebry...@gmail.com writes: I am still against the way Libsanitizer is being maintained. I do not enjoy it either. Suggestions are welcome, and see below! I really think the maintainers of the source in gcc should submit the patches upstream and not

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-05-13 Thread Rainer Orth
Evgeny Stupachenko evstu...@gmail.com writes: The test is on general changes. However I was able to test it on x86 only. I see 2 possible solutions: 1. Set the test for x86 only. 2. Modify it so that it will pass on sparc-sun-solaris2. If 2. is not acceptable I'll create patch for 1.

Re: [RFC] Using function clones for Pointer Bounds Checker

2014-05-13 Thread Ilya Enkovich
2014-05-13 1:20 GMT+04:00 Jeff Law l...@redhat.com: On 01/14/14 02:15, Ilya Enkovich wrote: Hi, I've been working for some time on the prototype of the Pointer Bounds Checker which uses function clones for instrumentation (http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03327.html). After

Re: [PATCH] Add missing -fdump-* options

2014-05-13 Thread Richard Biener
On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson tejohn...@google.com wrote: I discovered that the support for the documented -fdump-* options optimized, missed, note and optall was missing. Added that and fixed a minor typo in the documentation. Bootstrapped and tested on

Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call

2014-05-13 Thread Rainer Orth
Wei Mi w...@google.com writes: Thanks for trying the testcase. rtl scanning will be slightly better than assembly scanning. So how about this one? This one works fine for me. Thanks. Rainer -- - Rainer Orth,

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Konstantin Serebryany
other than by following the standard process because this will violate the LLVM developer policy. Which says what? http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch Once your patch is ready, submit it by emailing it to the appropriate project’s commit mailing list (or

Re: [PATCH, AArch64] Implement HARD_REGNO_CALLER_SAVE_MODE

2014-05-13 Thread Richard Earnshaw
On 12/05/14 17:30, Ian Bolton wrote: Currently, on AArch64, when a caller-save register is saved/restored, GCC is accessing the maximum size of the hard register. So an SImode integer (4 bytes) value is being stored as DImode (8 bytes) because the int registers are 8 bytes wide, and an

Re: [GSoC] use obstack in parse_c_expr

2014-05-13 Thread Richard Biener
On Fri, May 9, 2014 at 10:30 PM, Jeff Law l...@redhat.com wrote: On 04/25/14 05:39, Prathamesh Kulkarni wrote: On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo dnovi...@google.com wrote: Please remember to send patches to gcc-patches. I'm wondering if you couldn't just use std::string here.

Re: [PATCH] Fix omp declare simd cloning (PR tree-optimization/60823)

2014-05-13 Thread Rainer Orth
Jakub Jelinek ja...@redhat.com writes: 2014-04-18 Jakub Jelinek ja...@redhat.com PR tree-optimization/60823 * omp-low.c (ipa_simd_modify_function_body): Go through all SSA_NAMEs and for those refering to vector arguments which are going to be replaced adjust

Re: RFA: Fix type incompatibility in get_addr_base_and_unit_offset_1

2014-05-13 Thread Richard Biener
On Sat, May 10, 2014 at 9:19 PM, Richard Sandiford rdsandif...@googlemail.com wrote: get_addr_base_and_unit_offset_1 and get_ref_base_and_extent have similar code to handle array indices. The code in tree-dfa.c extends from the precision of the index, as before wide-int, but the tree-dfa.h

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Rainer Orth
Konstantin Serebryany konstantin.s.serebry...@gmail.com writes: other than by following the standard process because this will violate the LLVM developer policy. Which says what? http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch Once your patch is ready, submit it by

Re: libsanitizer merge from upstream r208536

2014-05-13 Thread Yury Gribov
Your current policy seems to massively impede contributions. How? (BTW, I am not the one who sets these policies and discussing them with me makes little sense) I think people are mainly worried with checking out Clang, making it to build (install Cmake, C++11-friendly compiler, etc.), then

Re: [Ada] RFA: Add some missing integer_one_node conversions

2014-05-13 Thread Richard Biener
On Sat, May 10, 2014 at 9:25 PM, Richard Sandiford rdsandif...@googlemail.com wrote: While testing another patch, I hit cases where Ada was building or folding additions involving integer_one_node without converting it to the type of the other operand. This looked unintentional, since all

Re: [PATCH GCC]Pick up more address lowering cases for ivopt and tree-affine.c

2014-05-13 Thread Richard Biener
On Sun, May 11, 2014 at 2:49 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Thu, May 8, 2014 at 5:08 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Tue, May 6, 2014 at 6:44 PM, Richard Biener richard.guent...@gmail.com wrote: On Tue, May 6, 2014 at 10:39 AM, Bin.Cheng amker.ch...@gmail.com

Re: [PATCH] Fix issue in uninit analysis (PR middle-end/61112)

2014-05-13 Thread Richard Biener
On Mon, May 12, 2014 at 5:42 AM, Patrick Palka patr...@parcs.ath.cx wrote: Hi, This patch fixes a bogus warning generated by -Wmaybe-uninitialized. The problem is that we sometimes fail to acknowledge a defining edge belonging to a control-dependence chain because we assume that each

RE: [Patch,Microblaze]: Added Break Handler Support

2014-05-13 Thread Ajit Kumar Agarwal
Hello Michael: The following patch is to handle Software and Hardware breaks in Microblaze Architecture. Deja GNU testcase does not have any regressions and the testcase attached passes through. Review comments are incorporated. Okay for trunk? Thanks Regards Ajit From

Re: [PATCH][x86] Support clflushopt, xsaves, xsavec.

2014-05-13 Thread Ilya Tocar
On 12 May 15:42, Uros Bizjak wrote: On Mon, May 12, 2014 at 3:25 PM, Ilya Tocar tocarip.in...@gmail.com wrote: This patch add support for xsavec, xsaves ISA extensions, introduced in [1], and clflushopt introduced in [2].

Re: [PATCH 1/5] rm a bunch of _stat allocation functions

2014-05-13 Thread Richard Biener
On Tue, May 13, 2014 at 8:41 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, basically this patch is unchanged from the last time I sent this series, except I reordered the includes in rtl.c to have ggc.h come before vec.h because vec.h declares some

Re: [PATCH 4/5] add finalizers to ggc

2014-05-13 Thread Richard Biener
On Tue, May 13, 2014 at 8:41 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com This implements finalizers by keeping a list of registered finalizers and after every mark but before sweeping check to see if any of them are for unmarked blocks. This uses the two

Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-05-13 Thread Zhenqiang Chen
On 9 May 2014 14:08, Jeff Law l...@redhat.com wrote: On 05/08/14 02:07, Zhenqiang Chen wrote: Hi, The patch splits the live_edge for move_insn_for_shrink_wrap to sink the copy out of the entry block. Bootstrap and no make check regression on X86-64 and ARM. OK for trunk? Thanks!

Re: [PATCH, 1/2] shrink wrap a function with a single loop: copy propagation

2014-05-13 Thread Zhenqiang Chen
After reading the code in regcprop.c, I think I should reuse the copyprop_hardreg_forward_1. So rewrite the patch, which is much simple and should handle HAVE_cc0. But not sure we'd handle DEBUG_INSN or not. 2014-05-13 Zhenqiang Chen zhenqiang.c...@linaro.org * regcprop.c

Re: [PATCH][x86] Support clflushopt, xsaves, xsavec.

2014-05-13 Thread Uros Bizjak
On Tue, May 13, 2014 at 11:18 AM, Ilya Tocar tocarip.in...@gmail.com wrote: This patch add support for xsavec, xsaves ISA extensions, introduced in [1], and clflushopt introduced in [2]. [1]http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html

Re: [PATCH GCC]Pick up more address lowering cases for ivopt and tree-affine.c

2014-05-13 Thread Bin.Cheng
On Tue, May 13, 2014 at 4:59 PM, Richard Biener richard.guent...@gmail.com wrote: On Sun, May 11, 2014 at 2:49 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Thu, May 8, 2014 at 5:08 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Tue, May 6, 2014 at 6:44 PM, Richard Biener

[PATCH] Fix PR60973

2014-05-13 Thread Richard Biener
As discussed in the PR, tailcall settings have to be cleared by the inliner. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk and 4.9 branch. Richard. 2014-05-13 Richard Biener rguent...@suse.de PR ipa/60973 * tree-inline.c (remap_gimple_stmt): Clear

Re: [DOC Patch] symbol rename pragmas

2014-05-13 Thread David Wohlferd
Thank you for taking the time to review this. the current text makes reference to compatibility with the Solaris system headers, the remaining pragma is (according to the existing text) currently on all platforms. This makes referring to Solaris both superfluous and potentially confusing. I

[patch] libstdc++/60497 (again) - qualify more calls

2014-05-13 Thread Jonathan Wakely
My fix for PR 60497 didn't cover the rvalue overloads of std::get. I also noticed we don't handle comparisons properly if tuple elements have perverse overloaded comparison operators. Tested x86_64-linux, committed to trunk. commit 0f87ec2cdf390a1234a8562e6b3aba95182a6951 Author: Jonathan

Re: [DOC Patch] symbol rename pragmas

2014-05-13 Thread Rainer Orth
Hi David, Thank you for taking the time to review this. the current text makes reference to compatibility with the Solaris system headers, the remaining pragma is (according to the existing text) currently on all platforms. This makes referring to Solaris both superfluous and potentially

[testsuite] Centralise clearing hardware capabilities with Sun ld

2014-05-13 Thread Rainer Orth
Prompted by the recent failures of c-c++-common/gomp/pr60823-2.c on Solaris/x86 with Sun as http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00943.html I've reworked the clearing of hardware capabilities via linker maps for Sun ld, which is currently replicated in several places all over the

Re: [PATCH 0/3] Compile-time gimple checking v4

2014-05-13 Thread Michael Matz
Hi, On Mon, 12 May 2014, David Malcolm wrote: The gfoo type names are pleasantly terse, though I'm a little unhappy about how they no longer match the prefix of the accessor functions e.g. gimple_switch_num_labels (const gswitch *gs) vs gimple_switch_num_labels (const gimple_switch *gs)

Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler

2014-05-13 Thread Senthil Kumar Selvaraj
On Mon, May 12, 2014 at 01:19:37PM +0200, Georg-Johann Lay wrote: Am 04/18/2014 11:52 AM, schrieb Senthil Kumar Selvaraj: On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote: Senthil Kumar Selvaraj schrieb: This patch modifies AVR target's ASM spec to pass -mlink-relax to the

Re: [PATCH][ARM] Remove unused vtrn, vzip, vuzp NEON builtins

2014-05-13 Thread Kyrill Tkachov
Ping. Thanks, Kyrill On 06/05/14 14:37, Kyrill Tkachov wrote: Hi all, This patch removes the NEON builtin functions for vtrn, vzip, vuzp and their associated wiring and machine descriptions. The builtins were initially used to implement the corresponding intrinsics in arm_neon.h but those

Re: [PATCH, ARM] Enable shrink-wrap for apcs frame

2014-05-13 Thread Richard Earnshaw
On 25/03/14 08:13, Zhenqiang Chen wrote: Hi The patch enables shrink-wrap for apcs frame. Bootstrap and no make check regression in ARM, THUMB1 and THUMB2 modes. No make check regression with -g/-mapcs/-marm. Build linux-3.14-rc7 without error. Is it OK for next stage1? Thanks!

Re: [PATCH][ARM] Remove unused vtrn, vzip, vuzp NEON builtins

2014-05-13 Thread Ramana Radhakrishnan
On 05/06/14 14:37, Kyrill Tkachov wrote: Hi all, This patch removes the NEON builtin functions for vtrn, vzip, vuzp and their associated wiring and machine descriptions. The builtins were initially used to implement the corresponding intrinsics in arm_neon.h but those have since been

Re: [PATCH 0/3] Compile-time gimple checking v4

2014-05-13 Thread Richard Biener
On Tue, May 13, 2014 at 2:37 PM, Michael Matz m...@suse.de wrote: Hi, On Mon, 12 May 2014, David Malcolm wrote: The gfoo type names are pleasantly terse, though I'm a little unhappy about how they no longer match the prefix of the accessor functions e.g. gimple_switch_num_labels (const

Re: [PATCH] Add missing -fdump-* options

2014-05-13 Thread Teresa Johnson
On Tue, May 13, 2014 at 1:39 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson tejohn...@google.com wrote: I discovered that the support for the documented -fdump-* options optimized, missed, note and optall was missing. Added that and fixed a

[linaro/gcc-4_9-branch] Merge from gcc-4_9-branch and backports

2014-05-13 Thread Yvan Roux
Hi, we have merged the gcc-4_9-branch into linaro/gcc-4_9-branch up to revision 210052 as r210370. We also have backported Ada AArch64 support as r210372 and 2 other upstream contributions as r210373 and r210376. This will be part of our 2014.05 release. Thanks, Yvan

Re: [PATCH 0/3] Compile-time gimple checking v4

2014-05-13 Thread David Malcolm
On Tue, 2014-05-13 at 15:10 +0200, Richard Biener wrote: On Tue, May 13, 2014 at 2:37 PM, Michael Matz m...@suse.de wrote: Hi, On Mon, 12 May 2014, David Malcolm wrote: The gfoo type names are pleasantly terse, though I'm a little unhappy about how they no longer match the prefix of

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-13 Thread Jonathan Wakely
On 12 May 2014 18:14, Jeff Law wrote: On 05/12/14 11:10, John Marino wrote: On 5/12/2014 18:59, Jeff Law wrote: On 05/09/14 01:14, John Marino wrote: 1) Patch updated online as requested 2) At this exact point in time, we probably can share the files 3) I might debate that we should

Ping^2 [patch, toplevel] configure nios2-elf libraries to build with -mno-gpopt

2014-05-13 Thread Sandra Loosemore
On 05/05/2014 02:32 PM, Sandra Loosemore wrote: Ping! http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01618.html And ping again -Sandra

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-13 Thread Dimitris Papavasiliou
On 05/12/2014 11:53 PM, Mike Stump wrote: I put in one small fix: Doing diffs in testsuite/objc.dg/ivar-visibility-4.m.~1~: --- testsuite/objc.dg/ivar-visibility-4.m.~1~ 2014-05-12 12:04:16.0 -0700 +++ testsuite/objc.dg/ivar-visibility-4.m 2014-05-12 13:50:53.0 -0700

Re: Ping^2 [patch, toplevel] configure nios2-elf libraries to build with -mno-gpopt

2014-05-13 Thread DJ Delorie
I understand that this patch, although target-specific, needs to be approved by a global reviewer Target-specific fragments of build files are generally approved by the target maintainer. A global maintainer's approval is not required. and then propagated to the sourceware.org binutils-gdb

Re: [PATCH 0/3] Compile-time gimple checking v4

2014-05-13 Thread Richard Biener
On Tue, May 13, 2014 at 3:27 PM, David Malcolm dmalc...@redhat.com wrote: On Tue, 2014-05-13 at 15:10 +0200, Richard Biener wrote: On Tue, May 13, 2014 at 2:37 PM, Michael Matz m...@suse.de wrote: Hi, On Mon, 12 May 2014, David Malcolm wrote: The gfoo type names are pleasantly terse,

Re: [PATCH] Add missing -fdump-* options

2014-05-13 Thread Xinliang David Li
On Tue, May 13, 2014 at 1:39 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson tejohn...@google.com wrote: I discovered that the support for the documented -fdump-* options optimized, missed, note and optall was missing. Added that and fixed a

Re: [PATCH] gengtype: Support explicit pointers in template arguments

2014-05-13 Thread David Malcolm
On Mon, 2014-05-05 at 10:18 -0600, Jeff Law wrote: On 04/30/14 21:07, David Malcolm wrote: Currently, gengtype does not support template arguments that are explicitly pointers, such as: static GTY(()) vecgimple_statement_base * test_gimple; giving this error:

[PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-13 Thread Yury Gribov
Hi, Asan and Tsan allow sanitized applications to tweak runtime behavior via API defined in headers in libsanitizer/include/sanitizer. This patch adds installation code for these headers and a small test. Bootstrapped and regtested on x64. -Y libsanitizer/ChangeLog: 2014-05-13 Yury Gribov

[GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Dehao Chen
The previous checkin will break build for most application: http://gcc.gnu.org/viewcvs/gcc/branches/google/gcc-4_9/gcc/?view=log This patch fixes the regression by updating highest_location. Testing on-going, OK for google-4_9 branch? Thanks, Dehao Index: gcc/input.c

Re: [GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Cary Coutant
Index: gcc/input.c === --- gcc/input.c (revision 210338) +++ gcc/input.c (working copy) @@ -910,6 +910,8 @@ location_with_discriminator (location_t locus, int : next_discriminator_location);

Re: [GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Dehao Chen
The problem is that linemap_location_from_macro_expansion_p will always return true if locus has discriminator. And in linemap_lookup, this will lead to call linemap_macro_map_lookup, in which there is an assertion: linemap_assert (line = LINEMAPS_MACRO_LOWEST_LOCATION (set)); However, line is

Re: [Patch,Microblaze]: Added Break Handler Support

2014-05-13 Thread Michael Eager
On 05/13/14 02:14, Ajit Kumar Agarwal wrote: Hello Michael: The following patch is to handle Software and Hardware breaks in Microblaze Architecture. Deja GNU testcase does not have any regressions and the testcase attached passes through. Review comments are incorporated. Okay for trunk?

Re: [GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Cary Coutant
The problem is that linemap_location_from_macro_expansion_p will always return true if locus has discriminator. And in linemap_lookup, this will lead to call linemap_macro_map_lookup, in which there is an assertion: linemap_assert (line = LINEMAPS_MACRO_LOWEST_LOCATION (set)); However,

[PATCH] Implement -fsanitize=float-cast-overflow

2014-05-13 Thread Marek Polacek
Here's an attempt to add the -fsanitize=float-cast-overflow instrumentation. It should issue a runtime error when a floating-point to integer type conversion overflows. Eventually it should instrument even floating-point to floating-point conversions to detect e.g. (float)1e39 overflow, but I'd

Re: [PATCH] PR60822 (m68k, missing earlyclobber in extendplussidi)

2014-05-13 Thread Joseph S. Myers
On Mon, 12 May 2014, Hans-Peter Nilsson wrote: On Thu, 24 Apr 2014, Jeff Law wrote: On 04/16/14 18:20, seg...@kernel.crashing.org wrote: PR target/60822 2014-04-16 Segher Boessenkool seg...@kernel.crashing.org * config/m68k/m68k.md (extendplussidi): Don't allow memory for

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-13 Thread Eric Botcazou
The point of it is that the release branches are actually used by GCC users, many people don't use just official releases, but arbitrary snapshots from the release branches. If a potentially risky patch is applied immediately also to release branches and soon needs follow-ups (happened many

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-13 Thread Eric Botcazou
OK, thanks. Richard also gave an RM's OK on IRC so I've now applied it. Thanks! -- Eric Botcazou

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-13 Thread Jakub Jelinek
On Tue, May 13, 2014 at 07:18:56PM +0200, Eric Botcazou wrote: The point of it is that the release branches are actually used by GCC users, many people don't use just official releases, but arbitrary snapshots from the release branches. If a potentially risky patch is applied immediately

[patch] libstdc++/60497 again - more std::get qualification

2014-05-13 Thread Jonathan Wakely
This patch ensures everywhere we use std::get we qualify it. It also changes some uses of the built-in operator with std::__addressof() which doesn't do ADL and so doesn't try to complete its argument. As noted in the bug report, the operator part of this affects most of the library, so I don't

Re: [PATCH, PR C++/61038] - g++ -E is unusable with UDL strings

2014-05-13 Thread Joseph S. Myers
On Mon, 12 May 2014, Ed Smith-Rowland wrote: This patch is really a libcpp patch. But UDLs are like that ;-) Add string user-defined literals and char user-defined literals to the list of things to look out for while escaping strings in macro args. I'm not sure how to test this really.

Re: [C PATCH] Better locinfo for -Wc++-compat (PR c/61162)

2014-05-13 Thread Joseph S. Myers
On Tue, 13 May 2014, Marek Polacek wrote: Tiny patch, just use available location instead of input_location. Tested x86_64. Ok? 2014-05-13 Marek Polacek pola...@redhat.com PR c/61162 * c-typeck.c (convert_for_assignment): Pass location to WARN_FOR_ASSIGNMENT

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-13 Thread Joseph S. Myers
On Tue, 13 May 2014, Marek Polacek wrote: Yeah, I should've done that in the first place, sorry. Is the following ok then? 2014-05-13 Marek Polacek pola...@redhat.com * c-c++-common/pr50459.c: Move cdtor tests to a separate testcase. * c-c++-common/pr50459-2.c: New test.

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-13 Thread Eric Botcazou
Even with official release you can apply a patch, that is not the point. The point is that many people expect the release branches (and IMHO rightly so) to be supposedly stable all the time, rather than being seriously unstable most of the time and only converging to stability around the

Re: [PATCH] Implement -fsanitize=float-cast-overflow

2014-05-13 Thread Jakub Jelinek
On Tue, May 13, 2014 at 07:08:01PM +0200, Marek Polacek wrote: In essence, the gist of this instrumentation is: if (x u= TYPE_MIN - 1.0 || x u= TYPE_MAX + 1.0) __ubsan_builtin (); this checks even +-Inf for free, and because the comparison is unordered, it detects even NaNs. The question

Re: [PATCH] Fix omp declare simd cloning (PR tree-optimization/60823)

2014-05-13 Thread Rainer Orth
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Jakub Jelinek ja...@redhat.com writes: 2014-04-18 Jakub Jelinek ja...@redhat.com PR tree-optimization/60823 * omp-low.c (ipa_simd_modify_function_body): Go through all SSA_NAMEs and for those refering to vector arguments

Re: [DOC Patch] symbol rename pragmas

2014-05-13 Thread Joseph S. Myers
On Tue, 13 May 2014, Rainer Orth wrote: right, and that's why I want to keep this info. If it weren't for Solaris compatibility, this pragma wouldn't exist, and given that heritage, I don't want to encourage its use elsewhere, even though it does work. I can see definite cases where it

Re: [GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Dehao Chen
As discussed offline, this is actually due to missing parts of the previous patch (some changes does not appear in the change log of r199154). I've updated the patch to include those missing pieces. Testing on going. Dehao On Tue, May 13, 2014 at 10:04 AM, Cary Coutant ccout...@google.com wrote:

[PATCH] Use -ggnu-pubnames with -gsplit-dwarf

2014-05-13 Thread Cary Coutant
This patch forces the use of -ggnu-pubnames when using -gsplit-dwarf. This is necessary so that the gold linker can generate .gdb_index version 7. No new regressions. Committed as trivial (has no effect if you're not using -gsplit-dwarf). -cary 2014-05-13 Cary Coutant ccout...@google.com

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-13 Thread Jakub Jelinek
On Tue, May 13, 2014 at 07:34:51PM +0200, Eric Botcazou wrote: Even with official release you can apply a patch, that is not the point. The point is that many people expect the release branches (and IMHO rightly so) to be supposedly stable all the time, rather than being seriously unstable

Re: [PATCH] Fix omp declare simd cloning (PR tree-optimization/60823)

2014-05-13 Thread Jakub Jelinek
On Tue, May 13, 2014 at 07:38:52PM +0200, Rainer Orth wrote: Rainer Orth r...@cebitec.uni-bielefeld.de writes: Jakub Jelinek ja...@redhat.com writes: 2014-04-18 Jakub Jelinek ja...@redhat.com PR tree-optimization/60823 * omp-low.c (ipa_simd_modify_function_body): Go through

[google/gcc-4_9] Force the use of -ggnu-pubnames when using -gsplit-dwarf

2014-05-13 Thread Cary Coutant
I've backported this patch from trunk at r210395. -cary gcc/ * opts.c (finish_options): Use -ggnu-pubnames with -gsplit-dwarf.

Re: [PATCH] Implement -fsanitize=float-cast-overflow

2014-05-13 Thread Joseph S. Myers
On Tue, 13 May 2014, Marek Polacek wrote: Here's an attempt to add the -fsanitize=float-cast-overflow instrumentation. It should issue a runtime error when a floating-point to integer type conversion overflows. Eventually it should instrument As with divide-by-zero, this should not be part

C++ PATCH for c++/61151 (ICE with nested lambda in template)

2014-05-13 Thread Jason Merrill
My patch for 60092 failed to consider that we need to avoid obscuring a capture proxy for 'this', not just 'this' itself. Tested x86_64-pc-linux-gnu, applying to trunk. commit e40151a986a68e29c169913e36b76fa4310379d7 Author: Jason Merrill ja...@redhat.com Date: Tue May 13 12:52:37 2014 -0400

Re: [GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Dehao Chen
Attached patch passes regression tests and benchmark test. OK for google-4_9? Thanks, Dehao On Tue, May 13, 2014 at 10:43 AM, Dehao Chen de...@google.com wrote: As discussed offline, this is actually due to missing parts of the previous patch (some changes does not appear in the change log of

Re: Ping^2 [patch, toplevel] configure nios2-elf libraries to build with -mno-gpopt

2014-05-13 Thread Jeff Law
On 05/13/14 08:11, Sandra Loosemore wrote: On 05/05/2014 02:32 PM, Sandra Loosemore wrote: Ping! http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01618.html And ping again As a co-maintainer for the nios2 port, I think this would be something you could self-approve. Regardless, approved

RE: [Patch,Microblaze]: Added Break Handler Support

2014-05-13 Thread Ajit Kumar Agarwal
Hello Michael: Thanks for the comments on ChangeLog. Modified ChangeLog is inlined below. 2014-05-13 Ajit Agarwal ajit...@xilinx.com * config/microblaze/microblaze.c (break_handler): New Declaration. (microblaze_break_function_p,microblaze_is_break_handler) : New

Re: [RFC] Using function clones for Pointer Bounds Checker

2014-05-13 Thread Jeff Law
On 05/13/14 02:38, Ilya Enkovich wrote: propagate constant bounds value and remove checks in called function). So from a linking standpoint, presumably you have to mangle the instrumented caller/callee in some manner. Right? Or are you dynamically dispatching somehow? Originally the idea

Re: [PATCH, 1/2] shrink wrap a function with a single loop: copy propagation

2014-05-13 Thread Jeff Law
On 05/09/14 01:30, Zhenqiang Chen wrote: So why restrict this to just cases where we have to propagate into a COMPARE at the end of a block? So in your example, assume the first block looks like prepare_shrink_wrap will move_insn_for_shrink_wrap in BB_INSNS_REVERSE order. Current

Re: [Patch,Microblaze]: Added Break Handler Support

2014-05-13 Thread Michael Eager
On 05/13/14 12:15, Ajit Kumar Agarwal wrote: Hello Michael: Thanks for the comments on ChangeLog. Modified ChangeLog is inlined below. Please resubmit the patch with documentation for _break_handler. -- Michael Eagerea...@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077

[PATCH] Provide inlining context in strict-overflow warnings

2014-05-13 Thread Florian Weimer
Patterns that trigger the optimization and warning can form after inlining, and it can be rather difficult to figure out what exactly is causing the warning. The inlining context at least provides additional hints, enabling developers to substitute the arguments and discover what, precisely,

Re: [GOOGLE] Updates highest_location when updating next_discriminator_location

2014-05-13 Thread Cary Coutant
Attached patch passes regression tests and benchmark test. OK for google-4_9? OK. Thanks again! -cary

[patch,mips] avoid invalid register for JALR

2014-05-13 Thread Sandra Loosemore
When I was trying to benchmark another patch (which I'll be sending along shortly) with CSiBE for -mabi=64, I ran into an assembler error like this: /tmp/ccJv2faG.s: Assembler messages: /tmp/ccJv2faG.s:1605: Error: a destination register must be supplied `jalr $31' Indeed, GCC is generating

  1   2   >