Re: [PATCH] Fix PR63259: bswap not recognized when finishing with rotation

2014-10-07 Thread Andrew Pinski
On Tue, Oct 7, 2014 at 11:43 PM, Thomas Preud'homme wrote: >> From: Jakub Jelinek [mailto:ja...@redhat.com] >> Sent: Wednesday, October 08, 2014 2:39 PM >> >> Doesn't it turn 16-bit {L,R}ROTATE_EXPR used alone into >> __builtin_bswap16? >> For those the question is if the canonical GIMPLE should b

RE: [PATCH] Fix PR63259: bswap not recognized when finishing with rotation

2014-10-07 Thread Thomas Preud'homme
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme > Sent: Wednesday, October 08, 2014 2:43 PM > > Also, perhaps you could short-circuit this if the rotation isn't by constant Note that do_shift_rotate already check for this. Is it enoug

Re: [Patch, MIPS] Add Octeon3 support

2014-10-07 Thread Hurugalawadi, Naveen
Hi, >> Patches adding new -march= values need to update invoke.texi. Thanks for reviewing the patch and suggestion. Please find attached the modified patch which updates octeon3 in invoke.texi Please review the patch and let us know if there should be any further modifications. Thanks, 2014-10-

RE: [PATCH] Fix PR63259: bswap not recognized when finishing with rotation

2014-10-07 Thread Thomas Preud'homme
> From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Wednesday, October 08, 2014 2:39 PM > > Doesn't it turn 16-bit {L,R}ROTATE_EXPR used alone into > __builtin_bswap16? > For those the question is if the canonical GIMPLE should be the rotation > or > byteswap, I'd think rotation would be perha

Re: [PATCH] Fix PR63259: bswap not recognized when finishing with rotation

2014-10-07 Thread Jakub Jelinek
On Wed, Oct 08, 2014 at 09:56:51AM +0800, Thomas Preud'homme wrote: > --- a/gcc/tree-ssa-math-opts.c > +++ b/gcc/tree-ssa-math-opts.c > @@ -2377,11 +2377,16 @@ pass_optimize_bswap::execute (function *fun) > { > gimple src_stmt, cur_stmt = gsi_stmt (gsi); > tree fndecl = NUL

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-10-07 Thread Bin.Cheng
On Wed, Oct 8, 2014 at 1:28 PM, Jeff Law wrote: > On 10/06/14 19:31, Bin.Cheng wrote: >> >> On Tue, Oct 7, 2014 at 1:20 AM, Mike Stump wrote: >>> >>> On Oct 6, 2014, at 4:32 AM, Richard Biener >>> wrote: On Mon, Oct 6, 2014 at 11:57 AM, Bin.Cheng wrote: How many merging

Re: [PATCH] Fix PR bootstrap/63432 in jump threading

2014-10-07 Thread Jeff Law
On 10/07/14 22:39, Teresa Johnson wrote: This patch addresses PR bootstrap/63432 which was an insanity in the probabilities created during jump threading. This was caused by threading multiple times along the same path leading to the second jump thread path being corrupted, which in turn caused t

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-10-07 Thread Jeff Law
On 10/06/14 19:31, Bin.Cheng wrote: On Tue, Oct 7, 2014 at 1:20 AM, Mike Stump wrote: On Oct 6, 2014, at 4:32 AM, Richard Biener wrote: On Mon, Oct 6, 2014 at 11:57 AM, Bin.Cheng wrote: How many merging opportunities does sched2 undo again? ISTR it has the tendency of pushing stores down a

[PATCH] Fix PR bootstrap/63432 in jump threading

2014-10-07 Thread Teresa Johnson
This patch addresses PR bootstrap/63432 which was an insanity in the probabilities created during jump threading. This was caused by threading multiple times along the same path leading to the second jump thread path being corrupted, which in turn caused the profile update code to fail. There was c

Re: [PATCH] add overlap function to gcov-tool

2014-10-07 Thread Jan Hubicka
> Hi, > > This patch adds overlap functionality to gcov-tool. The overlap score > estimates the similarity of two profiles. Currently it only computes > overlap for arc counters. > > The overlap score is defined as > \sum minimum (p1-counter[i] / p1-sum-all, p2-counter[i] / p2-sum-all) > where p1

Re: [PATCH GCC]Improve candidate selecting in IVOPT

2014-10-07 Thread Bin.Cheng
Ping. Any review comments? Thanks, bin On Wed, Oct 1, 2014 at 6:31 AM, Sebastian Pop wrote: > Bin Cheng wrote: >> Hi, >> As analyzed in PR62178, IVOPT can't find the optimal iv set for that case. >> The problem with current heuristic algorithm is it only replaces candidate >> with ones not in c

[PATCH PING]Improve induction variable elimination

2014-10-07 Thread Bin Cheng
Hi, This patch is posted long before in a series of patches at https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01392.html . Since the preceding patch is changed according to review comments, also because it's long time not reviewed, I rebased and updated this patch as attached. With this patch, s

[PATCH] Fix PR63259: bswap not recognized when finishing with rotation

2014-10-07 Thread Thomas Preud'homme
Currently the bswap pass only look for bswap pattern by examining bitwise OR statement and doing following def-use chains. However a rotation (left or right) can finish a manual byteswap, as shown in the following example: unsigned byteswap_ending_with_rotation (unsigned in) { in = ((in & 0xff

[committed] MAINTAINERS (Write After Approval): Add myself.

2014-10-07 Thread Felix Yang
Index: MAINTAINERS === --- MAINTAINERS(revision 215985) +++ MAINTAINERS(working copy) @@ -583,6 +583,7 @@ Chung-Ju Wu Le-Chun Wu Mingjie Xing Canqun Yang

Re: [Fortran, Patch] Implement IMPLICIT NONE

2014-10-07 Thread Dominique Dhumieres
Patch: --- ../_clean/gcc/testsuite/gfortran.dg/implicit_4.f90 2014-10-07 00:21:56.0 +0200 +++ gcc/testsuite/gfortran.dg/implicit_4.f902014-10-07 19:09:45.0 +0200 @@ -6,7 +6,7 @@ END SUBROUTINE a IMPLICIT REAL(b-j) -implicit none ! { dg-error "Type IMPLICIT NONE stat

Re: RFA: fix mode confusion in caller-save.c:replace_reg_with_saved_mem

2014-10-07 Thread Joern Rennecke
On 7 October 2014 18:38, Jeff Law wrote: > On 10/06/14 20:57, Joern Rennecke wrote: >> >> On 6 October 2014 19:58, Jeff Law wrote: >>> >>> What makes word_mode special here? ie, why is special casing for >>> word_mode >>> the right thing to do? >> >> >> The patch does not special-case word mode.

[Patch, testsuite] check if -shared is supported

2014-10-07 Thread Christophe Lyon
Hi, When Jason added the new g++.dg/ipa/devirt-28a.C test along with his fix for PR c++/58678 (https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00838.html), this new test was failing in the ARM and AArch64 configuration I am testing. For the arm*-none-eabi and aarch64*-none-elf configurations, this

Re: C++ Patch for c++/60894

2014-10-07 Thread Jason Merrill
On 09/24/2014 05:15 PM, Jason Merrill wrote: On 09/24/2014 05:06 PM, Fabien Chêne wrote: Unfortunately, just stripping the USING_DECL in lookup_and_check_tag does not really work because some diagnotic codes expect the USING_DECL not to be stripped. It seems to me that the problem is that look

Re: sort_heap complexity guarantee

2014-10-07 Thread Daniel Krügler
2014-10-07 23:11 GMT+02:00 François Dumont : > On 06/10/2014 23:05, Daniel Krügler wrote: >> François, could you please submit a corresponding LWG issue by sending >> an email using the recipe described here: >> >> http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#submit_issue >> >> ? >>

Re: sort_heap complexity guarantee

2014-10-07 Thread François Dumont
On 06/10/2014 23:05, Daniel Krügler wrote: 2014-10-06 23:00 GMT+02:00 François Dumont : On 05/10/2014 22:54, Marc Glisse wrote: On Sun, 5 Oct 2014, François Dumont wrote: I took a look at PR 61217 regarding pop_heap complexity guarantee. Looks like we have no test to check complexity of o

Towards GNU11

2014-10-07 Thread Marek Polacek
Hi! I'd like to kick off a discussion about moving the default standard for C from gnu89 to gnu11. This really shouldn't be much of a surprise: the docs mention that gnu11 is intended future default for a year now. I would presume now is a good time to make this move: together with the new namin

[Google 4.9] Backport of r210828

2014-10-07 Thread Sterling Augustine
The enclosed patch for google 4.9 is a backport of r210828 from trunk. googleref:b/14623977 The given tests now pass when run by hand, but timeout under dejagnu I will be sending a different change to fix that. OK for google 4.9? The enclosed patch for google 4.9 is a backport of r210828 from tr

[PATCH] add overlap function to gcov-tool

2014-10-07 Thread Rong Xu
Hi, This patch adds overlap functionality to gcov-tool. The overlap score estimates the similarity of two profiles. Currently it only computes overlap for arc counters. The overlap score is defined as \sum minimum (p1-counter[i] / p1-sum-all, p2-counter[i] / p2-sum-all) where p1-counter[i] and p2

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 10:12:22PM +0400, Ilya Verbin wrote: > > And, is __gnu_offload_{funcs,vars} named that way just because the plugin > > isn't able to add > > symbols around the sections for you? As it doesn't contain a dot, it would > > collide > > with user declarations put into __attrib

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-07 Thread Andreas Schwab
Jonathan Wakely writes: > diff --git a/libstdc++-v3/src/c++98/locale_facets.cc > b/libstdc++-v3/src/c++98/locale_facets.cc > index 3669acb..7ed04e6 100644 > --- a/libstdc++-v3/src/c++98/locale_facets.cc > +++ b/libstdc++-v3/src/c++98/locale_facets.cc > @@ -69,19 +69,26 @@ _GLIBCXX_BEGIN_NAMESPAC

Re: [patch] tag ../include/*

2014-10-07 Thread Mike Stump
On Oct 7, 2014, at 9:37 AM, Aldy Hernandez wrote: > Is there a reason we don't create etags for toplevel include files? I don’t think there is. > If not, could I please apply this patch? I’m in favor.

Re: [GOOGLE] Handle missing BINFO for LIPO

2014-10-07 Thread Xinliang David Li
Ok (please also guard it with L_IPO_COMP_MODE). David On Tue, Oct 7, 2014 at 11:27 AM, Teresa Johnson wrote: > We may have missing BINFO on a type if that type is a builtin, since > in LIPO mode we will reset builtin types to their original tree nodes > before parsing subsequent modules. Handle

[GOOGLE] Handle missing BINFO for LIPO

2014-10-07 Thread Teresa Johnson
We may have missing BINFO on a type if that type is a builtin, since in LIPO mode we will reset builtin types to their original tree nodes before parsing subsequent modules. Handle incomplete information by returning false so we won't put an entry in the type inheritance graph for optimization. Pa

Re: [Fortran, Patch] Implement IMPLICIT NONE

2014-10-07 Thread Andreas Schwab
NONE statement at .1. > following an IMPLICIT statement" } That doesn't match. /usr/local/gcc/gcc-20141007/gcc/testsuite/gfortran.dg/implicit_4.f90:9:103: Err\or: IMPLICIT NONE (type) statement at (1) following an IMPLICIT statement Andreas. -- Andreas Schwab, sch...@linux-m68k.or

[committed] Fix missing include in check_effective_target_fd_truncate

2014-10-07 Thread Marek Polacek
In -std=gnu11 as a default mode many Fortran tests ended up as UNSUPPORTED, because check_effective_target_fd_truncate routine was missing the string.h header (it uses strncmp) hence it failed. Applying to trunk. 2014-10-07 Marek Polacek * lib/target-supports.exp (check_effective_targ

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Ilya Verbin
On 07 Oct 16:30, Jakub Jelinek wrote: > I think it is useful, doesn't have to be in the initial checkin, but I'd > certainly prefer if from the (optional) --enable-offload-target argument > it would figure out everything it needs to add for testing. > And, if mkoffload isn't flexible enough to be c

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Jason Merrill
On 10/07/2014 11:04 AM, Jakub Jelinek wrote: adding a hint in this case is less obvious than in the C case, because, what if this wasn't supposed to be ::abort (), but std::abort (), or some other namespace abort, or some class abort () method etc.? It still seems reasonable to offer a hint if

Re: [patch] remove dwarf2out's current_function_has_inlines

2014-10-07 Thread Jason Merrill
On 10/07/2014 01:16 PM, Aldy Hernandez wrote: Errr... a static that only gets written to? OK to commit? Yes. This should have been removed with 2010-09-03 Marcin Baczynski * dwarf2out.c (file scope): Remove #if0'd code. (gen_subprogram_die): Same. Jason

[jit] Documentation tweaks

2014-10-07 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ChangeLog.jit: * docs/internals/index.rst (Overview of code structure): Directly include the comment from jit-common.h as rst, rather than as a quoted C++ comment. * jit-common.h: Convert the summary format to valid reStruct

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Joseph S. Myers
On Tue, 7 Oct 2014, Marek Polacek wrote: > 2014-10-07 Marek Polacek > > PR c/59717 > * c-decl.c (header_for_builtin_fn): New function. > (implicitly_declare): Suggest which header to include. > > * gcc.dg/pr59717.c: New test. OK. -- Joseph S. Myers jos...@codesource

Re: [patch] Work harder to find DECL_STRUCT_FUNCTION

2014-10-07 Thread Jan Hubicka
> On Mon, Oct 6, 2014 at 11:52 AM, Eric Botcazou wrote: > > Hi, > > > > you can have chains of clone functions in the callgraph but > > can_inline_edge_p > > stops at the first clone when it is looking for DECL_STRUCT_FUNCTION, which > > can fool the following conditions in the predicate. > > > >

[jit] Eliminate internal-api.c/h in favor of jit-common.h, jit-playback.c/h, jit-recording.c/h

2014-10-07 Thread David Malcolm
jit/internal-api.c and .h were getting large, so I broke them out into: * jit-common.h (forward decls of types) * jit-recording.h/c (the gcc::jit::recording classes) * jit-playback.h/c (the gcc::jit::playback classes) Committed to branch dmalcolm/jit as 3071567787aef4a8ada8b38c890d01c19b4b9

Re: RFA: fix mode confusion in caller-save.c:replace_reg_with_saved_mem

2014-10-07 Thread Jeff Law
On 10/06/14 20:57, Joern Rennecke wrote: On 6 October 2014 19:58, Jeff Law wrote: What makes word_mode special here? ie, why is special casing for word_mode the right thing to do? The patch does not special-case word mode. The if condition tests if smode would cover multiple hard registers.

[PATCH] More testsuite cleanups

2014-10-07 Thread Marek Polacek
Some more cleanups revealed by testing on ppc64. Applying to trunk. 2014-10-07 Marek Polacek * gcc.dg/guality/pr41616-1.c: Use -fgnu89-inline. * gcc.dg/iftrap-1.c: Fix implicit declarations. * gcc.target/powerpc/pr26350.c: Likewise. * gcc.target/powerpc/altivec

[patch] remove dwarf2out's current_function_has_inlines

2014-10-07 Thread Aldy Hernandez
Errr... a static that only gets written to? OK to commit? commit 7b1c19385fd06d6a2d0844d453bf1c7683071440 Author: Aldy Hernandez Date: Tue Oct 7 10:14:02 2014 -0700 * dwarf2out.c: Remove current_function_has_inlines. (gen_subprogram_die): Same. (gen_inlined_subroutine_

Re: [Patch, MIPS] Add Octeon3 support

2014-10-07 Thread Joseph S. Myers
Patches adding new -march= values need to update invoke.texi. -- Joseph S. Myers jos...@codesourcery.com

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Tom Tromey
Marek> I saw declarations of JvRunMain{,Name} with no parameters and with Marek> some parameters. Oh yeah, duh. Marek> So I decided to make it prototype-less function Marek> declaration for now. I think we don't have to worry about Marek> -Wstrict-prototypes for now. Thanks for looking. Tom

Re: SD-6 C++ feature-testing macros for 4.9

2014-10-07 Thread Jason Merrill
On 10/04/2014 07:28 PM, Ed Smith-Rowland wrote: This really does build clean and test clean on x86_64-linux. It's basically the same as for 5.0 except experimental/any isn't in and variable templates aren't in. OK. Jason

[patch] tag ../include/*

2014-10-07 Thread Aldy Hernandez
Is there a reason we don't create etags for toplevel include files? If not, could I please apply this patch? Thanks. Aldy commit a679529d14f005d8c88517f72d2b5295d8c82f0f Author: Aldy Hernandez Date: Tue Oct 7 09:32:21 2014 -0700 * Makefile.in (TAGS): Tag ../include files. diff --gi

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Marek Polacek
On Tue, Oct 07, 2014 at 10:03:26AM -0600, Tom Tromey wrote: > > "Marek" == Marek Polacek writes: > > Marek> [CCing java-patches now] > Marek> Java testsuite breaks with -std=gnu11 as a default and/or with > Marek> -Wimplicit-function-declaration on > > I don't recall how one gets warnings w

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Tom Tromey
> "Marek" == Marek Polacek writes: Marek> [CCing java-patches now] Marek> Java testsuite breaks with -std=gnu11 as a default and/or with Marek> -Wimplicit-function-declaration on I don't recall how one gets warnings when compiling this generated code, but if it is generally possible then I

Re: [PATCH, Pointer Bounds Checker 14/x] Pointer Bounds Checker passes

2014-10-07 Thread Ilya Enkovich
2014-10-03 23:59 GMT+04:00 Jeff Law : > On 10/03/14 02:50, Ilya Enkovich wrote: >> >> Attached is an updated version of the patch. It has disabled >> instrumenttation for builtin calls. >> >> Thanks, >> Ilya >> -- >> gcc/ >> >> 2014-10-02 Ilya Enkovich >> >> * tree-chkp.c: New. >>

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Marek Polacek
On Tue, Oct 07, 2014 at 05:00:26PM +0200, Richard Biener wrote: > On Tue, Oct 7, 2014 at 4:51 PM, Marek Polacek wrote: > > On Tue, Oct 07, 2014 at 04:39:55PM +0200, Richard Biener wrote: > >> Why not annotate builtins.def with the info? > > > > Because I think that would be more hairy, I'd have to

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Marek Polacek
On Tue, Oct 07, 2014 at 05:00:05PM +0200, Jakub Jelinek wrote: > On Tue, Oct 07, 2014 at 04:51:31PM +0200, Marek Polacek wrote: > > On Tue, Oct 07, 2014 at 04:39:55PM +0200, Richard Biener wrote: > > > Why not annotate builtins.def with the info? > > > > Because I think that would be more hairy, I

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 05:00:26PM +0200, Richard Biener wrote: > On Tue, Oct 7, 2014 at 4:51 PM, Marek Polacek wrote: > > On Tue, Oct 07, 2014 at 04:39:55PM +0200, Richard Biener wrote: > >> Why not annotate builtins.def with the info? > > > > Because I think that would be more hairy, I'd have to

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Richard Biener
On Tue, Oct 7, 2014 at 4:51 PM, Marek Polacek wrote: > On Tue, Oct 07, 2014 at 04:39:55PM +0200, Richard Biener wrote: >> Why not annotate builtins.def with the info? > > Because I think that would be more hairy, I'd have to change DEF_BUILTIN > and all the builtins. That seemed superfluous given

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 04:51:31PM +0200, Marek Polacek wrote: > On Tue, Oct 07, 2014 at 04:39:55PM +0200, Richard Biener wrote: > > Why not annotate builtins.def with the info? > > Because I think that would be more hairy, I'd have to change DEF_BUILTIN > and all the builtins. That seemed superf

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Marek Polacek
On Tue, Oct 07, 2014 at 04:39:55PM +0200, Richard Biener wrote: > Why not annotate builtins.def with the info? Because I think that would be more hairy, I'd have to change DEF_BUILTIN and all the builtins. That seemed superfluous given that this hint is only for a C FE... Marek

Re: [patch] Fix miscompilation of gnat1 in LTO bootstrap

2014-10-07 Thread Richard Biener
On Tue, Oct 7, 2014 at 10:04 AM, Eric Botcazou wrote: >> Testcase? I think it would be better to handle this in the canonical type >> merging code in lto.c - or how does it end up working without LTO? That is, >> what does the Ada frontend do to make sure get_alias_set handles this >> correctly?

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Ilya Verbin
On 07 Oct 16:30, Jakub Jelinek wrote: > Another thing I've noticed, when target-1.exe is built, there are tons of > sections that IMHO should have been stripped away: Could you please re-checkout the branch? I fixed this issue a week ago. Thanks, -- Ilya

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
Hi! Also, something that I believe has been discussed in the past, but can't find it on your wiki page nor in *.opt, are option overrides for the offloading target, i.e. some option you can pass to the host compiler driver during linking that will tell the driver for which offloading targets (if a

Re: [PATCH] PR lto/59441 Add initialization and release of bitmap obstack

2014-10-07 Thread Richard Biener
On Tue, Oct 7, 2014 at 2:55 PM, Ilya Palachev wrote: > Hi all, > > Attached patch fixes PR lto/59441. > The reason of failure was that the default bitmap obstack was released just > before the execution of early local passes. > The error was found using valgrind. It reported that there were 153 in

Re: [C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Richard Biener
On Tue, Oct 7, 2014 at 2:53 PM, Marek Polacek wrote: > PR59717 is a request for hints which header to include if the compiler warns > about incompatible implicit declarations. E.g., if one uses abort > without declaring it first, we now say > note: include ‘’ or provide a declaration of ‘abort’ >

[jit] Use the full name of the installed driver binary

2014-10-07 Thread David Malcolm
On Fri, 2014-09-26 at 21:55 +, Joseph S. Myers wrote: On Thu, 25 Sep 2014, David Malcolm wrote: > > > Should this have the $(exeext) suffix seen in Makefile.in? > > $(target_noncanonical)-gcc-$(version)$(exeext) > > Depends on whether that's needed for the pex code to find it. > > As for (B

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 05:51:53PM +0400, Ilya Verbin wrote: > On 07 Oct 15:06, Jakub Jelinek wrote: > > Still have issues with the non-installed testing. > > The idea was that the offload compiler should be installed. > > > If I add > > -B /usr/src/gcc-git/objinst/usr/local/lib/gcc/x86_64-pc-lin

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-07 Thread Siva Chandra
On Tue, Oct 7, 2014 at 4:05 AM, Mark Wielaard wrote: > To be honest my original patches for a deleted/defaulted markers on > special member functions was really just meant to give the consumer a > way to know why GCC produced a declaration in the first place. Which I > still think is useful inform

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Thomas Schwinge
Hi! On Tue, 7 Oct 2014 17:51:53 +0400, Ilya Verbin wrote: > On 07 Oct 15:06, Jakub Jelinek wrote: > > Still have issues with the non-installed testing. > > The idea was that the offload compiler should be installed. > > > If I add > > -B /usr/src/gcc-git/objinst/usr/local/lib/gcc/x86_64-pc-linu

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Ilya Verbin
On 07 Oct 15:06, Jakub Jelinek wrote: > Still have issues with the non-installed testing. The idea was that the offload compiler should be installed. > If I add > -B /usr/src/gcc-git/objinst/usr/local/lib/gcc/x86_64-pc-linux-gnu/5.0.0/ \ > -B /usr/src/gcc-git/objinst/usr/local/libexec/gcc/x86_64-

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-07 Thread Siva Chandra
On Mon, Oct 6, 2014 at 5:55 PM, Jason Merrill wrote: > On 10/06/2014 08:50 PM, Siva Chandra wrote: >> But, the question is whether it is required to determine the parameter >> passing ABI. If there is no special marker to indicate that the user >> declared 'tor is explicitly defaulted, then GDB co

Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework.

2014-10-07 Thread Christophe Lyon
On 1 October 2014 17:11, Marcus Shawcroft wrote: > On 30 September 2014 15:27, Christophe Lyon > wrote: >> On 10 July 2014 12:12, Marcus Shawcroft wrote: >>> On 1 July 2014 11:05, Christophe Lyon wrote: * documentation (README) * dejanu driver (neon-intrinsics.exp) * support mac

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
On Mon, Oct 06, 2014 at 07:53:17PM +0400, Ilya Verbin wrote: > This patch adds plugin support to libgomp, as well as memory mapping and > interaction with target devices through plugin's interface. Still have issues with the non-installed testing. ( mkdir objmic && cd objmic && ../configure --bu

[PATCH] PR lto/59441 Add initialization and release of bitmap obstack

2014-10-07 Thread Ilya Palachev
Hi all, Attached patch fixes PR lto/59441. The reason of failure was that the default bitmap obstack was released just before the execution of early local passes. The error was found using valgrind. It reported that there were 153 invalid reads and 173 invalid writes into the field of the defau

[C PATCH] Print header hints (PR c/59717)

2014-10-07 Thread Marek Polacek
PR59717 is a request for hints which header to include if the compiler warns about incompatible implicit declarations. E.g., if one uses abort without declaring it first, we now say note: include ‘’ or provide a declaration of ‘abort’ I've added hints only for standard functions which means we won

Re: RFA: Merge definitions of get_some_local_dynamic_name

2014-10-07 Thread Richard Sandiford
Richard Sandiford writes: > Rainer Orth writes: >> Hi Richard, >>> Rainer Orth writes: Hi Richard, >> It seems the new get_some_local_dynamic_name implementation in >> function.c lost the non-NULL check the sparc.c version had. I'm >> currently testing the following patch:

Re: [wwwdocs] Add feature-testing macros and std::is_final to gcc-5/changes.html

2014-10-07 Thread Jonathan Wakely
On 07/10/14 08:39 -0400, Ed Smith-Rowland wrote: OK, here is a patch for both using typename as a class key for template template parms and for __has_include, etc. Are these too wordy? They look OK to me, although you say "__has_include_next and __has_include_next" in both places, the first sh

Re: [wwwdocs] Add feature-testing macros and std::is_final to gcc-5/changes.html

2014-10-07 Thread Ed Smith-Rowland
On 10/02/2014 10:24 AM, Jonathan Wakely wrote: On 02/10/14 10:09 -0400, Ed Smith-Rowland wrote: On 10/02/2014 06:14 AM, Jonathan Wakely wrote: On 02/10/14 11:12 +0100, Jonathan Wakely wrote: Note Ed's recent changes. Committed to CVS. And fix a markup error that I expected xmllint to catch :

[wwwdocs] Update libstdc++ section of gcc-5/changes.html

2014-10-07 Thread Jonathan Wakely
Document the latest additions. ? gcc-5/.changes.html.swp Index: gcc-5/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.14 diff -u -u -r1.14 changes.html --- gcc-5/changes.html 2 Oct 2014

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Andrew Haley
On 10/07/2014 09:31 AM, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-linux, ok for trunk? OK, thanks. Andrew.

Re: [PATCH Fortran] move more diagnostics to the common machinery (try 2)

2014-10-07 Thread Tobias Burnus
Manuel López-Ibáñez wrote: > and of course, with -Werror=missing-include-dirs you get: > > f951: Error: Nonexistent include directory [...] > [-Werror=missing-include-dirs] > f951: some warnings being treated as errors > > plus colors! Awesome! > Bootstrapped and regression tested on x86_64-linu

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-07 Thread Mark Wielaard
On Mon, 2014-10-06 at 20:55 -0400, Jason Merrill wrote: > On 10/06/2014 08:50 PM, Siva Chandra wrote: > > On Sat, Oct 4, 2014 at 11:14 AM, Jason Merrill wrote: > >> On 10/03/2014 05:41 PM, Siva Chandra wrote: > >>> > >>> I understand that knowing whether a copy-ctor or a d-tor has been > >>> expli

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-07 Thread Dominik Vogt
On Mon, Oct 06, 2014 at 07:29:33AM -0700, Ian Lance Taylor wrote: > On Mon, Oct 6, 2014 at 12:42 AM, Dominik Vogt wrote: > > On s390[x] the symbol value of a section symbol is definitely not > > zero. > > Is true even in an object file? No. > I agree that in an executable a > section symbol wil

[PATCH] Fix PR ipa/61190, 2nd edition‏

2014-10-07 Thread Bernd Edlinger
Hi Honza, as you know, we have a wrong code bug, when a pure or const method is called via a virtual thunk. I had some more Ideas, how to fix that, but all of them had some serious draw-backs, so I leave the details out... But now I have a new insight, why the "obvious" fix for this serious c

Re: [PATCH] SPARC: add mcpu=leon3v7 target

2014-10-07 Thread Daniel Hellstrom
On 10/07/2014 11:07 AM, Eric Botcazou wrote: Ok, I will update that. Is there a way of generating the comments automatically? Do you mean the ChangeLog? If so, contrib/mklog will generate a skeleton but you'll still need to write the decription sentences. Perfect, thanks!

Re: [PATCH] SPARC: add mcpu=leon3v7 target

2014-10-07 Thread Eric Botcazou
> Ok, I will update that. Is there a way of generating the comments > automatically? Do you mean the ChangeLog? If so, contrib/mklog will generate a skeleton but you'll still need to write the decription sentences. -- Eric Botcazou

Re: [PATCH] SPARC: add mcpu=leon3v7 target

2014-10-07 Thread Daniel Hellstrom
On 10/07/2014 09:26 AM, Eric Botcazou wrote: You're right. I have attached an updated patch. The new code becomes: #ifdef HAVE_AS_LEON #define AS_LEON_FLAG "-Aleon" +#define AS_LEONV7_FLAG "-Aleon" #else #define AS_LEON_FLAG "-Av8" +#define AS_LEONV7_FLAG "-Av7" #endif The patch

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Marek Polacek
On Mon, Oct 06, 2014 at 11:00:48PM +0200, Mark Wielaard wrote: > On Mon, Oct 06, 2014 at 11:54:00AM +0200, Marek Polacek wrote: > > Java testsuite breaks with -std=gnu11 as a default and/or with > > -Wimplicit-function-declaration on, since the jvgenmain.c program > > that generates a C file conta

[Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Marek Polacek
[CCing java-patches now] Java testsuite breaks with -std=gnu11 as a default and/or with -Wimplicit-function-declaration on, since the jvgenmain.c program that generates a C file containing 'main' function which calls either 'JvRunMainName' or 'JvRunMain' does not generate forward declarations for

Re: [PATCH] Enhance array types debug info. for Ada

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 10:08:23AM +0200, Pierre-Marie de Rodat wrote: > >>gcc/fortran/ > >>* trans-types.c (gfc_get_array_descr_info): Use PLACEHOLDER_EXPR nodes > >>instead of VAR_DECL ones in type-related expressions. Remove base_decl > >>initialization. > > > >Ugh, I must say I don

Re: [PATCH] Indirect-call topn targets profiler (instrumentation)

2014-10-07 Thread Bernhard Reutner-Fischer
On 6 October 2014 22:31:18 CEST, Jan Hubicka wrote: >> >> Is it ok to commit these two patches now? > >Yes, it is OK, thanks! I do not see documentation of the new parameter added to doc in the ChangeLog? Also, I would not abbreviate "indir" in the param name. Thanks,

Re: [PING] Enhance array types debug info. for Ada

2014-10-07 Thread Pierre-Marie de Rodat
On 10/03/2014 06:41 PM, Jason Merrill wrote: Patches 1-4 are OK. + bool pell_conversions = true; I don't understand "pell". Do you mean "strip"? Absolutely: I though it was correct English. I replaced all occurences of "pell" with "strip". Updates patches will follow... Thank you very

Re: [PATCH] Enhance array types debug info. for Ada

2014-10-07 Thread Pierre-Marie de Rodat
Jakub, First, thank you very much for reviewing this set of patches. I think it's better to start with an answer to your last mail: On 10/03/2014 11:20 AM, Jakub Jelinek wrote: What kind of more complex expressions do you need and why? GNAT can produce array types that make sense only as par

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Andrew Haley
On 06/10/14 22:00, Mark Wielaard wrote: > If no java maintainer responds, try CCing java-patc...@gcc.gnu.org > to draw their attention. Please. I can't see the patch here. Andrew.

Re: [patch] Fix miscompilation of gnat1 in LTO bootstrap

2014-10-07 Thread Eric Botcazou
> Testcase? I think it would be better to handle this in the canonical type > merging code in lto.c - or how does it end up working without LTO? That is, > what does the Ada frontend do to make sure get_alias_set handles this > correctly? It manages the alias sets, see gcc-interface/utils.c:rela

Re: [patch] Turn 1 lra_assert into 1 gcc_assert

2014-10-07 Thread Eric Botcazou
> The docs on the asm_p flags say there is sth wrong with the asm constraints > so maybe better do > > if (!asm_p) >error_at (loc, ""); > > with an appropriate message and location? OK, I guess I can copy-and-paste reload1.c:spill_failure there. -- Eric Botcazou

Re: [patch] Work harder to find DECL_STRUCT_FUNCTION

2014-10-07 Thread Richard Biener
On Tue, Oct 7, 2014 at 9:43 AM, Eric Botcazou wrote: >> I wonder if this is worth abstracting into a callee_fn () cgraph edge >> method? > > That would rather be a cgraph node method without "callee" in the name since > we also apply it to callers, something like: > > struct function *cgraph_node:

Re: [PATCH 0/14+2][Vectorizer] Made reductions endianness-neutral, fixes PR/61114

2014-10-07 Thread Richard Biener
On Tue, Oct 7, 2014 at 9:45 AM, Richard Biener wrote: > On Mon, Oct 6, 2014 at 7:30 PM, Alan Lawrence wrote: >> Ok, so unless there are objections, I plan to commit patches 1, 2, 4, 5, and >> 6, >> which have been previously approved, in that sequence. (Of those, all bar >> patch >> 2 are AArch64

Re: [PATCH 0/14+2][Vectorizer] Made reductions endianness-neutral, fixes PR/61114

2014-10-07 Thread Richard Biener
On Mon, Oct 6, 2014 at 7:30 PM, Alan Lawrence wrote: > Ok, so unless there are objections, I plan to commit patches 1, 2, 4, 5, and > 6, > which have been previously approved, in that sequence. (Of those, all bar > patch > 2 are AArch64 only.) I think this is better than maintaining an > ever-expa

Re: [patch] Work harder to find DECL_STRUCT_FUNCTION

2014-10-07 Thread Eric Botcazou
> I wonder if this is worth abstracting into a callee_fn () cgraph edge > method? That would rather be a cgraph node method without "callee" in the name since we also apply it to callers, something like: struct function *cgraph_node::cfun (void) and the code in can_inline_edge_p would just be:

[PATCH][match-and-simplify] Change (match ...) syntax

2014-10-07 Thread Richard Biener
After internal discussion this changes (match logical_inverted_value (ne truth_valued_p@0 integer_onep) (if (INTEGRAL_TYPE_P (TREE_TYPE (@0))) (logical_inverted_value @0))) to (match (logical_inverted_value @0) (ne truth_valued_p@0 integer_onep) (if (INTEGRAL_TYPE_P (TREE_TYPE (@0) t

Re: [PATCH] SPARC: add mcpu=leon3v7 target

2014-10-07 Thread Eric Botcazou
> You're right. I have attached an updated patch. The new code becomes: > > #ifdef HAVE_AS_LEON > #define AS_LEON_FLAG "-Aleon" > +#define AS_LEONV7_FLAG "-Aleon" > #else > #define AS_LEON_FLAG "-Av8" > +#define AS_LEONV7_FLAG "-Av7" > #endif The patch is OK for all active branches (tru

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-07 Thread Dodji Seketeli
Jason Merrill writes: > On 10/06/2014 08:50 PM, Siva Chandra wrote: >> On Sat, Oct 4, 2014 at 11:14 AM, Jason Merrill wrote: >>> On 10/03/2014 05:41 PM, Siva Chandra wrote: I understand that knowing whether a copy-ctor or a d-tor has been explicitly defaulted is not sufficient to

Re: Fix libgomp crash without TLS (PR42616)

2014-10-07 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 08:44:59PM +0400, Varvara Rainchik wrote: > Ok, then here it is a new patch (tested and bootstrapped on linux). > > On linux with --disable-tls now all libgomp make check tests pass; for > Android I've patched toolchain and tried test from one of the > mentioned bugs, test