Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-21 Thread Maxim Kuvyrkov
On Oct 22, 2014, at 4:24 AM, Vladimir Makarov wrote: > On 10/20/2014 02:57 AM, Maxim Kuvyrkov wrote: >> Hi, >> >> This patch improves register pressure scheduling (both >> SCHED_PRESSURE_WEIGHTED and SCHED_PRESSURE_MODEL) to better estimate number >> of available registers. >> >> At the momen

Re: [PATCH] Fix and improve avx2 broadcasts (PR target/63594)

2014-10-21 Thread Uros Bizjak
On Tue, Oct 21, 2014 at 6:10 PM, Jakub Jelinek wrote: > Hi! > > This patch fixes a bunch of recent regressions: > FAIL: gcc.target/i386/avx-1.c (internal compiler error) > FAIL: gcc.target/i386/avx-1.c (test for excess errors) > FAIL: gcc.target/i386/avx-2.c (internal compiler error) > FAIL: gcc.t

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.21 at 15:31 -0700, Dehao Chen wrote: > Looks like the perf data type is incompatible with quipper (perf data > parser). Can you send me the perf.data file so that I can take a look. PERF_RECORD_MMAP2 (aka 10) was added in Linux 3.12 (commit 13d7a2410f). So your autofdo tool simply doesn

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-10-21 Thread Yangfei (Felix)
If the tripcount spill issue is not handled in the pattern, ICE may happen then. Here reload is trying to spill pseudo 173, but a memory operand is not allowed in zero_cost_loop_end pattern. And this is what I am trying to solve. pr44023.c:48:1: error: unable to generate reloads for: } ^ (j

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-10-21 Thread Yangfei (Felix)
Hi Sterling, Attached please find the testcase for the spill issue. Try it out with the patch :-) > > On Wed, Oct 15, 2014 at 7:10 PM, Yangfei (Felix) > wrote: > > Hi Sterling, > > > > Since the patch is delayed for a long time, I'm kind of pushing it. > > Sorry for > that. > > Y

Re: [PATCH] Improve i?86 address delegitimization after 32-bit pic changes (PR target/63542)

2014-10-21 Thread Jeff Law
On 10/21/14 16:03, Jakub Jelinek wrote: On Mon, Sep 29, 2014 at 01:08:56PM +0200, Jakub Jelinek wrote: I wonder if during/after reload we just couldn't look at ORIGINAL_REGNO of hard regs if ix86_use_pseudo_pic_reg. Or is that the other case, where you don't have any PIC register replacement ar

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2014-10-21 Thread Chen Gang
On 10/21/14 22:55, Chen Gang wrote: > On 09/25/2014 08:12 AM, Chen Gang wrote: >> OK, thanks, next month, I shall try Qemu for microblaze (I also focus on >> Qemu, and try to make patches for it). >> > > Excuse me, after tried upstream qemu, it cann't run microblaze correctly, > even for Xilinx q

Do not build soft-fp code at all for powerpc64-linux-gnu

2014-10-21 Thread Joseph S. Myers
When I added support for using soft-fp in libgcc , libgcc configuration was still done in the gcc/ directory, meaning that the variables set in makefile fragments could not depend on the multilib being built. Thus, building the soft-fp code

[committed] Change -mjump-in-delay option on PA to ignored

2014-10-21 Thread John David Anglin
The attached patch changes the -mjump-in-delay option to "Ignore" and removes the mask. Tested on hppa-unknown-linux-gnu with no regressions. Committed to trunk. Dave -- John David Anglin dave.ang...@bell.net 2014-10-21 John David Anglin * config.gcc: Remove MASK_JUMP_I

Re: [PING][PATCH] GCC/test: Set timeout factor for c11-atomic-exec-5.c

2014-10-21 Thread Maciej W. Rozycki
David, > >> > I thought http://gcc.gnu.org/ml/gcc-patches/2014-09/msg00242.html would > >> > be folded into PowerPC TARGET_ATOMIC_ASSIGN_EXPAND_FENV support, but I > >> > see > >> > r216437 went without it. In that case would someone please review my > >> > proposal as a separate change? > >> >

Re: [jit] Update the docs

2014-10-21 Thread Manuel López-Ibáñez
> IIRC, it took me several hours way back when to figure out how to just > run one specific testcase (as opposed to the whole suite), and I can > never remember the right incantation, so I wrote it up on the wiki page, > and now just go there when I find myself wondering the right incantation. Thi

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Dehao Chen
Looks like the perf data type is incompatible with quipper (perf data parser). Can you send me the perf.data file so that I can take a look. Thanks, Dehao On Tue, Oct 21, 2014 at 2:25 PM, Markus Trippelsdorf wrote: > On 2014.10.21 at 13:53 -0700, Dehao Chen wrote: >> Everything will be the same

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2014-10-21 Thread Ilya Verbin
2014-10-22 1:55 GMT+04:00 Joseph S. Myers : > On Tue, 21 Oct 2014, Ilya Verbin wrote: > >> +#include >> +#include "config.h" >> +#include "system.h" > > You should never include system headers before config.h because config.h > may define feature test macros such as _FILE_OFFSET_BITS=64 that are >

Re: The nvptx port [8/11+] Write undefined decls.

2014-10-21 Thread Bernd Schmidt
On 10/22/2014 12:05 AM, Jeff Law wrote: On 10/20/14 14:30, Bernd Schmidt wrote: ptx assembly requires that declarations are written for undefined variables. This adds that functionality. Does this need to happen at the use site, or can it be deferred? This is independent of use sites. The pat

Re: The nvptx port [7/11+] Inform the port about call arguments

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 11:53 PM, Jeff Law wrote: So, in the end I'm torn. I don't like adding new hooks when they're not needed, but I have some reservations about relying on the order of stuff in CALL_INSN_FUNCTION_USAGE and I worry a bit that you might end up with stuff other than arguments on that li

Re: The nvptx port [9/11+] Epilogues

2014-10-21 Thread Jeff Law
On 10/20/14 14:32, Bernd Schmidt wrote: We skip the late compilation passes on ptx, but there's one piece we do need - fixing up the function so that we get return insns in the right places. This patch just makes thread_prologue_and_epilogue_insns callable from the reorg pass. Bernd 009-proep.

Re: The nvptx port [8/11+] Write undefined decls.

2014-10-21 Thread Jeff Law
On 10/20/14 14:30, Bernd Schmidt wrote: ptx assembly requires that declarations are written for undefined variables. This adds that functionality. Bernd 008-undefdecl.diff gcc/ * target.def (assemble_undefined_decl): New hooks. * hooks.c (hook_void_FILEptr_constcharp

Avoid calls to realloc for nvptx

2014-10-21 Thread Bernd Schmidt
This is a followup patch for the nvptx port. Since malloc and free are magically provided by the ptx environment, but realloc is missing, it's nontrivial to provide an implementation for it. The Fortran frontend likes to generate calls to realloc, but in one case it seems like we can compute th

Re: [PATCH doc] Explain options precedence and difference between -pedantic-errors and -Werror=pedantic

2014-10-21 Thread Joseph S. Myers
On Tue, 21 Oct 2014, Manuel López-Ibáñez wrote: > On 19 October 2014 18:08, Joseph S. Myers wrote: > > On Sat, 18 Oct 2014, Manuel López-Ibáñez wrote: > > > >> What about this version? > >> > >> Give an error whenever the @dfn{base standard} (see @option{-Wpedantic}) > >> requires a diagnostic, i

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2014-10-21 Thread Joseph S. Myers
On Tue, 21 Oct 2014, Ilya Verbin wrote: > +#include > +#include "config.h" > +#include "system.h" You should never include system headers before config.h because config.h may define feature test macros such as _FILE_OFFSET_BITS=64 that are ineffective if defined after any system header is incl

Re: The nvptx port [7/11+] Inform the port about call arguments

2014-10-21 Thread Jeff Law
On 10/21/14 21:29, Bernd Schmidt wrote: A normal call looks like { .param.u32 %retval_in; .param.u64 %out_arg0; st.param.u64 [%out_arg0], %r1400; call (%retval_in), PopCnt, (%out_arg0); ld.param.u32%r1403, [%retval_in]; } which declares local variables for the args and retur

[PATCH/AARCH64] Move the rest of the cost tables to aarch64-cost-tables.h

2014-10-21 Thread Andrew Pinski
Hi, To make aarch64.c a little smaller and a little easier to understand, I have moved the rest of the cost tables (cpu_addrcost_table, cpu_regmove_cost, cpu_vector_cost) to aarch64-cost-tables. I also fixed up the inconstancy in the use of __extension__ on some of the structures and not all of t

Re: The nvptx port [1/11+] indirect jumps

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 11:30 PM, Jakub Jelinek wrote: At least for OpenMP, the best would be if the #pragma omp target regions and/or #pragma omp declare target functions contain anything a particular offloading accelerator can't handle, instead of failing the whole compilation perhaps just emit some at l

Re: The nvptx port [7/11+] Inform the port about call arguments

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 11:11 PM, Jeff Law wrote: On 10/20/14 14:29, Bernd Schmidt wrote: In ptx assembly we need to decorate call insns with the arguments that are being passed. We also need to know the exact function type. This is kind of hard to do with the existing infrastructure since things like fun

Re: The nvptx port [1/11+] indirect jumps

2014-10-21 Thread Jakub Jelinek
On Tue, Oct 21, 2014 at 11:00:35PM +0200, Bernd Schmidt wrote: > On 10/21/2014 08:26 PM, Jeff Law wrote: > >>* optabs.c (emit_indirect_jump): Test HAVE_indirect_jump and emit a > >>sorry if necessary. > >So doesn't this imply no hot-cold partitioning since we use indirect > >jumps to get ac

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.21 at 13:53 -0700, Dehao Chen wrote: > Everything will be the same on non-intel CPUs except for the perf command: > > perf record -e instructions -- your program. > > i.e. you need to drop "-b" and use instructions as event. > > Note that the current algorithm is tuned for accurate in

Re: [3/6] nvptx testsuite patches: stdio

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 09:01 PM, Mike Stump wrote: On Oct 21, 2014, at 7:17 AM, Bernd Schmidt wrote: Some tests use stdio functions which are unavaiable with the cut-down newlib I'm using for ptx testing. I'm somewhat uncertain what to do with these; they are by no means the only unavailable library fun

Re: The nvptx port [7/11+] Inform the port about call arguments

2014-10-21 Thread Jeff Law
On 10/20/14 14:29, Bernd Schmidt wrote: In ptx assembly we need to decorate call insns with the arguments that are being passed. We also need to know the exact function type. This is kind of hard to do with the existing infrastructure since things like function_arg are called at other times rathe

Re: [PATCH] Fix PR63266: Keep track of impact of sign extension in bswap

2014-10-21 Thread Christophe Lyon
Hi Thomas, Some minor comments: On 21 October 2014 11:28, Thomas Preud'homme wrote: > Hi Richard, > > I realized thanks to Christophe Lyon that a shift was not right: the shift > count > is a number of bytes instead of a number of bits. > > This extra patch fixes the problem. > > ChangeLog are

Re: The nvptx port [1/11+] indirect jumps

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 08:26 PM, Jeff Law wrote: * optabs.c (emit_indirect_jump): Test HAVE_indirect_jump and emit a sorry if necessary. So doesn't this imply no hot-cold partitioning since we use indirect jumps to get across the partition? Similarly doesn't this imply other missing features (se

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Dehao Chen
Everything will be the same on non-intel CPUs except for the perf command: perf record -e instructions -- your program. i.e. you need to drop "-b" and use instructions as event. Note that the current algorithm is tuned for accurate instruction level profile, which is not available on non-Intel C

Re: [PATCH 8/8] Use rank_for_schedule to as tie-breaker in model_order_p

2014-10-21 Thread Maxim Kuvyrkov
On Oct 22, 2014, at 9:24 AM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> On Oct 21, 2014, at 9:11 PM, Richard Sandiford >> wrote: >> >>> Maxim Kuvyrkov writes: This patch improves model_order_p to use non-reg-pressure version of rank_for_schedule when it needs to break the

Re: [PATCH 8/8] Use rank_for_schedule to as tie-breaker in model_order_p

2014-10-21 Thread Richard Sandiford
Maxim Kuvyrkov writes: > On Oct 21, 2014, at 9:11 PM, Richard Sandiford > wrote: > >> Maxim Kuvyrkov writes: >>> This patch improves model_order_p to use non-reg-pressure version of >>> rank_for_schedule when it needs to break the tie. At the moment it is >>> comparing INSN_PRIORITY by itself,

Re: [6/7] Random tweaks

2014-10-21 Thread Mike Stump
On Oct 21, 2014, at 10:46 AM, Marek Polacek wrote: > > I can remove the -w and fix C89/C11 incompatibilities, if anyone > thinks it's worth it. I’d leave the -w, no point in spending much time worrying about it. The -w is so that no one has to spend time worrying about it. If you want to fix

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.20 at 14:21 -0700, Dehao Chen wrote: > >> +If @var{path} is specified, GCC looks at the @var{path} to find > >> +the profile feedback data files. > >> + > >> +In order to collect AutoFDO profile, you need to have: > >> + > >> +1. A linux system with linux perf support > >> +2. An Intel p

Re: [jit] Add Sphinx to install.texi

2014-10-21 Thread David Malcolm
On Tue, 2014-10-21 at 18:15 +0200, Gerald Pfeifer wrote: > On Monday 2014-10-20 15:19, David Malcolm wrote: > > +@item Sphinx (any working version) > > As opposed to "any non-working version"? ;-) I'd just omit > "working" from this. FWIW, all my development has been with Sphinx 1.1.3, which is

Re: [3/6] nvptx testsuite patches: stdio

2014-10-21 Thread Mike Stump
On Oct 21, 2014, at 7:17 AM, Bernd Schmidt wrote: > Some tests use stdio functions which are unavaiable with the cut-down newlib > I'm using for ptx testing. I'm somewhat uncertain what to do with these; they > are by no means the only unavailable library functions the testsuite tries to > use

[jit] Update the docs

2014-10-21 Thread David Malcolm
On Wed, 2014-10-15 at 14:44 -0600, Jeff Law wrote: > On 10/15/14 10:56, David Malcolm wrote: > > On Tue, 2014-10-14 at 11:09 -0400, David Malcolm wrote: > >> On Mon, 2014-10-13 at 13:45 -0400, David Malcolm wrote: > >>> I'd like to merge the JIT branch into trunk: > >>>https://gcc.gnu.org/wiki/

Re: The nvptx port [6/11+] Pseudo call args

2014-10-21 Thread Jeff Law
On 10/20/14 14:26, Bernd Schmidt wrote: On ptx, we'll be using pseudos to pass function args as well, and there's one assert that needs to be toned town to make that work. Bernd 006-usereg.diff gcc/ * expr.c (use_reg_mode): Just return for pseudo registers. OK. I pondered

Re: The nvptx port [5/11+] Variable declarations

2014-10-21 Thread Jeff Law
On 10/20/14 14:25, Bernd Schmidt wrote: ptx assembly follows rather different rules than what's typical elsewhere. We need a new hook to add a " };" string when we are finished outputting a variable with an initializer. Bernd 005-declend.diff gcc/ * target.def (decl_end): Ne

Re: The nvptx port [4/11+] Post-RA pipeline

2014-10-21 Thread Jeff Law
On 10/20/14 14:24, Bernd Schmidt wrote: This stops most of the post-regalloc passes to be run if the target doesn't want register allocation. I'd previously moved them all out of postreload to the toplevel, but Jakub (I think) pointed out that the idea is not to run them to avoid crashes if reloa

Re: The nvptx port [3/11+] Struct returns

2014-10-21 Thread Jeff Law
On 10/20/14 14:22, Bernd Schmidt wrote: Even when returning a structure by passing an invisible reference, gcc still likes to set the return register to the address of the struct. This is undesirable on ptx where things like the return register have to be declared, and the function really returns

Re: The nvptx port [2/11+] No register allocation

2014-10-21 Thread Jeff Law
On 10/20/14 14:20, Bernd Schmidt wrote: Since it's a virtual target, I've chosen not to run register allocation. This is one of the patches necessary to make that work, it primarily adds a target hook to disable it and fixes some of the fallout. Bernd 002-noregalloc.diff gcc/

Re: [gomp4] c++ delete clause

2014-10-21 Thread Cesar Philippidis
On 10/20/2014 01:26 PM, Cesar Philippidis wrote: > On 10/20/2014 01:18 PM, Jakub Jelinek wrote: >> See how private or for clauses are handled earlier, you should >> not need to parse identifier to handle RID_DELETE as >> PRAGMA_OACC_CLAUSE_DELETE. > > I forgot about private being a keyword in c++

Re: The nvptx port [1/11+] indirect jumps

2014-10-21 Thread Jeff Law
On 10/20/14 14:19, Bernd Schmidt wrote: ptx doesn't have indirect jumps, so CODE_FOR_indirect_jump may not be defined. Add a sorry. Bernd 001-indjumps.diff gcc/ * optabs.c (emit_indirect_jump): Test HAVE_indirect_jump and emit a sorry if necessary. So doesn't this im

Re: [PATCH doc] Explain options precedence and difference between -pedantic-errors and -Werror=pedantic

2014-10-21 Thread Manuel López-Ibáñez
On 19 October 2014 18:08, Joseph S. Myers wrote: > On Sat, 18 Oct 2014, Manuel López-Ibáñez wrote: > >> What about this version? >> >> Give an error whenever the @dfn{base standard} (see @option{-Wpedantic}) >> requires a diagnostic, in cases where there is undefined behavior at >> compile-time >

Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c

2014-10-21 Thread jb999
"Jeff Law" : >On 10/21/14 16:13, Haswell wrote: >> The additional source must have the same requirement >> crossmodule-indircall-1.c has. >> >> * crossmodule-indircall-1a.c: Add missing requirement. >Why? When used by crossmodule-indircall-1.c we'll have already tested >the marker and when

PING: [PATCH diagnostics] PR 53061 cleanup initialization

2014-10-21 Thread Manuel López-Ibáñez
This is an old patch of mine that never got finished. I updated it following the suggestions of Gabriel here https://gcc.gnu.org/ml/gcc-patches/2012-04/msg00443.html In cp/error.c, I separate the initialization of the diagnostic context from the initialization of the scratch pretty-printer (cxx_pp

Re: [PATCH][AArch64]Update target testcases for gnu11

2014-10-21 Thread Mike Stump
On Oct 21, 2014, at 6:50 AM, Jiong Wang wrote: > Update testcases for recent gnu11 changes. > > ok for trunk? Ok.

Re: [PATCH][dejagnu] gcc-dg-prune glitch when filtering "relocation truncation" error

2014-10-21 Thread Jeff Law
On 10/21/14 14:07, Jiong Wang wrote: On 19/08/14 17:30, Mike Stump wrote: On Aug 19, 2014, at 6:12 AM, Kyrill Tkachov wrote: So how about this? Ok. Thanks. looks like this patch only fixed one invoke path. currently, "gcc-dg-prune" may be invoked directly *or* via ${tool}_check_compile:

Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c

2014-10-21 Thread Jeff Law
On 10/21/14 16:13, Haswell wrote: The additional source must have the same requirement crossmodule-indircall-1.c has. * crossmodule-indircall-1a.c: Add missing requirement. Why? When used by crossmodule-indircall-1.c we'll have already tested the marker and when used by itself, it doe

Re: RFA: Add libstdc++-v3 support for avr 5/7: libstdc++-v3 fix cross testing

2014-10-21 Thread Mike Stump
On Oct 21, 2014, at 9:02 AM, Joern Rennecke wrote: > The gdb version check ends up trying to invoke gdb on the target - > not so nice if your target is too small to accomodate gdb in the first place. So, I didn’t see anything that allowed it to work on targets that have gdb and can work. Turnin

Re: [patch] third basic-block restructure patch.

2014-10-21 Thread Jeff Law
On 10/21/14 17:04, Andrew MacLeod wrote: The last of the restructuring stuff before flattening basic-block.h. 5 new files, cfgbuild.h, cfgcleanup.h, cfgloopmanip.h, dominance.h, and ifcvt.h. MOstly prototypes, but a few enums, #defines and structs were more appropriately located. basic-block.h

Re: [PATCH 8/8] Use rank_for_schedule to as tie-breaker in model_order_p

2014-10-21 Thread Maxim Kuvyrkov
On Oct 21, 2014, at 9:11 PM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> This patch improves model_order_p to use non-reg-pressure version of >> rank_for_schedule when it needs to break the tie. At the moment it is >> comparing INSN_PRIORITY by itself, and it seems prudent to outsourc

Re: [6/7] Random tweaks

2014-10-21 Thread Marek Polacek
On Tue, Oct 21, 2014 at 06:48:55PM +0200, Jakub Jelinek wrote: > On Tue, Oct 21, 2014 at 03:32:31PM +, Jeff Law wrote: > > On 10/21/14 14:26, Bernd Schmidt wrote: > > >This tweaks a few tests so that we don't have to skip them. This is > > >mostly concerned with declaring main properly, or cha

Re: [PATCH 3/5] Pass an alternative_mask to constrain_operands

2014-10-21 Thread Jeff Law
On 10/17/14 14:51, Richard Sandiford wrote: After the previous patch there are cases where we want to constrain operands to any enabled alternative and cases where we want to also take size/speed preferences into account. The former applies when constraining an existing instruction (which might

Re: [PATCH 2/5] Add preferred_for_{size,speed} attributes

2014-10-21 Thread Jeff Law
On 10/17/14 14:48, Richard Sandiford wrote: This is the main patch, to add new preferred_for_size and preferred_for_speed attributes that can be used to selectively disable alternatives when optimising for size or speed. As explained in the docs, the new attributes are just optimisation hints an

[PATCH 3/4] Add libgomp plugin for Intel MIC

2014-10-21 Thread Ilya Verbin
Hello, This patch contains a plugin for libgomp and appropriate changes for makefiles. The plugin uses liboffloadmic_host.so to interact with the device (or with an emulator). Also the patch contains offload_target_main executable, which is the corresponding target side part of a libgomp plugin,

[PATCH 1/4] Add mkoffload for Intel MIC

2014-10-21 Thread Ilya Verbin
Hello, This patch contains mkoffload tool and the appropriate changes for makefiles. mkoffload is executed by lto-wrapper. It runs offload compiler, which produces a dynamic shared library for MIC (so far, it requires offload compiler to be installed). Then mkoffload copies the DSO into a new o

[PATCH 0/4] OpenMP 4.0 offloading to Intel MIC

2014-10-21 Thread Ilya Verbin
Hello, This patchset would contain target-specific things to support offloading to the devices with Intel MIC architecture. Particularly: mkoffload tool, liboffloadmic library and a plugin for libgomp. -- Ilya

[patch] third basic-block restructure patch.

2014-10-21 Thread Andrew MacLeod
The last of the restructuring stuff before flattening basic-block.h. 5 new files, cfgbuild.h, cfgcleanup.h, cfgloopmanip.h, dominance.h, and ifcvt.h. MOstly prototypes, but a few enums, #defines and structs were more appropriately located. basic-block.h only includes cfgbuild.h, cfgcleanup.

Re: [6/7] Random tweaks

2014-10-21 Thread Jakub Jelinek
On Tue, Oct 21, 2014 at 03:32:31PM +, Jeff Law wrote: > On 10/21/14 14:26, Bernd Schmidt wrote: > >This tweaks a few tests so that we don't have to skip them. This is > >mostly concerned with declaring main properly, or changing other > >declarations where the test does not seem to rely on the

Re: RFA: Add libstdc++-v3 support for avr 4/7: fix locale_facets_nonio overloading on struct tm using template

2014-10-21 Thread Joern Rennecke
On 21 October 2014 17:29, Jonathan Wakely wrote: >> +typedef typeof (((tm*)0)->tm_sec) __tm_small_int; > > > I think this should probably use __typeof__ to work with > -Wpedantic-errors Ok, makes sense, and it's a straightforward change. > >> +#else /* For 100% mangling compatibility, use int d

Re: [Patch, libstdc++/63497] Avoid dereferencing invalid iterator in regex_executor

2014-10-21 Thread Tim Shen
On Tue, Oct 21, 2014 at 3:25 AM, Jonathan Wakely wrote: > Did you manage to produce a testcase that crashed on trunk? Oh I forgot to mention that I've tried my best to make a testcase that crash the trunk, but failed :). I'm not sure if I should directly put an assert in the code and make a test

Re: [patch] Second basic-block.h restructuring patch.

2014-10-21 Thread Jiong Wang
On 21/10/14 17:30, Andrew MacLeod wrote: Try the following patch. Apparently missed because that target is not in contrib/config-list.mk and no other target must have enabled that code path. Seems to work now. checked in as obvious. verified OK, thanks. Regards, Jiong Andrew

Re: [patch] Second basic-block.h restructuring patch.

2014-10-21 Thread Andrew MacLeod
On 10/21/2014 11:48 AM, Jiong Wang wrote: bootstraps on x86_64-unknown-linux-gnu, and regressions are running... I expect no regressions because of the nature of the changes. OK to check in assuming everything is OK? Happen to start a fresh build ../gcc/configure --target=arm-none-linux-g

Re: RFA: Add libstdc++-v3 support for avr 4/7: fix locale_facets_nonio overloading on struct tm using template

2014-10-21 Thread Jonathan Wakely
On 21/10/14 16:53 +0100, Joern Rennecke wrote: libstdc++-v3: 2013-06-14 Joern Rennecke * include/bits/locale_facets_nonio.h (__tm_small_int): typedef/define. (_M_extract_num): Templatize base type of __member argument. (_M_extract_name): Change type of __member arg

Re: RFA: Add libstdc++-v3 support for avr 7/7: Add missing qualifier for size_t in a couple of libstdc++-v3 tests

2014-10-21 Thread Jonathan Wakely
On 21/10/14 17:09 +0100, Joern Rennecke wrote: A couple of tests fail because an unqualified size_t is used. 2014-09-15 Joern Rennecke * libstdc++-v3/testsuite/util/io/prog_bar.cc: Qualify size_t. * libstdc++-v3/testsuite/util/io/prog_bar.hpp: Likewise. * libstdc++-

Re: [jit] Add Sphinx to install.texi

2014-10-21 Thread Gerald Pfeifer
On Monday 2014-10-20 15:19, David Malcolm wrote: > +@item Sphinx (any working version) As opposed to "any non-working version"? ;-) I'd just omit "working" from this. Otherwise this looks good to me, except... > +Necessary to regenerate @file{jit/docs/_build/texinfo} from the .rst > +files in

[PATCH] Add missing requirement to crossmodule-indircall-1a.c

2014-10-21 Thread Haswell
The additional source must have the same requirement crossmodule-indircall-1.c has. * crossmodule-indircall-1a.c: Add missing requirement. diff -Nur a/gcc/testsuite/gcc.dg/tree-prof/crossmodule-indircall-1a.c b/gcc/testsuite/gcc.dg/tree-prof/crossmodule-indircall-1a.c --- a/gcc/testsuit

[PATCH] Fix and improve avx2 broadcasts (PR target/63594)

2014-10-21 Thread Jakub Jelinek
Hi! This patch fixes a bunch of recent regressions: FAIL: gcc.target/i386/avx-1.c (internal compiler error) FAIL: gcc.target/i386/avx-1.c (test for excess errors) FAIL: gcc.target/i386/avx-2.c (internal compiler error) FAIL: gcc.target/i386/avx-2.c (test for excess errors) FAIL: gcc.target/i386/av

RFA: Add libstdc++-v3 support for avr 7/7: Add missing qualifier for size_t in a couple of libstdc++-v3 tests

2014-10-21 Thread Joern Rennecke
A couple of tests fail because an unqualified size_t is used. 2014-09-15 Joern Rennecke * libstdc++-v3/testsuite/util/io/prog_bar.cc: Qualify size_t. * libstdc++-v3/testsuite/util/io/prog_bar.hpp: Likewise. * libstdc++-v3/testsuite/util/io/verified_cmd_line_input.hpp: Li

RFA: Add libstdc++-v3 support for avr 6/7: Run -frtti tests with -frtti

2014-10-21 Thread Joern Rennecke
We got a couple of tests that assume -frtti; this is the default for most targets, but not for avr. libstdc++-v3: 2013-09-24 Joern Rennecke * testsuite/18_support/type_info/hash_code.cc (dg-options): Add -frtti. * testsuite/20_util/shared_ptr/cons/unique_ptr_deleter_ref_2.cc

[PATCH] Improve i?86 address delegitimization after 32-bit pic changes (PR target/63542)

2014-10-21 Thread Jakub Jelinek
On Mon, Sep 29, 2014 at 01:08:56PM +0200, Jakub Jelinek wrote: > I wonder if during/after reload we just couldn't look at > ORIGINAL_REGNO of hard regs if ix86_use_pseudo_pic_reg. Or is that > the other case, where you don't have any PIC register replacement around, > and want to subtract somethin

RFA: Add libstdc++-v3 support for avr 5/7: libstdc++-v3 fix cross testing

2014-10-21 Thread Joern Rennecke
The gdb version check ends up trying to invoke gdb on the target - not so nice if your target is too small to accomodate gdb in the first place. I've added a check similar to the one in gdb-test to punt on non-native targets. libstdc++-v3: 2013-09-17 Joern Rennecke * testsuite/lib/gdb-

Go patch committed: Remove old hidden_fields_are_ok code

2014-10-21 Thread Ian Taylor
Back in December 2011 I changed the Go frontend to permit assigning structs with hidden fields (https://gcc.gnu.org/ml/gcc-patches/2011-12/msg00632.html). At the time the language change was somewhat experimental, so I left the old code. The language change has clearly stuck, and that old code is

Fix unresolved patterns in devirt-*.C testcases

2014-10-21 Thread Jan Hubicka
Hi, Richi pointed out to me that there are unresolved tests in devirt-*.C. This is fixed by this patch (one template needs update for missing unreachable function removal) Will commit it later tonight or tomorrow. Honza * g++.dg/ipa/devirt-42.C: Fix template. * g++.dg/ipa/devirt

Re: [PATCH 4/8] Disable max_issue when scheduling for register pressure

2014-10-21 Thread Vladimir Makarov
On 10/20/2014 11:21 PM, Maxim Kuvyrkov wrote: > Hi, > > This patch disables max_issue-based lookahead multipass scheduling when > register-pressure heuristics are active. The two approaches tend to undo > each others decisions and don't play well together. Yes, I am agree. > Currently this patch

RFA: Add libstdc++-v3 support for avr 4/7: fix locale_facets_nonio overloading on struct tm using template

2014-10-21 Thread Joern Rennecke
libstdc++-v3: 2013-06-14 Joern Rennecke * include/bits/locale_facets_nonio.h (__tm_small_int): typedef/define. (_M_extract_num): Templatize base type of __member argument. (_M_extract_name): Change type of __member argument to __tm_small_int&. * include/bits/loc

Re: [PATCH 3/8] Remove cached_first_cycle_multipass_dfa_lookahead and cached_issue_rate

2014-10-21 Thread Vladimir Makarov
On 10/20/2014 11:16 PM, Maxim Kuvyrkov wrote: > Hi, > > This patch cleans up (removes) cached_first_cycle_multipass_dfa_lookahead and > cached_issue_rate. > > These seem to be an artifact from the scheduler refactoring 10+ years ago. > They assume that dfa_lookahead and issue_rate can change mid

Re: [patch] Second basic-block.h restructuring patch.

2014-10-21 Thread Jiong Wang
On 20/10/14 19:21, Andrew MacLeod wrote: creates cfg.h, cfganal.h, lcm.h, and loop-unroll.h to house the prototypes for those .c files. cfganal.h also gets "struct edge_list" and "class control_dependences" definitions since that is where all the routines and manipulators are declared. loo

RFA: Add libstdc++-v3 support for avr 3/7: libstdc+-v3 avr configuration

2014-10-21 Thread Joern Rennecke
libstdc++-v3: 2013-06-14 Joern Rennecke * configure.ac [avr-*-*]: Don't use AC_LIBTOOL_DLOPEN. * crossconfig.m4: Add avr-*-* settings. * configure: Regenerate. Index: configure.ac === --- configure.ac

RFA: Add libstdc++-v3 support for avr 2/7: config/avr

2014-10-21 Thread Joern Rennecke
gcc: 2014-09-23 Joern Rennecke * config/avr/avr.h (LIBSTDCXX): Don't define. * config/avr/avr.c (TARGET_UNWIND_WORD_MODE): Define. (avr_unwind_word_mode): New function. * config/avr/avr.c (avr_asm_function_rodata_section): When merging something into

Re: [PATCH 1/5] Add recog_constrain_insn

2014-10-21 Thread Jeff Law
On 10/17/14 14:47, Richard Sandiford wrote: This patch just adds a new utility function called recog_constrain_insn, to go alongside the existing recog_constrain_insn_cached. Note that the extract_insn in lra.c wasn't used when checking is disabled. The function just moved on to the next instruc

Re: RFA: Add libstdc++-v3 support for avr 1/7: toplevel Makefile check-target-*

2014-10-21 Thread Joern Rennecke
On 21 October 2014 16:35, Joern Rennecke wrote: > Make can't 'build' check-c++ without rules for check-target-libgomp-c++ / > check-target-libitm-c++ > > This patch makes sure that there's at least a dummy rule available. Sorry - forgot to attach the patch - here it is: toplevel: 2014-09-15 Joe

Re: [PATCH] Improve scheduler dumps of ready list

2014-10-21 Thread Vladimir Makarov
On 10/20/2014 03:03 AM, Maxim Kuvyrkov wrote: > Hi, > > Following previous improvement to scheduler dumps that provided insight into > which heuristics in rank_for_schedule make most decisions, this patch adds > print outs that show the deciding reason for an instruction in the ready list > to b

RFA: Add libstdc++-v3 support for avr 1/7: toplevel Makefile check-target-*

2014-10-21 Thread Joern Rennecke
Make can't 'build' check-c++ without rules for check-target-libgomp-c++ / check-target-libitm-c++ This patch makes sure that there's at least a dummy rule available.

Re: [PATCH 3/5] Pass an alternative_mask to constrain_operands

2014-10-21 Thread Vladimir Makarov
On 10/17/2014 10:51 AM, Richard Sandiford wrote: > After the previous patch there are cases where we want to constrain > operands to any enabled alternative and cases where we want to also take > size/speed preferences into account. The former applies when > constraining an existing instruction (w

Re: [PATCH 4/5] Remove recog_data.enabled_alternatives

2014-10-21 Thread Jeff Law
On 10/17/14 14:52, Richard Sandiford wrote: After the previous patches, this one gets rid of recog_data.enabled_alternatives and its one remaining use. Richard gcc/ * recog.h (recog_data_d): Remove enabled_alternatives. * recog.c (extract_insn): Don't set it. * reload.c

Re: [7/7] nvptx testsuite patches: Return addresses

2014-10-21 Thread Jeff Law
On 10/21/14 14:29, Bernd Schmidt wrote: This tests for availability of return addresses in a number of tests. Bernd r422426.diff gcc/testsuite/ * lib/target-supports.exp (check_effective_target_return_address): New function. * gcc.c-torture/execute/20010122-1

Re: [2/6] nvptx testsuite patches: typed assembly

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 05:16 PM, Jeff Law wrote: On 10/21/14 14:15, Bernd Schmidt wrote: Since everything in ptx assembly is typed, K&R C is problematic. There are a number of testcases that call functions with the wrong number of arguments, or arguments of the wrong type. I've added a new feature, untyp

Re: [6/7] Random tweaks

2014-10-21 Thread Jeff Law
On 10/21/14 14:26, Bernd Schmidt wrote: This tweaks a few tests so that we don't have to skip them. This is mostly concerned with declaring main properly, or changing other declarations where the test does not seem to rely on the type mismatches. I've also included one example of changing a fun

Re: [4/6] nvptx testsuite patches: xfails and skips

2014-10-21 Thread Bernd Schmidt
On 10/21/2014 05:27 PM, Jeff Law wrote: More ptx tooling failures than I'd expect. I'll leave it up to you whether or not to push on NVidia to fix some of those failures. The timeouts seem particularly troublesome. All I can say is that we've reported them. Bernd

Re: [5/6] nvptx testsuite patches: jumps and labels

2014-10-21 Thread Jeff Law
On 10/21/14 14:23, Bernd Schmidt wrote: This deals with tests requiring indirect jumps (including tests using setjmp), label values, and nonlocal goto. A subset of these tests uses the NO_LABEL_VALUES macro, but it's not consistent across the testsuite. The feature test I wrote tests whether tha

Re: [4/6] nvptx testsuite patches: xfails and skips

2014-10-21 Thread Jeff Law
On 10/21/14 14:19, Bernd Schmidt wrote: Some things don't fit into nice categories that apply to a larger set of tests, or which are somewhat random like ptxas tool failures. For these I've added xfails and skips. Bernd ts-xfails.diff gcc/testsuite/ * lib/target-supports.exp

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-21 Thread Vladimir Makarov
On 10/20/2014 02:57 AM, Maxim Kuvyrkov wrote: > Hi, > > This patch improves register pressure scheduling (both > SCHED_PRESSURE_WEIGHTED and SCHED_PRESSURE_MODEL) to better estimate number > of available registers. > > At the moment the scheduler does not account for spills in the prologues and

[PATCHv5][PING^2] Vimrc config with GNU formatting

2014-10-21 Thread Yury Gribov
On 10/13/2014 02:26 PM, Yury Gribov wrote: On 10/02/2014 09:14 PM, Yury Gribov wrote: On 09/17/2014 09:08 PM, Yury Gribov wrote: > On 09/16/2014 08:38 PM, Yury Gribov wrote: >> Hi all, >> >> This is the third version of the patch. A list of changes since last >> version: >> * move config t

Re: [3/6] nvptx testsuite patches: stdio

2014-10-21 Thread Jeff Law
On 10/21/14 14:17, Bernd Schmidt wrote: Some tests use stdio functions which are unavaiable with the cut-down newlib I'm using for ptx testing. I'm somewhat uncertain what to do with these; they are by no means the only unavailable library functions the testsuite tries to use (signal is another e

Re: [2/6] nvptx testsuite patches: typed assembly

2014-10-21 Thread Jeff Law
On 10/21/14 14:15, Bernd Schmidt wrote: Since everything in ptx assembly is typed, K&R C is problematic. There are a number of testcases that call functions with the wrong number of arguments, or arguments of the wrong type. I've added a new feature, untyped_assembly, which these tests now requir

Re: [1/6] nvptx testsuite patches: alloca

2014-10-21 Thread Jeff Law
On 10/21/14 14:12, Bernd Schmidt wrote: This deals with uses of alloca in the testsuite. Some tests require it outright, others only at -O0, and others require it implicitly by requiring an alignment for stack variables bigger than the target's STACK_BOUNDARY. For the latter I've added explicit x

  1   2   >