Re: using scratchpads to enhance RTL-level if-conversion: the new patch is almost ready to be prepared for merging to trunk, but not 100% ready yet

2015-09-24 Thread Jeff Law
On 09/23/2015 06:11 PM, Abe wrote: The patch can pass the bootstrap stage2-to-stage3 comparison [same platform] *_if_* I prevent the "bootstrap-debug" value for BUILD_CONFIG from being automatically chosen, e.g. via "--with-build-config=bootstrap=time" during configuration. With the default

Re: [gomp4 5/8] libgomp: provide sem.h, mutex.h, ptrlock.h on nvptx

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:19PM +0300, Alexander Monakov wrote: > This patch provides minimal non-stub implementations for libgomp > mutex/ptrlock/semaphore, using atomic ops and busy waiting. The goal here is > to at least provide stub struct declarations necessary to unbreak libgomp.h. > >

Re: (patch,rfc) s/gimple/gimple */

2015-09-24 Thread Thomas Schwinge
Hi! On Sat, 19 Sep 2015 20:55:35 -0400, Trevor Saunders wrote: > On Fri, Sep 18, 2015 at 09:32:37AM -0600, Jeff Law wrote: > > On 09/18/2015 07:32 AM, Trevor Saunders wrote: > > >On Wed, Sep 16, 2015 at 03:11:14PM -0400, David Malcolm wrote: > > >>On Wed, 2015-09-16 at

Re: [ubsan PATCH] Fix uninitialized var issue (PR sanitizer/64906)

2015-09-24 Thread Marek Polacek
On Wed, Sep 23, 2015 at 08:55:53PM +0200, Bernd Schmidt wrote: > On 09/23/2015 06:07 PM, Marek Polacek wrote: > >Given that the code above seems to be useless now, I think let's put this > >patch in as-is, backport it to gcc-5, then remove those redundant hunks on > >trunk and add the testcase

Re: Openacc launch API

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 10:40 AM, Jakub Jelinek wrote: Iff GCC 5 compiled offloaded OpenACC/PTX code will always do host fallback anyway because of the incompatible PTX version, then why don't you just do goacc_save_and_set_bind (acc_device_host); fn (hostaddrs); goacc_restore_bind (); and

Re: Openacc launch API

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 11:56 AM, Jakub Jelinek wrote: On Thu, Sep 24, 2015 at 11:50:56AM +0200, Bernd Schmidt wrote: On 09/24/2015 10:40 AM, Jakub Jelinek wrote: Iff GCC 5 compiled offloaded OpenACC/PTX code will always do host fallback anyway because of the incompatible PTX version, then why don't you

Re: [PATCH 2/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 12:06 AM, Segher Boessenkool wrote: This is the meat of this series: a new algorithm to do basic block reordering. It uses the simple greedy approach to maximum weighted matching, where the weights are the predicted execution frequency of the edges. This always finds a solution

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 01:53 PM, Mark Wielaard wrote: Even if there are such constructs in header files and they aren't actually bugs or people are unwilling to fix the issue with something that is more idiomatic C then there are various ways to suppress the warning. Either just don't use

ARM: fp16 Fix PR 67624 - Incorrect conversion of float Infinity to __fp16

2015-09-24 Thread Richard Earnshaw
This patch fixes the bug reported in PR67624 where a single-precision infinity value was being incorrectly converted to a half-precision NaN value. Since we need to preserve the semantics of converting signaling NaNs to quiet NaNs, we test explicitly for this case. Built and tested on an arm-eabi

Re: [PATCH 3/4] bb-reorder: Add -freorder-blocks-algorithm= and wire it up

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 12:06 AM, Segher Boessenkool wrote: This adds an -freorder-blocks-algorithm=[simple|stc] flag, with "simple" as default. For -O2 and up (except -Os) it is switched to "stc" instead. Targets that never want STC can override this. This changes -freorder-blocks to be on at -O1 and

Re: [PATCH] Add new hooks ASM_OUTPUT_START_FUNCTION_HEADER ...

2015-09-24 Thread Bernd Schmidt
On 09/23/2015 04:48 PM, Dominik Vogt wrote: On Tue, Sep 22, 2015 at 01:56:15PM -0600, Jeff Law wrote: > Is there some good reason these aren't hooks? No, that was just inobservance. New version attached. Would it be preferrable to initialize the hooks with a NULL pointer and test the pointer

[PATCH] Fix PR67699, remove abstract origin streaming

2015-09-24 Thread Richard Biener
The following patch removes streaming of abstract origins into ltrans boundaries. This was introduced by rev. 201468 but I can't find the post of the change on the mailinglist and thus its reasoning. Fact is we never stream DECL_ABSTRACT_ORIGIN, so doing the abstract origin handling must have

Re: [PATCH, i386, AVX-512] Fix register name while checking for AVX-512VBMI presence.

2015-09-24 Thread Kirill Yukhin
On 24 Sep 11:20, Uros Bizjak wrote: > On Thu, Sep 24, 2015 at 11:07 AM, Kirill Yukhin > wrote: > > Hello Uroš, > > I've comitted (into main trunk) patch in the bottom which > > checks first bit of ecx (instead of ebx) to verify of > > AVX-512VBMI presents on the system

Re: Openacc launch API

2015-09-24 Thread Jakub Jelinek
On Thu, Sep 24, 2015 at 11:50:56AM +0200, Bernd Schmidt wrote: > On 09/24/2015 10:40 AM, Jakub Jelinek wrote: > >Iff GCC 5 compiled offloaded OpenACC/PTX code will always do host fallback > >anyway because of the incompatible PTX version, then why don't you just > >do > > goacc_save_and_set_bind

Re: [PATCH 0/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 12:06 AM, Segher Boessenkool wrote: The current basic block reordering always uses the "software trace cache" algorithm. That has a few problems: 1) It increases code size substantially; this makes it not suitable for -O1 or -Os, and not at all for some architectures; 2) but it

Re: [AArch64] Fix Prefetch ICE

2015-09-24 Thread Marcus Shawcroft
On 24 September 2015 at 07:47, Hurugalawadi, Naveen wrote: > Hi, > > Please find attached the patch that fixes an ICE for prefetch. > > The predicate is too lose for the constraints. Hence, the patch tightens > up the predicate to be exactly as constraint

[PATCH, fortran] Revival of AUTOMATIC patch

2015-09-24 Thread Jim MacArthur
Hi all, I'm following up on some old work my colleague Mark Doffman did to try and get support for the AUTOMATIC keyword into trunk. In the enclosed patch I've addressed the problem with it accepting 'automatic' outside -std=gnu (it will now only accept AUTOMATIC under -std=gnu or -std=legacy).

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-24 Thread Mark Wielaard
On Wed, 2015-09-23 at 12:25 -0600, Jeff Law wrote: > On 09/18/2015 08:29 PM, Martin Sebor wrote: > >> I guess it is not the 'const' I think should be handled special but the > >> 'static'. Having unused static variables (const or not) declared in a > >> header file but unused seems reasonable

Re: [PATCH] Don't create superfluous parm in expand_omp_taskreg

2015-09-24 Thread Thomas Schwinge
Hi Tom! On Tue, 11 Aug 2015 20:53:39 +0200, Tom de Vries wrote: > [ was: Re: [committed, gomp4] Fix release_dangling_ssa_names ] > > On 05/08/15 13:13, Richard Biener wrote: > > On Wed, 5 Aug 2015, Tom de Vries wrote: > > > >> On 05/08/15 11:30, Richard Biener wrote: >

[AArch64] Fix Prefetch ICE

2015-09-24 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch that fixes an ICE for prefetch. The predicate is too lose for the constraints. Hence, the patch tightens up the predicate to be exactly as constraint allows, avoids a “reload” and allows better code generation.   Submitted on behalf of Andrew Pinski. Thanks,

Re: [gomp4 0/8] NVPTX: initial OpenMP offloading

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 11:24:16PM +0300, Alexander Monakov wrote: > > These patches provide stub functionality, which > > is easy enough, but I can't tell whether there's a credible plan to provide > > a > > full implementation. GPUs really need a different programming model than > > normal

Re: [gomp4 1/8] nvptx: remove assumption of OpenACC attrs presence

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:15PM +0300, Alexander Monakov wrote: > This patch makes one OpenACC-specific path in nvptx_record_offload_symbol > optional. > > * config/nvptx/nvptx.c (nvptx_record_offload_symbol): Allow missing > OpenACC attributes. LGTM, but as it is a nvptx

Re: [PATCH] Don't create superfluous parm in expand_omp_taskreg

2015-09-24 Thread Tom de Vries
On 24/09/15 08:23, Thomas Schwinge wrote: Hi Tom! On Tue, 11 Aug 2015 20:53:39 +0200, Tom de Vries wrote: Don't create superfluous parm in expand_omp_taskreg 2015-08-11 Tom de Vries * omp-low.c (expand_omp_taskreg): If in ssa, set

Re: [gomp4 6/8] libgomp: provide stub bar.h on nvptx

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:20PM +0300, Alexander Monakov wrote: > This stub header only provides empty struct gomp_barrier_t. For now I've > punted on providing a minimally-correct implementation. > > * config/nvptx/bar.h: New file. > --- > libgomp/config/nvptx/bar.h | 38

Re: [RFC] Try vector as a new representation for vector masks

2015-09-24 Thread Richard Biener
On Wed, Sep 23, 2015 at 8:44 PM, Richard Henderson wrote: > On 09/23/2015 06:53 AM, Richard Biener wrote: >> I think independent improvements are >> >> 1) remove (most) of the bool patterns from the vectorizer >> >> 2) make VEC_COND_EXPR not have a GENERIC comparison embedded

Re: CSE pass prevents loop-invariant motion

2015-09-24 Thread Robin Dapp
On 09/15/2015 05:25 PM, Jeff Law wrote: > On 09/15/2015 06:11 AM, Robin Dapp wrote: >> Hi, >> >> recently, I came across a problem that keeps a load instruction in a >> loop although it is loop-invariant. [..] > You might want to check your costing model -- cprop is supposed to look > at costs to

Re: [gomp4 7/8] libgomp: work around missing pthread_attr_t on nvptx

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:21PM +0300, Alexander Monakov wrote: > Although newlib headers define most pthreads types, pthread_attr_t is not > available. Macro-replace it by 'void' to keep the prototype of > gomp_init_thread_affinity unchanged, and do not declare gomp_thread_attr. > > *

Re: [gomp4 8/8] libgomp: provide ICVs via env.c on nvptx

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:22PM +0300, Alexander Monakov wrote: > This patch ports env.c to NVPTX. It drops all environment parsing routines > since there's no "environment" on the device. For now, the useful effect of > the patch is providing 'omp_is_initial_device' to distinguish host

Re: [PATCH 0/5] RFC: Overhaul of diagnostics (v2)

2015-09-24 Thread Richard Biener
On Thu, Sep 24, 2015 at 2:25 AM, David Malcolm wrote: > On Wed, 2015-09-23 at 15:36 +0200, Richard Biener wrote: >> On Wed, Sep 23, 2015 at 3:19 PM, Michael Matz wrote: >> > Hi, >> > >> > On Tue, 22 Sep 2015, David Malcolm wrote: >> > >> >> The drawback is that

Re: [PATCH] update a few places for the change from gimple_statement_base to gimple

2015-09-24 Thread Richard Biener
On Thu, Sep 24, 2015 at 4:25 AM, wrote: > From: Trevor Saunders > > Hi, > > This fixes up a few remaining references to gimple_statement_base that were > just brought up. > > bootstrapped on x86_64-linux-gnu, but the only non comment / doc

Re: [gomp4 2/8] nvptx mkoffload: do not restrict to OpenACC

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:16PM +0300, Alexander Monakov wrote: > This patch allows to meaningfully invoke mkoffload with -fopenmp. The check > for -fopenacc flag is specific to gomp4 branch: trunk does not have it. > > * config/nvptx/mkoffload.c (main): Do not check for -fopenacc. >

Re: [gomp4 4/8] libgomp: minimal OpenMP support in plugin-nvptx.c

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:18PM +0300, Alexander Monakov wrote: > This is a minimal patch for NVPTX OpenMP offloading, using Jakub's initial > implementation. It allows to successfully run '#pragma omp target', without > any parallel execution: 1 team of 1 thread is spawned on the device, and

Re: [gomp4 3/8] libgomp: provide target-to-host fallback diagnostic

2015-09-24 Thread Jakub Jelinek
On Wed, Sep 23, 2015 at 08:22:17PM +0300, Alexander Monakov wrote: > This patch allows to see when target regions are executed on host with > GOMP_DEBUG=1 in the environment. > > * target.c (GOMP_target): Use gomp_debug on fallback path. > --- > libgomp/target.c | 1 + > 1 file changed, 1

Re: [PATCH] Don't create superfluous parm in expand_omp_taskreg

2015-09-24 Thread Thomas Schwinge
Hi Tom! On Thu, 24 Sep 2015 08:36:27 +0200, Tom de Vries wrote: > On 24/09/15 08:23, Thomas Schwinge wrote: > > On Tue, 11 Aug 2015 20:53:39 +0200, Tom de Vries > > wrote: > >> Don't create superfluous parm in expand_omp_taskreg > >> > >>

Re: [build] Support PIE on Solaris

2015-09-24 Thread Rainer Orth
Rainer Orth writes: > Beyond the reasons for the bundled Solaris CRTs already cited in > > https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01638.html > > they need to be PIC to support position independent executables (PIE). > > While linker support for PIE has

Re: Openacc launch API

2015-09-24 Thread Jakub Jelinek
On Fri, Sep 18, 2015 at 11:13:03AM +0200, Bernd Schmidt wrote: > On 09/17/2015 04:40 PM, Nathan Sidwell wrote: > > >Added call to gomp_fatal, indicating libgomp is out of date. Also added > >a default to the switch following with the same effect. The trouble > >with implementing handling of

Re: [RS6000] Don't pass --oformat to ld

2015-09-24 Thread Alan Modra
On Thu, Sep 24, 2015 at 02:24:25PM +1000, Michael Ellerman wrote: > On Wed, 2015-09-02 at 11:05 +0930, Alan Modra wrote: > > bugzilla.redhat.com/show_bug_cgi?id=1255946 shows that gcc built with > > both powerpc64-linux and powerpc64le-linux support passes wrong linker > > options when trying to

Re: libgo patch committed: rewrite lfstack to look more like gc code

2015-09-24 Thread Rainer Orth
This patch broke Solaris/x86 bootstrap: the amd64 lfstack.goc fails to compile: $ /bin/ksh ./libtool --tag=CC --mode=compile /var/gcc/gcc-6.0.0-20150924/12-gcc/./gcc/xgcc -B/var/gcc/gcc-6.0.0-20150924/12-gcc/./gcc/ -B/usr/local/i386-pc-solaris2.12/bin/ -B/usr/local/i386-pc-solaris2.12/lib/ -

Re: [C++ Patch] PR 53856

2015-09-24 Thread Jason Merrill
On 09/22/2015 03:31 PM, Paolo Carlini wrote: msg = G_("default template arguments may not be used in " "partial specializations"); + else if (current_class_type && !CLASSTYPE_IS_TEMPLATE (current_class_type)) +/* Per [temp.param]/9, "A default template-argument shall not

Re: [PATCH 2/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Segher Boessenkool
On Thu, Sep 24, 2015 at 12:32:59PM +0200, Bernd Schmidt wrote: > On 09/24/2015 12:06 AM, Segher Boessenkool wrote: > >This is the meat of this series: a new algorithm to do basic block > >reordering. It uses the simple greedy approach to maximum weighted > >matching, where the weights are the

[PATCH][committed] Fix aarch64/target_attr_10.c test following r227997

2015-09-24 Thread Szabolcs Nagy
gcc commit r227997 https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01455.html changed "error:" to "note:" for "called from here" messages, but missed adjusting an aarch64 target test. committed as obvious. gcc/testsuite/ChangeLog: 2015-09-24 Szabolcs Nagy *

Re: fdiagnostics-color=never does not disable color for some diagnostics

2015-09-24 Thread Jason Merrill
On 09/22/2015 04:23 PM, Manuel López-Ibáñez wrote: +error_at (loc, "-Werror=%s: no option -%s", arg, new_option); + else if (!(cl_options[option_index].flags & CL_WARNING)) +error_at (loc, "-Werror=%s: -%s is not an option that controls warnings", Won't these incorrectly start with

Re: [gomp4 8/8] libgomp: provide ICVs via env.c on nvptx

2015-09-24 Thread Alexander Monakov
On Thu, 24 Sep 2015, Jakub Jelinek wrote: > On Wed, Sep 23, 2015 at 08:22:22PM +0300, Alexander Monakov wrote: > > This patch ports env.c to NVPTX. It drops all environment parsing routines > > since there's no "environment" on the device. For now, the useful effect of > > the patch is

Re: libgo patch committed: rewrite lfstack to look more like gc code

2015-09-24 Thread Rainer Orth
Hi Ian, >> cc1: all warnings being treated as errors >> make: *** [lfstack.lo] Error 1 > > Bother. Sorry about that. Should be fixed with this patch. > Committed to mainline. compiles again, thanks. I just lost it in the maze of ifdefs... Rainer --

Re: [PATCH 3/4] bb-reorder: Add -freorder-blocks-algorithm= and wire it up

2015-09-24 Thread Segher Boessenkool
On Thu, Sep 24, 2015 at 12:28:08PM +0200, Bernd Schmidt wrote: > On 09/24/2015 12:06 AM, Segher Boessenkool wrote: > >This adds an -freorder-blocks-algorithm=[simple|stc] flag, with "simple" > >as default. For -O2 and up (except -Os) it is switched to "stc" instead. > >Targets that never want STC

[hsa] Gridification via whole construct nest cloning

2015-09-24 Thread Martin Jambor
Hi, this is a rewrite of a major portion of gridification code. The previous, loop-only copying quickly proved to be just too hacky. The new method uses already existing copy_gimple_seq_and_replace_locals to copy the whole nest including the parallel and possibly teams and distribute statements

Re: [PATCH 0/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Segher Boessenkool
On Thu, Sep 24, 2015 at 11:56:22AM +0200, Bernd Schmidt wrote: > On 09/24/2015 12:06 AM, Segher Boessenkool wrote: > >The current basic block reordering always uses the "software trace cache" > >algorithm. That has a few problems: > > > >1) It increases code size substantially; this makes it not

Re: libgo patch committed: rewrite lfstack to look more like gc code

2015-09-24 Thread Ian Lance Taylor
it for arm64. >> Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. >> Committed to mainline. > > This patch broke Solaris/x86 bootstrap: the amd64 lfstack.goc fails to > compile: > > $ /bin/ksh ./libtool --tag=CC --mode=compile > /var/gcc/gcc-6.0.0-201509

Re: [RS6000] Don't pass --oformat to ld

2015-09-24 Thread David Edelsohn
On Thu, Sep 24, 2015 at 8:54 AM, Alan Modra wrote: > On Thu, Sep 24, 2015 at 02:24:25PM +1000, Michael Ellerman wrote: >> On Wed, 2015-09-02 at 11:05 +0930, Alan Modra wrote: >> > bugzilla.redhat.com/show_bug_cgi?id=1255946 shows that gcc built with >> > both powerpc64-linux and

Re: [gomp4 8/8] libgomp: provide ICVs via env.c on nvptx

2015-09-24 Thread Jakub Jelinek
On Thu, Sep 24, 2015 at 04:15:28PM +0300, Alexander Monakov wrote: > Definitely, thanks for the suggestion! While implementing that, I considered > that it should be more natural to keep only env processing in env.c, and split > device-related functionality in another file, icv-device.c. That

Re: [PATCH] Add new hooks ASM_OUTPUT_START_FUNCTION_HEADER ...

2015-09-24 Thread Dominik Vogt
On Thu, Sep 24, 2015 at 12:41:24PM +0200, Bernd Schmidt wrote: > On 09/23/2015 04:48 PM, Dominik Vogt wrote: > >On Tue, Sep 22, 2015 at 01:56:15PM -0600, Jeff Law wrote: > Is > >there some good reason these aren't hooks? > > > >No, that was just inobservance. New version attached. Would it be >

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-24 Thread Ilya Enkovich
2015-09-15 14:01 GMT+03:00 Ilya Enkovich : > 2015-09-15 13:32 GMT+03:00 Richard Biener : >> On Tue, Sep 15, 2015 at 11:28 AM, Ilya Enkovich >> wrote: >> >> I see. I wonder why we even call chkp_find_bound_slots if

Re: [gomp4 0/8] NVPTX: initial OpenMP offloading

2015-09-24 Thread Nathan Sidwell
On 09/24/15 03:21, Jakub Jelinek wrote: So I'd like to ask Thomas/Nathan if they are ok with this stuff being on the gomp-4_0-branch for now, once all the prerequisities it needs are on the trunk, it can go into its own branch. Let Thomas & I think about it. Now that the new launch API is

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-24 Thread Richard Biener
On Thu, Sep 24, 2015 at 4:07 PM, Ilya Enkovich wrote: > 2015-09-15 14:01 GMT+03:00 Ilya Enkovich : >> 2015-09-15 13:32 GMT+03:00 Richard Biener : >>> On Tue, Sep 15, 2015 at 11:28 AM, Ilya Enkovich

Re: [PATCH 2/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Segher Boessenkool
On Thu, Sep 24, 2015 at 08:39:30AM -0500, Segher Boessenkool wrote: > > Any thoughts on this vs qsort? Do you need a stable sort? > > We always need stable sorts in GCC; things are not reproducible across > targets with qsort (not every qsort is the same). s/targets/hosts/

Re: fdiagnostics-color=never does not disable color for some diagnostics

2015-09-24 Thread Jason Merrill
On 09/24/2015 11:32 AM, Manuel López-Ibáñez wrote: On 24 September 2015 at 15:06, Jason Merrill wrote: On 09/22/2015 04:23 PM, Manuel López-Ibáñez wrote: +error_at (loc, "-Werror=%s: no option -%s", arg, new_option); + else if (!(cl_options[option_index].flags &

Re: [PATCH 3/4] bb-reorder: Add -freorder-blocks-algorithm= and wire it up

2015-09-24 Thread Andi Kleen
Segher Boessenkool writes: > > In effect, the changes are for -O1 (which now gets "simple" instead of > nothing), -Os (which now gets "simple" instead of "stc", since STC results > in much bigger code), and for targets that wish to never use STC (not in > this patch

Re: [PATCH 3/4] bb-reorder: Add -freorder-blocks-algorithm= and wire it up

2015-09-24 Thread Segher Boessenkool
On Thu, Sep 24, 2015 at 08:12:55AM -0700, Andi Kleen wrote: > Segher Boessenkool writes: > > > > In effect, the changes are for -O1 (which now gets "simple" instead of > > nothing), -Os (which now gets "simple" instead of "stc", since STC results > > in much bigger

[PATCH] Clear variables with stale SSA_NAME_RANGE_INFO (PR tree-optimization/67690)

2015-09-24 Thread Marek Polacek
As Richi said in , using recorded SSA name range infos in VRP is likely to expose errors in the ranges. This PR is such a case. As discussed in the PR, after tail merging via PRE the range infos cannot be relied upon anymore, so we need

Re: [PATCH 1/4] bb-reorder: Split out STC

2015-09-24 Thread Steven Bosscher
On Thu, Sep 24, 2015 at 12:06 AM, Segher Boessenkool wrote: > This first patch simply factors code a little bit. > > > 2015-09-23 Segher Boessenkool > > * bb-reorder.c (reorder_basic_blocks_software_trace_cache): New > function, factored out from ...

Re: [gomp4 7/8] libgomp: work around missing pthread_attr_t on nvptx

2015-09-24 Thread Alexander Monakov
> I'd prefer here the https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01418.html > changes to libgomp.h and associated configury changes. OK, like the following? [gomp4] libgomp: guard pthreads usage by LIBGOMP_USE_PTHREADS This allows to avoid referencing pthread types and functions on nvptx.

Re: fdiagnostics-color=never does not disable color for some diagnostics

2015-09-24 Thread Manuel López-Ibáñez
On 24 September 2015 at 15:06, Jason Merrill wrote: > On 09/22/2015 04:23 PM, Manuel López-Ibáñez wrote: >> >> +error_at (loc, "-Werror=%s: no option -%s", arg, new_option); >> + else if (!(cl_options[option_index].flags & CL_WARNING)) >> +error_at (loc, "-Werror=%s:

[patch] libstdc++/67707 Leave moved-from std::deque in a valid state

2015-09-24 Thread Jonathan Wakely
Apparently when adding allocator propagation to std::deque I didn't read my own comment in this constructor: _Deque_base(const allocator_type& __a) : _M_impl(__a) { /* Caller must initialize map. */ } This adds the missing initialization. Tested ppc64le-linux, committed to

Re: [gomp4 7/8] libgomp: work around missing pthread_attr_t on nvptx

2015-09-24 Thread Jakub Jelinek
On Thu, Sep 24, 2015 at 06:18:10PM +0300, Alexander Monakov wrote: > > I'd prefer here the https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01418.html > > changes to libgomp.h and associated configury changes. > > OK, like the following? > > [gomp4] libgomp: guard pthreads usage by

[gomp4] Merge trunk r228054 (2015-09-23) into gomp-4_0-branch

2015-09-24 Thread Thomas Schwinge
Hi! Committed to gomp-4_0-branch in r228091: commit 25dd642bd78afedeb6f94c98ed4fe767133b65ec Merge: a203723 3bf38a0 Author: tschwinge Date: Thu Sep 24 16:00:49 2015 + svn merge -r 226769:228054 svn+ssh://gcc.gnu.org/svn/gcc/trunk

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-24 Thread Steve Ellcey
On Thu, 2015-09-24 at 13:56 +0200, Bernd Schmidt wrote: > I think at this point we have reports of just two packages generating > extra warnings, with the warnings at least justifiable in both cases. So > my vote would be to leave things as-is for now and see if more reports > come in. It is

Re: [RFC] Try vector as a new representation for vector masks

2015-09-24 Thread Richard Henderson
On 09/24/2015 01:09 AM, Richard Biener wrote: > Both are basically a (target) restriction on how we should expand a > conditional > move (and its condition). It's techincally convenient to tie both together by > having them in the same statement but it's also techincally very incovenient > in

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread Richard Henderson
On 09/23/2015 07:39 PM, David Edelsohn wrote: > Richard and Richard, > > Appended is the updated version of the DWARF support patch for AIX. I > still can split out the length computation into a separate helper > function, but, as I mentioned, it won't apply to the instance that > uses a delta

Re: [PATCH 2/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Steven Bosscher
On Thu, Sep 24, 2015 at 12:06 AM, Segher Boessenkool wrote: > + /* First, collect all edges that can be optimized by reordering blocks: > + simple jumps and conditional jumps, as well as the function entry edge. > */ > + > + int n = 0; > + edges[n++] = EDGE_SUCC (ENTRY_BLOCK_PTR_FOR_FN

Re: [ubsan PATCH] Fix uninitialized var issue (PR sanitizer/64906)

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 11:32 AM, Marek Polacek wrote: On Wed, Sep 23, 2015 at 08:55:53PM +0200, Bernd Schmidt wrote: On 09/23/2015 06:07 PM, Marek Polacek wrote: Given that the code above seems to be useless now, I think let's put this patch in as-is, backport it to gcc-5, then remove those redundant

Re: [PATCH 2/4] bb-reorder: Add the "simple" algorithm

2015-09-24 Thread Segher Boessenkool
On Thu, Sep 24, 2015 at 06:03:33PM +0200, Steven Bosscher wrote: > On Thu, Sep 24, 2015 at 12:06 AM, Segher Boessenkool wrote: > > + /* First, collect all edges that can be optimized by reordering blocks: > > + simple jumps and conditional jumps, as well as the function entry > > edge. */ >

[gomp4.1] Doacross library implementation

2015-09-24 Thread Jakub Jelinek
Hi! This patch implements DOACROSS in the library, so far only as busy waiting and even without exponential (or some guess based on distance) backoff. Torvald, can you please have a look at it, if I got all the atomics / memory models right? The testcase obviously is not a good benchmark, we'll

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread David Edelsohn
>> + else if (TARGET_XCOFF && GET_CODE (x) == SYMBOL_REF >> + && SYMBOL_REF_TLS_MODEL (x) != 0) >> +{ >> + if (SYMBOL_REF_TLS_MODEL (x) == TLS_MODEL_LOCAL_EXEC) >> + fputs ("@le", file); >> + else if (SYMBOL_REF_TLS_MODEL (x) == TLS_MODEL_INITIAL_EXEC) >> +

Re: New power of 2 hash policy

2015-09-24 Thread François Dumont
On 11/09/2015 15:23, Jonathan Wakely wrote: > On 11/09/15 14:18 +0100, Jonathan Wakely wrote: >> On 11/09/15 15:11 +0200, Michael Matz wrote: >>> Hi, >>> >>> On Thu, 10 Sep 2015, François Dumont wrote: >>> Here is a patch to offer an alternative hash policy. This one is using power of

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread David Edelsohn
On Thu, Sep 24, 2015 at 2:49 PM, Richard Henderson wrote: > On 09/24/2015 11:40 AM, David Edelsohn wrote: >> Good news: AIX added support for the initially missing DWARF sections. > > Yay! > >> Bad news: The support is in an AIX service pack whose presence on a >> system requires

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread Richard Henderson
On 09/24/2015 11:40 AM, David Edelsohn wrote: > Good news: AIX added support for the initially missing DWARF sections. Yay! > Bad news: The support is in an AIX service pack whose presence on a > system requires effort to determine. Boo! Well, we've had worse problems with Solaris in the past.

Re: [PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-24 Thread pinskia
> On Sep 24, 2015, at 10:16 AM, Teresa Johnson wrote: > > This patch unsets -freorder-blocks-and-partition when -fprofile-use > is not specified. Function splitting was not actually being performed > in that case, as probably_never_executed_bb_p does not distinguish > any

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread Richard Henderson
On 09/24/2015 12:02 PM, David Edelsohn wrote: > If the assembler and linker pass the sections with the additional numbers > through and older DBX doesn't know about the sections, it doesn't matter. Agreed. In that case we simply emit the data all the time and let capable debuggers pick it up.

patch for PR61578

2015-09-24 Thread Vladimir Makarov
The following patch solves the 2nd case of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61578 I did a lot of benchmarking of different heuristics in hard reg cost propagation in IRA. This is the best what I found. The patch improves stably code size of SPEC2000 and its score although it

Re: [gomp4] Another oacc reduction simplification

2015-09-24 Thread Cesar Philippidis
On 09/22/2015 08:29 AM, Nathan Sidwell wrote: > 1) Don't have a fake gang reduction outside of worker & vector loops. > Deal with the receiver object directly. I.e. 'ref_to_res' need not be a > null pointer for vector and worker loops. What happens when there is no receiver object. E.g. a

Re: [PATCH, fortran] Revival of AUTOMATIC patch

2015-09-24 Thread FX
> I think I appreciate what you are trying to do here. I don't intend to sound > negative here, but if the keyword AUTOMATIC does nothing The testcase given is not an example of useful AUTOMATIC. I think it is meant to be used to oppose an implied SAVE attribute, e.g. a variable with explicit

[gomp4] rework ptx builtins ... again

2015-09-24 Thread Nathan Sidwell
I've committed this to rework the ptx builtin machinery. We don't use the float mode shuffles any more, so they;re not needed. Also, each builtin has a unique prototype, so the indirection of the type array is useless. Added swap and cmp_swap builtins that I'll be using shortly. nathan

Re: [PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-09-24 Thread Ilya Verbin
On Thu, Aug 27, 2015 at 21:44:50 +0800, Chung-Lin Tang wrote: > We've discovered that, for several of the libgomp plugin interface routines, > if the target specific routine calls exit() (usually upon a fatal condition), > deadlock ensues. We found this using nvptx, but it's possible on intelmic

[gomp4] adjust worker reduction allocation

2015-09-24 Thread Nathan Sidwell
I've committed this patch to reduce the number of worker reduction allocation builtins. We now pass in the (constant) allocation size and alignment and return a void ptr. nathan 2015-09-24 Nathan Sidwell * config/nvptx/nvptx.c (nvptx_expand_work_red_addr): Args

Re: patch for PR61578

2015-09-24 Thread Jeff Law
On 09/24/2015 02:41 PM, Vladimir Makarov wrote: The following patch solves the 2nd case of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61578 I did a lot of benchmarking of different heuristics in hard reg cost propagation in IRA. This is the best what I found. The patch improves

Re: New post-LTO OpenACC pass

2015-09-24 Thread Nathan Sidwell
On 09/23/15 14:58, Nathan Sidwell wrote: On 09/23/15 14:51, Bernd Schmidt wrote: On 09/23/2015 08:42 PM, Nathan Sidwell wrote: As I feared, builtin folding occurs in several places. In particular its first call is very early on in the host compiler, which is far too soon. We have to defer

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread David Edelsohn
On Thu, Sep 24, 2015 at 4:05 PM, Richard Henderson wrote: >> If the assembler and linker generate errors, it further >> delays deployment in GCC. > > If the assembler generates errors, then surely it's easy to error out at > configure time, printing a note about the service

Re: [PATCH] New attribute to create target clones

2015-09-24 Thread Evgeny Stupachenko
I've fixed ICE and review issues. x86 make check and bootstrap passed. Thanks, Evgeny ChangeLog 2015-09-25 Evgeny Stupachenko gcc/ * Makefile.in (OBJS): Add multiple_target.o. * multiple_target.c (make_attribute): New. (create_dispatcher_calls):

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-24 Thread Bernd Schmidt
On 09/24/2015 06:11 PM, Steve Ellcey wrote: At least one of the warnings in glibc is not justified (in my opinion). The header file timezone/private.h defines time_t_min and time_t_max. These are not used in any of the timezone files built by glibc but if you look at the complete tz package they

[PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-24 Thread Teresa Johnson
This patch unsets -freorder-blocks-and-partition when -fprofile-use is not specified. Function splitting was not actually being performed in that case, as probably_never_executed_bb_p does not distinguish any basic blocks as being cold vs hot when there is no profile data. Leaving it enabled,

[committed, PATCH] Change IA MCU processor from iamcu to lakemount

2015-09-24 Thread H.J. Lu
The first IA MCU processor will be Lakemount. This patch changes IA MCU processor name from iamcu to lakemount. Tested on Linux/x86-64 with -m32. Checked into trunk. H.J. -- gcc/ * config.gcc (x86_archs): Replace iamcu with lakemount. (with_cpu): Likewise. (with_arch):

[committed, pa] Update atomic support in PA backend

2015-09-24 Thread John David Anglin
The attached change updates the atomic support in the PA backend for hppa-linux. 1) It enables 64-bit sync builtin support, 2) It adds new atomic store patterns that are atomic with respect to the LWS compare and swap builtins in linux-atomic.c, and 3) Revises existing atomic load and store

Re: [PATCH, fortran] Revival of AUTOMATIC patch

2015-09-24 Thread Jerry DeLisle
On 09/24/2015 04:52 AM, Jim MacArthur wrote: > Hi all, I'm following up on some old work my colleague Mark Doffman did to > try > and get support for the AUTOMATIC keyword into trunk. In the enclosed patch > I've addressed the problem with it accepting 'automatic' outside -std=gnu (it > will

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread Mike Stump
On Sep 24, 2015, at 11:40 AM, David Edelsohn wrote: > AIX added support for the initially missing DWARF sections. > Bad news: The support is in an AIX service pack whose presence on a > system requires effort to determine. So, we faced this problem at Apple, and we just

Re: [PATCH] DWARF support for AIX v4

2015-09-24 Thread David Edelsohn
On Thu, Sep 24, 2015 at 8:01 PM, Mike Stump wrote: > On Sep 24, 2015, at 11:40 AM, David Edelsohn wrote: >> AIX added support for the initially missing DWARF sections. >> Bad news: The support is in an AIX service pack whose presence on a >> system

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-24 Thread Trevor Saunders
On Thu, Sep 24, 2015 at 06:55:11PM +0200, Bernd Schmidt wrote: > On 09/24/2015 06:11 PM, Steve Ellcey wrote: > >At least one of the warnings in glibc is not justified (in my opinion). > >The header file timezone/private.h defines time_t_min and time_t_max. > >These are not used in any of the