Re: [PATCH] Enhance dump_probability function.

2017-06-13 Thread Jakub Jelinek
On Wed, Jun 14, 2017 at 07:52:10AM +0200, Rainer Orth wrote: > both revised scan-tree-dump patterns got the quoting wrong, leading to > attempts to run unknown procs ^\\: instead of matching [^:] ;-( > > This totally broke make check-gcc: the affected partial test runs > aborted at that point, lea

[C++ PATCH] Cleanup cp_genericize_r

2017-06-13 Thread Jakub Jelinek
Hi! When doing the last cp_genericize_r change, I've noticed most of the function is a spaghetti if like: if (TREE_CODE (stmt) == X1) do_something; else if (TREE_CODE (stmt) == X2) do_something_else; else if (TREE_CODE (stmt) == X3) do_yet_another_stuff; else ... sometimes with

Re: [PATCH] Enhance dump_probability function.

2017-06-13 Thread Rainer Orth
Hi Paul, > New "ERROR: (DejaGnu)" on mips64el target. > > my DejaGnu version is 1.5.1. > > 1) > make check-gcc RUNTESTFLAGS="tree-ssa.exp=builtin-sprintf-2.c" > ... > ERROR: (DejaGnu) proc "^:\\" does not exist. > The error code is TCL LOOKUP COMMAND ^:\\ > The info on the error is: > invalid comm

Re: [PATCH] Enhance dump_probability function.

2017-06-13 Thread Paul Hua
New "ERROR: (DejaGnu)" on mips64el target. my DejaGnu version is 1.5.1. 1) make check-gcc RUNTESTFLAGS="tree-ssa.exp=builtin-sprintf-2.c" ... ERROR: (DejaGnu) proc "^:\\" does not exist. The error code is TCL LOOKUP COMMAND ^:\\ The info on the error is: invalid command name "^:\" while execu

Re: [PATCH 13/13] D: Phobos config, makefiles, and testsuite.

2017-06-13 Thread Iain Buclaw
On 13 June 2017 at 19:41, Joseph Myers wrote: > There appear to be various GPLv2 notices with old FSF addresses in here. > Where those are on source files (as opposed to generated files), they > should be updated to the usual GPLv3+ notice for GCC (and I'd expect FSF > copyright notices throughout

Re: [PATCH 11/13] D: GCC builtins and runtime support.

2017-06-13 Thread Iain Buclaw
On 13 June 2017 at 19:38, Joseph Myers wrote: > Presumably all of these GCC-specific files should have the GCC Runtime > Library Exception notice. > OK, noted. I will update them.

Re: [PATCH 2/13] D: The front-end (GDC) implementation.

2017-06-13 Thread Iain Buclaw
On 13 June 2017 at 19:29, Joseph Myers wrote: > As I read it, the front end has functions with names such as error, but no > useful i18n will actually occur because the functions in d-diagnostic.cc > format the messages with xvasprintf before passing to the common > diagnostic code. > That could

Re: Default std::vector default and move constructor

2017-06-13 Thread François Dumont
On 01/06/2017 15:34, Jonathan Wakely wrote: I would expect the constructor to look like this: _Bvector_impl() _GLIBCXX_NOEXCEPT_IF( noexcept(_Bit_alloc_type()) ) : _Bit_alloc_type() { } What happens when you do that? _Bvector_impl(const _Bit_alloc_type& _

gotools patch committed: Build for host_alias = target_alias

2017-06-13 Thread Ian Lance Taylor
This patch to gotools/configure.ac fixes the build to build the tools when host_alias = target_alias, or, in other words, when the system for which we are building code is the same as the system where that code will run. The earlier test of cross_compiling effectively tested whether build_alias an

Re: Avoid _Rb_tree_rotate_[left,right] symbols export

2017-06-13 Thread François Dumont
On 12/05/2017 13:03, Jonathan Wakely wrote: A much simpler (but equivalent) change would be: --- a/libstdc++-v3/src/c++98/tree.cc +++ b/libstdc++-v3/src/c++98/tree.cc @@ -153,6 +153,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION /* Static keyword was missing on _Rb_tree_rotate_left. Export the sym

[PATCH, rs6000] (v3) Fold vector shifts in GIMPLE

2017-06-13 Thread Will Schmidt
Hi, Add support for early expansion of vector shifts. Including vec_sl (shift left), vec_sr (shift right), vec_sra (shift right algebraic), vec_rl (rotate left). Part of this includes adding the vector shift right instructions to the list of those instructions having an unsigned second argument.

Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets

2017-06-13 Thread Christophe Lyon
Hi Thomas, On 13 June 2017 at 11:08, Thomas Preudhomme wrote: > Hi, > > Conditions checked for ARM targets in vector-related effective targets > are inconsistent: > > * sometimes arm*-*-* is checked > * sometimes Neon is checked > * sometimes arm_neon_ok and sometimes arm_neon is used for neon ch

Re: Containers default initialization

2017-06-13 Thread François Dumont
On 12/06/2017 13:57, Jonathan Wakely wrote: Ok to commit ? OK, thanks. Done yesterday. I guess that considering the compiler bug and rare occasions for this bug to show up we don't backport. François

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-13 Thread Jozef Lawrynowicz
On 13/06/2017 16:54, Nick Clifton wrote: Hi Jozef, Ok for trunk and gcc-7-branch? Approved - please apply (to both). Cheers Nick Sorry, didn't mention in that last post that I don't have write access, could someone please apply this for me. Thanks, Jozef

Re: [PATCH 13/13] D: Phobos config, makefiles, and testsuite.

2017-06-13 Thread Joseph Myers
There appear to be various GPLv2 notices with old FSF addresses in here. Where those are on source files (as opposed to generated files), they should be updated to the usual GPLv3+ notice for GCC (and I'd expect FSF copyright notices throughout the contributed GCC-specific files, not "Copyrigh

Re: [PATCH 11/13] D: GCC builtins and runtime support.

2017-06-13 Thread Joseph Myers
Presumably all of these GCC-specific files should have the GCC Runtime Library Exception notice. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 2/13] D: The front-end (GDC) implementation.

2017-06-13 Thread Joseph Myers
As I read it, the front end has functions with names such as error, but no useful i18n will actually occur because the functions in d-diagnostic.cc format the messages with xvasprintf before passing to the common diagnostic code. But will exgettext nevertheless extract messages from the dfronte

Re: [PATCH 32/30][arm][testsuite] Fix neon-thumb2-move.c test

2017-06-13 Thread Richard Earnshaw (lists)
This test was overriding the options that had been detected as being necessary to enable Neon. The result was that the combination of the test's options and those auto-detected were not compatible with neon leading to a test failure. The correct fix here is to stick with the options that dg-add-o

Re: [PATCH 31/30] [arm] Mark -marm and -mthumb as being inverse options

2017-06-13 Thread Richard Earnshaw (lists)
-marm and -mthumb are opposites: one cancels out the other. This patch marks them as such so that the driver will eliminate all but the last option on the command line. This aids multilib selection which otherwise can get confused if both are present. * config/arm/arm.opt (marm): Mark as

Re: [PATCH 14/30] [arm] Generate a canonical form for -march

2017-06-13 Thread Richard Earnshaw (lists)
On 09/06/17 13:53, Richard Earnshaw wrote: > > This patch uses the driver and some spec rewrite rules to generate a > canonicalized form of the -march= option. We want to do this for > several reasons, all relating to making multi-lib selection sane. > > 1) It can remove redundant extension opti

Re: [PATCH 09/30] [ARM] Move cpu and architecture option name parsing code to arm-common.c

2017-06-13 Thread Richard Earnshaw (lists)
On 09/06/17 13:53, Richard Earnshaw wrote: > > This patch has no functional change. The code used for parsing -mcpu, > -mtune and -march options is simply moved from arm.c arm-common.c. > The list of FPU options is also moved. Subsequent patches will make > use of this within the driver. > > So

Re: [PATCH 08/30] [arm] Split CPU, architecture and tuning data tables.

2017-06-13 Thread Richard Earnshaw (lists)
On 09/06/17 13:53, Richard Earnshaw wrote: > > The driver really needs to handle some canonicalization of the new > -mcpu and -march options in order to make multilib selection > tractable. This will require moving much of the logic to parse the > new options into the common code file. However,

Re: [PATCH 0/13] D: Submission of D Front End

2017-06-13 Thread Jeff Law
On 06/13/2017 02:05 AM, Richard Biener wrote: > On Tue, Jun 13, 2017 at 2:09 AM, Iain Buclaw wrote: >> On 13 June 2017 at 01:22, Mike Stump wrote: >>> On Jun 12, 2017, at 11:34 AM, Richard Sandiford >>> wrote: I'm not sure who this is a question to really, but how much value is t

Re: [PATCH 04/30] [arm] Allow +opt on arbitrary cpu and architecture specifications

2017-06-13 Thread Richard Earnshaw (lists)
On 09/06/17 13:53, Richard Earnshaw wrote: > > This is the main patch to provide the infrastructure for adding > feature extensions to CPU and architecture specifications. It does not, > however, add all the extensions that we intend to support (just a small > number to permit some basic testing)

Re: [PATCH 01/30] [arm] Use strings for -march, -mcpu and -mtune options

2017-06-13 Thread Richard Earnshaw (lists)
On 09/06/17 13:53, Richard Earnshaw wrote: > > In order to support more complex specifications for cpus and architectures > we need to move away from using enumerations to represent the set of > permitted options. This basic change just moves the option parsing > infrastructure over to that, but

Re: [PATCH] Fix ICE with -Wduplicated-branches (PR objc/80949)

2017-06-13 Thread Jakub Jelinek
On Tue, Jun 13, 2017 at 07:01:11PM +0200, Marek Polacek wrote: > -Wduplicated-branches can crash on a weird ObjC testcase that we haven't > managed to reduce, so no testcase attached. On that testcase, we end up > calling do_warn_duplicated_branches with null COND_EXPR_THEN, and the code > wasn't

Re: [PATCH][GCC][AArch64] optimize float immediate moves (1 /4) - infrastructure.

2017-06-13 Thread Richard Sandiford
James Greenhalgh writes: >> + >> + /* First determine number of instructions to do the move >> +as an integer constant. */ >> +if (!aarch64_float_const_representable_p (x) >> +&& !aarch64_can_const_movi_rtx_p (x, mode) >> +&& aarch64_float_const_rtx_p (x)) >> +

[PATCH] Fix ICE with -Wduplicated-branches (PR objc/80949)

2017-06-13 Thread Marek Polacek
-Wduplicated-branches can crash on a weird ObjC testcase that we haven't managed to reduce, so no testcase attached. On that testcase, we end up calling do_warn_duplicated_branches with null COND_EXPR_THEN, and the code wasn't prepared to handle that. The fix is trivial. Eric G. verified that th

[PATCH v9] add -fpatchable-function-entry=N,M option

2017-06-13 Thread Torsten Duwe
Changes since v8: * Documentation changes as requested by Sandra * 3 functional test cases added Torsten gcc/c-family/ChangeLog 2017-06-13 Torsten Duwe * c-attribs.c (c_common_attribute_table): Add entry for "patchable_function_entry". gcc/lto/ChangeLog 2017-06-

Re: [PATCH][GCC][AArch64] optimize float immediate moves (1 /4) - infrastructure.

2017-06-13 Thread James Greenhalgh
This patch is pretty huge, are there any opportunities to further split it to aid review? I have some comments in line. > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index > a069427f576f6bd7336bbe4497249773bd33d138..2ab2d96e40e80a79b5648046ca2d6e202d3939a2 > 10064

Re: [PATCH 00/30] [ARM] Reworking the -mcpu, -march and -mfpu options

2017-06-13 Thread Christophe Lyon
On 13 June 2017 at 17:25, Richard Earnshaw (lists) wrote: > On 12/06/17 15:34, Richard Earnshaw (lists) wrote: >> On 12/06/17 12:49, Christophe Lyon wrote: >>> On 10 June 2017 at 01:27, Richard Earnshaw (lists) >>> wrote: On 09/06/17 23:45, Christophe Lyon wrote: > Hi Richard, >

Re: [libgomp, OpenACC] Add more map handling for enter/exit data directives

2017-06-13 Thread Jakub Jelinek
On Tue, Jun 13, 2017 at 06:48:18PM +0800, Chung-Lin Tang wrote: > Hi Jakub, > this patch has been posted before, but hasn't really been reviewed yet: > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01927.html > > This has been deployed on gomp-4_0-branch for a long time, and was re-tested > on cur

Re: [PATCH] Finish implementing P0426R1 "Constexpr for std::char_traits" for C++17

2017-06-13 Thread Jonathan Wakely
On 12/06/17 23:28 +0100, Pedro Alves wrote: On 06/05/2017 03:27 PM, Jonathan Wakely wrote: Pedro, this is OK for trunk now we're in stage 1. Please go ahead and commit it - thanks. Thanks Jonathan. I've pushed it in now. It's probably safe for gcc-7-branch too, but let's leave it on trunk

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-13 Thread Nick Clifton
Hi Jozef, > Ok for trunk and gcc-7-branch? Approved - please apply (to both). Cheers Nick

Re: [PATCH 01/30] [arm] Use strings for -march, -mcpu and -mtune options

2017-06-13 Thread Richard Earnshaw (lists)
On 13/06/17 14:23, Christophe Lyon wrote: > On 9 June 2017 at 14:53, Richard Earnshaw wrote: >> >> In order to support more complex specifications for cpus and architectures >> we need to move away from using enumerations to represent the set of >> permitted options. This basic change just moves

Re: C/C++ PATCH to implement -Wmultistatement-macros (PR c/80116)

2017-06-13 Thread Joseph Myers
On Tue, 13 Jun 2017, Marek Polacek wrote: > * c-parser.c (c_parser_if_body): Set the location of the > body of the conditional after parsing all the labels. Call > warn_for_multistatement_macros. > (c_parser_else_body): Likewise. > (c_parser_switch_statement): Likewi

Re: [PATCH 00/30] [ARM] Reworking the -mcpu, -march and -mfpu options

2017-06-13 Thread Richard Earnshaw (lists)
On 12/06/17 15:34, Richard Earnshaw (lists) wrote: > On 12/06/17 12:49, Christophe Lyon wrote: >> On 10 June 2017 at 01:27, Richard Earnshaw (lists) >> wrote: >>> On 09/06/17 23:45, Christophe Lyon wrote: Hi Richard, On 9 June 2017 at 14:53, Richard Earnshaw wrote: > >

Re: Merge from GCC trunk to gccgo branch

2017-06-13 Thread Ian Lance Taylor
I've merged GCC trunk revision 249156 to the gccgo branch. Ian

Go patch committed: Fix function passed in write_globals

2017-06-13 Thread Ian Lance Taylor
This patch by Than McIntosh fixes a bug in the Go frontend: in Gogo::write_globals in a couple of places the wrong Bfunction was being used for the containing (not target) function when creating calls for init functions. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainl

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so that add

Re: [PATCH v3][AArch64] Fix symbol offset limit

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 January 2017 15:14 To: Richard Earnshaw; GCC Patches; James Greenhalgh Cc: nd Subject: Re: [PATCH v3][AArch64] Fix symbol offset limit     Here is v3 of the patch - tree_fits_uhwi_p was necessary to ensure the size of a declaration is an integer. So the questio

Re: [PATCH][ARM] Remove Thumb-2 iordi_not patterns

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 January 2017 18:00 To: GCC Patches Cc: nd; Kyrylo Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove Thumb-2 iordi_not patterns     After Bernd's DImode patch [1] almost all DImode operations are expanded early (except for -mfpu=neon). This means the Thumb

Re: [PATCH][ARM] Improve max_insns_skipped logic

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 10 November 2016 17:19 To: GCC Patches Cc: nd Subject: [PATCH][ARM] Improve max_insns_skipped logic     Improve the logic when setting max_insns_skipped.  Limit the maximum size of IT to MAX_INSN_PER_IT_BLOCK as otherwise multiple IT instructions are needed, incr

Re: [PATCH][ARM] Fix ldrd offsets

2017-06-13 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 03 November 2016 12:20 To: GCC Patches Cc: nd Subject: [PATCH][ARM] Fix ldrd offsets     Fix ldrd offsets of Thumb-2 - for TARGET_LDRD the range is +-1020, without -255..4091.  This reduces the number of addressing instructions when using DI mode operations

Re: [PATCH v2] Implement no_sanitize function attribute

2017-06-13 Thread Martin Liška
On 06/13/2017 03:49 PM, Richard Biener wrote: > On Tue, Jun 13, 2017 at 1:09 PM, Martin Liška wrote: >> On 06/09/2017 03:35 PM, Richard Biener wrote: >>> You can directly transform to no_sanitize with integer mask, not sure why >>> you'd need an intermediate step with a string? >> >> Hello. >> >>

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage     This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required. So make

Re: [PATCH][ARM] Remove movdi_vfp_cortexa8

2017-06-13 Thread Wilco Dijkstra
ping   Richard Earnshaw (lists) wrote: >  (define_insn "*movdi_vfp" > -  [(set (match_operand:DI 0 "nonimmediate_di_operand" > "=r,r,r,r,q,q,m,w,r,w,w, Uv") > +  [(set (match_operand:DI 0 "nonimmediate_di_operand" > "=r,r,r,r,q,q,m,w,!r,w,w, Uv") > Why have you introduced a no-reloads block

Re: [PATCH][AArch64] Improve Cortex-A53 shift bypass

2017-06-13 Thread Wilco Dijkstra
ping   Richard Earnshaw (lists) wrote: > --- a/gcc/config/arm/aarch-common.c > +++ b/gcc/config/arm/aarch-common.c > @@ -254,12 +254,7 @@ arm_no_early_alu_shift_dep (rtx producer, rtx consumer) >  return 0; >  >    if ((early_op = arm_find_shift_sub_rtx (op))) > -    { > -  if (REG_P (

Re: [PATCH][ARM] Update max_cond_insns settings

2017-06-13 Thread Wilco Dijkstra
ping   Richard Earnshaw (lists) wrote: > On 05/05/17 13:42, Wilco Dijkstra wrote: >> Richard Earnshaw (lists) wrote: >>> On 04/05/17 18:38, Wilco Dijkstra wrote: >>> > Richard Earnshaw wrote: >>> > > -  5, /* Max cond insns.  */ > +  2,   

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-06-13 Thread James Greenhalgh
On Tue, Jun 13, 2017 at 10:24:59AM +, Hurugalawadi, Naveen wrote: > Hi James, > > Thanks for your review and useful comments. > > >> If you could try to keep one reply chain for each patch series > Will keep that in mind for sure :-) > > >> Very minor, but what is wrong with: > >> int matche

Re: [PATCH v2] Implement no_sanitize function attribute

2017-06-13 Thread Richard Biener
On Tue, Jun 13, 2017 at 1:09 PM, Martin Liška wrote: > On 06/09/2017 03:35 PM, Richard Biener wrote: >> You can directly transform to no_sanitize with integer mask, not sure why >> you'd need an intermediate step with a string? > > Hello. > > Done in attached patch, I'm sending both incremental an

Re: C/C++ PATCH to implement -Wmultistatement-macros (PR c/80116)

2017-06-13 Thread Marek Polacek
On Sat, Jun 10, 2017 at 12:03:18AM +0200, Gerald Pfeifer wrote: > On Thu, 8 Jun 2017, David Malcolm wrote: > > How about: > > > > "Warn about unsafe multiple statement macros that appear to be guarded > > by a clause such as if, else, while, or for, in which only the first > > statement is actuall

libgo patch committed: Don't always show frames with no function in traceback

2017-06-13 Thread Ian Lance Taylor
In a Go traceback, if there is no function name, that traceback entry is generally uninformative. In earlier versions we did not show such frames. This patch restores that behavior. These frames can be seen with GOTRACEBACK=system. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Comm

Re: [PATCH 01/30] [arm] Use strings for -march, -mcpu and -mtune options

2017-06-13 Thread Christophe Lyon
On 9 June 2017 at 14:53, Richard Earnshaw wrote: > > In order to support more complex specifications for cpus and architectures > we need to move away from using enumerations to represent the set of > permitted options. This basic change just moves the option parsing > infrastructure over to that

Re: [PATCH 9/9] rs6000: Comment fixes + some leftovers

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/rs6000.c: Update all comments that mentioned SPE. > (rs6000_expand_builtin): Remove RS6000_BTC_EVSEL. > * config/rs6000/rs6000.h (RS6000_BTC_EVSEL): Delete. >

Re: [PATCH 7/9] rs6000: Remove FIXED_SCRATCH

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/rs6000.h (FIXED_SCRATCH): Delete. Okay. Thanks, david

Re: [PATCH 8/9] rs6000: Remove VECTOR_SPE

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/rs6000-opts.h (enum rs6000_vector): Delete VECTOR_SPE. > * config/rs6000/rs6000.c (rs6000_debug_vector_unit): Delete > VECTOR_SPE. Okay. Thanks, David

Re: [PATCH 6/9] rs6000: Updates to t-rtems

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/t-rtems: Don't handle SPE. Okay. Thanks, David

Re: [PATCH 5/9] rs6000: Updates to t-linux

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/t-linux: Don't handle SPE. Okay. Thanks, David

Re: [PATCH 4/9] rs6000: Remove eabispe.h

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/eabispe.h: Delete file. Okay. Thanks, David

Re: [PATCH 3/9] rs6000: Remove t-spe

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/t-spe: Delete file. Okay. Thanks, David

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-13 Thread Richard Biener
On Tue, Jun 13, 2017 at 2:32 PM, Martin Liška wrote: > Hello. > > After some discussions with Richi, I would like to propose patch that will > come up with a canonical name of attribute names. That means > __attribute__((__abi_tag__)) > will be given 'abi_tag' as IDENTIFIER_NAME of the attribute.

Re: [PATCH 2/9] rs6000: Remove SPE_CONST_OFFSET_OK

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > 2017-06-13 Segher Boessenkool > > * config/rs6000/rs6000.c (SPE_CONST_OFFSET_OK): Delete. > (rs6000_legitimate_offset_address_p): Return false for anything in > V2SImode or V2SFmode. Okay. Thanks, David

Re: [PATCH 1/9] rs6000: Sanitize vector modes

2017-06-13 Thread David Edelsohn
On Tue, Jun 13, 2017 at 8:53 AM, Segher Boessenkool wrote: > This removes the vector modes that were only used by SPE. It also > rearranges things so it is easier to see what is there, and for what. > > > 2017-06-13 Segher Boessenkool > > * config/rs6000/rs6000-modes.def: Remove all 8-

Re: [PING^3][RFC, PATCH][ASAN] Implement dynamic allocas/VLAs sanitization.​

2017-06-13 Thread Jakub Jelinek
On Tue, Jun 13, 2017 at 03:11:41PM +0300, Maxim Ostapenko wrote: > @@ -531,11 +533,166 @@ get_mem_ref_of_assignment (const gassign *assignment, >return true; > } > > +/* Return address of last allocated dynamic alloca. */ > + > +static tree > +get_last_alloca_addr () > +{ > + if (last_allo

fix libcc1 dependencies in toplevel Makefile

2017-06-13 Thread Olivier Hainque
Hello, During highly parallel builds on fast hosts, we have experienced sporadic bootstrap failures on libquadmath like In file included from ../../../src/libquadmath/printf/printf_fp.c:39:0: ../../../src/libquadmath/printf/quadmath-printf.h:24:20: fatal error: .../build/./gcc/include-fixed/

[PATCH 9/9] rs6000: Comment fixes + some leftovers

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/rs6000.c: Update all comments that mentioned SPE. (rs6000_expand_builtin): Remove RS6000_BTC_EVSEL. * config/rs6000/rs6000.h (RS6000_BTC_EVSEL): Delete. * config/rs6000/vxworks.h (VXCPU_FOR_8548): Delete. Adjust form

[PATCH 7/9] rs6000: Remove FIXED_SCRATCH

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/rs6000.h (FIXED_SCRATCH): Delete. --- gcc/config/rs6000/rs6000.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h index edfa546..e8305aa 100644 --- a/gcc/config/rs6000/rs6000

[PATCH 8/9] rs6000: Remove VECTOR_SPE

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/rs6000-opts.h (enum rs6000_vector): Delete VECTOR_SPE. * config/rs6000/rs6000.c (rs6000_debug_vector_unit): Delete VECTOR_SPE. --- gcc/config/rs6000/rs6000-opts.h | 1 - gcc/config/rs6000/rs6000.c | 1 - 2 files changed, 2 del

[PATCH 6/9] rs6000: Updates to t-rtems

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/t-rtems: Don't handle SPE. --- gcc/config/rs6000/t-rtems | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/config/rs6000/t-rtems b/gcc/config/rs6000/t-rtems index 723c6a3..8290f5c 100644 --- a/gcc/config/rs6000/

[PATCH 5/9] rs6000: Updates to t-linux

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/t-linux: Don't handle SPE. --- gcc/config/rs6000/t-linux | 4 1 file changed, 4 deletions(-) diff --git a/gcc/config/rs6000/t-linux b/gcc/config/rs6000/t-linux index 4cb63bd..acfde1f 100644 --- a/gcc/config/rs6000/t-linux +++ b/gcc/c

[PATCH 4/9] rs6000: Remove eabispe.h

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/eabispe.h: Delete file. --- gcc/config/rs6000/eabispe.h | 26 -- 1 file changed, 26 deletions(-) delete mode 100644 gcc/config/rs6000/eabispe.h diff --git a/gcc/config/rs6000/eabispe.h b/gcc/config/rs6000/eabispe.

[PATCH 3/9] rs6000: Remove t-spe

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/t-spe: Delete file. --- gcc/config/rs6000/t-spe | 72 - 1 file changed, 72 deletions(-) delete mode 100644 gcc/config/rs6000/t-spe diff --git a/gcc/config/rs6000/t-spe b/gcc/config/rs6000/t

[PATCH 2/9] rs6000: Remove SPE_CONST_OFFSET_OK

2017-06-13 Thread Segher Boessenkool
2017-06-13 Segher Boessenkool * config/rs6000/rs6000.c (SPE_CONST_OFFSET_OK): Delete. (rs6000_legitimate_offset_address_p): Return false for anything in V2SImode or V2SFmode. --- gcc/config/rs6000/rs6000.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) d

[PATCH 1/9] rs6000: Sanitize vector modes

2017-06-13 Thread Segher Boessenkool
This removes the vector modes that were only used by SPE. It also rearranges things so it is easier to see what is there, and for what. 2017-06-13 Segher Boessenkool * config/rs6000/rs6000-modes.def: Remove all 8-byte vector modes except V2SF and V2SI. Rearrange the vector m

[PATCH 0/9] rs6000: SPE removal, part 2

2017-06-13 Thread Segher Boessenkool
This patch series makes further updates to remove SPE from the rs6000 port. The only thing that should be left now is the documentation. Tested on powerpc64-linux {-m32,-m64}; I'll test on some more systems and commit later today. Segher gcc/config/rs6000/eabispe.h| 26 -- gc

[PATCH][RFC] Canonize names of attributes.

2017-06-13 Thread Martin Liška
Hello. After some discussions with Richi, I would like to propose patch that will come up with a canonical name of attribute names. That means __attribute__((__abi_tag__)) will be given 'abi_tag' as IDENTIFIER_NAME of the attribute. The change can improve attribute name lookup and we can delete

Re: [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c

2017-06-13 Thread Christophe Lyon
On 13 June 2017 at 12:13, Kyrill Tkachov wrote: > > On 13/06/17 11:12, Tamar Christina wrote: >> >> Hi All, >> >> This fixes the failing test gcc.target/arm/sdiv_costs_1.c by >> requiring arm_arch_v8a_ok. >> >> >> OK for trunk? >> > > Ok. > Thanks, > Kyrill > > >> gcc/testsuite/ >> 2017-06-13 Tam

[PING^3][RFC, PATCH][ASAN] Implement dynamic allocas/VLAs sanitization.​

2017-06-13 Thread Maxim Ostapenko
Hi, I would like to ping the following patch: https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01374.html Rebased version is attached. Thanks, -Maxim gcc/ChangeLog: 2017-06-13 Maxim Ostapenko * asan.c: Include gimple-fold.h. (get_last_alloca_addr): New function. (handle_builtin_stackresto

Re: [PATCH] Fix PR66313

2017-06-13 Thread Richard Biener
On Tue, 13 Jun 2017, Bin.Cheng wrote: > On Tue, Jun 13, 2017 at 12:48 PM, Richard Biener wrote: > > On Tue, 13 Jun 2017, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > On Tue, 13 Jun 2017, Richard Sandiford wrote: > >> >> Richard Biener writes: > >> >> > So I've come back to PR

Re: [PATCH] Fix PR66313

2017-06-13 Thread Bin.Cheng
On Tue, Jun 13, 2017 at 12:48 PM, Richard Biener wrote: > On Tue, 13 Jun 2017, Richard Sandiford wrote: > >> Richard Biener writes: >> > On Tue, 13 Jun 2017, Richard Sandiford wrote: >> >> Richard Biener writes: >> >> > So I've come back to PR66313 and found a solution to the tailrecursion >> >>

Re: [PATCH] Fix PR66313

2017-06-13 Thread Richard Biener
On Tue, 13 Jun 2017, Bin.Cheng wrote: > On Tue, Jun 13, 2017 at 12:23 PM, Richard Sandiford > wrote: > > Richard Biener writes: > >> On Tue, 13 Jun 2017, Richard Sandiford wrote: > >>> Richard Biener writes: > >>> > So I've come back to PR66313 and found a solution to the tailrecursion > >>> >

Re: [PATCH] Fix PR66313

2017-06-13 Thread Richard Biener
On Tue, 13 Jun 2017, Richard Sandiford wrote: > Richard Biener writes: > > On Tue, 13 Jun 2017, Richard Sandiford wrote: > >> Richard Biener writes: > >> > So I've come back to PR66313 and found a solution to the tailrecursion > >> > missed optimization when fixing the factoring folding to use a

RE: [PATCH][X86] Fix rounding pattern similar to PR73350

2017-06-13 Thread Koval, Julia
Thank you for your help. I fixed the test similar to existing sigaction tests. gcc/ * config/i386/i386.c: Fix rounding expand for new pattern. * config/i386/subst.md: Fix pattern (parallel -> unspec). gcc/testsuite/ * gcc.target/i386/pr73350-2.c: New test. Thanks, Julia >

Re: [PATCH try 2 resend] [i386] Remove warnings for ignoring -mcall-ms2sysv-xlogues.

2017-06-13 Thread Bernd Edlinger
On 06/11/17 22:35, Daniel Santos wrote: > I appear to have forgotten to cc gcc-patches, sorry about that. > > There are currently three cases where we issue a warning when disabling > -mcall-ms2sysv-xlogues for a function, but I never added a proper > warning, so there's no mechanism for disabli

Re: [PATCH] Fix PR66313

2017-06-13 Thread Bin.Cheng
On Tue, Jun 13, 2017 at 12:23 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Tue, 13 Jun 2017, Richard Sandiford wrote: >>> Richard Biener writes: >>> > So I've come back to PR66313 and found a solution to the tailrecursion >>> > missed optimization when fixing the factoring folding

Re: [PATCH] Fix PR66313

2017-06-13 Thread Richard Sandiford
Richard Biener writes: > On Tue, 13 Jun 2017, Richard Sandiford wrote: >> Richard Biener writes: >> > So I've come back to PR66313 and found a solution to the tailrecursion >> > missed optimization when fixing the factoring folding to use an unsigned >> > type when we're not sure of overflow. >>

Re: [PATCH GCC][06/13]Preserve loop nest in whole distribution life time

2017-06-13 Thread Richard Biener
On Tue, Jun 13, 2017 at 1:15 PM, Bin.Cheng wrote: > On Tue, Jun 13, 2017 at 12:06 PM, Richard Biener > wrote: >> On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: >>> Hi, >>> This simple patch computes and preserves loop nest vector for whole >>> distribution >>> life time. The loop nest will

Re: [PATCH GCC][06/13]Preserve loop nest in whole distribution life time

2017-06-13 Thread Bin.Cheng
On Tue, Jun 13, 2017 at 12:06 PM, Richard Biener wrote: > On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: >> Hi, >> This simple patch computes and preserves loop nest vector for whole >> distribution >> life time. The loop nest will be used multiple times in on-demand data >> dependence >> c

Re: [PATCH GCC][07/13]Preserve data references for whole distribution life time

2017-06-13 Thread Richard Biener
On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: > Hi, > This patch collects and preserves all data references in loop for whole > distribution life time. It will be used afterwards. > > Bootstrap and test on x86_64 and AArch64. Is it OK? +/* Vector of data references in the loop to be distrib

Re: [PATCH v2] Implement no_sanitize function attribute

2017-06-13 Thread Martin Liška
On 06/09/2017 03:35 PM, Richard Biener wrote: > You can directly transform to no_sanitize with integer mask, not sure why > you'd need an intermediate step with a string? Hello. Done in attached patch, I'm sending both incremental and final version (complete patch). I also decided to support no_

Re: [PATCH GCC][06/13]Preserve loop nest in whole distribution life time

2017-06-13 Thread Richard Biener
On Tue, Jun 13, 2017 at 1:06 PM, Richard Biener wrote: > On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: >> Hi, >> This simple patch computes and preserves loop nest vector for whole >> distribution >> life time. The loop nest will be used multiple times in on-demand data >> dependence >> co

Re: [PATCH GCC][06/13]Preserve loop nest in whole distribution life time

2017-06-13 Thread Richard Biener
On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: > Hi, > This simple patch computes and preserves loop nest vector for whole > distribution > life time. The loop nest will be used multiple times in on-demand data > dependence > computation. > > Bootstrap and test on x86_64 and AArch64. Is it

Re: [PATCH GCC][05/13]Refactoring partition merge

2017-06-13 Thread Richard Biener
On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: > Hi, > This simple patch refactors partition merge code and dump information. > > Bootstrap and test on x86_64 and AArch64. Is it OK? Ok. Thanks, Richard. > Thanks, > bin > 2017-06-07 Bin Cheng > > * tree-loop-distribution.c (enum f

Re: [PATCH 2/3] Make early return predictor more precise.

2017-06-13 Thread Martin Liška
On 06/09/2017 04:08 PM, Jan Hubicka wrote: >> gcc/ChangeLog: >> >> 2017-05-26 Martin Liska >> >> PR tree-optimization/79489 >> * gimplify.c (maybe_add_early_return_predict_stmt): New >> function. >> (gimplify_return_expr): Call the function. >> * predict.c (tree_estimate

Re: [PATCH GCC][04/13]Sort statements in topological order for loop distribution

2017-06-13 Thread Richard Biener
On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: > Hi, > During the work I ran into a latent bug for distributing. For the moment we > sort statements > in dominance order, but that's not enough because basic blocks may be sorted > in reverse order > of execution flow. This results in wrong d

Re: [PATCH GCC][03/13]Mark and skip distributed loops

2017-06-13 Thread Bin.Cheng
On Tue, Jun 13, 2017 at 11:47 AM, Richard Biener wrote: > On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: >> Hi, >> This simple patch marks distributed loops and skips it in following >> distribution. >> >> Bootstrap and test on x86_64 and AArch64. Is it OK? > > This is not necessary, FOR_EAC

[libgomp, OpenACC] Add more map handling for enter/exit data directives

2017-06-13 Thread Chung-Lin Tang
Hi Jakub, this patch has been posted before, but hasn't really been reviewed yet: https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01927.html This has been deployed on gomp-4_0-branch for a long time, and was re-tested on current trunk, test results okay. Is this okay for trunk? Thanks, Chung-Lin

Re: [PATCH GCC][03/13]Mark and skip distributed loops

2017-06-13 Thread Richard Biener
On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: > Hi, > This simple patch marks distributed loops and skips it in following > distribution. > > Bootstrap and test on x86_64 and AArch64. Is it OK? This is not necessary, FOR_EACH_LOOP first builds a vector of loops to iterate over so it will ne

Re: [PATCH GCC][02/13]Skip distribution if there is no loop

2017-06-13 Thread Richard Biener
On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng wrote: > Hi, > this is a simple patch skipping distribution if there is no loop at all. > > Bootstrap and test on x86_64 and AArch64. Is it OK? > Thanks, > bin > > 2017-06-07 Bin Cheng > > * cfgloop.h (pass_loop_distribution::execute): Skip if

  1   2   >