Re: [PATCH v2 05/07] RISC-V: autovec: Add tuning and target vectorization hooks

2023-03-05 Thread Richard Biener via Gcc-patches
On Mon, Mar 6, 2023 at 4:16 AM Michael Collison wrote: > > This patch adds support for registering target hooks for basic > autovectorization support as well as basic tuning information for the > vector extension. Btw, during the state tuning isn't established or autovect support being limited I

Re: [PATCH 1/2] gcov: Fix "do-while" structure in case statement leads to incorrect code coverage [PR93680]

2023-03-05 Thread Xionghu Luo via Gcc-patches
On 2023/3/2 18:45, Richard Biener wrote: small.gcno: 648: block 2:`small.c':1, 3, 4, 6 small.gcno: 688:0145: 36:LINES small.gcno: 700: block 3:`small.c':8, 9 small.gcno: 732:0145: 32:LINES small.gcno: 744:

Re: [PATCH v2] LoongArch: Stop -mfpu from silently breaking ABI [PR109000]

2023-03-05 Thread Lulu Cheng
在 2023/3/3 下午4:16, Xi Ruoyao 写道: In the toolchain convention, we describe -mfpu= as: "Selects the allowed set of basic floating-point instructions and registers. This option should not change the FP calling convention unless it's necessary." Though not explicitly stated, the rationale of

Re: [PATCH 0/2] LoongArch: testsuite: Fix tests related to stack

2023-03-05 Thread Xi Ruoyao via Gcc-patches
On Mon, 2023-03-06 at 11:16 +0800, Xi Ruoyao wrote: /* snip */ > > > Sorry for the late reply, the first patch I think is fine. But I haven't > > > reproduced the problem of the second mail. > > > > > > Is there any special option in the configuration? > > > > Oh some strange thing might be

Re: [PATCH v2 00/07] RISC-V: autovec: Add auto-vectorization support

2023-03-05 Thread Michael Collison
Thanks for the feedback, will try that next time. Michael Collison > On Mar 5, 2023, at 11:06 PM, Xi Ruoyao wrote: > > On Sun, 2023-03-05 at 22:13 -0500, Michael Collison wrote: > > /* snip */ > >> - Fixed ChangeLog email formatting > > Unfortunately it's not fixed. We expect one tab,

Re: [PATCH v2 00/07] RISC-V: autovec: Add auto-vectorization support

2023-03-05 Thread Xi Ruoyao via Gcc-patches
On Sun, 2023-03-05 at 22:13 -0500, Michael Collison wrote: /* snip */ > - Fixed ChangeLog email formatting Unfortunately it's not fixed. We expect one tab, but now you have 16 whitespaces. To me it looks like your email client is being too smart and destroying the patch . Try "git

Re: [PATCH] Always define `WIN32_LEAN_AND_MEAN` before

2023-03-05 Thread Ian Lance Taylor via Gcc-patches
On Fri, Mar 3, 2023 at 10:47 PM Xi Ruoyao wrote: > > On Sat, 2023-01-07 at 06:52 +, Jonathan Yong via Gcc-patches wrote: > > On 1/6/23 18:10, Jakub Jelinek wrote: > > > On Sat, Jan 07, 2023 at 02:01:05AM +0800, LIU Hao via Gcc-patches > > > wrote: > > > > libgomp/ > > > > > > > > PR

[PATCH v2 07/07] RISC-V: autovec: Add autovectorization patterns for add & sub

2023-03-05 Thread Michael Collison
This patch adds tests for autovectorization of integer add and subtract. gcc/testsuite/ChangeLog: 2023-03-02  Michael Collison                Vineet Gupta                 * gcc.target/riscv/rvv/autovec: New directory            for autovectorization tests.            *

Re: [PATCH 0/2] LoongArch: testsuite: Fix tests related to stack

2023-03-05 Thread Xi Ruoyao via Gcc-patches
On Mon, 2023-03-06 at 10:48 +0800, Xi Ruoyao wrote: > On Mon, 2023-03-06 at 09:15 +0800, Lulu Cheng wrote: > > > > 在 2023/3/6 上午12:21, Xi Ruoyao 写道: > > > On Fri, 2023-03-03 at 08:21 -0800, Mike Stump wrote: > > > > On Mar 3, 2023, at 12:40 AM, Xi Ruoyao via Gcc-patches > > > > wrote: > > > > >

[PATCH V2 06/07] RISC-V: autovec: Add autovectorization patterns for add & sub

2023-03-05 Thread Michael Collison
This patch adds patterns that provide basic autovectorization support for integer adds and subtracts. gcc/ChangeLog: 2023-03-02  Michael Collison                Juzhe Zhong                * config/riscv/riscv.md (riscv_vector_preferred_simd_mode): Include               

[PATCH v2 05/07] RISC-V: autovec: Add tuning and target vectorization hooks

2023-03-05 Thread Michael Collison
This patch adds support for registering target hooks for basic autovectorization support as well as basic tuning information for the vector extension. gcc/ChangeLog: 2023-03-02  Michael Collison                Juzhe Zhong            * config/riscv/riscv-cores.def (RISCV_TUNE):   

[PATCH v2 04/07] RISC-V: autovec: Add auto-vectorization support functions

2023-03-05 Thread Michael Collison
This patch adds support for functions used in implementing various portions of autovectorization support. gcc/ChangeLog: 2023-03-02  Michael Collison                Juzhe Zhong            * config/riscv/riscv-v.cc (riscv_classify_vlmul_field):            New function.   

[PATCH v2 03/07] RISC-V: autovec: Add vector cost model

2023-03-05 Thread Michael Collison
This patches adds two new files to support the vector cost model and modifies the Makefile fragment to build the cost model c++ file. Due to the large size this patch is provided as an attachment. gcc/ChangeLog: 2023-03-02  Michael Collison                Juzhe Zhong            *

[PATCH v2 02/07] RISC-V: autovec: Export policy functions to global scope

2023-03-05 Thread Michael Collison
This patch adds foundational support by making two functions that handle predication policies visibly globally. gcc/ChangeLog: 2023-03-02  Michael Collison                Juzhe Zhong            * config/riscv/riscv-vector-builtins.cc (get_tail_policy_for_pred):           

[PATCH v2 01/07] RISC-V: autovec: Add new predicates and function prototypes

2023-03-05 Thread Michael Collison
This patch adds foundational support in the form of: 1. New predicates 2. New function prototypes 3. Exporting emit_vlmax_vsetvl to global scope 4. Add a new command line option -mriscv_vector_lmu 2023-03-02  Michael Collison                Juzhe Zhong            *

[PATCH v2 00/07] RISC-V: autovec: Add auto-vectorization support

2023-03-05 Thread Michael Collison
This series of patches adds foundational support for RISC-V autovectorization support. These patches are based on the current upstream rvv vector intrinsic support and is not a new implementation. Most of the implementation consists of adding the new vector cost model, the autovectorization

Re: [PATCH 0/2] LoongArch: testsuite: Fix tests related to stack

2023-03-05 Thread Xi Ruoyao via Gcc-patches
On Mon, 2023-03-06 at 09:15 +0800, Lulu Cheng wrote: > > 在 2023/3/6 上午12:21, Xi Ruoyao 写道: > > On Fri, 2023-03-03 at 08:21 -0800, Mike Stump wrote: > > > On Mar 3, 2023, at 12:40 AM, Xi Ruoyao via Gcc-patches > > > wrote: > > > > Some trivial test case fixes.  Ok for trunk? > > > Ok. > > Lulu:

Ping [PATCH v3] Add condition coverage profiling

2023-03-05 Thread Jørgen Kvalsvik via Gcc-patches
On 05/12/2022 10:40, Jørgen Kvalsvik wrote: > This patch adds support in gcc+gcov for modified condition/decision > coverage (MC/DC) with the -fprofile-conditions flag. MC/DC is a type of > test/code coverage and it is particularly important in the avation and > automotive industries for

Re: [PATCH 0/2] LoongArch: testsuite: Fix tests related to stack

2023-03-05 Thread Lulu Cheng
在 2023/3/6 上午12:21, Xi Ruoyao 写道: On Fri, 2023-03-03 at 08:21 -0800, Mike Stump wrote: On Mar 3, 2023, at 12:40 AM, Xi Ruoyao via Gcc-patches wrote: Some trivial test case fixes.  Ok for trunk? Ok. Lulu: if you don't object I'll push these two in this week. I tried to bisect for the

Re: Re: [PATCH] RISC-V: Optimize the MASK opt generation

2023-03-05 Thread Feng Wang
On 2023-03-03 17:12  Feng Wang wrote: > >On 2023-03-03 16:54  jiawei wrote: >> >>The Mask flag in the single TargetVariable is not enough due to more >>and more extensions were added.So I optimize the defination of Mask >>flag, please refer to the below case: >>There are some new MASK flags for

New Swedish PO file for 'gcc' (version 13.1-b20230212)

2023-03-05 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: https://translationproject.org/latest/gcc/sv.po (This file,

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Segher Boessenkool
Hi! On Sun, Mar 05, 2023 at 08:43:20PM +, Tamar Christina wrote: > > On 3/5/23 12:28, Tamar Christina via Gcc-patches wrote: > > > The regression was reported during stage-1. A patch was provided during > > stage 1 and the discussions around combine stalled. > > > > > > The regression for

RE: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Tamar Christina via Gcc-patches
> > On 3/5/23 12:28, Tamar Christina via Gcc-patches wrote: > > > > The regression was reported during stage-1. A patch was provided during > stage 1 and the discussions around combine stalled. > > > > The regression for AArch64 needs to be fixed in GCC 13. The hit is too big > > just > to

[PATCH, v3] Fortran: fix CLASS attribute handling [PR106856]

2023-03-05 Thread Harald Anlauf via Gcc-patches
Hi Mikael, Am 04.03.23 um 23:29 schrieb Mikael Morin: Le 04/03/2023 à 22:20, Harald Anlauf a écrit : Hi Mikael, Am 04.03.23 um 18:09 schrieb Mikael Morin: There was a comment about the old_symbol thing at the end of my previous message:

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Jeff Law via Gcc-patches
On 3/5/23 12:28, Tamar Christina via Gcc-patches wrote: The regression was reported during stage-1. A patch was provided during stage 1 and the discussions around combine stalled. The regression for AArch64 needs to be fixed in GCC 13. The hit is too big just to "take". So we need a way

[committed] testsuite: Fix up syntax error in scan-tree-dump-times target selector

2023-03-05 Thread Jakub Jelinek via Gcc-patches
Hi! On aarch64, powerpc64le and s390x-linux I'm seeing another syntax error which didn't show up on x86_64-linux nor i686-linux: ERROR: gcc.dg/vect/slp-perm-8.c -flto -ffat-lto-objects: error executing dg-final: syntax error in target selector "target ! vect_load_lanes &&

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-05 Thread Tamar Christina via Gcc-patches
The regression was reported during stage-1. A patch was provided during stage 1 and the discussions around combine stalled. The regression for AArch64 needs to be fixed in GCC 13. The hit is too big just to "take". So we need a way forward, even if it's stage-4. Thanks, Tamar

Re: [PATCH v2] RISC-V: Produce better code with complex constants [PR95632] [PR106602]

2023-03-05 Thread Jeff Law via Gcc-patches
On 3/5/23 12:03, Andrew Pinski wrote: On Sun, Mar 5, 2023 at 10:14 AM Jeff Law via Gcc-patches wrote: On 2/23/23 14:23, Andrew Pinski via Gcc-patches wrote: On Fri, Dec 9, 2022 at 10:25 AM Raphael Moreira Zinsly wrote: Changes since v1: - Fixed formatting issues.

Re: [PATCH v2] RISC-V: Produce better code with complex constants [PR95632] [PR106602]

2023-03-05 Thread Andrew Pinski via Gcc-patches
On Sun, Mar 5, 2023 at 10:14 AM Jeff Law via Gcc-patches wrote: > > > > On 2/23/23 14:23, Andrew Pinski via Gcc-patches wrote: > > On Fri, Dec 9, 2022 at 10:25 AM Raphael Moreira Zinsly > > wrote: > >> > >> Changes since v1: > >> - Fixed formatting issues. > >> - Added a name

Re: [PATCH v2] RISC-V: Produce better code with complex constants [PR95632] [PR106602]

2023-03-05 Thread Jeff Law via Gcc-patches
On 2/23/23 14:23, Andrew Pinski via Gcc-patches wrote: On Fri, Dec 9, 2022 at 10:25 AM Raphael Moreira Zinsly wrote: Changes since v1: - Fixed formatting issues. - Added a name to the define_insn_and_split pattern. - Set the target on the 'dg-do compile' in

Re: [PATCH v4 5/9] riscv: thead: Add support for the XTheadBb ISA extension

2023-03-05 Thread Jeff Law via Gcc-patches
On 3/2/23 01:35, Christoph Muellner wrote: From: Christoph Müllner This patch adds support for the XTheadBb ISA extension. Thus, there is a functional overlap of the new instructions with existing Bitmanip instruction, which allows a good amount of code sharing. However, the vendor

Re: [PATCH] RISC-V: Fix ICE for avl_single-86/avl_single-88/avl_single-90

2023-03-05 Thread Kito Cheng via Gcc-patches
Committed, thanks for the fix :) On Sun, Mar 5, 2023 at 6:25 PM wrote: > > From: Ju-Zhe Zhong > > FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-86.c -Og -g (internal > compiler error: Segmentation fault) > FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-86.c -Og -g (test for > excess errors) >

Re: [PATCH 0/2] LoongArch: testsuite: Fix tests related to stack

2023-03-05 Thread Xi Ruoyao via Gcc-patches
On Fri, 2023-03-03 at 08:21 -0800, Mike Stump wrote: > On Mar 3, 2023, at 12:40 AM, Xi Ruoyao via Gcc-patches > wrote: > > > > Some trivial test case fixes.  Ok for trunk? > > Ok. Lulu: if you don't object I'll push these two in this week. I tried to bisect for the exact point where the test

[PATCH] RISC-V: Fix ICE for avl_single-86/avl_single-88/avl_single-90

2023-03-05 Thread juzhe . zhong
From: Ju-Zhe Zhong FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-86.c -Og -g (internal compiler error: Segmentation fault) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-86.c -Og -g (test for excess errors) FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-88.c -Og -g (internal compiler error:

Re: [PATCH V3 0/5] RISC-V: Implement Scalar Cryptography Extension

2023-03-05 Thread Kito Cheng via Gcc-patches
Committed, thanks! On Mon, Feb 20, 2023 at 3:01 PM Liao Shihua wrote: > > This series adds basic support for the Scalar Cryptography extensions: > * Zbkb > * Zbkc > * Zbkx > * Zknd > * Zkne > * Zknh > * Zksed > * Zksh > > The implementation follows the version Scalar Cryptography v1.0.0 of the

Re: [PATCH v4 0/9] RISC-V: Add XThead* extension support

2023-03-05 Thread Kito Cheng via Gcc-patches
LGTM :) On Thu, Mar 2, 2023 at 4:36 PM Christoph Muellner wrote: > > From: Christoph Müllner > > This series introduces support for the T-Head specific RISC-V ISA extensions > which are available e.g. on the T-Head XuanTie C906. > > The ISA spec can be found here: >

Re: [wwwdocs] gcc-13: riscv: Document the T-Head CPU support

2023-03-05 Thread Kito Cheng via Gcc-patches
LGTM :) On Fri, Feb 24, 2023 at 7:19 PM Christoph Muellner wrote: > > From: Christoph Müllner > > This patch documents the new T-Head CPU support for RISC-V. > > Signed-off-by: Christoph Müllner > --- > htdocs/gcc-13/changes.html | 24 +++- > 1 file changed, 23

Re: [PATCH] RISC-V: Fix wrong partial subreg check for bsetidisi

2023-03-05 Thread Kito Cheng via Gcc-patches
Committed, thanks! On Tue, Feb 28, 2023 at 5:32 PM Philipp Tomsich wrote: > > On Tue, 28 Feb 2023 at 06:00, Lin Sinan wrote: > > > > From: Lin Sinan > > > > The partial subreg check should be for subreg operand(operand 1) instead of > > the immediate operand(operand 2). This change also fix

Re: [PATCH] RISC-V: Allow const0_rtx operand in max/min

2023-03-05 Thread Kito Cheng via Gcc-patches
Committed, thanks! On Tue, Feb 28, 2023 at 12:36 PM Sinan wrote: > > From 73e743348a49a7fffcf2e328b8179e8dbbc3b2b4 Mon Sep 17 00:00:00 2001 > From: Lin Sinan > Date: Tue, 28 Feb 2023 00:44:55 +0800 > Subject: [PATCH] RISC-V: Allow const0_rtx operand in max/min > > Optimize cases that use