[patch] fix libstdc++/55861

2013-01-19 Thread Jonathan Wakely
objects. Tested x86_64-linux, committed to trunk. commit 0b1ce87e22ebcefbc19c9b26d58a1cd2a2654297 Author: Jonathan Wakely jwakely@gmail.com Date: Sat Jan 19 21:02:13 2013 + PR libstdc++/55861 * include/std/future (_State_base::_S_check(const shared_ptrT

Re: [PATCH] libstdc++: Fix up explicit-hle.cc test

2013-01-22 Thread Jonathan Wakely
On 22 January 2013 17:00, Jakub Jelinek wrote: Now in the form of a tested patch (regtested on x86_64-linux and i686-linux). Ok for trunk? OK, thanks. dg-additional-options unfortunately isn't supported in libstdc++ testsuite, so had to use second dg-options, and also the \(, \) were wrong

[patch] Improve docs for 128-bit integers in extend.texi

2013-01-22 Thread Jonathan Wakely
Committed as obvious. * doc/extend.texi (__int128): Improve grammar. commit b907a92691dbabe5755bc82c5e66718c8b255f4c Author: Jonathan Wakely jwakely@gmail.com Date: Tue Jan 22 21:36:04 2013 + * doc/extend.texi (__int128): Improve grammar. diff --git a/gcc/doc

Re: [patch] Update Downloading the source docs (Was: Components no longer exist)

2013-01-22 Thread Jonathan Wakely
6fe4893a2c8b4ebb1fbf84f0afc145412c5167b6 Author: Jonathan Wakely jwakely@gmail.com Date: Thu Jan 17 22:13:46 2013 + * doc/install.texi (Downloading the Source): Update references to downloading separate components. diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index

Re: [google gcc-4_7, integration] Scribble on destructed strings to catch invalid accesses.

2013-01-24 Thread Jonathan Wakely
On 24 January 2013 19:03, Marc Glisse wrote: On Wed, 23 Jan 2013, Paul Pluzhnikov wrote: This patch allows us to catch use of destructed strings. Hello, while a number of the google debug patches are just cheaper versions (that don't break the ABI) of what libstdc++'s debug mode provides,

[patch] Fix libstdc++/56112, inserting non-pairs into std::unordered_map

2013-01-27 Thread Jonathan Wakely
is present on the 4.6 and 4.7 branches, but not a regression. commit ca741fccc5d052db08ba839bd45ece7564ac5004 Author: Jonathan Wakely jwakely@gmail.com Date: Mon Jan 28 00:08:43 2013 + PR libstdc++/56112 * include/bits/hashtable_policy.h (insert(_Pair)): Use _M_emplace

Re: [v3] Fix management of non empty hash functor

2013-01-28 Thread Jonathan Wakely
On 10 January 2013 21:02, François Dumont wrote: Hi Here is an other version of this patch. Indeed there were no need to expose many stuff public. Inheriting from _Hash_code_base is fine, it is not final and it deals with EBO itself. I only kept usage of _Hashtable_ebo_helper when

Re: [v3] Fix management of non empty hash functor

2013-01-28 Thread Jonathan Wakely
On 28 January 2013 21:08, François Dumont wrote: (Do the performance benchmarks actually tell us anything useful? When I run them I get such varying results it doesn't seem to be reliable.) Last time I run the tests it was showing when not caching was better than caching. Yes, I've

Re: hasher speed traits

2013-02-03 Thread Jonathan Wakely
On 2 February 2013 21:57, François Dumont wrote: Hi Here is the last patch I can think of for 4.8. Thanks to it default performance reported in performance/23_containers/insert/54075.cc and performance/23_containers/insert_erase/41975.cc are always the best: Excellent. Ok to commit ?

[patch] partially fix libstdc++/56267

2013-02-10 Thread Jonathan Wakely
number. * testsuite/23_containers/unordered_set/ not_default_constructible_hash_neg.cc: Likewise. Tested x86_64-linux, committed to trunk, will also commit to 4.7 soon. commit 4eb16ce9981130d6322f474d22f9c1aeba2b864d Author: Jonathan Wakely jwakely@gmail.com Date: Sun Feb 10 22:12

[patch] fix libstdc++/56278

2013-02-10 Thread Jonathan Wakely
PR libstdc++/56278 * include/bits/hashtable_policy.h (_Hash_code_base): Make default constructor public. * testsuite/23_containers/unordered_set/56278.cc: New. Tested x86_64-linux, committed to trunk. commit b893384109ddb4dfc1afac24dc6b2c56557f2fa8 Author: Jonathan

Re: unordered containers doc

2013-02-10 Thread Jonathan Wakely
added for PR 56267, the change I committed is attached. Please let me know if you think it's wrong or unclear. 2013-02-10 François Dumont fdum...@gcc.gnu.org Jonathan Wakely jwakely@gmail.com * doc/xml/manual/containers.xml: Add section on unordered containers

Re: [PATCH, libstdc++] Fix 22_locale/time_get/get_weekday/char/38081-[12].cc tests for glibc 2.17

2013-02-11 Thread Jonathan Wakely
On 11 February 2013 17:18, Paolo Carlini wrote: I think it's Ok, yes. Thanks. However, I would appreciate if somebody with a glibc 2.17 system at hand could double check. Maybe HJ? Although I'm sure Carlos is right that they're close enough to not need checking, I've got a Rawhide setup with

Re: [PATCH, libstdc++] Fix 22_locale/time_get/get_weekday/char/38081-[12].cc tests for glibc 2.17

2013-02-11 Thread Jonathan Wakely
On 11 February 2013 19:15, Jonathan Wakely wrote: On 11 February 2013 17:18, Paolo Carlini wrote: I think it's Ok, yes. Thanks. However, I would appreciate if somebody with a glibc 2.17 system at hand could double check. Maybe HJ? Although I'm sure Carlos is right that they're close enough

Re: [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator

2011-03-10 Thread Jonathan Wakely
On 10 March 2011 09:47, Johannes Singler wrote: The attached patch patch solves a conformance problem of the parallel mode helper routine multiseq_partition.  I have added a test case for that.  multiseq_selection has similar problems, but is unused, so I plan to remove that completely (which

Re: [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator

2011-03-10 Thread Jonathan Wakely
On 10 March 2011 15:02, Johannes Singler wrote: Well, isn't it a bit ugly to define such a guard newly every time? It's one of my favourite techniques, the type is local and has no linkage, it should be nothing but a destructor call which is guaranteed to happen when exiting that scope. In

Re: [v3] typeinfo tuning

2011-03-15 Thread Jonathan Wakely
On 14 March 2011 17:29, Benjamin Kosnik wrote: I hacked up scripts/check_compile and ran the libstdc++ testsuite to generate 4k+ .s files, and then analyzed the resulting assembly files for vague linkage. Here are the clear wins that are ABI-compatible, or in C++0x code. There are other

[wwwdocs] addition to gcc-4.6/changes.html

2011-03-19 Thread Jonathan Wakely
I've committed this patch to note a change in G++, as requested in the comments of PR c++/44499 Index: htdocs/gcc-4.6/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.6/changes.html,v retrieving revision 1.114 diff -u -r1.114

[doc patch] fix PRs 48179, 48221 and 48234

2011-03-22 Thread Jonathan Wakely
numbering. This is problem is present on all active release branches. 48221 simply replaces -Wcpp with -Wno-cpp in the options summary and removes a stray backslash which prevents the option appearing in the HTML docs. This is only relevant for 4.6 and trunk. 2011-03-22 Jonathan Wakely jwakely

Re: [doc patch] obvious partial fix for other/48254

2011-03-24 Thread Jonathan Wakely
On 24 March 2011 10:12, Richard Guenther wrote: On Wed, Mar 23, 2011 at 11:03 PM, Jonathan Wakely jwakely@gmail.com wrote: Committed to 4.4 and 4.5 branches as obvious, will apply to 4.6 after 4.6.0 is released. The option's gone on the trunk so not relevant there. If you apply

Re: regex issue

2011-03-25 Thread Jonathan Wakely
On 25 March 2011 22:38, Jonathan Wakely wrote: The tests are invalid. There were preconditions added to match_results member functions recently, which we now check in debug mode, and those tests violate them. I'll deal with it, thanks for testing it. 2011-03-25 Jonathan Wakely jwakely

[v3] implement LWG issues 1514, 2030, 2031

2011-03-25 Thread Jonathan Wakely
2011-03-25 Jonathan Wakely jwakely@gmail.com * include/std/future (future::share): Add. (packaged_task::result_type): Remove as per LWG 2030. (packaged_task::packaged_task): Remove redundant constructors, as per LWG 1514. * testsuite/30_threads/future

Re: [C++0x] Range-based for statements and ADL

2011-03-29 Thread Jonathan Wakely
On 29 March 2011 01:49, Rodrigo Rivas wrote: Hi again. Here it is my first try at this. I have changed the list to gcc-patches, I don't know if cross post would be correct. Please, note that this patch is not finished: the new test cases are still missing, and expect format mistakes, 

Re: [C++0x] Range-based for statements and ADL

2011-03-29 Thread Jonathan Wakely
On 29 March 2011 21:33, Rodrigo Rivas wrote: On Tue, Mar 29, 2011 at 8:22 PM, Jonathan Wakely jwakely@gmail.com wrote: How about No suitable %begin% and %end% functions found for range expression of type %qT in %for% statement ? Nice. But the problem here is that there are a lot

Re: [C++0x] Range-based for statements and ADL

2011-03-31 Thread Jonathan Wakely
On 31 March 2011 21:22, Rodrigo Rivas wrote: On Thu, Mar 31, 2011 at 7:22 PM, Jason Merrill ja...@redhat.com wrote: On 03/28/2011 08:28 PM, Rodrigo Rivas wrote: A few comments: 1. I'm not sure about what should happen if the begin/end found in class scope are not ordinary functions.

fix PR libstdc++/48398

2011-04-02 Thread Jonathan Wakely
2011-04-02 Jonathan Wakely r...@gcc.gnu.org PR libstdc++/48398 * include/bits/unique_ptr.h (__tuple_type): Store pointer type. * testsuite/20_util/unique_ptr/modifiers/48398.cc: New. * testsuite/20_util/unique_ptr/requirements/pointer_type.cc: Remove

Re: typo in gcc manual

2011-04-06 Thread Jonathan Wakely
.) --- happened should be replaced with happen or with be happned I think. Thanks, fixed by this patch, committed to trunk as obvious 2011-04-06 Jonathan Wakely jwakely@gmail.com * doc/invoke.texi (Spec Files): Fix typo. Index: doc/invoke.texi

Re: Confirming a bug in new bugzilla?

2011-04-10 Thread Jonathan Wakely
On 10 April 2011 23:51, Frédéric Buclin wrote: Le 10. 04. 11 02:19, Joseph S. Myers a écrit : Likewise.  We don't use VERIFIED and CLOSED in GCC, proper text should reflect the existence of only one closed state with a genuine meaning and not mention the others (ideally they'd be completely

Re: Intrinsics for N2965: Type traits and base classes

2011-09-28 Thread Jonathan Wakely
On 28 September 2011 04:22, Michael Spertus wrote: Benjamin, I think tuple is wrong both for performance reasons (I believe these are likely to be serious enough to depress use due to inordinately long compiles) and because it prematurely locks us into a rigid choice of how our typelists

Re: Intrinsics for N2965: Type traits and base classes

2011-10-03 Thread Jonathan Wakely
On 3 October 2011 02:55, Michael Spertus wrote: Index: gcc/c-family/c-common.h === --- gcc/c-family/c-common.h     (revision 178892) +++ gcc/c-family/c-common.h     (working copy) @@ -139,7 +139,8 @@   RID_IS_LITERAL_TYPE,      

[v3] testsuite tweak

2011-10-03 Thread Jonathan Wakely
2011-10-03 Jonathan Wakely jwakely@gmail.com * testsuite/20_util/pointer_traits/pointer_to.cc: Define equality operator and use. Tested x86_64-linux, committed to trunk. Index: testsuite/20_util/pointer_traits/pointer_to.cc

[wwwdocs] add libstdc++/1773 change to gcc-4.7/changes.html

2011-10-04 Thread Jonathan Wakely
I've committed this, which documents the fix for http://gcc.gnu.org/PR1773 in gcc-4.7/changes.html, and also replaces some characters with the gt; entity. Index: changes.html === RCS file:

[doc] fix broken anchor in install.texi

2011-10-04 Thread Jonathan Wakely
-10-04 Jonathan Wakely jwakely@gmail.com * doc/install.texi (Specific): Fix anchor for x86_64-*-solaris2.1[0-9]* Index: install.texi === --- install.texi(revision 179520) +++ install.texi(working

[v3] add max_size and rebind to __alloc_traits

2011-10-04 Thread Jonathan Wakely
2011-10-04 Jonathan Wakely jwakely@gmail.com * include/ext/alloc_traits.h (__alloc_traits::max_size): Define. (__alloc_traits::rebind): Define. * include/bits/stl_vector.h: Use them. * testsuite/util/testsuite_allocator.h (SimpleAllocator): Define

[v3] define string::pop_back()

2011-10-04 Thread Jonathan Wakely
This adds the new C++11 pop_back() member to string, debug/string and ext/vstring.h, as added by LWG 534. * include/bits/basic_string.h (basic_string::pop_back): Define. * include/ext/vstring.h (versa_string::pop_back): Define. * include/debug/string

[v3] use NSDMI in C++11 mutex types

2011-10-04 Thread Jonathan Wakely
Now that G++ supports non-static data member initializers, I want to use it for initializing the __gthread_mutex_t members of std::mutex and friends: __native_type _M_mutex = __GTHREAD_MUTEX_INIT; This is more portable than our current code, which does: constexpr mutex() noexcept :

Re: [v3] add max_size and rebind to __alloc_traits

2011-10-06 Thread Jonathan Wakely
On 6 October 2011 02:57, Paolo Carlini wrote: today I ran the whole testsuite in C++0x mode and I'm pretty sure that 23_containers/vector/modifiers/swap/3.cc, which is now failing, wasn't a couple of days ago (I ran the whole testsuite like that in order to validate my std::list changes).

Re: [v3] use NSDMI in C++11 mutex types

2011-10-06 Thread Jonathan Wakely
On 6 October 2011 23:15, Benjamin Kosnik wrote: Does anyone have any comments or objections to going in this direction?  If the new base classes aren't OK the NSDMI syntax could still be used, just without refactoring to remove the code duplication. I like where you are going here. This

Re: [wwwdocs] add libstdc++/1773 change to gcc-4.7/changes.html

2011-10-10 Thread Jonathan Wakely
On 10 October 2011 02:10, Gerald Pfeifer wrote: On Tue, 4 Oct 2011, Jonathan Wakely wrote: I've committed this, which documents the fix for http://gcc.gnu.org/PR1773 in gcc-4.7/changes.html, and also replaces some characters with the gt; entity. Interesting that the latter was not caught

[v3] libstdc++/50196 - enable std::thread, std::mutex etc. on darwin

2011-10-20 Thread Jonathan Wakely
This patch should enable macosx support for thread and partial support for mutex, by defining _GLIBCXX_HAS_GTHREADS on POSIX systems without the _POSIX_TIMEOUTS option, and only disabling the types which rely on the Timeouts option, std::timed_mutex and std::recursive_timed_mutex, instead of

Re: [v3] libstdc++/50196 - enable std::thread, std::mutex etc. on darwin

2011-10-21 Thread Jonathan Wakely
On 21 October 2011 00:43, Jonathan Wakely wrote: This patch should enable macosx support for thread and partial support for mutex, by defining _GLIBCXX_HAS_GTHREADS on POSIX systems without the _POSIX_TIMEOUTS option, and only disabling the types which rely on the Timeouts option, std

Re: [v3] libstdc++/50196 - enable std::thread, std::mutex etc. on darwin

2011-10-21 Thread Jonathan Wakely
On 21 October 2011 09:15, Jonathan Wakely wrote: On 21 October 2011 00:43, Jonathan Wakely wrote: This patch should enable macosx support for thread and partial support for mutex, by defining _GLIBCXX_HAS_GTHREADS on POSIX systems without the _POSIX_TIMEOUTS option, and only disabling

Re: [v3] libstdc++/50196 - enable std::thread, std::mutex etc. on darwin

2011-10-22 Thread Jonathan Wakely
Plus this bit, which I didn't include in my 'svn diff' command for the last patches: * testsuite/30_threads/unique_lock/cons/5.cc: Likewise. * testsuite/30_threads/unique_lock/cons/6.cc: Likewise. * testsuite/30_threads/unique_lock/locking/3.cc: Likewise. *

Re: [v3] libstdc++/50196 - enable std::thread, std::mutex etc. on darwin

2011-10-22 Thread Jonathan Wakely
I've committed this, if I've broken anything for non-POSIX platforms there will be time to fix it before 4.7

libstdc++/50834 - update thread safety docs w.r.t. C++11

2011-10-23 Thread Jonathan Wakely
PR libstdc++/50834 * doc/xml/manual/using.xml: Update thread safety docs w.r.t. C++11. committed to trunk Index: doc/xml/manual/using.xml === --- doc/xml/manual/using.xml (revision 180334) +++ doc/xml/manual/using.xml

Re: [v3] libstdc++/50196 - enable std::thread, std::mutex etc. on darwin

2011-10-24 Thread Jonathan Wakely
On 24 October 2011 08:27, Iain Sandoe wrote: Hi Jonathan, On 22 Oct 2011, at 22:54, Jonathan Wakely wrote: I've committed this, if I've broken anything for non-POSIX platforms there will be time to fix it before 4.7 At present, (180333-180339) these tests seem to be failing on *-darwin

Re: [v3] use NSDMI in C++11 mutex types

2011-10-24 Thread Jonathan Wakely
PR libstdc++/49894 * include/std/mutex (__mutex_base,__recursive_mutex_base): Define new base classes to manage construction/destruction of native mutexes, using NSDMI when INIT macros are defined. (mutex,recursive_mutex,timed_mutex,recursive_timed_mutex):

libstdc++/50862 fix deadlock in condition_variable_any

2011-10-25 Thread Jonathan Wakely
PR libstdc++/50862 * include/std/condition_variable (condition_variable_any::wait): Fix deadlock and ensure _Lock::lock() is called on exit. (condition_variable_any::native_handle): Remove, as per LWG 1500. *

Re: [v3] use NSDMI in C++11 mutex types

2011-10-25 Thread Jonathan Wakely
This is a follow up to my last two changes to the condition_variable code. For some reason G++ didn't reject the explicitly-defaulted functions in src/condition_variable.cc even though they had different exception specifications to the declaration. I will try to file that in bugzilla but can't

Re: libstdc++/50862 fix deadlock in condition_variable_any

2011-10-26 Thread Jonathan Wakely
PR libstdc++/50862 * include/std/condition_variable (condition_variable_any::wait): Avoid terminating if relocking user mutex throws during stack-unwinding. * testsuite/30_threads/condition_variable_any/50862.cc: Add dg-require. Fixes two more issues pointed out in

Re: [v3] fix libstdc++/52476

2012-04-09 Thread Jonathan Wakely
On 9 April 2012 20:25, François Dumont wrote: I don't think I have the necessary rights to close the PR on bugzilla, I haven't been able to do so. You should be able to using your @gcc.gnu.org account. What if you assign it to yourself first?

[v3] fix broken performance test

2012-04-11 Thread Jonathan Wakely
This fixes a check-performance failure caused by my changes for libstdc++/49204 * testsuite/performance/30_threads/future/polling.cc: Adjust. Tested x86_64-linux, committing to trunk and 4.7 branch. commit fbb91a75e318226e666967a28883483a027f1f07 Author: Jonathan Wakely jwakely

[v3] tweak docs

2012-04-11 Thread Jonathan Wakely
I think this makes the text read a bit better. * doc/xml/manual/debug.xml (Debug Versions of Library Binary Files): Re-arrange text slightly. Committed to trunk commit 74b28e0fa40289525b44c79920cbd64a36a0cb52 Author: Jonathan Wakely jwakely@gmail.com Date: Wed Apr 11 23:13

fix libstdc++/52924

2012-04-11 Thread Jonathan Wakely
-error line numbers. Tested x86_64-linux, committed to trunk and 4.7 commit bab6adfa9c9cf5d3fd47c5eeffe7c4f58091ef3d Author: Jonathan Wakely jwakely@gmail.com Date: Wed Apr 11 10:05:00 2012 +0100 PR libstdc++/52924 * include/bits/shared_ptr_base.h (_Sp_counted_deleter

Re: Duplicate Words In GCC 4.7.0 Changes Page

2012-04-20 Thread Jonathan Wakely
Oops, meant to CC gcc-patches ... On 21 April 2012 01:01, Jonathan Wakely jwakely@gmail.com wrote: On 21 April 2012 00:37, Todd Edwards wrote: In Section New Languages and Language specific improvements In subsection C Family Objective-C is repeated twice. : A new experimental -ftrack

Re: [libcpp] maybe canonicalize system paths in line-map

2012-04-21 Thread Jonathan Wakely
I think this patch is a *huge* improvement for C++ diagnostics that refer to standard library files, I really hope it will be approved in some form. On 21 April 2012 12:58, Manuel López-Ibáñez lopeziba...@gmail.com wrote: Ping: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00903.html On 15

Re: [v3] Add missing forward_list::splice_after and merge overloads fix splice_after taking a range

2012-04-22 Thread Jonathan Wakely
On 16 April 2012 21:28, Jonathan Wakely wrote: I have a patch to add the checks to debug/forward_list And here it is, only checking in debug mode because noone objected to that suggestion. * include/debug/forward_list (forward_list::splice_after): Check allocators are equal

[v3] fix libstdc++/53027

2012-04-22 Thread Jonathan Wakely
: Jonathan Wakely jwakely@gmail.com Date: Fri Apr 20 09:13:44 2012 +0100 * include/bits/ptr_traits.h (pointer_traits::rebind): Make public. * testsuite/20_util/pointer_traits/requirements/typedefs.cc: Check rebind works. diff --git a/libstdc++-v3/include/bits

[v3] add difference_type to __gnu_cxx::__alloc_traits

2012-04-22 Thread Jonathan Wakely
The allocator_traits wrapper is missing difference_type, noticed while making vstring allocator-aware. * include/ext/alloc_traits.h (__alloc_traits::difference_type): Define. Tested x86_64-linux, committed to trunk. commit 7a3e74660df7df20bebb7676cd9142841637ba40 Author: Jonathan

Re: [google/integration] Extend C++11 UDLs to be compatible with inttypes.h macros (issue6104051)

2012-04-23 Thread Jonathan Wakely
On 23 April 2012 04:10, Jeffrey Yasskin wrote: Could you try to get this into mainline instead of just the google branches? In http://gcc.gnu.org/PR52538, Jonathan sounded like he'd consider accepting it. I think it's useful, but I can't approve front-end patches.

Re: FW: [v3] libstdc++/52689 testcase

2012-04-25 Thread Jonathan Wakely
On 25 April 2012 08:33, Igor Zamyatin wrote: This testcase is reported as failed on x86 Yep. http://gcc.gnu.org/ml/gcc-testresults/2012-04/msg02547.html Benjamin? Noticed that this testcase wasn't put in as part of the patch. Fixed as follows. tested x86/linux -benjamin

[v3] fix scoped_allocator problems

2012-04-25 Thread Jonathan Wakely
* include/std/scoped_allocator (scoped_allocator::__outermost): Do not pass non-POD to varargs function. * testsuite/20_util/scoped_allocator/1.cc: Fix test. This fixes a potential problem in scoped_allocator and fixes a broken test (and ensures it actually runs!) Tested

Re: [libcpp] maybe canonicalize system paths in line-map

2012-04-26 Thread Jonathan Wakely
On 26 April 2012 11:12, Dodji Seketeli wrote: So maybe it'd be better to canonicalize the _cpp_file::path when it's first build?  One drawback of that approach would be that _cpp_file::path will then permanently loose the information about the current directory, that is indirectly encoded

[v3] constrain std::function constructor to only accept callable types

2012-04-29 Thread Jonathan Wakely
. * include/std/functional (function::function(F)): LWG 2132: Disable constructor if argument isn't callable. * testsuite/20_util/function/cons/callable.cc: New. Tested x86_64-linux, committed to trunk. commit 0e069c4221d6ed4fda7d10938470c472170dcad7 Author: Jonathan Wakely

[v3] update outdated allocator docs

2012-05-02 Thread Jonathan Wakely
. * doc/xml/manual/debug.xml: Likewise. * doc/xml/manual/evolution.xml: Likewise. * doc/xml/manual/using.xml: Likewise. Tested x86_64-linux, committed to trunk. commit 54ea46758e35adc8b42ee35dafdf0b43e9980104 Author: Jonathan Wakely jwakely@gmail.com Date: Thu May 3 00:12:48

Re: [v3] PR 53270 fix hppa-linux bootstrap regression

2012-07-22 Thread Jonathan Wakely
close the PR as fixed. commit 36d2e77bb740df5f9ef68a52f7cac95f8306dfd1 Author: Jonathan Wakely jwakely@gmail.com Date: Sun Jul 22 02:02:09 2012 +0100 PR libstdc++/53270 * acinclude.m4 (GLIBCXX_GTHREADS_CXX11_COPY_ASSIGN): Define. * configure.ac

Re: PR 54075 Fix hashtable::reserve

2012-07-25 Thread Jonathan Wakely
(CC gcc-patches) On 25 July 2012 10:26, François Dumont wrote: Hi Here is a patch proposal for PR 54075. I also took the occasion to fix something that has been delay so far which is usage of std::max to get the number of buckets to use. The problem of using std::max when using the hash

Re: PR 54075 Fix hashtable::reserve

2012-07-26 Thread Jonathan Wakely
On 25 July 2012 21:29, François Dumont wrote: (_Hashtable::rehash): Likewise. Set _M_prev_resize to 0 to avoid the hashtable to be shrinking on next insertion. Not to be shrinking just shrinking, but nevermind.

Re: PR 54075 Restore 4.6 growth factor

2012-07-28 Thread Jonathan Wakely
Please remember to CC gcc-patches too. On 28 July 2012 21:49, François Dumont wrote: Hi Here is the patch to restore the 4.6 growth factor of 2. I prefer to validate the restored behavior by adding a performance test. Without the patch the result was: unordered_set.cc

Re: PR 54075 Restore 4.6 growth factor

2012-07-29 Thread Jonathan Wakely
On 29 July 2012 18:15, François Dumont wrote: Patch applied. I usually CC to gcc-patches when I signal that it has been applied. Should I send it all my patch proposals ? Yes please. The point is to allow people to review and comment before the patch is applied, and some people only subscribe

Re: _GLIBCXX_END_NAMESPACE_* invalid closure order

2012-07-30 Thread Jonathan Wakely
On 30 July 2012 20:16, François Dumont wrote: Ok for trunk ? OK, thanks.

Re: Remove redundant comparison in debug mode

2012-08-02 Thread Jonathan Wakely
On 1 August 2012 20:34, François Dumont wrote: Ok for trunk ? OK, thanks.

[v3] reorder headers in memory

2012-08-02 Thread Jonathan Wakely
/20_util/unique_ptr/assign/48635_neg.cc: Likewise. Tested x86_64-linux, committed to trunk. commit 9386ced4bfd9990046d2dec6a080478c8cc01c50 Author: Jonathan Wakely jwakely@gmail.com Date: Fri Aug 3 01:25:19 2012 +0100 * include/std/memory: Include auto_ptr.h later. * include

Re: Value type of map need not be default copyable

2012-08-09 Thread Jonathan Wakely
On 9 August 2012 09:35, Paolo Carlini wrote: When it does, and the corresponding PR will be *ready* we'll reconsider the issue. After all the *months and months and months* spent by the LWG adding and removing members from pair and tweaking everything wrt the containers and issues *still*

[v3] fix references to C++11 standard

2012-08-09 Thread Jonathan Wakely
: Likewise. * include/std/chrono: Likewise. * include/std/thread: Likewise. Tested x86_64-linux, committed to trunk. commit 0d6bc17d16d85865ed4b6deffd455d3e1e12f430 Author: Jonathan Wakely jwakely@gmail.com Date: Thu Aug 9 23:21:27 2012 +0100 * acinclude.m4: Update

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-10 Thread Jonathan Wakely
On 10 August 2012 20:49, Tom Tromey wrote: A user reported on irc that the std::unique_ptr pretty-printer yields bad results. For example: (gdb) p uptr $1 = std::tuple containing = { [1] = , [2] = { std::default_deletedatum = {No data fields}, No data fields} } This omits the

Re: complex.h

2012-08-10 Thread Jonathan Wakely
Let's CC Gaby, who likes to keep an eye on patches involving complex On 10 August 2012 20:17, Marc Glisse wrote: Ping http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01440.html On Sat, 28 Jul 2012, Marc Glisse wrote: Hello, here is a patch for PR54112. It does 2 things: * #undef complex

Re: Value type of map need not be default copyable

2012-08-12 Thread Jonathan Wakely
On 11 August 2012 14:47, Marc Glisse wrote: What testcase failed? I just tried the 2.cc file you added with the patch, and replacing forwardkey_type(__k) with move(__k) compiled fine. Shouldn't it be std::move(__k) to disable ADL though?

Re: [v3] improve exception text when threads not enabled

2012-08-13 Thread Jonathan Wakely
On 13 August 2012 16:47, Joe Buck joe.b...@synopsys.com wrote: On Sun, Aug 12, 2012 at 08:02:30PM +0100, Jonathan Wakely wrote: This improves the fairly uninformative Operation not supported message given when std::thread is used without linking to libpthread. Now you get: terminate called

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-13 Thread Jonathan Wakely
On 13 August 2012 14:31, Tom Tromey wrote: Jonathan == Jonathan Wakely jwakely@gmail.com writes: $11 = std::unique_ptr containing (datum *) 0x6067d0 Jonathan It's inconsistent with the other printers in that it prints Jonathan the stored type, unlike e.g. std::vectorint which just says

Re: complex.h

2012-08-13 Thread Jonathan Wakely
On 13 August 2012 12:57, Marc Glisse wrote: I only modified the xml version. I expect the html version will be updated the next time someone who knows what they are doing touches the doc... That's no problem, I tend to regenerate the html fairly frequently. Thanks.

Re: [v3] improve exception text when threads not enabled

2012-08-13 Thread Jonathan Wakely
On 13 August 2012 18:49, Jonathan Wakely wrote: I suppose EOPNOTSUPP might be better, if it's supported everywhere. EPERM has the advantage of being a documented error for pthread_create. We do define std::errc::operation_not_supported unconditionally on most platforms, but not mingw or djgpp

[v3] fix libstdc++/54185

2012-08-13 Thread Jonathan Wakely
/condition_variable/54185.cc: New. Tested x86-64-linux, committed to 4.7 and trunk. Thanks for the bug report and patch, David. commit 03a66e46ee35b74372da5c46caa4e7761d10b4c8 Author: Jonathan Wakely jwakely@gmail.com Date: Mon Aug 13 19:45:30 2012 +0100 2012-08-13 David Adler d.adle

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-15 Thread Jonathan Wakely
On 14 August 2012 15:44, Tom Tromey wrote: Jonathan == Jonathan Wakely jwakely@gmail.com writes: Jonathan I prefer it as unique_ptrdatum but I'm probably not your typical Jonathan user of the pretty printers, so if anyone else has an opinion please Jonathan share it. I prefer it too

[v3] correction to C++11 status table

2012-08-23 Thread Jonathan Wakely
PR libstdc++/54354 * doc/xml/manual/status_cxx2011.xml: Note missing manipulators. * doc/html/*: Regenerate. Committed to trunk.

[v3] fix PR 54248

2012-08-25 Thread Jonathan Wakely
PR libstdc++/54248 * include/bits/concept_check.h: Replace references to boost namespace. Committed to trunk. commit c545fcbc54ee0a5990c5c9cf84116b55ab07475a Author: Jonathan Wakely jwakely@gmail.com Date: Sat Aug 25 19:49:10 2012 +0100 PR libstdc++/54248

[v3] fix PR 54297 - segfaults with std::async

2012-08-25 Thread Jonathan Wakely
. * testsuite/30_threads/async/54297.cc: New. Tested x86_64-linux, committed to trunk and 4.7 commit 1006a99bff42b02e8ff7d2eaa696d639cfe3d0d7 Author: Jonathan Wakely jwakely@gmail.com Date: Sat Aug 25 19:25:27 2012 +0100 PR libstdc++/54297 * include/std/future

Re: random numbers in bulk

2012-08-25 Thread Jonathan Wakely
On 26 August 2012 00:33, Ulrich Drepper drep...@gmail.com wrote: On Sat, Aug 25, 2012 at 5:42 PM, Paolo Carlini paolo.carl...@oracle.com wrote: Personally, assuming the name itself is already reserved / used elsewhere, That was my thinking as well. There shouldn't be any further namespace

[v3] fix PR 54351

2012-08-25 Thread Jonathan Wakely
2012-08-26 Jonathan Wakely jwakely@gmail.com Geoff Romer gro...@google.com PR libstdc++/54351 * include/bits/unique_ptr.h (unique_ptrT::~unique_ptr): Do not use reset(). (unique_ptrT[]::~unique_ptr()): Likewise. * testsuite/20_util

Re: [v3] correction to C++11 status table

2012-08-25 Thread Jonathan Wakely
On 23 August 2012 09:38, Jonathan Wakely wrote: PR libstdc++/54354 * doc/xml/manual/status_cxx2011.xml: Note missing manipulators. * doc/html/*: Regenerate. Committed to trunk. I forgot to attach the patch, here it is. diff --git a/libstdc++-v3/doc/xml/manual

Re: random numbers in bulk

2012-08-26 Thread Jonathan Wakely
On 26 August 2012 14:08, Ulrich Drepper wrote: If people agree this is acceptable and the consensus is that generate_n() is the better name I can submit a patch so that the remaining random work can be submitted. Still ways to go... Unless you're thinking of changing the interface to take a

Re: [v3] fix PR 54297 - segfaults with std::async

2012-08-26 Thread Jonathan Wakely
On 26 August 2012 00:02, Jonathan Wakely wrote: This fixes a stupid mistake I made where the functor and asynchronous result can go out of scope before the async thread is joined. The _Async_state_common destructor still needs to be exported from the library, which is what the macro hack

Re: Is libstdcxx-time still experimental?

2012-08-26 Thread Jonathan Wakely
On 26 August 2012 18:06, Jonathan Wakely wrote: On Aug 26, 2012 4:17 PM, H.J. Lu wrote: Hi, According to http://gcc.gnu.org/ml/libstdc++/2010-04/msg00064.html One reason of --enable-libstdcxx-time=no on Linux is not all users will want for an experimental c++0x mode. Is this feature

Re: random numbers in bulk

2012-08-26 Thread Jonathan Wakely
On 26 August 2012 18:19, Ulrich Drepper wrote: Also, I consider the interface clean and now very C++-y. Iterators are used and transparently all kinds of overloads are possible. Only the iterator variants need to be documented, making the extensions easy to use. The only minor complication

Re: random numbers in bulk

2012-08-26 Thread Jonathan Wakely
On 26 August 2012 18:34, Jonathan Wakely wrote: On 26 August 2012 18:19, Ulrich Drepper wrote: Also, I consider the interface clean and now very C++-y. Iterators are used and transparently all kinds of overloads are possible. Only the iterator variants need to be documented, making

PR 43852: new configure option --disable-libstdcxx-verbose

2012-08-27 Thread Jonathan Wakely
/O code, reducing the footprint of libstdc++. 2012-08-27 Sebastian Huber sebastian.hu...@embedded-brains.de Jonathan Wakely jwakely@gmail.com * acinclude.m4 (GLIBCXX_ENABLE_VERBOSE): Define. * configure.ac (GLIBCXX_ENABLE_VERBOSE): Use it. * config.h.in

Re: [PATCH, libstdc++] Make empty std::string storage readonly

2012-08-28 Thread Jonathan Wakely
On 28 August 2012 16:15, Michael Haubenwallner wrote: Hi, in some old, large, originally C-written application (using gcc-4.2.4 still) I did have to find a bug that boils down to something like this: std::string x; strcpy( (char*) x.c_str(), abc); Any subsequent empty std::string

Re: PR 43852: new configure option --disable-libstdcxx-verbose

2012-08-28 Thread Jonathan Wakely
On 28 August 2012 18:29, Mike Stump wrote: On Aug 27, 2012, at 10:15 AM, Jonathan Wakely wrote: Unless anyone has objections I'm going to commit this to trunk, implementing Sebastian's idea to disable the verbose terminate handler and the pure virtual function called message, which write

Re: [PATCH, libstdc++] Make empty std::string storage readonly

2012-08-28 Thread Jonathan Wakely
On 28 August 2012 18:27, Michael Haubenwallner wrote: Does it actually produce a segfault? I suppose it might on some platforms, but not all, so I'm not sure it's worth changing. It does segfault here on (32bit each): i686-pc-linux-gnu ia64-hp-hpux11.31 i386-pc-solaris2.10

Re: [v3] libstdc++/54296

2012-08-28 Thread Jonathan Wakely
On 28 August 2012 11:08, François Dumont wrote: (erase(const key_type)): Use latters. Let's put Use the new member functions here in the ChangeLog, I don't think you can make a plural out of latter :-) * testsuite/23_containers/unordered_map/erase/54296.cc: New. *

<    1   2   3   4   5   6   7   8   9   10   >