[PATCH] Fix detection of thread support with uClibc in libgcc

thread library together with the uClibc implementation of libpthread. This caused a large number of failed tests from the g++, libgomp and libstdc++ testsuites when run on a MIPS Linux target with uClibc as the C library. Kwok 2014-10-11 Kwok Cheung Yeung k...@codesourcery.com libgcc

Re: [PATCH] Fix detection of thread support with uClibc in libgcc

On 11/10/2014 5:56 PM, Andrew Pinski wrote: On Sat, Oct 11, 2014 at 9:42 AM, Kwok Cheung Yeung k...@codesourcery.com wrote: __gthread_active_p() in libgcc checks for thread support by looking for the presence of a symbol from libpthread. With glibc, it looks for __pthread_key_create. However

[PATCH] Fix for PR26702: Emit .size for BSS variables on arm-eabi

4 NOTYPE LOCAL DEFAULT3 static_foo ... The testsuite has been run with a i686-pc-linux-gnu hosted cross-compiler targetted at arm-none-eabi with no regressions. Kwok 2015-03-30 Kwok Cheung Yeung k...@codesourcery.com gcc/ PR target/26702 * config/arm/unknown-elf.h

Re: [PATCH] Fix for PR26702: Emit .size for BSS variables on arm-eabi

Hello The target of the pr26702.c testcase was changed while committing from: { target arm*-*-eabi* } in my original patch to: { target arm_eabi } The check_effective_target_arm_eabi test (in gcc/testsuite/lib/target-supports.exp) checks for the presence of the __ARM_EABI__ preprocessor

[PATCH] Add myself to MAINTAINERS

Fei Yang Jeffrey Yasskin Joey Ye +Kwok Cheung Yeung Greta Yorsh David Yuste

[PATCH 4/4] [og8] Add tests for Fortran optional arguments in OpenACC 2.6

-calls.f90 + * testsuite/libgomp.oacc-fortran/optional-private.f90 + * testsuite/libgomp.oacc-fortran/optional-reduction.f90 + * testsuite/libgomp.oacc-fortran/optional-update-device.f90 + * testsuite/libgomp.oacc-fortran/optional-update-host.f90 + +2019-01-30 Kwok Cheung Yeung

[PATCH 1/4] [og8] Allow NULL for update directives in OpenACC 2.6

, 11 insertions(+) diff --git a/libgomp/ChangeLog.openacc b/libgomp/ChangeLog.openacc index a9a30d2..69bd1ee 100644 --- a/libgomp/ChangeLog.openacc +++ b/libgomp/ChangeLog.openacc @@ -1,3 +1,8 @@ +2019-01-30 Kwok Cheung Yeung + + * oacc-mem.c (update_dev_host): Return early if the host

[PATCH 0/4] [og8] Add support for Fortran optional arguments in OpenACC

This patch series adds support for the use of Fortran optional arguments in OpenACC constructs as specified by the OpenACC 2.6 standard. I will shortly commit these to openacc-gcc-8-branch if there are no objections. Kwok

[PATCH 2/4] [og8] Calculate correct size for optional arguments used in the firstprivate clause

+ gcc/omp-low.c | 3 ++- 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/gcc/ChangeLog.openacc b/gcc/ChangeLog.openacc index 744cf02..04d18c0 100644 --- a/gcc/ChangeLog.openacc +++ b/gcc/ChangeLog.openacc @@ -1,3 +1,10 @@ +2019-01-30 Kwok Cheung Yeung + + * omp-general.c

[PATCH 3/4] [og8] Add support for allocatable arrays as optional arguments

@@ +2019-01-30 Kwok Cheung Yeung + + * trans-openmp.c (gfc_build_conditional_assign): New. + (gfc_build_conditional_assign_expr): New. + (gfc_omp_finish_clause): Add conditionals to set the clause + declaration to null and size to zero if the declaration is a + non

[PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

b/gcc/ChangeLog.openacc index 5104eaa..58258fd 100644 --- a/gcc/ChangeLog.openacc +++ b/gcc/ChangeLog.openacc @@ -1,5 +1,12 @@ 2019-01-31 Kwok Cheung Yeung + * omp-low.c (lower_omp_target): For use_device clauses, generate + conditional statements to treat Fortran optional arguments

Re: [PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

I have retested all the failing cases and they now pass with the attached patch. I will commit this to openacc-gcc-8-branch now as the fix is obvious. Kwok On 01/02/2019 6:02 pm, Kwok Cheung Yeung wrote: There is an error in the logic here: --- a/gcc/omp-low.c +++ b/gcc/omp-low.c

Re: [PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

this allows at least libgomp.oacc-fortran/host_data-1.f90 to pass again. I will post the patch when I have double-checked the other cases. Thanks Kwok On 01/02/2019 4:24 pm, Thomas Schwinge wrote: Hi Kwok! On Thu, 31 Jan 2019 18:30:35 +, Kwok Cheung Yeung wrote: This patch allows for the use

[PATCH] [og8] Ensure that optional-arguments check is specific to Fortran

..5104eaa 100644 --- a/gcc/ChangeLog.openacc +++ b/gcc/ChangeLog.openacc @@ -1,3 +1,8 @@ +2019-01-31 Kwok Cheung Yeung + + * omp-general.c (omp_is_optional_argument): Add comment. Add extra + check for Fortran language. + 2019-01-31 Julian Brown * gimplify.c

Re: [PATCH 4/4] [og8] Add tests for Fortran optional arguments in OpenACC 2.6

22:24:48 +, Kwok Cheung Yeung wrote: diff --git a/libgomp/testsuite/libgomp.oacc-fortran/optional-host_data.f90 b/libgomp/testsuite/libgomp.oacc-fortran/optional-host_data.f90 new file mode 100644 I'm seeing this one fail at run time: "libgomp: use_device_ptr pointer wasn't m

Re: [wwwdocs] Document existence of openacc-gcc-9-branch

Hello On 04/06/2019 11:05 pm, Julian Brown wrote: Hi, I've pushed a new branch "openacc-gcc-9-branch" to the Git mirror (i.e. as a Git-only branch), for development of OpenACC and related functionality on top of the GCC 9 branch. It's currently based off the gcc-9_1_0-release tag, and contains

[PATCH 5/5, OpenACC] Add tests for Fortran optional arguments in OpenACC 2.6

This adds testcases exercising the use of optional arguments in the various OpenACC directives. Where applicable, both the present and non-present cases are tested, with an integer, array of integers and allocatable array of integers as the argument. libgomp/ *

[PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause

Reference types used by Fortran often need to be treated specially in the OACC lowering to deal with the referenced object as well as the reference itself. However, as optional arguments can be null, they are pointer types rather than reference types, so the code to detect these situations

[PATCH 1/5, OpenACC] Allow NULL as an argument to OpenACC 2.6 directives

Fortran pass-by-reference optional arguments behave much like normal Fortran arguments when lowered to GENERIC/GIMPLE, except they can be null (representing a non-present argument). Some parts of libgomp (those dealing with updating mappings) currently do not expect to take a null address and

[PATCH 3/5, OpenACC] Add support for allocatable arrays as optional arguments

This patch allows allocatable arrays passed as Fortran optional arguments to be used in OpenACC. The GIMPLE code generated by the current lowering unconditionally attempts to access fields within the structure representing the array, resulting in a null dereference if the array is non-present.

[PATCH 4/5, OpenACC] Allow optional arguments to be used in the use_device OpenACC clause

This patch fixes a similar situation that occurs with the use_device clause, where the lowering would result in a null dereference if applied to a non-present optional argument. This patch builds a conditional check that skips the dereference if the argument is non-present, and ensures that

[PATCH 0/5, OpenACC] Add support for Fortran optional arguments in OpenACC

This patchset allows the use of Fortran optional arguments in OpenACC programs in accordance with section 2.17 of the OpenACC 2.6 specification. These patches were originally posted at https://gcc.gnu.org/ml/gcc-patches/2019-01/msg01750.html for the OG8 branch. This version is targeted at

Re: [PATCH 4/5, OpenACC] Allow optional arguments to be used in the use_device OpenACC clause

On 12/07/2019 12:38 pm, Kwok Cheung Yeung wrote: This patch fixes a similar situation that occurs with the use_device clause, where the lowering would result in a null dereference if applied to a non-present optional argument. This patch builds a conditional check that skips the dereference

Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause

On 12/07/2019 12:41 pm, Jakub Jelinek wrote: +/* Return true if DECL is a Fortran optional argument. */ + +bool +omp_is_optional_argument (tree decl) +{ + /* A passed-by-reference Fortran optional argument is similar to + a normal argument, but since it can be null the type is a +

Re: [PATCH 04/10, OpenACC] Turn OpenACC kernels regions into a sequence of, parallel regions

On 18/07/2019 10:30 am, Jakub Jelinek wrote: On Wed, Jul 17, 2019 at 10:06:07PM +0100, Kwok Cheung Yeung wrote: --- a/gcc/omp-oacc-kernels.c +++ b/gcc/omp-oacc-kernels.c @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. If not see #include "backend.h" #include "targe

Re: [PATCH 06/10, OpenACC] Adjust parallelism of loops in gang-single parts of OpenACC kernels regions

The change to patch 04 (Turn OpenACC kernels regions into a sequence of parallel regions) necessitates an additional include of 'diagnostic-core.h' in omp-oacc-kernels.c, as it is no longer indirectly included by 'cp/cp-tree.h'. Kwok On 17/07/2019 10:12 pm, Kwok Cheung Yeung wrote: Loops

Re: [PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions

I have run the whole patch series through check_GNU_style.sh and fixed up the formatting where indicated. Do I need to post the reformatted patchset? Thanks Kwok On 18/07/2019 10:24 am, Jakub Jelinek wrote: On Wed, Jul 17, 2019 at 10:04:10PM +0100, Kwok Cheung Yeung wrote: @@ -2319,7

Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause

On 12/07/2019 12:41 pm, Jakub Jelinek wrote: This should be done through a langhook. Are really all PARM_DECLs wtih DECL_BY_REFERENCE and pointer type optional arguments? I mean, POINTER_TYPE is used for a lot of cases. Hmmm... I thought it was the case that if you pass an argument in by

[PATCH 00/10, OpenACC] Rework handling of OpenACC kernels regions

This series of patches reworks the way that OpenACC kernels regions are processed by GCC. Instead of relying on the parloops pass for auto-parallelisation of the kernel region, the contents of the region are transformed into a sequence of offloaded regions, which are then processed

[PATCH 01/10, OpenACC] Use "-fopenacc-kernels=parloops" to document "parloops" test cases

This patch introduces a new option "-fopenacc-kernels" to control how OpenACC kernels are processed. The current behaviour will be equivalent to '-fopenacc-kernels=parloops'. 2019-07-16 Thomas Schwinge gcc/ * flag-types.h (enum openacc_kernels): New type.

[PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions

This patch is in preparation for changes that will cut up OpenACC kernels regions into individual parts. For the new sub-regions that will be generated, this adds the following new kinds of OpenACC regions for internal use: - GF_OMP_TARGET_KIND_OACC_PARALLEL_KERNELS_PARALLELIZED for parts of

[PATCH 03/10, OpenACC] Separate OpenACC kernels regions in data and parallel parts

In the future, kernels regions will be transformed into data regions containing a sequence of serial and parallel offloaded regions. This first patch sets up a new pass that is responsible for this transformation, and in a first step constructs the new data region containing a parallel region

[PATCH 04/10, OpenACC] Turn OpenACC kernels regions into a sequence of, parallel regions

This patch decomposes each OpenACC kernels region into a sequence of parallel regions. Each OpenACC loop nest turns into its own region; any code between such loop nests is gathered up into a region as well. The loop regions can be distributed across gangs if the original kernels region had a

[PATCH 05/10, OpenACC] Handle conditional execution of loops in OpenACC, kernels regions

Any OpenACC loop controlled by an if statement or a non-OpenACC loop must be executed in a gang-single region. Detecting such loops is not trivial as OpenACC kernels expansion is done on GIMPLE but before computation of the control flow graph. This patch adds an auxiliary analysis for

[PATCH 06/10, OpenACC] Adjust parallelism of loops in gang-single parts of OpenACC kernels regions

Loops in gang-single parts of kernels regions cannot be executed in gang-redundant mode. If the user specified gang clauses on such loops, emit an error and remove these clauses. Adjust automatic partitioning to exclude gang partitioning in gang-single regions. 2019-07-16 Gergö Barany

[PATCH 07/10, OpenACC] Launch kernels asynchronously in OpenACC kernels regions

Kernels regions are decomposed into one or more smaller regions that are to be executed in sequence. With this patch, all of these regions are launched asynchronously, and a wait directive is added after them. This means that the host only waits once for the kernels to complete, not once per

[PATCH 08/10, OpenACC] New OpenACC kernels region decompose algorithm

Previously, OpenACC kernels region bodies were decomposed into a sequence of alternating gang-single and gang-parallel "parallel" regions. The new algorithm in this patch introduces a third possibility: Loops that look like they might benefit from the parloops pass are converted into old

[PATCH 09/10, OpenACC] Avoid introducing 'create' mapping clauses for loop index variables in kernels regions

This patch avoids adding CREATE mapping clauses for loop index variables. It also sets TREE_ADDRESSABLE on newly mapped declarations, which fixes an ICE that sometimes appears due to an assert firing in omp-low.c. 2019-07-16 Julian Brown gcc/ * omp-oacc-kernels.c

[PATCH 10/10, OpenACC] Make new OpenACC kernels conversion the default; adjust and add tests

This patch makes the new kernel conversion scheme the default, and adjusts the tests accordingly. 2019-07-16 Thomas Schwinge Kwok Cheung Yeung gcc/c-family/ * c.opt (fopenacc-kernels): Default to "split". gcc/fortran/ * lang.opt

Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause

On 18/07/2019 10:28 am, Tobias Burnus wrote: Hi all, I played around and came up with another second way one gets a single "*" without 'optional'. I haven't checked whether which of those match the proposed omp_is_optional_argument's +&& DECL_BY_REFERENCE (decl) +&& TREE_CODE

Re: [PATCH, og9] Port OpenACC profiling interface to OG9

On 24/07/2019 11:45 am, Thomas Schwinge wrote: +2017-02-28 Thomas Schwinge + + [...] + * oacc-parallel.c (GOACC_parallel_keyed_internal): Set device_api for + profiling. --- a/libgomp/oacc-parallel.c +++ b/libgomp/oacc-parallel.c @@ -275,6 +275,8 @@

[PATCH] Support multiple registers for the frame pointer

for this issue as it can affect pretty much everything not using -fomit-frame-pointer on AMD GCN. Okay for trunk? Kwok Yeung Add support for using multiple registers to hold the frame pointer 2019-11-02 Kwok Cheung Yeung gcc/ * ira.c (setup_alloc_regs): Setup

Re: [PATCH] Support multiple registers for the frame pointer

On 04/11/2019 08:02 pm, Dimitar Dimitrov wrote: On Sat, 2 Nov 2019, 19:28:38 EET Kwok Cheung Yeung wrote: diff --git a/gcc/ira.c b/gcc/ira.c index 9f8da67..25e9359 100644 --- a/gcc/ira.c +++ b/gcc/ira.c @@ -515,7 +515,13 @@ setup_alloc_regs (bool use_hard_frame_p) #endif

[PATCH] [LRA] Do not use eliminable registers for spilling

eliminable registers for spilling 2019-11-07 Kwok Cheung Yeung gcc/ * lra-spills.c (assign_spill_hard_regs): Do not spill into registers in eliminable_regset. diff --git a/gcc/lra-spills.c b/gcc/lra-spills.c index 0068e52..54f76cc 100644 --- a/gcc/lra-spills.c +++ b/gcc/lr

Re: [PATCH] Support multiple registers for the frame pointer

Hello On 04/11/2019 04:22 pm, Georg-Johann Lay wrote: > The avr port already uses 2 hard-reg frame pointer ever since... > > Does this patch has an impact on the avr port and its handling of > the frame pointer? I am not familiar with the AVR port, but looking at the source, it looks like it

[PATCH 0/5] [amdgcn] Reduce register usage on AMD GCN

Hello Although GCN has a large register file, these registers are distributed among the threads (wavefronts) running on the same compute unit, so (up to a point) the fewer registers used in a kernel, the more kernels can run concurrently. While this is of limited use in trunk at the moment

[PATCH 1/5] [amdgcn] Use first lane of v1 for zero constant

2019-11-14 Kwok Cheung Yeung gcc/ * config/gcn/gcn.c (gcn_expand_prologue): Remove initialization and prologue use of v0. (print_operand_address): Use v1 for zero vector offset. --- gcc/config/gcn/gcn.c | 17 +++-- 1 file changed, 3 insertions(+), 14

[PATCH 4/5] [amdgcn] Update lower limits requested by non-leaf kernels

? Kwok 2019-11-14 Kwok Cheung Yeung gcc/ * config/gcn/gcn.c (MAX_NORMAL_SGPR_COUNT, MAX_NORMAL_VGPR_COUNT): New. (gcn_conditional_register_usage): Use constants in place of hard-coded values. (gcn_hsa_declare_function_name): Set lower bound for number of SGPRs/VGPRs

[PATCH 5/5] [amdgcn] Unfix frame pointer

2019-11-14 Kwok Cheung Yeung gcc/ * config/gcn/gcn.h (FIXED_REGISTERS): Unfix frame pointer. (CALL_USED_REGISTERS): Make frame pointer callee-saved. --- gcc/config/gcn/gcn.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/gcn/gcn.h b/gcc

[PATCH 2/5] [amdgcn] Reinitialize registers for every function

implementation is actually dead code!). I have added a call to reinit_regs in gcn_init_cumulative_args to setup the available registers for each function. Okay for trunk? Kwok 2019-11-14 Kwok Cheung Yeung gcc/ * config/gcn/gcn.c (gcn_init_cumulative_args): Call reinit_regs

[PATCH 3/5] [amdgcn] Restrict register usage in non-kernel functions

to the newlib patch 'Stash reent marker in upper bits of s1 on AMD GCN' and the first patch in this series). Okay to commit? Kwok 2019-11-14 Kwok Cheung Yeung gcc/ * config/gcn/gcn.c (default_requested_args): New. (gcn_parse_amdgpu_hsa_kernel_attribute): Initialize

Re: [PATCH 4/5] [amdgcn] Update lower limits requested by non-leaf kernels

On 15/11/2019 11:32 am, Andrew Stubbs wrote: On 14/11/2019 15:33, Kwok Cheung Yeung wrote: The kernel attributes are changed to request at least 64 SGPRs and 24 VGPRs (i.e. the non-kernel maximum, otherwise the callees may not have enough registers to run in) for non-leaf kernels to take

[og9] Backport AMD GCN backend improvements from mainline

for mode I will commit this later. Thanks, Kwok 2019-11-07 Kwok Cheung Yeung gcc/ * ira.c (setup_alloc_regs): Setup no_unit_alloc_regs for frame pointer in multiple registers. (ira_setup_eliminable_regset): Setup eliminable_regset, ira_no_alloc_regs

[PATCH] [og9] Fix libgomp.oacc-fortran/lib-16.f90 test

s supposed to be identical to lib-16.f90 except for using 'include "openacc_lib.h"' instead of 'use openacc', any changes to lib-16-2.f90 should also apply to lib-16.f90. When the changes are applied to lib-16.f90, the test passes. Okay to commit to OG9? Thanks Kwok 2019-11-2

[PATCH] [libgomp, amdgcn] Fix Fortran linker errors on AMD GCN

with the alternative definitions in the mingw32, bsd, linux, posix and rtems subdirectories of libgomp/config/. Tested on an x86_64 host with both NVPTX and GCN offloading. Okay to commit to trunk? Kwok 2019-12-06 Kwok Cheung Yeung libgomp/ * config/accel/proc.c (omp_get_num_procs

[PATCH] Allow entry point markers without debug support in accelerator compiler

processed by the accelerator compiler. This is fixed by allowing the markers to be ignored in LTO mode only. 2019-12-06 Kwok Cheung Yeung gcc/ * dwarf2out.c (dwarf2out_inline_entry): Return early if in LTO and debug_inline_points not set. --- gcc/dwarf2out.c | 7

[PATCH] Check suitability of spill register for mode

on x86_64, though it currently does not use spill registers. Okay for trunk? Kwok 2019-11-14 Kwok Cheung Yeung gcc/ * lra-spills.c (assign_spill_hard_regs): Check that the spill register is suitable for the mode. --- gcc/lra-spills.c | 3 ++- 1 file changed, 2 insertions

[PATCH] [GCN] Fix handling of VCC_CONDITIONAL_REG

(into SGPR_REGS) to avoid expensive spills into memory. Built for and tested on the AMD GCN target with no regressions. Okay for trunk? Kwok 2019-11-14 Kwok Cheung Yeung gcc/ * config/gcn/gcn.c (gcn_regno_reg_class): Return VCC_CONDITIONAL_REG register class for VCC_LO

Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause

On 07/10/2019 10:25 am, Thomas Schwinge wrote: Hi Kwok, Tobias! On 2019-07-29T21:55:52+0100, Kwok Cheung Yeung wrote: > if (omp_is_reference (new_var) > && TREE_CODE (TREE_TYPE (new_var)) != POINTER_TYPE) As is, this code in lower_omp_targ

[PATCH] [amdgcn] Scale number of threads/workers with VGPR usage

The GCN architecture has 4 SIMD units per compute unit, with 256 VGPRs per SIMD unit. OpenMP threads or OpenACC workers must be distributed across the SIMD units, with each thread/worker fitting entirely within a single SIMD unit. VGPRs are shared by the kernels running in a SIMD unit, so we

Re: [PATCH] Allow entry point markers without debug support in accelerator compiler

assert. I have rerun the libgomp tests on AMD GCN with no regressions. Okay for trunk? Thanks Kwok 2020-01-09 Kwok Cheung Yeung gcc/ * lto-streamer-in.c (input_function): Remove streamed-in inline debug markers if debug_inline_points is false. --- gcc/lto-streame

Re: [PATCH] [amdgcn] Add support for sub-word sync_compare_and_swap operations

On 08/01/2020 11:42 am, Andrew Stubbs wrote: On 08/01/2020 11:07, Kwok Cheung Yeung wrote: +#define __sync_subword_compare_and_swap(type, size)    \ Macro parameters are conventionally upper case. Fixed. I upper-cased the macro name as well

[PATCH] [amdgcn] Remove dependency on stdint.h in libgcc

and replacing uintptr_t with __UINTPTR_TYPE__, which is a predefined macro in the C preprocessor. Okay for trunk? Kwok 2020-01-10 Kwok Cheung Yeung libgcc/ * config/gcn/atomic.c: Remove include of stdint.h. (__sync_val_compare_and_swap_##SIZE): Replace uintptr_t

[PATCH] [amdgcn] Add support for sub-word sync_compare_and_swap operations

. If the operation is unsuccessful due to a part of the word that is not the target subword changing values since the last read, then it must try again using the updated word. Okay for trunk? Kwok 2020-01-08 Kwok Cheung Yeung libgcc/ * config/gcn/atomic.c: New. * config

[PATCH] [amdgcn] Add support for unordered floating-point comparisons

with no regressions noted. Okay for trunk? Kwok commit ea811ce38ae2127554f0aca9cd34aca6e42f814d Author: Kwok Cheung Yeung Date: Thu Apr 2 07:47:28 2020 -0700 amdgcn: Support unordered floating-point comparison operators 2020-04-02 Kwok Cheung Yeung gcc/ * config/gcn/gcn.c

Re: [PATCH] amdgcn: Add stub personality function

On 23/04/2020 12:05 pm, Thomas Schwinge wrote: So we should simply disable it properly (see below)... ... instead of adding such stub functions. I suggest we instead apply what I'd proposed a month ago in "[amdgcn] ld: error: undefined symbol:

[PATCH] amdgcn: Add stub personality function

and standalone builds of GCC for AMD GCN. Okay for trunk? Kwok 2020-04-22 Kwok Cheung Yeung libgcc/ * config/gcn/unwind-gcn.c (__gxx_personality_v0): New. diff --git a/libgcc/config/gcn/unwind-gcn.c b/libgcc/config/gcn/unwind-gcn.c index 813f03f..6508b45 100644 --- a/libgcc/config/gcn

[PATCH] fortran, openmp: PR fortran/93660 Fix ICE when coarrays used with 'omp declare simd'

mp with Nvidia offloading. Okay for trunk? Thanks Kwok commit e842728189edc14c3f8b7c0a93cb51b007f20220 Author: Kwok Cheung Yeung Date: Thu Sep 10 13:59:51 2020 -0700 Fix ICE when coarrays used with the OpenMP 'declare simd' directive The ICE occurs when Fortran coarrays are used

[PATCH] [OG10] Fix warning messages in privatized-ref-[23].C testcases

: Kwok Cheung Yeung Date: Wed Sep 16 03:18:54 2020 -0700 Fix warning messages in libgomp.oacc-c++/privatized-ref-[23].C testcases More workers are requested than are supported, resulting in warning messages as the number of workers is overridden. 2020-09-16 Kwok Cheung

[PATCH] openmp: Implement support for OMP_TARGET_OFFLOAD

a22f434d5ec9e62c158912b693275ce89a2cbab0 Author: Kwok Cheung Yeung Date: Thu Oct 8 10:08:27 2020 -0700 openmp: Implement support for OMP_TARGET_OFFLOAD environment variable This implements support for the OMP_TARGET_OFFLOAD environment variable introduced in the OpenMP 5.0 standard, which

[PATCH] openmp: Add support for omp_get_supported_active_levels

aa519103d7eeaeed825fd358e9532bf51f4be0a9 Author: Kwok Cheung Yeung Date: Wed Oct 7 09:34:32 2020 -0700 openmp: Add support for the omp_get_supported_active_levels runtime library routine This patch implements the omp_get_supported_active_levels runtime routine from the OpenMP 5.0 specification, which returns

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

On 14/10/2020 9:20 am, Jakub Jelinek wrote: On Tue, Oct 13, 2020 at 07:05:10PM +0100, Kwok Cheung Yeung wrote: +* omp_get_supported_active_levels:: Maxiumum number of active levels supported Sorry for not catching it during review, but there is a typo above. Fixed with patch below, committed

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

Now committed to trunk with the suggested fixes. Thanks for the quick review. Kwok On 13/10/2020 7:36 pm, Jakub Jelinek wrote: I'd suggest to #define gomp_supported_active_levels INT_MAX in libgomp.h and leave out the const variable. Another possibility is an enumerator, but we don't include

Re: [PATCH] openmp: Implement support for OMP_TARGET_OFFLOAD

Thanks Kwok commit 82555f50d2930f973ab20782ebcb836b719bce96 Author: Kwok Cheung Yeung Date: Mon Oct 19 10:47:42 2020 -0700 openmp: Implement support for OMP_TARGET_OFFLOAD environment variable This implements support for the OMP_TARGET_OFFLOAD environment variable introduc

[committed] [OG10] Backport OpenMP-related patches

Kwok Cheung Yeung + + Backport from mainline + 2020-06-25 Tobias Burnus + + PR fortran/95837 + * resolve.c (gfc_resolve_substring_charlen): Remove + bogus ts.kind setting for the expression. + 2020-08-14 Kwok Cheung Yeung Backport from mainline diff

[committed] [OG10] Re: Re: [Patch] [OpenMP, Fortran] Add structure/derived-type element mapping

754e9208e85fb Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Wed, 19 Aug 2020 12:50:42 -0700 Subject: [PATCH] Fix gfortran.dg/goacc/pr70828.f90 testcase Array mapping was changed by the patch '[OpenMP, Fortran] Add structure/derived-type element mapping'. 2020-08-19 Kwok Cheung

[PATCH] [OG10] Fix warning messages in privatized-ref-1.f95 testcase

The libgomp.oacc-fortran/privatized-ref-1.f95 also has the same issue, and has been fixed in the same way. Kwok On 16/09/2020 11:33 am, Kwok Cheung Yeung wrote: Hello The libgomp.oacc-c++/privatized-ref-[23].C testcases request 64 workers in a parallel section, but Nvidia only supports

[PATCH] [OG10] Xfail libgomp.oacc-fortran/privatized-ref-2.f90 when offloading to nvptx

Yeung Date: Wed Sep 16 10:19:35 2020 -0700 XFAIL libgomp.oacc-fortran/privatized-ref-2.f90 on nvptx The testcase uses alloca, which is not currently supported on nvptx (see PR65181). 2020-09-16 Kwok Cheung Yeung libgomp/ * testsuite/libgomp.oacc

[PATCH] openmp: Implicit 'declare target' for C++ static initializers

with no offloading on x86-64. Okay for trunk? Thanks Kwok commit d2c8c5bd2826851b727e93a8ea2141596e50a621 Author: Kwok Cheung Yeung Date: Wed Oct 28 07:13:14 2020 -0700 openmp: Implicitly add 'declare target' directives for dynamic static initializers in C++ 2020-10-28 Kwok Cheung

Re: deprecations in OpenMP 5.0

Hello I found this almost two-year old thread while looking for how the OpenMP 5.0 deprecations were to be handled. E.g. if somebody tries hard to write portable OpenMP code and has: omp_lock_t lock; #if __OPENMP__ >= 201811L omp_init_lock_with_hint (, omp_sync_hint_contended); #elif

Re: [PATCH] nvptx: Add support for subword compare-and-swap

On 01/07/2020 3:28 pm, Tom de Vries wrote: I looked at the implementation, and it looks ok to me, though I think we need to make explicit in a comment what the assumptions are: - that we have read and write access to the entire word, and Is there a situation where an 8/16-bit portion of memory

[PATCH] [og10] Fix goacc/note-parallelism-combined-kernels-loop-auto.c test

y accident? This patch removes the dg-messages for the no-longer occurring messages. Okay for OG10? Kwok From 59c6bc996000fb69ee8cf2cee3ec2e279524e66f Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Thu, 18 Jun 2020 13:32:40 -0700 Subject: [PATCH 1/6] Fix failures in c-c++-common/goacc/note-p

[PATCH] [og10] Fix goacc/routine-4-extern.c test

6a0b5806b24bfdefe0b0f3ccbcc51299e5195dca) did not include a fix for routine-4-extern.c. This patch removes the now outdated dg-error and dg-warnings from the test. Okay for OG10? Kwok From 5774f048563df311f2a35a654b8c2d7b1af9f2da Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Thu, 18 Jun 2020 14:31

[PATCH] [og10] Fix goacc/loop-processing-1.c testcase

22e91315f3ce7c486017c6b9245dc1ea2d6bdede Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Fri, 19 Jun 2020 06:58:40 -0700 Subject: [PATCH 3/6] Fix broken testcase gcc.dg/goacc/loop-processing-1.c 2020-07-21 Kwok Cheung Yeung gcc/testsuite/ * gcc.dg/goacc/loop-processing-1.c: Remove erroneous

[PATCH] [og10] Fix routine-nohost-1.c testcase

'. Kwok From f921b0988c41ba086e968faf08e93f7a230e55a1 Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Fri, 19 Jun 2020 09:34:27 -0700 Subject: [PATCH 4/6] Fix failure in testcase c-c++-common/goacc/routine-nohost-1.c 2020-07-21 Kwok Cheung Yeung gcc/testsuite/ * c-c

[PR96519] Re: [PATCH][testsuite] Add gcc.dg/ia64-sync-5.c

ing the array element types explicitly signed. This issue is tracked as issue 96519 on the tracker. I have checked that the test now passes on PowerPC and Aarch64. Is the fix okay for trunk? Thanks Kwok commit fc6ac3af45a238da0bd65e020ae6f0f165b57b87 Author: Kwok Cheung Yeung Date: Tue Aug 11 0

[committed] [OG10] Add nvptx support for subword compare-and-swap

Author: Kwok Cheung Yeung Date: Wed Aug 12 12:37:20 2020 -0700 nvptx: Add support for subword compare-and-swap This adds support for __sync_val_compare_and_swap and __sync_bool_compare_and_swap for 1-byte and 2-byte long values, which are not natively supported on nvptx

[PING] Re: [PATCH] nvptx: Add support for subword compare-and-swap

Hello I posted a revised patchset about two weeks ago at: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/550291.html Are you able to take a look at it? Thanks Kwok

Re: [PATCH] nvptx: Add support for subword compare-and-swap

On 23/06/2020 5:51 pm, Jakub Jelinek wrote: On Tue, Jun 23, 2020 at 06:44:26PM +0200, Thomas Schwinge wrote: On 2020-06-15T21:28:12+0100, Kwok Cheung Yeung wrote: This patch adds support on nvptx for __sync_val_compare_and_swap operations on 1- and 2-byte values. Is this a thorough review

Re: [Patch][gcn, nvptx, offloading] mkoffload – handle -fpic/-fPIC

n a x64 host with offloading to nvptx and gcn. On AMD GCN, it also produces a couple of extra linker warnings that I have added dg-warning entries for. Okay for trunk/OG10 together with the previous mkoffload patch? Thanks Kwok commit 43238117c261285a6b95d881bcc2f9efd9f752ad Author: Kwok Cheung

[PATCH] libgomp: Fix hang when profiling OpenACC programs with CUDA 9.0 nvprof

d20f269e8571a76d682a500e78654ddd260ffaf1 Author: Kwok Cheung Yeung Date: Fri Jul 10 14:06:26 2020 -0700 libgomp: Fix hang when profiling OpenACC programs with CUDA 9.0 nvprof The version of nvprof in CUDA 9.0 causes a hang when used to profile an OpenACC program. This is because it calls

Re: [PATCH] wwwdocs: Document devel/omp/gcc-10 branch

. This is a history chapter, after all. commit b719899acf24974fd4c51f14538b426f99259384 Author: Kwok Cheung Yeung Date: Wed Jun 10 06:08:06 2020 -0700 Document devel/omp/gcc-10 branch This also moves the old devel/omp/gcc-9 branch to the inactive branches section. diff --git a/htdocs

[PATCH] nvptx: Add support for subword compare-and-swap

not cause any regressions on the nvptx offloading tests, and that the new test passes with both nvptx and amdgcn as offload targets. Okay for master and OG10? Kwok commit 7c3a9c23ba9f5b8fe953aa5492ae75617f2444a3 Author: Kwok Cheung Yeung Date: Mon Jun 15 12:34:55 2020 -0700 nvptx: Add support

Re: [PATCH] nvptx: Add support for subword compare-and-swap

On 23/06/2020 5:44 pm, Thomas Schwinge wrote: Hi! On 2020-06-15T21:28:12+0100, Kwok Cheung Yeung wrote: This patch adds support on nvptx for __sync_val_compare_and_swap operations on 1- and 2-byte values. Is this a thorough review that these are the only functions missing, or did you just

[PATCH] libgomp, fortran: Apply if clause to all sub-constructs in combined OpenMP constructs

9ffcc65e341e5 Author: Kwok Cheung Yeung Date: Thu Jun 18 12:40:16 2020 -0700 libgomp, fortran: Apply if clause to all sub-constructs in combined OpenMP constructs The unmodified 'if' clause should be applied to all the sub-constructs that accept an 'if' clause in a combined Ope

Re: [PATCH] libgomp, fortran: Apply if clause to all sub-constructs in combined OpenMP constructs

non-zero for nvptx. I think the easiest fix would be to expect different numbers of matches depending on whether nvptx offloading is enabled. This requires an extra function in gcc/testsuite/lib/target-supports.exp. Okay for master/OG10? Thanks Kwok commit 04bdcaa20827d814c323847630c59ee843c51408 A

Re: [PATCH] libgomp, fortran: Apply if clause to all sub-constructs in combined OpenMP constructs

it as obvious.) Hello I have committed your patch along with the testcase as 'obvious'. I have confirmed that it does not regress the gfortran and libgomp testsuites. Kwok commit f530bac8a11da9c85bdd8e58d589747f9825e38d Author: Kwok Cheung Yeung Date: Thu Jun 25 04:40:53 2020 -0700

[PATCH] wwwdocs: Document devel/omp/gcc-10 branch

to the old branch, as new development should occur on the newer branch. OK to push? Thanks, Kwok commit ef2aef1c8649a9620f0975a3fe5d4cadaa0b9d1e Author: Kwok Cheung Yeung Date: Wed Jun 10 06:08:06 2020 -0700 Document devel/omp/gcc-10 branch This also removes references

Re: [PATCH] wwwdocs: Document devel/omp/gcc-10 branch

case it should probably go after openacc-gcc-9-branch)? Kwok On 10/06/2020 4:15 pm, Tobias Burnus wrote: On 6/10/20 3:34 PM, Kwok Cheung Yeung wrote: This patch updates the previous entry on the website for devel/omp/gcc-9 to refer to the new branch instead. This removes references to the old

Re: [PATCH] [og10] Fix goacc/routine-4-extern.c test

previous changes and replaced the orphan loop gang reductions with empty loops as suggested, and checked that the tests now pass. Is this version okay for OG10? Thanks Kwok From 280957dc80090bd0b92ad7a73f528851aad94051 Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Sun, 26 Jul 2020 05:1

  1   2   3   >