at http://codereview.appspot.com/4800046
LGTM
--
Lawrence Crowl
);
lto_input/ouput will again no longer need to be extern when I make
my patch for pph to handle those differently, I will make sure
(remind me if I don't) to remove this change.
Okay.
--
Lawrence Crowl
Place the tinst_level list in forward order.
Tested on x64.
Index: gcc/cp/ChangeLog.pph
2011-07-28 Lawrence Crowl cr...@google.com
* pt.c (pph_in_tinst_level): Put tinst_level list in forward order.
Index: gcc/cp/pt.c
bitpack_d
pph_in_bitpack (pph_stream *stream)
{
- struct bitpack_d bp = lto_input_bitpack (stream-ib);
+ struct bitpack_d bp = lto_input_bitpack (stream-encoder.r.ib);
if (flag_pph_tracer = 4)
pph_trace_bitpack (stream, bp);
return bp;
--
Lawrence Crowl
On 5/28/12, Jakub Jelinek ja...@redhat.com wrote:
On Fri, May 25, 2012 at 02:42:39PM -0700, Lawrence Crowl wrote:
On 5/24/12, Jakub Jelinek ja...@redhat.com wrote:
On Thu, May 24, 2012 at 09:43:42AM -0700, Lawrence Crowl wrote:
Add a type-safe hash table, typed_htab. Uses of this table
On 5/24/12, Gabriel Dos Reis g...@integrable-solutions.net wrote:
On May 24, 2012 Lawrence Crowl cr...@google.com wrote:
Add a type-safe hash table, typed_htab. Uses of this table
replace uses of libiberty's htab_t. The benefits include less
boiler-plate code, full type safety
about garbage collection in gcc other than upgrade
it as we need. (See Diego's vec patch.) We are just having a
friendly philosophical discussion. :-)
--
Lawrence Crowl
On 5/29/12, Richard Guenther richard.guent...@gmail.com wrote:
On May 25, 2012 Mike Stump mikest...@comcast.net wrote:
On May 25, 2012, at 10:50 AM, Lawrence Crowl wrote:
Diego and I looked long and hard at this issue. It all came
down to a sequence of problems. First, libstdc++ isn't
progress, please let us know.
--
Lawrence Crowl
Change the check functions from templates to overloads.
Add set unwindonsignal on to gdbinit.in to gracefully handle aborts
in functions used from gdb.
Tested on x86-64.
Index: gcc/ChangeLog.cxx-conversion
2012-05-30 Lawrence Crowl cr...@google.com
* tree.h (tree_check): Change
On 6/5/12, Gerald Pfeifer ger...@pfeifer.com wrote:
On Mon, 4 Jun 2012, Lawrence Crowl wrote:
The following source change enables coddingconventions.html to
pass the HTML validator at validator.w3.org.
the web pages will be preprocessed before the are put on the server
(this transparently
. Reading files now uses TV_PHASE_STREAM_IN. Writing files
now uses TV_PHASE_STREAM_OUT. The remaining phase is TV_PHASE_OPT_GEN
(formerly TV_PHASE_CGRAPH).
Tested on x86_64.
Okay for trunk?
Index: gcc/ChangeLog
2012-06-11 Lawrence Crowl cr...@google.com
* timevar.def
,
+the constructor parameter names
+and getter member function names
+can use the more concise non-underscore form.
+/p
+
+/body
+/html
--
Lawrence Crowl
here. LTO runs as a front-end,
and the parse timers are automatically started for the front ends.
But LTO is not parsing. Rather than change every front end to
handle those timers, I turned the timers off and then back on again
within LTO.
Committed.
--
Lawrence Crowl
from the wiki. The one-space rule for protection labels is
common practice. If folks want something else, changes are fine
with me.
I have also made a few other edits requested offline by Benjamin
Kosnik.
--
Lawrence Crowl
On 6/25/12, Lawrence Crowl cr...@google.com wrote:
On 6/25/12, Joseph S. Myers jos...@codesourcery.com wrote:
On Mon, 25 Jun 2012, Diego Novillo wrote:
[ Added doc maintainers in CC ]
While I'm not particularly interested in the details of the
coding conventions, I am interested
arises.
Of course, I have no objection to an occasional inline cleanup.
That is, build with -Werror and adjusting inlines that have,
through the course of time, become larger than is useful.
--
Lawrence Crowl
On 6/25/12, Alexandre Oliva aol...@redhat.com wrote:
On Jun 25, 2012, Lawrence Crowl cr...@google.com wrote:
+These conventions will change over time,
+but changing them requires that a convincing rationale.
s/that//
+Complex heirarchies are to be avoided.
s/heir/hier/
Both fixed
On 6/26/12, Martin Jambor mjam...@suse.cz wrote:
On Mon, Jun 25, 2012 at 03:26:01PM -0700, Lawrence Crowl wrote:
I have no idea. I don't use emacs. The two-space rule for
members comes from the wiki. The one-space rule for protection
labels is common practice. If folks want something
On 6/26/12, Jason Merrill ja...@redhat.com wrote:
On 06/25/2012 06:26 PM, Lawrence Crowl wrote:
+orcodegcc_unreachable/code. If the checks are expensive or the
+compiler can reasonably carry on after the error, they may be
+conditioned oncode--enable-checking/code./p
by using
On 6/27/12, Martin Jambor mjam...@suse.cz wrote:
On Tue, Jun 26, 2012 at 11:06:15AM -0700, Lawrence Crowl wrote:
On 6/26/12, Martin Jambor mjam...@suse.cz wrote:
On Mon, Jun 25, 2012 at 03:26:01PM -0700, Lawrence Crowl wrote:
+but think twice before using it in code
+intended to last
On 6/27/12, Lawrence Crowl cr...@google.com wrote:
..., does anyone object to removing the permission to use C++
streams?
Having heard no objection, I removed the permission.
The following patch is the current state of the changes. Since the
discussion appears to have died down, can I commit
Resend, as I replied to a message that didn't have the usual suspects
on the cc line.
On 6/27/12, Lawrence Crowl cr...@google.com wrote:
..., does anyone object to removing the permission to use C++
streams?
Having heard no objection, I removed the permission.
The following patch
On 7/1/12, Gabriel Dos Reis g...@integrable-solutions.net wrote:
On Fri, Jun 29, 2012 at 1:17 PM, Lawrence Crowl cr...@google.com wrote:
Resend, as I replied to a message that didn't have the usual suspects
on the cc line.
On 6/27/12, Lawrence Crowl cr...@google.com wrote:
..., does anyone
On 7/1/12, Jason Merrill ja...@redhat.com wrote:
On 06/29/2012 02:17 PM, Lawrence Crowl wrote:
+h4a name=RTTIRTTI andcodedynamic_cast/code/a/h4
+
+p
+Run-time type information (RTTI) is permitted
+when certain non-defaultcode--enable-checking/code options are
enabled,
+so
On 7/4/12, Jason Merrill ja...@redhat.com wrote:
On 07/03/2012 04:37 PM, Lawrence Crowl wrote:
On 7/1/12, Jason Merrillja...@redhat.com wrote:
As discussed, I would say that RTTI is currently not permitted
but could be added later.
But isn't could be added later always true? Other folks
On 7/10/12, Gabriel Dos Reis g...@cs.tamu.edu wrote:
Jason Merrill ja...@redhat.com writes:
| On 07/09/2012 06:00 PM, Lawrence Crowl wrote:
| Done. New patch attached, but note that the html tags have been
| stripped from the patch to avoid mailer problems.
|
| Thanks. If nobody else
their contents are streamed in. Change
the call sites to uniformly use a postorder traversal for tracing.
This makes in and out traces directly comparable.
Bootstrapped on x64.
Index: gcc/cp/ChangeLog.pph
2011-10-28 Lawrence Crowl cr...@google.com
* pph.c (pph_dump_tree_name): Remove dead code
Add merging of static_decls in bindings. Due to the current
structure, this change is currently only effective at namespace scope.
Consequently, there are no changes to test status. We may need to
make all bindings merged by default.
Index: gcc/cp/ChangeLog.pph
2011-11-01 Lawrence Crowl cr
.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2011-11-07 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp (dg-pph-pos): Recognize bogus errors.
* g++.dg/pph/x0namespace2.h: New.
* g++.dg/pph/x4namespace.cc: New.
Index: gcc/cp/ChangeLog.pph
2011-11-07 Lawrence
Lawrence Crowl cr...@google.com
* g++.dg/pph/c0anticipated.h: New.
* g++.dg/pph/c1anticipated.cc: New.
* g++.dg/pph/x0samename1.h: New.
* g++.dg/pph/x0samename2.h: New.
* g++.dg/pph/x4samename.cc: New.
Index: gcc/cp/ChangeLog.pph
2011-11-30 Lawrence
because
these bits go into an alignment gap.
Index: libcpp/ChangeLog.pph
2011-04-14 Lawrence Crowl cr...@google.com
* include/cpplib.h (cpp_hashnode): Use a macro for the number of bits
in the directive_index bitfield. Change the number of bits back to 7.
* directives.c
This patch cleans up positive tests. First, stop on first failure so
as to avoid littering the logfile. Second, change the extensions of
the generated assembly files to .s-pph and .s+pph to be clear on the
provenence of each file.
Index: gcc/testsuite/ChangeLog.pph
2011-04-15 Lawrence Crowl
On 4/16/11, Diego Novillo dnovi...@google.com wrote:
On Apr 14, 2011 Lawrence Crowl cr...@google.com wrote:
Unfortunately, five bits are not sufficient for the alternate
use of cpp_hashnode.directive_index as a named operator index.
So, I have reverted the number of bits from five back
First stab at getting namespaces working with PPH. This change will
put top-level namespaces into the global namespace. It does not,
however, appear to their members in any place useful.
Some tuning of tracing output.
Index: gcc/cp/ChangeLog.pph
2011-04-18 Lawrence Crowl cr...@google.com
, but not at this level. That's inside the actual LTO streaming
code.
It would be nice to have an indication, but it is not something I want
to do now.
http://codereview.appspot.com/4433054/
--
Lawrence Crowl
On 4/21/11, Jason Merrill ja...@redhat.com wrote:
On 04/21/2011 07:17 PM, Lawrence Crowl wrote:
@@ -1911,7 +1911,7 @@ ggc_collect (void)
- timevar_push (TV_GC);
+ timevar_start (TV_GC);
Why this change? GC time shouldn't be counted against whatever we
happen to be parsing when it happens
On 4/22/11, Hans-Peter Nilsson h...@bitrange.com wrote:
On Sat, 16 Apr 2011, Diego Novillo wrote:
On Thu, Apr 14, 2011 at 22:01, Lawrence Crowl cr...@google.com wrote:
+unsigned char too_many_directives_for_bitfield[
+N_DIRECTIVES = (1 CPP_HASHNODE_INDEX_BITS)
+? 1 : -1
at the time of cleanup. There are subsequent segfaults still.
Fix formatting of a conditional in pph-streamer.c.
In libcpp/directives.c, make the too_many_directives_for_bitfield
static assert into an extern to avoid allocating storage.
Index: gcc/c-family/ChangeLog.pph
2011-04-20 Lawrence Crowl
This discussion continues in the thread
[patch] Split Parse Timevar (rev 2) (issue4433076)
which has a new uploaded patch.
On 4/23/11, Jason Merrill ja...@redhat.com wrote:
On 04/22/2011 06:41 PM, Lawrence Crowl wrote:
On 4/21/11, Jason Merrillja...@redhat.com wrote:
On 04/21/2011 07:17 PM
be if it were an aggregate.
This looks right to me. It's more in line with C99.
--
Lawrence Crowl
This patch saves and restores the PARM_DECL DECL_ARG_TYPE in the PPH file.
Index: gcc/cp/ChangeLog.pph
2011-04-28 Lawrence Crowl cr...@google.com
* pph-streamer-out.c (pph_stream_write_tree): Write PARM_DECL
DECL_ARG_TYPE.
* pph-streamer-in.c (pph_stream_read_tree
In the pph file, save and restore DECL_INITIAL instead of just
PARM_DECL DECL_ARG_TYPE.
Index: gcc/cp/ChangeLog.pph
2011-04-29 Lawrence Crowl cr...@google.com
* pph-streamer-out.c (pph_stream_write_tree): Write DECL_INITIAL
instead of PARM_DECL DECL_ARG_TYPE.
* pph
On 4/29/11, Diego Novillo dnovi...@google.com wrote:
On Apr 29, 2011 Richard Guenther richard.guent...@gmail.com wrote:
On Apr 29, 2011 Lawrence Crowl cr...@google.com wrote:
This patch saves and restores the PARM_DECL DECL_ARG_TYPE in the
PPH file.
Should be already streamed via
to me.
--
Lawrence Crowl
Split C++ test x1funcstatic.cc into a C test and a C++ test.
Stream out and in various C++ tree members.
Index: gcc/testsuite/ChangeLog.pph
2011-05-20 Lawrence Crowl cr...@google.com
* x1funcstatic.h: Rename to c1funcstatic.h, as contents are C only.
* x1funcstatic.c: Use
)
{
TI_TYPEDEFS_NEEDING_ACCESS_CHECKING (expr)
- = pph_stream_read_tree_vec (stream);
+ = pph_stream_read_qual_use_vec (stream);
}
else if (TREE_CODE (expr) == TREE_LIST)
; /* FIXME pph: already handled? */
http://codereview.appspot.com/4550064/
LGTM
--
Lawrence Crowl
the style.
Index: gcc/c-family/ChangeLog.pph
2011-05-24 Lawrence Crowl cr...@google.com
* c.opt (fpph-untree): Add.
Index: gcc/cp/ChangeLog.pph
2011-05-24 Lawrence Crowl cr...@google.com
* pph-streamer-in.c (pph_stream_read_tree): Refactor
from nested if statements
In pph_stream_read_tree and pph_stream_write_tree, reformat for style.
This step was skipped in the last patch to make diffs more sensible.
Index: gcc/cp/ChangeLog.pph
2011-05-25 Lawrence Crowl cr...@google.com
* pph-streamer-in.c (pph_stream_read_tree): Reformat for style
This patch updates tests to clear conflicting commits.
The change needed for x6rtti.cc does not make sense to me.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2011-08-08 Lawrence Crowl cr...@google.com
* (g++.dg/pph/x6dynarray4.cc): Remove dg-prune-output.
* (g++.dg
42
Gab
On Fri, Aug 5, 2011 at 11:15 AM, Lawrence Crowl cr...@google.com wrote:
This patch ads a bunch of small tests for multi-pph includes.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2011-08-04 Lawrence Crowl cr...@google.com
* g++.dg/pph/README: Add new
on x64.
Index: gcc/testsuite/ChangeLog.pph
2011-08-10 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp: Compile with -fno-dwarf2-cfi-asm to reduce
environmental differences.
* g++.dg/pph/z0expinstnin1.h: Remove in favor of new tests.
* g++.dg/pph/x0tmplfuncninl3
tests files sync-mem-op-[1-5].c to test all these
routines for (1)char, (2)short, (3)int, (4)long long, and (5)__int128_t.
Bootstrapped and no new regressions on x86-64. (I am re-verifying
overnight however). OK for the branch?
Andrew
--
Lawrence Crowl
.
Test x7rtti.cc was unresolved because the run test was failing to
compile. Updated test x7rtti.cc to supress the dg-run, until the
compile problems are fixed.
Tests run on x64.
Index: gcc/testsuite/ChangeLog.pph
2011-08-29 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp: Move -fno
.
Test x7rtti.cc was unresolved because the run test was failing to
compile. Updated test x7rtti.cc to supress the dg-run, until the
compile problems are fixed.
Tests run on x64.
Index: gcc/testsuite/ChangeLog.pph
2011-09-07 Lawrence Crowl cr...@google.com
* a0vardef.h: New
.
Cheers,
Gab
--
Lawrence Crowl
Restore compiling the tests with -fno-dwarf2-cfi-asm. Failure to do
so results in different assembly output on different platforms due to
different assembler support for exceptions.
Index: gcc/testsuite/ChangeLog.pph
2011-09-12 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp
/ChangeLog.pph
2011-09-17 Lawrence Crowl cr...@google.com
* pph.h (pph_tree_code_text): New.
(pph_dump_min_decl): New.
* pph.c (pph_tree_code_text): New. Update users of tree_code_name
to call this function instead, here and in other files.
(pph_dump_min_decl): New
additional information needed for decl merging. Reads take
the corresponding actions. We do not yet to symbol lookup or merging.
Tested on x64.
Index: gcc/cp/ChangeLog.pph
2011-09-19 Lawrence Crowl cr...@google.com
* pph-streamer-out.c (pph_out_binding_level_1): Read this_entity first
/ChangeLog.pph
2012-02-15 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp: Clarify kind of test in log file.
* g++.dg/pph/x0funcinl1.h: New.
* g++.dg/pph/x0funcinl2.h: New.
* g++.dg/pph/x0funcinl3.h: New.
* g++.dg/pph/x3funcinl12.cc: New.
* g++.dg
by assigning
values soon to be overwritten.
Tested on x64.
Index: gcc/cp/ChangeLog.pph
2012-02-16 Lawrence Crowl cr...@google.com
* pph-in.c (pph_in_merge_lang_indep_tree_body): Avoid a false used
uninitialized error message.
Index: gcc/cp/pph-in.c
.
In addition, there are a couple of fixes to protect against null
pointers.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2012-02-23 Lawrence Crowl cr...@google.com
* g++.dg/pph/x2incomplete4.cc: Make expected assembley diff.
Index: gcc/cp/ChangeLog.pph
2012-02-23 Lawrence
enables the above. line.
* One test has changed trailing include text into a comment.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2012-03-01 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp: Change search for dg-xfail-if to xfail-if.
* g++.dg/pph/d0include-next.h: Put dg
to the trace output. This capability is
used to emit merge names into the trace.
* Add functions pph_out_struct_function_for_decl and
pph_out_cgraph_node_for_decl to provide a better debugging handle on
symtab expansion.
Index: gcc/testsuite/ChangeLog.pph
2012-03-07 Lawrence Crowl cr
, and x4neststruct2.cc. The latter test demonstrates
the problem with a failure.
Tested on x64.
Index: gcc/c-family/ChangeLog.pph
2012-03-09 Lawrence Crowl cr...@google.com
* c.opt (-fprimary-system-header-okay): New.
* c-opts.c (c_common_handle_option): Add handling
an option -fpph-check to refine our check for headers compatible
with PPH. It implies -fprimary-system-header-okay and checks for the main
source file missing a guard. Generating a pph file implies the same check.
Tested on x64.
Index: gcc/c-family/ChangeLog.pph
2012-03-15 Lawrence Crowl cr
missing null pointer checks. Add them.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2012-03-16 Lawrence Crowl cr...@google.com
* g++.dg/pph/README: Clarify p category.
* g++.dg/pph/c1anonymous1.h: Mark passing.
* g++.dg/pph/c1anonymous2.h: Mark passing
)${host_installdir}; done
# By adding these files here, automake will remove them for 'make
clean' -CLEANFILES = ${pch_output} ${pch_output_anchors} stamp-host
+CLEANFILES = ${pch_output} ${pch_output_anchors} ${pph_output}
stamp-host
# To remove directories.
clean-local:
--
Lawrence Crowl
emitted.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2012-03-22 Lawrence Crowl cr...@google.com
* g++.dg/pph/x1tmpldfltparm.cc: Failure change from merging to excess
code generation.
Index: gcc/cp/ChangeLog.pph
2012-03-22 Diego Novillo dnovi...@google.com
, we alway emit all namespaces into the PPH file. We may
not emit decls within them.
There is an overloading bug in this patch, but I am pushing it up
now to avoid keeping so large a change hanging.
Index: gcc/testsuite/ChangeLog.pph
2011-01-17 Lawrence Crowl cr...@google.com
* g++.dg
Correct construction of bindings for overloaded symbols.
Index: gcc/testsuite/ChangeLog.pph
2011-01-20 Lawrence Crowl cr...@google.com
* g++.dg/pph/x4overset1.cc: Make passing.
* g++.dg/pph/x4overset2.cc: Make wanted assembly diff.
* g++.dg/pph/x4overset3.cc: Make
. These will be treated as passes.
Clarify a few other failures.
Make various debug/trace dump changes.
Index: gcc/testsuite/ChangeLog.pph
2012-01-24 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp: Add an asm 'xokay' for benign assembly differences.
* g++.dg/pph/x4keyno.cc: Bug
errors.
* g++.dg/pph/x5dynarray7.h: Add one bogus error.
* g++.dg/pph/x6dynarray6.h: Add one bogus error.
2012-01-24 Lawrence Crowl cr...@google.com
Index: gcc/cp/ChangeLog.pph
2012-01-25 Lawrence Crowl cr...@google.com
* pph-core.c (pph_dump_tree_name): Refactor
Emit some state hidden in cp/decl2.c: pending_statics, deferred_fns, and
no_linkage_decls.
One tests is now passing, two tests are now okay, and three tests have
improved, but are still failing.
Index: gcc/testsuite/ChangeLog.pph
2012-01-26 Lawrence Crowl cr...@google.com
* g++.dg
that they can be used while reading other
fields.
The patch adds some new tests for the upcoming type merging.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2012-02-01 Lawrence Crowl cr...@google.com
* g++.dg/pph/c0struct.h: Rename to c0struct2.h.
* g++.dg/pph/c0struct1.h
cases x*incomplete*, which progressively add more information to the
classes in different configurations of pph files.
Tested on x64.
Index: gcc/testsuite/ChangeLog.pph
2012-02-01 Lawrence Crowl cr...@google.com
* g++.dg/pph/x4structover1.cc: Mark fixed.
* g++.dg/pph
/ChangeLog.pph
2011-05-26 Lawrence Crowl cr...@google.com
* cp-objcp-common.c (cp_tree_size): Add case TREE_BINFO.
* pph.c (pph_read_file): Also log closing of PPH files.
* pph-streamer-in.c (pph_stream_read_tree):
Organize the switch into tcc_* chunks.
Move
On 5/26/11, Nathan Froyd froy...@codesourcery.com wrote:
On 05/26/2011 10:24 PM, Lawrence Crowl wrote:
Index: gcc/cp/cp-objcp-common.c
===
--- gcc/cp/cp-objcp-common.c (revision 174301)
+++ gcc/cp/cp-objcp-common.c (working copy
Remove case TREE_BINFO in cp_tree_size().
Index: gcc/cp/ChangeLog.pph
2011-05-27 Lawrence Crowl cr...@google.com
* cp-objcp-common.c (cp_tree_size): Remove case TREE_BINFO.
Index: gcc/cp/cp-objcp-common.c
===
--- gcc
on later ICEs.
Tests adjusted to reflect new reality.
Tested on x86-64. Committed.
Index: gcc/testsuite/ChangeLog.pph
2011-06-05 Lawrence Crowl cr...@google.com
* g++.dg/pph/x1special.cc: Change to new ICE.
* g++.dg/pph/x1template.cc: Change old ICE to new location.
* g
.
--
Lawrence Crowl
listing XFAILs that need work.
Index: gcc/testsuite/ChangeLog.pph
2011-06-08 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp (dg-pph-pos): Stop redundantly reporting a missing
pph assembly as an xfail when its compile xfails.
* g++.dg/pph/x1typerefs.cc: Replace ICE xfail
a decent comparison. The existing tools
only compare against whether or not tests fail. They fail to
report that a test failed for different reasons. Given that there
are only twelve tests for which there is a concern, I think we are
better off know where we are.
--
Lawrence Crowl
Some builtin macros are more builtin than others. In particular, front-end
builtin macros are weaker than libcpp builtin macros, and should not be
processed with the libcpp builtin tools.
Index: gcc/testsuite/ChangeLog.pph
2011-06-08 Lawrence Crowl cr...@google.com
* g++.dg/pph
= ] ; then
+echo Could not find a spawn command for pattern $1
+exit 1
+fi
+
+set -x +e
+$line $args
+exit $?
--
This patch is available for review at http://codereview.appspot.com/4601050
--
Lawrence Crowl
performance problems (unnecessary reloads) and correctness problems
(missing reloads in the presence of aliasing).
--
Lawrence Crowl
rather not get into complicated search rules just yet.
--
Lawrence Crowl
/testsuite/ChangeLog.pph
2011-06-27 Lawrence Crowl cr...@google.com
* g++.dg/pph/pph.map: Add missing PPH mappings.
* g++.dg/pph/c1funcstatic.cc: Add expected asm diff.
* g++.dg/pph/c1eabi1.cc: Add xfail-if; remove expected asm diff.
* g++.dg/pph/c2builtin2.cc: Add
.
Index: gcc/testsuite/ChangeLog.pph
2011-06-29 Lawrence Crowl cr...@google.com
* lib/dg-pph.exp: Run pph executables when normal executables run.
Change (assembly identical) and (assembly mismatch) to (assembly
comparison) to avoid false disappeared test
reports
}
--
This patch is available for review at http://codereview.appspot.com/4635087
--
Lawrence Crowl
.
That looks easy enough. I need to finish the current test stuff
before I get to that though.
--
Lawrence Crowl
conflict)
The latter test is not an artificial testcase.
Index: gcc/testsuite/ChangeLog.pph
2011-07-01 Lawrence Crowl cr...@google.com
* g++.dg/pph/a1dynarray-dcl1.hi: New.
* g++.dg/pph/a1dynarray-dcl2a.hi: New.
* g++.dg/pph/a1dynarray-dcl2b.hi: New.
* g++.dg/pph
typedefs value_type and compare_type instead
of T. Change all users to match.
Add usage documentation to hash-table.h.
Tested on x86-64.
Okay for trunk?
Index: gcc/ChangeLog
2012-10-25 Lawrence Crowl cr...@google.com
* hash-table.h: Add usage documentation.
(template struct
On 10/26/12, Richard Biener richard.guent...@gmail.com wrote:
On Oct 25, 2012 Lawrence Crowl cr...@googlers.com wrote:
Change hash_table to support a comparator type different from the
value type stored in the hash table. The 'find' functions now
may take a different type from the value
to varpool_node_for_decl.
Tested on x86_64.
Okay for trunk?
Index: gcc/ChangeLog
2012-10-26 Lawrence Crowl cr...@google.com
* is-a.h: New.
(is_a T (U*)): New. Test for is-a relationship.
(as_a T (U*)): New. Treat as a derived type.
(dyn_cast T (U*)): New
On 10/25/12, Lawrence Crowl cr...@googlers.com wrote:
This patch implements the unification of the *bitmap interfaces as
discussed.
Essentially, we rename ebitmap and sbitmap functions to use the same names
as the bitmap functions. This rename works because we can now overload
on the bitmap
On 10/29/12, Richard Biener richard.guent...@gmail.com wrote:
On Oct 29, 2012 Diego Novillo dnovi...@google.com wrote:
On Oct 25, 2012 Lawrence Crowl cr...@googlers.com wrote:
The sbitmap non-bool returning bitwise operations have been
merged with the bool versions. Sometimes this merge
On 10/27/12, Marc Glisse marc.gli...@inria.fr wrote:
On Fri, 26 Oct 2012, Lawrence Crowl wrote:
2012-10-26 Lawrence Crowl cr...@google.com
missing ''
Fixed.
* is-a.h: New.
(is_a T (U*)): New. Test for is-a relationship.
(as_a T (U*)): New. Treat as a derived type
On 10/29/12, Diego Novillo dnovi...@google.com wrote:
On Oct 29, 2012 Lawrence Crowl cr...@googlers.com wrote:
The sbitmap popcount function is only used in ebitmap, which is
itself not used. If we do anything, removing them might be the
thing to do.
Yes, please.
Separate patch, please
and changed them as well.
The only two sets of functions that will remain separate for
now are the iterators and the bitmap creation routines, I think.
Lawrence?
The iterator functions have been unified, but not the iterator
type names.
--
Lawrence Crowl
101 - 200 of 276 matches
Mail list logo
