On 10/30/12, Diego Novillo dnovi...@google.com wrote:
On 2012-10-29 15:01 , Lawrence Crowl wrote:
On 10/27/12, Marc Glisse marc.gli...@inria.fr wrote:
On Fri, 26 Oct 2012, Lawrence Crowl wrote:
2012-10-26 Lawrence Crowl cr...@google.com
missing ''
Fixed.
* is-a.h: New.
(is_a T
On 10/30/12, Diego Novillo dnovi...@google.com wrote:
On Tue, Oct 30, 2012 at 4:53 PM, Lawrence Crowl cr...@googlers.com wrote:
On 10/30/12, Diego Novillo dnovi...@google.com wrote:
So, to use these three functions, the user must define this single
'is_a_helper' routine? Nothing else?
You
. Comments?
--
Lawrence Crowl
declared in contexts where the bitmap type is not obvious. There are less
than 40 uses of this type, so the burden to modify it when changing bitmap
types is not large.
Tested on x86-64, config-list.mk testing in progress.
Okay for trunk?
Index: gcc/ChangeLog
2012-10-31 Lawrence Crowl cr
to the implementation file:
SBITMAP_SIZE_BYTES
sbitmap_verify_popcount
Tested on x86-64.
Okay for trunk?
Index: gcc/ChangeLog
2012-10-31 Lawrence Crowl cr...@google.com
* ebitmap.h: Remove unused.
* ebitmap.c: Remove unused.
* Makefile.in: Remove ebitmap.h and ebitmap.c
On 11/1/12, Diego Novillo dnovi...@google.com wrote:
On 2012-10-31 13:41 , Lawrence Crowl wrote:
This patch normalizes more bitmap function names.
sbitmap.h
TEST_BIT - bitmap_bit_p
SET_BIT - bitmap_set_bit
I wonder if it wouldn't it be more consistent if TEST_BIT became
On 11/1/12, Diego Novillo dnovi...@google.com wrote:
On 2012-10-31 13:43 , Lawrence Crowl wrote:
Rename the EXECUTE_IF_SET_IN_SBITMAP macro to
EXECUTE_IF_SET_IN_BITMAP. Its implementation is now identical to
that in bitmap.h. To prevent redefinition errors, both definitions
are now
On 11/1/12, Diego Novillo dnovi...@google.com wrote:
On 2012-10-31 18:47 , Lawrence Crowl wrote:
2012-10-31 Lawrence Crowl cr...@google.com
* ebitmap.h: Remove unused.
* ebitmap.c: Remove unused.
* Makefile.in: Remove ebitmap.h and ebitmap.c.
* sbitmap.h
On 11/2/12, Eric Botcazou ebotca...@adacore.com wrote:
Index: gcc/ChangeLog
2012-10-31 Lawrence Crowl cr...@google.com
* is-a.h: New.
(is_a T (U*)): New. Test for is-a relationship.
(as_a T (U*)): New. Treat as a derived type.
(dyn_cast T (U*)): New. Conditionally
on x86_64 builds.
Okay for trunk?
Index: contrib/ChangeLog
2012-11-05 Lawrence Crowl cr...@google.com
* compare_two_ftime_report_sets: New.
Index: contrib/compare_two_ftime_report_sets
===
--- contrib
On 11/6/12, Diego Novillo dnovi...@google.com wrote:
On Nov 5, 2012 Lawrence Crowl cr...@googlers.com wrote:
2012-11-05 Lawrence Crowl cr...@google.com
* compare_two_ftime_report_sets: New.
OK. Thanks.
Committed.
--
Lawrence Crowl
.
Okay for branch?
Index: gcc/ChangeLog
2012-11-30 Lawrence Crowl cr...@google.com
* data-streamer.h (struct string_slot): Move to lto-streamer.h.
(hash_string_slot_node): Move implementation into lto-streamer.h
struct string_slot_hasher.
(eq_string_slot_node
unused:
insert_loop_close_phis
insert_guard_phis
debug_ivtype_map
ivtype_map_elt_info
new_ivtype_map_elt
Tested on x86-64.
Okay for branch?
Index: gcc/ChangeLog
2012-11-30 Lawrence Crowl cr...@google.com
* graphite-htab.h: New.
(typedef hash_table bb_pbb_hasher
Change gimplify.c gimplify_ctx::temp_htab hash table from htab_t to
hash_table.
Move struct gimple_temp_hash_elt and struct gimplify_ctx to a new
gimplify-ctx.h, because they are used few places.
Tested on x86-64.
Okay for branch?
Index: gcc/ChangeLog
2012-11-30 Lawrence Crowl cr
dependences and because they are used in few places.
Tested on x86-64.
Okay for branch?
Index: gcc/ChangeLog
2012-11-30 Lawrence Crowl cr...@google.com
* tree-hasher.h: New.
(struct int_tree_hasher): New.
(typedef int_tree_htab_type): New.
* tree-flow.h (extern
to notice the change, but
incorrect code will.)
Tested on x86-64.
Okay for branch?
Index: gcc/ChangeLog
2012-11-30 Lawrence Crowl cr...@google.com
* hash-table.h (class hash_table):
Correct many methods with parameter types compare_type to the correct
value_type
, as in
if (varpool_node *vnode = (node-try_variable ()
vnode-finalized))
varpool_analyze_node (vnode);
which does not type-match.
So, if you want the type saftey and performance, the cascade is really
unavoidable.
--
Lawrence Crowl
On 9/18/12, Richard Guenther richard.guent...@gmail.com wrote:
On Sep 18, 2012 Lawrence Crowl cr...@googlers.com wrote:
* cgraph.h (varpool_node): Rename to varpool_node_for_tree.
Sure it should be varpool_node_for_decl, if any.
Or varpool_node_from_decl (grep for what is more common)
Grep
?
--
Lawrence Crowl
can write 'function' instead of
'cgraph_node *'.
--
Lawrence Crowl
On 9/19/12, Gabriel Dos Reis g...@integrable-solutions.net wrote:
On Wed, Sep 19, 2012 at 1:39 PM, Lawrence Crowl cr...@googlers.com wrote:
On 9/19/12, Gabriel Dos Reis g...@integrable-solutions.net wrote:
On Sep 19, 2012 Richard Guenther richard.guent...@gmail.com wrote:
Indeed. Btw, can we
On 9/20/12, Michael Matz m...@suse.de wrote:
On Wed, 19 Sep 2012, Lawrence Crowl wrote:
On 9/19/12, Eric Botcazou ebotca...@adacore.com wrote:
The language syntax would bind the conditional into the
intializer, as in
if (varpool_node *vnode = (node-try_variable
On 9/20/12, Gabriel Dos Reis g...@integrable-solutions.net wrote:
On Sep 20, 2012 Lawrence Crowl cr...@googlers.com wrote:
Why do you think cascading ifs is a bad idea?
Precedent. Confusion in case of dangling else (requiring
more {}, and hence even more indentation). Ugly.
I
/ChangeLog
2012-09-18 Lawrence Crowl cr...@google.com
* cgraph.h (varpool_node): Rename to varpool_node_for_tree.
Adjust callers to match.
(symtab_node_def::try_function): New.
Change most calls to symtab_function_p with calls to
symtab_node_def::try_function
objections to me changing it to that?
--
Lawrence Crowl
On 9/26/12, Michael Matz m...@suse.de wrote:
On Tue, 25 Sep 2012, Lawrence Crowl wrote:
On 8/15/12, Richard Henderson r...@redhat.com wrote:
On 2012-08-15 07:29, Richard Guenther wrote:
typedef typename Element::Element_t Element_t;
Can we use something less ugly than Element_t
On 9/27/12, Michael Matz m...@suse.de wrote:
On Wed, 26 Sep 2012, Lawrence Crowl wrote:
A lower-case type name indicates to me a non-changing type,
i.e. nothing that depends on a template. In C we only had
such types so we used lower-case names everywhere. With C++
and templates I
On 9/28/12, Michael Matz m...@suse.de wrote:
On Thu, 27 Sep 2012, Lawrence Crowl wrote:
template typename T
struct D : BT
{
typedef typename BT::E E; // element_type
E getme (int index);
}
Inside that struct, lets say we have a field of type E. Do we name
it F or f
be helpful. If I say Tim's father you know
role of that person without knowing exactly who it is. The typedef
convention serves the same purpose. It is important that we use the
same term for father, or we wouldn't be able to communicate.
--
Lawrence Crowl
on x86-64.
Okay for trunk?
Index: gcc/java/ChangeLog
2012-10-01 Lawrence Crowl cr...@google.com
* Make-lang.in (JAVA_OBJS): Add dependence on hash-table.o.
(JCFDUMP_OBJS): Add dependence on hash-table.o.
(jcf-io.o): Add dependence on hash-table.h.
* jcf-io.c
On 10/2/12, Richard Guenther rguent...@suse.de wrote:
On Mon, 1 Oct 2012, Lawrence Crowl wrote:
Change more non-GTY hash tables to use the new type-safe
template hash table. Constify member function parameters that
can be const. Correct a couple of expressions in formerly
uninstantiated
: gcc/ChangeLog
2012-10-02 Lawrence Crowl cr...@google.com
* cgraph.h (varpool_node): Rename to varpool_node_for_decl.
Adjust callers to match.
(symtab_node_def::try_function): New.
Change most calls to symtab_function_p with calls to
symtab_node_def
On 10/2/12, Ian Lance Taylor i...@google.com wrote:
On Oct 2, 2012 Lawrence Crowl cr...@googlers.com wrote:
On 10/2/12, Richard Guenther rguent...@suse.de wrote:
You are changing a hashtable used by fold checking, did you
test with fold checking enabled?
I didn't know I had to do
...@cs.tu-berlin.de
François-Xavier Coudertfxcoud...@gcc.gnu.org
Cary Coutant ccout...@google.com
+Lawrence Crowl cr...@google.com
Ian Dall i
On 10/2/12, Richard Guenther rguent...@suse.de wrote:
On Mon, 1 Oct 2012, Lawrence Crowl wrote:
Change more non-GTY hash tables to use the new type-safe template hash
table.
Constify member function parameters that can be const.
Correct a couple of expressions in formerly uninstantiated
parameters that can be const.
Correct a couple of expressions in formerly uninstantiated templates.
The new code is 0.362% faster in bootstrap, with a 99.5% confidence of
being faster.
Tested on x86-64.
Okay for trunk?
Index: gcc/java/ChangeLog
2012-10-01 Lawrence Crowl cr...@google.com
On 10/4/12, Richard Guenther rguent...@suse.de wrote:
On Tue, 2 Oct 2012, Lawrence Crowl wrote:
On 10/2/12, Richard Guenther rguent...@suse.de wrote:
On Mon, 1 Oct 2012, Lawrence Crowl wrote:
Change more non-GTY hash tables to use the new type-safe
template hash table. Constify member
On 10/5/12, Richard Guenther rguent...@suse.de wrote:
On Thu, 4 Oct 2012, Lawrence Crowl wrote:
On 10/4/12, Richard Guenther rguent...@suse.de wrote:
On Tue, 2 Oct 2012, Lawrence Crowl wrote:
On 10/2/12, Richard Guenther rguent...@suse.de wrote:
On Mon, 1 Oct 2012, Lawrence Crowl wrote
Could you please review the patch at
http://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg40961.html?
On 10/3/12, Lawrence Crowl cr...@googlers.com wrote:
Sorry, one more time with the right file contents.
On 10/2/12, Richard Guenther rguent...@suse.de wrote:
You are changing a hashtable
that much attention to over the years.
I just don't believe the 0.5% numbers.
Then ask. Don't mock, please.
--
Lawrence Crowl
On 10/5/12, Jakub Jelinek ja...@redhat.com wrote:
On Fri, Oct 05, 2012 at 01:59:18PM -0700, Lawrence Crowl wrote:
With the constructor, you don't have to remember and you don't
have to type more. If you have a variable, you know that it is
properly initialized.
But we really don't want
On 10/5/12, Diego Novillo dnovi...@google.com wrote:
On Oct 3, 2012 Lawrence Crowl cr...@googlers.com wrote:
Change more non-GTY hash tables to use the new type-safe
template hash table. Constify member function parameters that
can be const. Correct a couple of expressions in formerly
On 10/5/12, Jan Hubicka hubi...@ucw.cz wrote:
On Thu, Oct 4, 2012 at 8:16 PM, Diego Novillo dnovi...@google.com wrote:
On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl cr...@googlers.com wrote:
So, Jan Hubicka requested and approved the current spelling.
What now?
I don't think we
())
versus
if (cgraph_node *q = p-cast_to cgraph_node * ())
I thought the latter would generate objections. Does anyone object
to the extra typing?
If not, I can make that change.
--
Lawrence Crowl
On 10/12/12, Richard Biener richard.guent...@gmail.com wrote:
On Oct 11, 2012 Xinliang David Li davi...@google.com wrote:
On Oct 11, 2012 Lawrence Crowl cr...@googlers.com wrote:
On 10/10/12, Xinliang David Li davi...@google.com wrote:
In a different thread, I proposed the following
Descr, Allocator
-::traverse (Argument argument)
+hash_table Descr, Allocator::traverse (Argument argument)
{
size_t size = htab-size;
if (elements () * 8 size size 32)
--
Lawrence Crowl
be fine.
--
Lawrence Crowl
conversion operators to achieve the effect. However,
we probably don't want to do so until we can make them explicit.
Unfortunately, explicit conversion operators are not available
until C++11.
No, I don't want you to do the above transform with this patch ;)
--
Lawrence Crowl
. Lawrence?
Yes, in C++11, wide_int::zero ({32, 32}) is possible using an
implicit conversion to WIntSpec from an initializer_list. However,
at present we are limited to C++03 to enable older compilers as
boot compilers.
--
Lawrence Crowl
. In the case of double int, the goal was to simplify
use of the existing semantics. If you are changing the semantics,
consider incorporating sign explicitly.
--
Lawrence Crowl
On 10/23/12, Kenneth Zadeck zad...@naturalbridge.com wrote:
On 10/23/2012 02:38 PM, Lawrence Crowl wrote:
On 10/23/12, Kenneth Zadeck zad...@naturalbridge.com wrote:
On 10/23/2012 10:12 AM, Richard Biener wrote:
+ inline bool minus_one_p () const;
+ inline bool zero_p () const;
+ inline
/ChangeLog
2013-04-24 Lawrence Crowl cr...@google.com
* config/arm/t-arm: Update for below.
* config/arm/arm.c (arm_libcall_uses_aapcs_base::libcall_htab):
Change type to hash_table. Update dependent calls and types.
* config/i386/t-cygming: Update for below
On 4/25/13, Richard Biener richard.guent...@gmail.com wrote:
Thus, the patch is ok apart from the var-tracking.c bits which
I defer to respective maintainers.
Okay, I split out the var-tracking.c changes. I've committed the
rest to trunk.
--
Lawrence Crowl
On 4/25/13, Diego Novillo dnovi...@google.com wrote:
On 2013-04-24 15:58 , Lawrence Crowl wrote:
* var-tracking.c'emit_note_data_def.vars
* var-tracking.c'shared_hash_def.htab
* var-tracking.c'changed_variables
Fold variable_htab_hash, variable_htab_eq, variable_htab_free
into new struct
I still have not heard from i386 or ia64 folks. Anyone?
On 4/24/13, Lawrence Crowl cr...@googlers.com wrote:
This patch is a consolodation of the hash_table patches to the
cxx-conversion branch for files under gcc/config.
Recipients:
config/arm/arm.c - ni...@redhat.com, ramana.radhakrish
On 5/21/13, Diego Novillo dnovi...@google.com wrote:
On May 13, 2013 Lawrence Crowl cr...@googlers.com wrote:
I still have not heard from i386 or ia64 folks. Anyone?
The i386 bits look fine to me as well. Please wait 48 hours to
give the i386 maintainers a chance to object.
Committed
to me.
--
Lawrence Crowl
by default and fails to handle many C++
tree nodes.
Fixed by adding debug_raw for vectree,va_gc and changing
debug_vec_tree to use that.
OK for trunk?
Looks good to me.
--
Lawrence Crowl
*/
--
Lawrence Crowl
?
--
Lawrence Crowl
On 3/25/13, Tom Tromey tro...@redhat.com wrote:
Lawrence == Lawrence Crowl cr...@googlers.com writes:
Lawrence This patch is somewhat different from the original plan at
Lawrence gcc.gnu.org/wiki/cxx-conversion/debugging-dumps. The reason
Lawrence is that gdb has an incomplete implementation
On 3/26/13, Richard Biener richard.guent...@gmail.com wrote:
On Mar 25, 2013 Lawrence Crowl cr...@googlers.com wrote:
On 3/25/13, Richard Biener richard.guent...@gmail.com wrote:
You add a not used new interface. What for?
So that people can use it.
For use from gdb only
On 3/26/13, Lawrence Crowl cr...@googlers.com wrote:
On 3/26/13, Richard Biener richard.guent...@gmail.com wrote:
On Mar 25, 2013 Lawrence Crowl cr...@googlers.com wrote:
On 3/25/13, Richard Biener richard.guent...@gmail.com wrote:
You add a not used new interface. What for?
So
On 3/27/13, Richard Biener richard.guent...@gmail.com wrote:
On Mar 27, 2013, Lawrence Crowl cr...@googlers.com wrote:
Patch with rename to debug attached.
Tested on x86_64.
Add uniform debug dump function names.
Add some overloaded functions that provide uniform debug dump
function
On 3/27/13, Richard Biener richard.guent...@gmail.com wrote:
On Mar 23, 2013 Lawrence Crowl cr...@googlers.com wrote:
This patch is a consolodation of the hash_table patches to the
cxx-conversion branch.
Update various hash tables from htab_t to hash_table.
Modify types and calls
On 3/28/13, Richard Biener richard.guent...@gmail.com wrote:
The patch is ok as-is.
Committed.
--
Lawrence Crowl
(extern insert_loop_close_phis): Removed unused.
(extern insert_guard_phis): Removed unused.
(extern ivtype_map_elt_info): Removed unused.
(new_ivtype_map_elt): Removed unused.
* sese.c (ivtype_map_elt_info): Removed unused.
2013-03-28 Lawrence Crowl cr...@google.com
that are then never read.
Tested on x86-64.
Index: gcc/ChangeLog
2013-03-29 Lawrence Crowl cr...@google.com
* dse.c (clear_alias_sets): Remove never set.
(disqualified_clear_alias_sets): Remove never set.
(clear_alias_mode_pool): Remove never set.
(dse_step0
On 3/29/13, Jeff Law l...@redhat.com wrote:
On 03/29/2013 02:24 AM, Lawrence Crowl wrote:
This patch has been in the hash-table branch for months.
I thought it didn't quite meet the criteria for obvious,
but it's close.
In dse.c, remove alias hash tables that are never set.
Remove
without
the callback.
Lawrence, that's the critical bit of information you failed
to provide.
Sorry.
Patch approved, please install.
Committed.
--
Lawrence Crowl
Remove unused symbols related to ivtype_map. This map does not appear to
exist and I see no evidence of its removal in the ChangeLog.
Tested on x86_64.
Okay for trunk?
Index: gcc/ChangeLog
2013-03-31 Lawrence Crowl cr...@google.com
* sese.h (struct ivtype_map_elt_s): Remove unused
On 4/2/13, Richard Biener richard.guent...@gmail.com wrote:
On Mon, Apr 1, 2013 at 12:19 AM, Lawrence Crowl cr...@googlers.com wrote:
Remove unused symbols related to ivtype_map. This map does not appear to
exist and I see no evidence of its removal in the ChangeLog.
Tested on x86_64.
Okay
// zero extend
See http://www.cplusplus.com/reference/type_traits/is_signed/.
If you want to handle non-builtin types that are asigne dor unsigned,
then you need to add a specialization for is_signed.
--
Lawrence Crowl
operands to larger operands, so I think a reasonable
definition is possible here.
--
Lawrence Crowl
and the target machine.
Yes, that's a correct understanding
In essence, you have moved some of the optimization from the back
end to the front end. Correct?
--
Lawrence Crowl
Ping?
On 3/31/13, Lawrence Crowl cr...@googlers.com wrote:
On 3/28/13, Richard Biener richard.guent...@gmail.com wrote:
On Mar 27, 2013 Lawrence Crowl cr...@googlers.com wrote:
On 3/27/13, Richard Biener richard.guent...@gmail.com wrote:
On Mar 23, 2013 Lawrence Crowl cr...@googlers.com
201 - 276 of 276 matches
Mail list logo
