Re: [PATCH 0/4] BRIG (HSAIL) frontend

Ping: Any further comments to the patch set? Thanks, Pekka On Wed, May 18, 2016 at 8:01 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > Hi Joseph, > > Updated diffstat below: > Makefile.def |

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

On Wed, May 18, 2016 at 9:36 PM, David Malcolm <dmalc...@redhat.com> wrote: > On Wed, 2016-05-18 at 19:59 +0300, Pekka Jääskeläinen wrote: >> Hi Joseph, >> >> Thanks for the comments. Updated patch attached. Hopefully I >> didn't miss any diags. > > It lo

Re: [PATCH 1/4] BRIG (HSAIL) frontend: configuration file changes and misc

On Wed, May 18, 2016 at 7:58 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > Attached an updated patch (rebased + added .texi docs). Trying again. The file got somehow corrupted in the process. Sorry, Pekka The configuration file changes, documentation updates and other updat

[PATCH 0/4] BRIG (HSAIL) frontend

|57 + libhsail-rt/rt/workitems.c| 928 + 85 files changed, 42754 insertions(+) BR, -- Pekka Jääskeläinen Parmance

[PATCH 4/4] BRIG (HSAIL) frontend: smoke test suite

A smoke test suite. The patch has been tested more thoroughly with the proprietary HSA PRM conformance suite. Requires the HSAILasm tool to first compile the .hsail to .brig. -- Pekka Jääskeläinen Parmance A smoke test suite. The patch has been tested more thoroughly with the proprietary HSA

[PATCH 1/4] BRIG (HSAIL) frontend: configuration file changes and misc

The configuration file changes and misc. updates required by the BRIG frontend. Also, added include/hsa-interface.h which is hsa.h taken from libgomp and will be shared by it (agreed with Martin Liška / SUSE). -- Pekka Jääskeläinen Parmance The configuration file changes and misc. updates

[PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

The BRIG frontend itself. -- Pekka Jääskeläinen Parmance 002-brig-fe-new-files.patch.gz Description: application/gzip

Re: [PATCH 0/4] BRIG (HSAIL) frontend

| 928 + 88 files changed, 42773 insertions(+), 1 deletion(-) On Wed, May 18, 2016 at 3:17 AM, Joseph Myers <jos...@codesourcery.com> wrote: > On Mon, 16 May 2016, Pekka Jääskeläinen wrote: > >> The diffstat is as follows: > > I don't see any .tex

Re: [PATCH 1/4] BRIG (HSAIL) frontend: configuration file changes and misc

Hi, Attached an updated patch (rebased + added .texi docs). On Mon, May 16, 2016 at 8:25 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > The configuration file changes and misc. updates required > by the BRIG frontend. > > Also, added include/hsa-interface.h which i

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

Hi Joseph, Thanks for the comments. Updated patch attached. Hopefully I didn't miss any diags. On Wed, May 18, 2016 at 3:20 AM, Joseph Myers wrote: > This patch has many improperly formatted diagnostic messages (e.g. > starting with capital letters, ending with '.' or

Re: [PATCH 4/4] BRIG (HSAIL) frontend: smoke test suite

Updated the test suite by refreshing the test strings to match the new output + added a new regression test case. On Mon, May 16, 2016 at 8:26 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > A smoke test suite. The patch has been tested more thoroughly with the > proprie

Re: [PATCH 0/4] BRIG (HSAIL) frontend

insertions(+), 3 deletions(-) On Wed, May 18, 2016 at 3:17 AM, Joseph Myers <jos...@codesourcery.com> wrote: > On Mon, 16 May 2016, Pekka Jääskeläinen wrote: > >> The diffstat is as follows: > > I don't see any .texi files in this diffstat. New front ends need all > rel

Re: [PATCH 1/4] BRIG (HSAIL) frontend: configuration file changes and misc

Updated patch attached. On Wed, May 18, 2016 at 7:58 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > Hi, > > Attached an updated patch (rebased + added .texi docs). > > On Mon, May 16, 2016 at 8:25 PM, Pekka Jääskeläinen <pe...@parmance.com> > wrote: >

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

Thanks a lot for the review Martin, Responses inline: On Mon, Aug 1, 2016 at 7:37 PM, Martin Jambor wrote: > > - I would definitely appreciate more comments. All but the most > trivial functions should have one that describes what the function > does, what are its

Re: [PATCH] Actually fix libhsail-rt build on x86_64/i?86 32-bit (take 2)

Hi Jakub, Thanks for the fix. I've tested this patch with the HSA PRM suite and no bri{ck,g}ing, so please go ahead and commit. BR, Pekka On Mon, Jan 30, 2017 at 10:17 PM, Jakub Jelinek wrote: > On Mon, Jan 30, 2017 at 08:53:18PM +0100, Bernhard Reutner-Fischer wrote: >> As

Re: [PATCH 1/4] BRIG (HSAIL) frontend: configuration file changes and misc

Hi, On Tue, Jan 24, 2017 at 7:26 PM, Joseph Myers wrote: > Since front ends can't be enabled or disabled on a per-multilib basis, if > you want to support any x86/x86_64 GNU/Linux configuration you need to > support all of them here (and possibly disable runtime

Re: [PATCH] BRIG frontend: request for a global review

On Thu, Jan 26, 2017 at 10:28 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Jan 26, 2017 at 09:38:23AM +0200, Pekka Jääskeläinen wrote: >> > I suppose that also contrib/update-copyright.py need to be updated? (I >> > never looked into that, so don't know.) >>

Re: [PATCH] BRIG frontend: request for a global review

7 at 01:30:21PM +0200, Pekka Jääskeläinen wrote: >> diff --git a/ChangeLog b/ChangeLog >> index 9695f9d..6f4f256 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,9 @@ >> +2017-01-26 Pekka Jskel??inen <pekka.jaaskelai...@parmance.com>

Re: [PATCH] BRIG frontend: request for a global review

On Wed, Jan 25, 2017 at 6:07 PM, Thomas Schwinge wrote: > Hi! > > On Wed, 25 Jan 2017 13:21:13 +0100, Jakub Jelinek wrote: >> On Wed, Jan 25, 2017 at 11:00:50AM +0100, Thomas Schwinge wrote: >> > On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor

Re: [PATCH] BRIG frontend: request for a global review

OK, I'll see into adapting the Jakub's idea and also check if some of the simplest builtins are better expanded directly to tree nodes instead. I'm not sure if lto support is needed though as the assumption now is to have fully linked input to this FE (all necessary BRIG modules fed in at build

Re: [PATCH] BRIG frontend: request for a global review

Hi Jakub and Richard, Attached is an updated BRIG FE patch which adds the HSAIL related builtins only internally in the BRIG FE. I didn't add LTO support as I believe it's not useful for BRIG FE due to it always inputting fully linked BRIGs and not mixing with other frontends. BR, Pekka On

Re: [PATCH 3/4] BRIG (HSAIL) frontend: libhsail-rt

Updated patch attached. This one was updated with a new ultra simple fiber implementation that calls ucontext.h API directly instead of requiring Pth in between. Plus cleanups. On Mon, Aug 15, 2016 at 4:22 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > Updated patch attached.

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

Hi Martin, On Fri, Nov 4, 2016 at 4:58 PM, Martin Jambor wrote: > I personally primarily want this for debugging purposes, and we should > try to eventually report errors in a more comprehensible way than > HSAILasm. But more generally, and more importantly, if the input, >

Re: [PATCH] BRIG frontend: request for a global review

On Fri, Jan 13, 2017 at 11:36 PM, Richard Biener wrote: > Ah, with fibers fixed there's only the fp16.c part left. Presumably LGPL > overall is OK as well (but I'm not a lawyer either). Seems fp16.c has the GPL3 runtime exception in place, so I believe we are good

Re: [PATCH] BRIG frontend: request for a global review

Hi, A gentle ping... On Wed, Dec 14, 2016 at 7:15 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > Hi, > > I'm calling for a global review for the BRIG frontend for inclusion in > upstream. > The copyright transfer has been taken care of. > > The patch set has bee

Re: [PATCH] BRIG frontend: request for a global review

Hi Richard, Thanks for the review! Replies/questions inline. On Fri, Jan 13, 2017 at 2:28 PM, Richard Biener <richard.guent...@gmail.com> wrote: > On Thu, Jan 12, 2017 at 3:55 PM, Pekka Jääskeläinen <pe...@parmance.com> > wrote: >> Hi, >> >> A gentle ping...

Re: [PATCH] BRIG frontend: request for a global review

On Fri, Jan 13, 2017 at 2:34 PM, Richard Biener <richard.guent...@gmail.com> wrote: > On Thu, Jan 12, 2017 at 3:55 PM, Pekka Jääskeläinen <pe...@parmance.com> > wrote: >> Hi, >> >> A gentle ping... > > Looking at 002/ > > What's the reason of havi

[PATCH] -fftz-math: assume that denorms _must_ be flushed to zero optimizations

Hi, The attached patch adds a new switch -fftz-math which makes certain optimizations assume that "flush to zero" behavior of denormal inputs and outputs is not an optimization hint, but required behavior for semantical correctness. The need for this was initiated by HSAIL (BRIG). With HSAIL,

Re: [PATCH] -fftz-math: assume that denorms _must_ be flushed to zero optimizations

Hi Richard, The base idea of the patch is to optimize for the (common) situation where FTZ/DAZ is controlled by a CPU-wide flag and we then need to only avoid compile-time optimizations that assume semantics where denorm handling is on to support the ‘forced FTZ/DAZ semantics’. > This suggests

BRIG FE: fix for lda and private arrays

Hi, I committed in r248006 the attached fix for an assertion when doing an 'lda' of a private array offset. BR, -- Pekka Jääskeläinen Parmance Index: gcc/brig/ChangeLog === --- gcc/brig/ChangeLog (revision 248005) +++ gcc/brig

Misc. BRIG/HSAIL FE updates

=== --- gcc/brig/ChangeLog (revision 247575) +++ gcc/brig/ChangeLog (revision 247576) @@ -1,3 +1,11 @@ +2017-05-03 Pekka Jääskeläinen <visit0r@kamu> + + * brigfrontend/brig-code-entry-handler.cc + (brig_code_entry_handler::build_address_operand): Fix a bug + with reg+offset addressing on 32b s

Re: [PATCH] -fftz-math: assume that denorms _must_ be flushed to zero optimizations

Hi Richard and Joseph, Replies for both inline: I wrote: >> Both the inputs and outputs must be flushed to zero in the HSAIL’s >> ‘ftz’ semantics. >> FTZ operations were previously always “explicit” in the BRIG FE output, like >> you >> propose here; there were builtin calls injected for all

Re: [081/nnn] poly_int: brig vector elements

Hi Richard, Indeed, HSAIL doesn't so far support variable length vectors. If it ever will, there will be wider changes needed anyways. So, this patch LGTM. Pekka, A HSA/BRIG maintainer On Mon, Oct 23, 2017 at 7:32 PM, Richard Sandiford wrote: > This patch adds a

[PATCH] [BRIGFE] Reduce the number of type conversions due to the untyped HSAIL regs

nst-handler.cc: Handle any-typed + register variables. + * brigfrontend/brig-cvt-inst-handler.cc: Likewise. + * brigfrontend/brig-function.cc: Build register variables as a + type based on results of analysis phase. + * brigfrontend/brig-function.h: Move HSA register count defines to + brig-utils.h.

Re: [PATCH] BRIG frontend: request for a global review

finalization +@end direntry +@end format + +@insertcopying +@end ifinfo + +@titlepage +@title The GNU BRIG (HSAIL) Compiler +@versionsubtitle +@author Pekka Jääskeläinen + +@page +@vskip 0pt plus 1filll +Published by the Free Software Foundation @* +51 Franklin Street, Fifth Floor@* +Boston, MA 02110-1301

Re: [PATCH] [BRIGFE] Reduce the number of type conversions due to the untyped HSAIL regs

Hi Rainer, On Fri, Nov 17, 2017 at 1:32 PM, Rainer Orth wrote: > Please fix. Fixed in r254870. BR, Pekka

Re: [PATCH 3/8] [BRIGFE] The modulo in ID computation should not be needed.

Commited in r259944. On Fri, May 4, 2018 at 4:58 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > The case where a dim is greater than the grid size doesn't seem > to be mentioned in the specs nor tested by PRM test suite. > --- > gcc/brig/brigfrontend/brig-code-ent

Re: [PATCH 4/8] [BRIGFE] allow controlling strict aliasing from cmd line

Committed as r259948. On Fri, May 4, 2018 at 4:59 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > --- > gcc/brig/brig-lang.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > >

Re: [PATCH 1/8] [BRIGFE] fix an alloca stack underflow

Committed as r259942. On Fri, May 4, 2018 at 4:56 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > We didn't preserve additional space for the alloca frame pointers that > are needed to be saved in the alloca space.

Re: [PATCH 5/8] [BRIGFE] do not allow optimizations based on known C builtins

Committed as r259949. On Fri, May 4, 2018 at 5:00 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > This can break inputs that have similarly names functions. > --- > gcc/brig/brig-lang.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) >

Re: [PATCH 2/8] [BRIGFE] Enable whole program optimizations

Committed as r259943. On Fri, May 4, 2018 at 4:57 PM, Pekka Jääskeläinen <pekka.jaaskelai...@tut.fi> wrote: > HSA assumes all program scope HSAIL symbols can be queried from > the host runtime API, thus cannot be removed by the IPA. > > Getting some inlining happening in th

Re: [PATCH 7/8] [BRIGFE] phsa-specific optimizations

Committed as r259957. On Fri, May 4, 2018 at 5:02 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > Add flag -fassume-phsa that is on by default. If -fno-assume-phsa > is given, these optimizations are disabled. > > With this flag, gccbrig can generate GENERIC that assumes

Re: [PATCH 8/8] [BRIGFE] Fix handling of NOPs

Committed as r259958. On Fri, May 4, 2018 at 5:02 PM, Pekka Jääskeläinen <pe...@parmance.com> wrote: > --- > gcc/brig/brigfrontend/brig-basic-inst-handler.cc | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) >

[PATCH 0/8] [BRIGFE] various fixes and optimizations

Hi, I'm posting a series of patches that I will shortly commit to trunk as a maintainer of the BRIG frontend. All of them are build tested, the last one also with a bootstrap build. Best regards, -- Pekka

[PATCH 1/8] [BRIGFE] fix an alloca stack underflow

We didn't preserve additional space for the alloca frame pointers that are needed to be saved in the alloca space. Fixes libgomp.c++/target-6.C execution test. --- libhsail-rt/rt/workitems.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH 2/8] [BRIGFE] Enable whole program optimizations

HSA assumes all program scope HSAIL symbols can be queried from the host runtime API, thus cannot be removed by the IPA. Getting some inlining happening in the finalized binary required: * explicitly marking the 'prog' scope functions and the launcher function "externally_visible" to avoid the

[PATCH 3/8] [BRIGFE] The modulo in ID computation should not be needed.

The case where a dim is greater than the grid size doesn't seem to be mentioned in the specs nor tested by PRM test suite. --- gcc/brig/brigfrontend/brig-code-entry-handler.cc | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) >From 99303afff584518c1fd17e3c6ebe965043dd58f0 Mon Sep

[PATCH 4/8] [BRIGFE] allow controlling strict aliasing from cmd line

--- gcc/brig/brig-lang.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) >From c8a86773e877949fb9308d2dd448ea013be22c3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pekka=20J=C3=A4=C3=A4skel=C3=A4inen?= Date: Mon, 12 Feb 2018 11:34:58 +0200

[PATCH 5/8] [BRIGFE] do not allow optimizations based on known C builtins

This can break inputs that have similarly names functions. --- gcc/brig/brig-lang.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) >From 105277ee937482ee1a55265b1ec45637bc1e7a0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pekka=20J=C3=A4=C3=A4skel=C3=A4inen?=

[PATCH 6/8] [BRIGFE] skip multiple forward declarations of the same function

--- gcc/brig/brigfrontend/brig-function-handler.cc | 4 1 file changed, 4 insertions(+) >From 1c708e887073960b6142d716d3e85f3453d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pekka=20J=C3=A4=C3=A4skel=C3=A4inen?= Date: Sat, 17 Feb 2018 08:59:25 +0200

[PATCH 8/8] [BRIGFE] Fix handling of NOPs

--- gcc/brig/brigfrontend/brig-basic-inst-handler.cc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) >From fee48e53063309a58a9a3050df26395ae1615111 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pekka=20J=C3=A4=C3=A4skel=C3=A4inen?= Date: Thu, 12

[PATCH 7/8] [BRIGFE] phsa-specific optimizations

Add flag -fassume-phsa that is on by default. If -fno-assume-phsa is given, these optimizations are disabled. With this flag, gccbrig can generate GENERIC that assumes we are targeting a phsa-runtime based implementation, which allows us to expose the work-item context accesses to retrieve WI

Re: [PATCH RFC] add generic expansion for MULT_HIGHPART_EXP

Hi, On Mon, Aug 20, 2018 at 1:46 PM Alexander Monakov wrote: > > So - how difficult is it to fix BRIG to not use MULT_HIGHPART_EXPR if > > not supported? > > Pekka, can you comment? I think you have fallback paths for vector types > only at the moment? I think it involves pretty much moving the