[GOOGLE] Fix -femit-function-names in LIPO profile-use mode

2014-06-24 Thread Teresa Johnson
Emit the proper module name in LIPO profile-use mode. Passes regression tests, ok for google branches? Thanks, Teresa 2014-06-24 Teresa Johnson tejohn...@google.com * coverage.c (emit_function_name): Emit module name in LIPO mode. Index: coverage.c

Re: [PATCH] Add missing -fdump-* options

2014-06-25 Thread Teresa Johnson
On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li davi...@google.com wrote: On Tue, May 13, 2014 at 1:39 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson tejohn...@google.com wrote: I discovered that the support for the documented -fdump

[PATCH] Improve -fdump-tree-all efficiency

2014-06-26 Thread Teresa Johnson
, no patch: 10m30s -fdump-tree-all, my patch: 1m21s Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-06-26 Teresa Johnson tejohn...@google.com * c-family/c-common.h (get_dump_info): Declare. * c-family/c-gimplify.c (c_genericize): Use saved dump

Re: [PATCH] Add missing -fdump-* options

2014-06-26 Thread Teresa Johnson
On Thu, Jun 26, 2014 at 12:40 AM, Richard Biener richard.guent...@gmail.com wrote: On Wed, Jun 25, 2014 at 4:21 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li davi...@google.com wrote: On Tue, May 13, 2014 at 1:39 AM, Richard Biener

[GOOGLE] LIPO resolved node handling for inline clone references

2014-07-01 Thread Teresa Johnson
clones. Passes regression tests. Ok for google/4_9? Teresa 2014-07-01 Teresa Johnson tejohn...@google.com Google ref b/15411384. * cgraphbuild.c (mark_address): Skip resolved node lookup in inline copies. Index: cgraphbuild.c

[GOOGLE] Define libgcov interface for distinguishing -ftest-coverage from -fprofile-generate

2014-07-02 Thread Teresa Johnson
branches? Thanks, Teresa 2014-07-02 Teresa Johnson tejohn...@google.com Google ref b/15378201. * gcc/tree-profile.c (gcov_test_coverage_decl): Declare. (tree_init_instrumentation): Initialize gcov_test_coverage_decl. * libgcc/libgcov-driver.c (__gcov_dummy_ref7

Re: [GOOGLE] Define libgcov interface for distinguishing -ftest-coverage from -fprofile-generate

2014-07-02 Thread Teresa Johnson
it to this if you think that is clearer. Teresa David On Wed, Jul 2, 2014 at 12:55 PM, Teresa Johnson tejohn...@google.com wrote: The following patch adds support for a new libgcov interface, __gcov_profiling_enabled, that can be used by applications to determine whether a binary has been

Re: [GOOGLE] Define libgcov interface for distinguishing -ftest-coverage from -fprofile-generate

2014-07-02 Thread Teresa Johnson
New patch below. Retested. Ok for google branches? Thanks, Teresa 2014-07-02 Teresa Johnson tejohn...@google.com Google ref b/15378201. * gcc/tree-profile.c (gcov_test_coverage_decl): Declare. (tree_init_instrumentation): Initialize gcov_test_coverage_decl

Re: [PATCH] Handle more COMDAT profiling issues

2014-07-07 Thread Teresa Johnson
probabilities during inlining). Patch is below. Bootstrapped and tested on x86-64-unknown-linux-gnu. Also tested on a profile-use build of SPEC cpu2006. Ok for trunk when stage 1 reopens? Thanks, Teresa 2014-02-12 Teresa Johnson tejohn...@google.com * graphite.c (graphite_finalize): Pass

Re: [PATCH] Redesign jump threading profile updates

2014-07-07 Thread Teresa Johnson
Ping. Jeff, any update on when you can look at this? Thanks, Teresa On Tue, May 27, 2014 at 7:10 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law l...@redhat.com wrote: On 03/26

[GOOGLE] Rewrite FUNCTION_DECL references after LIPO linking

2014-07-15 Thread Teresa Johnson
This patch will rewrite references to function decls in all statements after LIPO linking so that the subsequent cgraph rebuild will set up references correctly. Passes regression and internal testing. Ok for google/4_9? Thanks, Teresa 2014-07-15 Teresa Johnson tejohn...@google.com

[GOOGLE] Use resolved node during AFDO vpt

2014-07-23 Thread Teresa Johnson
AFDO invokes cgraph_node_for_asm during VPT to get the cgraph node for a callee. Use the resolved node so we don't add a reference to the un-resolved node after LIPO fixup. Passes regression tests and internal test. Ok for google/4_9? Thanks, Teresa 2014-07-23 Teresa Johnson tejohn

Re: [PATCH] Redesign jump threading profile updates

2014-07-23 Thread Teresa Johnson
On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law l...@redhat.com wrote: On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases, particularly in the case where the threading path contains a joiner. Some

[PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Teresa Johnson
(elt)) return false; -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Teresa Johnson
, Nov 12, 2014 at 2:13 PM, Teresa Johnson tejohn...@google.com wrote: This patch fixes an issue where tree-strlen was incorrectly removing a store of 0 into a string because it thought a prior CLOBBER (which is an empty constructor with no elements) was zero-initializing the string. Bootstrapped

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Teresa Johnson
On Wed, Nov 12, 2014 at 9:30 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 12, 2014 at 9:25 PM, Teresa Johnson tejohn...@google.com wrote: Added testcase. Here is the new patch: 2014-11-12tejohn...@google.com gcc: PR tree-optimization/63841 * tree.c

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
, 2014 at 9:40 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 12, 2014 at 9:38 PM, Teresa Johnson tejohn...@google.com wrote: On Wed, Nov 12, 2014 at 9:30 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Nov 12, 2014 at 9:25 PM, Teresa Johnson tejohn...@google.com wrote: Added testcase

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 6:32 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, Nov 13, 2014 at 3:32 PM, Richard Biener richard.guent...@gmail.com wrote: On Thu, Nov 13, 2014 at 3:20 PM, Teresa Johnson tejohn...@google.com wrote: Here is the new patch. Bootstrapped and tested

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 6:36 AM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 06:20:16AM -0800, Teresa Johnson wrote: Here is the new patch. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Teresa 2014-11-13tejohn...@google.com gcc

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 06:46:23AM -0800, Teresa Johnson wrote: --- tree.c (revision 217190) +++ tree.c (working copy) @@ -10330,6 +10330,8 @@ initializer_zerop (const_tree init) { unsigned

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 7:39 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: And for release branches I'd really prefer tree-ssa-strlen.c change. Ok, I started testing the initializer_zerop change on the 4_9 branch

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 12:55 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 12:51:05PM -0800, Teresa Johnson wrote: On Thu, Nov 13, 2014 at 7:39 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 1:45 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 01:33:07PM -0800, Teresa Johnson wrote: Supposedly the printfs should have been removed and the #include cstdio isn't needed then either. No need to clutter the test output and log files

Re: [PATCH] Redesign jump threading profile updates

2014-09-29 Thread Teresa Johnson
On Fri, Aug 1, 2014 at 10:10 PM, Teresa Johnson tejohn...@google.com wrote: On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law l...@redhat.com wrote: On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered

Re: [PATCH] Redesign jump threading profile updates

2014-09-30 Thread Teresa Johnson
On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law l...@redhat.com wrote: On 09/29/14 08:19, Teresa Johnson wrote: Just an update - I found some good test cases by compiling the c-torture tests with profile feedback with and without my patch. But in the cases I pulled out I saw that there were still

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-30 Thread Teresa Johnson
On Tue, Sep 30, 2014 at 9:28 PM, Nathan Sidwell nat...@acm.org wrote: On 09/22/14 08:04, Teresa Johnson wrote: The approach we now take for LIPO builds is to propagate the counts LIPO? Sorry, Lightweight IPO (https://gcc.gnu.org/wiki/LightweightIpo), implemented and used on google branches

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
Sorry, yes, will try to reproduce. Teresa On Wed, Oct 1, 2014 at 12:03 AM, Christophe Lyon christophe.l...@linaro.org wrote: On 30 September 2014 20:20, Teresa Johnson tejohn...@google.com wrote: On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law l...@redhat.com wrote: On 09/29/14 08:19, Teresa Johnson

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 6:20 AM, Teresa Johnson tejohn...@google.com wrote: Sorry, yes, will try to reproduce. Teresa On Wed, Oct 1, 2014 at 12:03 AM, Christophe Lyon christophe.l...@linaro.org wrote: On 30 September 2014 20:20, Teresa Johnson tejohn...@google.com wrote: On Mon, Sep 29, 2014

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
it was too large. I suppose Teresa did receive it though. Not sure whether I can attach it in .xz format? Is this allowed? Thanks Christophe. Thanks, Sebastian -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 9:20 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Oct 1, 2014 at 8:29 AM, Teresa Johnson tejohn...@google.com wrote: I got the preprocessed source. With the aarch64 cross-compiler I built I am able to reproduce the ICE. Looking at it now. It may also cause: https

[PATCH] Fix PR63422 to handle profile insanities

2014-10-01 Thread Teresa Johnson
regression tests for x86_64-unknown-linux-gnu. Ok for trunk if that passes? Thanks, Teresa 2014-10-01 Teresa Johnson tejohn...@google.com PR middle-end/63422 * tree-ssa-threadupdate.c (freqs_to_counts_path): Remove asserts to handle incoming insanities. Index: tree-ssa

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
the reported issue. Currently bootstrapping and testing on x86_64-unknown-linux-gnu. Ok for trunk if it passes? (The whitespace is getting messed up when I copy the patch in here - the indentations do line up in the patch.) Thanks, Teresa 2014-10-01 Teresa Johnson tejohn...@google.com * tree

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 3:46 PM, Steve Ellcey sell...@mips.com wrote: On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: 2014-10-01 Teresa Johnson tejohn...@google.com * tree-ssa-threadupdate.c (freqs_to_counts_path): Scale frequencies up when synthesizing counts

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
issue. Currently bootstrapping and testing on x86_64-unknown-linux-gnu. Ok for trunk if it passes? (The whitespace is getting messed up when I copy the patch in here - the indentations do line up in the patch.) Thanks, Teresa 2014-10-01 Teresa Johnson tejohn...@google.com * tree

Re: [PATCH] Redesign jump threading profile updates

2014-10-02 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 10:02 PM, Teresa Johnson tejohn...@google.com wrote: On Wed, Oct 1, 2014 at 3:46 PM, Steve Ellcey sell...@mips.com wrote: On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: 2014-10-01 Teresa Johnson tejohn...@google.com * tree-ssa-threadupdate.c

Re: [PATCH] Redesign jump threading profile updates

2014-10-02 Thread Teresa Johnson
On Thu, Oct 2, 2014 at 8:45 AM, Steve Ellcey sell...@mips.com wrote: On Wed, 2014-10-01 at 22:02 -0700, Teresa Johnson wrote: Will take a look. In case I can't reproduce it with the aarch64 cross-compiler or x86_64, can you give me the preprocessed source? And also the instructions for how

Re: [PATCH] Fix PR63422 to handle profile insanities

2014-10-02 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 10:03 AM, Xinliang David Li davi...@google.com wrote: Probably need to file a bug to track the copyrename2 problem. I have filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63443 to track this. David On Wed, Oct 1, 2014 at 9:59 AM, Teresa Johnson tejohn...@google.com

[GOOGLE] Skip fake LIPO edges when replacing calls with local alias

2014-10-03 Thread Teresa Johnson
Adds handling in this block of code (new in gcc/4_9 and therefore google/4_9) for LIPO fake edges for indirect calls, which don't have a call_stmt set and cannot be redirected. Passes regression tests, ok for google/4_9 branch? Teresa 2014-10-03 Teresa Johnson tejohn...@google.com

Re: [google gcc-4_9] fix undefined references in debug_info

2014-10-03 Thread Teresa Johnson
). We need to output this label because it's a user label and debug_info has a reference to it. Tested with problematic file and regression test. Trunk may also have the same issue, but I need to work on a testcase. Thanks, -Rong -- Teresa Johnson | Software Engineer | tejohn

Re: [GOOGLE] Skip fake LIPO edges when replacing calls with local alias

2014-10-03 Thread Teresa Johnson
Johnson tejohn...@google.com wrote: Adds handling in this block of code (new in gcc/4_9 and therefore google/4_9) for LIPO fake edges for indirect calls, which don't have a call_stmt set and cannot be redirected. Passes regression tests, ok for google/4_9 branch? Teresa 2014-10-03 Teresa

[GOOGLE] Handle missing BINFO for LIPO

2014-10-07 Thread Teresa Johnson
. Passes regression tests. Ok for google branches? Teresa 2014-10-07 Teresa Johnson tejohn...@google.com Google ref b/16511102. * ipa-devirt.c (polymorphic_type_binfo_p): Handle missing BINFO. Index: ipa-devirt.c

[PATCH] Fix PR bootstrap/63432 in jump threading

2014-10-07 Thread Teresa Johnson
. Bootstrapped and tested on x86_64-unknown-linux-gnu. Also did an LTO profiledbootstrap. Ok for trunk? Thanks, Teresa 2014-10-07 Teresa Johnson tejohn...@google.com PR bootstrap/63432. * tree-ssa-threadupdate.c (estimated_freqs_path): New function

[Google] Put time profiling under param, disable by default

2014-10-12 Thread Teresa Johnson
main Passes regression tests. Ok for google/4_9? 2014-10-12 Teresa Johnson tejohn...@google.com Google ref b/17945455. gcc/ * params.def (PARAM_PROFILE_VALUES_TIME): New parameter. * value-prof.c (gimple_find_values_to_profile): Use new param. gcc/testsuite

[PATCH] Better tolerance of incoming profile insanities in jump threading

2014-10-14 Thread Teresa Johnson
and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-10-14 Teresa Johnson tejohn...@google.com PR bootstrap/63432 * tree-ssa-threadupdate.c (recompute_probabilities): Better overflow checking. Index: tree-ssa-threadupdate.c

[GOOGLE] Treat artificial from aux modules as non-external

2014-10-16 Thread Teresa Johnson
, passes regression tests. Ok for google/4_9? Thanks, Teresa 2014-10-16 Teresa Johnson tejohn...@google.com Google ref b/17971995. * l-ipo.c (cgraph_is_aux_decl_external): Artificial functions may not be available in primary module. Index: l-ipo.c

[GOOGLE] Disable -fdevirtualize by default

2014-10-18 Thread Teresa Johnson
Disabling devirtualization reduces code size, both for instrumentation (because many more virtual functions are kept longer and therefore instrumented) and for normal optimization. Patch attached. Passes internal testing and regression tests. Ok for google/4_9? Thanks, Teresa -- Teresa Johnson

[GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Teresa Johnson
. Ok for google/4_9? 2014-10-18 Teresa Johnson tejohn...@google.com Google ref b/17934523 * opts.c (finish_options): Increase max-early-inliner-iterations to 2 for profile-gen and profile-use builds. Index: opts.c

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Teresa Johnson
. Ok for google/4_9? 2014-10-18 Teresa Johnson tejohn...@google.com Google ref b/17934523 * opts.c (finish_options): Increase max-early-inliner-iterations to 2 for profile-gen and profile-use builds. Index: opts.c

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-18 Thread Teresa Johnson
the difference should not be big - perhaps I could make switch for that for mainline) and less accurate profiles when you get speculative devirtualization via topn. I would be very interested to see how much difference this makes. Honza -- Teresa Johnson | Software Engineer

[PATCH] Don't dump bb details when removing a block

2014-04-08 Thread Teresa Johnson
), instead of a block in the optimized code. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for either trunk or stage 1? Thanks, Teresa 2014-04-08 Teresa Johnson tejohn...@google.com * tree-cfg.c (remove_bb): Don't dump details during bb removal. 2014-04-08 Teresa Johnson tejohn

[GOOGLE] Fix incorrect detection of recursive calls during LIPO IPA inlining

2014-04-10 Thread Teresa Johnson
$(LINKER_PLUGIN_API_H) is-a.h \ + l-ipo.h DF_H = df.h $(BITMAP_H) $(REGSET_H) sbitmap.h $(BASIC_BLOCK_H) \ alloc-pool.h $(TIMEVAR_H) VALTRACK_H = valtrack.h $(BITMAP_H) $(DF_H) $(RTL_H) $(BASIC_BLOCK_H) \ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Don't dump bb details when removing a block

2014-04-11 Thread Teresa Johnson
for stage1. Thanks, Richard. Thanks, I have retested with the new patch below and will wait for stage 1 before committing. Teresa 2014-04-11 Teresa Johnson tejohn...@google.com * cfg.c (dump_bb_info): Fix flags check. * tree-cfg.c (remove_bb): Only dump TDF_BLOCKS when

Re: [PATCH] Redesign jump threading profile updates

2014-04-17 Thread Teresa Johnson
On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law l...@redhat.com wrote: On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases, particularly in the case where the threading path contains a joiner. Some

[PATCH] Fix cgraph dumping bug

2014-05-09 Thread Teresa Johnson
Fixed a place where the wrong dump file was being used, leading to an inconsistency and seg fault when dump_file was non-NULL but cgraph_dump_file was NULL. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-05-09 Teresa Johnson tejohn...@google.com

[PATCH] Add missing -fdump-* options

2014-05-09 Thread Teresa Johnson
I discovered that the support for the documented -fdump-* options optimized, missed, note and optall was missing. Added that and fixed a minor typo in the documentation. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-05-09 Teresa Johnson tejohn

[Google/4-8] Support for user-guided feedback-directed library optimization

2014-05-09 Thread Teresa Johnson
regression tests. Ok for google branches? Thanks, Teresa -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 Patch to add support for user-guided feedback-directed library optimization. Contains support for builtins and attributes for specifying user-supplied routines

Re: [Google/4-8] Support for user-guided feedback-directed library optimization

2014-05-09 Thread Teresa Johnson
Thanks for catching that, I will fix it. Teresa On Fri, May 9, 2014 at 7:49 PM, Andi Kleen a...@firstfloor.org wrote: Teresa Johnson tejohn...@google.com writes: Passes regression tests. Ok for google branches? +{ + char parameter[1000]; + sprintf (parameter, %s=%ld

Re: [PATCH] Add missing -fdump-* options

2014-05-13 Thread Teresa Johnson
On Tue, May 13, 2014 at 1:39 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson tejohn...@google.com wrote: I discovered that the support for the documented -fdump-* options optimized, missed, note and optall was missing. Added that and fixed

Re: [Google/4-8] Support for user-guided feedback-directed library optimization

2014-05-14 Thread Teresa Johnson
directed value profiling will also be supported but not in this patch. David On May 10, 2014 2:59 PM, Andi Kleen a...@firstfloor.org wrote: On Fri, May 09, 2014 at 08:11:40PM -0700, Teresa Johnson wrote: Thanks for catching that, I will fix it. BTW I first misunderstood the goal of you patch

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Teresa Johnson
Ping. Teresa On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson tejohn...@google.com wrote: This patch applies profile fixups to COMDATs on the dyn ipa callgraph at the end of LIPO module grouping (either in the profile gen run or in gcov-tool). This is to address issues with missing profiles

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Teresa Johnson
, Teresa Johnson tejohn...@google.com wrote: Ping. Teresa On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson tejohn...@google.com wrote: This patch applies profile fixups to COMDATs on the dyn ipa callgraph at the end of LIPO module grouping (either in the profile gen run or in gcov-tool

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Teresa Johnson
On Tue, May 20, 2014 at 8:39 AM, Xinliang David Li davi...@google.com wrote: On Tue, May 20, 2014 at 6:32 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li davi...@google.com wrote: Why duplicating the merger functions in dyn-ipa.c? Should

Re: [Patch] Avoid gcc_assert in libgcov

2014-05-22 Thread Teresa Johnson
(allocate_filename_struct) and libgcov-merge.c (__gcov_merge_single and __gcov_merge_delta). Should I remove those or change to gcov_error? Teresa -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[Google/4_8] Support for embedding build info into gcda files

2014-05-23 Thread Teresa Johnson
-- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 Support for embedding arbitrary build information from the profile-generate compile into the gcda file in a new BUILD_INFO record. Lines from a file passed to the -fprofile-generate compile via a new -fprofile-generate

Re: [Google/4_8] Support for embedding build info into gcda files

2014-05-23 Thread Teresa Johnson
): struct gcov_info { ... char ** build_info; }; For regular case, it is null, for case where the build info is available, make it point to a string array (with an null end marker string). David On Fri, May 23, 2014 at 11:08 AM, Teresa Johnson tejohn...@google.com wrote: Support

Re: [Google/4_8] Support for embedding build info into gcda files

2014-05-23 Thread Teresa Johnson
is? We are just reading in the file here. Teresa David On Fri, May 23, 2014 at 1:59 PM, Teresa Johnson tejohn...@google.com wrote: Done. Passes manual testing, rerunning regression testing. New patch attached. Thanks, Teresa On Fri, May 23, 2014 at 11:35 AM, Xinliang David Li davi

Re: [PATCH] Redesign jump threading profile updates

2014-05-27 Thread Teresa Johnson
On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law l...@redhat.com wrote: On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases

Re: [PATCH] rebuild frequency after vrp

2014-06-02 Thread Teresa Johnson
of the jump threading frequency updates? It's still in my queue of things to review. Fixing this stuff in the updater would be better than rebuilding the frequencies, IMHO. Jeff -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] rebuild frequency after vrp

2014-06-02 Thread Teresa Johnson
On Mon, Jun 2, 2014 at 11:04 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Jun 2, 2014 at 10:26 AM, Dehao Chen de...@google.com wrote: Just tried with Teresa's patch, the ICE in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61384 is not resolved. I will take a look to see why

[PATCH] Fix ICE due to memory corruption in SRA

2014-06-02 Thread Teresa Johnson
rebuilding. Google ref b/15383777. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-06-02 Teresa Johnson tejohn...@google.com * tree-sra.c (modify_function): Record caller nodes after rebuild. Index: tree-sra.c

[Google/4_8] Fix testsuite/gcc.dg/ipa/ipa-sra-6.c

2014-06-05 Thread Teresa Johnson
matches because it looks like: Adjusting call (0 - 2) foo - foo.isra.0 In google/4_9 and trunk, the additional dump lines don't match because the node's order number is being printed after the name: Adjusting call foo/0 - foo.isra.0/2 2014-06-05 Teresa Johnson tejohn...@google.com

[Google/4_8] Reduce memory overhead of LIPO COMDAT fixups

2014-06-05 Thread Teresa Johnson
tests (see ref below for details). Google ref b/15415042. 2014-06-05 Teresa Johnson tejohn...@google.com * dyn-ipa.c (struct lineno_checksum_alias): Replaced pointer set. (struct checksum_alias_info): Enabled linked list. (cfg_checksum_get_key): Removed

[Google] Fix AFDO early inline ICEs due to DFE

2014-06-12 Thread Teresa Johnson
These two patches fix multiple ICE that occurred due to DFE being recently enabled after AutoFDO LIPO linking. Passes regression and internal testing. Ok for Google/4_8? Teresa 2014-06-12 Teresa Johnson tejohn...@google.com Dehao Chen de...@google.com Google ref b

[PATCH] Fix bug in vect dumping code causing infinite loop

2014-02-03 Thread Teresa Johnson
This patch fixes a bug in the dumping code, whereby an inner loop index variable was the same as the outer loop index variable, and the redef caused an infinite loop. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? 2014-02-03 Teresa Johnson tejohn...@google.com

Re: [google gcc-4_8] gcov-tool: some new LIPO supports.

2014-02-04 Thread Teresa Johnson
occurrence is replaced. -u skips the run-time module grouping computation and reuses the one comes with the profiles (which is user editable). Tested with profiles from google internal benchmarks. Also use strcasestr for case insenstive operation. Done. David -Rong -- Teresa Johnson

Re: [google gcc-4_8] unify int and fp scaling in gcov-tool

2014-02-10 Thread Teresa Johnson
fix a bug in fp scaling of ic and dc counters in earlier code). Tested with spec2006 profiles. OK for checking in? Thanks, -Rong -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [google gcc-4_8][patch] Thunk section names

2014-02-10 Thread Teresa Johnson
out the thunk section from the name alone. With this patch, the thunk's section name is suffixed with the mangled name of the thunk and this solves the problem. Is this patch ok for google/gcc-4_8? Sri -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[PATCH] Handle more COMDAT profiling issues

2014-02-10 Thread Teresa Johnson
the guessed probabilities during inlining). Patch is below. Bootstrapped and tested on x86-64-unknown-linux-gnu. Also tested on a profile-use build of SPEC cpu2006. Ok for trunk when stage 1 reopens? Thanks, Teresa 2014-02-10 Teresa Johnson tejohn...@google.com * graphite.c

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Teresa Johnson
; + cold_section = section; + } + assert (cold_section != NULL cold_section-comdat_group == NULL); + cold_section-is_split_cold_section = 1; + } ... Thanks, Teresa -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2014-02-11 Thread Teresa Johnson
On Thu, Dec 19, 2013 at 10:19 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Dec 12, 2013 at 5:13 PM, Jan Hubicka hubi...@ucw.cz wrote: On Wed, Dec 11, 2013 at 1:21 AM, Martin Liška marxin.li...@gmail.com wrote: Hello, I prepared a collection of systemtap graphs for GIMP. 1

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam tmsri...@google.com wrote: On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson tejohn...@google.com wrote: On Feb 11, 2014 2:37 PM, Sriraman Tallam tmsri...@google.com wrote: On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson tejohn...@google.com

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 4:51 PM, Sriraman Tallam tmsri...@google.com wrote: On Tue, Feb 11, 2014 at 4:39 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam tmsri...@google.com wrote: On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson tejohn

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Teresa Johnson
(counts vs estimated frequencies). Teresa David On Mon, Feb 10, 2014 at 2:12 PM, Teresa Johnson tejohn...@google.com wrote: This patch attempts to address the lost profile issue for COMDATs in more circumstances, exposed by function splitting. My earlier patch handled the case where the comdat

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Teresa Johnson
PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Feb 11, 2014 at 2:56 PM, Xinliang David Li davi...@google.com wrote: Is it better to add some logic in counts_to_freq to determine if the profile count needs to be dropped completely to force profile estimation? This is the problem I

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-12 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 6:13 PM, Xinliang David Li davi...@google.com wrote: On Tue, Feb 11, 2014 at 5:36 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Feb 11, 2014 at 5:16 PM, Xinliang David Li davi...@google.com wrote: Why is call graph needed to determine whether to drop

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-12 Thread Teresa Johnson
On Wed, Feb 12, 2014 at 6:45 AM, Teresa Johnson tejohn...@google.com wrote: On Tue, Feb 11, 2014 at 6:13 PM, Xinliang David Li davi...@google.com wrote: On Tue, Feb 11, 2014 at 5:36 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Feb 11, 2014 at 5:16 PM, Xinliang David Li davi

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2014-02-14 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 2:21 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Dec 19, 2013 at 10:19 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Dec 12, 2013 at 5:13 PM, Jan Hubicka hubi...@ucw.cz wrote: On Wed, Dec 11, 2013 at 1:21 AM, Martin Liška marxin.li...@gmail.com

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-28 Thread Teresa Johnson
-- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [GOOGLE] Remove size check when loop is very hot

2014-02-28 Thread Teresa Johnson
= PARAM_VALUE (PARAM_UNROLLPEEL_HOTNESS_THRESHOLD); /* When the profile count sum to loop entry header ratio is smaller than -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[Google] Add libgcov dummy references for weak symbols

2014-03-10 Thread Teresa Johnson
This patch adds dummy references to libgcov for the symbols accessed via weak references from application code to ensure they are resolved at link time. Passes regression tests. Ok for google-4_8? Thanks, Teresa 2014-03-10 Teresa Johnson tejohn...@google.com Google ref b/13338320. * libgcov

Re: [PATCH] Handle more COMDAT profiling issues

2014-03-21 Thread Teresa Johnson
On Fri, Feb 28, 2014 at 9:13 AM, Teresa Johnson tejohn...@google.com wrote: Here's the new patch. The only changes from the earlier patch are in handle_missing_profiles, where we now get the counts off of the entry and call stmt bbs, and in tree_profiling, where we call handle_missing_profiles

[PATCH] Minor ipa-utils dumping fix

2014-03-21 Thread Teresa Johnson
Minor dumping fix. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for stage 1? Thanks, Teresa 2014-03-21 Teresa Johnson tejohn...@google.com * ipa-utils.c (ipa_print_order): Use specified dump file. Index: ipa-utils.c

[GOOGLE] Fix LIPO resolved node reference fixup

2014-10-24 Thread Teresa Johnson
This patch makes a fix to the reference fixups performed after LIPO node resolution, to better handle the case where we are updating the base address of a reference. Fixes google benchmark and passes regression tests. Ok for google/4_9? Thanks, Teresa 2014-10-24 Teresa Johnson tejohn

Re: [GOOGLE] Fix LIPO resolved node reference fixup

2014-10-24 Thread Teresa Johnson
with the assert. Teresa David On Fri, Oct 24, 2014 at 10:21 AM, Teresa Johnson tejohn...@google.com wrote: This patch makes a fix to the reference fixups performed after LIPO node resolution, to better handle the case where we are updating the base address of a reference. Fixes google benchmark

Re: [GOOGLE] Fix LIPO resolved node reference fixup

2014-10-27 Thread Teresa Johnson
Here is the new patch that walks op looking for the reference to addr. Passes internal benchmarks and regression tests. Ok for google/4_9? Thanks, Teresa 2014-10-27 Teresa Johnson tejohn...@google.com Google ref b/18110567. * cgraphbuild.c (fixup_all_refs_1): New function

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-10-29 Thread Teresa Johnson
middle-end/61529 * tree-ssa-threadupdate.c (compute_path_counts): Bound path_in_freq. -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Teresa Johnson
wrote: On 29/10/14 12:42, Teresa Johnson wrote: Hi Renlin, Are the incoming edge counts or probabilities insane in this case? I guess the patch is ok if we need to do this to handle those incoming insanitiles. But I can't approve patches myself. Not really, it's just a little bigger than

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Teresa Johnson
PR middle-end/61529 * tree-ssa-threadupdate.c (compute_path_counts): Bound path_in_freq. This is needed due to insane incoming frequencies. gcc/testsuite/ChangeLog: 2014-11-06 Renlin Li renlin...@arm.com PR middle-end/61529 * gcc.dg/pr61529.c: New. -- Teresa Johnson

Re: [PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-10 Thread Teresa Johnson
Hi Renlin, Looks like Jeff already approved it: Can you add a testcase please? With a testcase, this patch is OK for the trunk. Teresa On Mon, Nov 10, 2014 at 8:59 AM, Renlin Li renlin...@arm.com wrote: On 06/11/14 18:07, Renlin Li wrote: On 06/11/14 17:59, Teresa Johnson wrote: Thanks

[GOOGLE] Fixup varpool references after LIPO linking

2014-08-28 Thread Teresa Johnson
2014-08-28 Teresa Johnson tejohn...@google.com Google ref b/17038802. * l-ipo.c (resolve_cgraph_node): Pick non-external node. (fixup_reference_list): Fixup varpool references, remove old references, mark cgraph nodes as address taken as needed. Index: l-ipo.c

  1   2   3   4   5   >