Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-09 Thread Teresa Johnson
the heuristic more aggressive? Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-09 Thread Teresa Johnson
! Teresa Honza Thanks, Teresa I think we are really looking primarily for dead parts of the functions (sanity checks/error handling) that should not be visited by train run. We can then see how to make the heuristic more aggressive? Honza -- Teresa Johnson

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-11 Thread Teresa Johnson
, Teresa I think we are really looking primarily for dead parts of the functions (sanity checks/error handling) that should not be visited by train run. We can then see how to make the heuristic more aggressive? Honza -- Teresa Johnson | Software Engineer

[PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-11 Thread Teresa Johnson
. With this patch, a profilebootstrap with -freorder-blocks-and-partition force-enabled also passes. Ok for trunk? Thanks, Teresa 2013-08-11 Teresa Johnson tejohn...@google.com PR rtl-optimizations/57451 * final.c (reemit_insn_block_notes): Prevent lexical blocks from

Re: [PATCH] Convert more passes to new dump framework

2013-08-12 Thread Teresa Johnson
On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson tejohn...@google.com wrote: On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor mjam...@suse.cz wrote: Hi, On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-17 Thread Teresa Johnson
On Fri, Aug 9, 2013 at 2:02 PM, Teresa Johnson tejohn...@google.com wrote: On Fri, Aug 9, 2013 at 8:28 AM, Jan Hubicka hubi...@ucw.cz wrote: Do we sanity check that the cold partition does not contain any blocks of count 0? It may be that the profile is broken enough to make partitioning

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-19 Thread Teresa Johnson
Teresa patch for updating counts based on estimated frequencies to address inlined comdats with 0 profile counts: 013-08-16 Teresa Johnson tejohn...@google.com * tree-inline.c (copy_bb): Compute count based on frequency. (copy_edges_for_bb): Ditto

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-19 Thread Teresa Johnson
On Sat, Aug 17, 2013 at 1:44 PM, Jan Hubicka hubi...@ucw.cz wrote: patch for updating counts based on estimated frequencies to address inlined comdats with 0 profile counts: 013-08-16 Teresa Johnson tejohn...@google.com * tree-inline.c (copy_bb): Compute count based on frequency

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-19 Thread Teresa Johnson
be interesting to get similar script taking traces from valgrind and ploting the most frequent calls in the final layout ;) I think linux perf -g to get a callgraph should give similar data. Teresa Honza 2013-08-05 Teresa Johnson tejohn...@google.com Steven Bosscher ste

Re: [PATCH] Convert more passes to new dump framework

2013-08-19 Thread Teresa Johnson
Ping. Thanks, Teresa On Mon, Aug 12, 2013 at 6:54 AM, Teresa Johnson tejohn...@google.com wrote: On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson tejohn...@google.com wrote: On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor

Re: [PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-19 Thread Teresa Johnson
Ping. Thanks, Teresa On Sun, Aug 11, 2013 at 9:35 PM, Teresa Johnson tejohn...@google.com wrote: This patch fixes PR rtl-optimizations/57451 by preventing scopes and therefore lexical blocks from crossing split section boundaries. This will prevent debug info generation from using DW_AT_low_pc

Re: [PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-19 Thread Teresa Johnson
On Mon, Aug 19, 2013 at 11:44 AM, Jeff Law l...@redhat.com wrote: On 08/19/2013 12:34 PM, Teresa Johnson wrote: Ping. Thanks, Teresa On Sun, Aug 11, 2013 at 9:35 PM, Teresa Johnson tejohn...@google.com wrote: This patch fixes PR rtl-optimizations/57451 by preventing scopes and therefore

Re: [PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-19 Thread Teresa Johnson
On Mon, Aug 19, 2013 at 5:01 PM, Teresa Johnson tejohn...@google.com wrote: On Mon, Aug 19, 2013 at 11:44 AM, Jeff Law l...@redhat.com wrote: On 08/19/2013 12:34 PM, Teresa Johnson wrote: Ping. Thanks, Teresa On Sun, Aug 11, 2013 at 9:35 PM, Teresa Johnson tejohn...@google.com wrote

Re: [Google] Refine hot caller heuristic

2013-08-21 Thread Teresa Johnson
is enabled. This performs well on internal benchmarks. Ok for google/4_8 branch if all tests pass? - Easwaran -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-23 Thread Teresa Johnson
Kojima kkoj...@rr.iij4u.or.jp wrote: Steve Ellcey sell...@mips.com wrote: On Mon, 2013-08-19 at 22:21 -0700, Teresa Johnson wrote: 2013-08-19 Teresa Johnson tejohn...@google.com PR rtl-optimizations/57451 * final.c (reemit_insn_block_notes): Prevent lexical blocks from

Fixed PR rtl-optimization/58220 and PR regression/58221

2013-08-23 Thread Teresa Johnson
macro Teresa -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-23 Thread Teresa Johnson
On Fri, Aug 23, 2013 at 6:34 AM, Teresa Johnson tejohn...@google.com wrote: Hi Steve and Kaz, Sorry about that. Kaz has a fix shown in rtl-optimization/58220: --- ORIG/trunk/gcc/final.c 2013-08-22 09:43:35.0 +0900 +++ trunk/gcc/final.c 2013-08-22 14:36:51.0 +0900 @@ -1650,7

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-12-10 Thread Teresa Johnson
and clenaups first, with interface changes next and the gcov-tool is probably quite obvious at the end? Do you think you can split the patch this way? Thanks and sorry for taking long to review. I should have more time again now. Honza -- Teresa Johnson | Software Engineer | tejohn

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2013-12-11 Thread Teresa Johnson
Martin On 2 December 2013 17:52, Martin Liška marxin.li...@gmail.com wrote: Dear Teresa, I will today double check if the graphs are correct :) Martin On 2 December 2013 17:16, Jeff Law l...@redhat.com wrote: On 12/02/13 08:16, Teresa Johnson wrote: I'm wondering if the -fno-reorder

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-12-11 Thread Teresa Johnson
concerns. Bootstrapped and tested on x86-64-unknown-linux-gnu. A profiledbootstrap is in progress. Ok for trunk if profiledbootstrap passes? Thanks, Teresa -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 2013-12-11 Rong Xu x...@google.com * gcc/gcov-io.c

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-12-12 Thread Teresa Johnson
On Wed, Dec 11, 2013 at 10:05 PM, Teresa Johnson tejohn...@google.com wrote: On Fri, Dec 6, 2013 at 6:23 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, all This is the new patch for gcov-tool (previously profile-tool). Honza: can you comment on the new merge interface? David posted some comments

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-12-16 Thread Teresa Johnson
that are only defined under #ifdef IN_LIBGCOV and only used in libgcov*c (or each other): gcov_write_counter gcov_write_tag_length gcov_write_summary gcov_seek Should they all, plus gcov_rewrite, be moved to libgcov-driver.c? Teresa David On Thu, Dec 12, 2013 at 12:11 PM, Teresa Johnson tejohn

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2013-12-17 Thread Teresa Johnson
-noise improvement in crafty 2200-2300 and regression on Vortex, 2900-2800, plus code size increase. Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-12-17 Thread Teresa Johnson
things like gcov_seek and friends probably should be separated, but what is reason for splitting the file handling itself? Honza thanks, David On Mon, Dec 16, 2013 at 1:17 PM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 12:55 PM, Xinliang David Li davi

[Patch] Fix PR 59527 (assert in cfg fixup with function splitting)

2013-12-17 Thread Teresa Johnson
pro_and_epilogue. The fallthru was an empty block that appears to be due to switch expansion with the case having a __builtin_unreachable(). Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? 2013-12-17 Teresa Johnson tejohn...@google.com PR gcov-profile/59527 * cfgrtl.c

[Patch] Fix PR 59542: flow verification after compgotos

2013-12-19 Thread Teresa Johnson
Computed goto duplication needs to fixup partition boundaries if it performed any block duplication. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? 2013-12-19 Teresa Johnson tejohn...@google.com PR gcov-profile/59542 * bb-reorder.c (duplicate_computed_gotos

Re: [Patch] Fix PR 59542: flow verification after compgotos

2013-12-19 Thread Teresa Johnson
On Thu, Dec 19, 2013 at 2:06 PM, Steven Bosscher stevenb@gmail.com wrote: On Thu, Dec 19, 2013 at 8:33 PM, Teresa Johnson wrote: 2013-12-19 Teresa Johnson PR gcov-profile/59542 * bb-reorder.c (duplicate_computed_gotos): Invoke fixup_partitions if we have made

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2013-12-19 Thread Teresa Johnson
, and then follow the same procedure we were doing in the 0-count case (propagate the call count into the callee bb counts via the guessed probabilities). Is there a better solution? Thanks, Teresa Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[Patch] libgcov.c re-factoring

2013-12-20 Thread Teresa Johnson
On Tue, Dec 17, 2013 at 7:48 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Ok -- gcov_write_counter and gcov_write_tag_length are qualified as low level primitives for basic gcov format and probably should be kept

Re: [Patch] libgcov.c re-factoring

2014-01-03 Thread Teresa Johnson
On Sun, Dec 22, 2013 at 10:27 AM, Jan Hubicka hubi...@ucw.cz wrote: On Tue, Dec 17, 2013 at 7:48 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Dec 16, 2013 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Ok -- gcov_write_counter and gcov_write_tag_length are qualified

Re: [Patch] libgcov.c re-factoring

2014-01-03 Thread Teresa Johnson
On Fri, Jan 3, 2014 at 2:49 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Fri, 3 Jan 2014, Teresa Johnson wrote: Index: libgcc/libgcov.h === --- libgcc/libgcov.h(revision 0) +++ libgcc/libgcov.h(revision 0

Re: [Patch, bfin/c6x] Fix ICE for backends that rely on reorder_loops.

2014-01-05 Thread Teresa Johnson
Bernd -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [Patch] libgcov.c re-factoring

2014-01-06 Thread Teresa Johnson
gcc_assert already in gcov-io.c (these were the only 2 in gcov-io.h, now moved here). Should I go ahead and change all of them in gcov-io.c? Thanks, Teresa Thanks, Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [Patch] libgcov.c re-factoring

2014-01-08 Thread Teresa Johnson
On Mon, Jan 6, 2014 at 9:49 AM, Teresa Johnson tejohn...@google.com wrote: On Sun, Jan 5, 2014 at 12:08 PM, Jan Hubicka hubi...@ucw.cz wrote: 2014-01-03 Rong Xu x...@google.com * gcc/gcov-io.c (gcov_var): Move from gcov-io.h. (gcov_position): Ditto. (gcov_is_error

Re: [Patch] libgcov.c re-factoring

2014-01-08 Thread Teresa Johnson
within gcc/coverage tools and into nothing for libgcov runtime and we can change those offenders to that. Ok, committed as r206435. Will send the assert patch in a follow-up later this week. Teresa Honza Teresa Thanks, Teresa Thanks, Honza -- Teresa Johnson

Re: [Patch, bfin/c6x] Fix ICE for backends that rely on reorder_loops.

2014-01-08 Thread Teresa Johnson
On Tue, Jan 7, 2014 at 8:07 AM, Bernd Schmidt ber...@codesourcery.com wrote: On 01/05/2014 05:10 PM, Teresa Johnson wrote: On Sun, Jan 5, 2014 at 3:39 AM, Bernd Schmidt ber...@codesourcery.com wrote: I have a different patch which I'll submit next week after some more testing. The assert

[Patch] Avoid gcc_assert in libgcov

2014-01-09 Thread Teresa Johnson
As suggested by Honza, avoid bloating libgcov from gcc_assert by using a new macro gcov_nonruntime_assert in gcov-io.c that is only mapped to gcc_assert when not in libgcov. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-01-09 Teresa Johnson tejohn

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-14 Thread Teresa Johnson
. Ok for trunk? Thanks, Teresa 2014-01-09 Teresa Johnson tejohn...@google.com * gcov-io.c (gcov_position): Use gcov_nonruntime_assert. (gcov_is_error): Ditto. (gcov_rewrite): Ditto. (gcov_open): Ditto. (gcov_write_words): Ditto

[PATCH] Fix segfault in FRE during SCC value numbering

2014-01-15 Thread Teresa Johnson
a null result_vdef. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? 2014-01-15 Teresa Johnson tejohn...@google.com * tree-ssa-sccvn.c (visit_reference_op_call): Handle NULL vdef. Index: tree-ssa-sccvn.c

[GOOGLE] Handle integer overflow in unroller code size limit computation

2014-01-15 Thread Teresa Johnson
Regression tested, ok for google/4_8? Thanks, Teresa 2014-01-15 Teresa Johnson tejohn...@google.com * loop-unroll.c (code_size_limit_factor): Handle int overflow. Index: loop-unroll.c === --- loop-unroll.c

Re: [PATCH] Fix segfault in FRE during SCC value numbering

2014-01-15 Thread Teresa Johnson
On Wed, Jan 15, 2014 at 10:46 AM, Jeff Law l...@redhat.com wrote: On 01/15/14 10:07, Teresa Johnson wrote: Handle NULL vdef for call in the case where we have a matching vnresult that has a vdef (it already handles the NULL vdef case when !vnresult). This can happen for promoted indirect

Re: [PATCH] Fix segfault in FRE during SCC value numbering

2014-01-15 Thread Teresa Johnson
On Wed, Jan 15, 2014 at 12:00 PM, Teresa Johnson tejohn...@google.com wrote: On Wed, Jan 15, 2014 at 10:46 AM, Jeff Law l...@redhat.com wrote: On 01/15/14 10:07, Teresa Johnson wrote: Handle NULL vdef for call in the case where we have a matching vnresult that has a vdef (it already handles

Re: [PATCH] Fix segfault in FRE during SCC value numbering

2014-01-15 Thread Teresa Johnson
: There are options you can use to control passes explicitly: -fdisable-... -fenable- To disable early inline: -fdisable-tree-einline David On Wed, Jan 15, 2014 at 1:17 PM, Teresa Johnson tejohn...@google.com wrote: On Wed, Jan 15, 2014 at 12:00 PM, Teresa Johnson tejohn...@google.com wrote

[PATCH][google] Fix parallel make issue exposed by recent gcda change (issue7426043)

2013-02-27 Thread Teresa Johnson
tests and internal test. Ok for google branches? 2013-02-27 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (gcov_dump_module_info): Seek to zero word using new end of file relative seek. (gcov_merge_gcda_file): Make eof_pos local. (gcov_write_gcda_file): Pass

[PATCH][google] Fix parallel make issue exposed by recent gcda change (issue7426043)

2013-02-27 Thread Teresa Johnson
Patch updated based on comments. Added new gcov_seek_from_end method. Passes regression tests and internal benchmark test. Ok for google branches? Thanks, Teresa 2013-02-27 Teresa Johnson tejohn...@google.com * gcc/coverage.c (build_info_type): Remove eof_pos from gcov_info

Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)

2013-03-27 Thread Teresa Johnson
Ping. Thanks, Teresa On Fri, Dec 14, 2012 at 6:11 PM, Teresa Johnson tejohn...@google.com wrote: This patch enables the gcov-dump tool to optionally compute and dump the working set information from the counter histogram, via a new -w option. This is useful to help understand and tune how

Re: Compute precise counter histogram at LTO

2013-03-29 Thread Teresa Johnson
, LTO_section_opts, LTO_section_cgraph_opt_sum, -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[google] Add option to emit mapping between module/function id and function name (issue8211043)

2013-03-31 Thread Teresa Johnson
? 2013-03-30 Teresa Johnson tejohn...@google.com * tree-profile.c (tree_profiling): Optionally call new function emit_function_name. * common.opt (flag_emit_function_names): New flag. * coverage.c (emit_function_name): New function. * coverage.h: Ditto. Index

[PATCH] Avoid warning when unused attribute applied to C++ member variables (issue8212043)

2013-03-31 Thread Teresa Johnson
++ member variables. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? 2013-03-30 Teresa Johnson tejohn...@google.com * c-family/c-common.c (handle_unused_attribute): Handle FIELD_DECL for C++ class members. Index: c-family/c-common.c

Re: [PATCH] Avoid warning when unused attribute applied to C++ member variables (issue8212043)

2013-03-31 Thread Teresa Johnson
On Sun, Mar 31, 2013 at 1:36 AM, Andrew Pinski pins...@gmail.com wrote: On Sun, Mar 31, 2013 at 12:10 AM, Teresa Johnson tejohn...@google.com wrote: This patch allows the unused attribute to be used without warning on C++ class members, which are of type FIELD_DECL. This is for compatibility

Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)

2013-04-03 Thread Teresa Johnson
On Wed, Apr 3, 2013 at 10:52 AM, Jan Hubicka hubi...@ucw.cz wrote: 2012-12-14 Teresa Johnson tejohn...@google.com * lto-cgraph.c (input_symtab): Replace call to compute_working_sets to get_working_sets. * gcov-io.c (compute_working_sets): Moved most of body

Re: Compute precise counter histogram at LTO

2013-04-04 Thread Teresa Johnson
On Mon, Apr 1, 2013 at 2:27 PM, Rong Xu x...@google.com wrote: On Fri, Mar 29, 2013 at 1:06 PM, Teresa Johnson tejohn...@google.com wrote: On Fri, Mar 29, 2013 at 11:16 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, currently we use Theresa's code to determine hot/cold decisions based

Re: [patch] Fix node weight updates during ipa-cp (issue7812053)

2013-04-05 Thread Teresa Johnson
On Thu, Mar 28, 2013 at 2:27 AM, Richard Biener richard.guent...@gmail.com wrote: On Wed, Mar 27, 2013 at 6:22 PM, Teresa Johnson tejohn...@google.com wrote: I found that the node weight updates on cloned nodes during ipa-cp were leading to incorrect/insane weights. Both the original and new

Re: [PATCH] Avoid warning when unused attribute applied to C++ member variables (issue8212043)

2013-04-08 Thread Teresa Johnson
Ping. Thanks, Teresa On Sun, Mar 31, 2013 at 9:39 AM, Teresa Johnson tejohn...@google.com wrote: On Sun, Mar 31, 2013 at 1:36 AM, Andrew Pinski pins...@gmail.com wrote: On Sun, Mar 31, 2013 at 12:10 AM, Teresa Johnson tejohn...@google.com wrote: This patch allows the unused attribute

[google] Avoid warning when unused attribute applied to C++ member variables (issue8580044)

2013-04-09 Thread Teresa Johnson
in these cases. The documentation at http://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html also doesn't seem to preclude its use on C++ member variables. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for google branches? 2013-04-09 Teresa Johnson tejohn...@google.com * c

[google] Add libgcov interface for accessing profile directory (issue8726046)

2013-04-17 Thread Teresa Johnson
Patch to add interface for querying the profile directory prefix specified to the -fprofile-generate= option. Google ref b/8629045. Tested with regression tests and internal test. Ok for google branches? 2013-04-17 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c

Re: [GOOGLE] Workaround a bug in AutoFDO which may leads to infinite loop for inlined assembly

2013-04-21 Thread Teresa Johnson
= BLOCK_SOURCE_LOCATION (block); Do you want to move up the assignment to loc and use loc in the new if statement? pos_stack[idx].file = expand_location (loc).file; pos_stack[idx].line = expand_location (loc).line; -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [GOOGLE] Workaround a bug in AutoFDO which may leads to infinite loop for inlined assembly

2013-04-21 Thread Teresa Johnson
); pos_stack[idx].file = expand_location (loc).file; pos_stack[idx].line = expand_location (loc).line; pos_stack[idx - 1].func = On Sun, Apr 21, 2013 at 5:00 PM, Teresa Johnson tejohn...@google.com wrote: On Sun, Apr 21, 2013 at 4:51 PM, Dehao Chen de...@google.com wrote

Re: [patch] Fix node weight updates during ipa-cp (issue7812053)

2013-04-22 Thread Teresa Johnson
. So far I haven't seen any performance effects, so I am hoping to send this for review today or tomorrow. Thanks, Teresa On Mon, Apr 22, 2013 at 10:27 AM, Jan Hubicka hubi...@ucw.cz wrote: On Wed, Mar 27, 2013 at 6:22 PM, Teresa Johnson tejohn...@google.com wrote: I found that the node weight

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-04-24 Thread Teresa Johnson
of patch). Teresa Jakub -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: Compute precise counter histogram at LTO

2013-04-24 Thread Teresa Johnson
eliminate the precision errors. Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [google][4_7] Function reordering plugin enhancements

2013-04-24 Thread Teresa Johnson
, Teresa Thanks Sri -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Redesign jump threading profile updates

2014-08-01 Thread Teresa Johnson
On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law l...@redhat.com wrote: On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases

Re: [GOOGLE] Do not partition the cold/hot sections of a function with section attribute

2014-08-11 Thread Teresa Johnson
. */ optimize_function_for_speed_p (cfun) !DECL_ONE_ONLY (current_function_decl) + !DECL_SECTION_NAME (current_function_decl) !user_defined_section_attribute); } -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [GOOGLE] Do not partition the cold/hot sections of a function with section attribute

2014-08-11 Thread Teresa Johnson
removing user_defined_section_attribute and simply check !DECL_SECTION_NAME (current_function_decl). On Mon, Aug 11, 2014 at 8:00 AM, Teresa Johnson tejohn...@google.com wrote: On Fri, Aug 8, 2014 at 3:22 PM, Yi Yang ahyan...@google.com wrote: Friendly ping. Sorry, was OOO. The solution

Re: [GOOGLE] Do not partition the cold/hot sections of a function with section attribute

2014-08-12 Thread Teresa Johnson
On Mon, Aug 11, 2014 at 1:44 PM, Yi Yang ahyan...@google.com wrote: I ported this to trunk. Shall I commit this patch to the Google 4_8/4_9 branches first? Ok with me. Teresa On Mon, Aug 11, 2014 at 12:46 PM, Teresa Johnson tejohn...@google.com wrote: Ok, thanks. This seems reasonable. Can

Re: [GOOGLE] Fix the bug where implicit section names prevents function splitting

2014-08-14 Thread Teresa Johnson
(NODE)) Teresa + struct GTY(()) tree_decl_with_vis { struct tree_decl_with_rtl common; tree assembler_name; -- -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[Google/4_9] A couple gcov-tool fixes

2014-08-14 Thread Teresa Johnson
, Teresa 2014-08-14 Teresa Johnson tejohn...@google.com * libgcov-merge.c (__gcov_merge_dc): Use gcov_get_counter, Relax the check after COMDAT fixup. (__gcov_merge_icall_topn): Use gcov_get_counter. Index: libgcov-merge.c

Re: [Google/4_9] A couple gcov-tool fixes

2014-08-14 Thread Teresa Johnson
in libgcov.h and accesses should be through the new gcov_get_counter interface, but these just got missed when it was ported from trunk. Teresa David On Thu, Aug 14, 2014 at 11:27 AM, Teresa Johnson tejohn...@google.com wrote: Fix a couple problems found during testing. Backport from trunk

Re: [GOOGLE] Fix the bug where implicit section names prevents function splitting

2014-08-14 Thread Teresa Johnson
at 11:25 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Aug 13, 2014 at 9:03 PM, Yi Yang ahyan...@google.com wrote: This bug is caused by my last patch, which did not differentiate between explicit section names (via attributes) and implicit section names (via -ffunction-section

[GOOGLE] Fix AutoFDO LIPO ICE due to eliminated abstract origin

2014-08-23 Thread Teresa Johnson
to that in symtab_remove_unreachable_nodes. Tested with regression tests and internal benchmarks. Ok for google/4_9 2014-08-23 Teresa Johnson tejohn...@google.com Google ref b/16731481 * cgraphunit.c (analyze_functions): Don't remove origin node. Index: cgraphunit.c

[GOOGLE] Fix -fopt-info seg fault in AutoFDO LIPO mode

2014-08-23 Thread Teresa Johnson
Fixes seg fault when using -fopt-info with AutoFDO LIPO. Ensure that the mapping between module name and ident is setup. Tested with regression tests and internal benchmarks. Ok for google/4_9 2014-08-23 Teresa Johnson tejohn...@google.com Google ref b/17124135 * auto

Re: [GOOGLE] Fix AutoFDO LIPO ICE due to eliminated abstract origin

2014-08-23 Thread Teresa Johnson
the first does not cause any problems. Teresa On Sat, Aug 23, 2014 at 11:50 AM, Xinliang David Li davi...@google.com wrote: Is it a problem specific to LIPO? David On Sat, Aug 23, 2014 at 11:41 AM, Teresa Johnson tejohn...@google.com wrote: This patch ensures we don't prematurely delete

[GOOGLE] Make LIPO aux function removal consistent

2014-12-19 Thread Teresa Johnson
Passes regression tests, ok for google 4_9? Thanks, Teresa 2014-12-19 Teresa Johnson tejohn...@google.com Google ref b/18800499 * cgraph.c (cgraph_can_remove_if_no_direct_calls_and_refs_p): Make consistent with mark_functions_for_output for LIPO aux functions. Index

Re: [GOOGLE] Make LIPO aux function removal consistent

2014-12-22 Thread Teresa Johnson
Ping. Teresa On Fri, Dec 19, 2014 at 5:40 PM, Teresa Johnson tejohn...@google.com wrote: Passes regression tests, ok for google 4_9? Thanks, Teresa 2014-12-19 Teresa Johnson tejohn...@google.com Google ref b/18800499 * cgraph.c

[GOOGLE] Refine LIPO aux function removal

2015-01-02 Thread Teresa Johnson
? Thanks, Teresa 2015-01-02 Teresa Johnson tejohn...@google.com Google ref b/18882262. * cgraph.c (cgraph_can_remove_if_no_direct_calls_and_refs_p): Keep aux functions until after LIPO linking. Index: cgraph.c

Re: [GOOGLE] Fixes for TLS wrapper and init functions in LIPO mode

2015-03-19 Thread Teresa Johnson
New patch below. Passes regression tests plus internal application build. 2015-03-19 Teresa Johnson tejohn...@google.com gcc/ Google ref b/19618364. * cp/decl2.c (get_local_tls_init_fn): Assert on aux module. (get_tls_init_fn): Promote non-public init functions

Re: [GOOGLE] Fixes for TLS wrapper and init functions in LIPO mode

2015-03-19 Thread Teresa Johnson
module). Teresa David On Thu, Mar 19, 2015 at 4:11 PM, Teresa Johnson tejohn...@google.com wrote: New patch below. Passes regression tests plus internal application build. 2015-03-19 Teresa Johnson tejohn...@google.com gcc/ Google ref b/19618364. * cp/decl2.c

Re: [GOOGLE] Fixes for TLS wrapper and init functions in LIPO mode

2015-03-19 Thread Teresa Johnson
they are not marked static, so that would also need to be done to get them promoted. Teresa David On Thu, Mar 19, 2015 at 5:51 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Mar 19, 2015 at 4:45 PM, Xinliang David Li davi...@google.com wrote: does generate_tls_wrapper also need

Re: [GOOGLE] Fixes for TLS wrapper and init functions in LIPO mode

2015-03-20 Thread Teresa Johnson
On Thu, Mar 19, 2015 at 10:38 PM, Xinliang David Li davi...@google.com wrote: On Thu, Mar 19, 2015 at 9:57 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Mar 19, 2015 at 8:00 PM, Xinliang David Li davi...@google.com wrote: ok -- then there is an over assertion in get_local_tls_init_fn

Re: [GOOGLE] Fixes for TLS wrapper and init functions in LIPO mode

2015-03-19 Thread Teresa Johnson
the original test case (forgot to include in first patch) and the new one with the fixed patch. Teresa David On Wed, Mar 18, 2015 at 9:18 PM, Teresa Johnson tejohn...@google.com wrote: Ensure TLS variable wrapper and init functions are recorded at the module scope upon creation so

Re: [GOOGLE] Fixes for TLS wrapper and init functions in LIPO mode

2015-03-20 Thread Teresa Johnson
the tests to validate rather than print the expected output. Ok for google branches? 2015-03-20 Teresa Johnson tejohn...@google.com gcc/ Google ref b/19618364. * cp/decl2.c (get_local_tls_init_fn): Mark static, record new global at module scope

[GOOGLE] Reset lambda scope information when popping module for LIPO

2015-08-15 Thread Teresa Johnson
now (and has for awhile) encompasses more than just deferred function clearing. Passes regression tests. Ok for google 4_9? 2015-08-14 Teresa Johnson tejohn...@google.com Google ref b/23176787. * cp/cp-lang.c: Rename clear_deferred_fns to reset_parsing_state. * cp/cp

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-26 Thread Teresa Johnson
og: > > 2015-10-26 Renlin Li <renlin...@arm.com> > > * lib/target-supports.exp (check_effective_target_freorder): Add > -fprofile-use flag. -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[GOOGLE] Reduce max-vartrack-size

2015-10-13 Thread Teresa Johnson
Reduce the maximum variable tracking size by 20% to avoid extreme compilation times. Ok for google-4_9? 2015-10-13 Teresa Johnson <tejohn...@google.com> Google ref b/24569916 * params.def (PARAM_MAX_VARTRACK_SIZE): Reduce default to 40M. Index: para

Re: [GOOGLE] Only save command-line options for LIPO

2015-07-08 Thread Teresa Johnson
Resending in plain text mode. On Wed, Jul 8, 2015 at 11:34 AM, Teresa Johnson tejohn...@google.com wrote: This patch avoids saving optimization pragma or function level attributes in the list of command line options saved in the LIPO module info structure. Passes regression and internal

[PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-24 Thread Teresa Johnson
, however, causes the assembly code generator to create (empty) cold sections and labels, leading to unnecessary size overhead. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2015-09-24 Teresa Johnson <tejohn...@google.com> * opts.c (finish_options):

Re: [PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-25 Thread Teresa Johnson
ntry that Bernd pointed out. Thanks, Teresa > > Honza >> heuristics are used to distinguish cold bbs in >> probably_never_executed_bb_p, I don't think it makes sense to do >> anything finer grained that just disabling the option. >> >> Teresa >> >>

[GOOGLE] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-25 Thread Teresa Johnson
-25 Teresa Johnson <tejohn...@google.com> Google ref b/24265250 * opts.c (finish_options): Unset -freorder-blocks-and-partition if not using profile. (set_profile_use_options): Unset -freorder-blocks-and-partition if input profile not found and it

Re: [PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-25 Thread Teresa Johnson
Woops, we crossed wires. I just committed this patch. Would you like me to revert it? Teresa On Fri, Sep 25, 2015 at 9:57 AM, Andi Kleen <a...@firstfloor.org> wrote: > Teresa Johnson <tejohn...@google.com> writes: > >> This patch unsets -freorder-blocks-and-part

Re: [PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead

2015-09-25 Thread Teresa Johnson
On Fri, Sep 25, 2015 at 6:58 AM, Bernd Schmidt <bschm...@redhat.com> wrote: > On 09/24/2015 07:16 PM, Teresa Johnson wrote: >> >> This patch unsets -freorder-blocks-and-partition when -fprofile-use >> is not specified. Function splitting was not actually bein

[GOOGLE] Remove overly-aggressive LIPO assert

2015-12-02 Thread Teresa Johnson
regression tests. Ok for Google branch? 2015-12-02 Teresa Johnson <tejohn...@google.com> Google ref b/25925223. * l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict assert. Index: l-ipo.c === --- l-ipo.c (re

Re: [GOOGLE] Remove overly-aggressive LIPO assert

2015-12-04 Thread Teresa Johnson
Ping. Thanks, Teresa On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson <tejohn...@google.com> wrote: > Remove an assert that was overly-strict and already partially redundant > with an immediately prior assert. In this case we had a hidden visibility > function clone that was created

<    1   2   3   4   5