Re: [PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-03-30 Thread Tom de Vries
OK for stage1 if bootstrap and reg-test on x86_64 are ok? Thanks, - Tom Fix edge probabilities in gimple_duplicate_sese_tail 2015-03-27 Tom de Vries PR tree-optimization/65511 * tree-cfg.c (gimple_duplicate_sese_tail): Fix edge probabilities and counts. * gcc.dg/parloops-prob.c: New t

[PATCH][ada][PR65490] Fix bzero warning in child_setup_tty

2015-03-30 Thread Tom de Vries
, - Tom Fix bzero warning in child_setup_tty 2015-03-30 Tom de Vries PR ada/65490 * terminals.c (child_setup_tty): Fix warning 'argument to sizeof in bzero call is the same expression as the destination'. --- gcc/ada/terminals.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [PATCH, stage1][PR65443] Add transform_to_exit_first_loop_alt

2015-04-03 Thread Tom de Vries
On 27-03-15 15:10, Tom de Vries wrote: Hi, this patch fixes PR65443, a todo in the parloops pass for function transform_to_exit_first_loop: ... TODO: the common case is that latch of the loop is empty and immediately follows the loop exit. In this case, it would be better not to copy

[PR65637] Fix ssa-handling code in expand_omp_for_static_chunk

2015-04-15 Thread Tom de Vries
Hi, This patch series fixes PR65637. Currently, ssa-handling code in expand_omp_for_static_chunk is dead and not exercised by testing. Ssa-handling code in omp-low.c is only triggered by pass_parallelize_loops, and that pass doesn't specify a chunk size on the GIMPLE_OMP_FOR it constructs, s

[PR65637][PATCH][1/3] Fix gcc_assert in expand_omp_for_static_chunk

2015-04-15 Thread Tom de Vries
On 15-04-15 15:10, Tom de Vries wrote: Hi, This patch series fixes PR65637. Currently, ssa-handling code in expand_omp_for_static_chunk is dead and not exercised by testing. Ssa-handling code in omp-low.c is only triggered by pass_parallelize_loops, and that pass doesn't specify a chunk

[PR65637][PATCH][2/3] Fix inner loop phi in expand_omp_for_static_chunk

2015-04-15 Thread Tom de Vries
On 15-04-15 15:10, Tom de Vries wrote: Hi, This patch series fixes PR65637. Currently, ssa-handling code in expand_omp_for_static_chunk is dead and not exercised by testing. Ssa-handling code in omp-low.c is only triggered by pass_parallelize_loops, and that pass doesn't specify a chunk

[PR65637][PATCH][3/3] Handle 2 preds for fin_bb in expand_omp_for_static_chunk

2015-04-15 Thread Tom de Vries
On 15-04-15 15:10, Tom de Vries wrote: Hi, This patch series fixes PR65637. Currently, ssa-handling code in expand_omp_for_static_chunk is dead and not exercised by testing. Ssa-handling code in omp-low.c is only triggered by pass_parallelize_loops, and that pass doesn't specify a chunk

[PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-04-15 Thread Tom de Vries
On 03-04-15 14:39, Tom de Vries wrote: On 27-03-15 15:10, Tom de Vries wrote: Hi, this patch fixes PR65443, a todo in the parloops pass for function transform_to_exit_first_loop: ... TODO: the common case is that latch of the loop is empty and immediately follows the loop exit. In

[PING^2] [PATCH][5a/5] Postpone expanding va_arg until pass_stdarg

2015-04-16 Thread Tom de Vries
[stage1 ping^2] On 10-03-15 16:30, Tom de Vries wrote: [stage1 ping] On 22-02-15 14:13, Tom de Vries wrote: On 19-02-15 14:03, Richard Biener wrote: On Thu, 19 Feb 2015, Tom de Vries wrote: On 19-02-15 11:29, Tom de Vries wrote: Hi, I'm posting this patch series for stage1: - 0001-Di

[PING^2] [PATCH][5b/5] Avoid running expand_ifn_va_arg_1 in functions without va_arg

2015-04-16 Thread Tom de Vries
[stage1 ping^2] On 10-03-15 16:31, Tom de Vries wrote: [stage1 ping] [was: Postpone expanding va_arg until pass_stdarg] On 24-02-15 07:48, Tom de Vries wrote: On 23-02-15 11:09, Tom de Vries wrote: On 23-02-15 09:26, Michael Matz wrote: Hi, On Sun, 22 Feb 2015, Tom de Vries wrote: Btw, I&#

Re: [PATCH, PR66444] Handle -fipa-ra in reload_combine

2015-06-08 Thread Tom de Vries
On 08/06/15 17:31, Jakub Jelinek wrote: On Mon, Jun 08, 2015 at 02:04:12PM +0200, Tom de Vries wrote: this patch fixes PR66444, a problem with -fipa-ra in reload_combine. The problem is that for the test-case, reload_combine combines these two insns: Please work out with Vlad whether

Re: [PATCH, PR66444] Handle -fipa-ra in reload_combine

2015-06-08 Thread Tom de Vries
On 08/06/15 17:31, Jakub Jelinek wrote: On Mon, Jun 08, 2015 at 02:04:12PM +0200, Tom de Vries wrote: >this patch fixes PR66444, a problem with -fipa-ra in reload_combine. > >The problem is that for the test-case, reload_combine combines these two >insns: Please work out with

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Tom de Vries
On 08/06/15 17:55, Thomas Schwinge wrote: Hi Tom! On Mon, 8 Jun 2015 12:43:01 +0200, Tom de Vries wrote: There are two problems in try_transform_to_exit_first_loop_alt: 1. In case the latch is not a singleton bb, the function should return false rather than true. 2. The check for

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Tom de Vries
On 09/06/15 00:05, Tom de Vries wrote: On 08/06/15 17:55, Thomas Schwinge wrote: Hi Tom! On Mon, 8 Jun 2015 12:43:01 +0200, Tom de Vries wrote: There are two problems in try_transform_to_exit_first_loop_alt: 1. In case the latch is not a singleton bb, the function should return false

Re: [PING^2] [PATCH][5a/5] Postpone expanding va_arg until pass_stdarg

2015-06-09 Thread Tom de Vries
d - passes with that hunk. I'll put it through bootstrap and reg-test on x86_64. OK for trunk if that goes well? Thanks, - Tom Handle location in expand_ifn_va_arg_1 2015-06-09 Tom de Vries * tree-stdarg.c (expand_ifn_va_arg_1): Handle location. * gcc.target/i386/vararg-loc.c: New

Re: [PING^2][PATCH][3/3][PR65460] Mark offloaded functions as parallelized

2015-06-09 Thread Tom de Vries
On 09/06/15 13:07, Richard Biener wrote: On Mon, 8 Jun 2015, Tom de Vries wrote: On 17/04/15 12:08, Tom de Vries wrote: On 20-03-15 12:38, Tom de Vries wrote: On 19-03-15 12:05, Tom de Vries wrote: On 18-03-15 18:22, Tom de Vries wrote: Hi, this patch fixes PR65460. The patch marks

Re: [PING^2][PATCH][3/3][PR65460] Mark offloaded functions as parallelized

2015-06-10 Thread Tom de Vries
On 10/06/15 00:15, Thomas Schwinge wrote: Hi Tom! On Tue, 9 Jun 2015 16:12:12 +0200, Tom de Vries wrote: On 09/06/15 13:07, Richard Biener wrote: On Mon, 8 Jun 2015, Tom de Vries wrote: On 17/04/15 12:08, Tom de Vries wrote: On 20-03-15 12:38, Tom de Vries wrote: On 19-03-15 12:05, Tom

[committed] Update parloops-exit-first-loop-alt{,-2,-3}.c

2015-06-13 Thread Tom de Vries
Hi, this patch contains trivial improvements for test-cases {libgomp.c,gcc.dg}/parloops-exit-first-loop-alt{,-2,-3}.c. Committed to trunk. Thanks, - Tom Update parloops-exit-first-loop-alt{,-2,-3}.c 2015-06-13 Tom de Vries * testsuite/libgomp.c/parloops-exit-first-loop-alt-2.c: Add

[committed] Add parloops-exit-first-loop-alt-4.c

2015-06-13 Thread Tom de Vries
nks, - Tom Add gcc.dg/parloops-exit-first-loop-alt-4.c 2015-06-13 Tom de Vries * gcc.dg/parloops-exit-first-loop-alt-4.c: New test. * testsuite/libgomp.c/parloops-exit-first-loop-alt-4.c: New test. --- .../gcc.dg/parloops-exit-first-loop-alt-4.c| 28 ++ .../libgomp.

[PATCH] Handle casts in bound in try_transform_to_exit_first_loop_alt

2015-06-13 Thread Tom de Vries
sted tree expression '(unsigned int) (_6 + -1)' - strips the outer nops (assuming no change in value) - uses '(unsigned int)_6' as the alt_bound, and - gimplifies the expression. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle casts in bound in transform_to

Re: [PATCH, stage1] Make parloops gate more strict

2015-06-14 Thread Tom de Vries
On 13/03/15 11:36, Richard Biener wrote: On Fri, Mar 13, 2015 at 11:32 AM, Tom de Vries wrote: Hi, this patch moves a bunch of early-out tests from the parloops pass to the gate function. The only effect is for functions that we don't consider at all for parallelization in the parloops

Re: [PATCH] Fix warnings from including fdl.texi into gnat-style.texi

2015-06-14 Thread Tom de Vries
On 23/03/15 16:00, Gerald Pfeifer wrote: On Fri, 20 Mar 2015, Tom de Vries wrote: The gnat-style.texi part is OK. I cannot approve the fdl part though. Gerald, Can you approve the fdl part? Let's assume I can. Okay. Can you just describe the _why_ a bit in a @comment (in simple

[PING][PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-06-14 Thread Tom de Vries
On 30/03/15 11:54, Tom de Vries wrote: On 30-03-15 10:15, Jan Hubicka wrote: diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c index 64bdc92..c7a7c4d 100644 --- a/gcc/tree-cfg.c +++ b/gcc/tree-cfg.c @@ -6177,6 +6177,7 @@ gimple_duplicate_sese_tail (edge entry ATTRIBUTE_UNUSED, edge exit

[PING][PATCH][PR65511] Fix edge probabilities in move_sese_region_to_fn

2015-06-14 Thread Tom de Vries
On 30/03/15 11:54, Tom de Vries wrote: On 30-03-15 10:15, Jan Hubicka wrote: Also move_sese_region_to_fn seem to mis updating of counts. Can you, please, add that and send updated patch? Like this? OK for stage1 if bootstrap and reg-test on x86_64 are ok? Ping. Original posting at

Re: [PATCH, stage1] Make parloops gate more strict

2015-06-14 Thread Tom de Vries
On 14/06/15 23:49, Bernhard Reutner-Fischer wrote: On June 14, 2015 10:55:59 AM GMT+02:00, Tom de Vries wrote: On 13/03/15 11:36, Richard Biener wrote: On Fri, Mar 13, 2015 at 11:32 AM, Tom de Vries wrote: Hi, this patch moves a bunch of early-out tests from the parloops pass to the

[PATCH] Remove dg-options -O2 in libgomp.c

2015-06-15 Thread Tom de Vries
Hi, this patch removes superfluous dg-option "-O2" settings in testsuite/libgomp.c. The setting is superfluous, because DEFAULT_CFLAGS is already set to "-O2" in c.exp. Tested on x86_64. OK for trunk? Thanks, - Tom Remove dg-options -O2 in libgomp.c 2015

[patch] Run testsuite/libgomp.c++/c++.exp at -O2 by default

2015-06-15 Thread Tom de Vries
K for trunk? Thanks, - Tom Run testsuite/libgomp.c++/c++.exp at -O2 by default 2015-06-15 Tom de Vries * testsuite/libgomp.c++/c++.exp: Set DEFAULT_CFLAGS to -O2 if not already set. Use DEFAULT_CFLAGS in dg-runtest. * testsuite/libgomp.c++/atomic-16.C: Remove dg-options "-O2 -fopenmp

Re: [gomp4] Generate sequential loop for OpenACC loop directive inside kernels

2015-06-16 Thread Tom de Vries
On 16/06/15 10:59, Chung-Lin Tang wrote: This patch adjusts omp-low.c:expand_omp_for_generic() to expand to a "sequential" loop form (without the OMP runtime calls), used for loop directives inside OpenACC kernels constructs. Tom mentions that this allows the kernels parallelization to work whe

[gomp4,bootstrap] Remove unused variable in lower_reduction_clauses

2015-06-16 Thread Tom de Vries
Committed this patch to fix bootstrap. Thanks, - Tom Remove unused variable in lower_reduction_clauses 2015-06-16 Tom de Vries * omp-low.c (lower_reduction_clauses): Remove unused variable call. --- gcc/omp-low.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/omp

Re: [gomp4,bootstrap] Remove unused variable in lower_reduction_clauses

2015-06-16 Thread Tom de Vries
On 16/06/15 12:08, Tom de Vries wrote: Committed this patch to fix bootstrap. And this one. Thanks, - Tom Declare parm unused in make_offloadable_1 2015-06-16 Tom de Vries * varpool.c (make_offloadable_1): Declare decl with ATTRIBUTE_UNUSED. --- gcc/varpool.c | 2 +- 1 file changed

[gomp4][PATCH] Handle casts in bound in try_transform_to_exit_first_loop_alt

2015-06-18 Thread Tom de Vries
On 13/06/15 16:24, Tom de Vries wrote: Hi, this patch allows try_transform_to_exit_first_loop_alt to succeed when handling cases where the expression representing the number of iterations contains a cast. Currently, transform_to_exit_first_loop_alt testcase gfortran/parloops-exit-first-loop

[committed, gomp4] Rewrite virtuals into lcssa in transform_to_exit_first_loop_alt

2015-06-18 Thread Tom de Vries
, the property will be valid after transform_to_exit_first_loop_alt. Bootstrapped and reg-tested on x86_64. Committed to gomp-4_0-branch. OK for trunk? Thanks, - Tom Rewrite virtuals into lcssa in transform_to_exit_first_loop_alt 2015-06-18 Tom de Vries * tree-parloops.c

[gomp4, committed] Fix parallelization for fortran oacc kernels tests

2015-06-18 Thread Tom de Vries
es to make sure they get properly parallelized. Bootstrapped and reg-tested on x86_64. Committed to gomp-4_0-branch. Thanks, - Tom Fix parallelization for fortran oacc kernels tests 2015-06-18 Tom de Vries * passes.def: Move pass_fre later in pass group pass_oacc_kernels, replacing pass

Re: [gomp4, committed] Fix parallelization for fortran oacc kernels tests

2015-06-18 Thread Tom de Vries
On 18/06/15 12:48, Richard Biener wrote: On Thu, 18 Jun 2015, Tom de Vries wrote: Hi, I ran into a problem with fortran loops in oacc kernels regions not being parallelized, after introducting transform_to_exit_first_loop_alt. For gfortran.dg/goacc/kernels-loop.f95, we get: ... #pragma omp

Re: [committed, gomp4] Rewrite virtuals into lcssa in transform_to_exit_first_loop_alt

2015-06-18 Thread Tom de Vries
On 18/06/15 13:38, Richard Biener wrote: On Thu, Jun 18, 2015 at 9:25 AM, Tom de Vries wrote: Hi, transform_to_exit_first_loop contains the following comment: ... /* Make sure that we have phi nodes on exit for all loop header phis (create_parallel_loop requires that). */ ... I ran

Re: [PATCH, stage1] Make parloops gate more strict

2015-06-19 Thread Tom de Vries
On 16/06/15 13:18, Richard Biener wrote: On Mon, Jun 15, 2015 at 12:38 AM, Tom de Vries wrote: On 14/06/15 23:49, Bernhard Reutner-Fischer wrote: On June 14, 2015 10:55:59 AM GMT+02:00, Tom de Vries wrote: On 13/03/15 11:36, Richard Biener wrote: On Fri, Mar 13, 2015 at 11:32 AM, Tom de

Re: Expand oacc kernels after pass_fre

2015-06-19 Thread Tom de Vries
On 08/06/15 09:25, Richard Biener wrote: On Thu, 4 Jun 2015, Tom de Vries wrote: { gsi_next (&gsi); continue; diff --git gcc/tree-ssa-sccvn.c gcc/tree-ssa-sccvn.c index e417a15..449a615 100644 --- gcc/tree-ssa-sccvn.c +++ gcc/tree-ssa-sccvn.c @@ -

[PATCH] Test for flag_parallelize_loops > 1

2015-06-19 Thread Tom de Vries
> 1', just like all the other tests of flag_parallelize_loops in the compiler. Build on x86_64 and reg-tested libgomp's c.exp. OK for trunk if bootstrap and reg-test succeeds? Thanks, - Tom Test for flag_parallelize_loops > 1 2015-06-19 Tom de Vries

[PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
ide or outside the TV_DOM_FRONTIERS measurement. - there is a level of ENABLE_CHECKING that is more appropriate for the verify_dominators call. Is this ok for trunk if bootstrap and reg-test on x86_64 succeeds? Thanks, - Tom Check dominator info in compute_dominance_frontiers 201

[gomp4] dominance info after predicate_omp_regions

2015-06-22 Thread Tom de Vries
On 21/05/15 13:42, ber...@gcc.gnu.org wrote: Author: bernds Date: Thu May 21 11:42:14 2015 New Revision: 223478 URL: https://gcc.gnu.org/viewcvs?rev=223478&root=gcc&view=rev Log: * omp-low.c (struct omp_region): Add a gwv_this field. (bb_region_map): New variable. (find_o

[gomp4, committed] Handle reduction in oacc kernels region

2015-06-22 Thread Tom de Vries
nch. Committed to gomp-4_0-branch. Thanks, - Tom Handle reduction in oacc kernels region 2015-06-18 Tom de Vries * tree-parloops.c (struct reduction_info): Add reduc_addr field. (create_call_for_reduction_1): Handle case that reduc_addr is non-NULL. (gen_parallel_loop): Init clsn_d

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
On 22/06/15 12:14, Richard Biener wrote: On Mon, Jun 22, 2015 at 10:04 AM, Tom de Vries wrote: Hi, during development of a patch I ran into a case where compute_dominance_frontiers was called with incorrect dominance info. The result was a segmentation violation somewhere in the bitmap code

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
On 22/06/15 13:47, Richard Biener wrote: On Mon, Jun 22, 2015 at 1:33 PM, Tom de Vries wrote: On 22/06/15 12:14, Richard Biener wrote: On Mon, Jun 22, 2015 at 10:04 AM, Tom de Vries wrote: Hi, during development of a patch I ran into a case where compute_dominance_frontiers was called

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
On 22/06/15 13:47, Richard Biener wrote: (eventually also for the case where we >>end up only computing the fast-query stuff). Like this? ... diff --git a/gcc/dominance.c b/gcc/dominance.c index 9c66ca2..58fc6fd 100644 --- a/gcc/dominance.c +++ b/gcc/dominance.c @@ -679,6 +679,12 @@ calculate_

[committed] Test for flag_parallelize_loops > 1

2015-06-22 Thread Tom de Vries
On 19/06/15 11:26, Tom de Vries wrote: Hi, DEF_GOMP_BUILTIN tests for 'flag_parallelize_loops'. But if flag_parallelize_loops is one (which is also the default), then pass_parloops doesn't do anything, and won't generate any OMP constructs. This patch makes DE

[committed] Add missing update_stmt in transform_to_exit_first_loop_alt

2015-06-22 Thread Tom de Vries
update_stmt in transform_to_exit_first_loop_alt 2015-06-22 Tom de Vries * tree-parloops.c (transform_to_exit_first_loop_alt): Add update_stmt for cond_stmt. --- gcc/tree-parloops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-parloops.c b/gcc/tree-parloops.c index 28112b2..7123c27

[PATCH] parloops exit phi fixes

2015-06-22 Thread Tom de Vries
s. Bootstrapped and reg-tested on x864_64 on top of gomp-4_0-branch in combination with the patch series that triggered the problem. Bootstrapped and reg-tested on x864_64 on top of trunk. OK for trunk? Thanks, - Tom Handle unused reduction in create_loads_for_reductions 2015-06-22 Tom

[committed] Use abort in parloops-exit-first-loop-alt-{3,4}.c

2015-06-23 Thread Tom de Vries
Hi, committed attached patch as trivial. Thanks, - Tom Use abort in parloops-exit-first-loop-alt-{3,4}.c 2015-06-23 Tom de Vries * testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c (main): Use abort. * testsuite/libgomp.c/parloops-exit-first-loop-alt-4.c (main): Same. --- libgomp

[gomp4, committed] Move rewrite_virtuals_into_loop_closed_ssa to tree-ssa-loop-manip.c

2015-06-24 Thread Tom de Vries
Hi, this patch moves rewrite_virtuals_into_loop_closed_ssa to tree-ssa-loop-manip.c, as requested here: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01264.html . Thanks, - Tom Move rewrite_virtuals_into_loop_closed_ssa to tree-ssa-loop-manip.c 2015-06-18 Tom de Vries * tree-parloops.c

[gomp4, committed] Add bitmap_get_dominated_by

2015-06-24 Thread Tom de Vries
Hi, this patch adds bitmap_get_dominated_by, a version of get_dominated_by that returns a bitmap rather than a vector. Committed to gomp-4_0-branch. Thanks, - Tom Add bitmap_get_dominated_by 2015-06-18 Tom de Vries * dominance.c (bitmap_get_dominated_by): New function. * dominance.h

[gomp4, committed] Add get_virtual_phi

2015-06-24 Thread Tom de Vries
Hi, this patch factors new function get_virtual_phi out of rewrite_virtuals_into_loop_closed_ssa. Committed to gomp-4_0-branch. Thanks, - Tom Add get_virtual_phi 2015-06-18 Tom de Vries * tree-ssa-loop-manip.c (get_virtual_phi): Factor out of ... (rewrite_virtuals_into_loop_closed_ssa

[gomp4, committed] Add replace_uses_in_dominated_bbs

2015-06-24 Thread Tom de Vries
Hi, this patch factors out a new function replace_uses_in_dominated_bbs out of rewrite_virtuals_into_loop_closed_ssa. Committed to gomp-4_0-branch. Thanks, - Tom Add replace_uses_in_dominated_bbs 2015-06-18 Tom de Vries * tree-ssa-loop-manip.c (replace_uses_in_dominated_bbs): Factor out

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-25 Thread Tom de Vries
On 23/06/15 11:31, Richard Biener wrote: On Mon, Jun 22, 2015 at 7:10 PM, Tom de Vries wrote: On 22/06/15 13:47, Richard Biener wrote: (eventually also for the case where we end up only computing the fast-query stuff). Like this? ... diff --git a/gcc/dominance.c b/gcc/dominance.c index

[PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-06-25 Thread Tom de Vries
2015-06-24 Tom de Vries merge from gomp4 branch: 2015-06-24 Tom de Vries * tree-ssa-loop-manip.c (get_virtual_phi): Factor out of ... (rewrite_virtuals_into_loop_closed_ssa): ... here. * tree-ssa-loop-manip.c (replace_uses_in_dominated_bbs): Factor out of

[PATCH, 2/2][PR66642] Add empty loop exit block in transform_to_exit_first_loop_alt

2015-06-25 Thread Tom de Vries
exit block inbetween the main loop header and the old exit block. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Add empty loop exit block in transform_to_exit_first_loop_alt 2015-06-24 Tom de Vries PR tree-optimization/66642 * tree-parloops.c (transform_to_exit_firs

[Committed] Remove 'unsigned' in header comment canonicalize_loop_ivs

2015-06-25 Thread Tom de Vries
Hi, this patch fixes the header comment of canonicalize_loop_ivs. The generated IV is not guaranteed to be unsigned since the fix for PR49471. Thanks, - Tom Remove 'unsigned' in header comment canonicalize_loop_ivs 2015-06-25 Tom de Vries * tree-ssa-loop-manip.c (canonicaliz

[committed] Simplify structure try_transform_to_exit_first_loop_alt

2015-06-29 Thread Tom de Vries
-29 Tom de Vries * tree-parloops.c (try_transform_to_exit_first_loop_alt): Simplify function structure. --- gcc/tree-parloops.c | 59 ++--- 1 file changed, 15 insertions(+), 44 deletions(-) diff --git a/gcc/tree-parloops.c b/gcc/tree-parloops.c

[PATCH, PR66652] Use max_loop_iterations in transform_to_exit_first_loop_alt

2015-06-29 Thread Tom de Vries
15-06-29 Tom de Vries PR tree-optimization/66652 * tree-parloops.c (try_transform_to_exit_first_loop_alt): Use max_loop_iterations to determine if nit + 1 overflows. * testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c (f): Rewrite using restrict pointers. (main): Add arguments to calls

[PATCH] Insert new bound in try_transform_to_exit_first_loop_alt

2015-06-29 Thread Tom de Vries
in try_transform_to_exit_first_loop_alt 2015-06-29 Tom de Vries * tree-parloops.c (try_transform_to_exit_first_loop_alt): If not found, insert nit + 1 bound. * testsuite/libgomp.fortran/parloops-exit-first-loop-alt-2.f95: New test. * testsuite/libgomp.fortran/parloops-exit-first-loop

Re: [gomp4][PATCH] Handle casts in bound in try_transform_to_exit_first_loop_alt

2015-06-29 Thread Tom de Vries
On 22/06/15 16:36, Richard Biener wrote: On Thu, 18 Jun 2015, Tom de Vries wrote: On 13/06/15 16:24, Tom de Vries wrote: Hi, this patch allows try_transform_to_exit_first_loop_alt to succeed when handling cases where the expression representing the number of iterations contains a cast

Re: [PATCH, PR66652] Use max_loop_iterations in transform_to_exit_first_loop_alt

2015-06-30 Thread Tom de Vries
On 29/06/15 19:58, Jeff Law wrote: On 06/29/2015 08:24 AM, Tom de Vries wrote: Hi, this patch fixes PR66652. It uses max_loop_iterations in transform_to_exit_first_loop_alt to ensure that the new loop bound nit + 1 doesn't overflow. Bootstrapped and reg-tested on x86_64. OK for

Re: [PATCH, 2/2][PR66642] Add empty loop exit block in transform_to_exit_first_loop_alt

2015-06-30 Thread Tom de Vries
On 25/06/15 09:43, Tom de Vries wrote: Hi, I ran into a failure with parloops for reduction loop testcase libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c. When we exercise the low iteration count loop, the test-case fails. To understand the problem, let's first look at

[gomp4, committed] Insert new exit block only when needed in transform_to_exit_first_loop_alt

2015-06-30 Thread Tom de Vries
needed in transform_to_exit_first_loop_alt 2015-06-30 Tom de Vries * tree-parloops.c (transform_to_exit_first_loop_alt): Insert new exit block only when needed. --- gcc/tree-parloops.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff -

[committed] Add parloops-exit-first-loop-alt-{5,6,7}.c

2015-06-30 Thread Tom de Vries
Hi, This patch adds variants of parloops-exit-first-loop-alt.c, to cover all combinations of loop bound signed/unsigned and loop counter signed/unsigned. Committed to trunk. Thanks, - Tom Add parloops-exit-first-loop-alt-{5,6,7}.c 2015-06-29 Tom de Vries * gcc.dg/parloops-exit-first

[PING][patch] Run testsuite/libgomp.c++/c++.exp at -O2 by default

2015-06-30 Thread Tom de Vries
On 15/06/15 18:36, Tom de Vries wrote: Hi, this patch: - sets DEFAULT_CFLAGS to -O2, if not set otherwise (similar to what is done in c.exp) - removes superfluous dg-options "-O2" settings. - removes superfluous dg-options "-fopenmp" settings. - uses dg-additional-option

[committed] Run testsuite/libgomp.oacc-c++/c++.exp at -O2 by default

2015-06-30 Thread Tom de Vries
[ was: Re: [patch] Run testsuite/libgomp.c++/c++.exp at -O2 by default ] On 30/06/15 14:07, Jakub Jelinek wrote: On Mon, Jun 15, 2015 at 06:36:17PM +0200, Tom de Vries wrote: Hi, this patch: - sets DEFAULT_CFLAGS to -O2, if not set otherwise (similar to what is done in c.exp) - removes

[committed,gomp4] Run testsuite/libgomp.oacc-c++/c++.exp at -O2 by default

2015-06-30 Thread Tom de Vries
[ was Re: [committed] Run testsuite/libgomp.oacc-c++/c++.exp at -O2 by default ] On 30/06/15 17:48, Tom de Vries wrote: [ was: Re: [patch] Run testsuite/libgomp.c++/c++.exp at -O2 by default ] On 30/06/15 14:07, Jakub Jelinek wrote: On Mon, Jun 15, 2015 at 06:36:17PM +0200, Tom de Vries

Re: libgomp: libgomp.oacc-c-c++-common/lib-62.c is for acc_device_nvidia only

2015-07-01 Thread Tom de Vries
27;ve committed attached patch to gomp-4_0-branch, before finding this patch (which is a bit more thorough). You can drop it with the next merge from trunk. Thanks, - Tom Run libgomp.oacc-c-c++-common/lib-62.c only for nvidia 2015-07-01 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/lib

[gomp4, committed] Gracefully handle acc_init (nvidia) when not supported

2015-07-01 Thread Tom de Vries
acefully handle acc_init (nvidia) when not supported 2015-07-01 Tom de Vries * oacc-init.c (acc_init_1): Move base_dev NULL test to before use. * testsuite/lib/libgomp.exp (check_effective_target_openacc_nvidia_accel_supported): New proc. * testsuite/libgomp.oacc-c-c++-common/lib-93.c: Ne

[gomp4, PATCH] Fix libgomp.oacc-c-c++-common/lib-3.c

2015-07-01 Thread Tom de Vries
Attached patch makes sure that both current failure modes are tested and accepted. OK for gomp-4_0-branch? Thanks, - Tom Fix libgomp.oacc-c-c++-common/lib-3.c 2015-07-01 Tom de Vries * testsuite/lib/libgomp.exp (offload_targets_nonhost): New var. (check_effective_target_offload_target_no

[PATCH, PR66432] Handle PARM_DECL in remap_gimple_op_r

2015-07-01 Thread Tom de Vries
longer the same, and a bit later we hit the ICE. III. Attached patch fixes the ICE by handling PARM_DECL in remap_gimple_op_r. [ I'm not confident though this is the right fix ] Bootstrapped and reg-tested on x86_64. OK for trunk, or to be fixed otherwise? Thanks, - Tom Handle PARM_DECL i

[gomp4, committed, PR66716] Fix compilation libgomp.oacc-c-c++-common/kernels-loop.c -g

2015-07-01 Thread Tom de Vries
Thanks, - Tom Fix compilation libgomp.oacc-c-c++-common/kernels-loop.c -g 2015-07-01 Tom de Vries PR tree-optimization/66716 * tree-cfg.c (gimple_split_block_before_cond_jump): Split before cond_jump, instead of split after last nondebug insn before cond_jump. * c-c++-common/goacc/kernels-

Re: [PATCH, PR66432] Handle PARM_DECL in remap_gimple_op_r

2015-07-01 Thread Tom de Vries
On 01/07/15 13:58, Richard Biener wrote: On Wed, Jul 1, 2015 at 1:43 PM, Tom de Vries wrote: Hi, I. When running test libgomp.c/appendix-a/a.29.1.c with '--target_board unix/-O2/-g', we run into this failure: ... FAIL: libgomp.c/appendix-a/a.29.1.c (test for excess errors) Excess e

[testsuite, committed, PR66723] Use scan-rtl-dump in i386/vararg-loc.c

2015-07-01 Thread Tom de Vries
Hi, I've committed this patch, which rewrites the scan lines in test-case i386/vararg-loc.c from scan-assembler to scan-rtl-dump, to fix PR66723. Thanks, - Tom Use scan-rtl-dump in i386/vararg-loc.c 2015-07-01 Tom de Vries PR testsuite/66723 * gcc.target/i386/vararg-loc.c: Use sca

[RFC] two-phase marking in gt_cleare_cache

2015-07-06 Thread Tom de Vries
Hi, Using attached untested patch, I managed to minimize a test-case failure for PR 66714. The patch introduces two-phase marking in gt_cleare_cache: - first phase, it loops over all the hash table entries and removes those which are dead - second phase, it runs over all the live hash table

[PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-06 Thread Tom de Vries
On 25/06/15 09:42, Tom de Vries wrote: Hi, this patch merges rewrite_virtuals_into_loop_closed_ssa (originally submitted here: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01236.html ) to trunk. Bootstrapped and reg-tested on x86_64. OK for trunk? Ping. Thanks, - Tom 0001-Merge

[PING][PATCH, 2/2][PR66642] Add empty loop exit block in transform_to_exit_first_loop_alt

2015-07-06 Thread Tom de Vries
On 25/06/15 09:43, Tom de Vries wrote: Hi, I ran into a failure with parloops for reduction loop testcase libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c. When we exercise the low iteration count loop, the test-case fails. To understand the problem, let's first look at

Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-06 Thread Tom de Vries
On 06/07/15 15:29, Richard Biener wrote: On Mon, Jul 6, 2015 at 3:25 PM, Richard Biener wrote: On Mon, Jul 6, 2015 at 10:57 AM, Tom de Vries wrote: Hi, Using attached untested patch, I managed to minimize a test-case failure for PR 66714. The patch introduces two-phase marking in

[patch, driver] Ignore -ftree-parallelize-loops={0,1}

2015-07-07 Thread Tom de Vries
Hi, currently, we have these spec strings in gcc/gcc.c involving ftree-parallelize-loops: ... %{fopenacc|fopenmp|ftree-parallelize-loops=*:%:include(libgomp.spec)%(link_gomp)} %{fopenacc|fopenmp|ftree-parallelize-loops=*:-pthread}" ... Actually, ftree-parallelize-loops={0,1} means that no para

Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-07 Thread Tom de Vries
On 07/07/15 10:42, Richard Biener wrote: On Mon, Jul 6, 2015 at 7:29 PM, Tom de Vries wrote: On 06/07/15 15:29, Richard Biener wrote: On Mon, Jul 6, 2015 at 3:25 PM, Richard Biener wrote: On Mon, Jul 6, 2015 at 10:57 AM, Tom de Vries wrote: Hi, Using attached untested patch, I managed

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-07 Thread Tom de Vries
On 06/07/15 15:44, Richard Biener wrote: On Mon, 6 Jul 2015, Tom de Vries wrote: On 25/06/15 09:42, Tom de Vries wrote: Hi, this patch merges rewrite_virtuals_into_loop_closed_ssa (originally submitted here: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01236.html ) to trunk. Bootstrapped

Re: [PATCH, 2/2][PR66642] Add empty loop exit block in transform_to_exit_first_loop_alt

2015-07-08 Thread Tom de Vries
On 08/07/15 12:40, Andreas Schwab wrote: Tom de Vries writes: * testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c (main): Test low iteration count case. ../../../../libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c: In function 'main': ../../../

[gomp4, committed] Add rewrite_virtuals_into_loop_closed_ssa

2015-07-08 Thread Tom de Vries
[ was: Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch ] On 07/07/15 17:58, Tom de Vries wrote: Bootstrapped reg-tested on x86_64. Committed to trunk as attached. Reverted related patches on gomp-4_0-branch, and committed this patch instead. Thanks

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-09 Thread Tom de Vries
On 09/07/15 05:33, Jeff Law wrote: On 07/07/2015 09:58 AM, Tom de Vries wrote: [Big snip] 0001-Add-rewrite_virtuals_into_loop_closed_ssa.patch Add rewrite_virtuals_into_loop_closed_ssa 2015-07-07 Tom de Vries * tree-cfg.c (get_virtual_phi): New function. * tree-cfg.h

Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-09 Thread Tom de Vries
d does not increase runtime. Passes a minimal c build, and it fixes the ICE of PR66714 (although there still might be a root cause to address, I'm not sure). Thanks, - Tom Use conservative non-iterative strategy for caches 2015-07-09 Tom de Vries PR libgomp/66714 * hash-table.h (

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-09 Thread Tom de Vries
On 07/07/15 17:58, Tom de Vries wrote: If you can handle one exit edge I also can't see the difficulty in handling all exit edges. Agreed, that doesn't look to complicated. I could call rewrite_virtuals_into_loop_closed_ssa for all loops in rewrite_virtuals_into_loop_closed_ssa,

[PING][PATCH] Insert new bound in try_transform_to_exit_first_loop_alt

2015-07-09 Thread Tom de Vries
On 29/06/15 16:30, Tom de Vries wrote: Hi, this patch allows try_transform_to_exit_first_loop_alt to handle the case that the new loop bound nit + 1 is not available as ssa-name n in the assignment nit = n - 1, by inserting the new loop bound. Bootstrapped and reg-tested on x86_64. OK for

Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-09 Thread Tom de Vries
On 09/07/15 12:44, Tom de Vries wrote: On 07/07/15 16:00, Michael Matz wrote: Hi, On Mon, 6 Jul 2015, Richard Biener wrote: By doing so, we make the behaviour of gt_cleare_cache independent of the order in which the entries are visited, turning: - hard-to-trigger bugs which trigger for one

[committed][PR64707] Make fopenmp an LTO option

2015-01-23 Thread Tom de Vries
Hi, This patch fixes PR64707. It marks fopenmp as LTO option, which enables openmp builtins in lto1. Bootstrapped, reg-tested on x86_64 and committed. Thanks, - Tom 2015-01-22 Tom de Vries PR libgomp/64707 * lto-opts.c (lto_write_options): Output non-explicit conservative -fno-openmp

[committed][PR64672] Make fopenacc an LTO option

2015-01-23 Thread Tom de Vries
Hi, This patch fixes PR64672. It marks fopenacc as LTO option, which enables openacc builtins in lto1. Bootstrapped, reg-tested on x86_64 and committed. Thanks, - Tom 2015-01-22 Tom de Vries PR libgomp/64672 * lto-opts.c (lto_write_options): Output non-explicit conservative -fno

Re: [PATCH x86] Add march/mtune=knl

2015-01-24 Thread Tom de Vries
stead of avx512? Attached patch ok for stage4 trunk? Thanks, - Tom 2015-01-24 Tom de Vries * gcc.target/i386/funcspec-5.c: Replace avx512 with avx512f. --- gcc/testsuite/gcc.target/i386/funcspec-5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.

Re: Add to maintainers list.

2015-01-25 Thread Tom de Vries
On 24-01-15 20:41, Gerald Pfeifer wrote: Hi Alex, On Friday 2014-11-21 10:07, Alex Velenko wrote: Can someone, please, approve? we tried to document this in https://gcc.gnu.org/svnwrite.html . Can you perhaps suggest a way for us to improve this to make it more clear or easier to find? Ho

Fix scan-tree-dump for scop-19.c

2015-02-04 Thread Tom de Vries
ntry. This patch updates the scan-tree-dump to match the pic/nonpic behaviour. OK for trunk? Thanks, - Tom 2015-02-04 Tom de Vries * gcc.dg/graphite/scop-19.c: Fix scan-tree-dump for fpic. diff --git a/gcc/testsuite/gcc.dg/graphite/scop-19.c b/gcc/testsuite/gcc.dg/graphite/scop-19.c index 9df

Re: [PATCH] Fix PR64764

2015-02-05 Thread Tom de Vries
On 26-01-15 15:47, Richard Biener wrote: Index: gcc/testsuite/gcc.dg/uninit-19.c === --- gcc/testsuite/gcc.dg/uninit-19.c(revision 0) +++ gcc/testsuite/gcc.dg/uninit-19.c(working copy) @@ -0,0 +1,23 @@ +/* { dg-do compile } *

Re: [PATCH] Fix PR64764

2015-02-09 Thread Tom de Vries
On 09-02-15 09:59, Richard Biener wrote: On Thu, 5 Feb 2015, Tom de Vries wrote: On 26-01-15 15:47, Richard Biener wrote: Index: gcc/testsuite/gcc.dg/uninit-19.c === --- gcc/testsuite/gcc.dg/uninit-19.c(revision 0) +++ gcc

Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c

2015-02-09 Thread Tom de Vries
On 09-02-15 18:23, Dominique Dhumieres wrote: Tom, After these changes I have the following regressions on x86_64-apple-darwin1[04]*: FAIL: gcc.dg/uninit-19.c (test for warnings, line 22) FAIL: gcc.dg/uninit-19.c (test for excess errors) FAIL: gcc.dg/graphite/scop-19.c scan-tree-dump-times gr

Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c

2015-02-10 Thread Tom de Vries
On 09-02-15 20:01, Dominique d'Humières wrote: Le 9 févr. 2015 à 19:10, Tom de Vries mailto:tom_devr...@mentor.com>> a écrit : On 09-02-15 18:23, Dominique Dhumieres wrote: Tom, After these changes I have the following regressions on x86_64-apple-darwin1[04]*: FAIL: gcc.dg/

Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c

2015-02-11 Thread Tom de Vries
On 11-02-15 10:22, Dominique d'Humières wrote: Le 10 févr. 2015 à 12:42, Tom de Vries a écrit : I think we need to understand first what's going on. Sure, my patch was mainly to silence the failures on my working tree. In both test-cases, on Linux with -fpic the inlining of one

[committed] Add gcc.target/x86_64/abi/callabi/vaarg-6.c

2015-02-17 Thread Tom de Vries
Committed new test-case. Thanks, - Tom 2015-02-17 Tom de Vries * gcc.target/x86_64/abi/callabi/vaarg-6.c: New test. --- .../gcc.target/x86_64/abi/callabi/vaarg-6.c| 40 ++ 1 file changed, 40 insertions(+) create mode 100644 gcc/testsuite/gcc.target/x86_64/abi

[Patch] Add option ftree-stdarg-opt

2015-02-17 Thread Tom de Vries
regression or documentation fix, so it doesn't classify as a stage 4 patch. I could imagine it still being included in stage4 because it adds the possibility for a workaround in case of problems. Bootstrapped and reg-tested on x86_64. OK for stage1 (or even stage 4)? Thanks, - Tom 2015-0

<    8   9   10   11   12   13   14   15   16   17   >