Re: [PATCH] Implement __builtin_issignaling

2022-08-26 Thread Michael Meissner via Gcc-patches
On Thu, Aug 25, 2022 at 09:56:18PM +0200, Jakub Jelinek wrote: > On Thu, Aug 25, 2022 at 03:23:12PM -0400, Michael Meissner wrote: > > On Mon, Aug 15, 2022 at 12:12:02PM +0200, Jakub Jelinek via Gcc-patches > > wrote: > > > Hi! > > > > > > The following patch implements a new builtin,

Re: [PATCH] Implement __builtin_issignaling

2022-08-25 Thread Jakub Jelinek via Gcc-patches
On Thu, Aug 25, 2022 at 03:23:12PM -0400, Michael Meissner wrote: > On Mon, Aug 15, 2022 at 12:12:02PM +0200, Jakub Jelinek via Gcc-patches wrote: > > Hi! > > > > The following patch implements a new builtin, __builtin_issignaling, > > which can be used to implement the ISO/IEC TS 18661-1

Re: [PATCH] Implement __builtin_issignaling

2022-08-25 Thread Michael Meissner via Gcc-patches
On Mon, Aug 15, 2022 at 12:12:02PM +0200, Jakub Jelinek via Gcc-patches wrote: > Hi! > > The following patch implements a new builtin, __builtin_issignaling, > which can be used to implement the ISO/IEC TS 18661-1 issignaling > macro. I haven't looked in detail at the patch, but from the

Re: Patch ping (Re: [PATCH] Implement __builtin_issignaling)

2022-08-23 Thread Joseph Myers
On Tue, 23 Aug 2022, Jakub Jelinek via Gcc-patches wrote: > On Tue, Aug 16, 2022 at 11:41:06AM +, Richard Biener wrote: > > I'm OK with the rest of the patch if Joseph doesn't have comments > > on the actual issignaling lowerings (which I didn't review for > > correctness due to lack of

Patch ping (Re: [PATCH] Implement __builtin_issignaling)

2022-08-23 Thread Jakub Jelinek via Gcc-patches
On Tue, Aug 16, 2022 at 11:41:06AM +, Richard Biener wrote: > I'm OK with the rest of the patch if Joseph doesn't have comments > on the actual issignaling lowerings (which I didn't review for > correctness due to lack of knowledge). I'd like to ping this patch. Patch:

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Jakub Jelinek wrote: > On Tue, Aug 16, 2022 at 11:41:06AM +, Richard Biener wrote: > > Can you also amend the extend.texi documentation? I think the > > behavior will be special enough to worth mentioning it (I don't see > > any of -ffinite-math-only effect on

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Jakub Jelinek via Gcc-patches
On Tue, Aug 16, 2022 at 11:41:06AM +, Richard Biener wrote: > Can you also amend the extend.texi documentation? I think the > behavior will be special enough to worth mentioning it (I don't see > any of -ffinite-math-only effect on isnan/isinf mentioned though). Like this? ---

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Jakub Jelinek wrote: > On Mon, Aug 15, 2022 at 03:06:16PM +0200, Jakub Jelinek via Gcc-patches wrote: > > On Mon, Aug 15, 2022 at 12:07:38PM +, Richard Biener wrote: > > > Ah, I misread > > > > > > +static rtx > > > +expand_builtin_issignaling (tree exp, rtx target) > >

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 15, 2022 at 03:06:16PM +0200, Jakub Jelinek via Gcc-patches wrote: > On Mon, Aug 15, 2022 at 12:07:38PM +, Richard Biener wrote: > > Ah, I misread > > > > +static rtx > > +expand_builtin_issignaling (tree exp, rtx target) > > +{ > > + if (!validate_arglist (exp, REAL_TYPE,

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Uros Bizjak via Gcc-patches
On Mon, Aug 15, 2022 at 12:12 PM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > The following patch implements a new builtin, __builtin_issignaling, > which can be used to implement the ISO/IEC TS 18661-1 issignaling > macro. > > It is implemented as type-generic function, so there is just one

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 15, 2022 at 06:14:22PM +0200, FX wrote: > Thank you for taking this on (this patch and the Fortran ones), it is really > appreciated and will improve gfortran's IEEE conformance. > > - "Implement __builtin_issignaling”: is approved for the tiny Fortran part > - "libgfortran: Use

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread FX via Gcc-patches
Hi Jakub, Thank you for taking this on (this patch and the Fortran ones), it is really appreciated and will improve gfortran's IEEE conformance. - "Implement __builtin_issignaling”: is approved for the tiny Fortran part - "libgfortran: Use __builtin_issignaling in libgfortran”: was approved by

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 15, 2022 at 12:07:38PM +, Richard Biener wrote: > Ah, I misread > > +static rtx > +expand_builtin_issignaling (tree exp, rtx target) > +{ > + if (!validate_arglist (exp, REAL_TYPE, VOID_TYPE)) > +return NULL_RTX; > + > + tree arg = CALL_EXPR_ARG (exp, 0); > +

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Richard Biener via Gcc-patches
On Mon, 15 Aug 2022, Jakub Jelinek wrote: > On Mon, Aug 15, 2022 at 11:24:14AM +, Richard Biener wrote: > > Unlike the issignalling macro from glibc the builtin will return > > false for sNaN arguments when -fno-signalling-nans is used (similar > > to isinf, isnan, etc.). I think this

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Andreas Schwab via Gcc-patches
On Aug 15 2022, Jakub Jelinek via Gcc-patches wrote: > That seems like a glibc bug/weird feature in the __MATH_TG macro > or _Generic. __MATH_TG is only defined for real floating types, since all of the type generic macros in only accept real floating types. -- Andreas Schwab, SUSE Labs,

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 15, 2022 at 11:24:14AM +, Richard Biener wrote: > Unlike the issignalling macro from glibc the builtin will return > false for sNaN arguments when -fno-signalling-nans is used (similar > to isinf, isnan, etc.). I think this deserves mentioning in the > documentation (and I have my

Re: [PATCH] Implement __builtin_issignaling

2022-08-15 Thread Richard Biener via Gcc-patches
On Mon, 15 Aug 2022, Jakub Jelinek wrote: > Hi! > > The following patch implements a new builtin, __builtin_issignaling, > which can be used to implement the ISO/IEC TS 18661-1 issignaling > macro. > > It is implemented as type-generic function, so there is just one > builtin, not many with

[PATCH] Implement __builtin_issignaling

2022-08-15 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch implements a new builtin, __builtin_issignaling, which can be used to implement the ISO/IEC TS 18661-1 issignaling macro. It is implemented as type-generic function, so there is just one builtin, not many with various suffixes. This patch doesn't address PR56831 nor