Re: [Patch] Implement std::experimental::variant

2016-09-13 Thread Andre Vieira (lists)
On 26/08/16 18:56, Tim Shen wrote: >> >> Adding '#include ' to >> 'include/c++/7.0.0/variant' "fixes" that. Not sure its the right >> approach though. > > Why not? > I'm not saying its the wrong approach, I'm just saying thats the first thing I tried and it "seemed" to solve it but I didnt

Re: [Patch] Implement std::experimental::variant

2016-08-26 Thread Tim Shen
Hi, On Fri, Aug 26, 2016 at 7:43 AM, Andre Vieira (lists) wrote: > I am seeing failures on arm-none-eabi for Cortex-M0 for these two tests: > .../gcc-final/arm-none-eabi/armv6-m/libstdc++-v3/include/variant: In > member function

Re: [Patch] Implement std::experimental::variant

2016-08-26 Thread Andre Vieira (lists)
On 19/08/16 09:18, Jonathan Wakely wrote: > On 18/08/16 13:32 -0700, Tim Shen wrote: >> Tested on x86_64-linux-gnu and checked in as r239590. > > This updates the status at > https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.201z > > Committed to trunk. > > Hi, I am

Re: [Patch] Implement std::experimental::variant

2016-08-19 Thread Jonathan Wakely
On 18/08/16 13:32 -0700, Tim Shen wrote: Tested on x86_64-linux-gnu and checked in as r239590. This updates the status at https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.201z Committed to trunk. commit 6c46b6c04ac234b6443208e922bb3177344e90a8 Author: Jonathan Wakely

Re: [Patch] Implement std::experimental::variant

2016-08-18 Thread Tim Shen
Tested on x86_64-linux-gnu and checked in as r239590. Thanks! -- Regards, Tim Shen

Re: [Patch] Implement std::experimental::variant

2016-08-18 Thread Jonathan Wakely
On 05/08/16 22:45 -0700, Tim Shen wrote: On Fri, Aug 5, 2016 at 4:08 AM, Jonathan Wakely wrote: I think these all need to use ::new (__ptr) with qualification, see below. Done. I didn't add a testcase for this. Do you think that we need one/some? No, I don't think we

Re: [Patch] Implement std::experimental::variant

2016-08-08 Thread Ville Voutilainen
On 7 August 2016 at 04:04, Ville Voutilainen wrote: >> Good news! This compiles now! I learned the technique from Anthony >> Williams's implementation, whose code also compiles, but it requires a >> close-to-trunk gcc, which implements >> "...for unions, at least one

Re: [Patch] Implement std::experimental::variant

2016-08-06 Thread Ville Voutilainen
On 6 August 2016 at 08:45, Tim Shen wrote: >> using namespace std; >> constexpr variant v{}; >> constexpr variant v1{in_place_type}; >> constexpr variant v2{in_place_index<0>}; > > Good news! This compiles now!

Re: [Patch] Implement std::experimental::variant

2016-08-05 Thread Tim Shen
On Fri, Aug 5, 2016 at 4:08 AM, Jonathan Wakely wrote: >> --- a/libstdc++-v3/include/bits/uses_allocator.h >> +++ b/libstdc++-v3/include/bits/uses_allocator.h >> @@ -113,6 +113,51 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> constexpr bool uses_allocator_v = uses_allocator<_Tp,