Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-06-09 Thread Rainer Orth
Mike Stump mikest...@comcast.net writes: On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: * lto.c (promote_var): Only set VISIBILITY_HIDDEN if HAVE_GAS_HIDDEN. This looks wrong, there are more things that have visibility than those things that use GAS and have .hidden. Darwin I think

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-06-09 Thread Richard Guenther
On Thu, Jun 9, 2011 at 9:14 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Mike Stump mikest...@comcast.net writes: On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:  * lto.c (promote_var): Only set VISIBILITY_HIDDEN if      HAVE_GAS_HIDDEN. This looks wrong, there are more things that

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-06-09 Thread Jan Hubicka
On Thu, Jun 9, 2011 at 9:14 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Mike Stump mikest...@comcast.net writes: On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:  * lto.c (promote_var): Only set VISIBILITY_HIDDEN if      HAVE_GAS_HIDDEN. This looks wrong, there are more

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-06-09 Thread Mike Stump
On Jun 9, 2011, at 12:14 AM, Rainer Orth wrote: Mike Stump mikest...@comcast.net writes: On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: * lto.c (promote_var): Only set VISIBILITY_HIDDEN if HAVE_GAS_HIDDEN. This looks wrong, there are more things that have visibility than those things

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-21 Thread Rainer Orth
Mike, [Could you please configure your mail client to break lines? It's hard to reply to messages all on a single line. Thanks.] On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote: I've had a closer look now and think it's possible (and desirable) to define HAVE_GAS_HIDDEN for Darwin, too.

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-19 Thread Mike Stump
On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote: I've had a closer look now and think it's possible (and desirable) to define HAVE_GAS_HIDDEN for Darwin, too. But, they don't have the same thing, therefore, either, you loose out on the meaning, or, you must have yet another test that means the

[lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Rainer Orth
As described in the PR, it seems to make more sense to avoid to use the visibility attribute on targets that don't support it rather than using it unconditionally and later (and incompletely) prune the resulting warning. The following patch does exactly that. It now needs to document the

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Richard Guenther
On Tue, 5 Apr 2011, Rainer Orth wrote: As described in the PR, it seems to make more sense to avoid to use the visibility attribute on targets that don't support it rather than using it unconditionally and later (and incompletely) prune the resulting warning. The following patch does

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Mike Stump
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: * lto.c (promote_var): Only set VISIBILITY_HIDDEN if HAVE_GAS_HIDDEN. Oh, at a minimum, if TARGET_ASM_ASSEMBLE_VISIBILITY is set, doing this stuff I think is useful?

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Rainer Orth
Mike Stump mikest...@comcast.net writes: On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: * lto.c (promote_var): Only set VISIBILITY_HIDDEN if HAVE_GAS_HIDDEN. Oh, at a minimum, if TARGET_ASM_ASSEMBLE_VISIBILITY is set, doing this stuff I think is useful? No, this won't work.