Mike Stump mikest...@comcast.net writes:
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
* lto.c (promote_var): Only set VISIBILITY_HIDDEN if
HAVE_GAS_HIDDEN.
This looks wrong, there are more things that have visibility than those
things that use GAS and have .hidden. Darwin I think
On Thu, Jun 9, 2011 at 9:14 AM, Rainer Orth r...@cebitec.uni-bielefeld.de
wrote:
Mike Stump mikest...@comcast.net writes:
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
* lto.c (promote_var): Only set VISIBILITY_HIDDEN if
HAVE_GAS_HIDDEN.
This looks wrong, there are more things that
On Thu, Jun 9, 2011 at 9:14 AM, Rainer Orth r...@cebitec.uni-bielefeld.de
wrote:
Mike Stump mikest...@comcast.net writes:
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
* lto.c (promote_var): Only set VISIBILITY_HIDDEN if
HAVE_GAS_HIDDEN.
This looks wrong, there are more
On Jun 9, 2011, at 12:14 AM, Rainer Orth wrote:
Mike Stump mikest...@comcast.net writes:
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
* lto.c (promote_var): Only set VISIBILITY_HIDDEN if
HAVE_GAS_HIDDEN.
This looks wrong, there are more things that have visibility than those
things
Mike,
[Could you please configure your mail client to break lines? It's hard
to reply to messages all on a single line. Thanks.]
On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote:
I've had a closer look now and think it's possible (and desirable) to
define HAVE_GAS_HIDDEN for Darwin, too.
On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote:
I've had a closer look now and think it's possible (and desirable) to
define HAVE_GAS_HIDDEN for Darwin, too.
But, they don't have the same thing, therefore, either, you loose out on the
meaning, or, you must have yet another test that means the
As described in the PR, it seems to make more sense to avoid to use the
visibility attribute on targets that don't support it rather than using
it unconditionally and later (and incompletely) prune the resulting
warning.
The following patch does exactly that. It now needs to document the
On Tue, 5 Apr 2011, Rainer Orth wrote:
As described in the PR, it seems to make more sense to avoid to use the
visibility attribute on targets that don't support it rather than using
it unconditionally and later (and incompletely) prune the resulting
warning.
The following patch does
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
* lto.c (promote_var): Only set VISIBILITY_HIDDEN if
HAVE_GAS_HIDDEN.
Oh, at a minimum, if TARGET_ASM_ASSEMBLE_VISIBILITY is set, doing this stuff I
think is useful?
Mike Stump mikest...@comcast.net writes:
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
* lto.c (promote_var): Only set VISIBILITY_HIDDEN if
HAVE_GAS_HIDDEN.
Oh, at a minimum, if TARGET_ASM_ASSEMBLE_VISIBILITY is set, doing this stuff
I think is useful?
No, this won't work.
10 matches
Mail list logo