Re: Improve DSE in the presence of calls

2011-06-20 Thread Richard Guenther
On Sat, Jun 18, 2011 at 9:03 PM, Easwaran Raman era...@google.com wrote: The gimple for test2_31 before RTL expansion contains:  # .MEMD.2034_2 = VDEF .MEMD.2034_1(D)  s1D.2035 = s1D.1255; The RHS is a PARM_DECL. It doesn't have TREE_ADDRESSABLE and the LHS has, which makes sense. But then

Re: Improve DSE in the presence of calls

2011-06-18 Thread Ramana Radhakrishnan
This seems to have triggered http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49452 on arm-linux-gnueabi Might well be a DUP of PR49429 but I haven't looked at it yet. cheers Ramana

Re: Improve DSE in the presence of calls

2011-06-17 Thread Easwaran Raman
This patch seems to break ia64 and some other targets. I have updated Bug 49429 with a test case triage. It looks like for some EXPR, may_be_aliased returns incorrect value and hence can_escape incorrectly concludes the variable can't escape resulting in removal of useful stores. (So

Re: Improve DSE in the presence of calls

2011-06-14 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/10/11 13:18, Easwaran Raman wrote: I am not sure I understand the problem here. If there is a wild read from asm, the instruction has the wild_read flag set. The if statement checks if that flag is set and if so it clears the bitmap - which

Re: Ping: Re: Improve DSE in the presence of calls

2011-06-07 Thread Easwaran Raman
Ping. Diego, David, Is this patch OK for google/main? -Easwaran On Thu, Jun 2, 2011 at 4:48 PM, Easwaran Raman era...@google.com wrote: Ping. On Sat, May 14, 2011 at 8:01 AM, Easwaran Raman era...@google.com wrote: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00781.html

Re: Ping: Re: Improve DSE in the presence of calls

2011-06-02 Thread Easwaran Raman
Ping. On Sat, May 14, 2011 at 8:01 AM, Easwaran Raman era...@google.com wrote: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00781.html

Re: Ping: Re: Improve DSE in the presence of calls

2011-05-20 Thread Easwaran Raman
Ping. On Sat, May 14, 2011 at 8:01 AM, Easwaran Raman era...@google.com wrote: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00781.html

Ping: Re: Improve DSE in the presence of calls

2011-05-14 Thread Easwaran Raman
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00781.html

Re: Improve DSE in the presence of calls

2011-05-10 Thread Easwaran Raman
On Tue, May 3, 2011 at 9:40 AM, Easwaran Raman era...@google.com wrote: On Mon, May 2, 2011 at 8:37 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/11 16:06, Easwaran Raman wrote: You're right. The patch has correctness issues. It is not possible

Re: Improve DSE in the presence of calls

2011-05-03 Thread Richard Guenther
On Tue, May 3, 2011 at 5:37 AM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/11 16:06, Easwaran Raman wrote: You're right. The patch has correctness issues. It is not possible to simply not call add_wild_read because it also resets

Re: Improve DSE in the presence of calls

2011-05-03 Thread Easwaran Raman
On Mon, May 2, 2011 at 8:37 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/11 16:06, Easwaran Raman wrote: You're right. The patch has correctness issues. It is not possible to simply not call add_wild_read because it also resets

Re: Improve DSE in the presence of calls

2011-04-26 Thread Easwaran Raman
On Mon, Apr 25, 2011 at 10:03 AM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/22/11 14:19, Easwaran Raman wrote: Hi,  This patch improves RTL DSE by not assuming that calls read all memory locations. With this patch, calls are assumed to read any

Re: Improve DSE in the presence of calls

2011-04-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/22/11 14:19, Easwaran Raman wrote: Hi, This patch improves RTL DSE by not assuming that calls read all memory locations. With this patch, calls are assumed to read any non-frame memory and any stack variables that can potentially escape.

Improve DSE in the presence of calls

2011-04-22 Thread Easwaran Raman
Hi, This patch improves RTL DSE by not assuming that calls read all memory locations. With this patch, calls are assumed to read any non-frame memory and any stack variables that can potentially escape. This patch partly addresses PR rtl-optimization/44194. Bootstraps and no test regressions. OK

Re: Improve DSE in the presence of calls

2011-04-22 Thread Jakub Jelinek
On Fri, Apr 22, 2011 at 01:19:17PM -0700, Easwaran Raman wrote: The ChangeLog entry has various issues: 2011-04-22 Easwaran Raman era...@google.com PR rtl-optimization/44194 This should have tab before PR as well. * dse.c (header files): Include tree-flow.h. This should be just

Re: Improve DSE in the presence of calls

2011-04-22 Thread Easwaran Raman
On Fri, Apr 22, 2011 at 1:26 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Apr 22, 2011 at 01:19:17PM -0700, Easwaran Raman wrote: The ChangeLog entry has various issues: 2011-04-22  Easwaran Raman  era...@google.com PR rtl-optimization/44194 This should have tab before PR as well.