Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Eager
David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers jos...@codesourcery.com wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was intended. I added comments to make the semantics explicit. Given the

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 10:08:24AM -0700, Michael Eager wrote: David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers jos...@codesourcery.com wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Joseph S. Myers
On Thu, 5 May 2011, Michael Eager wrote: David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers jos...@codesourcery.com wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was intended. I added

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 03:08:43PM -0400, Michael Meissner wrote: Yes, it was an error on my part. Sorry. I will fix the GCC 4.6 branch. I will hold off fixing the on trunk, on the assumption this patch will go in. I can fix it if desired. I committed the following patch on the GCC 4.6

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Alan Modra
On Thu, May 05, 2011 at 11:29:13AM -0400, David Edelsohn wrote: Alan, is mcmodel suppose to set m64? No, that was an accident. -- Alan Modra Australia Development Lab, IBM

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread David Edelsohn
On Thu, May 5, 2011 at 3:34 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Thu, 5 May 2011, Michael Eager wrote: David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers jos...@codesourcery.com wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to

rs6000_handle_option global state avoidance, part 1

2011-05-04 Thread Joseph S. Myers
This patch implements the simpler parts of stopping rs6000_handle_option from using global state. Many options are converted to use .opt features such as Var and Enum, replacing explicit code, while other code is changed to use the opts and opts_set pointers. -mabi=, -mcpu= and -mtune= will be