Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Jakub Jelinek
On Thu, May 24, 2012 at 09:43:42AM -0700, Lawrence Crowl wrote: Add a type-safe hash table, typed_htab. Uses of this table replace uses of libiberty's htab_t. The benefits include less boiler-plate code, full type safety, and improved performance. You haven't looked at the most important

Re: PATCH: PR bootstrap/53472: contrib/compare-debug should strip out .comment section

2012-05-25 Thread Paolo Bonzini
2012-05-24  H.J. Lu  hongjiu...@intel.com        PR bootstrap/53472        * contrib/compare-debug (remove_comment): New function.        Remove any .comment sections if the first cmp failed. Ok. Paolo diff --git a/contrib/compare-debug b/contrib/compare-debug index 010d17f..fb8986d

Re: [patch] Fix PR ada/52362

2012-05-25 Thread Eric Botcazou
Paolo, The fix is mainly in the Ada tools, but there is a hitch: when you pass a response file to the linker by means of the -Wl,@ option, it is intercepted by collect2. And collect2 creates another response file for the linker proper only if HAVE_GNU_LD is set to 1. Now HAVE_GNU_LD is set

Re: [patch] Fix PR ada/52362

2012-05-25 Thread Paolo Bonzini
Il 18/05/2012 23:05, Eric Botcazou ha scritto: Hi, this is a regression present on mainline and 4.7 branch or, more precisely, if you use recent GNU linkers with LTO plugin. During the link phase, gnatlink can decide to use a response file to pass a very long line to the linker. It

Re: use longcall to abort from !pic trampoline setup on ppc-vxworks

2012-05-25 Thread Olivier Hainque
Hello David, On May 25, 2012, at 03:25 , David Edelsohn wrote: libgcc/ * config/rs6000/vxworks/tramp.S (trampoline_setup): Use a longcall sequence in the non pic case on VxWorks. + addis 11, 0,JUMP_TARGET(abort)@ha Why do you use the addis mnemonic instead of

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Dodji Seketeli
Tom Tromey tro...@redhat.com writes: Dodji == Dodji Seketeli do...@redhat.com writes: I didn't see a gcc-patches CC...? Woops, indeed. Sorry. I have just bounced the original messages to the list now. Dodji When building the compiler on altivec, it appears that an unused local Dodji

[Dodji Seketeli] [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Dodji Seketeli
I initially forgot to add the gcc-patches list in CC, and tried unsuccessfully to bounce the message to the list. I am thus forwarding it now. ---BeginMessage--- Hello, When building the compiler on altivec, it appears that an unused local typedef is lurking in a function of libcpp, breaking

Re: [Patch]: Fix very large frame bug on i386

2012-05-25 Thread Tristan Gingold
On May 22, 2012, at 7:17 PM, Richard Henderson wrote: On 05/15/12 02:10, Tristan Gingold wrote: 2012-05-15 Tristan Gingold ging...@adacore.com * config/i386/i386.c (struct ix86_frame): Remove unused frame field. (ix86_compute_frame_layout): Fix type of stack_alignment_needed

Re: [Patch]: Fix typo in common/config/ia64/ia64-common.c

2012-05-25 Thread Tristan Gingold
On May 22, 2012, at 7:17 PM, Richard Henderson wrote: On 05/15/12 01:52, Tristan Gingold wrote: 2012-05-14 Tristan Gingold ging...@adacore.com * common/config/ia64/ia64-common.c (ia64_except_unwind_info): Fix typo. Ok. Thanks, committed. Tristan.

ping: fix mem+32760 ICE on powerpc - introduce predicates weaker than mode_dependent_address_p

2012-05-25 Thread Olivier Hainque
Hello, Ping for the non-back-end parts of http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01668.html David approved the rs6000 parts already (with adjustments to comments, http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00368.html) Thanks much in advance for your feedback, Olivier On Apr 26, 2012,

[Patch ARM 4_7-branch ] Backport fix for flto failure with neon intrinsics.

2012-05-25 Thread Ramana Radhakrishnan
Hi, We hit an ICE using lto with neon intrinsics that could be traced back to an invalid call to convert during expand with LTO . Fixed by backporting Richi's fix from mainline - checking he had no objections to this on IRC , tested cross on arm-linux-gnueabi with qemu for no regressions.

Re: divide 64-bit by constant for 32-bit target machines

2012-05-25 Thread Dinar Temirbulatov
Hi, I have replaced expand_mult to expand_widening_mult and removed all direct references to DImode, SImode modes in the expand_mult_highpart_optab funtion. The attached patch was tested on arm-7l, mips-32r2 (74k), i686 without new regressions. Richard, do you think it is ready now?

[patch] Fix PR lto/52178 (continued)

2012-05-25 Thread Eric Botcazou
This is a follow-up to PR lto/52178: there are more type mismatch in component reference issues related to variably_modified_type_p when you try to build the gnattools with -flto: 1. Instances of a record type with fixed size at top level aren't merged if it has a field with

Re: [patch] Fix PR lto/52178 (continued)

2012-05-25 Thread Richard Guenther
On Fri, May 25, 2012 at 12:27 PM, Eric Botcazou ebotca...@adacore.com wrote: This is a follow-up to PR lto/52178: there are more type mismatch in component reference issues related to variably_modified_type_p when you try to build the gnattools with -flto:  1. Instances of a record type

[AARCH64] [PATCH 0/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
ARM is pleased to announce a port of GCC to its AArch64 architecture. Please note that while the compiler has been used to build a large body of software, it cannot yet be considered complete. We expect there to be a number of as yet undiscovered bugs and other issues that will need to be

[AARCH64] [PATCH 3/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
This patch adds an implementation of integer iterators. Index: gcc/ChangeLog.aarch64 * read-rtl.c (rtx_list): New data structure. (int_iterator_mapping): New data structure. (int_iterator_data): New. List of int iterator details. (num_int_iterator_data): New.

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 12:19:01PM +0100, Marcus Shawcroft wrote: ... * config/aarch64/aarch64-simd.md: New file. ... * config/aarch64/iterators.md: New file. With the above in the same ChangeLog entry * config/aarch64/aarch64-simd.md (reduc_smax_v4sf,

Re: [libgo] Fix IRIX bootstrap failure

2012-05-25 Thread Rainer Orth
Hi Ian, Thanks. I committed the patch to mainline and 4.7 branch. Thanks. Testsuite results are still terrible since many tests timeout (with timeout doubled to 600s to account for the slow 250 MHz MIPS R10k CPUs on my test machine), and others not even hitting the timeout at all:

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
On 25/05/12 12:27, Jakub Jelinek wrote: On Fri, May 25, 2012 at 12:19:01PM +0100, Marcus Shawcroft wrote: ... * config/aarch64/aarch64-simd.md: New file. ... * config/aarch64/iterators.md: New file. With the above in the same ChangeLog entry *

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 1:25 AM, Jakub Jelinek ja...@redhat.com wrote: Static functions are also not acceptable as template arguments, so this patch externalizes the functions.  To avoid potential name conflicts, the function names have been prefixed. Ugh.  I guess the C++ way around this

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Thu, May 24, 2012 at 4:55 PM, Diego Novillo dnovi...@google.com wrote: On 12-05-24 17:52 , Lawrence Crowl wrote: That said, I'll let y'all decide how much to put in any one piece. I favour the approach we are taking now.  Each patch to cxx-conversion is a small incremental step. When

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Jakub Jelinek wrote: + /* Return the current size of this hash table. */ + + size_t size() + { +return htab-size; + } (and various other places) - formatting is wrong, missing space between (. And it doesn't start at the first column, and type

Re: RFC: PATCH to correct the scopes of various types

2012-05-25 Thread H.J. Lu
On Wed, May 2, 2012 at 1:08 PM, Jason Merrill ja...@redhat.com wrote: I've been working on a patch to split out the DWARF debug info for COMDAT functions into COMDAT CUs to go in the same group.  One problem I ran into was that modified versions of function-local types (pointers, cv-qualified

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Dominique Dhumieres
Alternatively you could put the static assertion with the comment into the l field, i.e. /* Statically assert that N is 2 or 4. */ unsigned long l[(N == 2 || N == 4) ? N : -1]; I certainly prefer this alternative (the use of extern for that purpose being extremely confusing

[PATCH] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jack Howarth
The attached patch solves PR53453. The upcoming dsymutil release will now issue a warning when no debug notes are emitted for an object file on linkage. This causes several thousand failures in the FSF gcc testsuite. The origin of this problem is that the darwin linker requires the presence

[PATCH] omit -lcrt1.10.6.o and pass -no_new_main with -pg on darwin = 10.8

2012-05-25 Thread Jack Howarth
The attached patch limits the linkage of -lcrt1.10.6.o to darwin10 and darwin11 since its usage is deprecated in the 10.8sdk. The patch also solves radr://11491405, -pg broken for -mmacosx-version-min=10.8... 19-May-2012 11:10 PM Jack Howarth: Summary: The default -mmacosx-version-min=10.8

Re: [PATCH] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 09:03:02AM -0400, Jack Howarth wrote: DEFHOOKPOD +(force_at_comp_dir, + True if the @code{AT_comp_dir} attribute should be emitted for each \ It is DW_AT_comp_dir, so at least the comment should get it right. Jakub

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 1:19 PM, Marcus Shawcroft marcus.shawcr...@arm.com wrote: This patch adds an implementation of integer iterators. Index: gcc/ChangeLog.aarch64        * read-rtl.c (rtx_list): New data structure.        (int_iterator_mapping): New data structure.        

[PATCH][revised] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jack Howarth
The attached patch solves PR53453. The upcoming dsymutil release will now issue a warning when no debug notes are emitted for an object file on linkage. This causes several thousand failures in the FSF gcc testsuite. The origin of this problem is that the darwin linker requires the presence

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 1:19 PM, Marcus Shawcroft marcus.shawcr...@arm.com wrote:        * config/aarch64/aarch64.md: New file. Index: gcc/config/aarch64/aarch64.md === --- gcc/config/aarch64/aarch64.md (revision 0) +++

PR middle-end/53008 (trans-mem): output clone if function accessed indirectly

2012-05-25 Thread Aldy Hernandez
This is a patch from Patrick, based on an earlier patch by Dave Boutcher. Thanks folks. In the failing testcase below we have a transaction_safe function being accessed indirectly, but for -O1 and above, the corresponding clone is not generated because we think it is unused. Fixed by

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 7:17 AM, Michael Matz m...@suse.de wrote: Hi, On Fri, 25 May 2012, Jakub Jelinek wrote: +  /* Return the current size of this hash table.  */ + +  size_t size() +  { +    return htab-size; +  } (and various other places) - formatting is wrong, missing

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Gabriel Dos Reis wrote: (and various other places) - formatting is wrong, missing space between (. And it doesn't start at the first column, and type isn't on a separate line.  I realize that this is a member method, hence indenting and C GNU coding

Re: PATCH: PR target/53383: Allow -mpreferred-stack-boundary=3 on x86-64

2012-05-25 Thread H.J. Lu
On Sun, May 20, 2012 at 7:47 AM, H.J. Lu hongjiu...@intel.com wrote: Hi, This patch allows -mpreferred-stack-boundary=3 on x86-64 when SSE is disabled.  Since this option changes ABI, I also added a warning for -mpreferred-stack-boundary=3.  OK for trunk? Thanks. H.J.        PR

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 3:51 PM, Michael Matz m...@suse.de wrote: Hi, On Fri, 25 May 2012, Gabriel Dos Reis wrote: (and various other places) - formatting is wrong, missing space between (. And it doesn't start at the first column, and type isn't on a separate line.  I realize that

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: On Fri, 25 May 2012, Gabriel Dos Reis wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base. Because IMHO the libstdc++ style isn't very appealing. Seconded.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Steven Bosscher wrote: Note also the almost 2 decades of C++ style practice in our libstdc++ implementation. That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base.  Because IMHO the libstdc++ style

Re: [RFA PATCH, i386]: Fix gcc.target/i386/pr53249.c on Sun targets

2012-05-25 Thread Rainer Orth
Hi Uros, Currently gcc fails to compile following test from the testsuite [1]: FAIL: gcc.target/i386/pr53249.c (test for excess errors) We are trying to compile X32 specific test, but the special pattern that was introduced to handle certain sun assembler limitation, is not prepared to

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Diego Novillo
On 12-05-25 09:56 , Jakub Jelinek wrote: On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: On Fri, 25 May 2012, Gabriel Dos Reis wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base. Because IMHO the libstdc++ style

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Joseph S. Myers
General question: I suppose you expect to submit patches soon for other toolchain components (such as binutils, GDB, glibc) and the Linux kernel, if you haven't done so yet? Index: config.guess === --- config.guess (revision

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 8:57 AM, Michael Matz m...@suse.de wrote: Hi, On Fri, 25 May 2012, Steven Bosscher wrote: Note also the almost 2 decades of C++ style practice in our libstdc++ implementation. That's one of my fears, namely that those used to the libstdc++ style impose that on

Re: [PATCH] Add powerpc64-linux configuration options

2012-05-25 Thread Michael Meissner
On Thu, May 24, 2012 at 07:11:53PM -0400, David Edelsohn wrote: On Wed, May 23, 2012 at 6:36 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: On powerpc64-linux systems that run on IBM servers, the 32-bit software emulation library is not built with the Red Hat and SUSE distributions,

Re: [AARCH64] [PATCH 2/3] AArch64 Port

2012-05-25 Thread Joseph S. Myers
On Fri, 25 May 2012, Marcus Shawcroft wrote: Index: gcc/testsuite/gcc.target/aarch64/aapcs64/func-ret-4.x === --- gcc/testsuite/gcc.target/aarch64/aapcs64/func-ret-4.x (revision 0) +++

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 9:15 AM, Diego Novillo dnovi...@google.com wrote: I don't care how ugly coding conventions look.  I've dealt with many and they all have their ugly spots.  I mostly care about consistency. Agreed that consistency is very important. (At at single time in a week, I deal

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 10:15:54AM -0400, Diego Novillo wrote: Lawrence, Ian and Gaby have been working on the proposed coding guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). That page is quite inconsistent. E.g. it first talks about retaining space before ( (which I really hope

Re: [PATCH] pr51020 Fix invalid options validation for ARM target

2012-05-25 Thread Alexey Kravets
Hi guys, This issue has not been fixed in latest Linaro release (4.6.2012.04) yet. Can you suggest whether this patch is a correct fix for the pr51020. If so, should it be applied to the corresponding gcc branch? On Tue, May 01, 2012 at 11:21:28PM +0400, Alexey Kravets wrote: On Mon, Apr 30,

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Joseph S. Myers
On Fri, 25 May 2012, Diego Novillo wrote: I don't care how ugly coding conventions look. I've dealt with many and they all have their ugly spots. I mostly care about consistency. I don't think we should deviate much from the established GNU standards (which are hideous, btw). Mostly

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Bernd Schmidt
On 05/25/2012 04:15 PM, Diego Novillo wrote: On 12-05-25 09:56 , Jakub Jelinek wrote: On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: On Fri, 25 May 2012, Gabriel Dos Reis wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler

unwind.h installation causes rebuilds

2012-05-25 Thread Michael Matz
Hi, I've noticed that libitm is always rebuild with a non-bootstrap tree even with merely a sequence of two makes. The reason turns out to be that installation of unwind.h from libgcc, which is always done with a simple make: # make # make -d ... dest=../.././gcc/include/tmp$$-unwind.h; \

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Paolo Carlini
Hi, On Fri, May 25, 2012 at 7:17 AM, Michael Matz m...@suse.de wrote: Hi, On Fri, 25 May 2012, Jakub Jelinek wrote: + /* Return the current size of this hash table. */ + + size_t size() + { +return htab-size; + } (and various other places) - formatting is wrong, missing

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-25 Thread Christophe Lyon
On 21.05.2012 11:16, Christophe Lyon wrote: I tried applying your patch but ran into trouble with patch not liking this . My suspicion is mailer munging white spaces in some form - Could you send the patch as an attachment please rather than inline in your mail ? regards, Ramana Here it is,

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Olivier Hainque
Hello Michael, On May 25, 2012, at 16:30 , Michael Matz wrote: I've noticed that libitm is always rebuild with a non-bootstrap tree even with merely a sequence of two makes. The reason turns out to be that installation of unwind.h from libgcc, which is always done with a simple make:

[gimplefe] Fix parsing of assign_stmt (issue6247046)

2012-05-25 Thread Diego Novillo
: * gimple.dg/20120523-1.gimple: Add expected error. * gimple.dg/20120525-1.gimple: New. diff --git a/gcc/gimple/parser.c b/gcc/gimple/parser.c index 4b29333..3f3eb96 100644 --- a/gcc/gimple/parser.c +++ b/gcc/gimple/parser.c @@ -152,10 +152,10 @@ gl_token_as_text (const

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Diego Novillo wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base. Because IMHO the libstdc++ style isn't very appealing. Seconded. I don't care how ugly coding conventions look. Perhaps

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Diego Novillo
On 12-05-25 11:06 , Michael Matz wrote: Hi, On Fri, 25 May 2012, Diego Novillo wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base. Because IMHO the libstdc++ style isn't very appealing. Seconded. I don't care how ugly

[PATCH, i386]: Fix PR 53474, Solaris/x86 bootstrap with Sun as broken: j.e

2012-05-25 Thread Uros Bizjak
Hello! 2012-05-25 Uros Bizjak ubiz...@gmail.com PR target/53474 * config/i386/i386.c (ix86_print_operand) case 'O': Print '.' here. case 'C', case 'c', case 'F', case 'f': Print '.' only for C and c. Tested on i386-pc-solaris2.10 by Rainer, and on x86_64-pc-linux-gnu

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Olivier Hainque wrote: I've noticed that libitm is always rebuild with a non-bootstrap tree even with merely a sequence of two makes. The reason turns out to be that installation of unwind.h from libgcc, which is always done with a simple make: This should

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Olivier Hainque
On May 25, 2012, at 17:17 , Michael Matz wrote: This should have been fixed by rev 187839 ... Super, yes, that works. Great :) Though I still wonder if the whole copy-over-to-gcc business shouldn't be dependend on anything newly built. I can't see the use in copying over the same

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread NightStrike
On Fri, May 25, 2012 at 11:07 AM, Diego Novillo dnovi...@google.com wrote: On 12-05-25 11:06 , Michael Matz wrote: Hi, On Fri, 25 May 2012, Diego Novillo wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base.  Because IMHO the

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 9:33 AM, Paolo Carlini pcarl...@gmail.com wrote: Hi, On Fri, May 25, 2012 at 7:17 AM, Michael Matz m...@suse.de wrote: Hi, On Fri, 25 May 2012, Jakub Jelinek wrote: +  /* Return the current size of this hash table.  */ + +  size_t size() +  { +    return

Re: PR middle-end/53008 (trans-mem): output clone if function accessed indirectly

2012-05-25 Thread Richard Henderson
On 05/25/2012 06:25 AM, Aldy Hernandez wrote: OK? Would this be acceptable for the 4.7 branch as well? curr PR middle-end/53008 * trans-mem.c (ipa_tm_create_version_alias): Output new_node if accessed indirectly. (ipa_tm_create_version): Same. Ok everywhere.

Re: [PATCH, c++]: Fix PR 53441, [4.8 Regression] obj-c++.dg/ivar-invalid-type-1.mm ICE

2012-05-25 Thread Dodji Seketeli
Uros Bizjak ubiz...@gmail.com a écrit: As shown in the PR, ivar-invalid-type-1 ICEs in constructor_name_p, due to accessor on NULL type argument. The one-liner patch fixes the ICE by adding a guard that checks that current_class_type is non-NULL before calling constructor_name_p.

Re: [PATCH, c++]: Fix PR 53441, [4.8 Regression] obj-c++.dg/ivar-invalid-type-1.mm ICE

2012-05-25 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 32054

2012-05-25 Thread Jason Merrill
On 05/24/2012 10:57 PM, Paolo Carlini wrote: + error_at (decl_spec_token_start-location, + a storage class is not allowed); Let's give more explanation here so that the user knows that the problem is a storage class on an anonymous union/struct in class

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Jason Merrill
On 05/25/2012 08:46 AM, Dominique Dhumieres wrote: I certainly prefer this alternative (the use of extern for that purpose being extremely confusing for a fortraner;-). However, if my test is valid, if N is not equal to 2 or 4, one gets the following error error: size of array 'l' is negative

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 11:44 AM, Paweł Sikora pl...@agmk.net wrote: so, why you just don't use the hash table implementation from libstdc++? we have agreed on C++03 as a bootstrap compiler. There is unfortunately no hash table in C++03. The page about not defining a new template was just

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread NightStrike
On Fri, May 25, 2012 at 12:50 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Fri, May 25, 2012 at 11:44 AM, Paweł Sikora pl...@agmk.net wrote: so, why you just don't use the hash table implementation from libstdc++? we have agreed on C++03 as a bootstrap compiler. There is

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Paweł Sikora
On Friday 25 of May 2012 11:50:13 Gabriel Dos Reis wrote: On Fri, May 25, 2012 at 11:44 AM, Paweł Sikora pl...@agmk.net wrote: so, why you just don't use the hash table implementation from libstdc++? we have agreed on C++03 as a bootstrap compiler. There is unfortunately no hash table in

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Diego Novillo dnovi...@google.com wrote: Lawrence, Ian and Gaby have been working on the proposed coding guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). Lawrence, have you had a chance to update them with your latest edits? Not yet; they're on the desk in front of me.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Paweł Sikora pl...@agmk.net wrote: On Friday 25 of May 2012 10:15:54 Diego Novillo wrote: Lawrence, Ian and Gaby have been working on the proposed coding guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). on this page we can read: The following features of the C++

Re: Turn check macros into functions. (issue6188088)

2012-05-25 Thread Tom Tromey
Lawrence == Lawrence Crowl cr...@google.com writes: Lawrence Should I add that to my patch to gdbinit.in? I think it would be helpful. Tom

Re: Turn check macros into functions. (issue6188088)

2012-05-25 Thread Tom Tromey
Mike == Mike Stump mikest...@comcast.net writes: Mike Yeah, I kinda think the gdb people are wimping out by not just Mike implementing __extension__ and ({}), which, I think get us most of the Mike way there. Shh, don't tell them I said that. We eagerly await your patch. Tom

libgo patch committed: Fix cast error

2012-05-25 Thread Ian Lance Taylor
This patch to libgo fixes a cast error in the new file print.c that shows up on 32-bit systems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian diff -r ae91b408310f libgo/runtime/print.c --- a/libgo/runtime/print.c Thu May 24 14:06:08

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Tom Tromey
Diego == Diego Novillo dnovi...@google.com writes: Diego +struct GTY(()) vec_prefix Diego +{ Diego + unsigned num; Diego + unsigned alloc; Diego +}; Diego + Diego +/* Vector type, user visible. */ Diego +templatetypename T Diego +struct GTY(()) vec_t Diego +{ Diego + vec_prefix prefix; Diego

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 1:27 PM, Tom Tromey tro...@redhat.com wrote: Diego == Diego Novillo dnovi...@google.com writes: Diego +struct GTY(()) vec_prefix Diego +{ Diego +  unsigned num; Diego +  unsigned alloc; Diego +}; Diego + Diego +/* Vector type, user visible.  */ Diego

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Mike Stump
On May 25, 2012, at 10:50 AM, Lawrence Crowl wrote: Diego and I looked long and hard at this issue. It all came down to a sequence of problems. First, libstdc++ isn't rigged for GTY, If portability to other C++ compilers wasn't a concern, we could extend out g++ to make supporting GTY

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Mike Stump
On May 25, 2012, at 7:29 AM, Bernd Schmidt wrote: Can emacs handle the indentation rules automatically? I hope that any style picked, will have a no local mods required for emacs as the corner stone. One thing I hate about .md files, is they don't (last I checked) fulfill this requirement.

Re: [PATCH] omit -lcrt1.10.6.o and pass -no_new_main with -pg on darwin = 10.8

2012-05-25 Thread Mike Stump
On May 25, 2012, at 6:06 AM, Jack Howarth wrote: The attached patch limits the linkage of -lcrt1.10.6.o to darwin10 and darwin11 since its usage is deprecated in the 10.8sdk. Ok.

Re: [PATCH] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Mike Stump
On May 25, 2012, at 6:03 AM, Jack Howarth wrote: The attached patch solves PR53453. Darwin bits are Ok.

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Pedro Alves
On 05/25/2012 05:27 PM, Jason Merrill wrote: On 05/25/2012 08:46 AM, Dominique Dhumieres wrote: I certainly prefer this alternative (the use of extern for that purpose being extremely confusing for a fortraner;-). However, if my test is valid, if N is not equal to 2 or 4, one gets the

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
On 25/05/12 15:18, Joseph S. Myers wrote: General question: I suppose you expect to submit patches soon for other toolchain components (such as binutils, GDB, glibc) and the Linux kernel, if you haven't done so yet? There is work going on to get other components ready for community review. I

Re: [PATCH] Add powerpc64-linux configuration options

2012-05-25 Thread David Edelsohn
On Fri, May 25, 2012 at 10:22 AM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: Yes, the second patch just does not build the library or use the -mstrict-align option.  It is much simpler, but there may be somebody out there that depends on the functionality.  I really don't know, one

Re: [PATCH][revised] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jason Merrill
OK. Jason

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Joseph S. Myers
On Fri, 25 May 2012, Marcus Shawcroft wrote: We have a long list of intrinsics which we want to move into RTL, only some of these have been moved so far. However, that said, point noted that we can usefully exploit TARGET_FOLD_BUILTIN in preference to RTL. I think the order of preference is

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Diego Novillo
On 12-05-25 14:27 , Tom Tromey wrote: Diego == Diego Novillodnovi...@google.com writes: Diego +struct GTY(()) vec_prefix Diego +{ Diego + unsigned num; Diego + unsigned alloc; Diego +}; Diego + Diego +/* Vector type, user visible. */ Diego +templatetypename T Diego +struct GTY(())

Re: [patch] Fix PR lto/52178 (continued)

2012-05-25 Thread Eric Botcazou
Ok. Please make sure to verify LTO bootstrap on the branch still works after this. Thanks. I already verified it with --enable-checking=yes,rtl. -- Eric Botcazou

libgcc patch committed: Fix for -fsplit-stack when using gold

2012-05-25 Thread Ian Lance Taylor
When using the gold linker, the linker will adjust the split-stack prologue to call __morestack_non_split if it sees that the function calls a different function compiled without -fsplit-stack. The __morestack_non_split function has an optimization I committed 2011-12-20 to avoid splitting the

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Michael Matz m...@suse.de wrote: On Fri, 25 May 2012, Jakub Jelinek wrote: + /* Return the current size of this hash table. */ + + size_t size() + { +return htab-size; + } (and various other places) - formatting is wrong, missing space between (. Yes,

Go patch committed: Don't create a closure if not needed

2012-05-25 Thread Ian Lance Taylor
This patch to the Go frontend changes it to not produce a closure for an embedded function if one is not needed. Earlier, when Go permitted comparisons of function types, it was necessary to always create a closure for an embedded function, so that each embedded function would be reliably

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Jakub Jelinek ja...@redhat.com wrote: On Fri, May 25, 2012 at 10:15:54AM -0400, Diego Novillo wrote: Lawrence, Ian and Gaby have been working on the proposed coding guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). That page is quite inconsistent. E.g. it first talks

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/24/12, Jakub Jelinek ja...@redhat.com wrote: On Thu, May 24, 2012 at 09:43:42AM -0700, Lawrence Crowl wrote: Add a type-safe hash table, typed_htab. Uses of this table replace uses of libiberty's htab_t. The benefits include less boiler-plate code, full type safety, and improved

libgo patch committed: More efficient trampoline allocation

2012-05-25 Thread Ian Lance Taylor
This patch to libgo makes the implementation of function trampolines, used for nested functions that refer to variables in an enclosing function scope, much more efficient. Previously we were allocating a separate page for each trampoline. This patch packs them on a single page as much as

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Mike Stump mikest...@comcast.net wrote: On May 25, 2012, at 10:50 AM, Lawrence Crowl wrote: Diego and I looked long and hard at this issue. It all came down to a sequence of problems. First, libstdc++ isn't rigged for GTY, If portability to other C++ compilers wasn't a

[google/gcc-4_6] Fix -gfission ICEs with pubnames and .debug_addr table (issue6254054)

2012-05-25 Thread Cary Coutant
This patch is for the google/gcc-4_6 branch. It fixes a problem where we were still trying to output entries in the .debug_addr table for location lists that were removed, and fixes a problem where we were getting an ICE while trying to output a pubname for a member function of a struct. Tested

Re: [C++ Patch] PR 32054

2012-05-25 Thread Paolo Carlini
Hi, On 05/25/2012 06:25 PM, Jason Merrill wrote: On 05/24/2012 10:57 PM, Paolo Carlini wrote: +error_at (decl_spec_token_start-location, + a storage class is not allowed); Let's give more explanation here so that the user knows that the problem is a storage class on an

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 4:16 PM, Lawrence Crowl cr...@google.com wrote: On 5/25/12, Jakub Jelinek ja...@redhat.com wrote: On Fri, May 25, 2012 at 10:15:54AM -0400, Diego Novillo wrote: Lawrence, Ian and Gaby have been working on the proposed coding guidelines for C++

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 4:52 PM, Lawrence Crowl cr...@google.com wrote: Personally, I would rather see if we can take advantage of C++ features to reduce garbage and then use the Boehm collector. There is too much manual management with GTY, and I'd rather the compiler leverage mainstream

Merge from gcc-4_7-branch to gccgo branch

2012-05-25 Thread Ian Lance Taylor
I've merged gcc-4_7-branch revision 187900 to the gccgo branch. Ian

Re: [C++ Patch] PR 32054

2012-05-25 Thread Jason Merrill
OK. Jason

[patch] Fixes to make check_makefile_deps.sh work again

2012-05-25 Thread Steven Bosscher
Hello, The following patch was necessary to make check_makefile_deps.sh work on powerpc64-unknown-linux-gnu. Is this OK? Ciao! Steven Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 187901) +++ contrib/ChangeLog

  1   2   >