Re: [PATCH] Honour DriverOnly for enum values in error messages.

2015-07-27 Thread Andreas Krebbel
On 07/27/2015 01:45 PM, Dominik Vogt wrote: /gcc/ChangeLog * opts-common.c (read_cmdline_option): List DriverOnly enum values as valid only in the error message of the driver, not in the messages of the language compilers. Applied. Thanks! -Andreas-

[PATCH] Refactoring masked built-in decls

2015-07-27 Thread Petr Murzin
Hello, This patch converts mask type for masked builtins from signed to unsigned. Furthermore, several redundant builtins definitions were removed. Please have a look. It it ok for trunk? Thanks, Petr 2015-07-27 Petr Murzin petr.mur...@intel.com * config/i386/i386.c (bdesc_special_args):

Re: [wwwdocs] Mention -Wshift-overflow

2015-07-27 Thread Marek Polacek
On Mon, Jul 27, 2015 at 12:34:06AM +0200, Gerald Pfeifer wrote: Hi Marek, On Tue, 21 Jul 2015, Marek Polacek wrote: +liA new command-line option code-Wshift-overflow/code has been + added for the C and C++ compilers, which warns about left shift + overflows.

RFA: RL78: Add an optimization to the addsi3 pattern

2015-07-27 Thread Nick Clifton
Hi DJ, This patch adds a small optimization to the RL78 addsi3 pattern so that it can skip adding in the high part of a constant symbolic address when -mes0 is active. Under these circumstances we know that the address has to be in low memory and that it is invalid to attempt to access

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-27 Thread Alan Lawrence
Ramana Radhakrishnan wrote: I haven't seen the patch yet but here are my thoughts on where this should be going. Thus in summary - 1. -mfpu=neon implies the presence of the float16x(4/8) types and all the intrinsics that treat these values as bags of bits. 2. -mfpu=neon-fp16 implies the

Re: [gomp4] Additional tests for routine directive

2015-07-27 Thread Thomas Schwinge
Hi! On Fri, 24 Jul 2015 15:43:36 -0500, James Norris jnor...@codesourcery.com wrote: The attached patch adds additional test for the routine directive for C/C++/Fortran. Committed to gomp-4_0-branch. Thanks, but I see a number of FAILs, including the following: FAIL:

Re: [gomp4] acc routines bugfix

2015-07-27 Thread Thomas Schwinge
Hi Cesar! On Fri, 24 Jul 2015 08:05:00 -0700, Cesar Philippidis ce...@codesourcery.com wrote: [...] I couldn't think of a way to test the lto error message because that involves having two compilers present. I wonder if it's ok to have libgomp check for compiler expected compiler errors?

Re: OMP. More constification

2015-07-27 Thread Nathan Sidwell
On 07/27/15 04:23, Jakub Jelinek wrote: On Sun, Jul 26, 2015 at 11:01:09AM -0400, Nathan Sidwell wrote: I found some more missing consts. The size, kind, var and function arrays emitted by omp-low are read only, but are not so marked. This patch First of all, the hostaddrs array is going to

[PATCH][AArch64] Change aarch64 vector cost to match vectorizer

2015-07-27 Thread Pawel Kupidura
Hello, I've applied changes for AArch64 vectorizer config suggested by Richard Biener (here https://gcc.gnu.org/ml/gcc/2015-04/msg00086.html) and checked the effect on spec2006 and geekbench benchmarks. Benchmarks were compiled with and without patch, in both cases with and without

[PATCH] Honour DriverOnly for enum values in error messages.

2015-07-27 Thread Dominik Vogt
The attached patch fixes a glicht in the error message generated for invalid values of enum options. When a DriverOnly option was passed directoy top the compiler, it would still list that as valid in the error message, e.g. on s390: $ cc1 ... -march=native cc1: error: unrecognized argument

Re: [C/C++ PATCH] Implement -Wtautological-compare (PR c++/66555, c/54979)

2015-07-27 Thread Marek Polacek
On Fri, Jul 24, 2015 at 03:10:17PM -0600, Jeff Law wrote: OK. Note I think the pt.c change will need trivial updating as it conflicts with another change of yours that I approved recently. Committed after resolving trivial merge conflict. Thanks for review, Marek

Re: [PATCH][RFT] Reduce gimple-match.c compile-time(?)

2015-07-27 Thread Richard Biener
On Fri, 24 Jul 2015, Richard Biener wrote: The following patch implements the simplest approach of splitting the huge functions in gimple-match.c (not yet generic-match.c). ... Can people who reported huge compile-times test this patch and report back? Positive feedback on IRC and thus I

Re: [PATCH][RFC] Re-work GIMPLE checking to be gimple class friendly

2015-07-27 Thread Richard Biener
On Mon, 27 Jul 2015, Richard Biener wrote: I noticed that the code we generate for a simple gimple_assign_rhs1 (stmt) is quite bad as we have two checking pieces. The implementation is now static inline tree gimple_assign_rhs1 (const_gimple gs) { GIMPLE_CHECK (gs, GIMPLE_ASSIGN);

Re: [PATCH][RFC] Re-work GIMPLE checking to be gimple class friendly

2015-07-27 Thread Richard Biener
On Mon, 27 Jul 2015, Richard Biener wrote: On Mon, 27 Jul 2015, Richard Biener wrote: I noticed that the code we generate for a simple gimple_assign_rhs1 (stmt) is quite bad as we have two checking pieces. The implementation is now static inline tree gimple_assign_rhs1

Re: OMP. More constification

2015-07-27 Thread Jakub Jelinek
On Mon, Jul 27, 2015 at 07:33:59AM -0400, Nathan Sidwell wrote: On 07/27/15 04:23, Jakub Jelinek wrote: On Sun, Jul 26, 2015 at 11:01:09AM -0400, Nathan Sidwell wrote: I found some more missing consts. The size, kind, var and function arrays emitted by omp-low are read only, but are not so

Re: OMP. More constification

2015-07-27 Thread Nathan Sidwell
On 07/27/15 07:43, Jakub Jelinek wrote: On Mon, Jul 27, 2015 at 07:33:59AM -0400, Nathan Sidwell wrote: They are only global objects if they are filled with constants. Right know for kinds array that is true always, for sizes array if no VLAs nor variable length array sections are used. They

Re: [libstdc++/67015, patch] Fix regex POSIX bracket parsing

2015-07-27 Thread Jonathan Wakely
On 26/07/15 05:20 -0700, Tim Shen wrote: @@ -389,7 +391,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif } - void + _StringT _M_add_collating_element(const _StringT __s) { auto __st = _M_traits.lookup_collatename(__s.data(), Changing this return type is an ABI

[RFC AArch64][PR 63304] Handle literal pools for functions 1 MiB in size.

2015-07-27 Thread Ramana Radhakrishnan
Hi, This patch appears to fix the issue in PR63304 where we have functions that are 1MiB. The idea is to use adrp / ldr or adrp / add instructions to address the literal pools under the use of a command line option. The patch as attached turns this feature on by default as that is the

Re: Fix logic error in Fortran OpenACC parsing

2015-07-27 Thread Thomas Schwinge
Hi! On Fri, 8 May 2015 14:24:15 +0300, Ilmir Usmanov i.usma...@samsung.com wrote: On 06.05.2015 14:38, Thomas Schwinge wrote: On Tue, 5 May 2015 15:38:03 -0400, David Malcolm dmalc...@redhat.com wrote: On Wed, 2015-04-29 at 14:10 +0200, Mikael Morin wrote: Le 29/04/2015 02:02, David

Re: [gomp4] fiuxup openacc default handling

2015-07-27 Thread Tom de Vries
On 26/07/15 19:09, Nathan Sidwell wrote: I've committed this update to my earlier breakout of default handling. After complaining about something because of 'none', we should fall through to the default handling, to prevent ICEing later (on patch seriesI'm working on). This matches the OMP

Re: [gomp4] fiuxup openacc default handling

2015-07-27 Thread Nathan Sidwell
On 07/27/15 11:21, Tom de Vries wrote: On 26/07/15 19:09, Nathan Sidwell wrote: I've committed this update to my earlier breakout of default handling. After complaining about something because of 'none', we should fall through to the default handling, to prevent ICEing later (on patch seriesI'm

Re: [C/C++ PATCH] Implement -Wtautological-compare (PR c++/66555, c/54979)

2015-07-27 Thread Kyrill Tkachov
On 27/07/15 16:59, Kyrill Tkachov wrote: Hi Marek, On 27/07/15 13:41, Marek Polacek wrote: On Fri, Jul 24, 2015 at 03:10:17PM -0600, Jeff Law wrote: OK. Note I think the pt.c change will need trivial updating as it conflicts with another change of yours that I approved recently. Committed

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-07-27 Thread Jeff Law
On 07/27/2015 04:17 AM, Kyrill Tkachov wrote: I experimented with resource.c and the roadblock I hit is that it seems to have an assumption that it operates on hard regs (in fact the struct it uses to describe the resources has a HARD_REG_SET for the regs) and so it triggers various

RE: [PATCH][AArch64] Improve spill code - swap order in shl pattern

2015-07-27 Thread Wilco Dijkstra
ping -Original Message- From: Wilco Dijkstra [mailto:wdijk...@arm.com] Sent: 27 April 2015 14:37 To: GCC Patches Subject: [PATCH][AArch64] Improve spill code - swap order in shl pattern Various instructions are supported as integer operations as well as SIMD on AArch64. When

Re: [gomp4, fortran] Patch to fix continuation checks of OpenACC and OpenMP directives

2015-07-27 Thread Thomas Schwinge
Hi! On Tue, 30 Jun 2015 03:39:42 +0300, Ilmir Usmanov m...@ilmir.us wrote: 08.06.2015, 17:59, Cesar Philippidis ce...@codesourcery.com: On 06/07/2015 02:05 PM, Ilmir Usmanov wrote: 08.06.2015, 00:01, Ilmir Usmanov m...@ilmir.us: This patch fixes checks of OpenMP and OpenACC continuations

Re: [PATCH][RFC] Re-work GIMPLE checking to be gimple class friendly

2015-07-27 Thread Michael Matz
Hi, On Mon, 27 Jul 2015, Richard Biener wrote: static inline tree gimple_assign_rhs1 (const_gimple gs) { GIMPLE_CHECK (gs, GIMPLE_ASSIGN); return gimple_op (gs, 1); } and the hidden checking is due to gimple_op being static inline tree * gimple_ops

Re: [PATCH 2/16][ARM] PR/63870 Add __builtin_arm_lane_check.

2015-07-27 Thread Alan Lawrence
Kyrill Tkachov wrote: Hi Alan, Can you please add a comment on top of this saying that this builtin only exists to perform the lane check, just to make it explicit for the future. Done, and pushed as r226252. Charles, thanks for your patience, and I hope this lets you move forwards. I

Re: [PATCH][AArch64] Improve spill code - swap order in shr patterns

2015-07-27 Thread James Greenhalgh
On Mon, Jul 27, 2015 at 03:38:55PM +0100, Wilco Dijkstra wrote: This is basically the same as the shl version but for the shr patterns. Various instructions are supported as integer operations as well as SIMD on AArch64. When register pressure is high, lra-constraints inserts spill code

Re: [PATCH] Refactoring masked built-in decls

2015-07-27 Thread Uros Bizjak
On Mon, Jul 27, 2015 at 2:46 PM, Petr Murzin petrmurz...@gmail.com wrote: Hello, This patch converts mask type for masked builtins from signed to unsigned. Furthermore, several redundant builtins definitions were removed. Please have a look. It it ok for trunk? I gave the patch a quick look

Re: [PATCH][RFC][match.pd] optimize (X C) == N when C is power of 2

2015-07-27 Thread Segher Boessenkool
On Mon, Jul 27, 2015 at 09:11:12AM +0100, Kyrill Tkachov wrote: On 25/07/15 03:19, Segher Boessenkool wrote: On Fri, Jul 24, 2015 at 09:09:39AM +0100, Kyrill Tkachov wrote: This transformation folds (X % C) == N into X ((1 (size - 1)) | (C - 1))) == N for constants C and N where N is

Re: [C/C++ PATCH] Implement -Wtautological-compare (PR c++/66555, c/54979)

2015-07-27 Thread Kyrill Tkachov
Hi Marek, On 27/07/15 13:41, Marek Polacek wrote: On Fri, Jul 24, 2015 at 03:10:17PM -0600, Jeff Law wrote: OK. Note I think the pt.c change will need trivial updating as it conflicts with another change of yours that I approved recently. Committed after resolving trivial merge conflict.

Re: [PATCH 2/16][ARM] PR/63870 Add __builtin_arm_lane_check.

2015-07-27 Thread Kyrill Tkachov
Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01334.html + if (fcode == ARM_BUILTIN_NEON_LANE_CHECK) +{ + tree nlanes = CALL_EXPR_ARG (exp, 0); + gcc_assert (TREE_CODE (nlanes) == INTEGER_CST); + rtx lane_idx =

Re: [PATCH 1/16][ARM] PR/63870 Add qualifier to check lane bounds in expand

2015-07-27 Thread Kyrill Tkachov
Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01333.html (While this falls under PR/63870, and I will link to that in the ChangeLog, it is only a small step towards fixing that PR.) This is ok for trunk. Thanks, Kyrill

Re: [gomp4] Remove device-specific filtering during parsing for OpenACC

2015-07-27 Thread Julian Brown
On Fri, 17 Jul 2015 14:57:14 +0200 Thomas Schwinge tho...@codesourcery.com wrote: In combination with the equivant change to gcc/cp/parser.c:cp_parser_oacc_all_clauses, gcc/c-family/c-omp.c:c_oacc_filter_device_types, and transitively also the struct identifier_hasher and

Re: [PATCH][RFC] Re-work GIMPLE checking to be gimple class friendly

2015-07-27 Thread Richard Biener
On July 27, 2015 5:18:55 PM GMT+02:00, Michael Matz m...@suse.de wrote: Hi, On Mon, 27 Jul 2015, Richard Biener wrote: static inline tree gimple_assign_rhs1 (const_gimple gs) { GIMPLE_CHECK (gs, GIMPLE_ASSIGN); return gimple_op (gs, 1); } and the hidden

Re: offload data version number

2015-07-27 Thread Nathan Sidwell
On 07/24/15 09:32, Nathan Sidwell wrote: On 07/21/15 11:21, Nathan Sidwell wrote: I committed a version to gomp4 branch, but would still like to get this to trunk ASAP. I committed this update to the gomp4 branch to match the updated version currently under review for trunk. nathan

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

2015-07-27 Thread Jeff Law
On 07/27/2015 03:17 AM, Richard Biener wrote: On Mon, Jul 27, 2015 at 5:10 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org Hi, $subject. patches individually bootstrapped + regtested on x86_64-linux-gnu, and run through config-list.mk with more patches

[wwwdocs] Add -Wtautological-compare to changes.html

2015-07-27 Thread Marek Polacek
Another one. Committed to CVS. Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.17 diff -u -r1.17 changes.html --- changes.html27 Jul 2015 11:16:15 - 1.17 +++

[PATCH][AArch64] Improve spill code - swap order in shr patterns

2015-07-27 Thread Wilco Dijkstra
This is basically the same as the shl version but for the shr patterns. Various instructions are supported as integer operations as well as SIMD on AArch64. When register pressure is high, lra-constraints inserts spill code without taking the allocation class into account, and basically chooses

Re: [PATCH][AArch64] Improve spill code - swap order in shl pattern

2015-07-27 Thread James Greenhalgh
On Mon, Jul 27, 2015 at 03:38:40PM +0100, Wilco Dijkstra wrote: ping Various instructions are supported as integer operations as well as SIMD on AArch64. When register pressure is high, lra-constraints inserts spill code without taking the allocation class into account, and basically

Re: [C/C++ PATCH] Implement -Wtautological-compare (PR c++/66555, c/54979)

2015-07-27 Thread Marek Polacek
On Mon, Jul 27, 2015 at 05:01:30PM +0100, Kyrill Tkachov wrote: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67030 I hope the patch I've posted in the PR helps. Can you please check? Marek

Re: [PATCH][RFC][match.pd] optimize (X C) == N when C is power of 2

2015-07-27 Thread Jeff Law
On 07/27/2015 01:36 AM, Richard Biener wrote: I think it also aligns with the idea of pushing back RTL expansion and expose some target specifics after another GIMPLE lowering phase. I'm also thinking of addressing-mode selection and register promotion. So at least if we think of that target

Re: [PATCH] Honour DriverOnly for enum values in error messages.

2015-07-27 Thread Jeff Law
On 07/27/2015 05:45 AM, Dominik Vogt wrote: The attached patch fixes a glicht in the error message generated for invalid values of enum options. When a DriverOnly option was passed directoy top the compiler, it would still list that as valid in the error message, e.g. on s390: $ cc1 ...

Re: [PATCH] Use lowpart_subreg instead of simplify_gen_subreg

2015-07-27 Thread Jeff Law
On 07/26/2015 02:02 PM, Anatoliy Sokolov wrote: Hello. This patch change function call simplify_gen_subreg (omode, x, imode, subreg_lowpart_offset (omode, imode)) with lowpart_subreg (omode, x, imode) and move lowpart_subreg function from loop-iv.c to simplify-rtx.c. Bootstrapped and

Re: [PATCH][1/N] Change GET_MODE_INNER to always return a non-void mode

2015-07-27 Thread Jeff Law
On 07/27/2015 04:25 AM, David Sherwood wrote: Hi, Part 1 of this change is a clean-up. I have changed calls to GET_MODE_INNER (m) so that it returns m in cases where there is no inner mode. This simplifies some of the calling code by removing the need to check for VOIDmode and allows calling it

Re: [gomp4] Additional tests for routine directive

2015-07-27 Thread James Norris
Thomas, The attached patch adds XFAILs so as to quiet the errors until such time as the development is complete. Committed to gomp-4_0-branch. Thank you, thank you Jim On 07/27/2015 08:36 AM, Thomas Schwinge wrote: Hi! On Fri, 24 Jul 2015 15:43:36 -0500, James Norris

Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-07-27 Thread Jeff Law
On 07/27/2015 03:25 AM, Richard Biener wrote: On Mon, Jul 27, 2015 at 5:41 AM, Michael Collison michael.colli...@linaro.org wrote: This patch is designed to optimize end of loop conditions involving of the form i x i y into i min (x, y). Loop condition involving '' are handled similarly

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-07-27 Thread Kyrill Tkachov
On 27/07/15 17:09, Jeff Law wrote: On 07/27/2015 04:17 AM, Kyrill Tkachov wrote: I experimented with resource.c and the roadblock I hit is that it seems to have an assumption that it operates on hard regs (in fact the struct it uses to describe the resources has a HARD_REG_SET for the regs)

[committed, PATCH]: Add more tests for PR target/66232

2015-07-27 Thread H.J. Lu
Index: ChangeLog === --- ChangeLog (revision 226252) +++ ChangeLog (working copy) @@ -1,3 +1,10 @@ +2015-07-27 H.J. Lu hongjiu...@intel.com + + * gcc.target/i386/pr66232-6.c: New tests. + *

Re: [MOXIE] Hookize PRINT_OPERAND and PRINT_OPERAND_ADDRESS

2015-07-27 Thread Jeff Law
On 07/26/2015 02:02 PM, Anatoliy Sokolov wrote: Hi. This patch removes obsolete PRINT_OPERAND and PRINT_OPERAND_ADDRESS macros from the MOXIE back end in the GCC and introduces equivalent TARGET_PRINT_OPERAND and TARGET_PRINT_OPERAND_ADDRESS target hooks. Regression tested on

Re: RFA: RL78: Add an optimization to the addsi3 pattern

2015-07-27 Thread DJ Delorie
Ok, but please don't put non-public issue numbers in the comments.

Re: C++ delayed folding branch review

2015-07-27 Thread Jason Merrill
I've trimmed this to the previously mentioned issues that still need to be addressed; I'll do another full review after these are dealt with. On 06/13/2015 12:15 AM, Jason Merrill wrote: On 06/12/2015 12:11 PM, Kai Tietz wrote: @@ -1052,6 +1054,9 @@ adjust_temp_type (tree type, tree temp) {

Re: [committed] Typo in ipa-devirt.c

2015-07-27 Thread Richard Biener
On July 27, 2015 9:35:35 PM GMT+02:00, Marek Polacek pola...@redhat.com wrote: This patch fixes an obvious typo in types_same_for_odr detected by the new -Wtautological-compare warning. Bootstrapped/regtested on x86_64-linux, applying to trunk. Might want to back port this. Looks like a latent

[committed] Update outer-4.c and uns-outer-4.c

2015-07-27 Thread Tom de Vries
Hi, this patch cleans up testcases autopar/outer-4.c and autopar/uns-outer-4.c. Committed as obvious. Thanks, - Tom Update outer-4.c and uns-outer-4.c 2015-07-27 Tom de Vries t...@codesourcery.com * gcc.dg/autopar/outer-4.c (parloop): Remove superfluous noinline attribute. Update

[C/C++ PATCH, committed] Fix -Wtautological-compare (PR bootstrap/67030)

2015-07-27 Thread Marek Polacek
This PR exposed a defect in my -Wtautological-compare warning: we don't want to warn when the expression comes from a macro expansion. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2015-07-27 Marek Polacek pola...@redhat.com PR bootstrap/67030 * c-common.c

[committed] Typo in ipa-devirt.c

2015-07-27 Thread Marek Polacek
This patch fixes an obvious typo in types_same_for_odr detected by the new -Wtautological-compare warning. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2015-07-27 Marek Polacek pola...@redhat.com * ipa-devirt.c (types_same_for_odr): Fix typo. diff --git gcc/ipa-devirt.c

Re: [committed] Typo in ipa-devirt.c

2015-07-27 Thread Marek Polacek
On Mon, Jul 27, 2015 at 09:45:19PM +0200, Richard Biener wrote: On July 27, 2015 9:35:35 PM GMT+02:00, Marek Polacek pola...@redhat.com wrote: This patch fixes an obvious typo in types_same_for_odr detected by the new -Wtautological-compare warning. Bootstrapped/regtested on x86_64-linux,

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

2015-07-27 Thread Richard Sandiford
Jeff Law l...@redhat.com writes: On 07/27/2015 03:17 AM, Richard Biener wrote: On Mon, Jul 27, 2015 at 5:10 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org Hi, $subject. patches individually bootstrapped + regtested on x86_64-linux-gnu, and run

Re: [PATCH 1/4] convert ASM_OUTPUT_ASCII to a hook

2015-07-27 Thread Richard Sandiford
tbsaunde+...@tbsaunde.org writes: +/* The routine used to output sequences of byte values. We use a special + version of this for most svr4 targets because doing so makes the + generated assembly code more compact (and thus faster to assemble) + as well as more readable. Note that if

Re: [PR64164] drop copyrename, integrate into expand

2015-07-27 Thread Alexandre Oliva
On Jul 24, 2015, David Edelsohn dje@gmail.com wrote: On Fri, Jul 24, 2015 at 4:02 PM, Alexandre Oliva aol...@redhat.com wrote: On Jul 23, 2015, David Edelsohn dje@gmail.com wrote: I request that this patch be reverted (again). Might I kindly ask you to please do so for me. I've

Re: [PR64164] drop copyrename, integrate into expand

2015-07-27 Thread H.J. Lu
On Mon, Jul 27, 2015 at 2:22 PM, Alexandre Oliva aol...@redhat.com wrote: On Jul 24, 2015, David Edelsohn dje@gmail.com wrote: On Fri, Jul 24, 2015 at 4:02 PM, Alexandre Oliva aol...@redhat.com wrote: On Jul 23, 2015, David Edelsohn dje@gmail.com wrote: I request that this patch be

Elimitate duplication of get_catalogs in different abi

2015-07-27 Thread François Dumont
Hi This is the patch to get rid of the duplication of the get_catalogs functions in the .so. I used c++locale_internal.h that seems to be there for this kind of purpose. * config/locale/gnu/messages_members.cc (Catalog_info, Catalogs): Move... *

[committed] Simplify gather_scalar_reductions

2015-07-27 Thread Tom de Vries
Hi, this patch adds an early-out to gather_scalar_reductions, and further simplifies the function structure. Bootstrapped on x86_64. Reg-tested with relevant testcases. Committed as obvious. Thanks, - Tom Simplify gather_scalar_reductions 2015-07-27 Tom de Vries t...@codesourcery.com *

[committed] Remove unused decl in a test

2015-07-27 Thread Marek Polacek
Applied. 2015-07-27 Marek Polacek pola...@redhat.com * c-c++-common/Wtautological-compare-2.c: Remove unused declaration. diff --git gcc/testsuite/c-c++-common/Wtautological-compare-2.c gcc/testsuite/c-c++-common/Wtautological-compare-2.c index c8aecef..260d9f7 100644 ---

Re: PATCH: PR bootstrap/66978: [6 Regression] bootstrap failure with --with-multilib-list=m32,m64,mx32

2015-07-27 Thread Alexandre Oliva
On Jul 24, 2015, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Jul 24, 2015 at 10:53 AM, Alexandre Oliva aol...@redhat.com wrote: On Jul 24, 2015, H.J. Lu hongjiu...@intel.com wrote: Static chain returned from get_rtl_for_parm_ssa_default_def may not have Pmode. This patch converts static

Re: C++ delayed folding branch review

2015-07-27 Thread Kai Tietz
2015-07-27 18:51 GMT+02:00 Jason Merrill ja...@redhat.com: I've trimmed this to the previously mentioned issues that still need to be addressed; I'll do another full review after these are dealt with. Thanks for doing this summary of missing parts of prior review. On 06/13/2015 12:15 AM,

Re: [patch] [fixincludes] Ignore .DS_Store junk files when running make check

2015-07-27 Thread Eric Gallager
On 7/6/15, Jeff Law l...@redhat.com wrote: On 07/05/2015 04:58 PM, Eric Gallager wrote: I was just matching the code that was already used there... should the lines to ignore the CVS and .svn folders be re-written into the style you propose, too? Might as well have a consistent style.

Re: [PING][PATCH, PR66851] Handle double reduction in parloops

2015-07-27 Thread Tom de Vries
On 24/07/15 12:30, Tom de Vries wrote: On 13/07/15 16:55, Tom de Vries wrote: Hi, this patch fixes PR66851. In parloops, we manage to parallelize outer loops, but not if the inner loop contains a reduction. There is an xfail in autopar/outer-4.c for this: ... /* { dg-final {

Re: [PATCH] Cleaning up incomplete type warning.

2015-07-27 Thread Manuel López-Ibáñez
On 5 January 2015 at 21:14, Jeff Law l...@redhat.com wrote: On 12/24/14 11:07, Luis Felipe Strano Moraes wrote: This removes an unnecessary static variable from the code and also makes it a single warning instead of two. Patch originally proposed by Manuel López-Ibáñez. Luis Strano

Re: [patch] [fixincludes] Ignore .DS_Store junk files when running make check

2015-07-27 Thread Andreas Schwab
Eric Gallager eg...@gwmail.gwu.edu writes: Okay, I tried embedding ! -name CVS/ ! -name .svn/ into the find -name does an exact match, so you don't need the slash. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And

Re: [PATCH 1/3] Refactor entry point to -Wmisleading-indentation

2015-07-27 Thread Patrick Palka
On Tue, Jun 23, 2015 at 3:05 PM, Patrick Palka patr...@parcs.ath.cx wrote: On Mon, Jun 22, 2015 at 2:56 PM, Patrick Palka patr...@parcs.ath.cx wrote: On Mon, Jun 22, 2015 at 1:29 PM, Jeff Law l...@redhat.com wrote: On 06/09/2015 11:31 AM, Patrick Palka wrote: This patch refactors the entry

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-07-27 Thread Kyrill Tkachov
Hi Jeff, On 24/07/15 19:43, Jeff Law wrote: On 07/24/2015 03:31 AM, Kyrill Tkachov wrote: Wouldn't it be better to walk BB_A, gathering the set of all the registers modified, then do a single walk through BB testing for uses of those registers? I think so, yes. I'll try that. You might look

[PATCH][1/N] Change GET_MODE_INNER to always return a non-void mode

2015-07-27 Thread David Sherwood
Hi, Part 1 of this change is a clean-up. I have changed calls to GET_MODE_INNER (m) so that it returns m in cases where there is no inner mode. This simplifies some of the calling code by removing the need to check for VOIDmode and allows calling it unconditionally. I also removed

Re: [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins.

2015-07-27 Thread Matthew Wahab
Ping. Updated patch attached. Also, retested for arm-none-linux-gnueabihf with native bootstrap and make check and for arm-none-eabi with cross compiled make check. On 02/07/15 14:12, Matthew Wahab wrote: The __sync builtins are implemented using barriers that are too weak for ARMv8 targets,

Re: [PATCH 3/4][ARM][PR target/65697][5.1] Add tests for __sync_builtins.

2015-07-27 Thread Matthew Wahab
Ping. Updated patch attached. Also, retested for arm-none-linux-gnueabihf with native bootstrap and make check and for arm-none-eabi with cross compiled make check. On 02/07/15 14:17, Matthew Wahab wrote: This patch backports the tests added for code generated by the ARM back-end for the

RE: [PATCH][1/N] Change GET_MODE_INNER to always return a non-void mode

2015-07-27 Thread David Sherwood
Hi, Sorry, I forgot to mention I tested this on: aarch64 and aarch64_be - no regressions in gcc testsuite x86_64 - bootstrap build, no testsuite regressions arm-none-eabi - no regressions in gcc testsuite I will also make sure that I can do cross builds on a variety of different targets.

Re: [PATCH 2/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync,compare-and-swap builtins.

2015-07-27 Thread Matthew Wahab
Ping. Updated patch attached. Also, retested for arm-none-linux-gnueabihf with native bootstrap and make check and for arm-none-eabi with cross compiled make check. On 02/07/15 14:15, Matthew Wahab wrote: This patch backports the changes made to strengthen the barriers emitted for the __sync

Re: [PATCH 4/4][ARM][PR target/65697][5.1] Fix tests for __sync_builtins.

2015-07-27 Thread Matthew Wahab
Ping. Updated patch attached. Also, retested for arm-none-linux-gnueabihf with native bootstrap and make check and for arm-none-eabi with cross compiled make check. On 02/07/15 14:18, Matthew Wahab wrote: This patch backports fixes for the __sync builtin tests. The trunk patch submission is

Re: [Revert][AArch64] PR 63521 Define REG_ALLOC_ORDER/HONOR_REG_ALLOC_ORDER

2015-07-27 Thread James Greenhalgh
On Mon, Jul 27, 2015 at 10:52:58AM +0100, pins...@gmail.com wrote: On Jul 27, 2015, at 2:26 AM, Jiong Wang jiong.w...@arm.com wrote: Andrew Pinski writes: On Fri, Jul 24, 2015 at 2:07 AM, Jiong Wang jiong.w...@arm.com wrote: James Greenhalgh writes: On Wed, May 20, 2015 at

Re: [ARM] Correct spelling of references to ARMv6KZ

2015-07-27 Thread Kyrill Tkachov
On 27/07/15 10:47, Matthew Wahab wrote: On 23/07/15 12:04, Kyrill Tkachov wrote: GCC supports ARM architecture ARMv6KZ but refers to it as ARMv6ZK. This is made visible by the command line option -march=armv6zk and by the predefined macro __ARM_ARCH_6ZK__. This patch corrects the spelling

[PATCH][RFC] Re-work GIMPLE checking to be gimple class friendly

2015-07-27 Thread Richard Biener
I noticed that the code we generate for a simple gimple_assign_rhs1 (stmt) is quite bad as we have two checking pieces. The implementation is now static inline tree gimple_assign_rhs1 (const_gimple gs) { GIMPLE_CHECK (gs, GIMPLE_ASSIGN); return gimple_op (gs, 1); } and the hidden

Re: [PATCHv2] [fixincludes] Ignore .DS_Store junk files when running make check

2015-07-27 Thread Eric Gallager
On 7/27/15, Andreas Schwab sch...@linux-m68k.org wrote: Eric Gallager eg...@gwmail.gwu.edu writes: Okay, I tried embedding ! -name CVS/ ! -name .svn/ into the find -name does an exact match, so you don't need the slash. Andreas. Okay, attached a new version of the patch; make check for

Re: [libstdc++/67015, patch] Fix regex POSIX bracket parsing

2015-07-27 Thread Tim Shen
On Mon, Jul 27, 2015 at 4:45 AM, Jonathan Wakely jwak...@redhat.com wrote: On 26/07/15 05:20 -0700, Tim Shen wrote: @@ -389,7 +391,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif } - void + _StringT _M_add_collating_element(const _StringT __s) { auto

Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-07-27 Thread Martin Sebor
So, my suggestion would be to warn for any call with a nonzero value. The current documentation says that you should only use nonzero values for debug purposes. A warning would help yes, how many people read the manual after all :-) Thank you both for the feedback. Attached is a simplified

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

2015-07-27 Thread Trevor Saunders
On Mon, Jul 27, 2015 at 10:14:41AM -0600, Jeff Law wrote: On 07/27/2015 03:17 AM, Richard Biener wrote: On Mon, Jul 27, 2015 at 5:10 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org Hi, $subject. patches individually bootstrapped + regtested on

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

2015-07-27 Thread Trevor Saunders
On Mon, Jul 27, 2015 at 09:05:08PM +0100, Richard Sandiford wrote: Jeff Law l...@redhat.com writes: On 07/27/2015 03:17 AM, Richard Biener wrote: On Mon, Jul 27, 2015 at 5:10 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org Hi, $subject.

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-07-27 Thread Trevor Saunders
On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: On Sat, Jul 25, 2015 at 4:37 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org * config/arc/arc.h, config/bfin/bfin.h, config/frv/frv.h, config/ia64/ia64-protos.h,

Re: [PATCH][RFC][match.pd] optimize (X C) == N when C is power of 2

2015-07-27 Thread Richard Biener
On Fri, 24 Jul 2015, Jeff Law wrote: On 07/24/2015 03:44 AM, Ramana Radhakrishnan wrote: In expr.c, with TER you can detect such patterns, in this case when expanding the comparison, but perhaps we want a *.pd file that would have rules that would be only GIMPLE and only

Re: [ARM] Optimize compare against smin/umin

2015-07-27 Thread Kyrill Tkachov
Hi Michael, On 26/07/15 23:54, Michael Collison wrote: Here is an updated patch that addresses the issues you mentioned: 2015-07-24 Michael Collison michael.colli...@linaro.org Ramana Radhakrishnan ramana.radhakrish...@arm.com * gcc/config/arm/arm.md

Re: OMP. More constification

2015-07-27 Thread Jakub Jelinek
On Sun, Jul 26, 2015 at 11:01:09AM -0400, Nathan Sidwell wrote: I found some more missing consts. The size, kind, var and function arrays emitted by omp-low are read only, but are not so marked. This patch First of all, the hostaddrs array is going to be written by the library side for

Re: [PATCH][RFC][match.pd] optimize (X C) == N when C is power of 2

2015-07-27 Thread Kyrill Tkachov
On 25/07/15 03:19, Segher Boessenkool wrote: On Fri, Jul 24, 2015 at 09:09:39AM +0100, Kyrill Tkachov wrote: This transformation folds (X % C) == N into X ((1 (size - 1)) | (C - 1))) == N for constants C and N where N is positive and C is a power of 2. For N = 0 you can transform it to

[PATCH, PING] PR debug/53927: fix value for DW_AT_static_link

2015-07-27 Thread Pierre-Marie de Rodat
On 07/20/2015 09:39 AM, Pierre-Marie de Rodat wrote: This patch fixes the static link description in DWARF to comply with the specification. In order to do so, it appends a field to all FRAME objects to hold the frame base address (DW_AT_frame_base) so that the nested subrograms can directly

[PATCH, PING] Track indirect calls for call site information in debug info.

2015-07-27 Thread Pierre-Marie de Rodat
On 07/20/2015 02:45 PM, Pierre-Marie de Rodat wrote: On PowerPC targets with -mlongcall, most subprogram calls are turned into indirect calls: the call target is read from a register even though it is compile-time known. This makes it difficult for machine code static analysis engines to recover

Re: [PATCH] Use single shared memory block pool for all pool allocators

2015-07-27 Thread Richard Biener
On Sun, Jul 26, 2015 at 9:09 PM, pins...@gmail.com wrote: On Jul 26, 2015, at 11:50 AM, Andi Kleen a...@firstfloor.org wrote: Mikhail Maltsev malts...@gmail.com writes: Hi, all! Recently I did some profiling of GCC to find hotspots and areas of possible performance improvement among

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

2015-07-27 Thread Richard Biener
On Mon, Jul 27, 2015 at 5:10 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org Hi, $subject. patches individually bootstrapped + regtested on x86_64-linux-gnu, and run through config-list.mk with more patches removing usage of the macro. Ok? With

Re: [PATCH 4/9] varasm.c: switch from POINTER_SIZE to targetm.pointer_size ()

2015-07-27 Thread Richard Biener
On Mon, Jul 27, 2015 at 5:10 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders tbsaunde+...@tbsaunde.org gcc/ChangeLog: 2015-07-26 Trevor Saunders tbsaunde+...@tbsaunde.org * varasm.c (assemble_addr_to_section): Call targetm.pointer_size ().

Re: [Revert][AArch64] PR 63521 Define REG_ALLOC_ORDER/HONOR_REG_ALLOC_ORDER

2015-07-27 Thread Jiong Wang
Andrew Pinski writes: On Fri, Jul 24, 2015 at 2:07 AM, Jiong Wang jiong.w...@arm.com wrote: James Greenhalgh writes: On Wed, May 20, 2015 at 01:35:41PM +0100, Jiong Wang wrote: Current IRA still use both target macros in a few places. Tell IRA to use the order we defined rather than with

Re: [ARM] Correct spelling of references to ARMv6KZ

2015-07-27 Thread Matthew Wahab
On 23/07/15 12:04, Kyrill Tkachov wrote: GCC supports ARM architecture ARMv6KZ but refers to it as ARMv6ZK. This is made visible by the command line option -march=armv6zk and by the predefined macro __ARM_ARCH_6ZK__. This patch corrects the spelling internally and adds -march=armv6kz. To

Re: [V850] Hookize LIBCALL_VALUE

2015-07-27 Thread Nicholas Clifton
Hi Anatoliy, OK for trunk? 2015-07-26 Anatoly Sokolov ae...@post.ru * config/v850/v850.h (LIBCALL_VALUE): Remove macros. * config/v850/v850.md (RV_REGNUM): New constants. * config/v850/v850.c (v850_libcall_value): New functions. (v850_function_value_regno_p,

Re: [Revert][AArch64] PR 63521 Define REG_ALLOC_ORDER/HONOR_REG_ALLOC_ORDER

2015-07-27 Thread pinskia
On Jul 27, 2015, at 2:26 AM, Jiong Wang jiong.w...@arm.com wrote: Andrew Pinski writes: On Fri, Jul 24, 2015 at 2:07 AM, Jiong Wang jiong.w...@arm.com wrote: James Greenhalgh writes: On Wed, May 20, 2015 at 01:35:41PM +0100, Jiong Wang wrote: Current IRA still use both target

  1   2   >