Re: [PATCH] longlong: fix sh -Wundef builds

On Jan 8, 2016, at 7:18 AM, Mike Frysinger wrote: > On 08 Jan 2016 06:54, Oleg Endo wrote: >> On Jan 8, 2016, at 4:39 AM, Mike Frysinger wrote: >>> This file fails when building for SuperH as it assumes __SHMEDIA__ is >>> always defined. Update the code

Re: [PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed

On 01/07/2016 05:07 AM, Marek Polacek wrote: On Wed, Jan 06, 2016 at 04:38:20PM -0700, Martin Sebor wrote: gcc/testsuite/ChangeLog: 2016-01-04 Martin Sebor PR c/68966 * gcc.dg/atomic-fetch-bool.c: New test. * gcc.dg/sync-fetch-bool.c: Same. So

Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu

On 07/01/16 09:15, Kyrill Tkachov wrote: > > On 07/01/16 07:34, Thomas Preud'homme wrote: >> On Tuesday, January 05, 2016 10:47:38 AM Kyrill Tkachov wrote: >>> Hi Thomas, >> Hi Kyrill, >> diff --git a/gcc/testsuite/g++.dg/pr67989.C b/gcc/testsuite/g++.dg/pr67989.C index

Re: [ping] pending patches

On 01/06/2016 08:15 PM, David Malcolm wrote: [PATCH 1/4] PR c++/62314: add fixit hint for missing "template <> " in explicit specialization: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01933.html [PATCH 2/4] PR c++/62314: add fixit hint for "expected ';' after class definition:

Re: [PATCH : RL78] Disable interrupts during hardware multiplication routines

Hi Mike, Thanks for the feedback regarding the ABI. I have added Nick and DJ in the loop to see if they can review this patch posted last month, https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00733.html Best Regards, Kaushik On Wed, Dec 9, 2015 at 10:23 PM, Mike Stump

Re: [PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed

On Wed, Jan 06, 2016 at 04:38:20PM -0700, Martin Sebor wrote: > >>gcc/testsuite/ChangeLog: > >>2016-01-04 Martin Sebor > >> > >>PR c/68966 > >>* gcc.dg/atomic-fetch-bool.c: New test. > >>* gcc.dg/sync-fetch-bool.c: Same. > > > >So the tradition is to repeat "New

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68841: Make sure one basic block doesn't clobber CC reg usage of the other

Hi Bernd, On 06/01/16 10:36, Kyrill Tkachov wrote: Hi Bernd, On 05/01/16 18:19, Kyrill Tkachov wrote: On 05/01/16 17:06, Kyrill Tkachov wrote: On 05/01/16 16:34, Bernd Schmidt wrote: On 01/05/2016 03:22 PM, Kyrill Tkachov wrote: This works around the issue but we don't want to do

Re: RFA: PR 66655: Use COFF/PE weak symbols

Hi Jeff, The attached patch adds the test derived from the BZ. There is one small problem - I could not find a way to stop the additional source file from being compiled as a test on its own. I think for C++ code it's usually worked around by naming the additional-source file with ".cc"

Re: [PATCH : RL78] Disable interrupts during hardware multiplication routines

Hi Kaushik, Just a few comments on the patch itself: +/* Check if the block uses mul/div insns. */ +int +check_mduc_usage () I would suggest: static bool check_mduc_usage (void) instead, since this is a boolean function, only used in the rl78.c file, and it takes no arguments. +

Re: [PATCH] testsuite/lib/multline.exp: show test name and line numbers

On 12/29/2015 10:17 AM, Uros Bizjak wrote: It looks that this new functionality doesn't handle conditional compilation, when /* { dg-do compile { target { ! ia32 } } } */ is added to the testcase, such as in recently changed gcc.target/i386/pr68473-1.c. The directive is passed to the next

Re: [PATCH 2/2] PR c++/68819: libcpp fallbacks and -Wmisleading-indentation

On Wed, Jan 06, 2016 at 03:02:05PM -0500, David Malcolm wrote: > On Mon, 2015-12-21 at 22:20 +0100, Jakub Jelinek wrote: > > On Mon, Dec 21, 2015 at 02:10:17PM -0700, Jeff Law wrote: > > > On 12/18/2015 01:21 PM, David Malcolm wrote: > > > > > > >I don't think there's a way to fix

[PATCH] Fix #pragma implementation diagnostics (PR c++/69145, take 2)

Hi! On Tue, Jan 05, 2016 at 03:19:04PM -0500, David Malcolm wrote: > Isn't the line_table available from the cpp_reader as a field, though? > cpp_included_before could in theory access pfile->line_table. You are right, that works too. So I'm offering an alternate patch too: 2016-01-07 Jakub

Re: Fix 61441 [5/5] Disable various transformations for signaling NaN operands

On Thu, Jan 07, 2016 at 06:48:25AM +, Saraswati, Sujoy (OSTL) wrote: > Hi, > > > On Thu, Nov 26, 2015 at 08:38:55AM +, Saraswati, Sujoy (OSTL) wrote: > > > PR tree-optimization/61441 > > > * gcc.dg/pr61441.c: New testcase. > > > > Note the testcase fails on

Re: Fix PR66208

On 12/16/2015 11:14 PM, Jeff Law wrote: On 12/16/2015 10:13 AM, Bernd Schmidt wrote: This is a relatively straightforward PR where we should mention a macro expansion in a warning message. The patch below implements the suggestion by Marek to pass a location down from build_function_call_vec.

Re: PATCH: PR target/69171: [6 Regression] error: unrecognizable insn: on x86_64 with -O2

On Thu, Jan 7, 2016 at 12:52 PM, H.J. Lu wrote: > Add round_nimm_scalar_predicate for scalar SSE integer to floating point > conversions since round_nimm_predicate is for vector operand. > > round_constraint can't be used on vector SSE patterns since it is mapped > to "vm".

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

> +/* { dg-lto-options { { -flto -O2 -Werror -Wl,--defsym,__fread_chk=0x1234 } > } } */ This won’t work on darwin: ld: unknown option: --defsym collect2: error: ld returned 1 exit status TIA Dominique

[PATCH][simplify-rtx] PR rtl-optimization/69161: Fix ICE when trying to simplify vec_duplicate of CC mode

Hi all, In this ICE on aarch64 combine ends up creating a V4SI vec_duplicate of a comparison: (eq:CC_NZ (reg:CC_NZ 66 cc) (const_int 0 [0])) This triggers and assertion in simplify_const_unary_operation about the inner mode of the duplicate (SImode in this case) not being the same as the

[PATCH][RS6000] Migrate reduction optabs in paired.md

There are only a couple of uses of the old reduction optabs remaining (the optabs producing a vector with only one element set). This migrates the uses in gcc.target/rs6000/paired.md. In the absence of a vec_extract pattern, I generate two subreg moves, the same as usually produced by the midend

Re: [gomp4] kernels offload fns

On 01/06/16 19:11, Cesar Philippidis wrote: On 12/29/2015 06:19 AM, Nathan Sidwell wrote: @@ -19385,7 +19415,7 @@ new_oacc_loop_routine (oacc_loop *parent { oacc_loop *loop = new_oacc_loop_raw (parent, gimple_location (call)); int dims[GOMP_DIM_MAX]; - int level = oacc_validate_dims

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

Hi Rainer. +/* { dg-lto-options { { -flto -O2 -Werror -Wl,--defsym,__fread_chk=0x1234 this assumes GNU ld and will break on all targets that use different linkers. OK, how about this version instead ? Cheers Nick Index: gcc/testsuite/gcc.dg/lto/pr61886_0.c

[PATCH][MIPS] Migrate reduction optabs in mips-ps-3d.md

Here's an updated version, also covering the min/max patterns I missed before. I've now managed to do some testing with a stage 1 compiler, by compiling all tests in gcc.dg/vect at -O2 -ftree-vectorize -mips3d -march=mips64r2 -mabi=n32 $x -ffast-math -ffinite-math-only. There were no changes in

Re: [PATCH] Fix #pragma implementation diagnostics (PR c++/69145, take 2)

On 01/07/2016 10:05 AM, Jakub Jelinek wrote: + if (IS_ADHOC_LOC (location)) +{ + location &= MAX_SOURCE_LOCATION; + location + = pfile->line_table->location_adhoc_data_map.data[location].locus; +} This looks like it is get_location_from_adhoc_loc. Bernd

Re: [patch, nvptx] document "kernel" function attribute

On 01/06/16 23:43, Sandra Loosemore wrote: I've been trying to fill in missing documentation for target-specific attributes. I'm not 100% sure I've got this one correct. OK to commit? thanks. +as a kernel function, which is callable by host code. It's not directly callable. Perhaps ',

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68841: Make sure one basic block doesn't clobber CC reg usage of the other

On 01/07/2016 02:45 PM, Kyrill Tkachov wrote: On 07/01/16 11:52, Bernd Schmidt wrote: I looked and this is indeed the case. Still slightly scary. Should the MEM be rtx_equal_p to TO_RENAME? It would be good to test or at least assert this. I tried asserting that and it caused trouble

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68841: Make sure one basic block doesn't clobber CC reg usage of the other

On 07/01/16 13:47, Bernd Schmidt wrote: On 01/07/2016 02:45 PM, Kyrill Tkachov wrote: On 07/01/16 11:52, Bernd Schmidt wrote: I looked and this is indeed the case. Still slightly scary. Should the MEM be rtx_equal_p to TO_RENAME? It would be good to test or at least assert this. I tried

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

Hi Nick, >>> +/* { dg-lto-options { { -flto -O2 -Werror -Wl,--defsym,__fread_chk=0x1234 > >> this assumes GNU ld and will break on all targets that use different >> linkers. > > OK, how about this version instead ? > > Cheers > Nick > > Index: gcc/testsuite/gcc.dg/lto/pr61886_0.c >

Re: [PATCH] Fix #pragma implementation diagnostics (PR c++/69145, take 2)

On 01/07/2016 10:36 PM, Jakub Jelinek wrote: I've also bootstrapped/regtested on x86_64-linux and i686-linux following version: 2016-01-07 Jakub Jelinek PR c++/69145 * files.c (cpp_included_before): If IS_ADHOC_LOC (location), lookup real location

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

On 01/07/2016 06:37 AM, Nick Clifton wrote: Hi Jeff, But does the existence of the weak fread_chk change the interactions inside IPA & LTO in such a way as to compromise the test? One way to find out would be to check out a compiler before Honza's change which fixed 61886, verify the test as

Re: RFA: PR 66655: Use COFF/PE weak symbols

On 01/07/2016 05:15 AM, Nick Clifton wrote: Hi Jeff, The attached patch adds the test derived from the BZ. There is one small problem - I could not find a way to stop the additional source file from being compiled as a test on its own. I think for C++ code it's usually worked around by

[PATCH v2] libstdc++: Make certain exceptions transaction_safe.

The attached patch makes some exceptions transaction-safe, as require by the Transactional Memory TS. I believe I addressed all feedback for the previous version of this patch (in particular, there are now more safety checks for preconditions for this implementation (eg, that the new allocator is

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

Hi Jeff, As folks noted, I think this is still specific to the linker in use. True. :-( I cannot think of any linker neutral way to add a link time symbol definition. Any attempts to define the __fread_chk function via an object file will affects the ipa/lto code and prevent the test from

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

Jeff Law writes: > 68913 mentions ppc64-linux fails, it'd be nice to know why since I'd > expect that has the _chk symbols. It doesn't fail for me (and gcc-testresults has no hits). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B

C PATCH to rectify warning for character types (PR c/23087)

This PR points out that we issue a wrong warning message when assigning two pointers when one of them is plain char. In that case, the compiler currently says that pointer targets differ in signedness. But that is not correct; char is a separate type from (un)signed char and is not compatible

Re: RFA (tree-cfg): PATCH for 68983 (ICE in copy constructor)

> But it occurs to me that since the real problem I was trying to catch is > creation of temporaries of TREE_ADDRESSABLE type in the back end, we > should guard that instead. So this patch moves the assert into assign_temp. FWIW create_tmp_var has a slightly stronger version: gcc_assert

RFA (tree-cfg): PATCH for 68983 (ICE in copy constructor)

This testcase was broken by my earlier fix for 67557, which added an assert to store_field to catch inappropriate use of bitwise copying of TREE_ADDRESSABLE types. In this testcase, the copying is actually fine, since no temporary object is created. So one solution would be to recognize that

[gomp4] reductions on explicitly private variables

I noticed that libgomp is lacking test coverage reductions involving explicitly private variables. E.g. #pragma acc parallel copyout(red) { #pragma acc loop gang private(v) for (j = 0; j < 10; j++) { v = j; #pragma acc loop vector reduction (+:v) for (i = 0; i < 100;

Re: [patch] ARM FreeBSD fix bootstrap

On 06.01.16 11:39, Richard Earnshaw (lists) wrote: On 05/01/16 21:03, Andreas Tobler wrote: On 05.01.16 11:32, Richard Earnshaw (lists) wrote: On 23/12/15 19:28, Andreas Tobler wrote: 2015-12-23 Andreas Tobler * config/arm/freebsd.h: Rename

Re: [patch, nvptx] document "kernel" function attribute

On 01/07/16 12:54, Sandra Loosemore wrote: On 01/07/2016 06:48 AM, Nathan Sidwell wrote: On 01/06/16 23:43, Sandra Loosemore wrote: I've been trying to fill in missing documentation for target-specific attributes. I'm not 100% sure I've got this one correct. OK to commit? thanks. +as a

Re: [PATCH committed] Bug 66680 - [5 Regression] ICE with openmp, a loop and a type bound procedure

> Le 7 janv. 2016 à 19:02, H.J. Lu a écrit : > > On Thu, Jan 7, 2016 at 9:59 AM, H.J. Lu wrote: >> On Thu, Jan 7, 2016 at 5:30 AM, Dominique d'Humières >> wrote: >>> I have committed the following patch to trunk. I am planning to

Re: [patch, nvptx] document "kernel" function attribute

On 01/07/2016 06:48 AM, Nathan Sidwell wrote: On 01/06/16 23:43, Sandra Loosemore wrote: I've been trying to fill in missing documentation for target-specific attributes. I'm not 100% sure I've got this one correct. OK to commit? thanks. +as a kernel function, which is callable by host

Re: [PATCH committed] Bug 66680 - [5 Regression] ICE with openmp, a loop and a type bound procedure

On Thu, Jan 7, 2016 at 10:07 AM, Jakub Jelinek wrote: > On Thu, Jan 07, 2016 at 10:02:23AM -0800, H.J. Lu wrote: >> On Thu, Jan 7, 2016 at 9:59 AM, H.J. Lu wrote: >> > On Thu, Jan 7, 2016 at 5:30 AM, Dominique d'Humières >> > wrote: >>

[gomp4] Fix use of declare'd vars by routine procedures.

Hi! The checking of variables declared by OpenACC declare directives used within an OpenACC routine procedure was not being done correctly. This fix adds the checking required and also adds to the testing. This fix resolves the issue pointed out by Cesar with declare-4.c

Re: [PATCH committed] Bug 66680 - [5 Regression] ICE with openmp, a loop and a type bound procedure

On Thu, Jan 7, 2016 at 5:30 AM, Dominique d'Humières wrote: > I have committed the following patch to trunk. I am planning to commit it to > the gcc5 branch and close the PR as FIXED next sunday if there is no > objection. > > Cheers, > > Dominique > > Index:

[C++ PATCH] Fix ICE with bitfields (PR c++/69164)

Hi! We ICE on the following testcase during SRA, because it sees a field with DECL_SIZE of 1 which is not DECL_BIT_FIELD. The problem is that layout_class_type in some cases copies fields, including DECL_SIZE, but does not copy over DECL_BIT_FIELD flag. The following patch copies even that and

[PATCH] Fix ICE with va_arg (PR tree-optimization/69162)

Hi! The addition of IFN_VA_ARG which is only during stdarg pass lowered introduced ICE on the following testcase. The problem is that we expected that the type the first argument of the internal call points to will remain the one that used to be there during gimplification, but as pointer

[PATCH] Fix (ab) SSA_NAME issue in gimple folding (PR tree-optimization/69167)

Hi! Various places check that (ab) SSA_NAMEs that weren't referenced on a stmt before don't appear on it, but all the checking is done on the gimple tuple operands, while in this case it is added to operands of a comparison of COND_EXPR/VEC_COND_EXPR. The following patch fixes it,

[PATCH] Fix !$omp workshare (PR fortran/69128)

Hi! As the testcase shows, gfc_trans_scalarized_loop_end can be called multiple times (and not just for different dimensions of the same loop) on a single assignment, and we could in that case when inside of !$omp workshare generate nested !$omp do, which is obviously incorrect. Fixed by making

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

On 07/01/16 13:37 -0800, Steve Ellcey wrote: On Thu, 2016-01-07 at 20:56 +0100, Bernhard Reutner-Fischer wrote: On January 7, 2016 12:23:49 PM GMT+01:00, Jonathan Wakely wrote: >On 07/01/16 07:28 +0100, Marc Glisse wrote: >>On Wed, 6 Jan 2016, Jonathan Wakely wrote: >>

Re: [PATCH] longlong: fix sh -Wundef builds

On Jan 8, 2016, at 4:39 AM, Mike Frysinger wrote: > This file fails when building for SuperH as it assumes __SHMEDIA__ is > always defined. Update the code to check if it's defined. This is OK for trunk. Thanks for spotting it. Cheers, Oleg > --- > include/longlong.h | 4

Re: [PATCH], PowerPC IEEE 128-bit fp, #11-rev2 (enable libgcc conversions)

On Wed, 6 Jan 2016, Michael Meissner wrote: > 5)I put the exception handling code under #ifndef _SOFT_FLOAT > control so > that the 32-bit PowerPC machines that don't have hardware floating > point will not use this code (the exception handling uses hardware >

Re: [PATCH] Fix !$omp workshare (PR fortran/69128)

Hi Jakub, Thanks for responding so quickly - it looks good to me. The PR is marked as a 4.9/5/6 regression. Do you intend to backport to 5, at least? Cheers Paul On 7 January 2016 at 22:49, Jakub Jelinek wrote: > Hi! > > As the testcase shows, gfc_trans_scalarized_loop_end

[gomp4] Remove PTX link option

Hi, This patch removes the constraint whereby the PTX emitted was only for sm_30 GPU's. With this removal, the PTX emitted will be targeted for the current context (attached GPU). This patch has been applied to gomp-4_0-branch. Thanks, Jim Index: libgomp/ChangeLog.gomp

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

On Thu, 2016-01-07 at 20:56 +0100, Bernhard Reutner-Fischer wrote: > On January 7, 2016 12:23:49 PM GMT+01:00, Jonathan Wakely > wrote: > >On 07/01/16 07:28 +0100, Marc Glisse wrote: > >>On Wed, 6 Jan 2016, Jonathan Wakely wrote: > >> > >>>On 06/01/16 12:45 -0800, Steve

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

Hi Jakub, -extern size_t __fread_chk (void *__restrict __ptr, size_t __ptrlen, size_t __size, size_t __n, FILE *__restrict __stream) __asm__ ("" "__fread_chk") __attribute__ ((__warn_unused_result__)); +extern size_t __malloc (void *__restrict __ptr, size_t __ptrlen, size_t __size, size_t

Re: C PATCH to rectify warning for character types (PR c/23087)

On Thu, 7 Jan 2016, Marek Polacek wrote: > This PR points out that we issue a wrong warning message when assigning > two pointers when one of them is plain char. In that case, the compiler > currently says that pointer targets differ in signedness. But that is > not correct; char is a separate

Re: [CilkPlus] fix issues when cilk_spawn is used with nontrivial expressions

On 01/06/2016 01:11 PM, Ryan Burn wrote: I could additionally check that the language is c++ before checking those flags, but I'm not sure I see a way around using them. For c++, the cilk_spawn expression can be nested within implicit conversion operators or constructors as in this case:

Re: [PATCH] Fix #pragma implementation diagnostics (PR c++/69145, take 2)

On Thu, Jan 07, 2016 at 01:49:12PM +0100, Bernd Schmidt wrote: > On 01/07/2016 10:05 AM, Jakub Jelinek wrote: > >+ if (IS_ADHOC_LOC (location)) > >+{ > >+ location &= MAX_SOURCE_LOCATION; > >+ location > >+= pfile->line_table->location_adhoc_data_map.data[location].locus; > >+

[PATCH] Fix incorrect gimple_build arguments in gimple-fold.c (PR tree-optimization/69172)

Hi! gimple_build wants the type after POINTER_PLUS_EXPR, but gimple_fold_builtin_memory_chk wasn't passing it. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-01-07 Jakub Jelinek PR tree-optimization/69172 *

Re: [PATCH] longlong: fix sh -Wundef builds

On 08 Jan 2016 06:54, Oleg Endo wrote: > On Jan 8, 2016, at 4:39 AM, Mike Frysinger wrote: > > This file fails when building for SuperH as it assumes __SHMEDIA__ is > > always defined. Update the code to check if it's defined. > > This is OK for trunk. Thanks for spotting