[RFA][PATCH 2/4] [PR tree-optimization/61912] Trimming CONSTRUCTOR stores

2017-01-12 Thread Jeff Law
This is a relatively minor update to the trimming CONSTRUCTOR stores patch to address various comments from Richi. First, simplification of maybe_trim_constructor_store given we only handle one case (CONSTRUCTOR_NELTS (ctor) == 0). Use build_array_type_elts and building an appropriate alias

[RFA][PATCH 1b/4] [PR tree-optimization/33562] Improve DSE of complex stores

2017-01-12 Thread Jeff Law
No major changes in this patch, just addressing the small changes requested by Richi. ie, missing docs, dropped some unnecessary prototype movement, improve check in valid_ao_ref_for_dse, minor formatting fixes. I'm going to assume Richi's prior approval still holds as nothing significant

Re: [RFA][PATCH 3/4] Trim mem* calls in DSE

2017-01-12 Thread Jeff Law
Richi indicated he wants this to be included in gcc-7. So I've updated the mem* trimming patch with his comments. The unnecessary SSA updates are gone. Use wide_int_to_tree rather than building/folding expressions we know will result in constants. Simplify incrementing the start address

Re: [PATCH] Fix bootstrap failure on s390x-linux - ICE with __morestack side-effect jump (PR bootstrap/79069)

2017-01-12 Thread Jeff Law
On 01/12/2017 01:24 PM, Jakub Jelinek wrote: Hi! The RTL verification in rtl_verify_edges as well as various other routines in cfgrtl.c etc. require that any_uncondjump_p jumps never have fallthru edges - even if their destination is right after them, there still needs to be barrier in between

Re: [PATCH] Optimize away useless snprintf calls with -fprintf-return-value (take 2)

2017-01-12 Thread Jeff Law
On 01/10/2017 12:23 AM, Jakub Jelinek wrote: On Mon, Jan 02, 2017 at 04:54:57PM -0700, Martin Sebor wrote: Looks good to me, thanks! Just a couple of suggestions: Here is updated patch with those added comments (and adjusted for the current trunk). Ok for trunk? 2017-01-10 Jakub Jelinek

Re: [patch] update zlib to the 1.2.10 release.

2017-01-12 Thread Matthias Klose
On 12.01.2017 22:17, Jeff Law wrote: > On 01/05/2017 07:45 AM, Matthias Klose wrote: >> These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used >> when >> building without a system zlib. The new release includes fixes for security >> issues CVE-2016-9840, CVE-2016-9841,

Re: [patch] update zlib to the 1.2.10 release.

2017-01-12 Thread Jeff Law
On 01/12/2017 02:26 PM, Matthias Klose wrote: On 12.01.2017 22:17, Jeff Law wrote: On 01/05/2017 07:45 AM, Matthias Klose wrote: These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when building without a system zlib. The new release includes fixes for security issues

Re: [PATCH 1/6] RISC-V Port: gcc/config/riscv/riscv.c

2017-01-12 Thread Joseph Myers
On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > +#include This is included in system.h, so don't include it here. > + error ("unknown cpu `%s' for -mtune", cpu_string); This is using very-old-style `' quotes. Diagnostics should use e.g. %qs for quoting the output of a single % directive, or

[v3 PATCH] PR libstdc++/78389

2017-01-12 Thread Ville Voutilainen
Tested on Linux-x64. This patch doesn't try to fix the reported sort() issue, because a) it would require undoing a throwing move operation, which is impossible. b) in order to avoid the throwing move, we would need to add a level of indirection and the scratch space for the indirect data would

Re: [PATCH 6/6] RISC-V Port: gcc/testsuite

2017-01-12 Thread Andrew Waterman
On Thu, Jan 12, 2017 at 3:42 PM, Joseph Myers wrote: > On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > > As I understand it, you have -m options that can change the ABI between > 32-bit and 64-bit. In such a case you mustn't check for riscv*64*-*-* > target triplets in the

[RFA][PATCH 1a/4] [PR tree-optimization/33562] New sbitmap functions

2017-01-12 Thread Jeff Law
Per Richi's request, this breaks out the new sbitmap functions into their own patch. This patch should address all the concerns Richi raised in the prior review. Namely the performance of the range set/clear and bootstrapping with older or non-GCC C++ compilers and added missing docs. The

Re: [PATCH] Fix PR77283

2017-01-12 Thread Jeff Law
On 01/12/2017 07:55 AM, Richard Biener wrote: The following fixes PR77283, path splitting being overly aggressive and causing loop unrolling not to happen (because how it distorts the CFG). It is a aim at creating a cost model (there's none apart from not duplicating too much stmts) by means

Re: [v3 PATCH] PR libstdc++/78389

2017-01-12 Thread Tim Song
On Thu, Jan 12, 2017 at 8:11 PM, Ville Voutilainen wrote: > This patch doesn't try to fix the reported sort() issue, because > a) it would require undoing a throwing move operation, which > is impossible. > b) in order to avoid the throwing move, we would need to add

[PATCH] Fix bootstrap failure on s390x-linux - ICE with __morestack side-effect jump (PR bootstrap/79069)

2017-01-12 Thread Jakub Jelinek
Hi! The RTL verification in rtl_verify_edges as well as various other routines in cfgrtl.c etc. require that any_uncondjump_p jumps never have fallthru edges - even if their destination is right after them, there still needs to be barrier in between them and code_label after that.

Re: New Port for RISC-V

2017-01-12 Thread Andrew Waterman
Thank you for taking the time to give us feedback. On Thu, Jan 12, 2017 at 9:30 AM, Joseph Myers wrote: > General observation: I see no documentation (no changes to .texi files) > anywhere in this patch series. I also don't see updates to config-list.mk > to add RISC-V

Re: [PATCH] Fix bootstrap failure on s390x-linux - ICE with __morestack side-effect jump (PR bootstrap/79069)

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 02:10:39PM -0700, Jeff Law wrote: > > 2017-01-12 Jakub Jelinek > > > > PR bootstrap/79069 > > * cfgrtl.c (rtl_tidy_fallthru_edge): For any_uncondjump_p that can't > > be removed due to side-effects, don't remove following barrier nor > >

[testsuite, committed] gcc.dg/pr77862.c requires fpic target

2017-01-12 Thread Sandra Loosemore
gcc.dg/pr77862.c was failing on targets that don't support -fPIC, specifically nios2-elf. I've fixed this with a dg-require-effective-target restriction, consistent with what similar testcases do (e.g., gcc.dg/pic-2.c). Committed as obvious. -Sandra 2017-01-12 Sandra Loosemore

[PATCH] rename -Wformat-length to -Wformat-overflow

2017-01-12 Thread Martin Sebor
With the move of the snprintf truncation checking from -Wformat-length to the dedicated -Wformat-truncation option (done in r244210), -Wformat-length isn't as descriptive as it could and should be for an option whose sole focus is the detection of sprintf buffer overflow. The name is also

Re: [PATCH][GCC 5] Fix build issue with NO_FUNCTION_CSE

2017-01-12 Thread Nathan Sidwell
On 01/12/2017 12:38 PM, Kyrill Tkachov wrote: Hi all, This patch fixes the build issue on x86_64 (and other targets that define NO_FUNCTION_CSE but not a particular value) on the GCC 5 branch. thanks! -- Nathan Sidwell

Re: [PATCH] better handling of ranges (PR 78703)

2017-01-12 Thread Jeff Law
On 01/09/2017 09:18 AM, Martin Sebor wrote: On 01/08/2017 09:44 PM, Jeff Law wrote: As much as I hate to say it, I think we need to find a way to break this down into something more manageable. It's just impossible to see the structure of what you're doing with the implementation changes

Re: [PATCH] PR target/79004, Fix char/short -> _Float128 on PowerPC -mcpu=power9

2017-01-12 Thread Michael Meissner
On Wed, Jan 11, 2017 at 04:39:19PM -0600, Segher Boessenkool wrote: > On Mon, Jan 09, 2017 at 07:32:27PM -0500, Michael Meissner wrote: > > This patch fixes PR target/79004 by eliminating the optimization of avoiding > > direct move if we are converting an 8/16-bit integer value from memory to >

Re: [PATCH] better handling of ranges (PR 78703)

2017-01-12 Thread Jeff Law
On 01/09/2017 09:18 AM, Martin Sebor wrote: On 01/08/2017 09:44 PM, Jeff Law wrote: On 12/23/2016 02:25 PM, Martin Sebor wrote: Bug 78703 points out that the decimal point character in floating directives can be longer than just one byte (in locales where the decimal point is a multibyte

Re: [PATCH] rename -Wformat-length to -Wformat-overflow

2017-01-12 Thread Martin Sebor
On 01/12/2017 02:26 PM, Jeff Law wrote: On 01/12/2017 01:31 PM, Martin Sebor wrote: With the move of the snprintf truncation checking from -Wformat-length to the dedicated -Wformat-truncation option (done in r244210), -Wformat-length isn't as descriptive as it could and should be for an option

Re: [RFA][PATCH 3/4] Trim mem* calls in DSE

2017-01-12 Thread Jeff Law
On 01/04/2017 07:04 AM, Richard Biener wrote: * tree-ssa-dse.c (need_ssa_update): New file scoped boolean. (decrement_count): New function. (increment_start_addr, trim_memstar_call): Likewise. (trim_partially_dead_store): Call trim_memstar_call.

Re: [PATCH 4/6] RISC-V Port: libsanitizer

2017-01-12 Thread Joseph Myers
Have these changes been sent upstream? Although at the present development stage applying selected changes might be better than a bulk merge from upstream libsanitizer, they should still go upstream so they aren't a local patch at the time of the next merge. -- Joseph S. Myers

Re: [PATCH] rename -Wformat-length to -Wformat-overflow

2017-01-12 Thread Jeff Law
On 01/12/2017 01:31 PM, Martin Sebor wrote: With the move of the snprintf truncation checking from -Wformat-length to the dedicated -Wformat-truncation option (done in r244210), -Wformat-length isn't as descriptive as it could and should be for an option whose sole focus is the detection of

Re: [PATCH 2/6] RISC-V Port: gcc

2017-01-12 Thread Joseph Myers
On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > +static void > +riscv_parse_arch_string (const char *isa, int *flags) This should be passed the location from riscv_handle_option... > + error ("-march=%s: ISA string must begin with rv32 or rv64", isa); ... so you can use error_at with an

Re: [patch] update zlib to the 1.2.10 release.

2017-01-12 Thread Jeff Law
On 01/12/2017 02:26 PM, Matthias Klose wrote: On 12.01.2017 22:17, Jeff Law wrote: On 01/05/2017 07:45 AM, Matthias Klose wrote: These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when building without a system zlib. The new release includes fixes for security issues

Re: [PATCH 3/6] RISC-V Port: libgcc

2017-01-12 Thread Joseph Myers
On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > +riscv*-*-linux*) > + tmake_file="${tmake_file} t-softfp-sfdf riscv/t-softfp${host_address} > t-softfp riscv/t-elf riscv/t-elf${host_address}" > + extra_parts="$extra_parts crtbegin.o crtend.o crti.o crtn.o crtendS.o > crtbeginT.o" > +

Re: [PATCH] Fix PR77283

2017-01-12 Thread Jeff Law
On 01/12/2017 07:55 AM, Richard Biener wrote: The following fixes PR77283, path splitting being overly aggressive and causing loop unrolling not to happen (because how it distorts the CFG). It is a aim at creating a cost model (there's none apart from not duplicating too much stmts) by means

Re: [PATCH 6/6] RISC-V Port: gcc/testsuite

2017-01-12 Thread Joseph Myers
On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-cse-2.c > b/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-cse-2.c > index 1a4bfe6..665ac23 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-cse-2.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-cse-2.c >

[Ping^2][PATCH][Aarch64] Add support for overflow add and sub operations

2017-01-12 Thread Michael Collison
Ping. Link to original post: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg03119.html

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Richard Biener
On Thu, 12 Jan 2017, Jakub Jelinek wrote: > On Thu, Jan 12, 2017 at 10:52:23AM +0100, Richard Biener wrote: > > > I'll give the (short) 1 parsing a try though to see how awkward it > > > really gets. > > > > Ok, doesn't look a good way to go. Apart from making it difficult > > to handle in the

Re: [patch,avr] PR78883: Implement a dummy scheduler

2017-01-12 Thread Georg-Johann Lay
On 12.01.2017 10:00, Richard Sandiford wrote: Georg-Johann Lay writes: On 04.01.2017 20:29, Jeff Law wrote: On 01/04/2017 12:18 PM, Segher Boessenkool wrote: On Wed, Jan 04, 2017 at 06:42:23PM +, Richard Sandiford wrote: 1. reload has a bug that no-one really wants to fix

Re: [RFC] combine: Handle zero_extend without subreg in change_zero_ext.

2017-01-12 Thread Dominik Vogt
On Wed, Jan 11, 2017 at 12:02:40PM -0600, Segher Boessenkool wrote: > On Thu, Jan 05, 2017 at 05:46:51PM +0100, Dominik Vogt wrote: > > The attached patch deals with another type of zero_extend that is > > not yet handled in change_zero_ext, i.e. (zero_extend > > (pseudoreg)), without a "subreg"

Re: [fixincludes] Only declare gets for C++ < 2014 on Solaris (PR libstdc++/78979)

2017-01-12 Thread Rainer Orth
Rainer Orth writes: > While investigating PR libstdc++/78979, it turns out that Solaris > incorrectly declares std::gets even for C++14 where it's been > removed. This patch fixes that by adding an additional __cplusplus < > 201402L guard via fixincludes. This

Re: [patch,avr] PR78883: Implement a dummy scheduler

2017-01-12 Thread Richard Sandiford
Georg-Johann Lay writes: > On 04.01.2017 20:29, Jeff Law wrote: >> On 01/04/2017 12:18 PM, Segher Boessenkool wrote: >>> On Wed, Jan 04, 2017 at 06:42:23PM +, Richard Sandiford wrote: 1. reload has a bug that no-one really wants to fix (understandable) 2. the bug is

[RFC][PATCH][Libgcc] Verify pointers during stack unwind

2017-01-12 Thread Yuri Gribov
Hi all, Libgcc unwinder currently does not do any verification of pointers which it chases on stack. In practice this not so rarely causes segfaults when unwinding on corrupted stacks (e.g. when when trying to print diagnostic on fatal error) [1]. Ironically this usually happens in error

Unreviewed fixincludes patch

2017-01-12 Thread Rainer Orth
The following patch has remained unreviewed for a week: [fixincludes] Only declare gets for C++ < 2014 on Solaris (PR libstdc++/78979) https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00290.html Given that it's fixincludes-only, this is for Bruce to approve, although one might

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 10:52:23AM +0100, Richard Biener wrote: > > I'll give the (short) 1 parsing a try though to see how awkward it > > really gets. > > Ok, doesn't look a good way to go. Apart from making it difficult > to handle in the parser you can't distinguish a conversion from an >

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Prathamesh Kulkarni
On 12 January 2017 at 16:15, Richard Biener wrote: > On Thu, 12 Jan 2017, Jakub Jelinek wrote: > >> On Thu, Jan 12, 2017 at 10:52:23AM +0100, Richard Biener wrote: >> > > I'll give the (short) 1 parsing a try though to see how awkward it >> > > really gets. >> > >> > Ok,

Re: [PATCH] PR 78534 Change character length from int to size_t

2017-01-12 Thread FX
> I was finally able to get a 32-bit i686 compiler going (my attempts to > do this on a x86_64-pc-linux-gnu host failed, in the end I resorted to > running 32-bit builds/tests on a i686 container). At least on i686, > the patch below on top of the big charlen->size_t patch fixes the > failures

RE: [Aarch64][PATCH] Fix gcc.dg/zero_bits_compound-2.c for aarch64

2017-01-12 Thread Michael Collison
Committed. -Original Message- From: James Greenhalgh [mailto:james.greenha...@arm.com] Sent: Wednesday, January 11, 2017 2:50 AM To: Kyrill Tkachov Cc: Michael Collison; gcc-patches@gcc.gnu.org; Christophe Lyon; Richard Earnshaw; nd Subject: Re: [Aarch64][PATCH] Fix

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 04:38:27PM +0530, Prathamesh Kulkarni wrote: > On 12 January 2017 at 16:15, Richard Biener wrote: > > On Thu, 12 Jan 2017, Jakub Jelinek wrote: > > > >> On Thu, Jan 12, 2017 at 10:52:23AM +0100, Richard Biener wrote: > >> > > I'll give the (short) 1

Re: [PATCH] [PR rtl-optimization/65618] Fix MIPS ADA bootstrap failure

2017-01-12 Thread James Cowgill
On 11/01/17 17:22, Maciej W. Rozycki wrote: > On Wed, 11 Jan 2017, James Cowgill wrote: > >>> From this consideration I gather you have a program source which can be >>> used as a test case to reproduce the issue, so can you please file a >>> problem report and include the source and a recipe

Re: [PING][PATCH][ARM]Use different startfile and endfile for elf target when generating shared object.

2017-01-12 Thread Renlin Li
~ Ping https://gcc.gnu.org/ml/gcc-patches/2016-06/msg01227.html Regards, Renlin On 14/12/16 15:33, Renlin Li wrote: Ping~ Regards, Renlin On 16/06/16 12:04, Renlin Li wrote: Hi all, GCC has startfile and endfile spec string built into it. startfile is used to specify objects files to

[ping] libobjc patches and zlib update

2017-01-12 Thread Matthias Klose
[CCing some global reviewers] Please review the two libobjc patches: https://gcc.gnu.org/ml/gcc-patches/2016-12/msg02003.html - not a regression, but a simplification of the new configure option. https://gcc.gnu.org/ml/gcc-patches/2016-12/msg02004.html - fix the

Re: [PATCH][ARM]Use different startfile and endfile for elf target when generating shared object.

2017-01-12 Thread kugan
Hi, On 16/06/16 21:04, Renlin Li wrote: /* Now we define the strings used to build the spec file. */ -#define UNKNOWN_ELF_STARTFILE_SPEC " crti%O%s crtbegin%O%s crt0%O%s" +#define UNKNOWN_ELF_STARTFILE_SPEC \ + "crti%O%s \ + %{!shared:crtbegin%O%s} %{shared:crtbeginS%O%s} \ +

[PATCH, Fortran, pr70696, v1] [Coarray] ICE on EVENT POST of host-associated EVENT_TYPE coarray

2017-01-12 Thread Andre Vehreschild
Hi all, attached patch fixes the ICE when using an event in a subroutine. The reason for the ICE was that the backend_decl of the symbol to event on was not set when accessed. The patch ensures this. Furthermore did I fix a invalid memory access in the caf_single lib, where to less memory was

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Richard Biener
On Thu, 12 Jan 2017, Richard Biener wrote: > On Wed, 11 Jan 2017, Joseph Myers wrote: > > > On Wed, 11 Jan 2017, Richard Biener wrote: > > > > > As you can see I adjusted dumping of pointer constants (we can't > > > parse the B suffix and large unsigned numbers get a warning so > > > add 'U').

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Richard Biener
On Wed, 11 Jan 2017, Joseph Myers wrote: > On Wed, 11 Jan 2017, Richard Biener wrote: > > > As you can see I adjusted dumping of pointer constants (we can't > > parse the B suffix and large unsigned numbers get a warning so > > add 'U'). There's the general issue that we dump > > > > short

[PATCH] PR66284 remove std::function special case for reference_wrapper

2017-01-12 Thread Jonathan Wakely
As the PR says, we follow the Boost.Function semantics w.r.t. construction of std::function from a std::reference_wrapper, but other std::lib implementations do something different. I reported a defect (LWG 2781) and the consensus is to clarify the standard to bless the other implementations.

[PATCH] Fix PR77283

2017-01-12 Thread Richard Biener
The following fixes PR77283, path splitting being overly aggressive and causing loop unrolling not to happen (because how it distorts the CFG). It is a aim at creating a cost model (there's none apart from not duplicating too much stmts) by means of the observation that we'd have to have PHI

[Ada] Crash on missing full view of controlled private type

2017-01-12 Thread Arnaud Charlet
This patch protects adjustment, finalization, and initialization-related code from scenarios where a private type may not have been successfully frozen due to a missing full view. -- Source -- -- missing_view.ads with Ada.Finalization; use Ada.Finalization; package

Re: [PATCH] BRIG frontend: request for a global review

2017-01-12 Thread Pekka Jääskeläinen
Hi, A gentle ping... On Wed, Dec 14, 2016 at 7:15 PM, Pekka Jääskeläinen wrote: > Hi, > > I'm calling for a global review for the BRIG frontend for inclusion in > upstream. > The copyright transfer has been taken care of. > > The patch set has been approved by Martin

RE: [PATCH] MIPS: Fix generation of DIV.G and MOD.G for Loongson targets.

2017-01-12 Thread Maciej W. Rozycki
On Thu, 12 Jan 2017, Toma Tabacu wrote: > > > Unfortunately, this interferes with the generation of DIV.G and MOD.G > > > (the div3 and mod3 patterns) for Loongson targets, > > which > > > causes test failures. > > > > What test failures? Details please. > > > > It's >

[PATCH, Fortran, pr70697, v1] [Coarray] ICE on EVENT WAIT with array element UNTIL_COUNT argument

2017-01-12 Thread Andre Vehreschild
Hi all, *** this is no duplicate, but +1 in the PR#! *** attached patch fixes the ICE by resolving the expression in UNTIL_COUNT correctly. The ICE was caused by the array-specification in UNTIL_COUNT not correctly set. Bootstraps and regtests ok on x86_64-linux/F25. Ok for trunk and gcc-6? -

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Richard Biener
On Thu, 12 Jan 2017, Jakub Jelinek wrote: > On Thu, Jan 12, 2017 at 01:35:32PM +0100, Richard Biener wrote: > > It also lacks expressiveness when comparing > > > > short s; > > s_1 = (short) 1; > > s_2 = short (1); > > > > IMHO having a _Literal somewhere makes it more obvious what is

[Ada] Allow user-specified elaboration order constraints

2017-01-12 Thread Arnaud Charlet
This patch adds a new feature that allows the user to specify a particular elaboration order for some or all library items in the program. The following test should produce the following output: Command line: gprbuild -q -f -gnatE -g p-main.adb -bargs -l -felab-order.txt elab-order.txt file:

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Richard Biener
On Thu, 12 Jan 2017, Jakub Jelinek wrote: > On Thu, Jan 12, 2017 at 04:38:27PM +0530, Prathamesh Kulkarni wrote: > > On 12 January 2017 at 16:15, Richard Biener wrote: > > > On Thu, 12 Jan 2017, Jakub Jelinek wrote: > > > > > >> On Thu, Jan 12, 2017 at 10:52:23AM +0100,

RE: [PATCH] MIPS: Fix generation of DIV.G and MOD.G for Loongson targets.

2017-01-12 Thread Toma Tabacu
> Maciej Rozycki writes: > > > > > Unfortunately, this interferes with the generation of DIV.G and MOD.G > > (the div3 and mod3 patterns) for Loongson targets, > which > > causes test failures. > > What test failures? Details please. > It's gcc.target/mips/loongson-muldiv-1.c

[Ada] Missing type invariant check on view conversion

2017-01-12 Thread Arnaud Charlet
This patch corrects an issue with "out" or "in out" arguments producing wrong code when the argument is view converted. According to RM 7.3.2 (11-14) invariant checks of intermediate types must be preformed in the order of the parent to the child (skipping the parent) after the subprogram. With

Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts

2017-01-12 Thread Chung-Lin Tang
[ping] Hi Jakub, I don't think we ever got approval for the Fortran parts of the OpenACC tile patch? Is this okay for trunk? I'll be committing all parts of the patch once the Fortran parts are approved. Thanks, Chung-Lin On 2016/12/14 04:37 PM, Chung-Lin Tang wrote: > On 2016/11/30 10:47

Re: [PATCH v2 C++] Fix PR70182 -- missing "on" in mangling of unresolved operators

2017-01-12 Thread Nathan Sidwell
On 01/12/2017 02:57 AM, Markus Trippelsdorf wrote: Thanks for the review. Here is a new patch: Thanks, that does address my comments. AFAICT your reading of the ABI doc is correct, but I'd like Jason to confirm that. you're missing the testsuite/ChangeLog entry, don't forget. nathan --

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 01:35:32PM +0100, Richard Biener wrote: > It also lacks expressiveness when comparing > > short s; > s_1 = (short) 1; > s_2 = short (1); > > IMHO having a _Literal somewhere makes it more obvious what is meant > (I'm still going to dump 1u or 1l instead of _Literal

Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts

2017-01-12 Thread Jakub Jelinek
On Tue, Nov 29, 2016 at 05:47:08PM -0800, Cesar Philippidis wrote: > On 11/18/2016 03:24 AM, Jakub Jelinek wrote: > > On Sat, Nov 12, 2016 at 08:51:00AM -0800, Cesar Philippidis wrote: > >> On 11/11/2016 02:34 AM, Jakub Jelinek wrote: > >>> On Thu, Nov 10, 2016 at 06:46:46PM +0800, Chung-Lin Tang

RE: [PATCH] MIPS: Fix generation of DIV.G and MOD.G for Loongson targets.

2017-01-12 Thread Matthew Fortune
Maciej Rozycki writes: > On Thu, 12 Jan 2017, Toma Tabacu wrote: > > > > > Unfortunately, this interferes with the generation of DIV.G and > > > > MOD.G (the div3 and mod3 patterns) for Loongson > > > > targets, > > > which > > > > causes test failures. > > > > > >

Re: [PATCH, rs6000] Fix PR79044 (ICE in swap optimization)

2017-01-12 Thread Bill Schmidt
> On Jan 11, 2017, at 5:36 PM, Segher Boessenkool > wrote: > > On Tue, Jan 10, 2017 at 02:18:38PM -0600, Bill Schmidt wrote: >> PR79044 reports a situation where swap optimization ICEs in GCC 6 and in >> trunk. The >> problem is that swap optimization doesn't

Re: [v3 PATCH] PR libstdc++/78389

2017-01-12 Thread Ville Voutilainen
On 13 January 2017 at 08:01, Tim Song wrote: > On Thu, Jan 12, 2017 at 8:11 PM, Ville Voutilainen > wrote: >> This patch doesn't try to fix the reported sort() issue, because >> a) it would require undoing a throwing move operation, which >>

Re: [PATCH 3/6] RISC-V Port: libgcc

2017-01-12 Thread Andrew Waterman
Thanks again for your feedback. On Thu, Jan 12, 2017 at 3:30 PM, Joseph Myers wrote: > On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > >> +riscv*-*-linux*) >> + tmake_file="${tmake_file} t-softfp-sfdf riscv/t-softfp${host_address} >> t-softfp riscv/t-elf

Re: [v3 PATCH] PR libstdc++/78389

2017-01-12 Thread Tim Song
On Fri, Jan 13, 2017 at 1:39 AM, Ville Voutilainen wrote: > On 13 January 2017 at 08:01, Tim Song wrote: >> On Thu, Jan 12, 2017 at 8:11 PM, Ville Voutilainen >> wrote: >>> This patch doesn't try to fix the

Re: [v3 PATCH] PR libstdc++/78389

2017-01-12 Thread Ville Voutilainen
On 13 January 2017 at 09:51, Tim Song wrote: >>> Wait, what throwing move? list::sort should be all splicing and no >>> moving, unless I missed something. >> >> It operates based on merge, which moves elements from one list to >> another using a throwing >> comparator.

Re: [patch,avr] PR78883: Implement a dummy scheduler

2017-01-12 Thread Richard Sandiford
Georg-Johann Lay writes: > On 12.01.2017 10:00, Richard Sandiford wrote: >> Georg-Johann Lay writes: >>> On 04.01.2017 20:29, Jeff Law wrote: On 01/04/2017 12:18 PM, Segher Boessenkool wrote: > On Wed, Jan 04, 2017 at 06:42:23PM +, Richard Sandiford

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Marc Glisse
On Thu, 12 Jan 2017, Richard Biener wrote: On Thu, 12 Jan 2017, Jakub Jelinek wrote: On Thu, Jan 12, 2017 at 01:35:32PM +0100, Richard Biener wrote: It also lacks expressiveness when comparing short s; s_1 = (short) 1; s_2 = short (1); IMHO having a _Literal somewhere makes it more

Re: [PATCH][ARM]Use different startfile and endfile for elf target when generating shared object.

2017-01-12 Thread Renlin Li
Hi Kugan, some of the targets do include pie, and use the same crtbegin file as shared object. For example, alpha/elf.h And there are targets which don't do that, For example, sh/elf.h Most of the elf target seem only consider the simple case. The purpose of this patch is to make it possible

[Ada] Adapt detection of errors to gnat2why changes of Warning_Mode

2017-01-12 Thread Arnaud Charlet
In gnat2why, the executable used in GNATprove, Warning_Mode is changed between the initial and final work done in frontend (controlled by -gnatws in particular) and the work in between done in gnat2why (controlled by GNATprove switch --warnings). This requires storing the detection of an error

[Ada] Conformance of quantified expressions

2017-01-12 Thread Arnaud Charlet
This patch implements AI12-050, which extends the conformance rules to Ada2012 quantified expressions. Previously the conformance of corresponding identifiers in the two expressions required that they denote the same entity. The loop parameters of two quantified expressions are conformant if the

[Ada] Inheritance of predicates in derived scalar types.

2017-01-12 Thread Arnaud Charlet
This patch fixes an omission in the inheritance of predicate aspects in type derivations. The parent type may be a subtype declaration or a type declaration with a dynamic predicate aspect, and the aspect applies to a first subtype, not to its anonymous parent type. Eecuting: gnatmake -q

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 04:45:41PM +0100, Marc Glisse wrote: > > On Thu, 12 Jan 2017, Jakub Jelinek wrote: > > > > > On Thu, Jan 12, 2017 at 01:35:32PM +0100, Richard Biener wrote: > > > > It also lacks expressiveness when comparing > > > > > > > > short s; > > > > s_1 = (short) 1; > > > >

[PATCH] Introduce --with-gcc-major-version-only configure option (take 2)

2017-01-12 Thread Jakub Jelinek
Hi! On Tue, Jan 10, 2017 at 07:56:36AM +0100, Jakub Jelinek wrote: > As I said on IRC, I think -dumpversion of 7 in this configuration is the > right thing to do. In GCC sources, we have 3 uses of -dumpversion, > two of them look like: > gcc_version := $(shell $(GOC) -dumpversion) > ... >

[PATCH] Emit DW_AT_data_bit_offset instead of DW_AT_{data_member_location,bit_offset,byte_size} for -gdwarf-5 (PR debug/71669)

2017-01-12 Thread Jakub Jelinek
Hi! While DW_AT_data_bit_offset has been introduced already in DWARF4, GDB only gained support for it last November, so I think it is better to enable this only for -gdwarf-5 for now and we can reconsider it in a year or two. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

Re: [patch] update zlib to the 1.2.10 release.

2017-01-12 Thread Jeff Law
On 01/05/2017 07:45 AM, Matthias Klose wrote: These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when building without a system zlib. The new release includes fixes for security issues CVE-2016-9840, CVE-2016-9841, CVE-2016-9842, CVE-2016-9843. Checked with a build with

Re: [PATCH] builtin expansion of strncmp for rs6000

2017-01-12 Thread Segher Boessenkool
On Thu, Jan 12, 2017 at 05:53:06PM +, Joseph Myers wrote: > On Thu, 15 Dec 2016, Aaron Sawdey wrote: > > > + emit_library_call_value (gen_rtx_SYMBOL_REF (Pmode, "strncmp"), > > + target, LCT_NORMAL, GET_MODE (target), 3, > > + force_reg

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Joseph Myers
On Thu, 12 Jan 2017, Jakub Jelinek wrote: > Well, we need some suffix that will not clash with C++ mandated udlits > very soon, it is already bad that i and Q suffixes are problematic. > By sN, did you mean s128 or literally sN? > I've googled around a little bit and only found comments about >

Re: [PATCH, Fortran, pr70697, v1] [Coarray] ICE on EVENT WAIT with array element UNTIL_COUNT argument

2017-01-12 Thread Jerry DeLisle
On 01/12/2017 05:43 AM, Andre Vehreschild wrote: > Hi all, > > *** this is no duplicate, but +1 in the PR#! *** > > attached patch fixes the ICE by resolving the expression in UNTIL_COUNT > correctly. The ICE was caused by the array-specification in UNTIL_COUNT not > correctly set. > >

Re: [RFC] combine: Handle zero_extend without subreg in change_zero_ext.

2017-01-12 Thread Dominik Vogt
On Thu, Jan 12, 2017 at 11:02:36AM -0600, Segher Boessenkool wrote: > Hi Dominik, > > Thanks for the example. ROSBG, what a weird instruction. > > On Thu, Jan 05, 2017 at 05:46:51PM +0100, Dominik Vogt wrote: > > --- a/gcc/combine.c > > +++ b/gcc/combine.c > > @@ -11372,6 +11372,16 @@

Re: New Port for RISC-V

2017-01-12 Thread Joseph Myers
General observation: I see no documentation (no changes to .texi files) anywhere in this patch series. I also don't see updates to config-list.mk to add RISC-V targets to the set that builds. (You should make sure the port builds cleanly when built with current mainline GCC and configured

[PATCH][GCC 5] Fix build issue with NO_FUNCTION_CSE

2017-01-12 Thread Kyrill Tkachov
Hi all, This patch fixes the build issue on x86_64 (and other targets that define NO_FUNCTION_CSE but not a particular value) on the GCC 5 branch. Tested on x86_64. Committing to the branch in the interest of fixing the build. Thanks, Kyrill 2016-01-12 Kyrylo Tkachov

[Ping~]Re: [5/5][AArch64, libgcc] Runtime support for AArch64 return address signing (also attached target macros version)

2017-01-12 Thread Jiong Wang
On 06/01/17 11:47, Jiong Wang wrote: This is the update on libgcc unwinder support according to new DWARF proposal. As Joseph commented, duplication of unwind-dw2.c is not encouraged in libgcc, But from this patch, you can see there are a few places we need to modify for AArch64 in

Re: [PATCH, Fortran, pr70696, v1] [Coarray] ICE on EVENT POST of host-associated EVENT_TYPE coarray

2017-01-12 Thread Jerry DeLisle
On 01/12/2017 03:45 AM, Andre Vehreschild wrote: > Hi all, > > attached patch fixes the ICE when using an event in a subroutine. The reason > for the ICE was that the backend_decl of the symbol to event on was not set > when accessed. The patch ensures this. Furthermore did I fix a invalid memory

[PATCH] Add Cortex-A15 tuning to gcc.dg/uninit-pred-8_a.c

2017-01-12 Thread Kyrill Tkachov
Hi all, As discussed in the PR it's better to pin down the tuning for arm targets on this test so that the BRANCH_COST remains constant. This makes the test more stable across toolchains configured for different default CPUs. Ok to apply? Thanks, Kyrill 2017-01-12 Kyrylo Tkachov

Re: [PATCH] Fix DW_AT_data_member_location/DW_AT_bit_offset handling (PR debug/78839)

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 05:42:55PM +0100, Pierre-Marie de Rodat wrote: > > + object_offset_in_bytes > > + = wi::lrshift (object_offset_in_bits, LOG2_BITS_PER_UNIT); > > + if (ctx->variant_part_offset == NULL_TREE) > > + { > > + *cst_offset = object_offset_in_bytes.to_shwi (); > >

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-12 Thread Jonathan Wakely
On 11/01/17 13:25 +, Jonathan Wakely wrote: On 11/01/17 08:04 -0500, Tim Song wrote: On Wed, Jan 11, 2017 at 7:21 AM, Jonathan Wakely wrote: This patch uses the _Enable_default_constructor mixin to properly delete the default constructors. It's a bit cumbersome,

Re: [PATCH] builtin expansion of strncmp for rs6000

2017-01-12 Thread Joseph Myers
On Thu, 15 Dec 2016, Aaron Sawdey wrote: > + emit_library_call_value (gen_rtx_SYMBOL_REF (Pmode, "strncmp"), > +target, LCT_NORMAL, GET_MODE (target), 3, > +force_reg (Pmode, XEXP (src1, 0)), Pmode, > +

Re: [PATCH] Fix DW_AT_data_member_location/DW_AT_bit_offset handling (PR debug/78839)

2017-01-12 Thread Pierre-Marie de Rodat
Jakub, On 01/11/2017 09:19 PM, Jakub Jelinek wrote: In GCC 5 and earlier, field_byte_offset had code for PCC_BITFIELD_TYPE_MATTERS target that figured out what DW_AT_data_member_location value to use vs. DW_AT_bit_offset. That code is still in there, but due to several bugs added in r231762 it

Re: [PATCH][GIMPLE FE] Add parsing of MEM_REFs

2017-01-12 Thread Richard Biener
On January 12, 2017 4:53:54 PM GMT+01:00, Jakub Jelinek wrote: >On Thu, Jan 12, 2017 at 04:45:41PM +0100, Marc Glisse wrote: >> > On Thu, 12 Jan 2017, Jakub Jelinek wrote: >> > >> > > On Thu, Jan 12, 2017 at 01:35:32PM +0100, Richard Biener wrote: >> > > > It also lacks

Re: [PATCH] Add Cortex-A15 tuning to gcc.dg/uninit-pred-8_a.c

2017-01-12 Thread Jakub Jelinek
On Thu, Jan 12, 2017 at 04:56:11PM +, Kyrill Tkachov wrote: > Hi all, > > As discussed in the PR it's better to pin down the tuning for arm targets on > this test so that the BRANCH_COST remains constant. > This makes the test more stable across toolchains configured for different > default

Re: [RFC] combine: Handle zero_extend without subreg in change_zero_ext.

2017-01-12 Thread Segher Boessenkool
Hi Dominik, Thanks for the example. ROSBG, what a weird instruction. On Thu, Jan 05, 2017 at 05:46:51PM +0100, Dominik Vogt wrote: > --- a/gcc/combine.c > +++ b/gcc/combine.c > @@ -11372,6 +11372,16 @@ change_zero_ext_src (subrtx_ptr_iterator *piter) >else if (GET_CODE (x) == ZERO_EXTEND >

[PATCH, i386 testsuite]: Check all supported __builtin_cpu_supports options

2017-01-12 Thread Uros Bizjak
Hello! Attached patch checks all supported __builtin_cpu_supports options. Additionally, it adds a couple of comments and moves some code to prevent future mistakes. 2017-01-12 Uros Bizjak * gcc.target/i386/builtin_target.c (check_features): Check all supported

Re: [patch,avr] PR78883: Implement a dummy scheduler

2017-01-12 Thread Georg-Johann Lay
Richard Sandiford schrieb: Georg-Johann Lay writes: On 12.01.2017 10:00, Richard Sandiford wrote: Georg-Johann Lay writes: On 04.01.2017 20:29, Jeff Law wrote: On 01/04/2017 12:18 PM, Segher Boessenkool wrote: On Wed, Jan 04, 2017 at 06:42:23PM +, Richard

  1   2   >